goldencobra 1.4.0 → 1.4.27

data/app/controllers/goldencobra/sessions_controller.rb

@@ -4,6 +4,7 @@ module Goldencobra
   class SessionsController < Goldencobra::ApplicationController
     layout "application"
 
+
     def login
       @errors = []
       if params[:usermodel] && params[:usermodel].constantize && params[:usermodel].constantize.present? && params[:usermodel].constantize.attribute_method?(:email)
@@ -20,6 +21,7 @@ module Goldencobra
           @usermodel.sign_in_count = @usermodel.sign_in_count.to_i + 1
           @usermodel.last_sign_in_at = Time.now
           @usermodel.save
+          flash[:notice] = I18n.translate("signed_in", :scope => ["devise", "sessions"])
           @redirect_to = @usermodel.roles.try(:first).try(:redirect_after_login)
         else
           @usermodel.failed_attempts = @usermodel.failed_attempts.to_i + 1
@@ -36,8 +38,13 @@ module Goldencobra
       if params[:usermodel] && params[:usermodel].constantize && params[:usermodel].constantize.present? && params[:usermodel].constantize.attribute_method?(:email)
         sign_out
         reset_session
+        flash[:notice] = I18n.translate("signed_out", :scope => ["devise", "sessions"])
+      end
+      if request.format == "html"
+        redirect_to "/"
+      else
+        render :js => "window.location.href = '/';"
       end
-      render :js => "window.location.href = '/';"
     end
 
 

data/app/helpers/goldencobra/application_helper.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 module Goldencobra
   module ApplicationHelper
     include Goldencobra::ArticlesHelper
@@ -14,7 +16,7 @@ module Goldencobra
       user_mod = Goldencobra::Setting.for_key("goldencobra.bugherd.user")
       role_mod = Goldencobra::Setting.for_key("goldencobra.bugherd.role")
       bugherd_api = Goldencobra::Setting.for_key("goldencobra.bugherd.api")
-      if bugherd_api.present? && user_mod.present? && role_mod.present? && eval("#{user_mod} && #{user_mod}.present? && #{user_mod}.has_role?('#{role_mod}')")
+      if bugherd_api.present? && user_mod.present? && role_mod.present? && eval("!defined?(#{user_mod}).nil? && #{user_mod} && #{user_mod}.present? && #{user_mod}.has_role?('#{role_mod}')")
         render :partial => "goldencobra/articles/bugherd", :locals => {:bugherd_api => bugherd_api}
       end
     end

data/app/helpers/goldencobra/articles_helper.rb

@@ -9,9 +9,9 @@ module Goldencobra
     def read_on(article)
       target_window = article.redirection_target_in_new_window ? "_blank" : "_top"
       if article.redirect_link_title.present?
-        link_to article.redirect_link_title, article.external_url_redirect, :class => 'more', :target => target_window
+        link_to article.redirect_link_title, article.external_url_redirect, :class => "more", :target => target_window
       else
-        link_to t(:read_on, scope: [:articles]), article.public_url, :class => 'more', :target => target_window
+        link_to t(:read_on, scope: [:articles]), article.public_url, :class => "more", :target => target_window, :title => article.title
       end
     end
 
@@ -72,10 +72,12 @@ module Goldencobra
     end
 
     def render_article_type_content(options={})
-      if @article && @article.article_type.present? && @article.kind_of_article_type.present?
-        render :partial => "articletypes/#{@article.article_type_form_file.underscore.parameterize.downcase}/#{@article.kind_of_article_type.downcase}"
-      else
-        render :partial => "articletypes/default/show"
+      if @article
+        if @article.article_type.present? && @article.kind_of_article_type.present?
+         render :partial => "articletypes/#{@article.article_type_form_file.underscore.parameterize.downcase}/#{@article.kind_of_article_type.downcase}"
+        else
+          render :partial => "articletypes/default/show"
+        end
       end
     end
 
@@ -90,8 +92,12 @@ module Goldencobra
         #Wenn format email, dann gibt es keinen realen webseit besucher
         ability = Ability.new()
       else
-        operator = current_user || current_visitor
-        ability = Ability.new(operator)
+        if !defined?(current_user).nil? || !defined?(current_visitor).nil?
+          operator = current_user || current_visitor
+          ability = Ability.new(operator)
+        else
+          ability = Ability.new()
+        end
       end
       if @article
         widgets = @article.widgets.active

data/app/middleware/goldencobra/handle_invalid_percent_encoding.rb

@@ -0,0 +1,40 @@
+require 'rack'
+require 'logger'
+module Goldencobra
+  class HandleInvalidPercentEncoding
+    DEFAULT_CONTENT_TYPE = 'text/html'
+    DEFAULT_CHARSET      = 'utf-8'
+
+    attr_reader :logger
+    def initialize(app, stdout=STDOUT)
+      @app = app
+      @logger = defined?(Rails.logger) ? Rails.logger : Logger.new(stdout)
+    end
+
+    def call(env)
+      begin
+        # calling env.dup here prevents bad things from happening
+        request = Rack::Request.new(env.dup)
+        # calling request.params is sufficient to trigger the error
+        # see https://github.com/rack/rack/issues/337#issuecomment-46453404
+        request.params
+        @app.call(env)
+      rescue ArgumentError => e
+        raise unless e.message =~ /invalid %-encoding/
+        message = "BAD REQUEST: Returning 400 due to #{e.message} from request with env #{request.inspect}"
+        logger.info message
+        content_type = env['HTTP_ACCEPT'] || DEFAULT_CONTENT_TYPE
+        status = 400
+        body   = "Bad Request"
+        return [
+          status,
+          {
+            'Content-Type' => "#{content_type}; charset=#{DEFAULT_CHARSET}",
+            'Content-Length' => body.bytesize.to_s
+          },
+          [body]
+        ]
+      end
+    end
+  end
+end

data/app/models/ability.rb

@@ -3,78 +3,73 @@
 class Ability
   include CanCan::Ability
 
-  def initialize(operator=nil)
+  def initialize(operator=nil,current_domain=nil)
     can :read, Goldencobra::Article
     can :read, Goldencobra::Menue
     can :read, Goldencobra::Widget
 
     #Rechte die alle betreffen
     Goldencobra::Permission.where("action IS NOT NULL").where("role_id IS NULL OR role_id = ''").each do |permission|
-      if permission.subject_id.blank?
-        if permission.action.include?("not_")
-          cannot permission.action.gsub("not_", "").to_sym, permission.subject_class.constantize
-        else
-          can permission.action.to_sym, permission.subject_class.constantize
-        end
-      else
-        if permission.action.include?("not_")
-          cannot permission.action.gsub("not_", "").to_sym, permission.subject_class.constantize, :id => permission.subject_id.to_i
-          set_child_permissions("cannot",permission.action.gsub("not_", "").to_sym, permission.subject_class.constantize,permission.subject_id.to_i)
-        else
-          can permission.action.to_sym, permission.subject_class.constantize, :id => permission.subject_id.to_i
-          set_child_permissions("can",permission.action.to_sym, permission.subject_class.constantize,permission.subject_id.to_i)
-        end
-      end
+      set_permission(permission,current_domain)
     end
 
     #Rechte, die nur bestimmte nutzerrollen betreffen
     if operator && operator.respond_to?(:roles)
       operator.roles.each do |role|
         role.permissions.each do |permission|
-
-          if permission.subject_class == ":all"
-            if permission.action.include?("not_")
-              cannot permission.action.gsub("not_", "").to_sym, :all
-            else
-              can permission.action.to_sym, :all
-            end
-          end
-
-          if !permission.subject_class.include?(":all") && permission.subject_id.blank?
-            if permission.action.include?("not_")
-              cannot permission.action.gsub("not_", "").to_sym, permission.subject_class.constantize
-            else
-              can permission.action.to_sym, permission.subject_class.constantize
-            end
-          end
-
-          if !permission.subject_class.include?(":all") && permission.subject_id.present?
-            if permission.action.include?("not_")
-              cannot permission.action.to_s.gsub("not_", "").to_sym, permission.subject_class.constantize, :id => permission.subject_id.to_i
-              set_child_permissions("cannot",permission.action.gsub("not_", "").to_sym, permission.subject_class.constantize,permission.subject_id.to_i)
+          if check_for_domain_restrictions(permission,current_domain)
+            if permission.subject_class == ":all"
+                if permission.action.include?("not_")
+                  cannot permission.action.gsub("not_", "").to_sym, :all
+                else
+                  can permission.action.to_sym, :all
+                end
             else
-              can permission.action.to_sym, permission.subject_class.constantize, :id => permission.subject_id.to_i
-              set_child_permissions("can",permission.action.to_sym, permission.subject_class.constantize,permission.subject_id.to_i)
+              set_permission(permission,current_domain)
             end
           end
         end
       end
     end
-
   end
 
-  def set_child_permissions(able,action_name, model_name,id_name)
-    if able == "can" && model_name.new.respond_to?(:descendant_ids) && object = model_name.find_by_id(id_name)
-      object.descendant_ids.each do |child_id|
-        can action_name, model_name, :id => child_id
+  def set_permission(permission,current_domain)
+    able = 'can'
+    action_name = permission.action.to_sym
+    model_name = permission.subject_class.constantize
+
+    if permission.action.include?("not_")
+      action_name = permission.action.gsub("not_", "").to_sym
+      able = 'cannot'
+    end
+
+    if check_for_domain_restrictions(permission,current_domain)
+      if permission.subject_id.present?
+        set_ability(able, action_name, model_name, permission.subject_id.to_i)
+        set_child_permissions(able, action_name, model_name, permission.subject_id.to_i)
+      else
+        set_ability(able, action_name, model_name)
       end
     end
-    if able == "cannot" && model_name.new.respond_to?(:descendant_ids) && object = model_name.find_by_id(id_name)
+  end
+
+  def set_ability(able, action_name, model_name, id_name=nil)
+    if id_name.present?
+      send(able, action_name, model_name, id: id_name)
+    else
+      send(able, action_name, model_name)
+    end
+  end
+
+  def set_child_permissions(able, action_name, model_name,id_name)
+    if %w(can cannot).include?(able) && model_name.new.respond_to?(:descendant_ids) && object = model_name.find_by_id(id_name)
       object.descendant_ids.each do |child_id|
-        cannot action_name, model_name, :id => child_id
+        set_ability(able, action_name, model_name, child_id)
       end
     end
-
   end
 
-end
+  def check_for_domain_restrictions(permission,domain)
+    permission.domain.blank? || (domain.present? && permission.domain.present? && permission.domain == domain)
+  end
+end

data/app/models/goldencobra/article.rb

@@ -53,16 +53,17 @@ require "open-uri"
 
 module Goldencobra
   class Article < ActiveRecord::Base
+
     extend FriendlyId
     MetatagNames = ["Title Tag", "Meta Description", "Keywords", "OpenGraph Title", "OpenGraph Description", "OpenGraph Type", "OpenGraph URL", "OpenGraph Image"]
     LiquidParser = {}
-    SortOptions = ["Created_at", "Updated_at", "Random", "Alphabetically"]
+    SortOptions = ["Created_at", "Updated_at", "Random", "Alphabetically", "GlobalSortID"]
     DynamicRedirectOptions = [[:false,"deaktiviert"],[:latest,"neuester Untereintrag"], [:oldest, "ältester Untereintrag"]]
     DisplayIndexTypes = [["Einzelseiten", "show"],["Übersichtsseiten", "index"], ["Alle Seiten", "all"]]
-    attr_accessor   :hint_label, :manual_article_sort
+    attr_accessor   :hint_label, :manual_article_sort, :create_redirection
     ImportDataFunctions = []
 
-    serialize :link_checker, Hash
+    serialize :link_checker#, Hash
 
     has_many :metatags
     has_many :images, :through => :article_images, :class_name => Goldencobra::Upload
@@ -73,14 +74,15 @@ module Goldencobra
     has_many :comments, :class_name => Goldencobra::Comment
     has_many :permissions, :class_name => Goldencobra::Permission, :foreign_key => "subject_id", :conditions => {:subject_class => "Goldencobra::Article"}
     belongs_to :articletype, :class_name => Goldencobra::Articletype, :foreign_key => "article_type", :primary_key => "name"
+    belongs_to :creator, :class_name => User, :foreign_key => "creator_id"
 
-    belongs_to :author
+    has_many :article_authors
+    has_many :authors, :through => :article_authors
 
     accepts_nested_attributes_for :metatags, :allow_destroy => true, :reject_if => proc { |attributes| attributes['value'].blank? }
     accepts_nested_attributes_for :article_images, :allow_destroy => true
     accepts_nested_attributes_for :images, :allow_destroy => true
     accepts_nested_attributes_for :permissions, :allow_destroy => true
-    accepts_nested_attributes_for :author, :allow_destroy => true
 
     acts_as_taggable_on :tags, :frontend_tags #https://github.com/mbleigh/acts-as-taggable-on
     has_ancestry    :orphan_strategy => :restrict
@@ -90,21 +92,26 @@ module Goldencobra
     liquid_methods :title, :created_at, :updated_at, :subtitle, :context_info, :id, :frontend_tags
 
     validates_presence_of :title, :article_type
-    validates_format_of :url_name, :with => /\A[\w\d-]+\Z/, allow_blank: true
+    validates_format_of :url_name, :with => /\A[\w\-]+\Z/, allow_blank: true
     validates_presence_of :breadcrumb, :on => :create
     validates_length_of :breadcrumb, :within => 1..70, :on => :create
 
+    attr_protected :startpage
+
+    before_update :set_redirection_step_1
     after_create :set_active_since
     after_create :notification_event_create
+    after_create :cleanup_redirections
     before_save :parse_image_gallery_tags
     before_save :set_url_name_if_blank
     before_save :set_standard_application_template
     after_save :set_default_meta_opengraph_values
     after_save :verify_existence_of_opengraph_image
     after_update :notification_event_update
+    after_update :update_parent_article_etag
+    after_save :set_url_path
     before_destroy :update_parent_article_etag
-
-    attr_protected :startpage
+    after_update :set_redirection_step_2
 
     scope :robots_index, where(:robots_no_index => false)
     scope :robots_no_index, where(:robots_no_index => true)
@@ -116,18 +123,20 @@ module Goldencobra
     scope :parent_ids_in_eq, lambda { |art_id| subtree_of(art_id) }
     scope :parent_ids_in, lambda { |art_id| subtree_of(art_id) }
     scope :modified_since, lambda{ |date| where("updated_at > ?", Date.parse(date))}
-    scope :for_sitemap, where('dynamic_redirection = "false" AND ( external_url_redirect IS NULL OR external_url_redirect = "") AND active = 1 AND robots_no_index =  0')
+    scope :for_sitemap, includes(:images).where('dynamic_redirection = "false" AND ( external_url_redirect IS NULL OR external_url_redirect = "") AND active = 1 AND robots_no_index =  0')
     scope :frontend_tag_name_contains, lambda{|tag_name| tagged_with(tag_name.split(","), :on => :frontend_tags)}
     scope :tag_name_contains, lambda{|tag_name| tagged_with(tag_name.split(","), :on => :tags)}
     if ActiveRecord::Base.connection.table_exists?("goldencobra_metatags")
       scope :no_title_tag, where("goldencobra_articles.id NOT IN (?)", Goldencobra::Metatag.where(:name => "Title Tag").where("value IS NOT NULL AND value <> ''").pluck(:article_id).uniq)
       scope :no_meta_description, where("goldencobra_articles.id NOT IN (?)", Goldencobra::Metatag.where(:name => "Meta Description").where("value IS NOT NULL AND value <> ''").pluck(:article_id).uniq)
     end
+    scope :fulltext_contains, lambda{ |name| where("content LIKE '%#{name}%' OR teaser LIKE '%#{name}%' OR url_name LIKE '%#{name}%' OR subtitle LIKE '%#{name}%' OR summary LIKE '%#{name}%' OR context_info LIKE '%#{name}%' OR breadcrumb LIKE '%#{name}%'")}
 
     search_methods :frontend_tag_name_contains
     search_methods :tag_name_contains
     search_methods :parent_ids_in
     search_methods :parent_ids_in_eq
+    search_methods :fulltext_contains
 
     if ActiveRecord::Base.connection.table_exists?("goldencobra_settings")
       if Goldencobra::Setting.for_key("goldencobra.use_solr") == "true"
@@ -152,98 +161,6 @@ module Goldencobra
     # **************************
     # **************************
 
-    def parent_path
-      self.path.map(&:title).join(" / ")
-    end
-
-    #scope for index articles, display show articles, index articless or both articles of an current type
-    def self.articletype_for_index(current_article)
-      if current_article.display_index_types == "show"
-        articletype("#{current_article.article_type_form_file} Show")
-      elsif current_article.display_index_types == "index"
-        articletype("#{current_article.article_type_form_file} Index")
-      else
-        where("article_type = '#{current_article.article_type_form_file} Show' OR article_type = '#{current_article.article_type_form_file} Index'")
-      end
-    end
-
-    def render_html(layoutfile="application", localparams={})
-      av = ActionView::Base.new(ActionController::Base.view_paths + ["#{::Goldencobra::Engine.root}/app/views/goldencobra/articles/"])
-      av.request = ActionDispatch::Request.new(Rack::MockRequest.env_for(self.public_url))
-      av.request["format"] = "text/html"
-      av.controller = Goldencobra::ArticlesController.new
-      av.controller.request = av.request
-      av.params.merge!(localparams[:params])
-      av.assign({:article => self})
-      html_to_render = av.render(template: "/goldencobra/articles/show.html.erb", :layout => "layouts/#{layoutfile}", :locals => localparams, :content_type => "text/html" )
-      return html_to_render
-    end
-
-
-    #get all links of a page and make a check for response status and time
-    def set_link_checker
-      links_to_check = []
-      status_for_links = {}
-      doc = Nokogiri::HTML(open(self.absolute_public_url))
-      #find all links and stylesheets
-      doc.css('a,link').each do |link|
-        if add_link_to_checklist(link, "href").present?
-          links_to_check << {"link" => add_link_to_checklist(link, "href"), "pos" => link.path}
-        end
-      end
-      #find all images and javascripts
-      doc.css('img,script').each do |link|
-        if add_link_to_checklist(link,"src").present?
-          links_to_check << {"link" => add_link_to_checklist(link,"src"), "pos" => link.path}
-        end
-      end
-      links_to_check = links_to_check.compact.delete_if{|a| a.blank?}
-      links_to_check.each_with_index do |linkpos|
-        status_for_links[linkpos["link"]] = {"position" => linkpos["pos"]}
-        begin
-          start = Time.now
-          response = open(linkpos["link"])
-          status_for_links[linkpos["link"]]["response_code"] = response.status[0]
-          status_for_links[linkpos["link"]]["response_time"] = Time.now - start
-        rescue Exception  => e
-          status_for_links[linkpos["link"]]["response_code"] = "404"
-          status_for_links[linkpos["link"]]["response_error"] = e.to_s
-        end
-      end
-      self.link_checker = status_for_links
-    end
-
-    #helper method for finding links in html document
-    def add_link_to_checklist(link, src_type)
-      begin
-        if link.blank? || link[src_type].blank?
-          return nil
-        elsif link[src_type][0 .. 6] == "http://" || link[src_type][0 .. 6] == "https:/"
-          return "#{link[src_type]}"
-        elsif link[src_type] && link[src_type][0 .. 1] == "//"
-          return "http:/#{link[src_type][/.(.*)/m,1]}"
-        elsif link[src_type] && link[src_type][0] == "/"
-          return "#{Goldencobra::Setting.absolute_base_url}/#{link[src_type][/.(.*)/m,1]}"
-        elsif link[src_type] && !link[src_type].include?("mailto:")
-          return "#{self.absolute_public_url}/#{link[src_type]}"
-        end
-      rescue
-        return nil
-      end
-    end
-
-    def comments_of_subarticles
-      Goldencobra::Comment.where("article_id in (?)", self.subtree_ids)
-    end
-
-    def find_related_subarticle
-      if self.dynamic_redirection == "latest"
-        self.descendants.order("id DESC").first
-      else
-        self.descendants.order("id ASC").first
-      end
-    end
-
 
     #Das ist der Titel, der verwendet wird, wenn daraus ein Menüpunkt erstellt werden soll.
     #der menue.title hat folgende vorgaben: validates_format_of :title, :with => /^[\w\d\?\.\'\!\s&üÜöÖäÄß\-\:\,\"]+$/
@@ -255,7 +172,7 @@ module Goldencobra
     #@article.image_standard @article.image_logo @article.image_logo_medium
     def self.init_image_methods
       if ActiveRecord::Base.connection.table_exists?("goldencobra_settings")
-        Goldencobra::Setting.for_key("goldencobra.article.image_positions").split(",").map(&:strip).each do |image_type|
+        Goldencobra::Setting.for_key("goldencobra.article.image_positions").to_s.split(",").map(&:strip).each do |image_type|
           define_method "image_#{image_type.underscore}" do
             self.image(image_type,"original")
           end
@@ -312,66 +229,6 @@ module Goldencobra
       end
     end
 
-    def index_articles(current_operator=nil, user_frontend_tags=nil)
-      if self.article_for_index_id.blank?
-        #Index aller Artikel anzeigen
-        @list_of_articles = Goldencobra::Article.active.articletype_for_index(self)
-      else
-        #Index aller Artikel anzeigen, die Kinder sind von einem Bestimmten artikel
-        parent_article = Goldencobra::Article.find_by_id(self.article_for_index_id)
-        if parent_article
-          @list_of_articles = parent_article.descendants.active.articletype_for_index(self)
-        else
-          @list_of_articles = Goldencobra::Article.active.articletype_for_index(self)
-        end
-      end
-      #include related models
-      @list_of_articles = @list_of_articles.includes("#{self.article_type_form_file.underscore.parameterize.downcase}") if self.respond_to?(self.article_type_form_file.underscore.parameterize.downcase)
-      #get articles with tag
-      if self.index_of_articles_tagged_with.present?
-        @list_of_articles = @list_of_articles.tagged_with(self.index_of_articles_tagged_with.split(",").map{|t| t.strip}, on: :tags, any: true)
-      end
-      #get articles without tag
-      if self.not_tagged_with.present?
-        @list_of_articles = @list_of_articles.tagged_with(self.not_tagged_with.split(",").map{|t| t.strip}, :exclude => true, on: :tags)
-      end
-      #get_articles_by_frontend_tags
-      if user_frontend_tags.present?
-        @list_of_articles = @list_of_articles.tagged_with(user_frontend_tags, on: :frontend_tags, any: true)
-      end
-      #filter with permissions
-      @list_of_articles = filter_with_permissions(@list_of_articles,current_operator)
-
-      #sort list of articles
-      if self.sort_order.present?
-        if self.sort_order == "Random"
-          @list_of_articles = @list_of_articles.flatten.shuffle
-        elsif self.sort_order == "Alphabetical"
-          @list_of_articles = @list_of_articles.flatten.sort_by{|article| article.title }
-        elsif self.respond_to?(self.sort_order.downcase)
-          sort_order = self.sort_order.downcase
-          @list_of_articles = @list_of_articles.flatten.sort_by{|article| article.respond_to?(sort_order) ? article.send(sort_order) : article }
-        elsif self.sort_order.include?(".")
-          sort_order = self.sort_order.downcase.split(".")
-          @unsortable = @list_of_articles.flatten.select{|a| !a.respond_to_all?(self.sort_order) }
-          @list_of_articles = @list_of_articles.flatten.delete_if{|a| !a.respond_to_all?(self.sort_order) }
-          @list_of_articles = @list_of_articles.sort_by{|a| eval("a.#{self.sort_order}") }
-          if @unsortable.count > 0
-            @list_of_articles = @unsortable + @list_of_articles
-            @list_of_articles = @list_of_articles.flatten
-          end
-        end
-        if self.reverse_sort
-          @list_of_articles = @list_of_articles.reverse
-        end
-      end
-      if self.sorter_limit && self.sorter_limit > 0
-        @list_of_articles = @list_of_articles[0..self.sorter_limit-1]
-      end
-
-      return @list_of_articles
-    end
-
 
     # Methode filtert die @list_of_articles.
     # Rückgabewert: Ein Array all der Artikel, die der operator lesen darf.
@@ -410,22 +267,6 @@ module Goldencobra
       end
     end
 
-    def public_url(with_prefix=true)
-      if self.startpage
-        if with_prefix
-          return "#{Goldencobra::Domain.current.try(:url_prefix)}/"
-        else
-          return "/"
-        end
-      else
-        a_url = "/#{self.path.select([:ancestry, :url_name, :startpage]).map{|a| a.url_name if !a.startpage}.compact.join("/")}"
-        if with_prefix
-          return "#{Goldencobra::Domain.current.try(:url_prefix)}#{a_url}"
-        else
-          return a_url
-        end
-      end
-    end
 
     def date_of_last_modified_child
       if self.children.length > 0
@@ -439,31 +280,6 @@ module Goldencobra
       end
     end
 
-    def absolute_base_url
-      if Goldencobra::Setting.for_key("goldencobra.use_ssl") == "true"
-        "https://#{Goldencobra::Setting.for_key('goldencobra.url')}"
-      else
-        "http://#{Goldencobra::Setting.for_key('goldencobra.url')}"
-      end
-    end
-
-    def absolute_public_url
-      if Goldencobra::Setting.for_key("goldencobra.use_ssl") == "true"
-        "https://#{Goldencobra::Setting.for_key('goldencobra.url')}#{self.public_url}"
-      else
-        "http://#{Goldencobra::Setting.for_key('goldencobra.url')}#{self.public_url}"
-      end
-    end
-
-    def for_friendly_name
-      if self.url_name.present?
-        self.url_name
-      elsif self.breadcrumb.present?
-        self.breadcrumb
-      else
-        self.title
-      end
-    end
 
     # Gibt Consultant | Subsidiary | etc. zurück je nach Seitentyp
     def article_type_form_file
@@ -562,6 +378,116 @@ module Goldencobra
 
     end
 
+    def author
+      self.try(:authors).try(:first)
+    end
+
+    # **************************
+    # **************************
+    # Index Methods
+    # **************************
+    # **************************
+
+
+    #scope for index articles, display show articles, index articless or both articles of an current type
+    def self.articletype_for_index(current_article)
+      if current_article.display_index_types == "show"
+        articletype("#{current_article.article_type_form_file} Show")
+      elsif current_article.display_index_types == "index"
+        articletype("#{current_article.article_type_form_file} Index")
+      else
+        where("article_type = '#{current_article.article_type_form_file} Show' OR article_type = '#{current_article.article_type_form_file} Index'")
+      end
+    end
+
+    def render_html(layoutfile="application", localparams={})
+      av = ActionView::Base.new(ActionController::Base.view_paths + ["#{::Goldencobra::Engine.root}/app/views/goldencobra/articles/"])
+      av.request = ActionDispatch::Request.new(Rack::MockRequest.env_for(self.public_url))
+      av.request["format"] = "text/html"
+      av.controller = Goldencobra::ArticlesController.new
+      av.controller.request = av.request
+      if localparams.present? && localparams[:params].present?
+        av.params.merge!(localparams[:params])
+      end
+      av.assign({:article => self})
+      html_to_render = av.render(template: "/goldencobra/articles/show.html.erb", :layout => "layouts/#{layoutfile}", :locals => localparams, :content_type => "text/html" )
+      return html_to_render
+    end
+
+    def comments_of_subarticles
+      Goldencobra::Comment.where("article_id in (?)", self.subtree_ids)
+    end
+
+    def find_related_subarticle
+      if self.dynamic_redirection == "latest"
+        self.descendants.order("id DESC").first
+      else
+        self.descendants.order("id ASC").first
+      end
+    end
+
+
+    def index_articles(current_operator=nil, user_frontend_tags=nil)
+      if self.article_for_index_id.blank?
+        #Index aller Artikel anzeigen
+        @list_of_articles = Goldencobra::Article.active.articletype_for_index(self)
+      else
+        #Index aller Artikel anzeigen, die Kinder sind von einem Bestimmten artikel
+        parent_article = Goldencobra::Article.find_by_id(self.article_for_index_id)
+        if parent_article
+          @list_of_articles = parent_article.descendants.active.articletype_for_index(self)
+        else
+          @list_of_articles = Goldencobra::Article.active.articletype_for_index(self)
+        end
+      end
+      #include related models
+      @list_of_articles = @list_of_articles.includes("#{self.article_type_form_file.underscore.parameterize.downcase}") if self.respond_to?(self.article_type_form_file.underscore.parameterize.downcase)
+      #get articles with tag
+      if self.index_of_articles_tagged_with.present?
+        @list_of_articles = @list_of_articles.tagged_with(self.index_of_articles_tagged_with.split(",").map{|t| t.strip}, on: :tags, any: true)
+      end
+      #get articles without tag
+      if self.not_tagged_with.present?
+        @list_of_articles = @list_of_articles.tagged_with(self.not_tagged_with.split(",").map{|t| t.strip}, :exclude => true, on: :tags)
+      end
+      #get_articles_by_frontend_tags
+      if user_frontend_tags.present?
+        @list_of_articles = @list_of_articles.tagged_with(user_frontend_tags, on: :frontend_tags, any: true)
+      end
+      #filter with permissions
+      @list_of_articles = filter_with_permissions(@list_of_articles,current_operator)
+
+      #sort list of articles
+      if self.sort_order.present?
+        if self.sort_order == "Random"
+          @list_of_articles = @list_of_articles.flatten.shuffle
+        elsif self.sort_order == "Alphabetically"
+          @list_of_articles = @list_of_articles.flatten.sort_by{ |article| article.title }
+        elsif self.sort_order == "GlobalSortID"
+          @list_of_articles = @list_of_articles.flatten.sort_by{ |article| article.try(:global_sorting_id) }
+        elsif self.respond_to?(self.sort_order.downcase)
+          sort_order = self.sort_order.downcase
+          @list_of_articles = @list_of_articles.flatten.sort_by{ |article| article.respond_to?(sort_order) ? article.send(sort_order) : article }
+        elsif self.sort_order.include?(".")
+          sort_order = self.sort_order.downcase.split(".")
+          @unsortable = @list_of_articles.flatten.select{|a| !a.respond_to_all?(self.sort_order) }
+          @list_of_articles = @list_of_articles.flatten.delete_if{|a| !a.respond_to_all?(self.sort_order) }
+          @list_of_articles = @list_of_articles.sort_by{|a| eval("a.#{self.sort_order}") }
+          if @unsortable.count > 0
+            @list_of_articles = @unsortable + @list_of_articles
+            @list_of_articles = @list_of_articles.flatten
+          end
+        end
+        if self.reverse_sort
+          @list_of_articles = @list_of_articles.reverse
+        end
+      end
+      if self.sorter_limit && self.sorter_limit > 0
+        @list_of_articles = @list_of_articles[0..self.sorter_limit-1]
+      end
+
+      return @list_of_articles
+    end
 
     # **************************
     # **************************
@@ -569,7 +495,64 @@ module Goldencobra
     # **************************
     # **************************
 
-    #Nachdem ein Artikel gelöscht wurde soll sein Elternelement aktualisiert werden, damit ein rss feed oder ähnliches mitbekommt wenn ein kindeintrag gelöscht wurde
+    def cleanup_redirections
+      Goldencobra::Redirector.where(:source_url => self.absolute_public_url).destroy_all
+    end
+
+    #bevor ein Artikle gespeichert wird , wird ein redirector unvollständig erstellt
+    def set_redirection_step_1
+      #Wenn der Artikle vor mehr als 24 Stunden erstellt wurde und sich an der URL etwas verändert hat, dann eine Weiterleitung anlegen.
+      modified_hours_since = ((Time.now - self.created_at) / 1.hour).round
+      if !self.new_record? && (self.url_path_changed? || self.url_name_changed? || self.ancestry_changed?) && modified_hours_since > 24
+        #Erstelle Redirector nur mit source
+        if self.url_path_changed?
+          old_url = "#{self.absolute_base_url}#{Goldencobra::Domain.current.try(:url_prefix)}#{self.url_path_change[0]}"
+        else
+          old_url = "#{self.absolute_base_url}#{Goldencobra::Domain.current.try(:url_prefix)}#{self.url_path}"
+        end
+        r = Goldencobra::Redirector.find_or_create_by_source_url(old_url)
+        r.active = false
+        r.save
+        self.create_redirection = r.id
+      end
+    end
+
+    def set_redirection_step_2
+      if self.create_redirection.present? && self.create_redirection.to_i > 0
+        #Suche Redirector nur mit source und vervollständige ihn
+        Goldencobra::Redirector.where(:source_url => self.absolute_public_url).destroy_all
+        r = Goldencobra::Redirector.find_by_id(self.create_redirection)
+        if r.present?
+          r.target_url = self.absolute_public_url
+          r.active = true
+          r.save
+          custom_children = Goldencobra::Article.find_all_by_ancestry("#{self.ancestry}/#{self.id}")
+          if custom_children.any?
+            if custom_children.count < 30
+              # wenn es nur wenige Kinderartikel gibt, dann gleich direkt machen
+              custom_children.each do |d|
+                d.updated_at = Time.now
+                d.url_path = d.get_url_from_path
+                d.save
+              end
+            else
+              #Ansosnten einen Raketask damit starten
+              system("cd #{::Rails.root} && RAILS_ENV=#{::Rails.env} bundle exec rake article_cache:recreate ID=#{self.id} &")
+            end
+          end
+        end
+      end
+    end
+
+    def set_url_path
+      self.update_column(:url_path, self.get_url_from_path)
+    end
+
+    def get_url_from_path
+      "/#{self.path.select([:ancestry, :url_name, :startpage, :id]).map{|a| a.url_name if !a.startpage}.compact.join("/")}"
+    end
+
+    #Nachdem ein Artikel gelöscht oder aktualsisiert wurde soll sein Elternelement aktualisiert werden, damit ein rss feed oder ähnliches mitbekommt wenn ein kindeintrag gelöscht oder bearbeitet wurde
     def update_parent_article_etag
       if self.parent.present?
         self.parent.update_attributes(:updated_at => Time.now)
@@ -591,7 +574,7 @@ module Goldencobra
       #meta_description = Goldencobra::Setting.for_key('goldencobra.page.default_meta_description_tag')
 
       if self.teaser.present?
-        meta_description = remove_html_tags(self.teaser)
+        meta_description = remove_html_tags(self.teaser.truncate(200))
       else
         meta_description = self.content.present? ? remove_html_tags(self.content).truncate(200) : self.title
       end
@@ -660,28 +643,26 @@ module Goldencobra
     end
 
     def set_standard_application_template
-      if self.template_file.blank?
-        if self.articletype.present? && self.articletype.default_template_file.present?
-          self.template_file = self.articletype.default_template_file
-        else
-          self.template_file = "application"
+      if ActiveRecord::Base.connection.table_exists?("goldencobra_articles") && ActiveRecord::Base.connection.table_exists?("goldencobra_articletypes")
+        if self.template_file.blank?
+          if self.articletype.present? && self.articletype.default_template_file.present?
+            self.template_file = self.articletype.default_template_file
+          else
+            self.template_file = "application"
+          end
         end
       end
     end
 
+
+
+
     # **************************
     # **************************
-    # Class Methods
+    # URL and Redirection Methods
     # **************************
     # **************************
 
-    def self.active
-      Goldencobra::Article.where("active = 1 AND active_since < '#{Time.now.strftime('%Y-%m-%d %H:%M:%S ')}'")
-    end
-
-    def active?
-      self.active && self.active_since < Time.now.utc
-    end
 
     def self.search_by_url(url)
       article = nil
@@ -693,6 +674,82 @@ module Goldencobra
       return article
     end
 
+
+    def parent_path
+      self.path.map(&:title).join(" / ")
+    end
+
+
+    def public_url(with_prefix=true)
+      if self.startpage
+        if with_prefix
+          return "#{Goldencobra::Domain.current.try(:url_prefix)}/"
+        else
+          return "/"
+        end
+      else
+
+        #url_path in der Datenbank als string speichern und beim update von ancestry neu berechnen... ansosnten den urlpafh aus dem string holen statt jedesmal über alle eltern iterierne
+        if self.url_path.blank? || self.url_path_changed? || self.url_name_changed? || self.ancestry_changed?
+          a_url = self.get_url_from_path
+        else
+          a_url = self.url_path
+        end
+
+        if with_prefix
+          return "#{Goldencobra::Domain.current.try(:url_prefix)}#{a_url}"
+        else
+          return a_url
+        end
+      end
+    end
+
+
+    def absolute_base_url
+      if Goldencobra::Setting.for_key("goldencobra.use_ssl") == "true"
+        "https://#{Goldencobra::Setting.for_key('goldencobra.url')}"
+      else
+        "http://#{Goldencobra::Setting.for_key('goldencobra.url')}"
+      end
+    end
+
+
+    def absolute_public_url
+      if Goldencobra::Setting.for_key("goldencobra.use_ssl") == "true"
+        "https://#{Goldencobra::Setting.for_key('goldencobra.url')}#{self.public_url}"
+      else
+        "http://#{Goldencobra::Setting.for_key('goldencobra.url')}#{self.public_url}"
+      end
+    end
+
+
+    def for_friendly_name
+      if self.url_name.present?
+        self.url_name
+      elsif self.breadcrumb.present?
+        self.breadcrumb
+      else
+        self.title
+      end
+    end
+
+
+    # **************************
+    # **************************
+    # Class Methods
+    # **************************
+    # **************************
+
+    def self.active
+      Goldencobra::Article.where("active = 1 AND active_since < '#{Time.now.strftime('%Y-%m-%d %H:%M:%S ')}'")
+    end
+
+    def active?
+      self.active && self.active_since < Time.now.utc
+    end
+
+
+
     def self.load_liquid_methods(options={})
 
     end
@@ -743,6 +800,23 @@ module Goldencobra
     def self.templates_for_select
       Dir.glob(File.join(::Rails.root, "app", "views", "layouts", "*.html.erb")).map{|a| File.basename(a, ".html.erb")}.delete_if{|a| a =~ /^_/ }
     end
+
+    def self.simple_search(q)
+      self.active.search(:title_or_subtitle_or_url_name_or_content_or_summary_or_teaser_contains => q).relation.map {
+          |article|
+        {
+            :id => article.id,
+            :absolute_public_url => article.absolute_public_url,
+            :title => article ? article.title : '',
+            :teaser => article ? article.teaser : '',
+            :article_type => article.article_type,
+            :updated_at => article.updated_at,
+            :parent_title => article.parent ? article.parent.title ? article.parent.title : '' : '',
+            :ancestry => article.ancestry ? article.ancestry : ''
+        }
+      }
+    end
+
   end
 end