github_cli 0.5.3 → 0.5.4

data/spec/github_cli/config_spec.rb

@@ -1,131 +1,124 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe GithubCLI::Config do
   let(:filename) { '.githubrc' }
+  let(:path)     { "/users/#{filename}" }
   let(:config_name) { 'simple_config' }
-  let(:path) { "/users/#{filename}" }
+  let(:config) { described_class.new fixture_path }
+
+  before do
+    config.stub(:global_options_file) { fixture_path(config_name) }
+    File.stub(:open) { YAML.load fixture('simple_config') }
+  end
+
+  it 'returns config type' do
+    GithubCLI.config = GithubCLI::Config.new filename
+    GithubCLI.config.should be_a GithubCLI::Config
+  end
+
+  context 'array access' do
+    it 'returns value for the key' do
+      expect(config['user.login']).to eql('login')
+    end
+
+    it 'searches in commands' do
+      expect(config['issue.list']).to eql({ 'title' => 'ticket' })
+    end
+
+    it 'returns nil for missing key' do
+      expect(config['non-existent']).to be_nil
+    end
+  end
+
+  context '#fetch' do
+    it 'finds value' do
+      expect(config.fetch('user.token')).to eql('ad7f9asdf97as98df7as9fd7')
+    end
+
+    it 'uses default value' do
+      expect(config.fetch('unkown', 11)).to eql(11)
+    end
+
+    it 'raises error' do
+      expect { config.fetch('unkown') }.to raise_error(IndexError)
+    end
+  end
 
-  context 'global' do
-    let(:config) { GithubCLI::Config.new fixture_path }
+  context '#pretty' do
+    it 'collects options into array' do
+      options= {'user.token' => 'abc123' }
+      config.stub(:all).and_return options
+      expect(config.pretty).to eql([['user.token','abc123']])
+    end
+
+    it 'marks nil option value as undefined' do
+      options= {'option' => nil}
+      config.stub(:all).and_return options
+      expect(config.pretty).to eql([['option', 'UNDEFINED']])
+    end
+  end
+
+  context '#save' do
+    let(:attrs) { {} }
+    let(:cmd) { stub(:cmd, :namespace => 'repo', :name => 'create') }
 
     before do
-      config.stub(:global_options_file) { fixture_path(config_name) }
-      File.stub(:open) { YAML.load fixture('simple_config') }
+      GithubCLI::Command.stub(:all) { [cmd] }
+      File.stub(:open)
     end
-
-    it 'returns config type' do
-      GithubCLI.config = GithubCLI::Config.new filename
-      GithubCLI.config.should be_a GithubCLI::Config
-    end
-
-    context 'array access' do
-      it 'returns value for the key' do
-        config['auth.basic'].should == 'login:password'
-      end
-
-      it 'searches in commands' do
-        config['issue.list'].should == { 'title' => 'ticket' }
-      end
-
-      it 'returns nil for missing key' do
-        config['non-existent'].should be_nil
-      end
-    end
-
-    context '#fetch' do
-      it 'finds value' do
-        config.fetch('auth.token').should == 'ad7f9asdf97as98df7as9fd7'
-      end
-
-      it 'uses default value' do
-        config.fetch('unkown', 11).should == 11
-      end
-
-      it 'raises error' do
-        expect {
-          config.fetch('unkown')
-        }.to raise_error(IndexError)
-      end
-    end
-
-    context '#pretty' do
-      it 'collects options into array' do
-        options= {'auth.token' => 'abc123' }
-        config.stub(:all).and_return options
-        config.pretty.should == [['auth.token','abc123']]
-      end
-
-      it 'marks nil option value as undefined' do
-        options= {'option' => nil}
-        config.stub(:all).and_return options
-        config.pretty.should == [['option', 'UNDEFINED']]
-      end
-    end
-
-    context '#save' do
-      let(:attrs) { {} }
-      let(:cmd) { stub(:cmd, :namespace => 'repo', :name => 'create') }
-
-      before do
-        GithubCLI::Command.stub(:all) { [cmd] }
-        File.stub(:open)
-      end
-
-      it 'saves config to yaml format' do
-        File.stub(:open).and_yield filename
-        YAML.should_receive(:dump).with(attrs, filename)
-        config.save attrs
-      end
-
-      it 'retrieves api commands' do
-        config.save attrs
-        attrs.should have_key 'commands.repo.create'
-      end
-
-      it 'skips commands with no namespace' do
-        cmd.stub(:namespace) { '' }
-        config.save attrs
-        attrs.keys.should be_empty
-      end
-
-      it 'skips help commands' do
-        cmd.stub(:name) { 'help' }
-        config.save attrs
-        attrs.keys.should be_empty
-      end
-    end
-
-    context "#load" do
-      it "loads empty hash if config doesn't exist" do
-        File.stub(:exists?) { false }
-        config.load == {}
-      end
-
-      it "loads yaml config" do
-        File.stub(:exists?) { true }
-        File.stub(:open).and_yield filename
-        YAML.should_receive(:load).with(filename)
-        config.load
-      end
-    end
-
-    context "#path" do
-      it 'looks for local config file' do
-        root = "/users/"
-        File.stub(:exists?) { true }
-        config = GithubCLI::Config.new root
-        config.path.to_s.should == "#{root}/.githubrc"
-      end
-
-      it 'reads global file if local is missing ' do
-        File.stub(:exists?) { false }
-        config = GithubCLI::Config.new path
-        config.path.to_s.should == "#{ENV['HOME']}/#{filename}"
-      end
+
+    it 'saves config to yaml format' do
+      File.stub(:open).and_yield filename
+      YAML.should_receive(:dump).with(attrs, filename)
+      config.save attrs
+    end
+
+    it 'retrieves api commands' do
+      config.save attrs
+      attrs.should have_key 'commands.repo.create'
+    end
+
+    it 'skips commands with no namespace' do
+      cmd.stub(:namespace) { '' }
+      config.save attrs
+      attrs.keys.should be_empty
+    end
+
+    it 'skips help commands' do
+      cmd.stub(:name) { 'help' }
+      config.save attrs
+      attrs.keys.should be_empty
     end
   end
 
-  context 'local' do
+  context "#load" do
+    it "loads empty hash if config doesn't exist" do
+      File.stub(:exists?) { false }
+      config.load == {}
+    end
+
+    it "loads yaml config" do
+      File.stub(:exists?) { true }
+      File.stub(:open).and_yield filename
+      YAML.should_receive(:load).with(filename)
+      config.load
+    end
   end
 
+  context "#path" do
+    it 'looks for local config file' do
+      root = "/users/"
+      File.stub(:exists?) { true }
+      config = GithubCLI::Config.new root
+      config.path.to_s.should == "#{root}/.githubrc"
+    end
+
+    it 'reads global file if local is missing ' do
+      File.stub(:exists?) { false }
+      config = GithubCLI::Config.new path
+      config.path.to_s.should == "#{ENV['HOME']}/#{filename}"
+    end
+  end
 end # GithubCLI::Config

data/spec/github_cli/util/convert_value_spec.rb

@@ -0,0 +1,19 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe GithubCLI::Util, '#convert_value' do
+
+  it { expect(subject.convert_value(false)).to eq "false" }
+
+  it { expect(subject.convert_value(true)).to eq "true" }
+
+  it { expect(subject.convert_value(:bar)).to eq "bar" }
+
+  it { expect(subject.convert_value(123)).to eq "123" }
+
+  it { expect(subject.convert_value({:a => false})).to eql ["false"] }
+
+  it { expect(subject.convert_value([2.5])).to eql ["2.5"] }
+
+end # convert_value

data/spec/github_cli/util/convert_values_spec.rb

@@ -0,0 +1,14 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe GithubCLI::Util, '#convert_values' do
+  let(:values) { [true, {:a => false }, 'string']}
+
+  it { expect(subject.convert_values(values)).to include(["false"]) }
+
+  it { expect(subject.convert_values(values)).to include("true") }
+
+  it { expect(subject.convert_values(values)).to include("string") }
+
+end # convert_values

data/spec/github_cli/util_spec.rb

@@ -16,35 +16,6 @@ describe GithubCLI::Util do
     end
   end
 
-  describe '#convert_values' do
-    let(:values) { [true, {:a => false }, 'string']}
-
-    it "converts ruby boolean to string" do
-      subject.convert_values(values).should include "true"
-      subject.convert_values(values).should_not include true
-    end
-
-    it "converts recursively" do
-      subject.convert_values(values).should include ['false']
-    end
-
-    it 'preserves strings' do
-      subject.convert_values(values).should include 'string'
-    end
-  end
-
-  describe "#convert_value" do
-    it 'converts arrays to arrays of strings' do
-      values = [:bar, 123, 3.14]
-      subject.convert_value(values).should eq(["bar", "123", "3.14"])
-    end
-
-    it 'converts hash values to strings' do
-      values = {:foo => 123, :bar => :baz, :buz => 2.3}
-      subject.convert_value(values).should eq(["123", "baz", "2.3"])
-    end
-  end
-
   describe '#longest_common_prefix' do
     it 'finds common prefix' do
       a = 'tribe'; b = 'tree'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: github_cli
 version: !ruby/object:Gem::Version
-  version: 0.5.3
+  version: 0.5.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,22 +9,22 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-29 00:00:00.000000000Z
+date: 2013-03-23 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: github_api
-  requirement: &2152331700 !ruby/object:Gem::Requirement
+  requirement: &2153408740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '0.7'
+        version: '0.9'
   type: :runtime
   prerelease: false
-  version_requirements: *2152331700
+  version_requirements: *2153408740
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2152330960 !ruby/object:Gem::Requirement
+  requirement: &2153408300 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152330960
+  version_requirements: *2153408300
 - !ruby/object:Gem::Dependency
   name: aruba
-  requirement: &2152329880 !ruby/object:Gem::Requirement
+  requirement: &2153407820 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152329880
+  version_requirements: *2153407820
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &2152329160 !ruby/object:Gem::Requirement
+  requirement: &2153407400 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152329160
+  version_requirements: *2153407400
 - !ruby/object:Gem::Dependency
   name: communist
-  requirement: &2152328380 !ruby/object:Gem::Requirement
+  requirement: &2153406960 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152328380
+  version_requirements: *2153406960
 - !ruby/object:Gem::Dependency
   name: ronn
-  requirement: &2152327800 !ruby/object:Gem::Requirement
+  requirement: &2153406500 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,7 +76,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152327800
+  version_requirements: *2153406500
 description: CLI-based access to GitHub API v3
 email:
 - ''
@@ -235,11 +235,10 @@ files:
 - lib/github_cli/vendor/thor/actions/file_manipulation.rb
 - lib/github_cli/vendor/thor/actions/inject_into_file.rb
 - lib/github_cli/vendor/thor/base.rb
-- lib/github_cli/vendor/thor/core_ext/dir_escape.rb
-- lib/github_cli/vendor/thor/core_ext/file_binary_read.rb
+- lib/github_cli/vendor/thor/command.rb
 - lib/github_cli/vendor/thor/core_ext/hash_with_indifferent_access.rb
+- lib/github_cli/vendor/thor/core_ext/io_binary_read.rb
 - lib/github_cli/vendor/thor/core_ext/ordered_hash.rb
-- lib/github_cli/vendor/thor/empty.txt
 - lib/github_cli/vendor/thor/error.rb
 - lib/github_cli/vendor/thor/group.rb
 - lib/github_cli/vendor/thor/invocation.rb
@@ -254,7 +253,6 @@ files:
 - lib/github_cli/vendor/thor/shell/basic.rb
 - lib/github_cli/vendor/thor/shell/color.rb
 - lib/github_cli/vendor/thor/shell/html.rb
-- lib/github_cli/vendor/thor/task.rb
 - lib/github_cli/vendor/thor/util.rb
 - lib/github_cli/vendor/thor/version.rb
 - lib/github_cli/version.rb
@@ -266,9 +264,26 @@ files:
 - spec/github_cli/api_spec.rb
 - spec/github_cli/cli_spec.rb
 - spec/github_cli/command_spec.rb
+- spec/github_cli/commands/assignees_spec.rb
+- spec/github_cli/commands/blobs_spec.rb
+- spec/github_cli/commands/collaborators_spec.rb
+- spec/github_cli/commands/commits_spec.rb
+- spec/github_cli/commands/emails_spec.rb
+- spec/github_cli/commands/events_spec.rb
+- spec/github_cli/commands/followers_spec.rb
+- spec/github_cli/commands/keys_spec.rb
+- spec/github_cli/commands/labels_spec.rb
+- spec/github_cli/commands/milestones_spec.rb
+- spec/github_cli/commands/references_spec.rb
+- spec/github_cli/commands/starring_spec.rb
+- spec/github_cli/commands/tags_spec.rb
+- spec/github_cli/commands/trees_spec.rb
+- spec/github_cli/commands/watching_spec.rb
 - spec/github_cli/config_spec.rb
 - spec/github_cli/helpers_spec.rb
 - spec/github_cli/pager_spec.rb
+- spec/github_cli/util/convert_value_spec.rb
+- spec/github_cli/util/convert_values_spec.rb
 - spec/github_cli/util_spec.rb
 - spec/spec_helper.rb
 - lib/github_cli/man/gcli-config.1
@@ -345,8 +360,25 @@ test_files:
 - spec/github_cli/api_spec.rb
 - spec/github_cli/cli_spec.rb
 - spec/github_cli/command_spec.rb
+- spec/github_cli/commands/assignees_spec.rb
+- spec/github_cli/commands/blobs_spec.rb
+- spec/github_cli/commands/collaborators_spec.rb
+- spec/github_cli/commands/commits_spec.rb
+- spec/github_cli/commands/emails_spec.rb
+- spec/github_cli/commands/events_spec.rb
+- spec/github_cli/commands/followers_spec.rb
+- spec/github_cli/commands/keys_spec.rb
+- spec/github_cli/commands/labels_spec.rb
+- spec/github_cli/commands/milestones_spec.rb
+- spec/github_cli/commands/references_spec.rb
+- spec/github_cli/commands/starring_spec.rb
+- spec/github_cli/commands/tags_spec.rb
+- spec/github_cli/commands/trees_spec.rb
+- spec/github_cli/commands/watching_spec.rb
 - spec/github_cli/config_spec.rb
 - spec/github_cli/helpers_spec.rb
 - spec/github_cli/pager_spec.rb
+- spec/github_cli/util/convert_value_spec.rb
+- spec/github_cli/util/convert_values_spec.rb
 - spec/github_cli/util_spec.rb
 - spec/spec_helper.rb

data/lib/github_cli/vendor/thor/core_ext/file_binary_read.rb

@@ -1,9 +0,0 @@
-class File #:nodoc:
-
-  unless File.respond_to?(:binread)
-    def self.binread(file)
-      File.open(file, 'rb') { |f| f.read }
-    end
-  end
-
-end