github_cli 0.5.3 → 0.5.4

data/lib/github_cli/vendor/thor.rb

@@ -1,22 +1,24 @@
+require 'set'
 require 'thor/base'
 
 class Thor
   class << self
-    # Sets the default task when thor is executed without an explicit task to be called.
+    # Sets the default command when thor is executed without an explicit command to be called.
     #
     # ==== Parameters
-    # meth<Symbol>:: name of the default task
-    #
-    def default_task(meth=nil)
-      case meth
-        when :none
-          @default_task = 'help'
-        when nil
-          @default_task ||= from_superclass(:default_task, 'help')
-        else
-          @default_task = meth.to_s
+    # meth<Symbol>:: name of the default command
+    #
+    def default_command(meth=nil)
+      @default_command = case meth
+      when :none
+        'help'
+      when nil
+        @default_command || from_superclass(:default_command, 'help')
+      else
+        meth.to_s
       end
     end
+    alias default_task default_command
 
     # Registers another Thor subclass as a command.
     #
@@ -35,7 +37,7 @@ class Thor
       end
     end
 
-    # Defines the usage and the description of the next task.
+    # Defines the usage and the description of the next command.
     #
     # ==== Parameters
     # usage<String>
@@ -44,29 +46,29 @@ class Thor
     #
     def desc(usage, description, options={})
       if options[:for]
-        task = find_and_refresh_task(options[:for])
-        task.usage = usage             if usage
-        task.description = description if description
+        command = find_and_refresh_command(options[:for])
+        command.usage = usage             if usage
+        command.description = description if description
       else
         @usage, @desc, @hide = usage, description, options[:hide] || false
       end
     end
 
-    # Defines the long description of the next task.
+    # Defines the long description of the next command.
     #
     # ==== Parameters
     # long description<String>
     #
     def long_desc(long_description, options={})
       if options[:for]
-        task = find_and_refresh_task(options[:for])
-        task.long_description = long_description if long_description
+        command = find_and_refresh_command(options[:for])
+        command.long_description = long_description if long_description
       else
         @long_desc = long_description
       end
     end
 
-    # Maps an input to a task. If you define:
+    # Maps an input to a command. If you define:
     #
     #   map "-T" => "list"
     #
@@ -74,10 +76,10 @@ class Thor
     #
     #   thor -T
     #
-    # Will invoke the list task.
+    # Will invoke the list command.
     #
     # ==== Parameters
-    # Hash[String|Array => Symbol]:: Maps the string or the strings in the array to the given task.
+    # Hash[String|Array => Symbol]:: Maps the string or the strings in the array to the given command.
     #
     def map(mappings=nil)
       @map ||= from_superclass(:map, {})
@@ -95,7 +97,7 @@ class Thor
       @map
     end
 
-    # Declares the options for the next task to be declared.
+    # Declares the options for the next command to be declared.
     #
     # ==== Parameters
     # Hash[Symbol => Object]:: The hash key is the name of the option and the value
@@ -111,15 +113,15 @@ class Thor
     alias options method_options
 
     # Adds an option to the set of method options. If :for is given as option,
-    # it allows you to change the options from a previous defined task.
+    # it allows you to change the options from a previous defined command.
     #
-    #   def previous_task
+    #   def previous_command
     #     # magic
     #   end
     #
-    #   method_option :foo => :bar, :for => :previous_task
+    #   method_option :foo => :bar, :for => :previous_command
     #
-    #   def next_task
+    #   def next_command
     #     # magic
     #   end
     #
@@ -138,38 +140,38 @@ class Thor
     #
     def method_option(name, options={})
       scope = if options[:for]
-        find_and_refresh_task(options[:for]).options
+        find_and_refresh_command(options[:for]).options
       else
         method_options
       end
 
       build_option(name, options, scope)
     end
-
     alias option method_option
 
-    # Prints help information for the given task.
+    # Prints help information for the given command.
     #
     # ==== Parameters
     # shell<Thor::Shell>
-    # task_name<String>
+    # command_name<String>
     #
-    def task_help(shell, task_name)
-      meth = normalize_task_name(task_name)
-      task = all_tasks[meth]
-      handle_no_task_error(meth) unless task
+    def command_help(shell, command_name)
+      meth = normalize_command_name(command_name)
+      command = all_commands[meth]
+      handle_no_command_error(meth) unless command
 
       shell.say "Usage:"
-      shell.say "  #{banner(task)}"
+      shell.say "  #{banner(command)}"
       shell.say
-      class_options_help(shell, nil => task.options.map { |_, o| o })
-      if task.long_description
+      class_options_help(shell, nil => command.options.map { |_, o| o })
+      if command.long_description
         shell.say "Description:"
-        shell.print_wrapped(task.long_description, :indent => 2)
+        shell.print_wrapped(command.long_description, :indent => 2)
       else
-        shell.say task.description
+        shell.say command.description
       end
     end
+    alias task_help command_help
 
     # Prints help information for this class.
     #
@@ -177,32 +179,34 @@ class Thor
     # shell<Thor::Shell>
     #
     def help(shell, subcommand = false)
-      list = printable_tasks(true, subcommand)
+      list = printable_commands(true, subcommand)
       Thor::Util.thor_classes_in(self).each do |klass|
-        list += klass.printable_tasks(false)
+        list += klass.printable_commands(false)
       end
       list.sort!{ |a,b| a[0] <=> b[0] }
 
-      shell.say "Tasks:"
+      shell.say "Commands:"
       shell.print_table(list, :indent => 2, :truncate => true)
       shell.say
       class_options_help(shell)
     end
 
-    # Returns tasks ready to be printed.
-    def printable_tasks(all = true, subcommand = false)
-      (all ? all_tasks : tasks).map do |_, task|
-        next if task.hidden?
+    # Returns commands ready to be printed.
+    def printable_commands(all = true, subcommand = false)
+      (all ? all_commands : commands).map do |_, command|
+        next if command.hidden?
         item = []
-        item << banner(task, false, subcommand)
-        item << (task.description ? "# #{task.description.gsub(/\s+/m,' ')}" : "")
+        item << banner(command, false, subcommand)
+        item << (command.description ? "# #{command.description.gsub(/\s+/m,' ')}" : "")
         item
       end.compact
     end
+    alias printable_tasks printable_commands
 
     def subcommands
       @subcommands ||= from_superclass(:subcommands, [])
     end
+    alias subtasks subcommands
 
     def subcommand(subcommand, subcommand_class)
       self.subcommands << subcommand.to_s
@@ -210,9 +214,10 @@ class Thor
 
       define_method(subcommand) do |*args|
         args, opts = Thor::Arguments.split(args)
-        invoke subcommand_class, args, opts
+        invoke subcommand_class, args, opts, :invoked_via_subcommand => true, :class_options => options
       end
     end
+    alias subtask subcommand
 
     # Extend check unknown options to accept a hash of conditions.
     #
@@ -235,10 +240,10 @@ class Thor
       options = check_unknown_options
       return false unless options
 
-      task = config[:current_task]
-      return true unless task
+      command = config[:current_command]
+      return true unless command
 
-      name = task.name
+      name = command.name
 
       if subcommands.include?(name)
         false
@@ -251,129 +256,203 @@ class Thor
       end
     end
 
-    protected
-
-      # The method responsible for dispatching given the args.
-      def dispatch(meth, given_args, given_opts, config) #:nodoc:
-        meth ||= retrieve_task_name(given_args)
-        task = all_tasks[normalize_task_name(meth)]
-
-        if task
-          args, opts = Thor::Options.split(given_args)
-        else
-          args, opts = given_args, nil
-          task = Thor::DynamicTask.new(meth)
-        end
+    # Stop parsing of options as soon as an unknown option or a regular
+    # argument is encountered.  All remaining arguments are passed to the command.
+    # This is useful if you have a command that can receive arbitrary additional
+    # options, and where those additional options should not be handled by
+    # Thor.
+    #
+    # ==== Example
+    #
+    # To better understand how this is useful, let's consider a command that calls
+    # an external command.  A user may want to pass arbitrary options and
+    # arguments to that command.  The command itself also accepts some options,
+    # which should be handled by Thor.
+    #
+    #   class_option "verbose",  :type => :boolean
+    #   stop_on_unknown_option! :exec
+    #   check_unknown_options!  :except => :exec
+    #
+    #   desc "exec", "Run a shell command"
+    #   def exec(*args)
+    #     puts "diagnostic output" if options[:verbose]
+    #     Kernel.exec(*args)
+    #   end
+    #
+    # Here +exec+ can be called with +--verbose+ to get diagnostic output,
+    # e.g.:
+    #
+    #   $ thor exec --verbose echo foo
+    #   diagnostic output
+    #   foo
+    #
+    # But if +--verbose+ is given after +echo+, it is passed to +echo+ instead:
+    #
+    #   $ thor exec echo --verbose foo
+    #   --verbose foo
+    #
+    # ==== Parameters
+    # Symbol ...:: A list of commands that should be affected.
+    def stop_on_unknown_option!(*command_names)
+      @stop_on_unknown_option ||= Set.new
+      @stop_on_unknown_option.merge(command_names)
+    end
 
-        opts = given_opts || opts || []
-        config.merge!(:current_task => task, :task_options => task.options)
+    def stop_on_unknown_option?(command) #:nodoc:
+      !!@stop_on_unknown_option && @stop_on_unknown_option.include?(command.name.to_sym)
+    end
 
-        instance = new(args, opts, config)
-        yield instance if block_given?
-        args = instance.args
-        trailing = args[Range.new(arguments.size, -1)]
-        instance.invoke_task(task, trailing || [])
+  protected
+
+    # The method responsible for dispatching given the args.
+    def dispatch(meth, given_args, given_opts, config) #:nodoc:
+      # There is an edge case when dispatching from a subcommand.
+      # A problem occurs invoking the default command. This case occurs
+      # when arguments are passed and a default command is defined, and
+      # the first given_args does not match the default command.
+      # Thor use "help" by default so we skip that case.
+      # Note the call to retrieve_command_name. It's called with
+      # given_args.dup since that method calls args.shift. Then lookup
+      # the command normally. If the first item in given_args is not
+      # a command then use the default command. The given_args will be
+      # intact later since dup was used.
+      if config[:invoked_via_subcommand] && given_args.size >= 1 && default_command != "help" && given_args.first != default_command
+        meth ||= retrieve_command_name(given_args.dup)
+        command = all_commands[normalize_command_name(meth)]
+        command ||= all_commands[normalize_command_name(default_command)]
+      else
+        meth ||= retrieve_command_name(given_args)
+        command = all_commands[normalize_command_name(meth)]
       end
 
-      # The banner for this class. You can customize it if you are invoking the
-      # thor class by another ways which is not the Thor::Runner. It receives
-      # the task that is going to be invoked and a boolean which indicates if
-      # the namespace should be displayed as arguments.
-      #
-      def banner(task, namespace = nil, subcommand = false)
-        "#{basename} #{task.formatted_usage(self, $thor_runner, subcommand)}"
+      if command
+        args, opts = Thor::Options.split(given_args)
+        if stop_on_unknown_option?(command) && !args.empty?
+          # given_args starts with a non-option, so we treat everything as
+          # ordinary arguments
+          args.concat opts
+          opts.clear
+        end
+      else
+        args, opts = given_args, nil
+        command = Thor::DynamicCommand.new(meth)
       end
 
-      def baseclass #:nodoc:
-        Thor
-      end
+      opts = given_opts || opts || []
+      config.merge!(:current_command => command, :command_options => command.options)
 
-      def create_task(meth) #:nodoc:
-        if @usage && @desc
-          base_class = @hide ? Thor::HiddenTask : Thor::Task
-          tasks[meth] = base_class.new(meth, @desc, @long_desc, @usage, method_options)
-          @usage, @desc, @long_desc, @method_options, @hide = nil
-          true
-        elsif self.all_tasks[meth] || meth == "method_missing"
-          true
-        else
-          puts "[WARNING] Attempted to create task #{meth.inspect} without usage or description. " <<
-               "Call desc if you want this method to be available as task or declare it inside a " <<
-               "no_tasks{} block. Invoked from #{caller[1].inspect}."
-          false
-        end
-      end
+      instance = new(args, opts, config)
+      yield instance if block_given?
+      args = instance.args
+      trailing = args[Range.new(arguments.size, -1)]
+      instance.invoke_command(command, trailing || [])
+    end
 
-      def initialize_added #:nodoc:
-        class_options.merge!(method_options)
-        @method_options = nil
-      end
+    # The banner for this class. You can customize it if you are invoking the
+    # thor class by another ways which is not the Thor::Runner. It receives
+    # the command that is going to be invoked and a boolean which indicates if
+    # the namespace should be displayed as arguments.
+    #
+    def banner(command, namespace = nil, subcommand = false)
+      "#{basename} #{command.formatted_usage(self, $thor_runner, subcommand)}"
+    end
 
-      # Retrieve the task name from given args.
-      def retrieve_task_name(args) #:nodoc:
-        meth = args.first.to_s unless args.empty?
-        if meth && (map[meth] || meth !~ /^\-/)
-          args.shift
-        else
-          nil
-        end
+    def baseclass #:nodoc:
+      Thor
+    end
+
+    def create_command(meth) #:nodoc:
+      if @usage && @desc
+        base_class = @hide ? Thor::HiddenCommand : Thor::Command
+        commands[meth] = base_class.new(meth, @desc, @long_desc, @usage, method_options)
+        @usage, @desc, @long_desc, @method_options, @hide = nil
+        true
+      elsif self.all_commands[meth] || meth == "method_missing"
+        true
+      else
+        puts "[WARNING] Attempted to create command #{meth.inspect} without usage or description. " <<
+             "Call desc if you want this method to be available as command or declare it inside a " <<
+             "no_commands{} block. Invoked from #{caller[1].inspect}."
+        false
       end
+    end
+    alias create_task create_command
 
-      # receives a (possibly nil) task name and returns a name that is in
-      # the tasks hash. In addition to normalizing aliases, this logic
-      # will determine if a shortened command is an unambiguous substring of
-      # a task or alias.
-      #
-      # +normalize_task_name+ also converts names like +animal-prison+
-      # into +animal_prison+.
-      def normalize_task_name(meth) #:nodoc:
-        return default_task.to_s.gsub('-', '_') unless meth
-
-        possibilities = find_task_possibilities(meth)
-        if possibilities.size > 1
-          raise ArgumentError, "Ambiguous task #{meth} matches [#{possibilities.join(', ')}]"
-        elsif possibilities.size < 1
-          meth = meth || default_task
-        elsif map[meth]
-          meth = map[meth]
-        else
-          meth = possibilities.first
-        end
+    def initialize_added #:nodoc:
+      class_options.merge!(method_options)
+      @method_options = nil
+    end
 
-        meth.to_s.gsub('-','_') # treat foo-bar as foo_bar
+    # Retrieve the command name from given args.
+    def retrieve_command_name(args) #:nodoc:
+      meth = args.first.to_s unless args.empty?
+      if meth && (map[meth] || meth !~ /^\-/)
+        args.shift
+      else
+        nil
       end
+    end
+    alias retrieve_task_name retrieve_command_name
 
-      # this is the logic that takes the task name passed in by the user
-      # and determines whether it is an unambiguous substrings of a task or
-      # alias name.
-      def find_task_possibilities(meth)
-        len = meth.to_s.length
-        possibilities = all_tasks.merge(map).keys.select { |n| meth == n[0, len] }.sort
-        unique_possibilities = possibilities.map { |k| map[k] || k }.uniq
-
-        if possibilities.include?(meth)
-          [meth]
-        elsif unique_possibilities.size == 1
-          unique_possibilities
-        else
-          possibilities
-        end
+    # receives a (possibly nil) command name and returns a name that is in
+    # the commands hash. In addition to normalizing aliases, this logic
+    # will determine if a shortened command is an unambiguous substring of
+    # a command or alias.
+    #
+    # +normalize_command_name+ also converts names like +animal-prison+
+    # into +animal_prison+.
+    def normalize_command_name(meth) #:nodoc:
+      return default_command.to_s.gsub('-', '_') unless meth
+
+      possibilities = find_command_possibilities(meth)
+      if possibilities.size > 1
+        raise ArgumentError, "Ambiguous command #{meth} matches [#{possibilities.join(', ')}]"
+      elsif possibilities.size < 1
+        meth = meth || default_command
+      elsif map[meth]
+        meth = map[meth]
+      else
+        meth = possibilities.first
       end
 
-      def subcommand_help(cmd)
-        desc "help [COMMAND]", "Describe subcommands or one specific subcommand"
-        class_eval <<-RUBY
-          def help(task = nil, subcommand = true); super; end
-        RUBY
+      meth.to_s.gsub('-','_') # treat foo-bar as foo_bar
+    end
+    alias normalize_task_name normalize_command_name
+
+    # this is the logic that takes the command name passed in by the user
+    # and determines whether it is an unambiguous substrings of a command or
+    # alias name.
+    def find_command_possibilities(meth)
+      len = meth.to_s.length
+      possibilities = all_commands.merge(map).keys.select { |n| meth == n[0, len] }.sort
+      unique_possibilities = possibilities.map { |k| map[k] || k }.uniq
+
+      if possibilities.include?(meth)
+        [meth]
+      elsif unique_possibilities.size == 1
+        unique_possibilities
+      else
+        possibilities
       end
+    end
+    alias find_task_possibilities find_command_possibilities
+
+    def subcommand_help(cmd)
+      desc "help [COMMAND]", "Describe subcommands or one specific subcommand"
+      class_eval <<-RUBY
+        def help(command = nil, subcommand = true); super; end
+      RUBY
+    end
+    alias subtask_help subcommand_help
+
   end
 
   include Thor::Base
 
   map HELP_MAPPINGS => :help
 
-  desc "help [TASK]", "Describe available tasks or one specific task"
-  def help(task = nil, subcommand = false)
-    task ? self.class.task_help(shell, task) : self.class.help(shell, subcommand)
+  desc "help [COMMAND]", "Describe available commands or one specific command"
+  def help(command = nil, subcommand = false)
+    command ? self.class.command_help(shell, command) : self.class.help(shell, subcommand)
   end
 end

data/lib/github_cli/version.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
 
 module GithubCLI
-  VERSION = "0.5.3"
+  VERSION = "0.5.4"
 end

data/man/gcli-config.1.ronn

@@ -3,9 +3,9 @@ gcli-config(1) - Get or set global or local configuration options
 
 ## SYNOPSIS
 
-`gcli config` --global|--local name [value]<br>
-`gcli config` --global|--local `-l | -list` [name_regex]<br>
-`gcli config` --global|--local `-e | --edit`
+`gcli config` [--local] name [value]<br>
+`gcli config` [--local] `-l | -list` [name_regex]<br>
+`gcli config` [--local] `-e | --edit`
 
 ## DESCRIPTION
 
@@ -23,9 +23,6 @@ This command line will fail (with the exit code ret) if:
 
 ## OPTIONS
 
-* `--global`:
-  Writes configuration settings to global ~/.githubrc file inside user home directory.
-
 * `--local`:
   Writes cofinguration settings inside the current directory to the .githubrc file.
 
@@ -47,11 +44,17 @@ The configuration file is written in `yaml`. Therfore all formatting rules are d
 
 ### VARIABLES
 
-*  `auth.token`:
+*  `user.token`:
   Authentication token.
 
-*  `auth.basic`: 
-  Basic credentials in the form `login:password`.
+*  `user.login`: 
+  Basic login credentials.
+
+*  `user.password`:
+  Basic password credentials.
+
+*  `core.adapter`:
+  Sets http adapter used to perform requests to GitHub API v3.
 
 *  `core.endpoint`:
   Sets host path used as the base for all requests to GitHub API v3.
@@ -63,7 +66,7 @@ The configuration file is written in `yaml`. Therfore all formatting rules are d
   The command that will be used to paginate output. Can be overridden with PAGER environment variable. less
 
 *  `core.no-pager`:
-  false
+  Switched off results paging.
 
 *  `core.no-color`:
   If set to true disables color output. By default is set to false.
@@ -71,7 +74,7 @@ The configuration file is written in `yaml`. Therfore all formatting rules are d
 *  `core.format`:
   Determines output formatting. Defaults to table output.
 
-*  `core.auto`:
+*  `core.auto_pagination`:
    Automatic pagination of requests to GitHub.
 
 *  `core.aliases`:

data/spec/github_cli/commands/assignees_spec.rb

@@ -0,0 +1,20 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe GithubCLI::Commands::Assignees do
+  let(:format) { 'table' }
+  let(:user)   { 'peter-murach' }
+  let(:repo)   { 'github_cli' }
+  let(:api_class) { GithubCLI::Assignee }
+
+  it "invokes assignee:list" do
+    api_class.should_receive(:all).with(user, repo, {}, format)
+    subject.invoke "assignee:list", [user, repo]
+  end
+
+  it "invokes assignee:check" do
+    api_class.should_receive(:check).with(user, repo, 'git', {}, format)
+    subject.invoke "assignee:check", [user, repo, 'git']
+  end
+end

data/spec/github_cli/commands/blobs_spec.rb

@@ -0,0 +1,21 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe GithubCLI::Commands::Blobs do
+  let(:format) { 'table' }
+  let(:user)   { 'peter-murach' }
+  let(:repo)   { 'github_cli' }
+  let(:sha)    { '3a0f86fb8db8eea7ccbb9a95f325ddbedfb25e15' }
+  let(:api_class) { GithubCLI::Blob }
+
+  it "invokes blob:get" do
+    api_class.should_receive(:get).with(user, repo, sha, {}, format)
+    subject.invoke "blob:get", [user, repo, sha]
+  end
+
+  it "invokes blob:create" do
+    api_class.should_receive(:create).with(user, repo, {}, format)
+    subject.invoke "blob:create", [user, repo]
+  end
+end