github_api 0.8.4 → 0.8.5

data/spec/github/issues/events/list_spec.rb

@@ -0,0 +1,84 @@
+
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Issues::Events, '#list' do
+  let(:user) { 'peter-murach' }
+  let(:repo) { 'github' }
+  let(:issue_id) { 1 }
+  let(:request_path) { "/repos/#{user}/#{repo}/issues/events" }
+
+  before {
+    stub_get(request_path).to_return(:body => body, :status => status,
+      :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context 'without issue_id' do
+    let(:body) { fixture('issues/events.json') }
+    let(:status) { 200 }
+
+    context "resource found" do
+
+      it { subject.should respond_to :all }
+
+      it "should fail to get resource without username" do
+        expect { subject.list }.to raise_error(ArgumentError)
+      end
+
+      it "should get the resources" do
+        subject.list user, repo
+        a_get(request_path).should have_been_made
+      end
+
+      it_should_behave_like 'an array of resources' do
+        let(:requestable) { subject.list user, repo }
+      end
+
+      it "should get issue information" do
+        events = subject.list user, repo
+        events.first.actor.login.should == 'octocat'
+      end
+
+      it "should yield to a block" do
+        yielded = []
+        result = subject.list(user, repo) { |obj| yielded << obj }
+        yielded.should == result
+      end
+    end
+
+    it_should_behave_like 'request failure' do
+      let(:requestable) { subject.list user, repo }
+    end
+  end # without issue_id
+
+  context 'with issue_id' do
+    let(:request_path) { "/repos/#{user}/#{repo}/issues/#{issue_id}/events" }
+    let(:body) { fixture('issues/events.json') }
+    let(:status) { 200 }
+
+    context "resource found" do
+      it "should get the resources" do
+        subject.list user, repo, :issue_id => issue_id
+        a_get(request_path).should have_been_made
+      end
+
+      it_should_behave_like 'an array of resources' do
+        let(:requestable) { subject.list user, repo, :issue_id => issue_id }
+      end
+
+      it "should get issue information" do
+        events = subject.list user, repo, :issue_id => issue_id
+        events.first.actor.login.should == 'octocat'
+      end
+
+      it "should yield to a block" do
+        yielded = []
+        result = subject.list(user, repo, :issue_id => issue_id) { |obj| yielded << obj }
+        yielded.should == result
+      end
+    end
+  end # with issue_id
+end # list

data/spec/github/issues/events_spec.rb

@@ -3,160 +3,5 @@
 require 'spec_helper'
 
 describe Github::Issues::Events do
-  let(:github) { Github.new }
-  let(:user)   { 'peter-murach' }
-  let(:repo)   { 'github' }
-  let(:issue_id) { 1 }
-
-  after { reset_authentication_for github }
-
-  describe '#list' do
-    it { github.issues.comments.should respond_to :all }
-
-    context 'without issue_id' do
-      context "resource found" do
-        before do
-          stub_get("/repos/#{user}/#{repo}/issues/events").
-            to_return(:body => fixture('issues/events.json'),
-              :status => 200,
-              :headers => {:content_type => "application/json; charset=utf-8"})
-        end
-
-        it "should fail to get resource without username" do
-          expect { github.issues.events.list }.to raise_error(ArgumentError)
-        end
-
-        it "should get the resources" do
-          github.issues.events.list user, repo
-          a_get("/repos/#{user}/#{repo}/issues/events").should have_been_made
-        end
-
-        it "should return array of resources" do
-          events = github.issues.events.list user, repo
-          events.should be_an Array
-          events.should have(1).items
-        end
-
-        it "should be a mash type" do
-          events = github.issues.events.list user, repo
-          events.first.should be_a Hashie::Mash
-        end
-
-        it "should get issue information" do
-          events = github.issues.events.list user, repo
-          events.first.actor.login.should == 'octocat'
-        end
-
-        it "should yield to a block" do
-          github.issues.events.should_receive(:list).
-            with(user, repo).and_yield('web')
-          github.issues.events.list(user, repo) { |param| 'web' }.should == 'web'
-        end
-      end
-
-      context "resource not found" do
-        before do
-          stub_get("/repos/#{user}/#{repo}/issues/events").
-            to_return(:body => "", :status => [404, "Not Found"])
-        end
-
-        it "should return 404 with a message 'Not Found'" do
-          expect {
-            github.issues.events.list user, repo
-          }.to raise_error(Github::Error::NotFound)
-        end
-      end
-    end # without issue_id
-
-    context 'with issue_id' do
-      context "resource found" do
-        before do
-          stub_get("/repos/#{user}/#{repo}/issues/#{issue_id}/events").
-            to_return(:body => fixture('issues/events.json'), :status => 200, :headers => {:content_type => "application/json; charset=utf-8"})
-        end
-
-        it "should get the resources" do
-          github.issues.events.list user, repo, :issue_id => issue_id
-          a_get("/repos/#{user}/#{repo}/issues/#{issue_id}/events").should have_been_made
-        end
-
-        it "should return array of resources" do
-          events = github.issues.events.list user, repo, :issue_id => issue_id
-          events.should be_an Array
-          events.should have(1).items
-        end
-
-        it "should be a mash type" do
-          events = github.issues.events.list user, repo, :issue_id => issue_id
-          events.first.should be_a Hashie::Mash
-        end
-
-        it "should get issue information" do
-          events = github.issues.events.list user, repo, :issue_id => issue_id
-          events.first.actor.login.should == 'octocat'
-        end
-
-        it "should yield to a block" do
-          github.issues.events.should_receive(:list).
-            with(user, repo, issue_id).and_yield('web')
-          github.issues.events.list(user, repo, issue_id) { |param| 'web' }.
-            should == 'web'
-        end
-      end
-    end # with issue_id
-  end # list
-
-  describe "#get" do
-    let(:event_id) { 1 }
-
-    it { github.issues.events.should respond_to :find }
-
-    context "resource found" do
-      before do
-        stub_get("/repos/#{user}/#{repo}/issues/events/#{event_id}").
-          to_return(:body => fixture('issues/event.json'),
-            :status => 200,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to get resource without event id" do
-        expect {
-          github.issues.events.get user, repo, nil
-        }.to raise_error(ArgumentError)
-      end
-
-      it "should get the resource" do
-        github.issues.events.get user, repo, event_id
-        a_get("/repos/#{user}/#{repo}/issues/events/#{event_id}").
-          should have_been_made
-      end
-
-      it "should get event information" do
-        event = github.issues.events.get user, repo, event_id
-        event.actor.id.should == event_id
-        event.actor.login.should == 'octocat'
-      end
-
-      it "should return mash" do
-        event = github.issues.events.get user, repo, event_id
-        event.should be_a Hashie::Mash
-      end
-    end
-
-    context "resource not found" do
-      before do
-        stub_get("/repos/#{user}/#{repo}/issues/events/#{event_id}").
-          to_return(:body => fixture('issues/event.json'),
-            :status => 404,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to retrive resource" do
-        expect {
-          github.issues.events.get user, repo, event_id
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # get
 
 end # Github::Issues:Events

data/spec/github/issues/labels/remove_spec.rb

@@ -0,0 +1,58 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Issues::Labels, '#remove' do
+  let(:user)   { 'peter-murach' }
+  let(:repo)   { 'github' }
+  let(:issue_id) { 1 }
+  let(:label_id) { 1 }
+  let(:request_path) { "/repos/#{user}/#{repo}/issues/#{issue_id}/labels/#{label_id}" }
+
+  before {
+    stub_delete(request_path).to_return(:body => body, :status => status,
+      :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "remove a label from an issue" do
+    let(:body) { fixture('issues/labels.json') }
+    let(:status) { 200 }
+
+    it "should throw exception if issue-id not present" do
+      expect { subject.remove user, repo, nil }.to raise_error(ArgumentError)
+    end
+
+    it "should remove label successfully" do
+      subject.remove user, repo, issue_id, label_id
+      a_delete(request_path).should have_been_made
+    end
+
+    it "should return the resource" do
+      labels = subject.remove user, repo, issue_id, label_id
+      labels.first.should be_a Hashie::Mash
+    end
+
+    it "should get the label information" do
+      labels = subject.remove user, repo, issue_id, label_id
+      labels.first.name.should == 'bug'
+    end
+  end
+
+  context "remove all labels from an issue" do
+    let(:request_path) { "/repos/#{user}/#{repo}/issues/#{issue_id}/labels" }
+    let(:body) { '[]' }
+    let(:status) { 204 }
+
+    it "should remove labels successfully" do
+      subject.remove user, repo, issue_id
+      a_delete(request_path).should have_been_made
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.remove user, repo, issue_id, label_id }
+  end
+
+end # remove

data/spec/github/issues/labels/replace_spec.rb

@@ -0,0 +1,50 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Issues::Labels, '#replace' do
+  let(:user) { 'peter-murach' }
+  let(:repo) { 'github' }
+  let(:issue_id) { 1 }
+  let(:labels) { "Label 1" }
+  let(:request_path) { "/repos/#{user}/#{repo}/issues/#{issue_id}/labels" }
+
+  before {
+    stub_put(request_path).to_return(:body => body, :status => status,
+      :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+
+  context "labels replaced" do
+    let(:body) { fixture('issues/labels.json') }
+    let(:status) { 200 }
+
+    it "should fail to add labels if issue-id is missing" do
+      expect {
+        subject.replace user, repo, nil, labels
+      }.to raise_error(ArgumentError)
+    end
+
+    it "should create resource successfully" do
+      subject.replace user, repo, issue_id, labels
+      a_put(request_path).should have_been_made
+    end
+
+    it "should return the resource" do
+      labels = subject.replace user, repo, issue_id, labels
+      labels.first.should be_a Hashie::Mash
+    end
+
+    it "should get the label information" do
+      labels = subject.replace user, repo, issue_id, labels
+      labels.first.name.should == 'bug'
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.replace user, repo, issue_id, labels }
+  end
+
+end # replace

data/spec/github/issues/labels_spec.rb

@@ -1,118 +1,7 @@
 require 'spec_helper'
 
-describe Github::Issues::Labels do
-  let(:github) { Github.new }
-  let(:user)   { 'peter-murach' }
-  let(:repo)   { 'github' }
-  let(:label_id) { 1 }
-
-  after { github.user, github.repo, github.oauth_token = nil, nil, nil }
+describe Github::Issues::Labels, 'integration' do
 
   it { described_class::VALID_LABEL_INPUTS.should_not be_nil }
 
-  describe "#remove" do
-    let(:issue_id) { 1 }
-    let(:label_id) { 1 }
-
-    context "remove a label from an issue" do
-      before do
-        stub_delete("/repos/#{user}/#{repo}/issues/#{issue_id}/labels/#{label_id}").
-          to_return(:body => fixture('issues/labels.json'), :status => 200, :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should throw exception if issue-id not present" do
-        expect {
-          github.issues.labels.remove user, repo, nil
-        }.to raise_error(ArgumentError)
-      end
-
-      it "should remove label successfully" do
-        github.issues.labels.remove user, repo, issue_id, label_id
-        a_delete("/repos/#{user}/#{repo}/issues/#{issue_id}/labels/#{label_id}").should have_been_made
-      end
-
-      it "should return the resource" do
-        labels = github.issues.labels.remove user, repo, issue_id, label_id
-        labels.first.should be_a Hashie::Mash
-      end
-
-      it "should get the label information" do
-        labels = github.issues.labels.remove user, repo, issue_id, label_id
-        labels.first.name.should == 'bug'
-      end
-    end
-
-    context "remove all labels from an issue" do
-      before do
-        stub_delete("/repos/#{user}/#{repo}/issues/#{issue_id}/labels").
-          to_return(:body => "", :status => 204, :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should remove labels successfully" do
-        github.issues.labels.remove user, repo, issue_id
-        a_delete("/repos/#{user}/#{repo}/issues/#{issue_id}/labels").should have_been_made
-      end
-    end
-
-    context "failed to remove label from an issue" do
-      before do
-        stub_delete("/repos/#{user}/#{repo}/issues/#{issue_id}/labels/#{label_id}").
-          to_return(:body => fixture('issues/label.json'), :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should faile to retrieve resource" do
-        expect {
-          github.issues.labels.remove user, repo, issue_id, label_id
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # remove
-
-  describe "#replace" do
-    let(:issue_id) { 1 }
-    let(:labels) { "Label 1" }
-
-    context "labels added" do
-      before do
-        stub_put("/repos/#{user}/#{repo}/issues/#{issue_id}/labels").
-          to_return(:body => fixture('issues/labels.json'), :status => 200, :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to add labels if issue-id is missing" do
-        expect {
-          github.issues.labels.replace user, repo, nil, labels
-        }.to raise_error(ArgumentError)
-      end
-
-      it "should create resource successfully" do
-        github.issues.labels.replace user, repo, issue_id, labels
-        a_put("/repos/#{user}/#{repo}/issues/#{issue_id}/labels").should have_been_made
-      end
-
-      it "should return the resource" do
-        labels = github.issues.labels.replace user, repo, issue_id, labels
-        labels.first.should be_a Hashie::Mash
-      end
-
-      it "should get the label information" do
-        labels = github.issues.labels.replace user, repo, issue_id, labels
-        labels.first.name.should == 'bug'
-      end
-    end
-
-    context "failed to add labels" do
-      before do
-        stub_put("/repos/#{user}/#{repo}/issues/#{issue_id}/labels").
-          to_return(:body => fixture('issues/label.json'), :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
-
-      end
-
-      it "should fail to retrieve resource" do
-        expect {
-          github.issues.labels.replace user, repo, issue_id, labels
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # replace
-
 end # Github::Issues::Labels