github_api 0.8.4 → 0.8.5

data/spec/github/issues/comments/get_spec.rb

@@ -0,0 +1,49 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Issues::Comments, '#get' do
+  let(:user)   { 'peter-murach' }
+  let(:repo)   { 'github' }
+  let!(:comment_id) { 1 }
+  let(:request_path) { "/repos/#{user}/#{repo}/issues/comments/#{comment_id}" }
+
+  before {
+    stub_get(request_path).to_return(:body => body, :status => status,
+      :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resource found" do
+    let(:body) { fixture('issues/comment.json') }
+    let(:status) { 200 }
+
+    it { should respond_to :find }
+
+    it "should fail to get resource without comment id" do
+      expect { subject.get user, repo, nil }.to raise_error(ArgumentError)
+    end
+
+    it "should get the resource" do
+      subject.get user, repo, comment_id
+      a_get(request_path).should have_been_made
+    end
+
+    it "should get comment information" do
+      comment = subject.get user, repo, comment_id
+      comment.user.id.should == comment_id
+      comment.user.login.should == 'octocat'
+    end
+
+    it "should return mash" do
+      comment = subject.get user, repo, comment_id
+      comment.should be_a Hashie::Mash
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.get user, repo, comment_id }
+  end
+
+end # get

data/spec/github/issues/comments/list_spec.rb

@@ -0,0 +1,79 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Issues::Comments, '#list' do
+  let(:user)   { 'peter-murach' }
+  let(:repo)   { 'github' }
+  let!(:issue_id) { 1 }
+
+  before {
+    stub_get(request_path).to_return(:body => body, :status => status,
+      :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "on an issue" do
+    let(:request_path) { "/repos/#{user}/#{repo}/issues/#{issue_id}/comments" }
+    let(:body) { fixture('issues/comments.json') }
+    let(:status) { 200 }
+
+    it { should respond_to :all }
+
+    it "should fail to get resource without username" do
+      expect { subject.list user, nil }.to raise_error(ArgumentError)
+    end
+
+    it "should get the resources" do
+      subject.list user, repo, :issue_id => issue_id
+      a_get(request_path).should have_been_made
+    end
+
+    it_should_behave_like 'an array of resources' do
+      let(:requestable) { subject.list user, repo, :issue_id => issue_id }
+    end
+
+    it "should get issue comment information" do
+      comments = subject.list user, repo, :issue_id => issue_id
+      comments.first.user.login.should == 'octocat'
+    end
+
+    it "should yield to a block" do
+      yielded = []
+      result = subject.list(user, repo, :issue_id => issue_id) { |obj| yielded << obj }
+      yielded.should == result
+    end
+
+    it_should_behave_like 'request failure' do
+      let(:requestable) { subject.list user, repo, :issue_id => issue_id }
+    end
+  end
+
+  context "in a repository" do
+    let(:request_path) { "/repos/#{user}/#{repo}/issues/comments" }
+    let(:body) { fixture('issues/comments.json') }
+    let(:status) { 200 }
+
+    it "should get the resources" do
+      subject.list user, repo
+      a_get(request_path).should have_been_made
+    end
+
+    it_should_behave_like 'an array of resources' do
+      let(:requestable) { subject.list user, repo }
+    end
+
+    it "should get issue comment information" do
+      comments = subject.list user, repo
+      comments.first.user.login.should == 'octocat'
+    end
+
+    it "should yield to a block" do
+      yielded = []
+      result = subject.list(user, repo) { |obj| yielded << obj }
+      yielded.should == result
+    end
+  end
+
+end # list

data/spec/github/issues/comments_spec.rb

@@ -3,301 +3,7 @@
 require 'spec_helper'
 
 describe Github::Issues::Comments do
-  let(:github) { Github.new }
-  let(:user)   { 'peter-murach' }
-  let(:repo)   { 'github' }
-  let!(:comment_id) { 1 }
-  let!(:issue_id) { 1 }
-
-  after { github.user, github.repo, github.oauth_token = nil, nil, nil }
 
   it { described_class::VALID_ISSUE_COMMENT_PARAM_NAME.should_not be_nil }
 
-  describe '#list' do
-    it { github.issues.should respond_to :all }
-
-    context "on an issue" do
-      before do
-        stub_get("/repos/#{user}/#{repo}/issues/#{issue_id}/comments").
-          to_return(:body => fixture('issues/comments.json'),
-            :status => 200,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to get resource without username" do
-        expect {
-          github.issues.comments.list user, nil
-        }.to raise_error(ArgumentError)
-      end
-
-      it "should get the resources" do
-        github.issues.comments.list user, repo, :issue_id => issue_id
-        a_get("/repos/#{user}/#{repo}/issues/#{issue_id}/comments").should have_been_made
-      end
-
-      it "should return array of resources" do
-        comments = github.issues.comments.list user, repo, :issue_id => issue_id
-        comments.should be_an Array
-        comments.should have(1).items
-      end
-
-      it "should be a mash type" do
-        comments = github.issues.comments.list user, repo, :issue_id => issue_id
-        comments.first.should be_a Hashie::Mash
-      end
-
-      it "should get issue comment information" do
-        comments = github.issues.comments.list user, repo, :issue_id => issue_id
-        comments.first.user.login.should == 'octocat'
-      end
-
-      it "should yield to a block" do
-        yielded = []
-        result = github.issues.comments.list(user, repo, :issue_id => issue_id) { |obj| yielded << obj }
-        yielded.should == result
-      end
-    end
-
-    context "in a repository" do
-      before do
-        stub_get("/repos/#{user}/#{repo}/issues/comments").
-          to_return(:body => fixture('issues/comments.json'),
-            :status => 200,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should get the resources" do
-        github.issues.comments.list user, repo
-        a_get("/repos/#{user}/#{repo}/issues/comments").should have_been_made
-      end
-
-      it "should return array of resources" do
-        comments = github.issues.comments.list user, repo
-        comments.should be_an Array
-        comments.should have(1).items
-      end
-
-      it "should be a mash type" do
-        comments = github.issues.comments.list user, repo
-        comments.first.should be_a Hashie::Mash
-      end
-
-      it "should get issue comment information" do
-        comments = github.issues.comments.list user, repo
-        comments.first.user.login.should == 'octocat'
-      end
-
-      it "should yield to a block" do
-        yielded = []
-        result = github.issues.comments.list(user, repo) { |obj| yielded << obj }
-        yielded.should == result
-      end
-    end
-
-    context "resource not found" do
-      before do
-        stub_get("/repos/#{user}/#{repo}/issues/#{issue_id}/comments").
-          to_return(:body => "", :status => [404, "Not Found"])
-      end
-
-      it "should return 404 with a message 'Not Found'" do
-        expect {
-          github.issues.comments.list user, repo, :issue_id => issue_id
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # list
-
-  describe "#get" do
-    it { github.issues.comments.should respond_to :find }
-
-    context "resource found" do
-      before do
-        stub_get("/repos/#{user}/#{repo}/issues/comments/#{comment_id}").
-          to_return(:body => fixture('issues/comment.json'), :status => 200, :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to get resource without comment id" do
-        expect {
-          github.issues.comments.get user, repo, nil
-        }.to raise_error(ArgumentError)
-      end
-
-      it "should get the resource" do
-        github.issues.comments.get user, repo, comment_id
-        a_get("/repos/#{user}/#{repo}/issues/comments/#{comment_id}").should have_been_made
-      end
-
-      it "should get comment information" do
-        comment = github.issues.comments.get user, repo, comment_id
-        comment.user.id.should == comment_id
-        comment.user.login.should == 'octocat'
-      end
-
-      it "should return mash" do
-        comment = github.issues.comments.get user, repo, comment_id
-        comment.should be_a Hashie::Mash
-      end
-    end
-
-    context "resource not found" do
-      before do
-        stub_get("/repos/#{user}/#{repo}/issues/comments/#{comment_id}").
-          to_return(:body => fixture('issues/comment.json'),
-          :status => 404,
-          :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to retrive resource" do
-        expect {
-          github.issues.comments.get user, repo, comment_id
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # get
-
-  describe "#create" do
-    let(:issue_id) { 1 }
-    let(:inputs) { { 'body' => 'a new comment' } }
-
-    context "resouce created" do
-      before do
-        stub_post("/repos/#{user}/#{repo}/issues/#{issue_id}/comments").
-          with(:body => inputs).
-          to_return(:body => fixture('issues/comment.json'),
-          :status => 201,
-          :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to create resource if 'body' input is missing" do
-        expect {
-          github.issues.comments.create user, repo, issue_id, inputs.except('body')
-        }.to raise_error(Github::Error::RequiredParams)
-      end
-
-      it "should create resource successfully" do
-        github.issues.comments.create user, repo, issue_id, inputs
-        a_post("/repos/#{user}/#{repo}/issues/#{issue_id}/comments").
-          with(inputs).should have_been_made
-      end
-
-      it "should return the resource" do
-        comment = github.issues.comments.create user, repo, issue_id, inputs
-        comment.should be_a Hashie::Mash
-      end
-
-      it "should get the comment information" do
-        comment = github.issues.comments.create user, repo, issue_id, inputs
-        comment.user.login.should == 'octocat'
-      end
-    end
-
-    context "failed to create resource" do
-      before do
-        stub_post("/repos/#{user}/#{repo}/issues/#{issue_id}/comments").
-          with(inputs).
-          to_return(:body => fixture('issues/comment.json'),
-            :status => 404,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to retrieve resource" do
-        expect {
-          github.issues.comments.create user, repo, issue_id, inputs
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # create
-
-  describe "edit_comment" do
-    let(:comment_id) { 1 }
-    let(:inputs) { { 'body' => 'a new comment' } }
-
-    context "resouce edited" do
-      before do
-        stub_patch("/repos/#{user}/#{repo}/issues/comments/#{comment_id}").
-          with(inputs).
-          to_return(:body => fixture('issues/comment.json'),
-            :status => 201,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to create resource if 'body' input is missing" do
-        expect {
-          github.issues.comments.edit user, repo, comment_id, inputs.except('body')
-        }.to raise_error(Github::Error::RequiredParams)
-      end
-
-      it "should create resource successfully" do
-        github.issues.comments.edit user, repo, comment_id, inputs
-        a_patch("/repos/#{user}/#{repo}/issues/comments/#{comment_id}").
-          with(inputs).should have_been_made
-      end
-
-      it "should return the resource" do
-        comment = github.issues.comments.edit user, repo, comment_id, inputs
-        comment.should be_a Hashie::Mash
-      end
-
-      it "should get the comment information" do
-        comment = github.issues.comments.edit user, repo, comment_id, inputs
-        comment.user.login.should == 'octocat'
-      end
-    end
-
-    context "failed to create resource" do
-      before do
-        stub_patch("/repos/#{user}/#{repo}/issues/comments/#{comment_id}").
-          with(inputs).
-          to_return(:body => fixture('issues/comment.json'),
-            :status => 404,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to retrieve resource" do
-        expect {
-          github.issues.comments.edit user, repo, comment_id, inputs
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # edit
-
-  describe "#delete" do
-    let(:comment_id) { 1 }
-
-    context "resouce deleted" do
-      before do
-        stub_delete("/repos/#{user}/#{repo}/issues/comments/#{comment_id}").
-          to_return(:body => fixture('issues/comment.json'),
-            :status => 204,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to delete resource if comment_id is missing" do
-        expect {
-          github.issues.comments.delete user, repo, nil
-        }.to raise_error(ArgumentError)
-      end
-
-      it "should create resource successfully" do
-        github.issues.comments.delete user, repo, comment_id
-        a_delete("/repos/#{user}/#{repo}/issues/comments/#{comment_id}").
-          should have_been_made
-      end
-    end
-
-    context "failed to create resource" do
-      before do
-        stub_delete("/repos/#{user}/#{repo}/issues/comments/#{comment_id}").
-          to_return(:body => fixture('issues/comment.json'), :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to retrieve resource" do
-        expect {
-          github.issues.comments.delete user, repo, comment_id
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # delete
-
 end # Github::Issues::Comments

data/spec/github/issues/events/get_spec.rb

@@ -0,0 +1,49 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Issues::Events, '#list' do
+  let(:user) { 'peter-murach' }
+  let(:repo) { 'github' }
+  let(:event_id) { 1 }
+  let(:request_path) { "/repos/#{user}/#{repo}/issues/events/#{event_id}" }
+
+  before {
+    stub_get(request_path).to_return(:body => body, :status => status,
+      :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resource found" do
+    let(:body) { fixture('issues/event.json') }
+    let(:status) { 200 }
+
+    it { should respond_to :find }
+
+    it "should fail to get resource without event id" do
+      expect { subject.get user, repo, nil }.to raise_error(ArgumentError)
+    end
+
+    it "should get the resource" do
+      subject.get user, repo, event_id
+      a_get(request_path).should have_been_made
+    end
+
+    it "should get event information" do
+      event = subject.get user, repo, event_id
+      event.actor.id.should == event_id
+      event.actor.login.should == 'octocat'
+    end
+
+    it "should return mash" do
+      event = subject.get user, repo, event_id
+      event.should be_a Hashie::Mash
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.get user, repo, event_id }
+  end
+
+end # get