github_api 0.8.2 → 0.8.3

data/spec/github/issues/milestones/delete_spec.rb

@@ -0,0 +1,42 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Issues::Milestones, '#create' do
+  let(:user)   { 'peter-murach' }
+  let(:repo)   { 'github' }
+  let(:milestone_id) { 1 }
+  let(:request_path) { "/repos/#{user}/#{repo}/milestones/#{milestone_id}" }
+
+  before {
+    stub_delete(request_path).to_return(:body => body, :status => status,
+      :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resouce removed" do
+    let(:body) { fixture('issues/milestone.json') }
+    let(:status) { 201 }
+
+    it "should remove resource successfully" do
+      subject.delete user, repo, milestone_id
+      a_delete(request_path).should have_been_made
+    end
+
+    it "should return the resource" do
+      milestone = subject.delete user, repo, milestone_id
+      milestone.should be_a Hashie::Mash
+    end
+
+    it "should get the milestone information" do
+      milestone = subject.delete user, repo, milestone_id
+      milestone.title.should == 'v1.0'
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.delete user, repo, milestone_id }
+  end
+
+end # delete

data/spec/github/issues/milestones/get_spec.rb

@@ -0,0 +1,49 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Issues::Milestones, '#get' do
+  let(:user)   { 'peter-murach' }
+  let(:repo)   { 'github' }
+  let(:milestone_id) { 1 }
+  let(:request_path) { "/repos/#{user}/#{repo}/milestones/#{milestone_id}" }
+
+  before {
+    stub_get(request_path).to_return(:body => body, :status => status,
+      :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resource found" do
+    let(:body) { fixture('issues/milestone.json') }
+    let(:status) { 200 }
+
+    it { subject.should respond_to :find }
+
+    it "should fail to get resource without milestone id" do
+      expect { subject.get user, repo, nil }.to raise_error(ArgumentError)
+    end
+
+    it "should get the resource" do
+      subject.get user, repo, milestone_id
+      a_get(request_path).should have_been_made
+    end
+
+    it "should get milestone information" do
+      milestone = subject.get user, repo, milestone_id
+      milestone.number.should == milestone_id
+      milestone.title.should == 'v1.0'
+    end
+
+    it "should return mash" do
+      milestone = subject.get user, repo, milestone_id
+      milestone.should be_a Hashie::Mash
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.get user, repo, milestone_id }
+  end
+
+end # get

data/spec/github/issues/milestones/list_spec.rb

@@ -0,0 +1,52 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Issues::Milestones, '#list' do
+  let(:user)   { 'peter-murach' }
+  let(:repo)   { 'github' }
+  let(:request_path) { "/repos/#{user}/#{repo}/milestones" }
+
+  before {
+    stub_get(request_path).to_return(:body => body, :status => status,
+      :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resource found" do
+    let(:body) { fixture('issues/milestones.json') }
+    let(:status) { 200 }
+
+    it { subject.should respond_to :all }
+
+    it "should fail to get resource without username" do
+      expect { subject.list nil, repo }.to raise_error(ArgumentError)
+    end
+
+    it "should get the resources" do
+      subject.list user, repo
+      a_get(request_path).should have_been_made
+    end
+
+    it_should_behave_like 'an array of resources' do
+      let(:requestable) { subject.list user, repo }
+    end
+
+    it "should get issue information" do
+      milestones = subject.list user, repo
+      milestones.first.title.should == 'v1.0'
+    end
+
+    it "should yield to a block" do
+      yielded = []
+      result = subject.list(user, repo) { |obj| yielded << obj }
+      yielded.should == result
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.list user, repo }
+  end
+
+end # list

data/spec/github/issues/milestones/update_spec.rb

@@ -0,0 +1,57 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Issues::Milestones, '#update' do
+  let(:user)   { 'peter-murach' }
+  let(:repo)   { 'github' }
+  let(:milestone_id) { 1 }
+  let(:request_path) { "/repos/#{user}/#{repo}/milestones/#{milestone_id}" }
+  let(:inputs) {
+    {
+      "title" => "String",
+      "state" => "open or closed",
+      "description" => "String",
+      "due_on" => "Time"
+    }
+  }
+
+  before {
+    stub_patch(request_path).with(inputs).
+      to_return(:body => body, :status => status,
+      :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resouce updated" do
+    let(:body) { fixture('issues/milestone.json') }
+    let(:status) { 201 }
+
+    it "should fail to create resource if 'number' input is missing" do
+      expect {
+        subject.update user, repo, nil, inputs
+      }.to raise_error(ArgumentError)
+    end
+
+    it "should update resource successfully" do
+      subject.update user, repo, milestone_id, inputs
+      a_patch(request_path).with(inputs).should have_been_made
+    end
+
+    it "should return the resource" do
+      milestone = subject.update user, repo, milestone_id, inputs
+      milestone.should be_a Hashie::Mash
+    end
+
+    it "should get the milestone information" do
+      milestone = subject.update user, repo, milestone_id, inputs
+      milestone.title.should == 'v1.0'
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.update user, repo, milestone_id, inputs }
+  end
+
+end # update

data/spec/github/issues/milestones_spec.rb

@@ -3,284 +3,9 @@
 require 'spec_helper'
 
 describe Github::Issues::Milestones do
-  let(:github) { Github.new }
-  let(:user)   { 'peter-murach' }
-  let(:repo)   { 'github' }
-
-  after { reset_authentication_for github }
 
   it { described_class::VALID_MILESTONE_OPTIONS.should_not be_nil }
-  it { described_class::VALID_MILESTONE_INPUTS.should_not be_nil }
-
-  describe '#list' do
-    it { github.issues.milestones.should respond_to :all }
-
-    context "resource found" do
-      before do
-        stub_get("/repos/#{user}/#{repo}/milestones").
-          to_return(:body => fixture('issues/milestones.json'),
-            :status => 200,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to get resource without username" do
-        expect {
-          github.issues.milestones.list nil, repo
-        }.to raise_error(ArgumentError)
-      end
-
-      it "should get the resources" do
-        github.issues.milestones.list user, repo
-        a_get("/repos/#{user}/#{repo}/milestones").should have_been_made
-      end
-
-      it "should return array of resources" do
-        milestones = github.issues.milestones.list user, repo
-        milestones.should be_an Array
-        milestones.should have(1).items
-      end
-
-      it "should be a mash type" do
-        milestones = github.issues.milestones.list user, repo
-        milestones.first.should be_a Hashie::Mash
-      end
-
-      it "should get issue information" do
-        milestones = github.issues.milestones.list user, repo
-        milestones.first.title.should == 'v1.0'
-      end
-
-      it "should yield to a block" do
-        github.issues.milestones.should_receive(:list).
-          with(user, repo).and_yield('web')
-        github.issues.milestones.list(user, repo) { |param| 'web' }.should == 'web'
-      end
-    end
-
-    context "resource not found" do
-      before do
-        stub_get("/repos/#{user}/#{repo}/milestones").
-          to_return(:body => "", :status => [404, "Not Found"])
-      end
-
-      it "should return 404 with a message 'Not Found'" do
-        expect {
-          github.issues.milestones.list user, repo
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # list
-
-  describe "#get" do
-    let(:milestone_id) { 1 }
-
-    it { github.issues.milestones.should respond_to :find }
-
-    context "resource found" do
-      before do
-        stub_get("/repos/#{user}/#{repo}/milestones/#{milestone_id}").
-          to_return(:body => fixture('issues/milestone.json'),
-            :status => 200,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to get resource without milestone id" do
-        expect {
-          github.issues.milestones.get user, repo, nil
-        }.to raise_error(ArgumentError)
-      end
-
-      it "should get the resource" do
-        github.issues.milestones.get user, repo, milestone_id
-        a_get("/repos/#{user}/#{repo}/milestones/#{milestone_id}").should have_been_made
-      end
-
-      it "should get milestone information" do
-        milestone = github.issues.milestones.get user, repo, milestone_id
-        milestone.number.should == milestone_id
-        milestone.title.should == 'v1.0'
-      end
-
-      it "should return mash" do
-        milestone = github.issues.milestones.get user, repo, milestone_id
-        milestone.should be_a Hashie::Mash
-      end
-    end
-
-    context "resource not found" do
-      before do
-        stub_get("/repos/#{user}/#{repo}/milestones/#{milestone_id}").
-          to_return(:body => fixture('issues/milestone.json'),
-            :status => 404,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to retrive resource" do
-        expect {
-          github.issues.milestones.get user, repo, milestone_id
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # get
-
-  describe "create_milestone" do
-    let(:inputs) {
-      {
-        "title" => "String",
-        "state" => "open or closed",
-        "description" => "String",
-        "due_on" => "Time"
-      }
-    }
-
-    context "resouce created" do
-      before do
-        stub_post("/repos/#{user}/#{repo}/milestones").with(inputs).
-          to_return(:body => fixture('issues/milestone.json'),
-            :status => 201,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
 
-      it "should fail to create resource if 'title' input is missing" do
-        expect {
-          github.issues.milestones.create user, repo, inputs.except('title')
-        }.to raise_error(Github::Error::RequiredParams)
-      end
-
-      it "should create resource successfully" do
-        github.issues.milestones.create user, repo, inputs
-        a_post("/repos/#{user}/#{repo}/milestones").with(inputs).should have_been_made
-      end
-
-      it "should return the resource" do
-        milestone = github.issues.milestones.create user, repo, inputs
-        milestone.should be_a Hashie::Mash
-      end
-
-      it "should get the milestone information" do
-        milestone = github.issues.milestones.create user, repo, inputs
-        milestone.title.should == 'v1.0'
-      end
-    end
-
-    context "failed to create resource" do
-      before do
-        stub_post("/repos/#{user}/#{repo}/milestones").with(inputs).
-          to_return(:body => fixture('issues/milestone.json'),
-            :status => 404,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-
-      end
-
-      it "should faile to retrieve resource" do
-        expect {
-          github.issues.milestones.create user, repo, inputs
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # create
-
-  describe "#update" do
-    let(:milestone_id) { 1 }
-    let(:inputs) {
-      {
-        "title" => "String",
-        "state" => "open or closed",
-        "description" => "String",
-        "due_on" => "Time"
-      }
-    }
-
-    context "resouce updated" do
-      before do
-        stub_patch("/repos/#{user}/#{repo}/milestones/#{milestone_id}").
-          with(inputs).
-          to_return(:body => fixture('issues/milestone.json'), :status => 201, :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to create resource if 'title' input is missing" do
-        expect {
-          github.issues.milestones.update user, repo, milestone_id, inputs.except('title')
-        }.to raise_error(Github::Error::RequiredParams)
-      end
-
-      it "should update resource successfully" do
-        github.issues.milestones.update user, repo, milestone_id, inputs
-        a_patch("/repos/#{user}/#{repo}/milestones/#{milestone_id}").
-          with(inputs).should have_been_made
-      end
-
-      it "should return the resource" do
-        milestone = github.issues.milestones.update user, repo, milestone_id, inputs
-        milestone.should be_a Hashie::Mash
-      end
-
-      it "should get the milestone information" do
-        milestone = github.issues.milestones.update user, repo, milestone_id, inputs
-        milestone.title.should == 'v1.0'
-      end
-    end
-
-    context "failed to create resource" do
-      before do
-        stub_patch("/repos/#{user}/#{repo}/milestones/#{milestone_id}").
-          with(inputs).
-          to_return(:body => fixture('issues/milestone.json'),
-            :status => 404,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-
-      end
-
-      it "should faile to retrieve resource" do
-        expect {
-          github.issues.milestones.update user, repo, milestone_id, inputs
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # update
-
-  describe "#delete" do
-    let(:milestone_id) { 1 }
-
-    context "resouce removed" do
-      before do
-        stub_delete("/repos/#{user}/#{repo}/milestones/#{milestone_id}").
-          to_return(:body => fixture('issues/milestone.json'),
-            :status => 201,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should remove resource successfully" do
-        github.issues.milestones.delete user, repo, milestone_id
-        a_delete("/repos/#{user}/#{repo}/milestones/#{milestone_id}").
-          should have_been_made
-      end
-
-      it "should return the resource" do
-        milestone = github.issues.milestones.delete user, repo, milestone_id
-        milestone.should be_a Hashie::Mash
-      end
-
-      it "should get the milestone information" do
-        milestone = github.issues.milestones.delete user, repo, milestone_id
-        milestone.title.should == 'v1.0'
-      end
-    end
-
-    context "failed to remove resource" do
-      before do
-        stub_delete("/repos/#{user}/#{repo}/milestones/#{milestone_id}").
-          to_return(:body => fixture('issues/milestone.json'),
-            :status => 404,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should faile to retrieve resource" do
-        expect {
-          github.issues.milestones.delete user, repo, milestone_id
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # delete
+  it { described_class::VALID_MILESTONE_INPUTS.should_not be_nil }
 
 end # Github::Issues::Milestones