github_api 0.8.2 → 0.8.3

data/spec/github/issues/assignees_spec.rb

@@ -1,101 +1,5 @@
 require 'spec_helper'
 
 describe Github::Issues::Assignees do
-  let(:github) { Github::Issues::Assignees.new }
-  let(:user) { 'peter-murach' }
-  let(:repo) { 'github' }
-  let(:assignee) { 'octocat' }
-
-  after { github.user, github.repo, github.oauth_token = nil, nil, nil }
-
-  describe '#list' do
-    context 'resources found' do
-      before do
-        stub_get("/repos/#{user}/#{repo}/assignees").
-          to_return(:body => fixture('repos/assignees.json'),
-            :status => 200,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it 'should get the resources' do
-        github.list user, repo
-        a_get("/repos/#{user}/#{repo}/assignees").should have_been_made
-      end
-
-      it "should return array of resources" do
-        assignees = github.list user, repo
-        assignees.should be_an Array
-        assignees.should have(1).items
-      end
-
-      it "should be a mash type" do
-        assignees = github.list user, repo
-        assignees.first.should be_a Hashie::Mash
-      end
-
-      it "should get collaborator information" do
-        assignees = github.list user, repo
-        assignees.first.login.should == 'octocat'
-      end
-
-      it "should yield to a block" do
-        github.should_receive(:list).with(user, repo).and_yield('web')
-        github.list(user, repo) { |param| 'web' }
-      end
-    end
-
-    context "resource not found" do
-      before do
-        stub_get("/repos/#{user}/#{repo}/assignees").
-          to_return(:body => "", :status => [404, "Not Found"],
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should return 404 with a message 'Not Found'" do
-        expect {
-          github.list user, repo
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # list
-
-  describe '#check' do
-    context "resource found " do
-      before do
-        stub_get("/repos/#{user}/#{repo}/assignees/#{assignee}").
-          to_return(:body => '', :status => 204,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to get resource without collaborator name" do
-        expect {
-          github.check user, repo, nil
-        }.to raise_error(ArgumentError)
-      end
-
-      it "should get the resource" do
-        github.check user, repo, assignee
-        a_get("/repos/#{user}/#{repo}/assignees/#{assignee}").should have_been_made
-      end
-
-      it "should find assignee" do
-        github.should_receive(:check).with(user, repo, assignee) { true }
-        github.check user, repo, assignee
-      end
-    end
-
-    context "resource not found" do
-      before do
-        stub_get("/repos/#{user}/#{repo}/assignees/#{assignee}").
-          to_return(:body => '', :status => 404,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to retrieve resource" do
-        github.should_receive(:check).with(user, repo, assignee) { false }
-        github.check user, repo, assignee
-      end
-    end
-  end # check
 
 end # Github::Repos::Assignees

data/spec/github/issues/create_spec.rb

@@ -0,0 +1,60 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Issues, '#create' do
+  let(:user)   { 'peter-murach' }
+  let(:repo)   { 'github' }
+  let(:request_path) { "/repos/#{user}/#{repo}/issues" }
+  let(:inputs) {
+    {
+        "title" =>  "Found a bug",
+        "body" => "I'm having a problem with this.",
+        "assignee" =>  "octocat",
+        "milestone" => 1,
+        "labels" => [
+          "Label1",
+          "Label2"
+        ]
+    }
+  }
+
+  before {
+    stub_post(request_path).with(inputs).
+      to_return(:body => body, :status => status,
+      :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resouce created" do
+    let(:body) { fixture('issues/issue.json') }
+    let(:status) { 201 }
+
+    it "should fail to create resource if 'title' input is missing" do
+      expect {
+        subject.create user, repo, inputs.except('title')
+      }.to raise_error(Github::Error::RequiredParams)
+    end
+
+    it "should create resource successfully" do
+      subject.create user, repo, inputs
+      a_post(request_path).with(inputs).should have_been_made
+    end
+
+    it "should return the resource" do
+      issue = subject.create user, repo, inputs
+      issue.should be_a Hashie::Mash
+    end
+
+    it "should get the issue information" do
+      issue = subject.create(user, repo, inputs)
+      issue.title.should == 'Found a bug'
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.create user, repo, inputs }
+  end
+
+end # create

data/spec/github/issues/edit_spec.rb

@@ -0,0 +1,61 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Issues, '#create' do
+  let(:user)   { 'peter-murach' }
+  let(:repo)   { 'github' }
+  let(:issue_id) { 1347 }
+  let(:request_path) { "/repos/#{user}/#{repo}/issues/#{issue_id}" }
+  let(:inputs) {
+    {
+        "title" =>  "Found a bug",
+        "body" => "I'm having a problem with this.",
+        "assignee" =>  "octocat",
+        "milestone" => 1,
+        "labels" => [
+          "Label1",
+          "Label2"
+        ]
+    }
+  }
+
+  before {
+    stub_patch(request_path).with(inputs).
+      to_return(:body => body, :status => status,
+      :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resource edited successfully" do
+    let(:body) { fixture("issues/issue.json") }
+    let(:status) { 200 }
+
+    it "should fail to edit without 'user/repo' parameters" do
+      expect {
+        subject.edit nil, repo, issue_id
+      }.to raise_error(ArgumentError)
+    end
+
+    it "should edit the resource" do
+      subject.edit user, repo, issue_id, inputs
+      a_patch(request_path).with(inputs).should have_been_made
+    end
+
+    it "should return resource" do
+      issue = subject.edit user, repo, issue_id, inputs
+      issue.should be_a Hashie::Mash
+    end
+
+    it "should be able to retrieve information" do
+      issue = subject.edit user, repo, issue_id, inputs
+      issue.title.should == 'Found a bug'
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.edit user, repo, issue_id, inputs }
+  end
+
+end # edit

data/spec/github/issues/events_spec.rb

@@ -76,23 +76,23 @@ describe Github::Issues::Events do
         end
 
         it "should get the resources" do
-          github.issues.events.list user, repo, issue_id
+          github.issues.events.list user, repo, :issue_id => issue_id
           a_get("/repos/#{user}/#{repo}/issues/#{issue_id}/events").should have_been_made
         end
 
         it "should return array of resources" do
-          events = github.issues.events.list user, repo, issue_id
+          events = github.issues.events.list user, repo, :issue_id => issue_id
           events.should be_an Array
           events.should have(1).items
         end
 
         it "should be a mash type" do
-          events = github.issues.events.list user, repo, issue_id
+          events = github.issues.events.list user, repo, :issue_id => issue_id
           events.first.should be_a Hashie::Mash
         end
 
         it "should get issue information" do
-          events = github.issues.events.list user, repo, issue_id
+          events = github.issues.events.list user, repo, :issue_id => issue_id
           events.first.actor.login.should == 'octocat'
         end
 

data/spec/github/issues/get_spec.rb

@@ -0,0 +1,49 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Issues, '#get' do
+  let(:user)   { 'peter-murach' }
+  let(:repo)   { 'github' }
+  let(:issue_id) { 1347 }
+  let(:request_path) { "/repos/#{user}/#{repo}/issues/#{issue_id}" }
+
+  before {
+    stub_get(request_path).to_return(:body => body, :status => status,
+      :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resource found" do
+    let(:body) { fixture('issues/issue.json') }
+    let(:status) { 200 }
+
+    it { should respond_to :find }
+
+    it "should fail to get resource without issue id" do
+      expect { subject.get user, repo, nil }.to raise_error(ArgumentError)
+    end
+
+    it "should get the resource" do
+      subject.get user, repo, issue_id
+      a_get(request_path).should have_been_made
+    end
+
+    it "should get issue information" do
+      issue = subject.get user, repo, issue_id
+      issue.number.should == issue_id
+      issue.title.should == 'Found a bug'
+    end
+
+    it "should return mash" do
+      issue = subject.get user, repo, issue_id
+      issue.should be_a Hashie::Mash
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.get user, repo, issue_id }
+  end
+
+end # get

data/spec/github/issues/issues_spec.rb

@@ -0,0 +1,19 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Issues do
+
+  after { reset_authentication_for subject }
+
+  its(:assignees)  { should be_a Github::Issues::Assignees }
+
+  its(:comments)   { should be_a Github::Issues::Comments }
+
+  its(:events)     { should be_a Github::Issues::Events }
+
+  its(:labels)     { should be_a Github::Issues::Labels }
+
+  its(:milestones) { should be_a Github::Issues::Milestones }
+
+end # Github::Issues

data/spec/github/issues/list_spec.rb

@@ -0,0 +1,90 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Issues, '#list' do
+  let(:request_path) { "/issues" }
+  let(:body) { fixture('issues/issues.json') }
+  let(:status) { 200 }
+
+  before {
+    stub_get(request_path).to_return(:body => body, :status => status,
+      :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resource found" do
+
+    it { should respond_to(:all) }
+
+    it "should get the resources" do
+      subject.list
+      a_get(request_path).should have_been_made
+    end
+
+    it_should_behave_like 'an array of resources' do
+      let(:requestable) { subject.list }
+    end
+
+    it "should get issue information" do
+      issues = subject.list
+      issues.first.title.should == 'Found a bug'
+    end
+
+    it "should yield to a block" do
+      yielded = []
+      result = subject.list { |obj| yielded << obj }
+      yielded.should == result
+    end
+  end
+
+  context 'for a given organization' do
+    let(:org) { 'github' }
+    let(:request_path) { "/orgs/#{org}/issues" }
+
+    it 'should get the resources' do
+      subject.list :org => org
+      a_get(request_path).should have_been_made
+    end
+  end
+
+  context 'for an user' do
+    let(:request_path) { "/user/issues" }
+
+    it 'should get the resources' do
+      subject.list :user
+      a_get(request_path).should have_been_made
+    end
+  end
+
+  context "for a repository" do
+    let(:user)   { 'peter-murach' }
+    let(:repo)   { 'github' }
+    let(:request_path) { "/repos/#{user}/#{repo}/issues" }
+
+    it "should get the resources" do
+      subject.list :user => user, :repo => repo
+      a_get(request_path).should have_been_made
+    end
+
+    it_should_behave_like 'an array of resources' do
+      let(:requestable) { subject.list :user => user, :repo => repo }
+    end
+
+    it "should get repository issue information" do
+      repo_issues = subject.list :user => user, :repo => repo
+      repo_issues.first.title.should == 'Found a bug'
+    end
+
+    it "should yield to a block" do
+      yielded = []
+      result = subject.list(:user => user, :repo => repo) { |obj| yielded << obj }
+      yielded.should == result
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.list }
+  end
+end # list

data/spec/github/issues/milestones/create_spec.rb

@@ -0,0 +1,56 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Issues::Milestones, '#create' do
+  let(:user)   { 'peter-murach' }
+  let(:repo)   { 'github' }
+  let(:request_path) { "/repos/#{user}/#{repo}/milestones" }
+  let(:inputs) {
+    {
+      "title" => "String",
+      "state" => "open or closed",
+      "description" => "String",
+      "due_on" => "Time"
+    }
+  }
+
+  before {
+    stub_post(request_path).with(inputs).
+      to_return(:body => body, :status => status,
+      :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resouce created" do
+    let(:body) { fixture('issues/milestone.json') }
+    let(:status) { 201 }
+
+    it "should fail to create resource if 'title' input is missing" do
+      expect {
+        subject.create user, repo, inputs.except('title')
+      }.to raise_error(Github::Error::RequiredParams)
+    end
+
+    it "should create resource successfully" do
+      subject.create user, repo, inputs
+      a_post(request_path).with(inputs).should have_been_made
+    end
+
+    it "should return the resource" do
+      milestone = subject.create user, repo, inputs
+      milestone.should be_a Hashie::Mash
+    end
+
+    it "should get the milestone information" do
+      milestone = subject.create user, repo, inputs
+      milestone.title.should == 'v1.0'
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.create user, repo, inputs }
+  end
+
+end # create