github_api 0.7.1 → 0.7.2

data/spec/github/repos/downloads/get_spec.rb

@@ -0,0 +1,58 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Repos::Downloads, '#get' do
+  let(:github) { Github.new }
+  let(:user) { 'peter-murach' }
+  let(:repo) { 'github' }
+  let(:download_id) { 1 }
+  let(:request_path) { "/repos/#{user}/#{repo}/downloads/#{download_id}" }
+
+  after { reset_authentication_for(github) }
+
+  before {
+    stub_get(request_path).
+      to_return(:body => body, :status => status,
+        :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  context "resource found" do
+    let(:body)   { fixture('repos/download.json') }
+    let(:status) { 200 }
+
+    it { should respond_to :find }
+
+    it "should fail to get resource without download id" do
+      expect { subject.get user, repo, nil }.to raise_error(ArgumentError)
+    end
+
+    it "should get the resource" do
+      github.repos.downloads.get user, repo, download_id
+      a_get(request_path).should have_been_made
+    end
+
+    it "should get download information" do
+      download = subject.get user, repo, download_id
+      download.id.should == download_id
+      download.name.should == 'new_file.jpg'
+    end
+
+    it "should return mash" do
+      download = subject.get user, repo, download_id
+      download.should be_a Hashie::Mash
+    end
+  end
+
+  context "resource not found" do
+    let(:body) { "" }
+    let(:status) { [404, "Not Found"] }
+
+    it "should fail to retrive resource" do
+      expect {
+        subject.get user, repo, download_id
+      }.to raise_error(Github::Error::NotFound)
+    end
+  end
+end # get
+

data/spec/github/repos/downloads/list_spec.rb

@@ -0,0 +1,63 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Repos::Downloads, '#list' do
+  let(:user) { 'peter-murach' }
+  let(:repo) { 'github' }
+  let(:request_path) { "/repos/#{user}/#{repo}/downloads" }
+
+  before {
+    stub_get(request_path).
+      to_return(:body => body, :status => status,
+        :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resource found" do
+    let(:body)   { fixture('repos/downloads.json') }
+    let(:status) { 200 }
+
+    it { should respond_to :all }
+
+    it "should fail to get resource without username" do
+      expect { subject.list }.to raise_error(ArgumentError)
+    end
+
+    it "should get the resources" do
+      subject.list user, repo
+      a_get(request_path).should have_been_made
+    end
+
+    it "should return array of resources" do
+      downloads = subject.list user, repo
+      downloads.should be_an Array
+      downloads.should have(1).items
+    end
+
+    it "should be a mash type" do
+      downloads = subject.list user, repo
+      downloads.first.should be_a Hashie::Mash
+    end
+
+    it "should get download information" do
+      downloads = subject.list user, repo
+      downloads.first.name.should == 'new_file.jpg'
+    end
+
+    it "should yield to a block" do
+      subject.should_receive(:list).with(user, repo).and_yield('web')
+      subject.list(user, repo) { |param| 'web' }
+    end
+  end
+
+  context "resource not found" do
+    let(:body)   { "" }
+    let(:status) { [404, "Not Found"] }
+
+    it "should return 404 with a message 'Not Found'" do
+      expect { subject.list user, repo }.to raise_error(Github::Error::NotFound)
+    end
+  end
+end # list

data/spec/github/repos/downloads/upload_spec.rb

@@ -0,0 +1,32 @@
+# encoding: utf-8
+
+require 'spec_helper'
+require 'github_api/s3_uploader'
+
+describe Github::Repos::Downloads do
+  let(:user) { 'peter-murach' }
+  let(:repo) { 'github' }
+
+  after { reset_authentication_for(subject) }
+
+  let(:resource) { stub(:resource) }
+  let(:filename) { 'filename' }
+  let(:res)      { stub(:response, :body => 'success') }
+  let(:uploader) { stub(:uploader, :send => res) }
+
+  before { Github::S3Uploader.stub(:new) { uploader } }
+
+  it "should fail if resource is of incorrect type" do
+    expect {
+      subject.upload resource, nil
+    }.to raise_error(ArgumentError)
+  end
+
+  it "should upload resource successfully" do
+    res = stub(:response, :body => 'success')
+    uploader = stub(:uploader, :send => res)
+    Github::S3Uploader.should_receive(:new).with(resource, filename) { uploader }
+    subject.upload(resource, filename).should == 'success'
+  end
+end # upload
+

data/spec/github/repos/downloads_spec.rb

@@ -1,245 +1,13 @@
 # encoding: utf-8
 
 require 'spec_helper'
-require 'github_api/s3_uploader'
 
 describe Github::Repos::Downloads do
-  let(:github) { Github.new }
-  let(:user) { 'peter-murach' }
-  let(:repo) { 'github' }
 
-  after { reset_authentication_for(github) }
+  after { reset_authentication_for(subject) }
 
   it { described_class::VALID_DOWNLOAD_PARAM_NAMES.should_not be_nil }
 
   it { described_class::REQUIRED_PARAMS.should_not be_nil }
 
-  describe "#list" do
-
-    before do
-      stub_get("/repos/#{user}/#{repo}/downloads").
-        to_return(:body => body, :status => status,
-          :headers => {:content_type => "application/json; charset=utf-8"})
-    end
-
-    context "resource found" do
-      let(:body)   { fixture('repos/downloads.json') }
-      let(:status) { 200 }
-
-      it { should respond_to :list }
-
-      it "should fail to get resource without username" do
-        expect { github.repos.downloads.list }.to raise_error(ArgumentError)
-      end
-
-      it "should get the resources" do
-        github.repos.downloads.list  user, repo
-        a_get("/repos/#{user}/#{repo}/downloads").should have_been_made
-      end
-
-      it "should return array of resources" do
-        downloads = github.repos.downloads.list user, repo
-        downloads.should be_an Array
-        downloads.should have(1).items
-      end
-
-      it "should be a mash type" do
-        downloads = github.repos.downloads.list user, repo
-        downloads.first.should be_a Hashie::Mash
-      end
-
-      it "should get download information" do
-        downloads = github.repos.downloads.list user, repo
-        downloads.first.name.should == 'new_file.jpg'
-      end
-
-      it "should yield to a block" do
-        github.repos.downloads.should_receive(:list).
-          with(user, repo).and_yield('web')
-        github.repos.downloads.list(user, repo) { |param| 'web' }
-      end
-    end
-
-    context "resource not found" do
-      let(:body)   { "" }
-      let(:status) { [404, "Not Found"] }
-
-      it "should return 404 with a message 'Not Found'" do
-        expect {
-          github.repos.downloads.list user, repo
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # list
-
-  describe "#get" do
-    let(:download_id) { 1 }
-
-    before do
-      stub_get("/repos/#{user}/#{repo}/downloads/#{download_id}").
-        to_return(:body => body, :status => status,
-          :headers => {:content_type => "application/json; charset=utf-8"})
-    end
-
-    context "resource found" do
-      let(:body)   { fixture('repos/download.json') }
-      let(:status) { 200 }
-
-      it { github.repos.downloads.should respond_to :find }
-
-      it "should fail to get resource without download id" do
-        expect {
-          github.repos.downloads.get user, repo, nil
-        }.to raise_error(ArgumentError)
-      end
-
-      it "should get the resource" do
-        github.repos.downloads.get user, repo, download_id
-        a_get("/repos/#{user}/#{repo}/downloads/#{download_id}").should have_been_made
-      end
-
-      it "should get download information" do
-        download = github.repos.downloads.get user, repo, download_id
-        download.id.should == download_id
-        download.name.should == 'new_file.jpg'
-      end
-
-      it "should return mash" do
-        download = github.repos.downloads.get user, repo, download_id
-        download.should be_a Hashie::Mash
-      end
-    end
-
-    context "resource not found" do
-      let(:body) { "" }
-      let(:status) { [404, "Not Found"] }
-
-      it "should fail to retrive resource" do
-        expect {
-          github.repos.downloads.get user, repo, download_id
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # get
-
-  describe "#delete" do
-    let(:download_id) { 1 }
-
-    before do
-      stub_delete("/repos/#{user}/#{repo}/downloads/#{download_id}").
-        to_return(:body => body, :status => status,
-          :headers => { :content_type => "application/json; charset=utf-8"})
-    end
-
-    context "resource deleted successfully" do
-      let(:body)   { "" }
-      let(:status) { 204 }
-
-      it "should fail to delete without 'user/repo' parameters" do
-        expect { github.repos.downloads.delete }.to raise_error(ArgumentError)
-      end
-
-      it "should fail to delete resource without 'download_id'" do
-        expect {
-          github.repos.downloads.delete user, repo
-        }.to raise_error(ArgumentError)
-      end
-
-      it "should delete the resource" do
-        github.repos.downloads.delete user, repo, download_id
-        a_delete("/repos/#{user}/#{repo}/downloads/#{download_id}").should have_been_made
-      end
-    end
-
-    context "failed to delete resource" do
-      let(:body)   { "" }
-      let(:status) { [404, "Not Found"] }
-
-      it "should fail to find resource" do
-        expect {
-          github.repos.downloads.delete user, repo, download_id
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # delete
-
-  describe "#create" do
-    let(:inputs) { {:name => 'new_file.jpg', :size => 114034, :description => "Latest release", :content_type => 'text/plain'} }
-
-    before do
-      stub_post("/repos/#{user}/#{repo}/downloads").with(inputs).
-        to_return(:body => body, :status => status,
-          :headers => {:content_type => "application/json; charset=utf-8"})
-    end
-
-    context "resouce created" do
-      let(:body)   { fixture('repos/download_s3.json') }
-      let(:status) { 201}
-
-      it "should fail to create resource if 'name' input is missing" do
-        expect {
-          github.repos.downloads.create user, repo, inputs.except(:name)
-        }.to raise_error(Github::Error::RequiredParams)
-      end
-
-      it "should failt to create resource if 'size' input is missing" do
-        expect {
-          github.repos.downloads.create user, repo, inputs.except(:size)
-        }.to raise_error(Github::Error::RequiredParams)
-      end
-
-      it "should create resource successfully" do
-        github.repos.downloads.create user, repo, inputs
-        a_post("/repos/#{user}/#{repo}/downloads").with(inputs).should have_been_made
-      end
-
-      it "should return the resource" do
-        download = github.repos.downloads.create user, repo, inputs
-        download.should be_a Hashie::Mash
-      end
-
-      it "should get the download information" do
-        download = github.repos.downloads.create user, repo, inputs
-        download.name.should == 'new_file.jpg'
-      end
-    end
-
-    context "failed to create resource" do
-      let(:body)   { "" }
-      let(:status) { [404, "Not Found"] }
-
-      it "should faile to retrieve resource" do
-        expect {
-          github.repos.downloads.create user, repo, inputs
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # create
-
-  describe 'upload' do
-    let(:resource) { stub(:resource) }
-    let(:filename) { 'filename' }
-    let(:res)      { stub(:response, :body => 'success') }
-    let(:uploader) { stub(:uploader, :send => res) }
-
-    context 'resource uploaded' do
-      before do
-        Github::S3Uploader.stub(:new) { uploader }
-      end
-
-      it "should fail if resource is of incorrect type" do
-        expect {
-          github.repos.downloads.upload resource, nil
-        }.to raise_error(ArgumentError)
-      end
-
-      it "should upload resource successfully" do
-        res = stub(:response, :body => 'success')
-        uploader = stub(:uploader, :send => res)
-        Github::S3Uploader.should_receive(:new).with(resource, filename) { uploader }
-        github.repos.downloads.upload(resource, filename).should == 'success'
-      end
-    end
-  end # upload
-
 end # Github::Repos::Downloads

data/spec/github/repos_spec.rb

@@ -8,6 +8,8 @@ describe Github::Repos, 'integration' do
 
   its(:collaborators) { should be_a Github::Repos::Collaborators }
 
+  its(:comments)      { should be_a Github::Repos::Comments }
+
   its(:commits)       { should be_a Github::Repos::Commits }
 
   its(:downloads)     { should be_a Github::Repos::Downloads }

data/spec/spec_helper.rb

@@ -92,6 +92,7 @@ OAUTH_TOKEN = 'bafec72922f31fe86aacc8aca4261117f3bd62cf'
 
 def reset_authentication_for(object)
   [ 'user', 'repo', 'basic_auth', 'oauth_token', 'login', 'password' ].each do |item|
+    Github.send("#{item}=", nil)
     object.send("#{item}=", nil)
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: github_api
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.7.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-20 00:00:00.000000000Z
+date: 2012-10-27 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hashie
-  requirement: &2154977880 !ruby/object:Gem::Requirement
+  requirement: &2152862440 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: 1.2.0
   type: :runtime
   prerelease: false
-  version_requirements: *2154977880
+  version_requirements: *2152862440
 - !ruby/object:Gem::Dependency
   name: faraday
-  requirement: &2154977380 !ruby/object:Gem::Requirement
+  requirement: &2152861940 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: 0.8.1
   type: :runtime
   prerelease: false
-  version_requirements: *2154977380
+  version_requirements: *2152861940
 - !ruby/object:Gem::Dependency
   name: multi_json
-  requirement: &2154976920 !ruby/object:Gem::Requirement
+  requirement: &2152861480 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: '1.3'
   type: :runtime
   prerelease: false
-  version_requirements: *2154976920
+  version_requirements: *2152861480
 - !ruby/object:Gem::Dependency
   name: oauth2
-  requirement: &2154976540 !ruby/object:Gem::Requirement
+  requirement: &2152861100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2154976540
+  version_requirements: *2152861100
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &2154976000 !ruby/object:Gem::Requirement
+  requirement: &2158226040 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,10 +65,10 @@ dependencies:
         version: 1.5.2
   type: :runtime
   prerelease: false
-  version_requirements: *2154976000
+  version_requirements: *2158226040
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2154975500 !ruby/object:Gem::Requirement
+  requirement: &2158225540 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154975500
+  version_requirements: *2158225540
 - !ruby/object:Gem::Dependency
   name: cucumber
-  requirement: &2154975040 !ruby/object:Gem::Requirement
+  requirement: &2158225080 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,10 +87,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154975040
+  version_requirements: *2158225080
 - !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &2154990960 !ruby/object:Gem::Requirement
+  requirement: &2158224620 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -98,10 +98,10 @@ dependencies:
         version: 1.8.0
   type: :development
   prerelease: false
-  version_requirements: *2154990960
+  version_requirements: *2158224620
 - !ruby/object:Gem::Dependency
   name: vcr
-  requirement: &2154990500 !ruby/object:Gem::Requirement
+  requirement: &2158224160 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -109,10 +109,10 @@ dependencies:
         version: 2.2.0
   type: :development
   prerelease: false
-  version_requirements: *2154990500
+  version_requirements: *2158224160
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &2154990040 !ruby/object:Gem::Requirement
+  requirement: &2158223700 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -120,10 +120,10 @@ dependencies:
         version: 0.7.1
   type: :development
   prerelease: false
-  version_requirements: *2154990040
+  version_requirements: *2158223700
 - !ruby/object:Gem::Dependency
   name: guard
-  requirement: &2154989660 !ruby/object:Gem::Requirement
+  requirement: &2158223320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -131,10 +131,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154989660
+  version_requirements: *2158223320
 - !ruby/object:Gem::Dependency
   name: guard-rspec
-  requirement: &2154989200 !ruby/object:Gem::Requirement
+  requirement: &2158222860 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -142,10 +142,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154989200
+  version_requirements: *2158222860
 - !ruby/object:Gem::Dependency
   name: guard-cucumber
-  requirement: &2154988780 !ruby/object:Gem::Requirement
+  requirement: &2158222440 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -153,10 +153,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154988780
+  version_requirements: *2158222440
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &2154988360 !ruby/object:Gem::Requirement
+  requirement: &2158222020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -164,10 +164,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154988360
+  version_requirements: *2158222020
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &2154987940 !ruby/object:Gem::Requirement
+  requirement: &2158221600 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -175,7 +175,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154987940
+  version_requirements: *2158221600
 description: ! ' Ruby wrapper that supports all of the GitHub API v3 methods(nearly
   200). It''s build in a modular way, that is, you can either instantiate the whole
   api wrapper Github.new or use parts of it e.i. Github::Repos.new if working solely
@@ -366,6 +366,7 @@ files:
 - lib/github_api/pull_requests.rb
 - lib/github_api/rate_limit.rb
 - lib/github_api/repos/collaborators.rb
+- lib/github_api/repos/comments.rb
 - lib/github_api/repos/commits.rb
 - lib/github_api/repos/contents.rb
 - lib/github_api/repos/downloads.rb
@@ -487,6 +488,7 @@ files:
 - spec/fixtures/users/key.json
 - spec/fixtures/users/keys.json
 - spec/fixtures/users/user.json
+- spec/github/api/set_spec.rb
 - spec/github/api_factory_spec.rb
 - spec/github/api_spec.rb
 - spec/github/authorization_spec.rb
@@ -529,11 +531,23 @@ files:
 - spec/github/repos/branch_spec.rb
 - spec/github/repos/branches_spec.rb
 - spec/github/repos/collaborators_spec.rb
-- spec/github/repos/commits_spec.rb
+- spec/github/repos/comments/create_spec.rb
+- spec/github/repos/comments/delete_spec.rb
+- spec/github/repos/comments/get_spec.rb
+- spec/github/repos/comments/list_spec.rb
+- spec/github/repos/comments/update_spec.rb
+- spec/github/repos/commits/compare_spec.rb
+- spec/github/repos/commits/get_spec.rb
+- spec/github/repos/commits/list_spec.rb
 - spec/github/repos/contents_spec.rb
 - spec/github/repos/contributors_spec.rb
 - spec/github/repos/create_spec.rb
 - spec/github/repos/delete_spec.rb
+- spec/github/repos/downloads/create_spec.rb
+- spec/github/repos/downloads/delete_spec.rb
+- spec/github/repos/downloads/get_spec.rb
+- spec/github/repos/downloads/list_spec.rb
+- spec/github/repos/downloads/upload_spec.rb
 - spec/github/repos/downloads_spec.rb
 - spec/github/repos/edit_spec.rb
 - spec/github/repos/forks/create_spec.rb
@@ -579,7 +593,7 @@ files:
 homepage: https://github.com/peter-murach/github
 licenses: []
 post_install_message: ! "\n--------------------------------------------------------------------------------\nThank
-  you for installing github_api-0.7.1.\n\nFor more information: https://github.com/peter-murach/github\n--------------------------------------------------------------------------------\n
+  you for installing github_api-0.7.2.\n\nFor more information: https://github.com/peter-murach/github\n--------------------------------------------------------------------------------\n
   \ "
 rdoc_options: []
 require_paths: