github_api 0.7.1 → 0.7.2

data/lib/github_api/repos/contents.rb

@@ -13,6 +13,7 @@ module Github
     #  github.repos.contents.readme 'user-name', 'repo-name'
     #
     def readme(user_name, repo_name, params={})
+      set :user => user_name, :repo => repo_name
       normalize! params
 
       get_request("/repos/#{user_name}/#{repo_name}/readme", params)
@@ -30,6 +31,7 @@ module Github
     #  github.repos.contents.get 'user-name', 'repo-name', 'path'
     #
     def get(user_name, repo_name, path, params={})
+      set :user => user_name, :repo => repo_name
       normalize! params
 
       get_request("/repos/#{user_name}/#{repo_name}/contents/#{path}", params)
@@ -56,6 +58,7 @@ module Github
     #    "ref" => "master"
     #
     def archive(user_name, repo_name, params={})
+      set :user => user_name, :repo => repo_name
       normalize! params
       archive_format = params.delete('archive_format') || 'zipball'
       ref = params.delete('ref') || 'master'

data/lib/github_api/repos/downloads.rb

@@ -22,7 +22,7 @@ module Github
     #  github.repos.downloads.list 'user-name', 'repo-name' { |downl| ... }
     #
     def list(user_name, repo_name, params={})
-      _update_user_repo_params(user_name, repo_name)
+      set :user => user_name, :repo => repo_name
       assert_presence_of user, repo
       normalize! params
 
@@ -39,7 +39,7 @@ module Github
     #  github.repos.downloads.get 'user-name', 'repo-name', 'download-id'
     #
     def get(user_name, repo_name, download_id, params={})
-      _update_user_repo_params(user_name, repo_name)
+      set :user => user_name, :repo => repo_name
       assert_presence_of user, repo, download_id
       normalize! params
 
@@ -54,7 +54,7 @@ module Github
     #  github.repos.downloads.delete 'user-name', 'repo-name', 'download-id'
     #
     def delete(user_name, repo_name, download_id, params={})
-      _update_user_repo_params(user_name, repo_name)
+      set :user => user_name, :repo => repo_name
       assert_presence_of user, repo, download_id
       normalize! params
 
@@ -80,7 +80,7 @@ module Github
     #    "content_type" => "text/plain"
     #
     def create(user_name, repo_name, params={})
-      _update_user_repo_params(user_name, repo_name)
+      set :user => user_name, :repo => repo_name
       assert_presence_of user, repo
 
       normalize! params

data/lib/github_api/repos/forks.rb

@@ -14,7 +14,7 @@ module Github
     #  github.repos.forks.list 'user-name', 'repo-name' { |fork| ... }
     #
     def list(user_name, repo_name, params = {})
-      _update_user_repo_params(user_name, repo_name)
+      set :user => user_name, :repo => repo_name
       assert_presence_of user, repo
       normalize! params
 
@@ -35,7 +35,7 @@ module Github
     #    "org" =>  "github"
     #
     def create(user_name, repo_name, params={})
-      _update_user_repo_params(user_name, repo_name)
+      set :user => user_name, :repo => repo_name
       assert_presence_of user, repo
       normalize! params
       filter! %w[ org ], params

data/lib/github_api/repos/hooks.rb

@@ -43,7 +43,7 @@ module Github
     #  github.repos.hooks.list 'user-name', 'repo-name' { |hook| ... }
     #
     def list(user_name, repo_name, params={})
-      _update_user_repo_params(user_name, repo_name)
+      set :user => user_name, :repo => repo_name
       assert_presence_of user, repo
       normalize! params
 
@@ -60,7 +60,7 @@ module Github
     #  github.repos.hooks.get 'user-name', 'repo-name'
     #
     def get(user_name, repo_name, hook_id, params={})
-      _update_user_repo_params(user_name, repo_name)
+      set :user => user_name, :repo => repo_name
       assert_presence_of user, repo, hook_id
       normalize! params
 
@@ -87,7 +87,7 @@ module Github
     #    }
     #
     def create(user_name, repo_name, params={})
-      _update_user_repo_params(user_name, repo_name)
+      set :user => user_name, :repo => repo_name
       assert_presence_of user, repo
 
       normalize! params
@@ -119,7 +119,7 @@ module Github
     #    }
     #
     def edit(user_name, repo_name, hook_id, params={})
-      _update_user_repo_params(user_name, repo_name)
+      set :user => user_name, :repo => repo_name
       assert_presence_of user, repo, hook_id
 
       normalize! params
@@ -138,7 +138,7 @@ module Github
     #  github.repos.hooks.test 'user-name', 'repo-name', 'hook-id'
     #
     def test(user_name, repo_name, hook_id, params={})
-      _update_user_repo_params(user_name, repo_name)
+      set :user => user_name, :repo => repo_name
       assert_presence_of user, repo, hook_id
       normalize! params
 
@@ -152,7 +152,7 @@ module Github
     #  github.repos.hooks.delete 'user-name', 'repo-name', 'hook-id'
     #
     def delete(user_name, repo_name, hook_id, params={})
-      _update_user_repo_params(user_name, repo_name)
+      set :user => user_name, :repo => repo_name
       assert_presence_of user, repo, hook_id
       normalize! params
 

data/lib/github_api/repos/keys.rb

@@ -13,7 +13,7 @@ module Github
     #  github.repos.keys.list 'user-name', 'repo-name' { |key| ... }
     #
     def list(user_name, repo_name, params={})
-      _update_user_repo_params(user_name, repo_name)
+      set :user => user_name, :repo => repo_name
       assert_presence_of user, repo
       normalize! params
 
@@ -30,7 +30,7 @@ module Github
     #  github.repos.keys.get 'user-name', 'repo-name', 'key-id'
     #
     def get(user_name, repo_name, key_id, params={})
-      _update_user_repo_params(user_name, repo_name)
+      set :user => user_name, :repo => repo_name
       assert_presence_of user, repo, key_id
       normalize! params
 
@@ -51,7 +51,7 @@ module Github
     #    "key" =>  "ssh-rsa AAA..."
     #
     def create(user_name, repo_name, params={})
-      _update_user_repo_params(user_name, repo_name)
+      set :user => user_name, :repo => repo_name
       assert_presence_of user, repo
       normalize! params
       filter! VALID_KEY_PARAM_NAMES, params
@@ -73,7 +73,7 @@ module Github
     #    "key" =>  "ssh-rsa AAA..."
     #
     def edit(user_name, repo_name, key_id, params={})
-      _update_user_repo_params(user_name, repo_name)
+      set :user => user_name, :repo => repo_name
       assert_presence_of user, repo, key_id
 
       normalize! params
@@ -89,7 +89,7 @@ module Github
     #  @github.repos.keys.delete 'user-name', 'repo-name', 'key-id'
     #
     def delete(user_name, repo_name, key_id, params={})
-      _update_user_repo_params(user_name, repo_name)
+      set :user => user_name, :repo => repo_name
       assert_presence_of user, repo, key_id
       normalize! params
 

data/lib/github_api/repos/merging.rb

@@ -29,6 +29,7 @@ module Github
     #    "commit_message": "Shipped cool_feature!"
     #
     def merge(user_name, repo_name, params={})
+      set :user => user_name, :repo => repo_name
       normalize! params
       filter! VALID_MERGE_PARAM_NAMES, params
       assert_required_keys REQUIRED_MERGE_PARAMS, params

data/lib/github_api/repos/starring.rb

@@ -13,7 +13,7 @@ module Github
     #  github.repos.starring.list { |star| ... }
     #
     def list(user_name, repo_name, params={})
-      _update_user_repo_params(user_name, repo_name)
+      set :user => user_name, :repo => repo_name
       assert_presence_of user, repo
       normalize! params
 
@@ -74,6 +74,7 @@ module Github
     #  github.repos.starring.star 'user-name', 'repo-name'
     #
     def star(user_name, repo_name, params={})
+      set :user => user_name, :repo => repo_name
       assert_presence_of user_name, repo_name
       normalize! params
       put_request("/user/starred/#{user_name}/#{repo_name}", params)
@@ -88,6 +89,7 @@ module Github
     #  github.repos.starring.unstar 'user-name', 'repo-name'
     #
     def unstar(user_name, repo_name, params={})
+      set :user => user_name, :repo => repo_name
       assert_presence_of user_name, repo_name
       normalize! params
       delete_request("/user/starred/#{user_name}/#{repo_name}", params)

data/lib/github_api/repos/statuses.rb

@@ -22,7 +22,7 @@ module Github
     #  github.repos.statuses.list 'user-name', 'repo-name', 'sha' { |status| ... }
     #
     def list(user_name, repo_name, sha, params={})
-      _update_user_repo_params(user_name, repo_name)
+      set :user => user_name, :repo => repo_name
       assert_presence_of user, repo
       normalize! params
 
@@ -50,7 +50,7 @@ module Github
     #    "description" => "Successful build #3 from origin/master"
     #
     def create(user_name, repo_name, sha, params={})
-      _update_user_repo_params(user_name, repo_name)
+      set :user => user_name, :repo => repo_name
       assert_presence_of user, repo
 
       normalize! params

data/lib/github_api/repos/watching.rb

@@ -13,7 +13,7 @@ module Github
     #  github.repos.watching.list { |watcher| ... }
     #
     def list(user_name, repo_name, params={})
-      _update_user_repo_params(user_name, repo_name)
+      set :user => user_name, :repo => repo_name
       assert_presence_of user, repo
       normalize! params
 

data/lib/github_api/version.rb

@@ -4,7 +4,7 @@ module Github
   module VERSION
     MAJOR = 0
     MINOR = 7
-    PATCH = 1
+    PATCH = 2
     BUILD = nil
 
     STRING = [MAJOR, MINOR, PATCH, BUILD].compact.join('.');

data/spec/github/api/set_spec.rb

@@ -0,0 +1,19 @@
+# -*- encoding: utf-8 -*-
+
+require 'spec_helper'
+
+describe Github::API, '#set' do
+
+  after { reset_authentication_for subject }
+
+  it 'requires value to be set' do
+    expect { subject.set :option }.to raise_error(ArgumentError)
+  end
+
+  it 'accepts more than one option' do
+    subject.set :user => 'user-name', :repo => 'repo-name'
+    subject.user.should == 'user-name'
+    subject.repo.should == 'repo-name'
+  end
+
+end

data/spec/github/repos/comments/create_spec.rb

@@ -0,0 +1,86 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Repos::Comments, '#create' do
+  let(:user) { 'peter-murach' }
+  let(:repo) { 'github' }
+  let(:sha) { '23432dfosfsufd' }
+  let(:inputs) do
+    { 'body' => 'web',
+      :commit_id => 1,
+      :line => 1,
+      :path => 'file1.txt',
+      :position => 4 }
+  end
+  let(:request_path) { "/repos/#{user}/#{repo}/commits/#{sha}/comments" }
+
+  before {
+    stub_post(request_path).with(inputs).
+      to_return(:body => body, :status => status,
+        :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for subject }
+
+  context "resouce created" do
+    let(:body)   { fixture('repos/commit_comment.json') }
+    let(:status) { 201 }
+
+    it "should fail to create resource if 'body' input is missing" do
+      expect {
+        subject.create user, repo, sha, inputs.except('body')
+      }.to raise_error(Github::Error::RequiredParams)
+    end
+
+    it "should fail to create resource if 'commit_id' input is missing" do
+      expect {
+        subject.create user, repo, sha, inputs.except(:commit_id)
+      }.to raise_error(Github::Error::RequiredParams)
+    end
+
+    it "should fail to create resource if 'line' input is missing" do
+      expect {
+        subject.create user, repo, sha, inputs.except(:line)
+      }.to raise_error(Github::Error::RequiredParams)
+    end
+
+    it "should fail to create resource if 'path' input is missing" do
+      expect {
+        subject.create user, repo, sha, inputs.except(:path)
+      }.to raise_error(Github::Error::RequiredParams)
+    end
+
+    it "should fail to create resource if 'position' input is missing" do
+      expect {
+        subject.create user, repo, sha, inputs.except(:position)
+      }.to raise_error(Github::Error::RequiredParams)
+    end
+
+    it "should create resource successfully" do
+      subject.create user, repo, sha, inputs
+      a_post(request_path).with(inputs).should have_been_made
+    end
+
+    it "should return the resource" do
+      comment = subject.create user, repo, sha, inputs
+      comment.should be_a Hashie::Mash
+    end
+
+    it "should get the commit comment information" do
+      comment = subject.create user, repo, sha, inputs
+      comment.user.login.should == 'octocat'
+    end
+  end
+
+  context "failed to create resource" do
+    let(:body)   { '' }
+    let(:status) { 404 }
+
+    it "should fail to retrieve resource" do
+      expect {
+        subject.create user, repo, sha, inputs
+      }.to raise_error(Github::Error::NotFound)
+    end
+  end
+end # create

data/spec/github/repos/comments/delete_spec.rb

@@ -0,0 +1,47 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Repos::Comments, '#delete' do
+  let(:user) { 'peter-murach' }
+  let(:repo) { 'github' }
+  let(:comment_id) { 1 }
+  let(:request_path) { "/repos/#{user}/#{repo}/comments/#{comment_id}" }
+
+  before {
+    stub_delete(request_path).
+      to_return(:body => body, :status => status,
+        :headers => { :content_type => "application/json; charset=utf-8"})
+  }
+
+  context "resource deleted successfully" do
+    let(:body) { '' }
+    let(:status) { 204 }
+
+    it "should fail to delete without 'user/repo' parameters" do
+      expect { subject.delete }.to raise_error(ArgumentError)
+    end
+
+    it "should fail to delete resource without 'comment_id'" do
+      expect {
+        subject.delete user, repo, nil
+      }.to raise_error(ArgumentError)
+    end
+
+    it "should delete the resource" do
+      subject.delete user, repo, comment_id
+      a_delete(request_path).should have_been_made
+    end
+  end
+
+  context "failed to delete resource" do
+    let(:body) { '' }
+    let(:status) { 404 }
+
+    it "should fail to find resource" do
+      expect {
+        subject.delete user, repo, comment_id
+      }.to raise_error(Github::Error::NotFound)
+    end
+  end
+end # delete

data/spec/github/repos/comments/get_spec.rb

@@ -0,0 +1,54 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Repos::Comments, '#get' do
+  let(:user) { 'peter-murach' }
+  let(:repo) { 'github' }
+  let(:comment_id) { 1 }
+  let(:request_path) { "/repos/#{user}/#{repo}/comments/#{comment_id}" }
+
+  before {
+    stub_get(request_path).to_return(:body => body, :status => status,
+      :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for subject }
+
+  context "resource found" do
+    let(:body)   { fixture('repos/commit_comment.json') }
+    let(:status) { 200 }
+
+    it { should respond_to(:find) }
+
+    it "should fail to get resource without comment id" do
+      expect { subject.get user, repo, nil }.to raise_error(ArgumentError)
+    end
+
+    it "should get the resource" do
+      subject.get user, repo, comment_id
+      a_get(request_path).should have_been_made
+    end
+
+    it "should get commit comment information" do
+      commit_comment = subject.get user, repo, comment_id
+      commit_comment.user.login.should == 'octocat'
+    end
+
+    it "should return mash" do
+      commit_comment = subject.get user, repo, comment_id
+      commit_comment.should be_a Hashie::Mash
+    end
+  end
+
+  context "resource not found" do
+    let(:body)   { '' }
+    let(:status) { 404 }
+
+    it "should fail to retrive resource" do
+      expect {
+        subject.get user, repo, comment_id
+      }.to raise_error(Github::Error::NotFound)
+    end
+  end
+end # get