github_api 0.6.0 → 0.6.1

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: github_api
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-06-12 00:00:00.000000000Z
+date: 2012-06-24 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hashie
-  requirement: &2153407400 !ruby/object:Gem::Requirement
+  requirement: &2153407020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,21 +21,21 @@ dependencies:
         version: 1.2.0
   type: :runtime
   prerelease: false
-  version_requirements: *2153407400
+  version_requirements: *2153407020
 - !ruby/object:Gem::Dependency
   name: faraday
-  requirement: &2153406900 !ruby/object:Gem::Requirement
+  requirement: &2153406520 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.8.0
+        version: 0.8.1
   type: :runtime
   prerelease: false
-  version_requirements: *2153406900
+  version_requirements: *2153406520
 - !ruby/object:Gem::Dependency
   name: multi_json
-  requirement: &2153406420 !ruby/object:Gem::Requirement
+  requirement: &2153406040 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,21 +43,21 @@ dependencies:
         version: '1.3'
   type: :runtime
   prerelease: false
-  version_requirements: *2153406420
+  version_requirements: *2153406040
 - !ruby/object:Gem::Dependency
   name: oauth2
-  requirement: &2153392320 !ruby/object:Gem::Requirement
+  requirement: &2153400220 !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: '0.7'
+        version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2153392320
+  version_requirements: *2153400220
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &2153391800 !ruby/object:Gem::Requirement
+  requirement: &2153399560 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,10 +65,10 @@ dependencies:
         version: 1.5.2
   type: :runtime
   prerelease: false
-  version_requirements: *2153391800
+  version_requirements: *2153399560
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2153391320 !ruby/object:Gem::Requirement
+  requirement: &2153399020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153391320
+  version_requirements: *2153399020
 - !ruby/object:Gem::Dependency
   name: cucumber
-  requirement: &2153390860 !ruby/object:Gem::Requirement
+  requirement: &2153398480 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,10 +87,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153390860
+  version_requirements: *2153398480
 - !ruby/object:Gem::Dependency
   name: yajl-ruby
-  requirement: &2153390380 !ruby/object:Gem::Requirement
+  requirement: &2153397960 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -98,10 +98,10 @@ dependencies:
         version: 1.1.0
   type: :development
   prerelease: false
-  version_requirements: *2153390380
+  version_requirements: *2153397960
 - !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &2153389860 !ruby/object:Gem::Requirement
+  requirement: &2153397380 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -109,10 +109,10 @@ dependencies:
         version: 1.8.0
   type: :development
   prerelease: false
-  version_requirements: *2153389860
+  version_requirements: *2153397380
 - !ruby/object:Gem::Dependency
   name: vcr
-  requirement: &2153389400 !ruby/object:Gem::Requirement
+  requirement: &2153396800 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -120,10 +120,10 @@ dependencies:
         version: 2.2.0
   type: :development
   prerelease: false
-  version_requirements: *2153389400
+  version_requirements: *2153396800
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &2153388880 !ruby/object:Gem::Requirement
+  requirement: &2153396220 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -131,10 +131,10 @@ dependencies:
         version: 0.6.1
   type: :development
   prerelease: false
-  version_requirements: *2153388880
+  version_requirements: *2153396220
 - !ruby/object:Gem::Dependency
   name: guard
-  requirement: &2153388500 !ruby/object:Gem::Requirement
+  requirement: &2153395720 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -142,10 +142,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153388500
+  version_requirements: *2153395720
 - !ruby/object:Gem::Dependency
   name: guard-rspec
-  requirement: &2153388020 !ruby/object:Gem::Requirement
+  requirement: &2153395140 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -153,10 +153,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153388020
+  version_requirements: *2153395140
 - !ruby/object:Gem::Dependency
   name: guard-cucumber
-  requirement: &2153387560 !ruby/object:Gem::Requirement
+  requirement: &2153394600 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -164,10 +164,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153387560
+  version_requirements: *2153394600
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &2153387140 !ruby/object:Gem::Requirement
+  requirement: &2153394100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -175,10 +175,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153387140
+  version_requirements: *2153394100
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &2153386680 !ruby/object:Gem::Requirement
+  requirement: &2153393640 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -186,7 +186,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153386680
+  version_requirements: *2153393640
 description: ! ' Ruby wrapper that supports all of the GitHub API v3 methods(nearly
   200). It''s build in a modular way, that is, you can either instantiate the whole
   api wrapper Github.new or use parts of it e.i. Github::Repos.new if working solely
@@ -316,7 +316,6 @@ files:
 - lib/github_api/error/validations.rb
 - lib/github_api/error.rb
 - lib/github_api/events.rb
-- lib/github_api/filter.rb
 - lib/github_api/gists/comments.rb
 - lib/github_api/gists.rb
 - lib/github_api/git_data/blobs.rb
@@ -331,6 +330,7 @@ files:
 - lib/github_api/issues/milestones.rb
 - lib/github_api/issues.rb
 - lib/github_api/mime_type.rb
+- lib/github_api/normalizer.rb
 - lib/github_api/orgs/members.rb
 - lib/github_api/orgs/teams.rb
 - lib/github_api/orgs.rb
@@ -338,6 +338,7 @@ files:
 - lib/github_api/page_links.rb
 - lib/github_api/page_uri_processor.rb
 - lib/github_api/paged_request.rb
+- lib/github_api/parameter_filter.rb
 - lib/github_api/params_hash.rb
 - lib/github_api/pull_requests/comments.rb
 - lib/github_api/pull_requests.rb
@@ -465,7 +466,6 @@ files:
 - spec/github/error/required_params_spec.rb
 - spec/github/error/unknown_value_spec.rb
 - spec/github/events_spec.rb
-- spec/github/filter_spec.rb
 - spec/github/gists/comments_spec.rb
 - spec/github/gists_spec.rb
 - spec/github/git_data/blobs_spec.rb
@@ -480,12 +480,14 @@ files:
 - spec/github/issues/milestones_spec.rb
 - spec/github/issues_spec.rb
 - spec/github/mime_type_spec.rb
+- spec/github/normalizer_spec.rb
 - spec/github/orgs/members_spec.rb
 - spec/github/orgs/teams_spec.rb
 - spec/github/orgs_spec.rb
 - spec/github/page_iterator_spec.rb
 - spec/github/page_links_spec.rb
 - spec/github/paged_request_spec.rb
+- spec/github/parameter_filter_spec.rb
 - spec/github/pull_requests/comments_spec.rb
 - spec/github/pull_requests_spec.rb
 - spec/github/repos/collaborators_spec.rb
@@ -526,7 +528,7 @@ files:
 homepage: https://github.com/peter-murach/github
 licenses: []
 post_install_message: ! "\n--------------------------------------------------------------------------------\nThank
-  you for installing github_api-0.6.0.\n\n*NOTE*: Version 0.5.0 introduces breaking
+  you for installing github_api-0.6.1.\n\n*NOTE*: Version 0.5.0 introduces breaking
   changes to the way github api is queried.\nThe interface has been rewritten to be
   more consistent with REST verbs that\ninteract with GitHub hypermedia resources.
   Thus, to list resources 'list' or 'all'\nverbs are used, to retrieve individual

data/lib/github_api/filter.rb

@@ -1,57 +0,0 @@
-module Github
-  module Filter
-
-    def process_params(*args)
-      yield self if block_given?
-    end
-
-    def normalize(params)
-      _normalize_params_keys params
-    end
-
-    def filter(keys, params)
-      _filter_params_keys(keys, params)
-    end
-
-    # Turns any keys from nested hashes including nested arrays into strings
-    def _normalize_params_keys(params)  #  :nodoc:
-      case params
-      when Hash
-        params.keys.each do |k|
-          params[k.to_s] = params.delete(k)
-          _normalize_params_keys(params[k.to_s])
-        end
-      when Array
-        params.map! do |el|
-          _normalize_params_keys(el)
-        end
-      else
-        params.to_s
-      end
-      return params
-    end
-
-    # Removes any keys from nested hashes that don't match predefiend keys
-    # filter_valid_keys
-    def _filter_params_keys(keys, params, options={:recursive => true})  # :nodoc:
-      case params
-      when Hash
-        params.keys.each do |k, v|
-          unless (keys.include?(k) or Github::Validations::VALID_API_KEYS.include?(k))
-            params.delete(k)
-          else
-            _filter_params_keys(keys, params[k]) if options[:recursive]
-          end
-        end
-      when Array
-        params.map! do |el|
-          _filter_params_keys(keys, el) if options[:recursive]
-        end
-      else
-        params
-      end
-      return params
-    end
-
-  end # Filter
-end # Github

data/spec/github/filter_spec.rb

@@ -1,82 +0,0 @@
-require 'spec_helper'
-require 'github_api/core_ext/hash'
-
-describe Github::Filter do
-  let(:github) { Github.new }
-  let(:repos_instance) { Github::Repos.new }
-  let(:block) {
-    Proc.new do |repo|
-      repo = repos_instance
-    end
-  }
-  let(:hash) {  { :a => { :b => { :c => 1 } } }  }
-
-  context '#process_params' do
-
-    it 'correctly yields current api instance' do
-      github.repos.should_receive(:process_params).and_yield repos_instance
-      github.repos.process_params(&block).should eq repos_instance
-    end
-  end
-
-  context '#normalize' do
-    it 'should call normalize on passed block' do
-      github.repos.process_params(&block).should respond_to :normalize
-    end
-
-    it 'should normalize params inside block' do
-      github.repos.stub(:process_params).and_yield repos_instance
-      github.repos.process_params do |repo|
-        repo.normalize hash
-      end
-      hash.all_keys.should include 'a'
-      hash.all_keys.should_not include :a
-    end
-  end
-
-  context '#filter' do
-    it 'should call filter on passed block' do
-      github.repos.process_params(&block).should respond_to :filter
-    end
-
-    it 'should filter params inside block' do
-      github.repos.stub(:process_params).and_yield repos_instance
-      github.repos.process_params do |repo|
-        repo.filter [:a], hash
-      end
-      hash.all_keys.should     include :a
-      hash.all_keys.should_not include :b
-    end
-  end
-
-  context '#_normalize_params_keys' do
-    it 'converts hash keys to string' do
-      ['a', 'b', 'c'].each do |key|
-        github.repos._normalize_params_keys(hash).all_keys.should include key
-      end
-      [:a, :b, :c].each do |key|
-        github.repos._normalize_params_keys(hash).all_keys.should_not include key
-      end
-    end
-  end
-
-  context '#_filter_params_keys' do
-    it 'removes unwanted keys from hash' do
-      github.repos._filter_params_keys([:a], hash)
-      hash.all_keys.should     include :a
-      hash.all_keys.should_not include :b
-      hash.all_keys.should_not include :c
-    end
-
-    it 'recursively filters inputs tree' do
-      github.repos._filter_params_keys([:a, :b], hash)
-      hash.all_keys.should_not include :c
-    end
-
-    it 'filters inputs tree only on top level' do
-      github.repos._filter_params_keys([:a, :b], hash, :recursive => false)
-      hash.all_keys.should include :c
-    end
-  end
-
-end # Github::Filter