github_api 0.6.0 → 0.6.1

Sign up to get free protection for your applications and to get access to all the features.
Files changed (48) hide show
  1. data/README.md +2 -1
  2. data/lib/github_api/api.rb +5 -3
  3. data/lib/github_api/authorizations.rb +8 -8
  4. data/lib/github_api/connection.rb +1 -1
  5. data/lib/github_api/events.rb +8 -8
  6. data/lib/github_api/gists/comments.rb +7 -7
  7. data/lib/github_api/gists.rb +10 -10
  8. data/lib/github_api/git_data/blobs.rb +3 -3
  9. data/lib/github_api/git_data/commits.rb +3 -3
  10. data/lib/github_api/git_data/references.rb +7 -7
  11. data/lib/github_api/git_data/tags.rb +3 -3
  12. data/lib/github_api/git_data/trees.rb +3 -3
  13. data/lib/github_api/issues/comments.rb +7 -7
  14. data/lib/github_api/issues/events.rb +2 -2
  15. data/lib/github_api/issues/labels.rb +12 -11
  16. data/lib/github_api/issues/milestones.rb +8 -8
  17. data/lib/github_api/issues.rb +9 -9
  18. data/lib/github_api/normalizer.rb +27 -0
  19. data/lib/github_api/orgs/members.rb +7 -7
  20. data/lib/github_api/orgs/teams.rb +15 -16
  21. data/lib/github_api/orgs.rb +4 -3
  22. data/lib/github_api/parameter_filter.rb +32 -0
  23. data/lib/github_api/pull_requests/comments.rb +7 -7
  24. data/lib/github_api/pull_requests.rb +12 -12
  25. data/lib/github_api/repos/collaborators.rb +4 -4
  26. data/lib/github_api/repos/commits.rb +11 -11
  27. data/lib/github_api/repos/contents.rb +3 -3
  28. data/lib/github_api/repos/downloads.rb +5 -5
  29. data/lib/github_api/repos/forks.rb +3 -3
  30. data/lib/github_api/repos/hooks.rb +8 -8
  31. data/lib/github_api/repos/keys.rb +7 -7
  32. data/lib/github_api/repos/pub_sub_hubbub.rb +4 -4
  33. data/lib/github_api/repos/watching.rb +5 -5
  34. data/lib/github_api/repos.rb +13 -13
  35. data/lib/github_api/search.rb +4 -4
  36. data/lib/github_api/users/emails.rb +3 -3
  37. data/lib/github_api/users/followers.rb +5 -5
  38. data/lib/github_api/users/keys.rb +7 -7
  39. data/lib/github_api/users.rb +3 -3
  40. data/lib/github_api/validations/presence.rb +1 -0
  41. data/lib/github_api/version.rb +1 -1
  42. data/lib/github_api.rb +26 -25
  43. data/spec/github/api_spec.rb +4 -4
  44. data/spec/github/normalizer_spec.rb +20 -0
  45. data/spec/github/parameter_filter_spec.rb +71 -0
  46. metadata +42 -40
  47. data/lib/github_api/filter.rb +0 -57
  48. data/spec/github/filter_spec.rb +0 -82
@@ -84,8 +84,8 @@ module Github
84
84
  #
85
85
  def list(*args)
86
86
  params = args.extract_options!
87
- _normalize_params_keys(params)
88
- _filter_params_keys(VALID_ISSUE_PARAM_NAMES, params)
87
+ normalize! params
88
+ filter! VALID_ISSUE_PARAM_NAMES, params
89
89
  # _merge_mime_type(:issue, params)
90
90
  assert_valid_values(VALID_ISSUE_PARAM_VALUES, params)
91
91
 
@@ -129,8 +129,8 @@ module Github
129
129
  _update_user_repo_params(user_name, repo_name)
130
130
  _validate_user_repo_params(user, repo) unless user? && repo?
131
131
 
132
- _normalize_params_keys(params)
133
- _filter_params_keys(VALID_ISSUE_PARAM_NAMES, params)
132
+ normalize! params
133
+ filter! VALID_ISSUE_PARAM_NAMES, params
134
134
  # _merge_mime_type(:issue, params)
135
135
  assert_valid_values(VALID_ISSUE_PARAM_VALUES, params)
136
136
 
@@ -151,7 +151,7 @@ module Github
151
151
  _validate_user_repo_params(user, repo) unless user? && repo?
152
152
  _validate_presence_of issue_id
153
153
 
154
- _normalize_params_keys(params)
154
+ normalize! params
155
155
  # _merge_mime_type(:issue, params)
156
156
 
157
157
  get_request("/repos/#{user}/#{repo}/issues/#{issue_id}", params)
@@ -182,9 +182,9 @@ module Github
182
182
  _update_user_repo_params(user_name, repo_name)
183
183
  _validate_user_repo_params(user, repo) unless user? && repo?
184
184
 
185
- _normalize_params_keys(params)
185
+ normalize! params
186
186
  # _merge_mime_type(:issue, params)
187
- _filter_params_keys(VALID_ISSUE_PARAM_NAMES, params)
187
+ filter! VALID_ISSUE_PARAM_NAMES, params
188
188
  assert_required_keys(%w[ title ], params)
189
189
 
190
190
  post_request("/repos/#{user}/#{repo}/issues", params)
@@ -217,9 +217,9 @@ module Github
217
217
  _validate_user_repo_params(user, repo) unless user? && repo?
218
218
  _validate_presence_of issue_id
219
219
 
220
- _normalize_params_keys(params)
220
+ normalize! params
221
221
  # _merge_mime_type(:issue, params)
222
- _filter_params_keys(VALID_ISSUE_PARAM_NAMES, params)
222
+ filter! VALID_ISSUE_PARAM_NAMES, params
223
223
 
224
224
  patch_request("/repos/#{user}/#{repo}/issues/#{issue_id}", params)
225
225
  end
@@ -0,0 +1,27 @@
1
+ # -*- encoding: utf-8 -*-
2
+
3
+ module Github
4
+ # Deals with normalazing client supplied parameter keys.
5
+ module Normalizer
6
+
7
+ # Turns any keys from nested hashes including nested arrays into strings
8
+ #
9
+ def normalize!(params)
10
+ case params
11
+ when Hash
12
+ params.keys.each do |k|
13
+ params[k.to_s] = params.delete(k)
14
+ normalize!(params[k.to_s])
15
+ end
16
+ when Array
17
+ params.map! do |el|
18
+ normalize!(el)
19
+ end
20
+ else
21
+ params.to_s
22
+ end
23
+ return params
24
+ end
25
+
26
+ end # Normalizer
27
+ end # Github
@@ -18,7 +18,7 @@ module Github
18
18
  #
19
19
  def list(org_name, params={})
20
20
  _validate_presence_of org_name
21
- _normalize_params_keys(params)
21
+ normalize! params
22
22
  response = get_request("/orgs/#{org_name}/members", params)
23
23
  return response unless block_given?
24
24
  response.each { |el| yield el }
@@ -33,7 +33,7 @@ module Github
33
33
  #
34
34
  def member?(org_name, member_name, params={})
35
35
  _validate_presence_of org_name, member_name
36
- _normalize_params_keys(params)
36
+ normalize! params
37
37
  get_request("/orgs/#{org_name}/members/#{member_name}", params)
38
38
  true
39
39
  rescue Github::Error::NotFound
@@ -50,7 +50,7 @@ module Github
50
50
  #
51
51
  def delete(org_name, member_name, params={})
52
52
  _validate_presence_of org_name, member_name
53
- _normalize_params_keys(params)
53
+ normalize! params
54
54
  delete_request("/orgs/#{org_name}/members/#{member_name}", params)
55
55
  end
56
56
  alias :remove :delete
@@ -64,7 +64,7 @@ module Github
64
64
  #
65
65
  def list_public(org_name, params={})
66
66
  _validate_presence_of org_name
67
- _normalize_params_keys(params)
67
+ normalize! params
68
68
  response = get_request("/orgs/#{org_name}/public_members", params)
69
69
  return response unless block_given?
70
70
  response.each { |el| yield el }
@@ -79,7 +79,7 @@ module Github
79
79
  #
80
80
  def public_member?(org_name, member_name, params={})
81
81
  _validate_presence_of org_name, member_name
82
- _normalize_params_keys(params)
82
+ normalize! params
83
83
  get_request("/orgs/#{org_name}/public_members/#{member_name}", params)
84
84
  true
85
85
  rescue Github::Error::NotFound
@@ -94,7 +94,7 @@ module Github
94
94
  #
95
95
  def publicize(org_name, member_name, params={})
96
96
  _validate_presence_of org_name, member_name
97
- _normalize_params_keys(params)
97
+ normalize! params
98
98
  put_request("/orgs/#{org_name}/public_members/#{member_name}", params)
99
99
  end
100
100
  alias :make_public :publicize
@@ -108,7 +108,7 @@ module Github
108
108
  #
109
109
  def conceal(org_name, member_name, params={})
110
110
  _validate_presence_of org_name, member_name
111
- _normalize_params_keys(params)
111
+ normalize! params
112
112
  delete_request("/orgs/#{org_name}/public_members/#{member_name}", params)
113
113
  end
114
114
  alias :conceal_membership :conceal
@@ -19,7 +19,7 @@ module Github
19
19
  #
20
20
  def list(org_name, params={})
21
21
  _validate_presence_of org_name
22
- _normalize_params_keys(params)
22
+ normalize! params
23
23
 
24
24
  response = get_request("/orgs/#{org_name}/teams", params)
25
25
  return response unless block_given?
@@ -35,7 +35,7 @@ module Github
35
35
  #
36
36
  def get(team_name, params={})
37
37
  _validate_presence_of team_name
38
- _normalize_params_keys(params)
38
+ normalize! params
39
39
 
40
40
  get_request("/teams/#{team_name}", params)
41
41
  end
@@ -63,8 +63,8 @@ module Github
63
63
  #
64
64
  def create(org_name, params={})
65
65
  _validate_presence_of org_name
66
- _normalize_params_keys(params)
67
- _filter_params_keys(VALID_TEAM_PARAM_NAMES, params)
66
+ normalize! params
67
+ filter! VALID_TEAM_PARAM_NAMES, params
68
68
  assert_valid_values(VALID_TEAM_PARAM_VALUES, params)
69
69
  assert_required_keys(%w[ name ], params)
70
70
 
@@ -89,9 +89,8 @@ module Github
89
89
  #
90
90
  def edit(team_name, params={})
91
91
  _validate_presence_of team_name
92
- _normalize_params_keys(params)
93
-
94
- _filter_params_keys(VALID_TEAM_PARAM_NAMES, params)
92
+ normalize! params
93
+ filter! VALID_TEAM_PARAM_NAMES, params
95
94
  assert_valid_values(VALID_TEAM_PARAM_VALUES, params)
96
95
  assert_required_keys(%w[ name ], params)
97
96
 
@@ -107,7 +106,7 @@ module Github
107
106
  #
108
107
  def delete(team_name, params={})
109
108
  _validate_presence_of team_name
110
- _normalize_params_keys(params)
109
+ normalize! params
111
110
  delete_request("/teams/#{team_name}", params)
112
111
  end
113
112
  alias :remove :delete
@@ -122,7 +121,7 @@ module Github
122
121
  #
123
122
  def list_members(team_name, params={})
124
123
  _validate_presence_of team_name
125
- _normalize_params_keys(params)
124
+ normalize! params
126
125
 
127
126
  response = get_request("/teams/#{team_name}/members", params)
128
127
  return response unless block_given?
@@ -138,7 +137,7 @@ module Github
138
137
  #
139
138
  def team_member?(team_name, member_name, params={})
140
139
  _validate_presence_of team_name, member_name
141
- _normalize_params_keys(params)
140
+ normalize! params
142
141
  get_request("/teams/#{team_name}/members/#{member_name}", params)
143
142
  true
144
143
  rescue Github::Error::NotFound
@@ -154,7 +153,7 @@ module Github
154
153
  #
155
154
  def add_member(team_name, member_name, params={})
156
155
  _validate_presence_of team_name, member_name
157
- _normalize_params_keys(params)
156
+ normalize! params
158
157
  put_request("/teams/#{team_name}/members/#{member_name}", params)
159
158
  end
160
159
  alias :add_team_member :add_member
@@ -171,7 +170,7 @@ module Github
171
170
  #
172
171
  def remove_member(team_name, member_name, params={})
173
172
  _validate_presence_of team_name, member_name
174
- _normalize_params_keys(params)
173
+ normalize! params
175
174
  delete_request("/teams/#{team_name}/members/#{member_name}", params)
176
175
  end
177
176
  alias :remove_team_member :remove_member
@@ -184,7 +183,7 @@ module Github
184
183
  #
185
184
  def list_repos(team_name, params={})
186
185
  _validate_presence_of team_name
187
- _normalize_params_keys(params)
186
+ normalize! params
188
187
 
189
188
  response = get_request("/teams/#{team_name}/repos", params)
190
189
  return response unless block_given?
@@ -200,7 +199,7 @@ module Github
200
199
  #
201
200
  def team_repo?(team_name, user_name, repo_name, params={})
202
201
  _validate_presence_of team_name, user_name, repo_name
203
- _normalize_params_keys(params)
202
+ normalize! params
204
203
  get_request("/teams/#{team_name}/repos/#{user_name}/#{repo_name}", params)
205
204
  true
206
205
  rescue Github::Error::NotFound
@@ -221,7 +220,7 @@ module Github
221
220
  #
222
221
  def add_repo(team_name, user_name, repo_name, params={})
223
222
  _validate_presence_of team_name, user_name, repo_name
224
- _normalize_params_keys(params)
223
+ normalize! params
225
224
  put_request("/teams/#{team_name}/repos/#{user_name}/#{repo_name}", params)
226
225
  end
227
226
  alias :add_repository :add_repo
@@ -238,7 +237,7 @@ module Github
238
237
  #
239
238
  def remove_repo(team_name, user_name, repo_name, params={})
240
239
  _validate_presence_of team_name, user_name, repo_name
241
- _normalize_params_keys(params)
240
+ normalize! params
242
241
  delete_request("/teams/#{team_name}/repos/#{user_name}/#{repo_name}", params)
243
242
  end
244
243
  alias :remove_repository :remove_repo
@@ -44,7 +44,7 @@ module Github
44
44
  #
45
45
  def list(*args)
46
46
  params = args.extract_options!
47
- _normalize_params_keys(params)
47
+ normalize! params
48
48
 
49
49
  response = if (user_name = params.delete("user"))
50
50
  get_request("/users/#{user_name}/orgs", params)
@@ -65,6 +65,7 @@ module Github
65
65
  #
66
66
  def get(org_name, params={})
67
67
  _validate_presence_of org_name
68
+ normalize! params
68
69
  get_request("/orgs/#{org_name}", params)
69
70
  end
70
71
  alias :find :get
@@ -90,8 +91,8 @@ module Github
90
91
  #
91
92
  def edit(org_name, params={})
92
93
  _validate_presence_of org_name
93
- _normalize_params_keys(params)
94
- _filter_params_keys(VALID_ORG_PARAM_NAMES, params)
94
+ normalize! params
95
+ filter! VALID_ORG_PARAM_NAMES, params
95
96
 
96
97
  patch_request("/orgs/#{org_name}", params)
97
98
  end
@@ -0,0 +1,32 @@
1
+ # -*- encoding: utf-8 -*-
2
+
3
+ module Github
4
+ # Allows you to specify parameters keys which will be preserved
5
+ # in parameters hash and its subhashes. Any keys from the nested
6
+ # hash that do not match will be removed.
7
+ module ParameterFilter
8
+
9
+ # Removes any keys from nested hashes that don't match predefiend keys
10
+ #
11
+ def filter!(keys, params, options={:recursive => true}) # :nodoc:
12
+ case params
13
+ when Hash
14
+ params.keys.each do |k, v|
15
+ unless (keys.include?(k) or Github::Validations::VALID_API_KEYS.include?(k))
16
+ params.delete(k)
17
+ else
18
+ filter!(keys, params[k]) if options[:recursive]
19
+ end
20
+ end
21
+ when Array
22
+ params.map! do |el|
23
+ filter!(keys, el) if options[:recursive]
24
+ end
25
+ else
26
+ params
27
+ end
28
+ return params
29
+ end
30
+
31
+ end # Filter
32
+ end # Github
@@ -24,7 +24,7 @@ module Github
24
24
  _validate_user_repo_params(user, repo) unless user? && repo?
25
25
  _validate_presence_of request_id
26
26
 
27
- _normalize_params_keys(params)
27
+ normalize! params
28
28
  # _merge_mime_type(:pull_comment, params)
29
29
 
30
30
  response = get_request("/repos/#{user}/#{repo}/pulls/#{request_id}/comments", params)
@@ -43,7 +43,7 @@ module Github
43
43
  _validate_user_repo_params(user, repo) unless user? && repo?
44
44
  _validate_presence_of comment_id
45
45
 
46
- _normalize_params_keys(params)
46
+ normalize! params
47
47
  # _merge_mime_type(:pull_comment, params)
48
48
 
49
49
  get_request("/repos/#{user}/#{repo}/pulls/comments/#{comment_id}", params)
@@ -83,9 +83,9 @@ module Github
83
83
  _validate_user_repo_params(user, repo) unless user? && repo?
84
84
  _validate_presence_of request_id
85
85
 
86
- _normalize_params_keys(params)
86
+ normalize! params
87
87
  # _merge_mime_type(:pull_comment, params)
88
- _filter_params_keys(VALID_REQUEST_COM_PARAM_NAMES, params)
88
+ filter! VALID_REQUEST_COM_PARAM_NAMES, params
89
89
  # _validate_reply_to(params)
90
90
 
91
91
  post_request("/repos/#{user}/#{repo}/pulls/#{request_id}/comments", params)
@@ -106,9 +106,9 @@ module Github
106
106
  _validate_user_repo_params(user, repo) unless user? && repo?
107
107
  _validate_presence_of comment_id
108
108
 
109
- _normalize_params_keys(params)
109
+ normalize! params
110
110
  # _merge_mime_type(:pull_comment, params)
111
- _filter_params_keys(VALID_REQUEST_COM_PARAM_NAMES, params)
111
+ filter! VALID_REQUEST_COM_PARAM_NAMES, params
112
112
 
113
113
  patch_request("/repos/#{user}/#{repo}/pulls/comments/#{comment_id}", params)
114
114
  end
@@ -124,7 +124,7 @@ module Github
124
124
  _validate_user_repo_params(user, repo) unless user? && repo?
125
125
  _validate_presence_of comment_id
126
126
 
127
- _normalize_params_keys(params)
127
+ normalize! params
128
128
  # _merge_mime_type(:pull_comment, params)
129
129
 
130
130
  delete_request("/repos/#{user}/#{repo}/pulls/comments/#{comment_id}", params)
@@ -47,8 +47,8 @@ module Github
47
47
  _update_user_repo_params(user_name, repo_name)
48
48
  _validate_user_repo_params(user, repo) unless (user? && repo?)
49
49
 
50
- _normalize_params_keys(params)
51
- _filter_params_keys(VALID_REQUEST_PARAM_NAMES, params)
50
+ normalize! params
51
+ filter! VALID_REQUEST_PARAM_NAMES, params
52
52
  # _merge_mime_type(:pull_request, params)
53
53
  assert_valid_values(VALID_REQUEST_PARAM_VALUES, params)
54
54
 
@@ -72,7 +72,7 @@ module Github
72
72
  _validate_user_repo_params(user, repo) unless user? && repo?
73
73
  _validate_presence_of request_id
74
74
 
75
- _normalize_params_keys(params)
75
+ normalize! params
76
76
  # _merge_mime_type(:pull_request, params)
77
77
 
78
78
  get_request("/repos/#{user}/#{repo}/pulls/#{request_id}", params)
@@ -112,9 +112,9 @@ module Github
112
112
  _update_user_repo_params(user_name, repo_name)
113
113
  _validate_user_repo_params(user, repo) unless user? && repo?
114
114
 
115
- _normalize_params_keys(params)
115
+ normalize! params
116
116
  # _merge_mime_type(:pull_request, params)
117
- _filter_params_keys(VALID_REQUEST_PARAM_NAMES, params)
117
+ filter! VALID_REQUEST_PARAM_NAMES, params
118
118
 
119
119
  post_request("/repos/#{user}/#{repo}/pulls", params)
120
120
  end
@@ -138,8 +138,8 @@ module Github
138
138
  _validate_user_repo_params(user, repo) unless user? && repo?
139
139
  _validate_presence_of request_id
140
140
 
141
- _normalize_params_keys(params)
142
- _filter_params_keys(VALID_REQUEST_PARAM_NAMES, params)
141
+ normalize! params
142
+ filter! VALID_REQUEST_PARAM_NAMES, params
143
143
  # _merge_mime_type(:pull_request, params)
144
144
  assert_valid_values(VALID_REQUEST_PARAM_VALUES, params)
145
145
 
@@ -157,7 +157,7 @@ module Github
157
157
  _validate_user_repo_params(user, repo) unless user? && repo?
158
158
  _validate_presence_of request_id
159
159
 
160
- _normalize_params_keys(params)
160
+ normalize! params
161
161
  # _merge_mime_type(:pull_request, params)
162
162
 
163
163
  response = get_request("/repos/#{user}/#{repo}/pulls/#{request_id}/commits", params)
@@ -176,7 +176,7 @@ module Github
176
176
  _validate_user_repo_params(user, repo) unless user? && repo?
177
177
  _validate_presence_of request_id
178
178
 
179
- _normalize_params_keys(params)
179
+ normalize! params
180
180
  # _merge_mime_type(:pull_request, params)
181
181
 
182
182
  response = get_request("/repos/#{user}/#{repo}/pulls/#{request_id}/files", params)
@@ -195,7 +195,7 @@ module Github
195
195
  _validate_user_repo_params(user, repo) unless user? && repo?
196
196
  _validate_presence_of request_id
197
197
 
198
- _normalize_params_keys(params)
198
+ normalize! params
199
199
  # _merge_mime_type(:pull_request, params)
200
200
 
201
201
  get_request("/repos/#{user}/#{repo}/pulls/#{request_id}/merge", params)
@@ -218,9 +218,9 @@ module Github
218
218
  _validate_user_repo_params(user, repo) unless user? && repo?
219
219
  _validate_presence_of request_id
220
220
 
221
- _normalize_params_keys(params)
221
+ normalize! params
222
222
  # _merge_mime_type(:pull_request, params)
223
- _filter_params_keys(VALID_REQUEST_PARAM_NAMES, params)
223
+ filter! VALID_REQUEST_PARAM_NAMES, params
224
224
 
225
225
  put_request("/repos/#{user}/#{repo}/pulls/#{request_id}/merge", params)
226
226
  end
@@ -16,7 +16,7 @@ module Github
16
16
  _update_user_repo_params(user_name, repo_name)
17
17
  _validate_user_repo_params(user, repo) unless user? && repo?
18
18
  _validate_presence_of collaborator
19
- _normalize_params_keys(params)
19
+ normalize! params
20
20
 
21
21
  put_request("/repos/#{user}/#{repo}/collaborators/#{collaborator}", params)
22
22
  end
@@ -32,7 +32,7 @@ module Github
32
32
  _update_user_repo_params(user_name, repo_name)
33
33
  _validate_user_repo_params(user, repo) unless user? && repo?
34
34
  _validate_presence_of collaborator
35
- _normalize_params_keys(params)
35
+ normalize! params
36
36
 
37
37
  get_request("/repos/#{user}/#{repo}/collaborators/#{collaborator}", params)
38
38
  true
@@ -50,7 +50,7 @@ module Github
50
50
  def list(user_name, repo_name, params={})
51
51
  _update_user_repo_params(user_name, repo_name)
52
52
  _validate_user_repo_params(user, repo) unless (user? && repo?)
53
- _normalize_params_keys(params)
53
+ normalize! params
54
54
 
55
55
  response = get_request("/repos/#{user}/#{repo}/collaborators", params)
56
56
  return response unless block_given?
@@ -68,7 +68,7 @@ module Github
68
68
  _update_user_repo_params(user_name, repo_name)
69
69
  _validate_user_repo_params(user, repo) unless user? && repo?
70
70
  _validate_presence_of collaborator
71
- _normalize_params_keys(params)
71
+ normalize! params
72
72
 
73
73
  delete_request("/repos/#{user}/#{repo}/collaborators/#{collaborator}", params)
74
74
  end
@@ -23,7 +23,7 @@ module Github
23
23
  #
24
24
  def compare(user_name, repo_name, base, head, params={})
25
25
  _validate_presence_of base, head
26
- _normalize_params_keys(params)
26
+ normalize! params
27
27
 
28
28
  get_request("/repos/#{user_name}/#{repo_name}/compare/#{base}...#{head}", params)
29
29
  end
@@ -51,8 +51,8 @@ module Github
51
51
  _validate_user_repo_params(user, repo) unless user? && repo?
52
52
  _validate_presence_of sha
53
53
 
54
- _normalize_params_keys(params)
55
- _filter_params_keys(REQUIRED_COMMENT_PARAMS, params)
54
+ normalize! params
55
+ filter! REQUIRED_COMMENT_PARAMS, params
56
56
 
57
57
  assert_required_keys(REQUIRED_COMMENT_PARAMS, params)
58
58
 
@@ -69,7 +69,7 @@ module Github
69
69
  _update_user_repo_params(user_name, repo_name)
70
70
  _validate_user_repo_params(user, repo) unless user? && repo?
71
71
  _validate_presence_of comment_id
72
- _normalize_params_keys(params)
72
+ normalize! params
73
73
 
74
74
  delete_request("/repos/#{user}/#{repo}/comments/#{comment_id}", params)
75
75
  end
@@ -88,8 +88,8 @@ module Github
88
88
  def list(user_name, repo_name, params={})
89
89
  _update_user_repo_params(user_name, repo_name)
90
90
  _validate_user_repo_params(user, repo) unless user? && repo?
91
- _normalize_params_keys(params)
92
- _filter_params_keys(%w[ sha path], params)
91
+ normalize! params
92
+ filter! %w[ sha path], params
93
93
 
94
94
  response = get_request("/repos/#{user}/#{repo}/commits", params)
95
95
  return response unless block_given?
@@ -107,7 +107,7 @@ module Github
107
107
  def repo_comments(user_name, repo_name, params={})
108
108
  _update_user_repo_params(user_name, repo_name)
109
109
  _validate_user_repo_params(user, repo) unless user? && repo?
110
- _normalize_params_keys(params)
110
+ normalize! params
111
111
 
112
112
  response = get_request("/repos/#{user}/#{repo}/comments", params)
113
113
  return response unless block_given?
@@ -126,7 +126,7 @@ module Github
126
126
  _update_user_repo_params(user_name, repo_name)
127
127
  _validate_user_repo_params(user, repo) unless user? && repo?
128
128
  _validate_presence_of sha
129
- _normalize_params_keys(params)
129
+ normalize! params
130
130
 
131
131
  response = get_request("/repos/#{user}/#{repo}/commits/#{sha}/comments", params)
132
132
  return response unless block_given?
@@ -144,7 +144,7 @@ module Github
144
144
  _update_user_repo_params(user_name, repo_name)
145
145
  _validate_user_repo_params(user, repo) unless user? && repo?
146
146
  _validate_presence_of sha
147
- _normalize_params_keys(params)
147
+ normalize! params
148
148
 
149
149
  get_request("/repos/#{user}/#{repo}/commits/#{sha}", params)
150
150
  end
@@ -160,7 +160,7 @@ module Github
160
160
  _update_user_repo_params(user_name, repo_name)
161
161
  _validate_user_repo_params(user, repo) unless user? && repo?
162
162
  _validate_presence_of comment_id
163
- _normalize_params_keys(params)
163
+ normalize! params
164
164
 
165
165
  get_request("/repos/#{user}/#{repo}/comments/#{comment_id}", params)
166
166
  end
@@ -181,7 +181,7 @@ module Github
181
181
  _validate_user_repo_params(user, repo) unless user? && repo?
182
182
  _validate_presence_of comment_id
183
183
 
184
- _normalize_params_keys(params)
184
+ normalize! params
185
185
  assert_required_keys(%w[ body ], params)
186
186
 
187
187
  patch_request("/repos/#{user}/#{repo}/comments/#{comment_id}", params)
@@ -13,7 +13,7 @@ module Github
13
13
  # github.repos.contents.readme 'user-name', 'repo-name'
14
14
  #
15
15
  def readme(user_name, repo_name, params={})
16
- _normalize_params_keys(params)
16
+ normalize! params
17
17
 
18
18
  get_request("/repos/#{user_name}/#{repo_name}/readme", params)
19
19
  end
@@ -27,7 +27,7 @@ module Github
27
27
  # github.repos.contents.get 'user-name', 'repo-name', 'path'
28
28
  #
29
29
  def get(user_name, repo_name, path, params={})
30
- _normalize_params_keys(params)
30
+ normalize! params
31
31
 
32
32
  get_request("/repos/#{user_name}/#{repo_name}/contents/#{path}", params)
33
33
  end
@@ -53,7 +53,7 @@ module Github
53
53
  # "ref" => "master"
54
54
  #
55
55
  def archive(user_name, repo_name, params={})
56
- _normalize_params_keys(params)
56
+ normalize! params
57
57
  archive_format = params.delete('archive_format') || 'zipball'
58
58
  ref = params.delete('ref') || 'master'
59
59
 
@@ -24,7 +24,7 @@ module Github
24
24
  def list(user_name, repo_name, params={})
25
25
  _update_user_repo_params(user_name, repo_name)
26
26
  _validate_user_repo_params(user, repo) unless user? && repo?
27
- _normalize_params_keys(params)
27
+ normalize! params
28
28
 
29
29
  response = get_request("/repos/#{user}/#{repo}/downloads", params)
30
30
  return response unless block_given?
@@ -42,7 +42,7 @@ module Github
42
42
  _update_user_repo_params(user_name, repo_name)
43
43
  _validate_user_repo_params(user, repo) unless user? && repo?
44
44
  _validate_presence_of download_id
45
- _normalize_params_keys(params)
45
+ normalize! params
46
46
 
47
47
  get_request("/repos/#{user}/#{repo}/downloads/#{download_id}", params)
48
48
  end
@@ -58,7 +58,7 @@ module Github
58
58
  _update_user_repo_params(user_name, repo_name)
59
59
  _validate_user_repo_params(user, repo) unless user? && repo?
60
60
  _validate_presence_of download_id
61
- _normalize_params_keys(params)
61
+ normalize! params
62
62
 
63
63
  delete_request("/repos/#{user}/#{repo}/downloads/#{download_id}", params)
64
64
  end
@@ -85,8 +85,8 @@ module Github
85
85
  _update_user_repo_params(user_name, repo_name)
86
86
  _validate_user_repo_params(user, repo) unless user? && repo?
87
87
 
88
- _normalize_params_keys(params)
89
- _filter_params_keys(VALID_DOWNLOAD_PARAM_NAMES, params)
88
+ normalize! params
89
+ filter! VALID_DOWNLOAD_PARAM_NAMES, params
90
90
  assert_required_keys(REQUIRED_PARAMS, params)
91
91
 
92
92
  post_request("/repos/#{user}/#{repo}/downloads", params)
@@ -16,7 +16,7 @@ module Github
16
16
  def list(user_name, repo_name, params = {})
17
17
  _update_user_repo_params(user_name, repo_name)
18
18
  _validate_user_repo_params(user, repo) unless user? && repo?
19
- _normalize_params_keys(params)
19
+ normalize! params
20
20
 
21
21
  response = get_request("/repos/#{user}/#{repo}/forks", params)
22
22
  return response unless block_given?
@@ -37,8 +37,8 @@ module Github
37
37
  def create(user_name, repo_name, params={})
38
38
  _update_user_repo_params(user_name, repo_name)
39
39
  _validate_user_repo_params(user, repo) unless user? && repo?
40
- _normalize_params_keys(params)
41
- _filter_params_keys(%w[ org ], params)
40
+ normalize! params
41
+ filter! %w[ org ], params
42
42
 
43
43
  post_request("/repos/#{user}/#{repo}/forks", params)
44
44
  end