github_api 0.4.6 → 0.4.7

data/spec/github/request_spec.rb

@@ -1,3 +1,7 @@
 require 'spec_helper'
 
+require 'spec_helper'
 
+describe Github::Request do
+  pending
+end

data/spec/github/response/helpers_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Github::Response::Helpers do
-
   let(:env) { { :body => [1,2,3] } }
   let(:instance) { described_class.new }
 
@@ -14,5 +13,4 @@ describe Github::Response::Helpers do
     res = instance.on_complete(env)
     res[:body].should respond_to :env
   end
-
 end # Github::Response::Helpers

data/spec/github/result_spec.rb

@@ -1,7 +1,8 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Github::Result do
-
   let(:github) { Github.new }
   let(:user)   { 'wycats' }
   let(:res)    { github.events.public({ 'per_page' => 20 }) }
@@ -86,11 +87,9 @@ describe Github::Result do
   context "pagination methods" do
     let(:env) { {:response_headers => {}}}
     let(:iterator) { Github::PageIterator.new(env) }
-    let(:items) { [] }
 
     before do
       described_class.stub(:page_iterator).and_return iterator
-      @items.stub(:env).and_return env
     end
 
     it "should respond to links" do

data/spec/github/users/followers_spec.rb

@@ -1,14 +1,12 @@
-require 'spec_helper'
+# encoding: utf-8
 
-describe Github::Users::Followers, :type => :base do
+require 'spec_helper'
 
-  before do
-    reset_authentication_for github
-  end
+describe Github::Users::Followers do
+  let(:github) { Github.new }
+  let(:user)   { 'peter-murach' }
 
-  after do
-    reset_authentication_for github
-  end
+  after { reset_authentication_for github }
 
   describe "#followers" do
     context "resource found for a user" do

data/spec/github/users_spec.rb

@@ -2,128 +2,128 @@ require 'spec_helper'
 
 describe Github::Users, :type => :base do
 
-  before do
-    reset_authentication_for github
-  end
-
-  after do
-    reset_authentication_for github
-  end
-
-  describe "get_user" do
-    context "resource found for a user" do
-      before do
-        stub_get("/users/#{user}").
-          to_return(:body => fixture('users/user.json'),
-            :status => 200, :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should get the resources" do
-        github.users.get_user user
-        a_get("/users/#{user}").should have_been_made
-      end
-
-      it "should return resource" do
-        user_resource = github.users.get_user user
-        user_resource.should be_a Hash
-      end
-
-      it "should be a mash type" do
-        user_resource = github.users.get_user user
-        user_resource.should be_a Hashie::Mash
-      end
-
-      it "should get org information" do
-        user_resource = github.users.get_user user
-        user_resource.login.should == 'octocat'
-      end
-
-      it "should yield to a block" do
-        github.users.should_receive(:get_user).with(user).and_yield('web')
-        github.users.get_user(user) { |param| 'web' }
-      end
-    end
-
-    context "resource found for an authenticated user" do
-      before do
-        github.oauth_token = OAUTH_TOKEN
-        stub_get("/user").
-          with(:query => { :access_token => "#{OAUTH_TOKEN}"}).
-          to_return(:body => fixture('users/user.json'), :status => 200, :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should get the resources" do
-        github.users.get_user
-        a_get("/user").with(:query => {:access_token => "#{OAUTH_TOKEN}"}).
-          should have_been_made
-      end
-    end
-
-    context "resource not found for a user" do
-      before do
-        stub_get("/users/#{user}").
-          to_return(:body => "", :status => [404, "Not Found"])
-      end
-
-      it "should return 404 with a message 'Not Found'" do
-        expect {
-          github.users.get_user user
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # get_user
-
-  describe "update_user" do
-    let(:user_params) {
-      {
-        "name" => "monalisa octocat",
-        "email" => "octocat@github.com",
-        "blog" => "https://github.com/blog",
-        "company" => "GitHub",
-        "location" => "San Francisco",
-        "hireable" => true,
-        "bio" => "There once..."
-      }
-    }
-
-    context "resouce updated" do
-      before do
-        github.oauth_token = OAUTH_TOKEN
-        stub_patch("/user?access_token=#{OAUTH_TOKEN}").with(user_params).
-          to_return(:body => fixture('users/user.json'), :status => 200, :headers => {:content_type => "application/json; charset=utf-8"})
-
-      end
-
-      it "should create resource successfully" do
-        github.users.update_user
-        a_patch("/user?access_token=#{OAUTH_TOKEN}").with(user_params).should have_been_made
-      end
-
-      it "should return the resource" do
-        user_resource = github.users.update_user
-        user_resource.should be_a Hashie::Mash
-      end
-
-      it "should get the resource information" do
-        user_resource = github.users.update_user
-        user_resource.login.should == 'octocat'
-      end
-    end
-
-    context "failed to update resource" do
-      before do
-        github.oauth_token = OAUTH_TOKEN
-        stub_patch("/user?access_token=#{OAUTH_TOKEN}").with(user_params).
-          to_return(:body => fixture('users/user.json'), :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
-
-      end
-
-      it "should fail to retrieve resource" do
-        expect {
-          github.users.update_user
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # update_comment
+#   before do
+#     reset_authentication_for github
+#   end
+# 
+#   after do
+#     reset_authentication_for github
+#   end
+# 
+#   describe "get_user" do
+#     context "resource found for a user" do
+#       before do
+#         stub_get("/users/#{user}").
+#           to_return(:body => fixture('users/user.json'),
+#             :status => 200, :headers => {:content_type => "application/json; charset=utf-8"})
+#       end
+# 
+#       it "should get the resources" do
+#         github.users.get_user user
+#         a_get("/users/#{user}").should have_been_made
+#       end
+# 
+#       it "should return resource" do
+#         user_resource = github.users.get_user user
+#         user_resource.should be_a Hash
+#       end
+# 
+#       it "should be a mash type" do
+#         user_resource = github.users.get_user user
+#         user_resource.should be_a Hashie::Mash
+#       end
+# 
+#       it "should get org information" do
+#         user_resource = github.users.get_user user
+#         user_resource.login.should == 'octocat'
+#       end
+# 
+#       it "should yield to a block" do
+#         github.users.should_receive(:get_user).with(user).and_yield('web')
+#         github.users.get_user(user) { |param| 'web' }
+#       end
+#     end
+# 
+#     context "resource found for an authenticated user" do
+#       before do
+#         github.oauth_token = OAUTH_TOKEN
+#         stub_get("/user").
+#           with(:query => { :access_token => "#{OAUTH_TOKEN}"}).
+#           to_return(:body => fixture('users/user.json'), :status => 200, :headers => {:content_type => "application/json; charset=utf-8"})
+#       end
+# 
+#       it "should get the resources" do
+#         github.users.get_user
+#         a_get("/user").with(:query => {:access_token => "#{OAUTH_TOKEN}"}).
+#           should have_been_made
+#       end
+#     end
+# 
+#     context "resource not found for a user" do
+#       before do
+#         stub_get("/users/#{user}").
+#           to_return(:body => "", :status => [404, "Not Found"])
+#       end
+# 
+#       it "should return 404 with a message 'Not Found'" do
+#         expect {
+#           github.users.get_user user
+#         }.to raise_error(Github::Error::NotFound)
+#       end
+#     end
+#   end # get_user
+# 
+#   describe "update_user" do
+#     let(:user_params) {
+#       {
+#         "name" => "monalisa octocat",
+#         "email" => "octocat@github.com",
+#         "blog" => "https://github.com/blog",
+#         "company" => "GitHub",
+#         "location" => "San Francisco",
+#         "hireable" => true,
+#         "bio" => "There once..."
+#       }
+#     }
+# 
+#     context "resouce updated" do
+#       before do
+#         github.oauth_token = OAUTH_TOKEN
+#         stub_patch("/user?access_token=#{OAUTH_TOKEN}").with(user_params).
+#           to_return(:body => fixture('users/user.json'), :status => 200, :headers => {:content_type => "application/json; charset=utf-8"})
+# 
+#       end
+# 
+#       it "should create resource successfully" do
+#         github.users.update_user
+#         a_patch("/user?access_token=#{OAUTH_TOKEN}").with(user_params).should have_been_made
+#       end
+# 
+#       it "should return the resource" do
+#         user_resource = github.users.update_user
+#         user_resource.should be_a Hashie::Mash
+#       end
+# 
+#       it "should get the resource information" do
+#         user_resource = github.users.update_user
+#         user_resource.login.should == 'octocat'
+#       end
+#     end
+# 
+#     context "failed to update resource" do
+#       before do
+#         github.oauth_token = OAUTH_TOKEN
+#         stub_patch("/user?access_token=#{OAUTH_TOKEN}").with(user_params).
+#           to_return(:body => fixture('users/user.json'), :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
+# 
+#       end
+# 
+#       it "should fail to retrieve resource" do
+#         expect {
+#           github.users.update_user
+#         }.to raise_error(Github::Error::NotFound)
+#       end
+#     end
+#   end # update_comment
 
 end # Github::Users

data/spec/github/validation_spec.rb

@@ -1,19 +1,20 @@
 require 'spec_helper'
 
-describe Github::Validation, :type => :base do
+describe Github::Validation do
+  let(:github) { Github.new }
 
   context '#_validate_inputs' do
-    before do
-      @required = ['param_a', 'param_c']
-      @provided = { 'param_a' => true, 'param_c' => true }
-    end
+    let(:required) { ['param_a', 'param_c'] }
+    let(:provided) { { 'param_a' => true, 'param_c' => true } }
 
     it 'detect missing parameter' do
-      github._validate_inputs(@required, @provided.except('param_c')).should be_false
+      expect {
+      github._validate_inputs(required, provided.except('param_c')).should be_false
+      }.to raise_error(Github::Error::RequiredParams)
     end
 
     it 'asserts correct required parameters' do
-      github._validate_inputs(@required, @provided).should be_true
+      github._validate_inputs(required, provided).should be_true
     end
   end
 

data/spec/github_spec.rb

@@ -1,12 +1,12 @@
-require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
+# encoding: utf-8
+
+require 'spec_helper'
 
 describe Github do
 
-  before do
-    subject.user = nil
-    subject.repo = nil
-    subject.oauth_token = nil
-    subject.basic_auth = nil
+  after do
+    subject.set_defaults
+    reset_authentication_for subject
   end
 
   it "should respond to 'new' message" do
@@ -22,7 +22,6 @@ describe Github do
   end
 
   describe "setting configuration options" do
-
     it "should return default adapter" do
       subject.adapter.should == Github::Configuration::DEFAULT_ADAPTER
     end

data/spec/spec_helper.rb

@@ -28,7 +28,7 @@ end
 
 RSpec.configure do |config|
   config.include WebMock::API
-  # config.order = :rand
+  config.order = :rand
   config.color_enabled = true
   config.treat_symbols_as_metadata_keys_with_true_values = true
 
@@ -91,7 +91,7 @@ end
 OAUTH_TOKEN = 'bafec72922f31fe86aacc8aca4261117f3bd62cf'
 
 def reset_authentication_for(object)
-  ['basic_auth', 'oauth_token', 'login', 'password' ].each do |item|
+  [ 'user', 'repo', 'basic_auth', 'oauth_token', 'login', 'password' ].each do |item|
     object.send("#{item}=", nil)
   end
 end

metadata

@@ -2,7 +2,7 @@
 name: github_api
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.4.6
+  version: 0.4.7
 platform: ruby
 authors: 
 - Piotr Murach
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-02-27 00:00:00 +00:00
+date: 2012-03-11 00:00:00 +00:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -91,82 +91,93 @@ dependencies:
   type: :development
   version_requirements: *id007
 - !ruby/object:Gem::Dependency 
-  name: bundler
+  name: webmock
   prerelease: false
   requirement: &id008 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        version: 1.0.0
+        version: 1.8.0
   type: :development
   version_requirements: *id008
 - !ruby/object:Gem::Dependency 
-  name: webmock
+  name: vcr
   prerelease: false
   requirement: &id009 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        version: 1.8.0
+        version: 2.0.0
   type: :development
   version_requirements: *id009
 - !ruby/object:Gem::Dependency 
-  name: vcr
+  name: simplecov
   prerelease: false
   requirement: &id010 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        version: 1.11.3
+        version: 0.6.1
   type: :development
   version_requirements: *id010
 - !ruby/object:Gem::Dependency 
-  name: simplecov
+  name: guard
   prerelease: false
   requirement: &id011 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        version: 0.6.1
+        version: 0.8.8
   type: :development
   version_requirements: *id011
 - !ruby/object:Gem::Dependency 
-  name: guard
+  name: guard-rspec
   prerelease: false
   requirement: &id012 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ~>
+    - - "="
       - !ruby/object:Gem::Version 
-        version: 0.8.8
+        version: 0.5.7
   type: :development
   version_requirements: *id012
 - !ruby/object:Gem::Dependency 
-  name: guard-rspec
+  name: guard-cucumber
   prerelease: false
   requirement: &id013 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - "="
       - !ruby/object:Gem::Version 
-        version: 0.5.7
+        version: 0.7.4
   type: :development
   version_requirements: *id013
 - !ruby/object:Gem::Dependency 
-  name: guard-cucumber
+  name: rake
   prerelease: false
   requirement: &id014 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - "="
+    - - ">="
       - !ruby/object:Gem::Version 
-        version: 0.7.4
+        version: "0"
   type: :development
   version_requirements: *id014
+- !ruby/object:Gem::Dependency 
+  name: bundler
+  prerelease: false
+  requirement: &id015 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: "0"
+  type: :development
+  version_requirements: *id015
 description: " Ruby wrapper that supports all of the GitHub API v3 methods(nearly 200). It's build in a modular way, that is, you can either instantiate the whole api wrapper Github.new or use parts of it e.i. Github::Repos.new if working solely with repositories is your main concern. "
 email: ""
 executables: []
@@ -185,7 +196,6 @@ files:
 - features/cassettes/gists/gist.yml
 - features/cassettes/gists/gists/public_all.yml
 - features/cassettes/gists/gists/user_all.yml
-- features/cassettes/gists/star.yml
 - features/cassettes/pagination/repos/commits/next.yml
 - features/cassettes/pagination/repos/commits/sha/next.yml
 - features/cassettes/pagination/repos/commits/sha.yml
@@ -193,13 +203,11 @@ files:
 - features/cassettes/pagination/repos/diff/next.yml
 - features/cassettes/pagination/repos/diff.yml
 - features/cassettes/pagination/repos/next.yml
-- features/cassettes/pagination/repos/per_page/1.yml
 - features/cassettes/pagination/repos/per_page/each_page.yml
 - features/cassettes/pagination/repos/per_page/first.yml
 - features/cassettes/pagination/repos.yml
 - features/cassettes/repos/branches.yml
 - features/cassettes/repos/tags.yml
-- features/cassettes/repos/teams.yml
 - features/error_codes.feature
 - features/gists/comments.feature
 - features/gists.feature
@@ -228,13 +236,17 @@ files:
 - lib/github_api/core_ext/hash.rb
 - lib/github_api/deprecation.rb
 - lib/github_api/error/bad_request.rb
+- lib/github_api/error/client_error.rb
 - lib/github_api/error/forbidden.rb
 - lib/github_api/error/internal_server_error.rb
+- lib/github_api/error/invalid_options.rb
 - lib/github_api/error/not_found.rb
+- lib/github_api/error/required_params.rb
 - lib/github_api/error/service_error.rb
 - lib/github_api/error/service_unavailable.rb
 - lib/github_api/error/unauthorized.rb
 - lib/github_api/error/unprocessable_entity.rb
+- lib/github_api/error/validations.rb
 - lib/github_api/error.rb
 - lib/github_api/events.rb
 - lib/github_api/filter.rb
@@ -364,6 +376,9 @@ files:
 - spec/github/client_spec.rb
 - spec/github/core_ext/hash_spec.rb
 - spec/github/deprecation_spec.rb
+- spec/github/error/client_error_spec.rb
+- spec/github/error/invalid_options_spec.rb
+- spec/github/error/required_params_spec.rb
 - spec/github/events_spec.rb
 - spec/github/filter_spec.rb
 - spec/github/gists/comments_spec.rb