github_api 0.4.6 → 0.4.7

data/spec/github/git_data/references_spec.rb

@@ -1,10 +1,16 @@
-require 'spec_helper'
+# encoding: utf-8
 
-describe Github::GitData::References, :type => :base do
+require 'spec_helper'
 
+describe Github::GitData::References do
+  let(:github) { Github.new }
+  let(:user) { 'peter-murach' }
+  let(:repo) { 'github' }
   let(:ref) { "heads/master" }
   let(:sha) { "3a0f86fb8db8eea7ccbb9a95f325ddbedfb25e15" }
 
+  after { github.user, github.repo, github.oauth_token = nil, nil, nil }
+
   it { described_class::VALID_REF_PARAM_NAMES.should_not be_nil }
   it { described_class::VALID_REF_PARAM_VALUES.should_not be_nil }
 
@@ -23,7 +29,6 @@ describe Github::GitData::References, :type => :base do
       end
 
       it "should fail to get resource without username" do
-        github.user, github.repo = nil, nil
         expect { github.git_data.references }.to raise_error(ArgumentError)
       end
 
@@ -161,7 +166,7 @@ describe Github::GitData::References, :type => :base do
       it "should fail to create resource if 'sha' input is missing" do
         expect {
           github.git_data.create_reference user, repo, inputs.except('sha')
-        }.to raise_error(ArgumentError)
+        }.to raise_error(Github::Error::RequiredParams)
       end
 
       it "should fail to create resource if 'ref' is wrong" do
@@ -217,13 +222,13 @@ describe Github::GitData::References, :type => :base do
           to_return(:body => fixture('git_data/reference.json'), :status => 201, :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
-      it "should fail to create resource if 'sha' input is missing" do
+      it "should fail to update resource if 'sha' input is missing" do
         expect {
           github.git_data.update_reference user, repo, ref, inputs.except('sha')
-        }.to raise_error(ArgumentError)
+        }.to raise_error(Github::Error::RequiredParams)
       end
 
-      it "should fail to create resource if 'ref' is wrong" do
+      it "should fail to update resource if 'ref' is wrong" do
         expect {
           github.git_data.update_reference user, repo, 'branch', inputs
         }.to raise_error(ArgumentError)
@@ -245,7 +250,7 @@ describe Github::GitData::References, :type => :base do
       end
     end
 
-    context "failed to create resource" do
+    context "failed to update resource" do
       before do
         stub_patch("/repos/#{user}/#{repo}/git/refs/#{ref}").with(inputs).
           to_return(:body => fixture('git_data/reference.json'), :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})

data/spec/github/git_data/tags_spec.rb

@@ -1,9 +1,15 @@
-require 'spec_helper'
+# encoding: utf-8
 
-describe Github::GitData::Tags, :type => :base do
+require 'spec_helper'
 
+describe Github::GitData::Tags do
+  let(:github) { Github.new }
+  let(:user) { 'peter-murach' }
+  let(:repo) { 'github' }
   let(:sha) { "940bd336248efae0f9ee5bc7b2d5c985887b16ac" }
 
+  after { github.user, github.repo, github.oauth_token = nil, nil, nil }
+
   it { described_class::VALID_TAG_PARAM_NAMES.should_not be_nil }
 
   describe "tag" do
@@ -97,7 +103,6 @@ describe Github::GitData::Tags, :type => :base do
         stub_post("/repos/#{user}/#{repo}/git/tags").
           with(inputs).
           to_return(:body => fixture('git_data/tag.json'), :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
-
       end
 
       it "should faile to retrieve resource" do

data/spec/github/git_data/trees_spec.rb

@@ -1,9 +1,15 @@
-require 'spec_helper'
+# encoding: utf-8
 
-describe Github::GitData::Trees, :type => :base do
+require 'spec_helper'
 
+describe Github::GitData::Trees do
+  let(:github) { Github.new }
+  let(:user) { 'peter-murach' }
+  let(:repo) { 'github' }
   let(:sha) { "9fb037999f264ba9a7fc6274d15fa3ae2ab98312" }
 
+  after { github.user, github.repo, github.oauth_token = nil, nil, nil }
+
   it { described_class::VALID_TREE_PARAM_NAMES.should_not be_nil }
 
   describe "tree" do
@@ -96,7 +102,7 @@ describe Github::GitData::Trees, :type => :base do
       it "should fail to create resource if 'content' input is missing" do
         expect {
           github.git_data.create_tree user, repo, inputs.except('tree')
-        }.to raise_error(ArgumentError)
+        }.to raise_error(Github::Error::RequiredParams)
       end
 
       it "should create resource successfully" do

data/spec/github/issues/comments_spec.rb

@@ -1,9 +1,16 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
-describe Github::Issues::Comments, :type => :base do
+describe Github::Issues::Comments do
+  let(:github) { Github.new }
+  let(:user)   { 'peter-murach' }
+  let(:repo)   { 'github' }
   let!(:comment_id) { 1 }
   let!(:issue_id) { 1 }
 
+  after { github.user, github.repo, github.oauth_token = nil, nil, nil }
+
   it { described_class::VALID_ISSUE_COMMENT_PARAM_NAME.should_not be_nil }
 
   describe 'comments' do
@@ -128,7 +135,7 @@ describe Github::Issues::Comments, :type => :base do
       it "should fail to create resource if 'body' input is missing" do
         expect {
           github.issues.create_comment user, repo, issue_id, inputs.except('body')
-        }.to raise_error(ArgumentError)
+        }.to raise_error(Github::Error::RequiredParams)
       end
 
       it "should create resource successfully" do
@@ -177,7 +184,7 @@ describe Github::Issues::Comments, :type => :base do
       it "should fail to create resource if 'body' input is missing" do
         expect {
           github.issues.edit_comment user, repo, comment_id, inputs.except('body')
-        }.to raise_error(ArgumentError)
+        }.to raise_error(Github::Error::RequiredParams)
       end
 
       it "should create resource successfully" do

data/spec/github/issues/events_spec.rb

@@ -1,8 +1,15 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
-describe Github::Issues::Events, :type => :base do
+describe Github::Issues::Events do
+  let(:github) { Github.new }
+  let(:user)   { 'peter-murach' }
+  let(:repo)   { 'github' }
   let(:issue_id) { 1 }
 
+  after { github.user, github.repo, github.oauth_token = nil, nil, nil }
+
   describe 'events' do
     it { github.issues.should respond_to :events }
     it { github.issues.should respond_to :list_events }
@@ -17,7 +24,6 @@ describe Github::Issues::Events, :type => :base do
         end
 
         it "should fail to get resource without username" do
-          github.user, github.repo = nil, nil
           expect { github.issues.events }.to raise_error(ArgumentError)
         end
 
@@ -60,7 +66,6 @@ describe Github::Issues::Events, :type => :base do
           }.to raise_error(Github::Error::NotFound)
         end
       end
-
     end # without issue_id
 
     context 'with issue_id' do

data/spec/github/issues/labels_spec.rb

@@ -1,6 +1,11 @@
 require 'spec_helper'
 
-describe Github::Issues::Labels, :type => :base do
+describe Github::Issues::Labels do
+  let(:github) { Github.new }
+  let(:user)   { 'peter-murach' }
+  let(:repo)   { 'github' }
+
+  after { github.user, github.repo, github.oauth_token = nil, nil, nil }
 
   it { described_class::VALID_LABEL_INPUTS.should_not be_nil }
 
@@ -123,13 +128,13 @@ describe Github::Issues::Labels, :type => :base do
       it "should fail to create resource if 'name' input is missing" do
         expect {
           github.issues.create_label user, repo, inputs.except('name')
-        }.to raise_error(ArgumentError)
+        }.to raise_error(Github::Error::RequiredParams)
       end
 
       it "should fail to create resource if 'color' input is missing" do
         expect {
           github.issues.create_label user, repo, inputs.except('color')
-        }.to raise_error(ArgumentError)
+        }.to raise_error(Github::Error::RequiredParams)
       end
 
       it "should create resource successfully" do
@@ -181,13 +186,13 @@ describe Github::Issues::Labels, :type => :base do
       it "should fail to create resource if 'name' input is missing" do
         expect {
           github.issues.update_label user, repo, label_id, inputs.except('name')
-        }.to raise_error(ArgumentError)
+        }.to raise_error(Github::Error::RequiredParams)
       end
 
       it "should fail to create resource if 'color' input is missing" do
         expect {
           github.issues.update_label user, repo, label_id, inputs.except('color')
-        }.to raise_error(ArgumentError)
+        }.to raise_error(Github::Error::RequiredParams)
       end
 
       it "should update resource successfully" do
@@ -274,13 +279,14 @@ describe Github::Issues::Labels, :type => :base do
 
       it "should fail to get resource without issue_id" do
         expect {
-          github.issues.labels_for user, repo, nil 
+          github.issues.labels_for user, repo, nil
         }.to raise_error(ArgumentError)
       end
 
       it "should get the resources" do
         github.issues.labels_for user, repo, issue_id
-        a_get("/repos/#{user}/#{repo}/issues/#{issue_id}/labels").should have_been_made
+        a_get("/repos/#{user}/#{repo}/issues/#{issue_id}/labels").
+          should have_been_made
       end
 
       it "should return array of resources" do

data/spec/github/issues/milestones_spec.rb

@@ -1,6 +1,13 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
-describe Github::Issues::Milestones, :type => :base do
+describe Github::Issues::Milestones do
+  let(:github) { Github.new }
+  let(:user)   { 'peter-murach' }
+  let(:repo)   { 'github' }
+
+  after { github.user, github.repo, github.oauth_token = nil, nil, nil }
 
   it { described_class::VALID_MILESTONE_OPTIONS.should_not be_nil }
   it { described_class::VALID_MILESTONE_INPUTS.should_not be_nil }
@@ -127,7 +134,7 @@ describe Github::Issues::Milestones, :type => :base do
       it "should fail to create resource if 'title' input is missing" do
         expect {
           github.issues.create_milestone user, repo, inputs.except('title')
-        }.to raise_error(ArgumentError)
+        }.to raise_error(Github::Error::RequiredParams)
       end
 
       it "should create resource successfully" do
@@ -181,7 +188,7 @@ describe Github::Issues::Milestones, :type => :base do
       it "should fail to create resource if 'title' input is missing" do
         expect {
           github.issues.update_milestone user, repo, milestone_id, inputs.except('title')
-        }.to raise_error(ArgumentError)
+        }.to raise_error(Github::Error::RequiredParams)
       end
 
       it "should update resource successfully" do

data/spec/github/issues_spec.rb

@@ -3,12 +3,13 @@
 require 'spec_helper'
 
 describe Github::Issues do
-
   let(:issues_api) { Github::Issues }
   let(:github) { Github.new }
   let(:user)   { 'peter-murach' }
   let(:repo)   { 'github' }
 
+  after { github.user, github.repo, github.oauth_token = nil, nil, nil }
+
   describe 'modules inclusion' do
     it { issues_api.included_modules.should include Github::Issues::Comments }
     it { issues_api.included_modules.should include Github::Issues::Events }
@@ -193,7 +194,7 @@ describe Github::Issues do
       it "should fail to create resource if 'title' input is missing" do
         expect {
           github.issues.create_issue user, repo, inputs.except('title')
-        }.to raise_error(ArgumentError)
+        }.to raise_error(Github::Error::RequiredParams)
       end
 
       it "should create resource successfully" do
@@ -248,7 +249,6 @@ describe Github::Issues do
       end
 
       it "should fail to edit without 'user/repo' parameters" do
-        github.user, github.repo = nil, nil
         expect {
           github.issues.edit_issue nil, repo, issue_id
         }.to raise_error(ArgumentError)

data/spec/github/mime_type_spec.rb

@@ -2,69 +2,69 @@ require 'spec_helper'
 
 describe Github::MimeType do
 
-  let(:github) { Github.new }
-
-  it "should lookup mime type for :full" do
-    github.lookup_mime(:full).should == 'full+json'
-  end
-
-  it "should lookup mime type for :html" do
-    github.lookup_mime(:html).should == 'html+json'
-  end
-
-  it "should lookup mime type for :html" do
-    github.lookup_mime(:text).should == 'text+json'
-  end
-
-  it "should lookup mime type for :raw" do
-    github.lookup_mime(:raw).should == 'raw+json'
-  end
-
-  it "should default to json if no parameters given" do
-    Github.should_receive(:parse).and_return 'application/json'
-    Github.parse.should == 'application/json'
-  end
-
-  it "should accept header for 'issue' request" do
-    Github.should_receive(:parse).with(:issue, :full).
-      and_return 'application/vnd.github-issue.full+json'
-    Github.parse(:issue, :full).should == 'application/vnd.github-issue.full+json'
-  end
-
-  it "should accept header for 'isssue comment' request" do
-    Github.should_receive(:parse).with(:issue_comment, :full).
-      and_return 'application/vnd.github-issuecomment.full+json'
-    Github.parse(:issue_comment, :full).should == 'application/vnd.github-issuecomment.full+json'
-  end
-
-  it "should accept header for 'commit comment' request" do
-    Github.should_receive(:parse).with(:commit_comment, :full).
-      and_return 'application/vnd.github-commitcomment.full+json'
-    Github.parse(:commit_comment, :full).should == 'application/vnd.github-commitcomment.full+json'
-  end
-
-  it "should accept header for 'pull requst' request" do
-    Github.should_receive(:parse).with(:pull_request, :full).
-      and_return 'application/vnd.github-pull.full+json'
-    Github.parse(:pull_request, :full).should == 'application/vnd.github-pull.full+json'
-  end
-
-  it "should accept header for 'pull comment' request" do
-    Github.should_receive(:parse).with(:pull_comment, :full).
-      and_return 'application/vnd.github-pullcomment.full+json'
-    Github.parse(:pull_comment, :full).should == 'application/vnd.github-pullcomment.full+json'
-  end
-
-  it "should accept header for 'gist comment' request" do
-    Github.should_receive(:parse).with(:gist_comment, :full).
-      and_return 'application/vnd.github-gistcomment.full+json'
-    Github.parse(:gist_comment, :full).should == 'application/vnd.github-gistcomment.full+json'
-  end
-
-  it "should accept header for 'blog' request" do
-    Github.should_receive(:parse).with(:blob, :blob).
-      and_return 'application/vnd.github-blob.raw'
-    Github.parse(:blob, :blob).should == 'application/vnd.github-blob.raw'
-  end
+#   let(:github) { Github.new }
+# 
+#   it "should lookup mime type for :full" do
+#     github.lookup_mime(:full).should == 'full+json'
+#   end
+# 
+#   it "should lookup mime type for :html" do
+#     github.lookup_mime(:html).should == 'html+json'
+#   end
+# 
+#   it "should lookup mime type for :html" do
+#     github.lookup_mime(:text).should == 'text+json'
+#   end
+# 
+#   it "should lookup mime type for :raw" do
+#     github.lookup_mime(:raw).should == 'raw+json'
+#   end
+# 
+#   it "should default to json if no parameters given" do
+#     Github.should_receive(:parse).and_return 'application/json'
+#     Github.parse.should == 'application/json'
+#   end
+# 
+#   it "should accept header for 'issue' request" do
+#     Github.should_receive(:parse).with(:issue, :full).
+#       and_return 'application/vnd.github-issue.full+json'
+#     Github.parse(:issue, :full).should == 'application/vnd.github-issue.full+json'
+#   end
+# 
+#   it "should accept header for 'isssue comment' request" do
+#     Github.should_receive(:parse).with(:issue_comment, :full).
+#       and_return 'application/vnd.github-issuecomment.full+json'
+#     Github.parse(:issue_comment, :full).should == 'application/vnd.github-issuecomment.full+json'
+#   end
+# 
+#   it "should accept header for 'commit comment' request" do
+#     Github.should_receive(:parse).with(:commit_comment, :full).
+#       and_return 'application/vnd.github-commitcomment.full+json'
+#     Github.parse(:commit_comment, :full).should == 'application/vnd.github-commitcomment.full+json'
+#   end
+# 
+#   it "should accept header for 'pull requst' request" do
+#     Github.should_receive(:parse).with(:pull_request, :full).
+#       and_return 'application/vnd.github-pull.full+json'
+#     Github.parse(:pull_request, :full).should == 'application/vnd.github-pull.full+json'
+#   end
+# 
+#   it "should accept header for 'pull comment' request" do
+#     Github.should_receive(:parse).with(:pull_comment, :full).
+#       and_return 'application/vnd.github-pullcomment.full+json'
+#     Github.parse(:pull_comment, :full).should == 'application/vnd.github-pullcomment.full+json'
+#   end
+# 
+#   it "should accept header for 'gist comment' request" do
+#     Github.should_receive(:parse).with(:gist_comment, :full).
+#       and_return 'application/vnd.github-gistcomment.full+json'
+#     Github.parse(:gist_comment, :full).should == 'application/vnd.github-gistcomment.full+json'
+#   end
+# 
+#   it "should accept header for 'blog' request" do
+#     Github.should_receive(:parse).with(:blob, :blob).
+#       and_return 'application/vnd.github-blob.raw'
+#     Github.parse(:blob, :blob).should == 'application/vnd.github-blob.raw'
+#   end
 
 end # Github::MimeType

data/spec/github/orgs/members_spec.rb

@@ -1,11 +1,12 @@
 require 'spec_helper'
 
 describe Github::Orgs::Members do
-
   let(:github) { Github.new }
   let(:member) { 'peter-murach' }
   let(:org)    { 'github' }
 
+  after { github.user, github.repo, github.oauth_token = nil, nil, nil }
+
   describe "members" do
     context "resource found" do
       before do
@@ -59,13 +60,9 @@ describe Github::Orgs::Members do
   end # members
 
   describe "member?" do
-
     context "with username ane reponame passed" do
-
       context "this repo is being watched by the user"
         before do
-          github.oauth_token = nil
-          github.user = nil
           stub_get("/orgs/#{org}/members/#{member}").
             to_return(:body => "", :status => 404, :headers => {:user_agent => github.user_agent})
         end
@@ -81,7 +78,6 @@ describe Github::Orgs::Members do
         membership = github.orgs.member? org, member
         membership.should be_true
       end
-
     end
 
     context "without org name and member name passed" do
@@ -144,13 +140,9 @@ describe Github::Orgs::Members do
   end # public_members
 
   describe "public_member?" do
-
     context "with username ane reponame passed" do
-
       context "this repo is being watched by the user"
         before do
-          github.oauth_token = nil
-          github.user = nil
           stub_get("/orgs/#{org}/public_members/#{member}").
             to_return(:body => "", :status => 404, :headers => {:user_agent => github.user_agent})
         end
@@ -166,7 +158,6 @@ describe Github::Orgs::Members do
         public_member = github.orgs.public_member? org, member
         public_member.should be_true
       end
-
     end
 
     context "without org name and member name passed" do