git-lint 4.6.0 → 5.0.0

data/lib/git/lint/commits/systems/netlify_ci.rb

@@ -1,24 +1,24 @@
 # frozen_string_literal: true
 
-require "open3"
-
 module Git
   module Lint
     module Commits
       module Systems
         # Provides Netlify CI build environment feature branch information.
         class NetlifyCI
-          include Git::Lint::Import[:repository, :executor, :environment]
+          include Git::Lint::Import[:git, :environment]
 
           def call
-            executor.capture3 "git remote add -f origin #{environment["REPOSITORY_URL"]}"
-            executor.capture3 "git fetch origin #{name}:#{name}"
-            repository.commits "origin/#{repository.branch_default}..origin/#{name}"
+            git.call("remote", "add", "-f", "origin", environment["REPOSITORY_URL"])
+               .bind { git.call "fetch", "origin", "#{branch_name}:#{branch_name}" }
+               .bind { git.commits "origin/#{branch_default}..origin/#{branch_name}" }
           end
 
           private
 
-          def name = environment["HEAD"]
+          def branch_default = git.branch_default.value_or nil
+
+          def branch_name = environment["HEAD"]
         end
       end
     end

data/lib/git/lint/configuration/defaults.yml

@@ -23,18 +23,11 @@
     :enabled: true
     :severity: :error
     :includes: "\\-"
-  :commit_body_tracker_shorthand:
-    :enabled: true
-    :severity: :error
-    :excludes:
-      - "(f|F)ix(es|ed)?\\s\\#\\d+"
-      - "(c|C)lose(s|d)?\\s\\#\\d+"
-      - "(r|R)esolve(s|d)?\\s\\#\\d+"
   :commit_body_leading_line:
-    :enabled: false
+    :enabled: true
     :severity: :warn
   :commit_body_line_length:
-    :enabled: true
+    :enabled: false
     :severity: :error
     :maximum: 72
   :commit_body_paragraph_capitalization:
@@ -71,13 +64,24 @@
       - "as\\sfar\\sas\\s.+\\sconcerned"
       - "of\\sthe\\s(fact|opinion)\\sthat"
   :commit_body_presence:
-    :enabled: false
+    :enabled: true
     :severity: :warn
     :minimum: 1
   :commit_body_single_bullet:
     :enabled: true
     :severity: :error
     :includes: "\\-"
+  :commit_body_tracker_shorthand:
+    :enabled: true
+    :severity: :error
+    :excludes:
+      - "(f|F)ix(es|ed)?\\s\\#\\d+"
+      - "(c|C)lose(s|d)?\\s\\#\\d+"
+      - "(r|R)esolve(s|d)?\\s\\#\\d+"
+  :commit_signature:
+    :enabled: false
+    :severity: :error
+    :includes: Good
   :commit_subject_length:
     :enabled: true
     :severity: :error
@@ -102,18 +106,57 @@
   :commit_trailer_collaborator_capitalization:
     :enabled: true
     :severity: :error
-  :commit_trailer_collaborator_duplication:
-    :enabled: true
-    :severity: :error
   :commit_trailer_collaborator_email:
     :enabled: true
     :severity: :error
   :commit_trailer_collaborator_key:
     :enabled: true
     :severity: :error
-    :includes:
-      - "Co-Authored-By"
+    :includes: Co-Authored-By
   :commit_trailer_collaborator_name:
     :enabled: true
     :severity: :error
     :minimum: 2
+  :commit_trailer_duplicate:
+    :enabled: true
+    :severity: :error
+  :commit_trailer_format_key:
+    :enabled: true
+    :severity: :error
+    :includes: Format
+  :commit_trailer_format_value:
+    :enabled: true
+    :severity: :error
+    :includes:
+      - ASCII
+      - Markdown
+  :commit_trailer_issue_key:
+    :enabled: true
+    :severity: :error
+    :includes: Issue
+  :commit_trailer_issue_value:
+    :enabled: true
+    :severity: :error
+    :includes: "[\\w-]+"
+  :commit_trailer_signer_capitalization:
+    :enabled: true
+    :severity: :error
+  :commit_trailer_signer_email:
+    :enabled: true
+    :severity: :error
+  :commit_trailer_signer_key:
+    :enabled: true
+    :severity: :error
+    :includes: Signed-By
+  :commit_trailer_signer_name:
+    :enabled: true
+    :severity: :error
+    :minimum: 2
+  :commit_trailer_tracker_key:
+    :enabled: true
+    :severity: :error
+    :includes: Tracker
+  :commit_trailer_tracker_value:
+    :enabled: true
+    :severity: :error
+    :includes: "[\\w\\-\\s]+"

data/lib/git/lint/container.rb

@@ -2,8 +2,7 @@
 
 require "cogger"
 require "dry-container"
-require "git_plus"
-require "open3"
+require "gitt"
 require "spek"
 
 module Git
@@ -14,11 +13,33 @@ module Git
 
       register(:configuration) { Configuration::Loader.call }
       register(:environment) { ENV }
-      register(:repository) { GitPlus::Repository.new }
+      register(:git) { Gitt::Repository.new }
       register(:specification) { Spek::Loader.call "#{__dir__}/../../../git-lint.gemspec" }
       register(:kernel) { Kernel }
-      register(:executor) { Open3 }
       register(:logger) { Cogger::Client.new }
+
+      namespace :trailers do
+        register(:collaborator) { /\ACo.*Authored.*By.*\Z/i }
+        register(:format) { /\AFormat.*\Z/i }
+        register(:issue) { /\AIssue.*\Z/i }
+        register(:signer) { /\ASigned.*By.*\Z/i }
+        register(:tracker) { /\ATracker.*\Z/i }
+      end
+
+      namespace :parsers do
+        register(:person) { Gitt::Parsers::Person.new }
+      end
+
+      namespace :sanitizers do
+        register(:email) { Gitt::Sanitizers::Email }
+        register(:signature) { Gitt::Sanitizers::Signature }
+      end
+
+      namespace :validators do
+        register(:capitalization) { Validators::Capitalization.new }
+        register(:email) { Validators::Email.new }
+        register(:name) { Validators::Name.new }
+      end
     end
   end
 end

data/lib/git/lint/rake/{tasks.rb → register.rb}

@@ -1,26 +1,24 @@
 # frozen_string_literal: true
 
-require "rake"
 require "git/lint"
+require "rake"
 
 module Git
   module Lint
     module Rake
-      # Defines and installs Rake tasks for use in downstream projects.
-      class Tasks
+      # Registers Rake tasks for use.
+      class Register
         include ::Rake::DSL
 
-        def self.setup = new.install
+        def self.call = new.call
 
         def initialize shell: CLI::Shell.new
           @shell = shell
         end
 
-        def install
+        def call
           desc "Run Git Lint"
-          task :git_lint do
-            shell.call ["--analyze"]
-          end
+          task(:git_lint) { shell.call ["--analyze"] }
         end
 
         private

data/lib/git/lint/reporters/commit.rb

@@ -13,7 +13,7 @@ module Git
         def to_s
           return "" if analyzers.empty?
 
-          "#{commit.sha} (#{commit.author_name}, #{commit.author_date_relative}): " \
+          "#{commit.sha} (#{commit.author_name}, #{commit.authored_relative_at}): " \
           "#{commit.subject}\n#{report}\n"
         end
 

data/lib/git/lint/validators/capitalization.rb

@@ -5,21 +5,18 @@ module Git
     module Validators
       # Validates the capitalizationn of text.
       class Capitalization
-        DEFAULT_PATTERN = /\A[[:upper:]].*\Z/
+        PATTERN = /\A[[:upper:]].*\Z/
 
-        def initialize text, delimiter: Name::DEFAULT_DELIMITER, pattern: DEFAULT_PATTERN
-          @text = String text
+        def initialize delimiter: Name::DELIMITER, pattern: PATTERN
           @delimiter = delimiter
           @pattern = pattern
         end
 
-        def valid? = parts.all? { |name| String(name).match? pattern }
+        def call(content) = String(content).split(delimiter).all? { |name| name.match? pattern }
 
         private
 
-        attr_reader :text, :delimiter, :pattern
-
-        def parts = text.split(delimiter)
+        attr_reader :delimiter, :pattern
       end
     end
   end

data/lib/git/lint/validators/email.rb

@@ -7,16 +7,15 @@ module Git
     module Validators
       # Validates the format of email addresses.
       class Email
-        def initialize text, pattern: URI::MailTo::EMAIL_REGEXP
-          @text = text
+        def initialize pattern: URI::MailTo::EMAIL_REGEXP
           @pattern = pattern
         end
 
-        def valid? = String(text).match?(pattern)
+        def call(content) = String(content).match? pattern
 
         private
 
-        attr_reader :text, :pattern
+        attr_reader :pattern
       end
     end
   end

data/lib/git/lint/validators/name.rb

@@ -1,26 +1,29 @@
 # frozen_string_literal: true
 
+require "refinements/strings"
+
 module Git
   module Lint
     module Validators
       # Validates the format of names.
       class Name
-        DEFAULT_DELIMITER = /\s{1}/
-        DEFAULT_MINIMUM = 2
+        using Refinements::Strings
+
+        DELIMITER = /\s{1}/
+        MINIMUM = 2
 
-        def initialize text, delimiter: DEFAULT_DELIMITER, minimum: DEFAULT_MINIMUM
-          @text = text
+        def initialize delimiter: DELIMITER
           @delimiter = delimiter
-          @minimum = minimum
         end
 
-        def valid? = parts.size >= minimum && parts.all? { |name| !String(name).empty? }
+        def call content, minimum: MINIMUM
+          parts = String(content).split delimiter
+          parts.size >= minimum && parts.all? { |name| !name.blank? }
+        end
 
         private
 
-        attr_reader :text, :delimiter, :minimum
-
-        def parts = String(text).split(delimiter)
+        attr_reader :delimiter
       end
     end
   end

data/lib/git/lint.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require "zeitwerk"
-require "git_plus"
 
 Zeitwerk::Loader.new.then do |loader|
   loader.inflector.inflect "cli" => "CLI",

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: git-lint
 version: !ruby/object:Gem::Version
-  version: 4.6.0
+  version: 5.0.0
 platform: ruby
 authors:
 - Brooke Kuhlmann
@@ -28,7 +28,7 @@ cert_chain:
   CxDe2+VuChj4I1nvIHdu+E6XoEVlanUPKmSg6nddhkKn2gC45Kyzh6FZqnzH/CRp
   RFE=
   -----END CERTIFICATE-----
-date: 2022-10-22 00:00:00.000000000 Z
+date: 2022-12-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cogger
@@ -36,14 +36,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.4'
+        version: '0.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.4'
+        version: '0.5'
 - !ruby/object:Gem::Dependency
   name: dry-container
   requirement: !ruby/object:Gem::Requirement
@@ -59,33 +59,47 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0.11'
 - !ruby/object:Gem::Dependency
-  name: git_plus
+  name: dry-monads
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '1.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '1.6'
+- !ruby/object:Gem::Dependency
+  name: gitt
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: infusible
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.2'
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.2'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: pastel
   requirement: !ruby/object:Gem::Requirement
@@ -106,42 +120,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '9.7'
+        version: '10.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '9.7'
+        version: '10.0'
 - !ruby/object:Gem::Dependency
   name: runcom
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '8.7'
+        version: '9.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '8.7'
+        version: '9.0'
 - !ruby/object:Gem::Dependency
   name: spek
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: zeitwerk
   requirement: !ruby/object:Gem::Requirement
@@ -186,14 +200,25 @@ files:
 - lib/git/lint/analyzers/commit_body_presence.rb
 - lib/git/lint/analyzers/commit_body_single_bullet.rb
 - lib/git/lint/analyzers/commit_body_tracker_shorthand.rb
+- lib/git/lint/analyzers/commit_signature.rb
 - lib/git/lint/analyzers/commit_subject_length.rb
 - lib/git/lint/analyzers/commit_subject_prefix.rb
 - lib/git/lint/analyzers/commit_subject_suffix.rb
 - lib/git/lint/analyzers/commit_trailer_collaborator_capitalization.rb
-- lib/git/lint/analyzers/commit_trailer_collaborator_duplication.rb
 - lib/git/lint/analyzers/commit_trailer_collaborator_email.rb
 - lib/git/lint/analyzers/commit_trailer_collaborator_key.rb
 - lib/git/lint/analyzers/commit_trailer_collaborator_name.rb
+- lib/git/lint/analyzers/commit_trailer_duplicate.rb
+- lib/git/lint/analyzers/commit_trailer_format_key.rb
+- lib/git/lint/analyzers/commit_trailer_format_value.rb
+- lib/git/lint/analyzers/commit_trailer_issue_key.rb
+- lib/git/lint/analyzers/commit_trailer_issue_value.rb
+- lib/git/lint/analyzers/commit_trailer_signer_capitalization.rb
+- lib/git/lint/analyzers/commit_trailer_signer_email.rb
+- lib/git/lint/analyzers/commit_trailer_signer_key.rb
+- lib/git/lint/analyzers/commit_trailer_signer_name.rb
+- lib/git/lint/analyzers/commit_trailer_tracker_key.rb
+- lib/git/lint/analyzers/commit_trailer_tracker_value.rb
 - lib/git/lint/cli/actions/analyze/branch.rb
 - lib/git/lint/cli/actions/analyze/commit.rb
 - lib/git/lint/cli/actions/config.rb
@@ -222,9 +247,7 @@ files:
 - lib/git/lint/errors/sha.rb
 - lib/git/lint/import.rb
 - lib/git/lint/kit/filter_list.rb
-- lib/git/lint/parsers/trailers/collaborator.rb
-- lib/git/lint/rake/setup.rb
-- lib/git/lint/rake/tasks.rb
+- lib/git/lint/rake/register.rb
 - lib/git/lint/reporters/branch.rb
 - lib/git/lint/reporters/commit.rb
 - lib/git/lint/reporters/line.rb
@@ -253,14 +276,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - "~>"
     - !ruby/object:Gem::Version
-      version: '3.1'
+      version: '3.2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.24
+rubygems_version: 3.4.1
 signing_key:
 specification_version: 4
 summary: A command line interface for linting Git commits.

data/lib/git/lint/analyzers/commit_trailer_collaborator_duplication.rb

@@ -1,46 +0,0 @@
-# frozen_string_literal: true
-
-module Git
-  module Lint
-    module Analyzers
-      # Analyzes commit trailer collaborator duplication.
-      class CommitTrailerCollaboratorDuplication < Abstract
-        def initialize commit, parser: Parsers::Trailers::Collaborator, **dependencies
-          super commit, **dependencies
-          @parser = parser
-          @tally = build_tally
-        end
-
-        def valid? = affected_commit_trailers.empty?
-
-        def issue
-          return {} if valid?
-
-          {
-            hint: "Avoid duplication.",
-            lines: affected_commit_trailers
-          }
-        end
-
-        protected
-
-        def invalid_line? line
-          collaborator = parser.new line
-          collaborator.match? && tally[line] != 1
-        end
-
-        private
-
-        attr_reader :parser, :tally
-
-        def build_tally
-          zeros = Hash.new { |new_hash, missing_key| new_hash[missing_key] = 0 }
-
-          zeros.tap do |collection|
-            commit.trailers.each { |line| collection[line] += 1 if parser.new(line).match? }
-          end
-        end
-      end
-    end
-  end
-end

data/lib/git/lint/parsers/trailers/collaborator.rb

@@ -1,50 +0,0 @@
-# frozen_string_literal: true
-
-module Git
-  module Lint
-    module Parsers
-      module Trailers
-        # Parses collaborator information within a commit trailer.
-        class Collaborator
-          DEFAULT_KEY_PATTERN = /\ACo.*Authored.*By.*\Z/i
-
-          DEFAULT_MATCH_PATTERN = /
-            (?<key>\A.+)         # Key (anchored to start of line).
-            (?<delimiter>:)      # Key delimiter.
-            (?<key_space>\s?)    # Space delimiter (optional).
-            (?<name>.*?)         # Collaborator name (smallest possible).
-            (?<name_space>\s?)   # Space delimiter (optional).
-            (?<email><.+>)?      # Collaborator email (optional).
-            \Z                   # End of line.
-          /x
-
-          def initialize text,
-                         key_pattern: DEFAULT_KEY_PATTERN,
-                         match_pattern: DEFAULT_MATCH_PATTERN
-
-            @text = String text
-            @key_pattern = key_pattern
-            @match_pattern = match_pattern
-            @matches = build_matches
-          end
-
-          def key = String(matches["key"])
-
-          def name = String(matches["name"])
-
-          def email = String(matches["email"]).delete_prefix("<").delete_suffix(">")
-
-          def match? = text.match?(key_pattern)
-
-          private
-
-          attr_reader :text, :key_pattern, :match_pattern, :matches
-
-          def build_matches
-            text.match(match_pattern).then { |data| data ? data.named_captures : Hash.new }
-          end
-        end
-      end
-    end
-  end
-end

data/lib/git/lint/rake/setup.rb

@@ -1,4 +0,0 @@
-# frozen_string_literal: true
-
-require "git/lint/rake/tasks"
-Git::Lint::Rake::Tasks.setup