git-lint 4.6.0 → 5.0.0

data/lib/git/lint/analyzers/commit_trailer_collaborator_email.rb

@@ -5,16 +5,12 @@ module Git
     module Analyzers
       # Analyzes commit trailer collaborator email address format.
       class CommitTrailerCollaboratorEmail < Abstract
-        # rubocop:disable Metrics/ParameterLists
-        def initialize commit,
-                       parser: Parsers::Trailers::Collaborator,
-                       validator: Validators::Email,
-                       **dependencies
-          super commit, **dependencies
-          @parser = parser
-          @validator = validator
-        end
-        # rubocop:enable Metrics/ParameterLists
+        include Import[
+          pattern: "trailers.collaborator",
+          parser: "parsers.person",
+          sanitizer: "sanitizers.email",
+          validator: "validators.email"
+        ]
 
         def valid? = affected_commit_trailers.empty?
 
@@ -29,9 +25,9 @@ module Git
 
         protected
 
-        def invalid_line? line
-          collaborator = parser.new line
-          collaborator.match? && !validator.new(collaborator.email).valid?
+        def invalid_line? trailer
+          email = sanitizer.call parser.call(trailer.value).email
+          trailer.key.match?(pattern) && !validator.call(email)
         end
 
         private

data/lib/git/lint/analyzers/commit_trailer_collaborator_key.rb

@@ -5,10 +5,7 @@ module Git
     module Analyzers
       # Analyzes commit trailer collaborator key usage.
       class CommitTrailerCollaboratorKey < Abstract
-        def initialize commit, parser: Parsers::Trailers::Collaborator, **dependencies
-          super commit, **dependencies
-          @parser = parser
-        end
+        include Import[pattern: "trailers.collaborator"]
 
         def valid? = affected_commit_trailers.empty?
 
@@ -25,18 +22,11 @@ module Git
 
         def load_filter_list = Kit::FilterList.new(settings.includes)
 
-        def invalid_line? line
-          collaborator = parser.new line
-          key = collaborator.key
-
-          collaborator.match? && !key.empty? && !key.match?(
-            /\A#{Regexp.union filter_list.to_regexp}\Z/
-          )
+        def invalid_line? trailer
+          trailer.key.then do |key|
+            key.match?(pattern) && !key.match?(/\A#{Regexp.union filter_list.to_regexp}\Z/)
+          end
         end
-
-        private
-
-        attr_reader :parser
       end
     end
   end

data/lib/git/lint/analyzers/commit_trailer_collaborator_name.rb

@@ -5,16 +5,11 @@ module Git
     module Analyzers
       # Analyzes commit trailer collaborator name construction.
       class CommitTrailerCollaboratorName < Abstract
-        # rubocop:disable Metrics/ParameterLists
-        def initialize commit,
-                       parser: Parsers::Trailers::Collaborator,
-                       validator: Validators::Name,
-                       **dependencies
-          super commit, **dependencies
-          @parser = parser
-          @validator = validator
-        end
-        # rubocop:enable Metrics/ParameterLists
+        include Import[
+          pattern: "trailers.collaborator",
+          parser: "parsers.person",
+          validator: "validators.name"
+        ]
 
         def valid? = affected_commit_trailers.empty?
 
@@ -29,15 +24,14 @@ module Git
 
         protected
 
-        def invalid_line? line
-          collaborator = parser.new line
-          collaborator.match? && !validator.new(collaborator.name.strip, minimum:).valid?
+        def invalid_line? trailer
+          parser.call(trailer.value).then do |person|
+            trailer.key.match?(pattern) && !validator.call(person.name, minimum:)
+          end
         end
 
         private
 
-        attr_reader :parser, :validator
-
         def minimum = settings.minimum
       end
     end

data/lib/git/lint/analyzers/commit_trailer_duplicate.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+module Git
+  module Lint
+    module Analyzers
+      # Analyzes commit trailer duplicate.
+      class CommitTrailerDuplicate < Abstract
+        def valid? = affected_commit_trailers.empty?
+
+        def issue
+          return {} if valid?
+
+          {
+            hint: "Avoid duplicates.",
+            lines: affected_commit_trailers
+          }
+        end
+
+        protected
+
+        def invalid_line?(trailer) = commit.trailers.tally[trailer] != 1
+      end
+    end
+  end
+end

data/lib/git/lint/analyzers/commit_trailer_format_key.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+module Git
+  module Lint
+    module Analyzers
+      # Analyzes commit trailer format key usage.
+      class CommitTrailerFormatKey < Abstract
+        include Import[pattern: "trailers.format"]
+
+        def valid? = affected_commit_trailers.empty?
+
+        def issue
+          return {} if valid?
+
+          {
+            hint: "Use format: #{filter_list.to_hint}.",
+            lines: affected_commit_trailers
+          }
+        end
+
+        protected
+
+        def load_filter_list = Kit::FilterList.new(settings.includes)
+
+        def invalid_line? trailer
+          trailer.key.then do |key|
+            key.match?(pattern) && !key.match?(/\A#{Regexp.union filter_list.to_regexp}\Z/)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/git/lint/analyzers/commit_trailer_format_value.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+module Git
+  module Lint
+    module Analyzers
+      # Analyzes commit trailer format value.
+      class CommitTrailerFormatValue < Abstract
+        include Import[pattern: "trailers.format"]
+
+        def valid? = affected_commit_trailers.empty?
+
+        def issue
+          return {} if valid?
+
+          {
+            hint: "Use format: #{filter_list.to_hint}.",
+            lines: affected_commit_trailers
+          }
+        end
+
+        protected
+
+        def load_filter_list = Kit::FilterList.new(settings.includes)
+
+        def invalid_line? trailer
+          trailer.key.match?(pattern) && !trailer.value.match?(value_pattern)
+        end
+
+        def value_pattern = /\A#{Regexp.union filter_list.to_regexp}\Z/
+      end
+    end
+  end
+end

data/lib/git/lint/analyzers/commit_trailer_issue_key.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+module Git
+  module Lint
+    module Analyzers
+      # Analyzes commit trailer issue key usage.
+      class CommitTrailerIssueKey < Abstract
+        include Import[pattern: "trailers.issue"]
+
+        def valid? = affected_commit_trailers.empty?
+
+        def issue
+          return {} if valid?
+
+          {
+            hint: "Use format: #{filter_list.to_hint}.",
+            lines: affected_commit_trailers
+          }
+        end
+
+        protected
+
+        def load_filter_list = Kit::FilterList.new(settings.includes)
+
+        def invalid_line? trailer
+          trailer.key.then do |key|
+            key.match?(pattern) && !key.match?(/\A#{Regexp.union filter_list.to_regexp}\Z/)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/git/lint/analyzers/commit_trailer_issue_value.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+module Git
+  module Lint
+    module Analyzers
+      # Analyzes commit trailer issue value.
+      class CommitTrailerIssueValue < Abstract
+        include Import[pattern: "trailers.issue"]
+
+        def valid? = affected_commit_trailers.empty?
+
+        def issue
+          return {} if valid?
+
+          {
+            hint: "Use format: #{filter_list.to_hint}.",
+            lines: affected_commit_trailers
+          }
+        end
+
+        protected
+
+        def load_filter_list = Kit::FilterList.new(settings.includes)
+
+        def invalid_line? trailer
+          trailer.key.match?(pattern) && !trailer.value.match?(value_pattern)
+        end
+
+        def value_pattern = /\A#{Regexp.union filter_list.to_regexp}\Z/
+      end
+    end
+  end
+end

data/lib/git/lint/analyzers/commit_trailer_signer_capitalization.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+module Git
+  module Lint
+    module Analyzers
+      # Analyzes commit trailer signer name capitalization.
+      class CommitTrailerSignerCapitalization < Abstract
+        include Import[
+          pattern: "trailers.signer",
+          parser: "parsers.person",
+          validator: "validators.capitalization"
+        ]
+
+        def valid? = affected_commit_trailers.empty?
+
+        def issue
+          return {} if valid?
+
+          {
+            hint: "Name must be capitalized.",
+            lines: affected_commit_trailers
+          }
+        end
+
+        protected
+
+        def invalid_line? trailer
+          parser.call(trailer.value).then do |person|
+            trailer.key.match?(pattern) && !validator.call(person.name)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/git/lint/analyzers/commit_trailer_signer_email.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+module Git
+  module Lint
+    module Analyzers
+      # Analyzes commit trailer signer email address format.
+      class CommitTrailerSignerEmail < Abstract
+        include Import[
+          pattern: "trailers.signer",
+          parser: "parsers.person",
+          sanitizer: "sanitizers.email",
+          validator: "validators.email"
+        ]
+
+        def valid? = affected_commit_trailers.empty?
+
+        def issue
+          return {} if valid?
+
+          {
+            hint: %(Email must follow name and use format: "<name@server.domain>".),
+            lines: affected_commit_trailers
+          }
+        end
+
+        protected
+
+        def invalid_line? trailer
+          email = sanitizer.call parser.call(trailer.value).email
+          trailer.key.match?(pattern) && !validator.call(email)
+        end
+
+        private
+
+        attr_reader :parser, :validator
+      end
+    end
+  end
+end

data/lib/git/lint/analyzers/commit_trailer_signer_key.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+module Git
+  module Lint
+    module Analyzers
+      # Analyzes commit trailer signer key usage.
+      class CommitTrailerSignerKey < Abstract
+        include Import[pattern: "trailers.signer"]
+
+        def valid? = affected_commit_trailers.empty?
+
+        def issue
+          return {} if valid?
+
+          {
+            hint: "Use format: #{filter_list.to_hint}.",
+            lines: affected_commit_trailers
+          }
+        end
+
+        protected
+
+        def load_filter_list = Kit::FilterList.new(settings.includes)
+
+        def invalid_line? trailer
+          trailer.key.then do |key|
+            key.match?(pattern) && !key.match?(/\A#{Regexp.union filter_list.to_regexp}\Z/)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/git/lint/analyzers/commit_trailer_signer_name.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+module Git
+  module Lint
+    module Analyzers
+      # Analyzes commit trailer signer name construction.
+      class CommitTrailerSignerName < Abstract
+        include Import[
+          pattern: "trailers.signer",
+          parser: "parsers.person",
+          validator: "validators.name"
+        ]
+
+        def valid? = affected_commit_trailers.empty?
+
+        def issue
+          return {} if valid?
+
+          {
+            hint: "Name must follow key and consist of #{minimum} parts (minimum).",
+            lines: affected_commit_trailers
+          }
+        end
+
+        protected
+
+        def invalid_line? trailer
+          parser.call(trailer.value).then do |person|
+            trailer.key.match?(pattern) && !validator.call(person.name, minimum:)
+          end
+        end
+
+        private
+
+        def minimum = settings.minimum
+      end
+    end
+  end
+end

data/lib/git/lint/analyzers/commit_trailer_tracker_key.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+module Git
+  module Lint
+    module Analyzers
+      # Analyzes commit trailer tracker key usage.
+      class CommitTrailerTrackerKey < Abstract
+        include Import[pattern: "trailers.tracker"]
+
+        def valid? = affected_commit_trailers.empty?
+
+        def issue
+          return {} if valid?
+
+          {
+            hint: "Use format: #{filter_list.to_hint}.",
+            lines: affected_commit_trailers
+          }
+        end
+
+        protected
+
+        def load_filter_list = Kit::FilterList.new(settings.includes)
+
+        def invalid_line? trailer
+          trailer.key.then do |key|
+            key.match?(pattern) && !key.match?(/\A#{Regexp.union filter_list.to_regexp}\Z/)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/git/lint/analyzers/commit_trailer_tracker_value.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+module Git
+  module Lint
+    module Analyzers
+      # Analyzes commit trailer tracker value.
+      class CommitTrailerTrackerValue < Abstract
+        include Import[pattern: "trailers.tracker"]
+
+        def valid? = affected_commit_trailers.empty?
+
+        def issue
+          return {} if valid?
+
+          {
+            hint: "Use format: #{filter_list.to_hint}.",
+            lines: affected_commit_trailers
+          }
+        end
+
+        protected
+
+        def load_filter_list = Kit::FilterList.new(settings.includes)
+
+        def invalid_line? trailer
+          trailer.key.match?(pattern) && !trailer.value.match?(value_pattern)
+        end
+
+        def value_pattern = /\A#{Regexp.union filter_list.to_regexp}\Z/
+      end
+    end
+  end
+end

data/lib/git/lint/cli/actions/analyze/branch.rb

@@ -7,7 +7,7 @@ module Git
         module Analyze
           # Handles analyze action for branch.
           class Branch
-            include Git::Lint::Import[:repository, :kernel, :logger]
+            include Git::Lint::Import[:kernel, :logger]
 
             def initialize analyzer: Analyzer.new, **dependencies
               super(**dependencies)

data/lib/git/lint/cli/actions/analyze/commit.rb

@@ -5,20 +5,17 @@ module Git
     module CLI
       module Actions
         module Analyze
-          # Handles analyze action for commit(s) by SHA.
+          # Handles analyze action for single commit SHA
           class Commit
-            include Git::Lint::Import[:kernel, :logger]
+            include Git::Lint::Import[:git, :kernel, :logger]
 
-            def initialize analyzer: Analyzer.new,
-                           parser: GitPlus::Parsers::Commits::Saved::History.with_show,
-                           **dependencies
+            def initialize analyzer: Analyzer.new, **dependencies
               super(**dependencies)
               @analyzer = analyzer
-              @parser = parser
             end
 
-            def call sha = nil
-              process sha
+            def call *arguments
+              process arguments.unshift "-1"
             rescue Errors::Base => error
               logger.error { error.message }
               kernel.abort
@@ -26,10 +23,10 @@ module Git
 
             private
 
-            attr_reader :analyzer, :parser
+            attr_reader :analyzer
 
-            def process sha
-              analyzer.call commits: parser.call(*sha) do |collector, reporter|
+            def process arguments
+              analyzer.call commits: git.commits(*arguments) do |collector, reporter|
                 kernel.puts reporter
                 kernel.abort if collector.errors?
               end

data/lib/git/lint/cli/actions/hook.rb

@@ -6,7 +6,7 @@ module Git
       module Actions
         # Handles unsaved Git commit action.
         class Hook
-          include Git::Lint::Import[:repository, :kernel, :logger]
+          include Git::Lint::Import[:git, :kernel, :logger]
 
           def initialize analyzer: Analyzer.new, **dependencies
             super(**dependencies)
@@ -14,7 +14,7 @@ module Git
           end
 
           def call path
-            analyzer.call commits: [repository.unsaved(path)] do |collector, reporter|
+            analyzer.call commits: commits(path) do |collector, reporter|
               kernel.puts reporter
               kernel.abort if collector.errors?
             end
@@ -23,6 +23,8 @@ module Git
           private
 
           attr_reader :analyzer
+
+          def commits(path) = git.uncommitted(path).fmap { |commit| [commit] }
         end
       end
     end

data/lib/git/lint/commits/loader.rb

@@ -9,10 +9,10 @@ module Git
       class Loader
         include Systems::Import[
           :circle_ci,
+          :git,
           :git_hub_action,
           :netlify_ci,
           :local,
-          :repository,
           :environment
         ]
 
@@ -20,7 +20,7 @@ module Git
 
         def call
           message = "Invalid repository. Are you within a Git repository?"
-          fail Errors::Base, message unless repository.exist?
+          fail Errors::Base, message unless git.exist?
 
           load_system.call
         end

data/lib/git/lint/commits/systems/circle_ci.rb

@@ -6,13 +6,15 @@ module Git
       module Systems
         # Provides Circle CI build environment feature branch information.
         class CircleCI
-          include Git::Lint::Import[:repository]
+          include Git::Lint::Import[:git]
 
-          def call = repository.commits("origin/#{repository.branch_default}..#{name}")
+          def call = git.commits("origin/#{branch_default}..#{branch_name}")
 
           private
 
-          def name = "origin/#{repository.branch_name}"
+          def branch_default = git.branch_default.value_or nil
+
+          def branch_name = "origin/#{git.branch_name.value_or nil}"
         end
       end
     end

data/lib/git/lint/commits/systems/git_hub_action.rb

@@ -6,13 +6,15 @@ module Git
       module Systems
         # Provides GitHub Action build environment feature branch information.
         class GitHubAction
-          include Git::Lint::Import[:repository]
+          include Git::Lint::Import[:git]
 
-          def call = repository.commits("origin/#{repository.branch_default}..#{name}")
+          def call = git.commits("origin/#{branch_default}..#{branch_name}")
 
           private
 
-          def name = "origin/#{repository.branch_name}"
+          def branch_default = git.branch_default.value_or nil
+
+          def branch_name = "origin/#{git.branch_name.value_or nil}"
         end
       end
     end

data/lib/git/lint/commits/systems/local.rb

@@ -6,13 +6,15 @@ module Git
       module Systems
         # Provides local build environment feature branch information.
         class Local
-          include Git::Lint::Import[:repository]
+          include Git::Lint::Import[:git]
 
-          def call = repository.commits("#{repository.branch_default}..#{name}")
+          def call = git.commits("#{branch_default}..#{branch_name}")
 
           private
 
-          def name = repository.branch_name
+          def branch_default = git.branch_default.value_or nil
+
+          def branch_name = git.branch_name.value_or nil
         end
       end
     end