geoblacklight 2.3.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA256:
+  metadata.gz: f61832ee1c73971aba39a0274862bfcb02da7bb159e3b442ae4d510a617a6fd8
+  data.tar.gz: 21611d0326e071ac549f546668f474b9889eef2611f3a58976efe18b82401d24
+SHA512:
+  metadata.gz: 9c053aa4af51bbf0a1ed10e34b4937cc66d4659296eada0dec44a2a69e087d5391d23de1a31593abed3b06ea71cc028c167cb454f8063c4dc73f99fb20155a01
+  data.tar.gz: 29afb9d926d461f10fde92c864511e83ccaf6a1bdc505c0cfe1144c6981c0ee2e312db1576731599000cb917104a9613aadc564e7093591fefa4e96f270c3ecb

data/.circleci/config.yml

@@ -0,0 +1,195 @@
+---
+version: 2.1
+jobs:
+  build:
+    working_directory: ~/geoblacklight
+    parameters:
+      ruby_version:
+        type: string
+        default: '2.5.7'
+      solr_port:
+        type: string
+        default: '8983'
+      rails_version:
+        type: string
+        default: '5.1.7'
+    docker:
+      - image: circleci/ruby:<< parameters.ruby_version >>-node-browsers-legacy
+      - image: solr:7-alpine
+        command: bin/solr -cloud -noprompt -f -p <<parameters.solr_port>>
+    environment:
+      GEM_HOME: /home/circleci/geoblacklight/vendor/bundle
+      BUNDLE_PATH: /home/circleci/geoblacklight/vendor/bundle
+      BUNDLE_JOBS: 4
+      BUNDLE_RETRY: 3
+      RAILS_ENV: test
+      RACK_ENV: test
+      RAILS_VERSION: <<parameters.rails_version>>
+      COVERAGE: true
+    parallelism: 4
+    steps:
+      - checkout
+      # Update chrome
+      - run: wget -q -O - https://dl.google.com/linux/linux_signing_key.pub | sudo apt-key add -
+      - run: sudo sh -c 'echo "deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google.list'
+      - run: sudo apt-get update
+      - run: sudo apt-get -y install google-chrome-stable
+      # Restore bundle and internal test app from the cache
+      - restore_cache:
+          keys:
+            - geoblacklight-bundle-{{ checksum "geoblacklight.gemspec" }}-{{ checksum "Gemfile" }}-<< parameters.ruby_version >>-<< parameters.rails_version >>
+      # Install gems
+      - run: bundle check || bundle install
+      # Store bundle cache
+      - save_cache:
+          key: geoblacklight-bundle-{{ checksum "geoblacklight.gemspec" }}-{{ checksum "Gemfile" }}-<< parameters.ruby_version >>-<< parameters.rails_version >>
+          paths:
+            - /home/circleci/geoblacklight/vendor/bundle
+        # Restore internal test app from the cache
+      - restore_cache:
+          keys:
+            - geoblacklight-internal-test-app-{{ checksum "geoblacklight.gemspec" }}-{{ checksum "Gemfile" }}-{{ checksum "spec/test_app_templates/Gemfile.extra" }}-<< parameters.ruby_version >>-<< parameters.rails_version >>
+      # Generate the internal test app
+      - run:
+          name: Generate test app
+          command: |
+            [ -e ./.internal_test_app ] || bundle exec rake engine_cart:generate
+      - save_cache:
+          name: Save test app cache
+          key: geoblacklight-internal-test-app-{{ checksum "geoblacklight.gemspec" }}-{{ checksum "Gemfile" }}-{{ checksum "spec/test_app_templates/Gemfile.extra" }}-<< parameters.ruby_version >>-<< parameters.rails_version >>
+          paths:
+            - ./.internal_test_app
+      - run:
+          name: Wait for Solr
+          command: dockerize -wait tcp://localhost:<<parameters.solr_port>> -timeout 1m
+      - run:
+          name: Load config into solr
+          command: |
+            cd .internal_test_app/solr/conf
+            zip -1 -r solr_config.zip ./*
+            curl -H "Content-type:application/octet-stream" --data-binary @solr_config.zip "http://localhost:8983/solr/admin/configs?action=UPLOAD&name=solrconfig"
+            curl -H 'Content-type: application/json' http://localhost:<<parameters.solr_port>>/api/collections/ -d '{create: {name: blacklight-core, config: solrconfig, numShards: 1}}'
+      - run:
+          name: Seed Solr
+          command: |
+            cd .internal_test_app
+            bundle check || bundle install
+            bundle exec rake geoblacklight:index:seed
+            bundle exec rake geoblacklight:downloads:mkdir
+      - run:
+          name: Compile the assets for Webpack
+          command: |
+            cd .internal_test_app
+            rm config/webpacker.yml
+            bundle exec rails webpacker:install
+            bundle exec rails webpacker:compile
+      - run:
+          name: Run the RSpec test suites
+          command: bundle exec rspec $(circleci tests glob "spec/**/*_spec.rb" | circleci tests split --split-by=timings)
+      - run:
+          name: Run the Teaspoon test suites
+          command: bundle exec rake teaspoon
+
+  rubocop:
+    working_directory: ~/geoblacklight
+    parameters:
+      ruby_version:
+        type: string
+        default: '2.5.7'
+      rails_version:
+        type: string
+        default: '5.1.7'
+    docker:
+      - image: circleci/ruby:<< parameters.ruby_version >>-node-browsers-legacy
+    environment:
+      GEM_HOME: /home/circleci/geoblacklight/vendor/bundle
+      BUNDLE_PATH: /home/circleci/geoblacklight/vendor/bundle
+      BUNDLE_JOBS: 4
+      BUNDLE_RETRY: 3
+      RAILS_ENV: test
+      RACK_ENV: test
+      RAILS_VERSION: <<parameters.rails_version>>
+    steps:
+      - checkout
+      # Restore bundle cache
+      - restore_cache:
+          keys:
+            - geoblacklight-bundle-{{ checksum "geoblacklight.gemspec" }}-{{ checksum "Gemfile" }}-<< parameters.ruby_version >>-<< parameters.rails_version >>
+          paths:
+            - /home/circleci/geoblacklight/vendor/bundle
+      # Install gems and run rubocop
+      - run: bundle check || bundle install
+      - run: bundle exec rake rubocop
+
+workflows:
+  version: 2
+  build:
+    jobs:
+      - build:
+          ruby_version: 2.6.5
+          rails_version: 5.2.4.1
+          name: "ruby2-6_rails5-2"
+      - build:
+          ruby_version: 2.5.7
+          rails_version: 5.2.4.1
+          name: "ruby2-5_rails5-2"
+      - rubocop:
+          ruby_version: 2.6.5
+          rails_version: 5.2.4.1
+          name: "rubocop_ruby2-6_rails5-2"
+      - rubocop:
+          ruby_version: 2.5.7
+          rails_version: 5.2.4.1
+          name: "rubocop_ruby2-5_rails5-2"
+
+      - build:
+          ruby_version: 2.6.5
+          name: "ruby2-6_rails5-1"
+      - build:
+          ruby_version: 2.5.7
+          name: "ruby2-5_rails5-1"
+      - rubocop:
+          ruby_version: 2.6.5
+          name: "rubocop_ruby2-6_rails5-1"
+      - rubocop:
+          ruby_version: 2.5.7
+          name: "rubocop_ruby2-5_rails5-1"
+
+  nightly:
+    triggers:
+      - schedule:
+          cron: "0 0 * * *"
+          filters:
+            branches:
+              only:
+                - master
+    jobs:
+      - build:
+          ruby_version: 2.6.5
+          rails_version: 5.2.4.1
+          name: "ruby2-6_rails5-2"
+      - build:
+          ruby_version: 2.5.7
+          rails_version: 5.2.4.1
+          name: "ruby2-5_rails5-2"
+      - rubocop:
+          ruby_version: 2.6.5
+          rails_version: 5.2.4.1
+          name: "rubocop_ruby2-6_rails5-2"
+      - rubocop:
+          ruby_version: 2.5.7
+          rails_version: 5.2.4.1
+          name: "rubocop_ruby2-5_rails5-2"
+
+      - build:
+          ruby_version: 2.6.5
+          name: "ruby2-6_rails5-1"
+      - build:
+          ruby_version: 2.5.7
+          name: "ruby2-5_rails5-1"
+      - rubocop:
+          ruby_version: 2.6.5
+          name: "rubocop_ruby2-6_rails5-1"
+      - rubocop:
+          ruby_version: 2.5.7
+          name: "rubocop_ruby2-5_rails5-1"

data/.github/ISSUE_TEMPLATE.md

@@ -0,0 +1,17 @@
+### Descriptive summary
+
+Include what version of GeoBlacklight related to this issue (1.3.0, master, etc.) if appropriate, and any relevant tracebacks if you're reporting a bug.
+
+### Expected behavior
+
+### Actual behavior
+
+### Steps to reproduce the behavior
+
+1. Do this
+1. Then do this...
+
+### Related work
+
+Link to related tickets or prior related work here.
+

data/.gitignore

@@ -0,0 +1,21 @@
+*.gem
+*.rbc
+.bundle
+.config
+.yardoc
+Gemfile.lock
+InstalledFiles
+_yardoc
+coverage
+doc/
+lib/bundler/man
+pkg
+rdoc
+spec/reports
+test/tmp
+test/version_tmp
+tmp
+jetty
+.internal_test_app
+# Ignore byebug history
+.byebug_history

data/.hound.yml

@@ -0,0 +1,8 @@
+javascript:
+  config_file: .jshintrc
+  ignore_file: .jshintignore
+scss:
+  exclude:
+    - 'vendor/assets/stylesheets/**'
+ruby:
+  config_file: .rubocop.yml

data/.jshintignore

@@ -0,0 +1,2 @@
+vendor/*
+app/assets/javascripts/vendor/*

data/.jshintrc

@@ -0,0 +1,67 @@
+{
+  /*
+   * ENVIRONMENTS
+   * =================
+   */
+
+  // Define globals exposed by modern browsers.
+  "browser": true,
+
+  // Define globals exposed by jQuery.
+  "jquery": true,
+
+  // Define globals exposed by Node.js.
+  "node": true,
+
+  // Allow ES6.
+  "esnext": true,
+
+  /*
+   * ENFORCING OPTIONS
+   * =================
+   */
+
+  // Force all variable names to use either camelCase style or UPPER_CASE
+  // with underscores.
+  "camelcase": true,
+
+  // Prohibit use of == and != in favor of === and !==.
+  "eqeqeq": true,
+
+  // Enforce tab width of 2 spaces.
+  "indent": 2,
+
+  // Prohibit use of a variable before it is defined.
+  "latedef": true,
+
+  // Enforce line length to 80 characters
+  "maxlen": 80,
+
+  // Require capitalized names for constructor functions.
+  "newcap": true,
+
+  // Enforce use of single quotation marks for strings.
+  "quotmark": "single",
+
+  // Enforce placing 'use strict' at the top function scope
+  "strict": true,
+
+  // Prohibit use of explicitly undeclared variables.
+  "undef": true,
+
+  // Warn when variables are defined but never used.
+  "unused": true,
+
+  /*
+   * RELAXING OPTIONS
+   * =================
+   */
+
+  // Suppress warnings about == null comparisons.
+  "eqnull": true,
+
+  // Custom predefined js stuff
+  "predef": [
+    "expect", "describe", "it", "xit", "spyOn", "fixture", "beforeEach", "afterEach", "L", "jasmine", "TestResponses"
+  ]
+}

data/.rubocop.yml

@@ -0,0 +1,99 @@
+require: rubocop-rspec
+
+inherit_gem:
+  bixby: bixby_default.yml
+
+inherit_from: .rubocop_todo.yml
+
+Rails:
+  Enabled: true
+
+AllCops:
+  TargetRubyVersion: 2.3
+  DisplayCopNames: true
+  Include:
+  - '**/Rakefile'
+  Exclude:
+  - 'db/**/*'
+  - 'vendor/**/*'
+  - '.internal_test_app/**/*'
+  - 'lib/generators/geoblacklight/templates/**/*'
+  - 'geoblacklight.gemspec'
+  - 'Gemfile'
+
+Layout/DotPosition:
+  Description: Checks the position of the dot in multi-line method calls.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#consistent-multi-line-chains
+  Enabled: true
+  EnforcedStyle: leading
+  SupportedStyles:
+  - leading
+  - trailing
+
+Metrics/BlockLength:
+  Exclude:
+  - 'spec/helpers/geoblacklight_helper_spec.rb'
+
+Metrics/LineLength:
+  Max: 115
+  Exclude:
+  - 'spec/**/*'
+  - 'Rakefile'
+  - 'lib/generators/geoblacklight/install_generator.rb'
+  - 'lib/tasks/geoblacklight.rake'
+  - 'app/models/concerns/geoblacklight/spatial_search_behavior.rb'
+
+Metrics/MethodLength:
+  Max: 16
+  Exclude:
+    - 'lib/geoblacklight/metadata/base.rb'
+
+Metrics/ModuleLength:
+  Exclude:
+  - 'app/helpers/geoblacklight_helper.rb'
+
+# TODO: Add top-level class and module documentation.
+Style/Documentation:
+  Enabled: false
+
+# Overrides method in blacklight. Must use method name.
+Naming/PredicateName:
+  Exclude:
+    - 'lib/geoblacklight/view_helper_override.rb'
+
+# geoblacklight references in solr_document_spec are
+# difficult to mock because of the use of 'method_missing'.
+# https://relishapp.com/rspec/rspec-mocks/docs/verifying-doubles/dynamic-classes
+RSpec/AnyInstance:
+  Exclude:
+    - 'spec/models/concerns/geoblacklight/solr_document_spec.rb'
+    - 'spec/helpers/geoblacklight_helper_spec.rb'
+    - 'spec/models/concerns/geoblacklight/solr_document/finder_spec.rb'
+    - 'spec/features/download_layer_spec.rb'
+
+# Rubocop bug causes view specs to fail.
+#  https://github.com/nevir/rubocop-rspec/issues/47
+RSpec/DescribeClass:
+  Enabled: false
+
+RSpec/ExampleLength:
+  Enabled: false
+
+RSpec/VerifiedDoubles:
+  Exclude:
+    - 'spec/lib/geoblacklight/download/hgl_download_spec.rb'
+    - 'spec/lib/geoblacklight/document_presenter_spec.rb'
+
+Style/SignalException:
+  EnforcedStyle: semantic
+
+Style/StringLiterals:
+  Description: Checks if uses of quotes match the configured preference.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#consistent-string-literals
+  Enabled: true
+  EnforcedStyle: single_quotes
+
+Style/SafeNavigation:
+  Exclude:
+    - 'app/models/concerns/geoblacklight/solr_document/arcgis.rb'
+    - 'app/models/concerns/geoblacklight/solr_document.rb'

data/.rubocop_todo.yml

@@ -0,0 +1,196 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2019-08-05 15:03:55 -0600 using RuboCop version 0.52.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 16
+# Cop supports --auto-correct.
+# Configuration parameters: Width, IgnoredPatterns.
+Layout/IndentationWidth:
+  Exclude:
+    - 'app/controllers/download_controller.rb'
+    - 'app/controllers/relation_controller.rb'
+    - 'app/controllers/wms_controller.rb'
+    - 'app/helpers/carto_helper.rb'
+    - 'app/models/concerns/geoblacklight/solr_document.rb'
+    - 'app/models/concerns/geoblacklight/solr_document/finder.rb'
+    - 'lib/geoblacklight/bounding_box.rb'
+    - 'lib/geoblacklight/download.rb'
+    - 'lib/geoblacklight/metadata/base.rb'
+    - 'lib/geoblacklight/metadata/fgdc.rb'
+    - 'lib/geoblacklight/metadata/iso19139.rb'
+    - 'lib/geoblacklight/metadata_transformer/base.rb'
+    - 'lib/geoblacklight/reference.rb'
+    - 'lib/geoblacklight/references.rb'
+    - 'lib/tasks/geoblacklight.rake'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AllowForAlignment.
+Layout/SpaceBeforeFirstArg:
+  Exclude:
+    - 'app/views/relation/index.json.jbuilder'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
+Lint/UnusedBlockArgument:
+  Exclude:
+    - 'lib/tasks/geoblacklight.rake'
+
+# Offense count: 47
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/BlockLength:
+  Max: 247
+
+# Offense count: 2
+# Configuration parameters: CustomIncludeMethods.
+RSpec/EmptyExampleGroup:
+  Exclude:
+    - 'spec/views/catalog/_document_split.html.erb_spec.rb'
+    - 'spec/views/catalog/_index_split.html.erb_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: implicit, each, example
+RSpec/HookArgument:
+  Exclude:
+    - 'spec/spec_helper.rb'
+
+# Offense count: 8
+RSpec/LeadingSubject:
+  Exclude:
+    - 'spec/lib/geoblacklight/document_presenter_spec.rb'
+    - 'spec/lib/geoblacklight/metadata_transformer/base_spec.rb'
+    - 'spec/lib/geoblacklight/metadata_transformer/fgdc_spec.rb'
+    - 'spec/lib/geoblacklight/metadata_transformer/iso19139_spec.rb'
+    - 'spec/lib/geoblacklight/metadata_transformer_spec.rb'
+
+# Offense count: 49
+# Configuration parameters: .
+# SupportedStyles: have_received, receive
+RSpec/MessageSpies:
+  EnforcedStyle: receive
+
+# Offense count: 28
+RSpec/NamedSubject:
+  Exclude:
+    - 'spec/lib/geoblacklight/metadata/base_spec.rb'
+    - 'spec/lib/geoblacklight/metadata_transformer/base_spec.rb'
+    - 'spec/lib/geoblacklight/metadata_transformer/fgdc_spec.rb'
+    - 'spec/lib/geoblacklight/metadata_transformer/iso19139_spec.rb'
+    - 'spec/lib/geoblacklight/metadata_transformer_spec.rb'
+    - 'spec/models/concerns/geoblacklight/solr_document/inspection_spec.rb'
+    - 'spec/models/concerns/geoblacklight/spatial_search_behavior_spec.rb'
+
+# Offense count: 6
+RSpec/RepeatedDescription:
+  Exclude:
+    - 'spec/features/esri_viewer_spec.rb'
+    - 'spec/features/search_results_map_spec.rb'
+    - 'spec/lib/geoblacklight/references_spec.rb'
+
+# Offense count: 2
+RSpec/RepeatedExample:
+  Exclude:
+    - 'spec/features/esri_viewer_spec.rb'
+
+# Offense count: 2
+RSpec/SubjectStub:
+  Exclude:
+    - 'spec/models/concerns/geoblacklight/spatial_search_behavior_spec.rb'
+
+# Offense count: 7
+Rails/FilePath:
+  Exclude:
+    - 'lib/geoblacklight/download.rb'
+    - 'lib/tasks/geoblacklight.rake'
+    - 'spec/lib/geoblacklight/download_spec.rb'
+    - 'spec/lib/geoblacklight/metadata_transformer/fgdc_spec.rb'
+    - 'spec/lib/geoblacklight/metadata_transformer/iso19139_spec.rb'
+
+# Offense count: 7
+Rails/OutputSafety:
+  Exclude:
+    - 'app/controllers/download_controller.rb'
+    - 'app/helpers/geoblacklight_helper.rb'
+    - 'lib/geoblacklight/view_helper_override.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/ColonMethodCall:
+  Exclude:
+    - 'lib/tasks/geoblacklight.rake'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
+# SupportedStyles: assign_to_condition, assign_inside_condition
+Style/ConditionalAssignment:
+  Exclude:
+    - 'app/controllers/download_controller.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/EmptyLiteral:
+  Exclude:
+    - 'spec/models/concerns/geoblacklight/spatial_search_behavior_spec.rb'
+
+# Offense count: 137
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: when_needed, always, never
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
+# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
+Style/HashSyntax:
+  Exclude:
+    - 'lib/tasks/geoblacklight.rake'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/MultilineIfModifier:
+  Exclude:
+    - 'app/helpers/geoblacklight_helper.rb'
+    - 'lib/geoblacklight/references.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, EnforcedStyle.
+# SupportedStyles: predicate, comparison
+Style/NumericPredicate:
+  Exclude:
+    - 'spec/**/*'
+    - 'lib/geoblacklight/relation/relation_response.rb'
+
+# Offense count: 10
+# Cop supports --auto-correct.
+# Configuration parameters: PreferredDelimiters.
+Style/PercentLiteralDelimiters:
+  Exclude:
+    - 'app/models/concerns/geoblacklight/solr_document/inspection.rb'
+    - 'spec/helpers/geoblacklight_helper_spec.rb'
+    - 'spec/lib/geoblacklight/document_presenter_spec.rb'
+    - 'spec/lib/geoblacklight/references_spec.rb'
+    - 'spec/lib/geoblacklight/wms_layer/feature_info_response_spec.rb'
+
+# Offense count: 6
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
+# SupportedStyles: single_quotes, double_quotes
+Style/StringLiterals:
+  Exclude:
+    - 'lib/tasks/geoblacklight.rake'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/UnneededInterpolation:
+  Exclude:
+    - 'lib/tasks/geoblacklight.rake'