geoblacklight 2.3.0

data/spec/controllers/catalog_controller_spec.rb

@@ -0,0 +1,82 @@
+require 'spec_helper'
+
+describe CatalogController, type: :controller do
+  describe '#web_services' do
+    it 'returns a document based off an id' do
+      get :web_services, params: { id: 'mit-f6rqs4ucovjk2' }
+      expect(response.status).to eq 200
+      expect(assigns(:documents)).not_to be_nil
+    end
+  end
+
+  describe '.default_solr_params' do
+    it 'sets the number of rows returned by Solr to 10 and does not filter the results' do
+      get :index
+      expect(response.status).to eq 200
+      expect(assigns(:response).docs).not_to be_empty
+      expect(assigns(:response).docs.length).to eq 10
+    end
+
+    it 'sets the starting document index to 0' do
+      get :index
+      expect(response.status).to eq 200
+      expect(assigns(:response).docs).not_to be_empty
+      expect(assigns(:response).docs.first.id).to eq 'stanford-cg357zz0321'
+    end
+
+    context 'with altered default parameters' do
+      let(:blacklight_config) { Blacklight::Configuration.new }
+
+      before do
+        allow(controller).to receive_messages blacklight_config: blacklight_config
+      end
+
+      it 'sets the starting document index' do
+        blacklight_config.default_solr_params = { start: 2, 'q.alt' => '*:*' }
+        get :index
+        expect(response.status).to eq 200
+        expect(assigns(:response).docs).not_to be_empty
+        expect(assigns(:response).docs.first.id).to eq 'mit-001145244'
+      end
+
+      it 'filters using a default DisMax query when no query is provided by the client' do
+        blacklight_config.default_solr_params = { start: 10, 'q.alt' => '{!dismax}id:nyu' }
+        get :index
+        expect(response.status).to eq 200
+        expect(assigns(:response).docs).to be_empty
+      end
+    end
+
+    context 'with altered per page parameters' do
+      let(:blacklight_config) { Blacklight::Configuration.new }
+
+      before do
+        allow(controller).to receive_messages blacklight_config: blacklight_config
+      end
+
+      it 'alters the number of documents returned from Solr' do
+        blacklight_config.default_per_page = 20
+        get :index
+        expect(response.status).to eq 200
+        expect(assigns(:response).docs).not_to be_empty
+        expect(assigns(:response).docs.length).to eq 20
+      end
+    end
+  end
+
+  describe '#raw' do
+    it 'returns a JSON representation of a Solr Document' do
+      get :raw, params: { id: 'tufts-cambridgegrid100-04' }
+      expect(response.status).to eq 200
+      expect(response.body).not_to be_empty
+      response_values = JSON.parse(response.body)
+      expect(response_values).to include 'geoblacklight_version' => '1.0'
+      expect(response_values).to include 'dc_title_s' => '100 Foot Grid Cambridge MA 2004'
+      expect(response_values).to include 'dc_identifier_s' => 'urn:geodata.tufts.edu:Tufts.CambridgeGrid100_04'
+      expect(response_values).to include 'dc_rights_s' => 'Public'
+      expect(response_values).to include 'dct_provenance_s' => 'Tufts'
+      expect(response_values).to include 'layer_slug_s' => 'tufts-cambridgegrid100-04'
+      expect(response_values).to include 'solr_geom' => 'ENVELOPE(-71.163984, -71.052581, 42.408316, 42.34757)'
+    end
+  end
+end

data/spec/controllers/download_controller_spec.rb

@@ -0,0 +1,120 @@
+require 'spec_helper'
+
+describe DownloadController, type: :controller do
+  describe '#file' do
+    describe 'restricted file' do
+      it 'redirects to login for authentication' do
+        get :file, params: { id: 'stanford-cg357zz0321-shapefile', format: 'zip' }
+        expect(response.status).to eq 401
+      end
+    end
+    describe 'public file' do
+      it 'initiates download' do
+        allow(controller).to receive(:render) # Needed for testing with Rails 4
+        expect(controller).to receive(:send_file)
+        get :file, params: { id: 'mit-f6rqs4ucovjk2-shapefile', format: 'zip' }
+      end
+    end
+  end
+  describe '#show' do
+    describe 'restricted file' do
+      it 'redirects to login for authentication' do
+        get :show, params: { id: 'stanford-cg357zz0321', format: 'json' }
+        expect(response.status).to eq 401
+      end
+    end
+    describe 'public file' do
+      let(:shapefile_download) { instance_double(Geoblacklight::ShapefileDownload) }
+
+      before do
+        allow(Geoblacklight::ShapefileDownload).to receive(:new).and_return(shapefile_download)
+      end
+
+      it 'initiates download creation' do
+        allow(shapefile_download).to receive(:get).and_return('success')
+        get :show, params: { id: 'mit-f6rqs4ucovjk2', type: 'shapefile' }
+        expect(response.status).to eq 200
+      end
+    end
+
+    context 'when requesting GeoJSON files' do
+      let(:id) { 'tufts-cambridgegrid100-04' }
+      let(:type) { 'geojson' }
+      let(:geojson_download) { instance_double(Geoblacklight::GeojsonDownload) }
+
+      before do
+        allow(geojson_download).to receive(:get).and_return('file.json')
+        allow(Geoblacklight::GeojsonDownload).to receive(:new).and_return(geojson_download)
+      end
+
+      it 'downloads the files and notifies the user' do
+        expect(Geoblacklight::GeojsonDownload).to receive(:new)
+        get :show, params: { id: id, type: type }
+
+        expect(response.body).to include 'success'
+        expect(response.body).to include 'Your file file.json is ready for download'
+      end
+    end
+
+    context 'when requesting GeoTIFF files' do
+      let(:id) { 'tufts-cambridgegrid100-04' }
+      let(:type) { 'geotiff' }
+      let(:geotiff_download) { instance_double(Geoblacklight::GeotiffDownload) }
+
+      before do
+        allow(geotiff_download).to receive(:get).and_return('file.tiff')
+        allow(Geoblacklight::GeotiffDownload).to receive(:new).and_return(geotiff_download)
+      end
+
+      it 'downloads the files and notifies the user' do
+        expect(Geoblacklight::GeotiffDownload).to receive(:new)
+        get :show, params: { id: id, type: type }
+
+        expect(response.body).to include 'success'
+        expect(response.body).to include 'Your file file.tiff is ready for download'
+      end
+    end
+  end
+
+  describe '#hgl' do
+    let(:hgl_download) { instance_double(Geoblacklight::HglDownload) }
+
+    it 'requests file' do
+      allow(hgl_download).to receive(:get).and_return('success')
+      allow(Geoblacklight::HglDownload).to receive(:new).and_return(hgl_download)
+
+      get :hgl, params: { id: 'harvard-g7064-s2-1834-k3', email: 'foo@example.com' }
+      expect(response.status).to eq 200
+    end
+
+    it 'renders form' do
+      allow(Geoblacklight::HglDownload).to receive(:new).and_return(hgl_download)
+
+      get :hgl, params: { id: 'harvard-g7064-s2-1834-k3' }
+      expect(response).to render_template('hgl')
+    end
+
+    context 'when an error occurs while downloading a file' do
+      let(:exception) { Geoblacklight::Exceptions::ExternalDownloadFailed.new(url: nil) }
+
+      it 'uses the default error message when the exception does not have a URL' do
+        allow(Geoblacklight::HglDownload).to receive(:new).and_raise(exception)
+
+        get :hgl, params: { id: 'harvard-g7064-s2-1834-k3', email: 'foo@example.com' }
+        expect(response.body).to include('danger')
+        expect(response.body).to include('Sorry, the requested file could not be downloaded')
+      end
+    end
+
+    context 'when downloading the requested file fails' do
+      it 'flashes the error message' do
+        allow(hgl_download).to receive(:get).and_return(nil)
+        allow(Geoblacklight::HglDownload).to receive(:new).and_return(hgl_download)
+
+        get :hgl, params: { id: 'harvard-g7064-s2-1834-k3', email: 'foo@example.com' }
+        expect(response.body).to include('danger')
+        expect(response.body).to include('Sorry, the requested file could not be downloaded')
+      end
+    end
+  end
+end

data/spec/controllers/relation_controller_spec.rb

@@ -0,0 +1,11 @@
+require 'spec_helper'
+
+describe RelationController, type: :controller do
+  describe '#index' do
+    it 'returns a listing of related documents for a record' do
+      get :index, params: { id: 'nyu_2451_34502' }
+      expect(response.status).to eq 200
+      expect(assigns(:relations)).not_to be_nil
+    end
+  end
+end

data/spec/controllers/wms_controller_spec.rb

@@ -0,0 +1,34 @@
+require 'spec_helper'
+
+describe WmsController, type: :controller do
+  let(:wms_layer) { instance_double('Geoblacklight::WmsLayer') }
+  let(:feature_info) { { values: ['fid', 'layer:example'] } }
+  let(:params) do
+    { format: 'json', 'URL' => 'http://www.example.com/', 'LAYERS' => 'layer:example',
+      'BBOX' => '-74, 40, -68, 43', 'WIDTH' => '500', 'HEIGHT' => '400',
+      'QUERY_LAYERS' => 'layer:example', 'X' => '277', 'Y' => '195' }
+  end
+
+  before do
+    allow(Geoblacklight::WmsLayer).to receive(:new).and_return(wms_layer)
+    allow(wms_layer).to receive(:feature_info).and_return(feature_info)
+  end
+
+  describe '#handle' do
+    it 'returns feature info as json' do
+      get :handle, params: params
+      expect(response.body).to eq(feature_info.to_json)
+    end
+  end
+
+  describe '#wms_params' do
+    let(:wms_params) { controller.instance_eval { wms_params } }
+
+    it 'returns only permitted params' do
+      get :handle, params: params
+      expect(wms_params.to_h).not_to eq(params)
+      params.delete(:format)
+      expect(wms_params.to_h).to eq(params)
+    end
+  end
+end

data/spec/factories/user.rb

@@ -0,0 +1,7 @@
+FactoryBot.define do
+  factory :user do
+    sequence(:email) { |n| "user#{n}@example.com" }
+    password { 'password' }
+    password_confirmation { 'password' }
+  end
+end

data/spec/features/bookmarks_spec.rb

@@ -0,0 +1,10 @@
+require 'spec_helper'
+
+feature 'Blacklight Bookmarks' do
+  scenario 'index has created bookmarks' do
+    visit solr_document_path 'nyu-2451-34564'
+    click_button 'Bookmark'
+    visit bookmarks_path
+    expect(page).to have_css '.document', count: 1
+  end
+end

data/spec/features/configurable_basemap_spec.rb

@@ -0,0 +1,35 @@
+require 'spec_helper'
+
+feature 'Configurable basemap', js: true do
+  scenario 'defaults to positron' do
+    visit root_path
+    expect(page).to have_css "img[src*='carto']"
+  end
+  feature 'without provided basemap config' do
+    before do
+      CatalogController.blacklight_config.basemap_provider = nil
+    end
+    scenario 'has Carto map' do
+      visit root_path
+      expect(page).to have_css "img[src*='carto']"
+    end
+  end
+  feature 'using darkMatter' do
+    before do
+      CatalogController.blacklight_config.basemap_provider = 'darkMatter'
+    end
+    scenario 'has darkMatter map' do
+      visit root_path
+      expect(page).to have_css "img[src*='dark_all']"
+    end
+  end
+  feature 'using openstreetmapHot' do
+    before do
+      CatalogController.blacklight_config.basemap_provider = 'openstreetmapHot'
+    end
+    scenario 'has openstreetmapHot map' do
+      visit root_path
+      expect(page).to have_css "img[src*='hot']"
+    end
+  end
+end

data/spec/features/data_dictionary_download_spec.rb

@@ -0,0 +1,16 @@
+require 'spec_helper'
+
+feature 'Data dictionary download tool' do
+  feature 'when data_dictionary reference present' do
+    scenario 'shows up in tools' do
+      visit solr_document_path 'nyu_2451_34502'
+      expect(page).to have_css 'li.data_dictionary a', text: 'Documentation'
+    end
+  end
+  feature 'when data_dictionary reference absent' do
+    scenario 'download tool is not rendered' do
+      visit solr_document_path 'stanford-cg357zz0321'
+      expect(page).not_to have_css 'li.data_dictionary a', text: 'Documentation'
+    end
+  end
+end

data/spec/features/download_layer_spec.rb

@@ -0,0 +1,93 @@
+require 'spec_helper'
+
+feature 'Download layer' do
+  let(:shapefile_download) { instance_double(Geoblacklight::ShapefileDownload) }
+  let(:kmz_download) { instance_double(Geoblacklight::KmzDownload) }
+
+  before do
+    allow(Geoblacklight::ShapefileDownload).to receive(:new).and_return(shapefile_download)
+    allow(Geoblacklight::KmzDownload).to receive(:new).and_return(kmz_download)
+  end
+
+  scenario 'clicking initial shapefile download button should trigger download', js: true do
+    expect(shapefile_download).to receive(:get).and_return('mit-f6rqs4ucovjk2-shapefile.zip')
+    visit solr_document_path('mit-f6rqs4ucovjk2')
+    find('a[data-download-type="shapefile"]', text: 'Export').click
+    expect(page).to have_css(
+      'a[href="/download/file/mit-f6rqs4ucovjk2-shapefile.zip"]',
+      text: 'Your file mit-f6rqs4ucovjk2-shapefile.zip is ready for download'
+    )
+  end
+  scenario 'failed download should return message with link to layer', js: true do
+    expect(shapefile_download).to receive(:get).and_raise(Geoblacklight::Exceptions::ExternalDownloadFailed.new(message: 'Failed', url: 'http://www.example.com/failed'))
+    visit solr_document_path('mit-f6rqs4ucovjk2')
+    find('a[data-download-type="shapefile"]', text: 'Export').click
+    expect(page).to have_css 'div.alert.alert-danger', text: 'Sorry, the requested file could not be downloaded. Try downloading it directly from:'
+    expect(page).to have_css 'a', text: 'http://www.example.com/failed'
+  end
+  scenario 'clicking kmz download button should trigger download', js: true do
+    expect(kmz_download).to receive(:get).and_return('mit-f6rqs4ucovjk2-kmz.kmz')
+    visit solr_document_path('mit-f6rqs4ucovjk2')
+    find('a[data-download-type="kmz"]', text: 'Export').click
+    expect(page).to have_css(
+      'a[href="/download/file/mit-f6rqs4ucovjk2-kmz.kmz"]',
+      text: 'Your file mit-f6rqs4ucovjk2-kmz.kmz is ready for download'
+    )
+  end
+  scenario 'jpg download option should be present under toggle' do
+    visit solr_document_path('princeton-02870w62c')
+    expect(page).to have_css('li a', text: 'Original JPG')
+  end
+  scenario 'clicking jpg download button should redirect to external image' do
+    visit solr_document_path('princeton-02870w62c')
+    expect(page).to have_css("a.btn.btn-default[href='https://libimages.princeton.edu/loris/pudl0076/map_pownall/00000001.jp2/full/full/0/default.jpg']", text: 'Original JPG')
+  end
+  scenario 'options should be available under toggle' do
+    visit solr_document_path('mit-f6rqs4ucovjk2')
+    expect(page).to have_css('li a[data-download-type="shapefile"]', text: 'Export')
+    expect(page).to have_css('li a[data-download-type="kmz"]', text: 'Export')
+  end
+  scenario 'restricted layer should not have download available to non logged in user' do
+    visit solr_document_path('stanford-cg357zz0321')
+    expect(page).to have_css 'a', text: 'Login to View and Download'
+    expect(page).not_to have_css 'button', text: 'Download Shapefile'
+  end
+  scenario 'restricted layer should have download available to logged in user' do
+    sign_in
+    visit solr_document_path('stanford-cg357zz0321')
+    expect(page).not_to have_css 'a', text: 'Login to view and download'
+    expect(page).to have_css 'a[data-download-type="shapefile"]', text: 'Export'
+  end
+  scenario 'layer with direct download and wms/wfs should include all download types' do
+    sign_in
+    visit solr_document_path('stanford-cg357zz0321')
+    expect(page).to have_css 'h2', text: 'Downloads'
+    expect(page).to have_css 'a', text: 'Original Shapefile'
+    expect(page).to have_css 'h2', text: 'Export Formats'
+    expect(page).to have_css 'a', text: 'Export'
+  end
+  scenario 'clicking GeoTIFF button for Harvard layer should show email form', js: true do
+    visit solr_document_path('harvard-g7064-s2-1834-k3')
+    find('a[data-download-type="harvard-hgl"]', text: 'GeoTIFF').click
+    expect(page).to have_css('#hglRequest')
+  end
+  context 'with a successful request to the server' do
+    let(:hgl_download) { instance_double(Geoblacklight::HglDownload) }
+
+    xscenario 'submitting email form should trigger HGL request', js: true do
+      # There are currently difficulties with testing the HGL downloader
+      visit solr_document_path('harvard-g7064-s2-1834-k3')
+      find('a[data-download-type="harvard-hgl"]', text: 'Original GeoTIFF').click
+
+      allow_any_instance_of(Geoblacklight::HglDownload).to receive(:new).and_return(hgl_download)
+      allow(hgl_download).to receive(:get).and_return('success')
+
+      within '#hglRequest' do
+        fill_in('Email', with: 'foo@example.com')
+        click_button('Request')
+      end
+      expect(page).to have_css('.alert-success')
+      expect(page).to have_content('You should receive an email when your download is ready')
+    end
+  end
+end

data/spec/features/empty_search_spec.rb

@@ -0,0 +1,11 @@
+require 'spec_helper'
+
+feature 'Empty search' do
+  before do
+    visit root_path
+  end
+  scenario 'Entering empty search returns results page' do
+    click_button 'search'
+    expect(page).to have_css '#documents'
+  end
+end

data/spec/features/esri_viewer_spec.rb

@@ -0,0 +1,42 @@
+require 'spec_helper'
+
+feature 'feature_layer reference', js: true do
+  scenario 'displays image map layer' do
+    visit solr_document_path '32653ed6-8d83-4692-8a06-bf13ffe2c018'
+    expect(page).to have_css '.leaflet-control-zoom', visible: true
+    expect(page).to have_css 'img.leaflet-image-layer', visible: true
+  end
+  scenario 'displays dynamic layer (all layers)' do
+    pending 'external service disabled cors access'
+    visit solr_document_path '90f14ff4-1359-4beb-b931-5cb41d20ab90'
+    expect(page).to have_css '.leaflet-control-zoom', visible: true
+    expect(page).to have_css 'img.leaflet-image-layer', visible: true
+  end
+  scenario 'displays dynamic layer (single layer)' do
+    visit solr_document_path '4669301e-b4b2-4c8b-bf40-01b968a2865b'
+    expect(page).to have_css '.leaflet-control-zoom', visible: true
+    expect(page).to have_css 'img.leaflet-image-layer', visible: true
+  end
+  scenario 'displays feature layer' do
+    pending 'cannot currently test for svg feature'
+    visit solr_document_path 'f406332e63eb4478a9560ad86ae90327_18'
+    expect(page).to have_css '.leaflet-control-zoom', visible: true
+    expect(Nokogiri::HTML.parse(page.body).css('g').length).to eq 23
+    fail
+  end
+  scenario 'displays image map layer' do
+    visit solr_document_path '32653ed6-8d83-4692-8a06-bf13ffe2c018'
+    expect(page).to have_css '.leaflet-control-zoom', visible: true
+    expect(page).to have_css 'img.leaflet-image-layer', visible: true
+  end
+  scenario 'displays tiled map layer' do
+    visit solr_document_path 'nyu-test-soil-survey-map'
+    expect(page).to have_css '.leaflet-control-zoom', visible: true
+    expect(page).to have_css 'img.leaflet-tile.leaflet-tile-loaded', visible: true
+  end
+  scenario 'displays Esri WMS layer' do
+    visit solr_document_path 'purdue-urn-f082acb1-b01e-4a08-9126-fd62a23fd9aa'
+    expect(page).to have_css '.leaflet-control-zoom', visible: true
+    expect(page).to have_css 'img.leaflet-tile.leaflet-tile-loaded', visible: true
+  end
+end