gemba 0.1.1 → 0.2.1

data/test/test_settings_hotkeys.rb

@@ -8,9 +8,9 @@ class TestMGBASettingsHotkeys < Minitest::Test
 
   def test_hotkeys_tab_exists
     assert_tk_app("hotkeys tab exists in notebook") do
-      require "gemba/settings_window"
-      require "gemba/hotkey_map"
-      sw = Gemba::SettingsWindow.new(app, callbacks: {})
+      require "gemba/headless"
+      require "gemba/headless"
+      sw = Gemba::SettingsWindow.new(app)
       sw.show
       app.update
 
@@ -21,9 +21,9 @@ class TestMGBASettingsHotkeys < Minitest::Test
 
   def test_hotkey_buttons_show_default_keysyms
     assert_tk_app("hotkey buttons show default keysyms") do
-      require "gemba/settings_window"
-      require "gemba/hotkey_map"
-      sw = Gemba::SettingsWindow.new(app, callbacks: {})
+      require "gemba/headless"
+      require "gemba/headless"
+      sw = Gemba::SettingsWindow.new(app)
       sw.show
       app.update
 
@@ -40,9 +40,9 @@ class TestMGBASettingsHotkeys < Minitest::Test
 
   def test_clicking_hotkey_button_enters_listen_mode
     assert_tk_app("clicking hotkey button enters listen mode") do
-      require "gemba/settings_window"
-      require "gemba/hotkey_map"
-      sw = Gemba::SettingsWindow.new(app, callbacks: {})
+      require "gemba/headless"
+      require "gemba/headless"
+      sw = Gemba::SettingsWindow.new(app)
       sw.show
       app.update
 
@@ -57,13 +57,13 @@ class TestMGBASettingsHotkeys < Minitest::Test
 
   def test_capture_updates_label_and_fires_callback
     assert_tk_app("capturing hotkey updates label and fires callback") do
-      require "gemba/settings_window"
-      require "gemba/hotkey_map"
+      require "gemba/headless"
+      require "gemba/headless"
       received_action = nil
       received_key = nil
-      sw = Gemba::SettingsWindow.new(app, callbacks: {
-        on_hotkey_change: proc { |a, k| received_action = a; received_key = k }
-      })
+      Gemba.bus = Gemba::EventBus.new
+      Gemba.bus.on(:hotkey_changed) { |a, k| received_action = a; received_key = k }
+      sw = Gemba::SettingsWindow.new(app)
       sw.show
       app.update
 
@@ -85,9 +85,9 @@ class TestMGBASettingsHotkeys < Minitest::Test
 
   def test_capture_enables_undo_button
     assert_tk_app("capturing hotkey enables undo button") do
-      require "gemba/settings_window"
-      require "gemba/hotkey_map"
-      sw = Gemba::SettingsWindow.new(app, callbacks: {})
+      require "gemba/headless"
+      require "gemba/headless"
+      sw = Gemba::SettingsWindow.new(app)
       sw.show
       app.update
 
@@ -108,12 +108,12 @@ class TestMGBASettingsHotkeys < Minitest::Test
 
   def test_undo_fires_callback_and_disables
     assert_tk_app("undo fires on_undo_hotkeys and disables button") do
-      require "gemba/settings_window"
-      require "gemba/hotkey_map"
+      require "gemba/headless"
+      require "gemba/headless"
       undo_called = false
-      sw = Gemba::SettingsWindow.new(app, callbacks: {
-        on_undo_hotkeys: proc { undo_called = true }
-      })
+      Gemba.bus = Gemba::EventBus.new
+      Gemba.bus.on(:undo_hotkeys) { undo_called = true }
+      sw = Gemba::SettingsWindow.new(app)
       sw.show
       app.update
 
@@ -135,11 +135,12 @@ class TestMGBASettingsHotkeys < Minitest::Test
 
   def test_reset_restores_defaults
     assert_tk_app("reset restores default hotkey labels") do
-      require "gemba/settings_window"
-      require "gemba/hotkey_map"
+      require "gemba/headless"
+      require "gemba/headless"
       reset_called = false
+      Gemba.bus = Gemba::EventBus.new
+      Gemba.bus.on(:hotkey_reset) { reset_called = true }
       sw = Gemba::SettingsWindow.new(app, callbacks: {
-        on_hotkey_reset: proc { reset_called = true },
         on_confirm_reset_hotkeys: -> { true },
       })
       sw.show
@@ -168,9 +169,9 @@ class TestMGBASettingsHotkeys < Minitest::Test
 
   def test_refresh_hotkeys_updates_labels
     assert_tk_app("refresh_hotkeys updates button labels") do
-      require "gemba/settings_window"
-      require "gemba/hotkey_map"
-      sw = Gemba::SettingsWindow.new(app, callbacks: {})
+      require "gemba/headless"
+      require "gemba/headless"
+      sw = Gemba::SettingsWindow.new(app)
       sw.show
       app.update
 
@@ -187,9 +188,9 @@ class TestMGBASettingsHotkeys < Minitest::Test
 
   def test_cancel_listen_restores_label
     assert_tk_app("canceling listen restores original label") do
-      require "gemba/settings_window"
-      require "gemba/hotkey_map"
-      sw = Gemba::SettingsWindow.new(app, callbacks: {})
+      require "gemba/headless"
+      require "gemba/headless"
+      sw = Gemba::SettingsWindow.new(app)
       sw.show
       app.update
 
@@ -210,12 +211,12 @@ class TestMGBASettingsHotkeys < Minitest::Test
 
   def test_capture_without_listen_is_noop
     assert_tk_app("capture without listen mode is a no-op") do
-      require "gemba/settings_window"
-      require "gemba/hotkey_map"
+      require "gemba/headless"
+      require "gemba/headless"
       received = false
-      sw = Gemba::SettingsWindow.new(app, callbacks: {
-        on_hotkey_change: proc { |*| received = true }
-      })
+      Gemba.bus = Gemba::EventBus.new
+      Gemba.bus.on(:hotkey_changed) { |*| received = true }
+      sw = Gemba::SettingsWindow.new(app)
       sw.show
       app.update
 
@@ -233,12 +234,13 @@ class TestMGBASettingsHotkeys < Minitest::Test
 
   def test_hotkey_rejected_when_conflicting_with_gamepad_key
     assert_tk_app("hotkey rejected when key conflicts with gamepad mapping") do
-      require "gemba/settings_window"
-      require "gemba/hotkey_map"
+      require "gemba/headless"
+      require "gemba/headless"
       received = false
       conflict_msg = nil
+      Gemba.bus = Gemba::EventBus.new
+      Gemba.bus.on(:hotkey_changed) { |*| received = true }
       sw = Gemba::SettingsWindow.new(app, callbacks: {
-        on_hotkey_change: proc { |*| received = true },
         on_validate_hotkey: ->(keysym) {
           # Simulate: 'z' is GBA button A
           keysym == 'z' ? '"z" is mapped to GBA button A' : nil
@@ -265,11 +267,12 @@ class TestMGBASettingsHotkeys < Minitest::Test
 
   def test_hotkey_accepted_when_no_conflict
     assert_tk_app("hotkey accepted when no conflict") do
-      require "gemba/settings_window"
-      require "gemba/hotkey_map"
+      require "gemba/headless"
+      require "gemba/headless"
       received_action = nil
+      Gemba.bus = Gemba::EventBus.new
+      Gemba.bus.on(:hotkey_changed) { |a, _| received_action = a }
       sw = Gemba::SettingsWindow.new(app, callbacks: {
-        on_hotkey_change: proc { |a, _| received_action = a },
         on_validate_hotkey: ->(_) { nil },
       })
       sw.show
@@ -290,13 +293,13 @@ class TestMGBASettingsHotkeys < Minitest::Test
 
   def test_capture_modifier_then_key_produces_combo
     assert_tk_app("modifier + key produces combo hotkey") do
-      require "gemba/settings_window"
-      require "gemba/hotkey_map"
+      require "gemba/headless"
+      require "gemba/headless"
       received_action = nil
       received_hk = nil
-      sw = Gemba::SettingsWindow.new(app, callbacks: {
-        on_hotkey_change: proc { |a, hk| received_action = a; received_hk = hk },
-      })
+      Gemba.bus = Gemba::EventBus.new
+      Gemba.bus.on(:hotkey_changed) { |a, hk| received_action = a; received_hk = hk }
+      sw = Gemba::SettingsWindow.new(app)
       sw.show
       app.update
 
@@ -319,12 +322,12 @@ class TestMGBASettingsHotkeys < Minitest::Test
 
   def test_capture_multi_modifier_combo
     assert_tk_app("multi-modifier combo (Ctrl+Shift+S)") do
-      require "gemba/settings_window"
-      require "gemba/hotkey_map"
+      require "gemba/headless"
+      require "gemba/headless"
       received_hk = nil
-      sw = Gemba::SettingsWindow.new(app, callbacks: {
-        on_hotkey_change: proc { |_, hk| received_hk = hk },
-      })
+      Gemba.bus = Gemba::EventBus.new
+      Gemba.bus.on(:hotkey_changed) { |_, hk| received_hk = hk }
+      sw = Gemba::SettingsWindow.new(app)
       sw.show
       app.update
 
@@ -344,11 +347,12 @@ class TestMGBASettingsHotkeys < Minitest::Test
 
   def test_combo_hotkey_skips_gamepad_conflict_validation
     assert_tk_app("combo hotkey skips gamepad conflict validation") do
-      require "gemba/settings_window"
-      require "gemba/hotkey_map"
+      require "gemba/headless"
+      require "gemba/headless"
       received_hk = nil
+      Gemba.bus = Gemba::EventBus.new
+      Gemba.bus.on(:hotkey_changed) { |_, hk| received_hk = hk }
       sw = Gemba::SettingsWindow.new(app, callbacks: {
-        on_hotkey_change: proc { |_, hk| received_hk = hk },
         # 'z' conflicts as a plain key, but Ctrl+z should be fine
         on_validate_hotkey: ->(key) {
           key == 'z' ? '"z" is mapped to GBA button A' : nil
@@ -370,9 +374,9 @@ class TestMGBASettingsHotkeys < Minitest::Test
 
   def test_refresh_hotkeys_shows_combo_display_name
     assert_tk_app("refresh_hotkeys shows combo display name") do
-      require "gemba/settings_window"
-      require "gemba/hotkey_map"
-      sw = Gemba::SettingsWindow.new(app, callbacks: {})
+      require "gemba/headless"
+      require "gemba/headless"
+      sw = Gemba::SettingsWindow.new(app)
       sw.show
       app.update
 
@@ -387,12 +391,12 @@ class TestMGBASettingsHotkeys < Minitest::Test
 
   def test_bind_script_modifier_combo_roundtrip
     assert_tk_app("Tcl bind script round-trip with modifier+key combo") do
-      require "gemba/settings_window"
-      require "gemba/hotkey_map"
+      require "gemba/headless"
+      require "gemba/headless"
       received_hk = nil
-      sw = Gemba::SettingsWindow.new(app, callbacks: {
-        on_hotkey_change: proc { |_, hk| received_hk = hk },
-      })
+      Gemba.bus = Gemba::EventBus.new
+      Gemba.bus.on(:hotkey_changed) { |_, hk| received_hk = hk }
+      sw = Gemba::SettingsWindow.new(app)
       sw.show
       app.update
 
@@ -421,9 +425,9 @@ class TestMGBASettingsHotkeys < Minitest::Test
 
   def test_record_hotkey_button_shows_default
     assert_tk_app("record hotkey button shows F10") do
-      require "gemba/settings_window"
-      require "gemba/hotkey_map"
-      sw = Gemba::SettingsWindow.new(app, callbacks: {})
+      require "gemba/headless"
+      require "gemba/headless"
+      sw = Gemba::SettingsWindow.new(app)
       sw.show
       app.update
 
@@ -431,4 +435,17 @@ class TestMGBASettingsHotkeys < Minitest::Test
       assert_equal 'F10', text
     end
   end
+
+  def test_open_rom_hotkey_button_shows_default
+    assert_tk_app("open rom hotkey button shows Ctrl+O") do
+      require "gemba/headless"
+      require "gemba/headless"
+      sw = Gemba::SettingsWindow.new(app)
+      sw.show
+      app.update
+
+      text = app.command(Gemba::SettingsWindow::HK_ACTIONS[:open_rom], 'cget', '-text')
+      assert_equal 'Ctrl+O', text
+    end
+  end
 end

data/test/test_settings_recording.rb

@@ -0,0 +1,49 @@
+# frozen_string_literal: true
+
+require "minitest/autorun"
+require_relative "shared/tk_test_helper"
+
+class TestSettingsRecordingTab < Minitest::Test
+  include TeekTestHelper
+
+  def test_recording_tab_exists
+    assert_tk_app("recording tab exists in notebook") do
+      require "gemba/headless"
+      sw = Gemba::SettingsWindow.new(app)
+      sw.show
+      app.update
+
+      tabs = app.command(Gemba::Settings::Paths::NB, 'tabs')
+      assert_includes tabs, Gemba::Settings::RecordingTab::FRAME
+    end
+  end
+
+  def test_compression_combobox_defaults_to_1
+    assert_tk_app("compression combobox defaults to 1") do
+      require "gemba/headless"
+      sw = Gemba::SettingsWindow.new(app)
+      sw.show
+      app.update
+
+      assert_equal '1', app.get_variable(Gemba::Settings::RecordingTab::VAR_COMPRESSION)
+    end
+  end
+
+  def test_selecting_compression_fires_callback
+    assert_tk_app("selecting compression fires on_compression_change") do
+      require "gemba/headless"
+      received = nil
+      Gemba.bus = Gemba::EventBus.new
+      Gemba.bus.on(:compression_changed) { |v| received = v }
+      sw = Gemba::SettingsWindow.new(app)
+      sw.show
+      app.update
+
+      app.set_variable(Gemba::Settings::RecordingTab::VAR_COMPRESSION, '6')
+      app.command(:event, 'generate', Gemba::Settings::RecordingTab::COMPRESSION_COMBO, '<<ComboboxSelected>>')
+      app.update
+
+      assert_equal 6, received
+    end
+  end
+end

data/test/test_settings_save_states.rb

@@ -0,0 +1,97 @@
+# frozen_string_literal: true
+
+require "minitest/autorun"
+require_relative "shared/tk_test_helper"
+
+class TestSettingsSaveStatesTab < Minitest::Test
+  include TeekTestHelper
+
+  def test_save_states_tab_exists
+    assert_tk_app("save states tab exists in notebook") do
+      require "gemba/headless"
+      sw = Gemba::SettingsWindow.new(app)
+      sw.show
+      app.update
+
+      tabs = app.command(Gemba::Settings::Paths::NB, 'tabs')
+      assert_includes tabs, Gemba::Settings::SaveStatesTab::FRAME
+    end
+  end
+
+  def test_quick_slot_defaults_to_1
+    assert_tk_app("quick slot defaults to 1") do
+      require "gemba/headless"
+      sw = Gemba::SettingsWindow.new(app)
+      sw.show
+      app.update
+
+      assert_equal '1', app.get_variable(Gemba::Settings::SaveStatesTab::VAR_QUICK_SLOT)
+    end
+  end
+
+  def test_selecting_slot_fires_callback
+    assert_tk_app("selecting slot fires on_quick_slot_change") do
+      require "gemba/headless"
+      received = nil
+      Gemba.bus = Gemba::EventBus.new
+      Gemba.bus.on(:quick_slot_changed) { |v| received = v }
+      sw = Gemba::SettingsWindow.new(app)
+      sw.show
+      app.update
+
+      app.set_variable(Gemba::Settings::SaveStatesTab::VAR_QUICK_SLOT, '5')
+      app.command(:event, 'generate', Gemba::Settings::SaveStatesTab::SLOT_COMBO, '<<ComboboxSelected>>')
+      app.update
+
+      assert_equal 5, received
+    end
+  end
+
+  def test_backup_defaults_to_on
+    assert_tk_app("backup checkbox defaults to on") do
+      require "gemba/headless"
+      sw = Gemba::SettingsWindow.new(app)
+      sw.show
+      app.update
+
+      assert_equal '1', app.get_variable(Gemba::Settings::SaveStatesTab::VAR_BACKUP)
+    end
+  end
+
+  def test_clicking_backup_fires_callback
+    assert_tk_app("clicking backup fires on_backup_change") do
+      require "gemba/headless"
+      received = nil
+      Gemba.bus = Gemba::EventBus.new
+      Gemba.bus.on(:backup_changed) { |v| received = v }
+      sw = Gemba::SettingsWindow.new(app)
+      sw.show
+      app.update
+
+      app.command(Gemba::Settings::SaveStatesTab::BACKUP_CHECK, 'invoke')
+      app.update
+
+      assert_equal false, received
+    end
+  end
+
+  def test_clicking_backup_twice_re_enables
+    assert_tk_app("clicking backup twice re-enables") do
+      require "gemba/headless"
+      received = nil
+      Gemba.bus = Gemba::EventBus.new
+      Gemba.bus.on(:backup_changed) { |v| received = v }
+      sw = Gemba::SettingsWindow.new(app)
+      sw.show
+      app.update
+
+      app.command(Gemba::Settings::SaveStatesTab::BACKUP_CHECK, 'invoke')
+      app.update
+      assert_equal false, received
+
+      app.command(Gemba::Settings::SaveStatesTab::BACKUP_CHECK, 'invoke')
+      app.update
+      assert_equal true, received
+    end
+  end
+end

data/test/test_settings_system.rb

@@ -0,0 +1,133 @@
+# frozen_string_literal: true
+
+require "minitest/autorun"
+require_relative "shared/tk_test_helper"
+
+class TestSettingsSystem < Minitest::Test
+  include TeekTestHelper
+
+  FAKE_BIOS = File.expand_path("fixtures/fake_bios.bin", __dir__)
+
+  # -- tab presence -----------------------------------------------------------
+
+  def test_system_tab_exists_in_notebook
+    assert_tk_app("system tab exists in notebook") do
+      require "gemba/headless"
+      Gemba.bus = Gemba::EventBus.new
+      sw = Gemba::SettingsWindow.new(app)
+      sw.show
+      app.update
+
+      tabs = app.command(Gemba::SettingsWindow::NB, 'tabs').split
+      assert_includes tabs, Gemba::SettingsWindow::SYSTEM_TAB
+    end
+  end
+
+  # -- initial state ----------------------------------------------------------
+
+  def test_bios_path_empty_initially
+    assert_tk_app("bios path var is empty initially") do
+      require "gemba/headless"
+      Gemba.bus = Gemba::EventBus.new
+      sw = Gemba::SettingsWindow.new(app)
+      sw.show
+      app.update
+
+      val = app.get_variable(Gemba::SettingsWindow::VAR_BIOS_PATH)
+      assert_equal '', val
+    end
+  end
+
+  def test_skip_bios_unchecked_initially
+    assert_tk_app("skip bios checkbox is unchecked initially") do
+      require "gemba/headless"
+      Gemba.bus = Gemba::EventBus.new
+      sw = Gemba::SettingsWindow.new(app)
+      sw.show
+      app.update
+
+      val = app.get_variable(Gemba::SettingsWindow::VAR_SKIP_BIOS)
+      assert_equal '0', val
+    end
+  end
+
+  # -- skip_bios checkbox marks dirty ----------------------------------------
+
+  def test_skip_bios_toggle_marks_save_dirty
+    assert_tk_app("toggling skip bios enables the save button") do
+      require "gemba/headless"
+      Gemba.bus = Gemba::EventBus.new
+      sw = Gemba::SettingsWindow.new(app)
+      sw.show
+
+      # Navigate to system tab
+      app.command(Gemba::SettingsWindow::NB, 'select', Gemba::SettingsWindow::SYSTEM_TAB)
+      app.update
+
+      app.command(Gemba::Settings::SystemTab::SKIP_BIOS_CHECK, 'invoke')
+      app.update
+
+      state = app.command(Gemba::SettingsWindow::SAVE_BTN, :cget, '-state').to_s
+      assert_equal 'normal', state
+    end
+  end
+
+  # -- clear button -----------------------------------------------------------
+
+  def test_clear_button_empties_bios_path
+    assert_tk_app("clear button empties the bios path variable") do
+      require "gemba/headless"
+      Gemba.bus = Gemba::EventBus.new
+      sw = Gemba::SettingsWindow.new(app)
+      sw.show
+      app.update
+
+      # Seed a value
+      app.set_variable(Gemba::SettingsWindow::VAR_BIOS_PATH, 'gba_bios.bin')
+      app.command(Gemba::Settings::SystemTab::BIOS_CLEAR, 'invoke')
+      app.update
+
+      assert_equal '', app.get_variable(Gemba::SettingsWindow::VAR_BIOS_PATH)
+    end
+  end
+
+  def test_clear_button_marks_save_dirty
+    assert_tk_app("clear button enables the save button") do
+      require "gemba/headless"
+      Gemba.bus = Gemba::EventBus.new
+      sw = Gemba::SettingsWindow.new(app)
+      sw.show
+      app.update
+
+      app.command(Gemba::Settings::SystemTab::BIOS_CLEAR, 'invoke')
+      app.update
+
+      state = app.command(Gemba::SettingsWindow::SAVE_BTN, :cget, '-state').to_s
+      assert_equal 'normal', state
+    end
+  end
+
+  def test_clear_resets_status_label
+    assert_tk_app("clear button resets status label to not-set text") do
+      require "gemba/headless"
+      Gemba::Locale.load('en')
+      Gemba.bus = Gemba::EventBus.new
+      sw = Gemba::SettingsWindow.new(app)
+      sw.show
+      app.update
+
+      app.command(Gemba::Settings::SystemTab::BIOS_CLEAR, 'invoke')
+      app.update
+
+      text = app.command(Gemba::Settings::SystemTab::BIOS_STATUS, :cget, '-text').to_s
+      assert_includes text, 'Not set'
+    end
+  end
+
+  # -- system tab is per-game eligible ----------------------------------------
+
+  def test_system_tab_in_per_game_tabs
+    require "gemba/headless"
+    assert Gemba::SettingsWindow::PER_GAME_TABS.include?(Gemba::SettingsWindow::SYSTEM_TAB)
+  end
+end