gemba 0.1.1 → 0.2.0

data/test/achievements_window/test_initial_state.rb

@@ -0,0 +1,164 @@
+# frozen_string_literal: true
+
+require "minitest/autorun"
+require_relative "../shared/tk_test_helper"
+
+# Tests for AchievementsWindow initial widget state — sync button, unofficial
+# checkbox, game combo filter, and status bar default text.
+class TestAchievementsWindowInitialState < Minitest::Test
+  include TeekTestHelper
+
+  TOP = Gemba::AchievementsWindow::TOP rescue '.gemba_achievements'
+
+  def test_sync_button_disabled_when_not_authenticated
+    assert_tk_app("sync button disabled when not authenticated") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        Gemba.bus = Gemba::EventBus.new
+
+        backend = Gemba::Achievements::FakeBackend.new  # NOT logged in
+        win = Gemba::AchievementsWindow.new(
+          app: app, rom_library: make_rom_library, config: FakeConfig.new(false)
+        )
+        win.update_game(rom_id: nil, backend: backend)
+        win.show
+        app.update
+
+        top = Gemba::AchievementsWindow::TOP
+        assert_equal 'disabled',
+          app.command("#{top}.toolbar.sync", :cget, '-state').to_s
+      ensure
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+
+  def test_sync_button_enabled_when_authenticated
+    assert_tk_app("sync button enabled when authenticated") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        Gemba.bus = Gemba::EventBus.new
+
+        backend = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+        win = Gemba::AchievementsWindow.new(
+          app: app, rom_library: make_rom_library, config: FakeConfig.new(false)
+        )
+        win.update_game(rom_id: nil, backend: backend)
+        win.show
+        app.update
+
+        top = Gemba::AchievementsWindow::TOP
+        assert_equal 'normal',
+          app.command("#{top}.toolbar.sync", :cget, '-state').to_s
+      ensure
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+
+  def test_unofficial_checkbox_reflects_config_false
+    assert_tk_app("unofficial checkbox is unchecked when config is false") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        Gemba.bus = Gemba::EventBus.new
+
+        backend = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+        win = Gemba::AchievementsWindow.new(
+          app: app, rom_library: make_rom_library, config: FakeConfig.new(false)
+        )
+        win.update_game(rom_id: nil, backend: backend)
+        win.show
+        app.update
+
+        assert_equal '0', app.get_variable(Gemba::AchievementsWindow::VAR_UNOFFICIAL)
+      ensure
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+
+  def test_unofficial_checkbox_reflects_config_true
+    assert_tk_app("unofficial checkbox is checked when config is true") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        Gemba.bus = Gemba::EventBus.new
+
+        backend = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+        win = Gemba::AchievementsWindow.new(
+          app: app, rom_library: make_rom_library, config: FakeConfig.new(true)
+        )
+        win.update_game(rom_id: nil, backend: backend)
+        win.show
+        app.update
+
+        assert_equal '1', app.get_variable(Gemba::AchievementsWindow::VAR_UNOFFICIAL)
+      ensure
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+
+  def test_combo_shows_only_gba_games
+    assert_tk_app("combo lists GBA games only, not GB or GBC") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        Gemba.bus = Gemba::EventBus.new
+
+        roms = [
+          make_rom_entry(id: 'gba1', title: 'GBA Game', platform: 'gba'),
+          make_rom_entry(id: 'gb1',  title: 'GB Game',  platform: 'gb'),
+          make_rom_entry(id: 'gbc1', title: 'GBC Game', platform: 'gbc'),
+        ]
+        backend = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+        win = Gemba::AchievementsWindow.new(
+          app: app, rom_library: make_rom_library(*roms), config: FakeConfig.new(false)
+        )
+        win.update_game(rom_id: nil, backend: backend)
+        win.show
+        app.update
+
+        top    = Gemba::AchievementsWindow::TOP
+        values = app.command("#{top}.toolbar.combo", :cget, '-values').to_s
+        assert_includes values, 'GBA Game'
+        refute_includes values, 'GB Game'
+        refute_includes values, 'GBC Game'
+      ensure
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+
+  def test_status_shows_none_when_empty
+    assert_tk_app("status shows 'no achievements' when backend has no achievements") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        Gemba.bus = Gemba::EventBus.new
+
+        backend = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+        win = Gemba::AchievementsWindow.new(
+          app: app, rom_library: make_rom_library, config: FakeConfig.new(false)
+        )
+        win.update_game(rom_id: nil, backend: backend)
+        win.show
+        app.update
+
+        top    = Gemba::AchievementsWindow::TOP
+        status = app.command("#{top}.status_bar.status", :cget, '-text').to_s
+        assert_equal Gemba::Locale.translate('achievements.none'), status
+      ensure
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+end

data/test/achievements_window/test_sorting.rb

@@ -0,0 +1,227 @@
+# frozen_string_literal: true
+
+require "minitest/autorun"
+require_relative "../shared/tk_test_helper"
+
+# Tests for AchievementsWindow treeview column sorting — default order,
+# heading click indicators, and indicator cleanup when switching columns.
+class TestAchievementsWindowSorting < Minitest::Test
+  include TeekTestHelper
+
+  def test_default_sort_earned_first_then_alphabetical
+    assert_tk_app("default sort: earned first, then unearned A→Z") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        require "support/fake_core"
+        Gemba.bus = Gemba::EventBus.new
+
+        backend = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+        backend.add_achievement(id: 'z', title: 'Zebra',    description: '', points: 5) { false }
+        backend.add_achievement(id: 'a', title: 'Aardvark', description: '', points: 5) { |_| true }
+        backend.add_achievement(id: 'm', title: 'Monkey',   description: '', points: 5) { false }
+        backend.do_frame(FakeCore.new)
+
+        win = Gemba::AchievementsWindow.new(
+          app: app, rom_library: make_rom_library, config: FakeConfig.new(false)
+        )
+        win.update_game(rom_id: nil, backend: backend)
+        win.show
+        win.refresh(backend)
+        app.update
+
+        tree   = "#{Gemba::AchievementsWindow::TOP}.tf.tree"
+        items  = app.tcl_eval("#{tree} children {}").split
+        titles = items.map { |id| app.tcl_eval("#{tree} set #{id} name") }
+        assert_equal 'Aardvark', titles[0], "earned should be first"
+        assert_equal 'Monkey',   titles[1], "Monkey before Zebra alphabetically"
+        assert_equal 'Zebra',    titles[2]
+      ensure
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+
+  def test_click_name_heading_sorts_asc_with_indicator
+    assert_tk_app("clicking name heading sorts A→Z and shows ▲") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        Gemba.bus = Gemba::EventBus.new
+
+        backend = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+        backend.add_achievement(id: 'z', title: 'Zebra',    description: '', points: 5) { false }
+        backend.add_achievement(id: 'a', title: 'Aardvark', description: '', points: 5) { false }
+        backend.add_achievement(id: 'm', title: 'Monkey',   description: '', points: 5) { false }
+
+        win = Gemba::AchievementsWindow.new(
+          app: app, rom_library: make_rom_library, config: FakeConfig.new(false)
+        )
+        win.update_game(rom_id: nil, backend: backend)
+        win.show
+        win.refresh(backend)
+        app.update
+
+        tree = "#{Gemba::AchievementsWindow::TOP}.tf.tree"
+        cmd  = app.tcl_eval("#{tree} heading name -command")
+        app.tcl_eval("uplevel #0 {#{cmd}}")
+        app.update
+
+        items  = app.tcl_eval("#{tree} children {}").split
+        titles = items.map { |id| app.tcl_eval("#{tree} set #{id} name") }
+        assert_equal %w[Aardvark Monkey Zebra], titles
+
+        assert_includes app.tcl_eval("#{tree} heading name -text"), '▲'
+      ensure
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+
+  def test_click_name_heading_twice_reverses_to_desc
+    assert_tk_app("clicking name heading twice reverses to Z→A and shows ▼") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        Gemba.bus = Gemba::EventBus.new
+
+        backend = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+        backend.add_achievement(id: 'z', title: 'Zebra',    description: '', points: 5) { false }
+        backend.add_achievement(id: 'a', title: 'Aardvark', description: '', points: 5) { false }
+
+        win = Gemba::AchievementsWindow.new(
+          app: app, rom_library: make_rom_library, config: FakeConfig.new(false)
+        )
+        win.update_game(rom_id: nil, backend: backend)
+        win.show
+        win.refresh(backend)
+        app.update
+
+        tree = "#{Gemba::AchievementsWindow::TOP}.tf.tree"
+        cmd  = app.tcl_eval("#{tree} heading name -command")
+        app.tcl_eval("uplevel #0 {#{cmd}}")  # asc
+        app.tcl_eval("uplevel #0 {#{cmd}}")  # desc
+        app.update
+
+        items  = app.tcl_eval("#{tree} children {}").split
+        titles = items.map { |id| app.tcl_eval("#{tree} set #{id} name") }
+        assert_equal %w[Zebra Aardvark], titles
+        assert_includes app.tcl_eval("#{tree} heading name -text"), '▼'
+      ensure
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+
+  def test_click_points_heading_sorts_low_to_high
+    assert_tk_app("clicking points heading sorts by points low→high") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        Gemba.bus = Gemba::EventBus.new
+
+        backend = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+        backend.add_achievement(id: 'a', title: 'High', description: '', points: 50) { false }
+        backend.add_achievement(id: 'b', title: 'Low',  description: '', points: 5)  { false }
+        backend.add_achievement(id: 'c', title: 'Mid',  description: '', points: 25) { false }
+
+        win = Gemba::AchievementsWindow.new(
+          app: app, rom_library: make_rom_library, config: FakeConfig.new(false)
+        )
+        win.update_game(rom_id: nil, backend: backend)
+        win.show
+        win.refresh(backend)
+        app.update
+
+        tree = "#{Gemba::AchievementsWindow::TOP}.tf.tree"
+        cmd  = app.tcl_eval("#{tree} heading points -command")
+        app.tcl_eval("uplevel #0 {#{cmd}}")
+        app.update
+
+        items = app.tcl_eval("#{tree} children {}").split
+        pts   = items.map { |id| app.tcl_eval("#{tree} set #{id} points").to_i }
+        assert_equal [5, 25, 50], pts
+      ensure
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+
+  def test_click_earned_heading_puts_unearned_last
+    assert_tk_app("clicking earned heading keeps unearned rows at the bottom") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        require "support/fake_core"
+        Gemba.bus = Gemba::EventBus.new
+
+        backend = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+        backend.add_achievement(id: 'e', title: 'Earned',   description: '', points: 5) { |_| true }
+        backend.add_achievement(id: 'u', title: 'Unearned', description: '', points: 5) { false }
+        backend.do_frame(FakeCore.new)
+
+        win = Gemba::AchievementsWindow.new(
+          app: app, rom_library: make_rom_library, config: FakeConfig.new(false)
+        )
+        win.update_game(rom_id: nil, backend: backend)
+        win.show
+        win.refresh(backend)
+        app.update
+
+        tree = "#{Gemba::AchievementsWindow::TOP}.tf.tree"
+        cmd  = app.tcl_eval("#{tree} heading earned -command")
+        app.tcl_eval("uplevel #0 {#{cmd}}")
+        app.update
+
+        items  = app.tcl_eval("#{tree} children {}").split
+        earned = items.map { |id| app.tcl_eval("#{tree} set #{id} earned") }
+        assert_equal '',  earned.last,  "unearned must be last"
+        refute_equal '', earned.first,  "earned must be first"
+      ensure
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+
+  def test_switching_sort_column_clears_old_indicator
+    assert_tk_app("switching sort column removes indicator from previously sorted column") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        Gemba.bus = Gemba::EventBus.new
+
+        backend = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+        backend.add_achievement(id: 'a', title: 'Alpha', description: '', points: 5) { false }
+
+        win = Gemba::AchievementsWindow.new(
+          app: app, rom_library: make_rom_library, config: FakeConfig.new(false)
+        )
+        win.update_game(rom_id: nil, backend: backend)
+        win.show
+        win.refresh(backend)
+        app.update
+
+        tree     = "#{Gemba::AchievementsWindow::TOP}.tf.tree"
+        name_cmd = app.tcl_eval("#{tree} heading name   -command")
+        pts_cmd  = app.tcl_eval("#{tree} heading points -command")
+        app.tcl_eval("uplevel #0 {#{name_cmd}}")   # sort by name
+        app.tcl_eval("uplevel #0 {#{pts_cmd}}")    # switch to points
+        app.update
+
+        name_text = app.tcl_eval("#{tree} heading name -text")
+        pts_text  = app.tcl_eval("#{tree} heading points -text")
+        refute_includes name_text, '▲', "name heading must lose indicator after switching"
+        refute_includes name_text, '▼', "name heading must lose indicator after switching"
+        assert_includes pts_text,  '▲', "points heading should show ▲"
+      ensure
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+end

data/test/achievements_window/test_tree_rendering.rb

@@ -0,0 +1,133 @@
+# frozen_string_literal: true
+
+require "minitest/autorun"
+require_relative "../shared/tk_test_helper"
+
+# Tests for AchievementsWindow treeview rendering — achievement rows, earned/
+# unearned column display, and status bar earned count.
+class TestAchievementsWindowTreeRendering < Minitest::Test
+  include TeekTestHelper
+
+  def test_tree_shows_achievement_titles
+    assert_tk_app("treeview rows show achievement titles from the backend") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        Gemba.bus = Gemba::EventBus.new
+
+        backend = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+        backend.add_achievement(id: 'a1', title: 'First Act',  description: '', points: 5)  { false }
+        backend.add_achievement(id: 'a2', title: 'Second Act', description: '', points: 10) { false }
+
+        win = Gemba::AchievementsWindow.new(
+          app: app, rom_library: make_rom_library, config: FakeConfig.new(false)
+        )
+        win.update_game(rom_id: nil, backend: backend)
+        win.show
+        win.refresh(backend)
+        app.update
+
+        tree   = "#{Gemba::AchievementsWindow::TOP}.tf.tree"
+        items  = app.tcl_eval("#{tree} children {}").split
+        titles = items.map { |id| app.tcl_eval("#{tree} set #{id} name") }
+        assert_equal 2, items.size
+        assert_includes titles, 'First Act'
+        assert_includes titles, 'Second Act'
+      ensure
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+
+  def test_unearned_achievements_have_empty_earned_column
+    assert_tk_app("unearned achievements show empty earned column") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        Gemba.bus = Gemba::EventBus.new
+
+        backend = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+        backend.add_achievement(id: 'a1', title: 'Unearned', description: '', points: 5) { false }
+
+        win = Gemba::AchievementsWindow.new(
+          app: app, rom_library: make_rom_library, config: FakeConfig.new(false)
+        )
+        win.update_game(rom_id: nil, backend: backend)
+        win.show
+        win.refresh(backend)
+        app.update
+
+        tree = "#{Gemba::AchievementsWindow::TOP}.tf.tree"
+        item = app.tcl_eval("#{tree} children {}").split.first
+        assert_equal '', app.tcl_eval("#{tree} set #{item} earned")
+      ensure
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+
+  def test_earned_achievements_show_date
+    assert_tk_app("earned achievements show a YYYY-MM-DD date in the earned column") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        require "support/fake_core"
+        Gemba.bus = Gemba::EventBus.new
+
+        backend = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+        backend.add_achievement(id: 'a1', title: 'Earned One', description: '', points: 5) { |_| true }
+        backend.do_frame(FakeCore.new)
+
+        win = Gemba::AchievementsWindow.new(
+          app: app, rom_library: make_rom_library, config: FakeConfig.new(false)
+        )
+        win.update_game(rom_id: nil, backend: backend)
+        win.show
+        win.refresh(backend)
+        app.update
+
+        tree   = "#{Gemba::AchievementsWindow::TOP}.tf.tree"
+        item   = app.tcl_eval("#{tree} children {}").split.first
+        earned = app.tcl_eval("#{tree} set #{item} earned")
+        assert_match(/\d{4}-\d{2}-\d{2}/, earned)
+      ensure
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+
+  def test_status_bar_shows_earned_count
+    assert_tk_app("status bar shows 'X / Y earned'") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        require "support/fake_core"
+        Gemba.bus = Gemba::EventBus.new
+
+        backend = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+        backend.add_achievement(id: 'a1', title: 'Alpha', description: '', points: 5) { |_| true }
+        backend.add_achievement(id: 'a2', title: 'Beta',  description: '', points: 5) { false }
+        backend.do_frame(FakeCore.new)
+
+        win = Gemba::AchievementsWindow.new(
+          app: app, rom_library: make_rom_library, config: FakeConfig.new(false)
+        )
+        win.update_game(rom_id: nil, backend: backend)
+        win.show
+        win.refresh(backend)
+        app.update
+
+        top    = Gemba::AchievementsWindow::TOP
+        status = app.command("#{top}.status_bar.status", :cget, '-text').to_s
+        assert_includes status, '1'
+        assert_includes status, '2'
+      ensure
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+end

data/test/shared/teek_test_worker.rb

@@ -67,7 +67,7 @@ class Teek::TestWorker
     end
 
     # Default timeout for test execution (can be overridden via TK_TEST_TIMEOUT env var)
-    DEFAULT_TIMEOUT = 60
+    DEFAULT_TIMEOUT = 10
 
     def run_test(code, pipe_capture: false, timeout: nil, source_file: nil, source_line: nil)
       start unless running?
@@ -171,6 +171,22 @@ class Teek::TestWorker
       end
       result
     end
+
+    # Suppress tk_popup for the duration of the block so right-click bindings
+    # can build and configure menus without posting them.  This avoids the
+    # platform grab that would block app.update on macOS and Windows.
+    #
+    # Uses Tcl `catch` so setup and teardown are idempotent — safe even if a
+    # previous test left _orig_tk_popup stranded due to an error.
+    def override_tk_popup
+      @app.tcl_eval("rename tk_popup _orig_tk_popup; proc tk_popup {args} {}")
+      yield
+    ensure
+      # Delete the no-op proc first (rename to {} = delete in Tcl), then
+      # restore the real tk_popup.  Both wrapped in catch so a double-ensure
+      # or other edge case never raises.
+      @app.tcl_eval("catch {rename tk_popup {}}; catch {rename _orig_tk_popup tk_popup}")
+    end
   end
 
   # Server-side: runs in subprocess