gemba 0.1.1 → 0.2.0

data/lib/gemba/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Gemba
-  VERSION = "0.1.1"
+  VERSION = "0.2.0"
 end

data/lib/gemba/virtual_keyboard.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+require 'set'
+
+module Gemba
+  # Virtual keyboard device that tracks key press/release state.
+  # Presents the same interface as an SDL gamepad: +button?+ and +closed?+.
+  class VirtualKeyboard
+    def initialize
+      @held = Set.new
+    end
+
+    def press(keysym)   = @held.add(keysym)
+    def release(keysym) = @held.delete(keysym)
+    def button?(keysym) = @held.include?(keysym)
+    def closed? = false
+  end
+
+end

data/lib/gemba.rb

@@ -1,17 +1,7 @@
 # frozen_string_literal: true
 
+require_relative "gemba/version"
 require "teek"
 require "teek/sdl2"
 require_relative "gemba/runtime"
-require_relative "gemba/child_window"
-require_relative "gemba/tip_service"
-require_relative "gemba/settings_window"
-require_relative "gemba/rom_info_window"
-require_relative "gemba/save_state_picker"
-require_relative "gemba/save_state_manager"
-require_relative "gemba/toast_overlay"
-require_relative "gemba/overlay_renderer"
-require_relative "gemba/input_mappings"
-require_relative "gemba/hotkey_map"
-require_relative "gemba/recorder"
-require_relative "gemba/player"
+require_relative "gemba/platform_open"

data/test/achievements_window/test_bulk_sync.rb

@@ -0,0 +1,218 @@
+# frozen_string_literal: true
+
+require "minitest/autorun"
+require_relative "../shared/tk_test_helper"
+
+# Tests for AchievementsWindow bulk sync — unofficial toggle fires bus event,
+# UI locks/unlocks during sync, per-game status updates, and done count display.
+class TestAchievementsWindowBulkSync < Minitest::Test
+  include TeekTestHelper
+
+  def test_unofficial_toggle_fires_bus_event
+    assert_tk_app("toggling unofficial checkbox fires :ra_unofficial_changed on the bus") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        require "tmpdir"
+        Gemba.bus = Gemba::EventBus.new
+
+        received = nil
+        Gemba.bus.on(:ra_unofficial_changed) { |value:, **| received = value }
+
+        backend = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+        backend.stub_fetch_for_display([])
+
+        Dir.mktmpdir("ach_win_test") do |tmpdir|
+          ENV['GEMBA_CONFIG_DIR'] = tmpdir
+          win = Gemba::AchievementsWindow.new(
+            app: app, rom_library: make_rom_library, config: FakeConfig.new(false)
+          )
+          win.update_game(rom_id: nil, backend: backend)
+          win.show
+          app.update
+
+          top = Gemba::AchievementsWindow::TOP
+          app.command("#{top}.toolbar.unofficial", 'invoke')
+          app.update
+
+          assert_equal true, received, ":ra_unofficial_changed should fire with true"
+        ensure
+          ENV.delete('GEMBA_CONFIG_DIR')
+        end
+      ensure
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+
+  def test_unofficial_toggle_locks_ui_during_sync
+    assert_tk_app("unofficial toggle disables both buttons while bulk sync runs") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        require "tmpdir"
+        Gemba.bus = Gemba::EventBus.new
+
+        backend = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+
+        # Capture widget states from INSIDE the fetch callback — FakeBackend
+        # calls synchronously so we're mid-sync right here.
+        mid_sync_states = {}
+        backend.stub_fetch_for_display do |_|
+          top = Gemba::AchievementsWindow::TOP
+          mid_sync_states[:sync]  = app.command("#{top}.toolbar.sync",      :cget, '-state').to_s
+          mid_sync_states[:unoff] = app.command("#{top}.toolbar.unofficial", :cget, '-state').to_s
+          nil
+        end
+
+        roms = [make_rom_entry(id: 'r1', title: 'Game')]
+        Dir.mktmpdir("ach_win_test") do |tmpdir|
+          ENV['GEMBA_CONFIG_DIR'] = tmpdir
+          win = Gemba::AchievementsWindow.new(
+            app: app, rom_library: make_rom_library(*roms), config: FakeConfig.new(false)
+          )
+          win.update_game(rom_id: nil, backend: backend)
+          win.show
+          app.update
+
+          top = Gemba::AchievementsWindow::TOP
+          app.command("#{top}.toolbar.unofficial", 'invoke')
+          app.update
+
+          assert_equal 'disabled', mid_sync_states[:sync],  "sync button locked during bulk sync"
+          assert_equal 'disabled', mid_sync_states[:unoff], "unofficial button locked during bulk sync"
+        ensure
+          ENV.delete('GEMBA_CONFIG_DIR')
+        end
+      ensure
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+
+  def test_bulk_sync_shows_per_game_status_updates
+    assert_tk_app("bulk sync updates the status bar for each game in sequence") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        require "tmpdir"
+        Gemba.bus = Gemba::EventBus.new
+
+        backend = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+
+        statuses = []
+        backend.stub_fetch_for_display do |_|
+          top = Gemba::AchievementsWindow::TOP
+          statuses << app.command("#{top}.status_bar.status", :cget, '-text').to_s
+          []
+        end
+
+        roms = [
+          make_rom_entry(id: 'r1', title: 'Game One'),
+          make_rom_entry(id: 'r2', title: 'Game Two'),
+        ]
+        Dir.mktmpdir("ach_win_test") do |tmpdir|
+          ENV['GEMBA_CONFIG_DIR'] = tmpdir
+          win = Gemba::AchievementsWindow.new(
+            app: app, rom_library: make_rom_library(*roms), config: FakeConfig.new(false)
+          )
+          win.update_game(rom_id: nil, backend: backend)
+          win.show
+          app.update
+
+          top = Gemba::AchievementsWindow::TOP
+          app.command("#{top}.toolbar.unofficial", 'invoke')
+          app.update
+
+          assert_equal 2, statuses.size,           "one status update per game"
+          assert_includes statuses[0], 'Game One', "first update names Game One"
+          assert_includes statuses[1], 'Game Two', "second update names Game Two"
+        ensure
+          ENV.delete('GEMBA_CONFIG_DIR')
+        end
+      ensure
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+
+  def test_bulk_sync_unlocks_ui_when_complete
+    assert_tk_app("bulk sync re-enables buttons after all games are done") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        require "tmpdir"
+        Gemba.bus = Gemba::EventBus.new
+
+        backend = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+        backend.stub_fetch_for_display([])
+
+        roms = [make_rom_entry(id: 'r1', title: 'Game')]
+        Dir.mktmpdir("ach_win_test") do |tmpdir|
+          ENV['GEMBA_CONFIG_DIR'] = tmpdir
+          win = Gemba::AchievementsWindow.new(
+            app: app, rom_library: make_rom_library(*roms), config: FakeConfig.new(false)
+          )
+          win.update_game(rom_id: nil, backend: backend)
+          win.show
+          app.update
+
+          top = Gemba::AchievementsWindow::TOP
+          app.command("#{top}.toolbar.unofficial", 'invoke')
+          app.update
+
+          assert_equal 'normal', app.command("#{top}.toolbar.sync",      :cget, '-state').to_s
+          assert_equal 'normal', app.command("#{top}.toolbar.unofficial", :cget, '-state').to_s
+        ensure
+          ENV.delete('GEMBA_CONFIG_DIR')
+        end
+      ensure
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+
+  def test_bulk_sync_done_status_shows_count
+    assert_tk_app("status bar shows N-game count after bulk sync completes") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        require "tmpdir"
+        Gemba.bus = Gemba::EventBus.new
+
+        backend = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+        backend.stub_fetch_for_display([])
+
+        roms = [
+          make_rom_entry(id: 'r1', title: 'Game A'),
+          make_rom_entry(id: 'r2', title: 'Game B'),
+        ]
+        Dir.mktmpdir("ach_win_test") do |tmpdir|
+          ENV['GEMBA_CONFIG_DIR'] = tmpdir
+          win = Gemba::AchievementsWindow.new(
+            app: app, rom_library: make_rom_library(*roms), config: FakeConfig.new(false)
+          )
+          win.update_game(rom_id: nil, backend: backend)
+          win.show
+          app.update
+
+          top = Gemba::AchievementsWindow::TOP
+          app.command("#{top}.toolbar.unofficial", 'invoke')
+          app.update
+
+          status = app.command("#{top}.status_bar.status", :cget, '-text').to_s
+          assert_includes status, '2', "done status should mention 2 games synced"
+        ensure
+          ENV.delete('GEMBA_CONFIG_DIR')
+        end
+      ensure
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+end

data/test/achievements_window/test_bus_events.rb

@@ -0,0 +1,125 @@
+# frozen_string_literal: true
+
+require "minitest/autorun"
+require_relative "../shared/tk_test_helper"
+
+# Tests for AchievementsWindow event bus subscriptions — sync started/done
+# disables/enables the sync button and auth-result logout disables it.
+class TestAchievementsWindowBusEvents < Minitest::Test
+  include TeekTestHelper
+
+  def test_ra_sync_started_disables_sync_button
+    assert_tk_app(":ra_sync_started disables the sync button") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        Gemba.bus = Gemba::EventBus.new
+
+        backend = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+        win = Gemba::AchievementsWindow.new(
+          app: app, rom_library: make_rom_library, config: FakeConfig.new(false)
+        )
+        win.update_game(rom_id: nil, backend: backend)
+        win.show
+        app.update
+
+        Gemba.bus.emit(:ra_sync_started)
+        app.update
+
+        top = Gemba::AchievementsWindow::TOP
+        assert_equal 'disabled',
+          app.command("#{top}.toolbar.sync", :cget, '-state').to_s
+      ensure
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+
+  def test_ra_sync_done_ok_re_enables_sync_button
+    assert_tk_app(":ra_sync_done(ok: true) re-enables the sync button") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        Gemba.bus = Gemba::EventBus.new
+
+        backend = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+        win = Gemba::AchievementsWindow.new(
+          app: app, rom_library: make_rom_library, config: FakeConfig.new(false)
+        )
+        win.update_game(rom_id: nil, backend: backend)
+        win.show
+        app.update
+
+        Gemba.bus.emit(:ra_sync_started)
+        app.update
+        Gemba.bus.emit(:ra_sync_done, ok: true)
+        app.update
+
+        top = Gemba::AchievementsWindow::TOP
+        assert_equal 'normal',
+          app.command("#{top}.toolbar.sync", :cget, '-state').to_s
+      ensure
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+
+  def test_ra_sync_done_fail_shows_error_status
+    assert_tk_app(":ra_sync_done(ok: false) shows sync_failed in status bar") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        Gemba.bus = Gemba::EventBus.new
+
+        backend = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+        win = Gemba::AchievementsWindow.new(
+          app: app, rom_library: make_rom_library, config: FakeConfig.new(false)
+        )
+        win.update_game(rom_id: nil, backend: backend)
+        win.show
+        app.update
+
+        Gemba.bus.emit(:ra_sync_done, ok: false)
+        app.update
+
+        top    = Gemba::AchievementsWindow::TOP
+        status = app.command("#{top}.status_bar.status", :cget, '-text').to_s
+        assert_equal Gemba::Locale.translate('achievements.sync_failed'), status
+      ensure
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+
+  def test_ra_auth_result_logout_disables_sync_button
+    assert_tk_app(":ra_auth_result after logout disables sync button") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        Gemba.bus = Gemba::EventBus.new
+
+        backend = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+        win = Gemba::AchievementsWindow.new(
+          app: app, rom_library: make_rom_library, config: FakeConfig.new(false)
+        )
+        win.update_game(rom_id: nil, backend: backend)
+        win.show
+        app.update
+
+        backend.logout
+        Gemba.bus.emit(:ra_auth_result, status: :logout)
+        app.update
+
+        top = Gemba::AchievementsWindow::TOP
+        assert_equal 'disabled',
+          app.command("#{top}.toolbar.sync", :cget, '-state').to_s
+      ensure
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+end

data/test/achievements_window/test_close_confirmation.rb

@@ -0,0 +1,201 @@
+# frozen_string_literal: true
+
+require "minitest/autorun"
+require_relative "../shared/tk_test_helper"
+
+# Tests for AchievementsWindow close-during-bulk-sync confirmation dialog —
+# no dialog when not syncing, dialog shown mid-sync, 'no' keeps window open,
+# 'yes' stops sync and withdraws the window.
+class TestAchievementsWindowCloseConfirmation < Minitest::Test
+  include TeekTestHelper
+
+  def test_hide_without_bulk_sync_does_not_show_dialog
+    assert_tk_app("win.hide when not syncing closes without showing any dialog") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        Gemba.bus = Gemba::EventBus.new
+
+        app.tcl_eval("set ::ach_dlg 0")
+        app.tcl_eval("proc tk_messageBox {args} { incr ::ach_dlg; return yes }")
+
+        backend = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+        win = Gemba::AchievementsWindow.new(
+          app: app, rom_library: make_rom_library, config: FakeConfig.new(false)
+        )
+        win.update_game(rom_id: nil, backend: backend)
+        win.show
+        app.update
+
+        win.hide
+        app.update
+
+        assert_equal '0', app.tcl_eval("set ::ach_dlg").strip,
+          "tk_messageBox must not be called when not in bulk sync"
+      ensure
+        app.tcl_eval("catch {rename tk_messageBox {}}") rescue nil
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+
+  def test_hide_during_bulk_sync_shows_dialog
+    assert_tk_app("win.hide mid-sync triggers a tk_messageBox confirmation") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        require "tmpdir"
+        Gemba.bus = Gemba::EventBus.new
+
+        app.tcl_eval("set ::ach_dlg 0")
+        app.tcl_eval("proc tk_messageBox {args} { incr ::ach_dlg; return no }")
+
+        backend = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+
+        win       = nil
+        attempted = false
+        backend.stub_fetch_for_display do |_|
+          unless attempted
+            attempted = true
+            win.hide   # dialog returns "no" → stays open
+            app.update
+          end
+          nil
+        end
+
+        roms = [make_rom_entry(id: 'r1', title: 'Game')]
+        Dir.mktmpdir("ach_win_test") do |tmpdir|
+          ENV['GEMBA_CONFIG_DIR'] = tmpdir
+          win = Gemba::AchievementsWindow.new(
+            app: app, rom_library: make_rom_library(*roms), config: FakeConfig.new(false)
+          )
+          win.update_game(rom_id: nil, backend: backend)
+          win.show
+          app.update
+
+          top = Gemba::AchievementsWindow::TOP
+          app.command("#{top}.toolbar.unofficial", 'invoke')
+          app.update
+
+          assert_equal '1', app.tcl_eval("set ::ach_dlg").strip,
+            "tk_messageBox must be shown when hiding during bulk sync"
+        ensure
+          ENV.delete('GEMBA_CONFIG_DIR')
+        end
+      ensure
+        app.tcl_eval("catch {rename tk_messageBox {}}") rescue nil
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+
+  def test_hide_confirm_no_keeps_window_visible
+    assert_tk_app("answering 'no' to the cancel-sync dialog keeps the window open") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        require "tmpdir"
+        Gemba.bus = Gemba::EventBus.new
+
+        app.tcl_eval("proc tk_messageBox {args} { return no }")
+
+        backend = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+
+        win       = nil
+        attempted = false
+        backend.stub_fetch_for_display do |_|
+          unless attempted
+            attempted = true
+            win.hide
+            app.update
+          end
+          nil
+        end
+
+        roms = [make_rom_entry(id: 'r1', title: 'Game')]
+        Dir.mktmpdir("ach_win_test") do |tmpdir|
+          ENV['GEMBA_CONFIG_DIR'] = tmpdir
+          win = Gemba::AchievementsWindow.new(
+            app: app, rom_library: make_rom_library(*roms), config: FakeConfig.new(false)
+          )
+          win.update_game(rom_id: nil, backend: backend)
+          win.show
+          app.update
+
+          top = Gemba::AchievementsWindow::TOP
+          app.command("#{top}.toolbar.unofficial", 'invoke')
+          app.update
+
+          # wm state is unreliable in xvfb when the root is withdrawn; instead
+          # verify the sync completed and UI was unlocked — only possible if
+          # the window stayed open and the sync ran to completion.
+          assert_equal 'normal', app.command("#{top}.toolbar.sync", :cget, '-state').to_s,
+            "sync button must be re-enabled after sync completes (window stayed open)"
+        ensure
+          ENV.delete('GEMBA_CONFIG_DIR')
+        end
+      ensure
+        app.tcl_eval("catch {rename tk_messageBox {}}") rescue nil
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+
+  def test_hide_confirm_yes_stops_sync_and_withdraws_window
+    assert_tk_app("answering 'yes' stops the bulk sync and withdraws the window") do
+      begin
+        require "gemba/headless"
+        require "support/achievements_window_helpers"
+        require "tmpdir"
+        Gemba.bus = Gemba::EventBus.new
+
+        app.tcl_eval("proc tk_messageBox {args} { return yes }")
+
+        win         = nil
+        fetch_count = 0
+        hide_done   = false
+        backend     = Gemba::Achievements::FakeBackend.new
+        backend.login_with_token(username: 'u', token: 't')
+        backend.stub_fetch_for_display do |_|
+          fetch_count += 1
+          unless hide_done
+            hide_done = true
+            win.hide   # dialog returns "yes" → cancel + withdraw
+            app.update
+          end
+          nil
+        end
+
+        roms = [
+          make_rom_entry(id: 'r1', title: 'Game One'),
+          make_rom_entry(id: 'r2', title: 'Game Two'),
+        ]
+        Dir.mktmpdir("ach_win_test") do |tmpdir|
+          ENV['GEMBA_CONFIG_DIR'] = tmpdir
+          win = Gemba::AchievementsWindow.new(
+            app: app, rom_library: make_rom_library(*roms), config: FakeConfig.new(false)
+          )
+          win.update_game(rom_id: nil, backend: backend)
+          win.show
+          app.update
+
+          top = Gemba::AchievementsWindow::TOP
+          app.command("#{top}.toolbar.unofficial", 'invoke')
+          app.update
+
+          assert_equal 1, fetch_count, "sync must stop after the first game when user says yes"
+          assert_equal 'withdrawn', app.tcl_eval("wm state #{top}").strip,
+            "window must be withdrawn after user confirms close"
+        ensure
+          ENV.delete('GEMBA_CONFIG_DIR')
+        end
+      ensure
+        app.tcl_eval("catch {rename tk_messageBox {}}") rescue nil
+        app.command(:destroy, Gemba::AchievementsWindow::TOP) rescue nil
+      end
+    end
+  end
+end