gecko-ruby 0.9.1 → 0.10.0

data/lib/gecko/record/variant.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gecko/record/base'
 
 module Gecko
@@ -13,7 +15,7 @@ module Gecko
         attribute :committed,       BigDecimal
         attribute :stock_on_hand,   BigDecimal
 
-        alias_method :committed_stock, :committed
+        alias committed_stock committed
       end
 
       class VariantPrice
@@ -84,12 +86,12 @@ module Gecko
       #
       # @api public
       def display_name
-        if name.nil? || !name.include?(product_name)
-          parts = [sku, product_name, name]
-        else
-          parts = [sku, name]
-        end
-        parts.select { |part| part && part.length }.join(' - ')
+        parts = if name.nil? || !name.include?(product_name)
+                  [sku, product_name, name]
+                else
+                  [sku, name]
+                end
+        parts.select { |part| part&.length }.join(' - ')
       end
 
       # attribute :is_online

data/lib/gecko/record/webhook.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gecko/record/base'
 
 module Gecko
@@ -27,7 +29,7 @@ module Gecko
         stock_adjustment.create
         stock_transfer.create
         variant.create
-      ]
+      ].freeze
 
       attribute :address, String
       attribute :event,   String

data/lib/gecko/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gecko
-  VERSION = '0.9.1'
+  VERSION = '0.10.0'
 end

data/test/client_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class ClientTest < Minitest::Test
@@ -13,10 +15,10 @@ class ClientTest < Minitest::Test
   def test_custom_user_agent
     client  = Gecko::Client.new("ABC", "DEF")
     agent   = client.oauth_client.connection.headers["User-Agent"]
-    assert_match(%r|Gecko/#{Gecko::VERSION} OAuth2/\d\.\d\.\d Faraday/\d\.\d+\.\d Ruby/\d\.\d\.\d|, agent)
+    assert_match(%r{Gecko/#{Gecko::VERSION} OAuth2/\d\.\d\.\d Faraday/\d\.\d+\.\d Ruby/\d\.\d\.\d}, agent)
   end
 
-  def test_allows_test_URLs
+  def test_allows_test_urls
     client = Gecko::Client.new("ABC", "DEF", site: "localhost:3000")
     assert_equal "localhost:3000", client.oauth_client.site
   end

data/test/fixtures/vcr_cassettes/images.yml

@@ -53,7 +53,7 @@ http_interactions:
       - chunked
     body:
       encoding: UTF-8
-      string: '{"images":[{"id":204,"variant_id":1035,"uploader_id":26,"name":"p17e54uam11hmn11g019qg16gj1lvh4.jpeg","position":1,"base_path":"https://tradegecko-development-images.s3.amazonaws.com/uploads/variant_image/image/204","file_name":"Dead_Cool.jpeg","versions":["thumbnail"],"image_processing":null},{"id":5140,"variant_id":1995,"uploader_id":26,"name":"p17hgbcgn413jf2pi9h415jjjc74.jpeg","position":1,"base_path":"https://tradegecko-development-images.s3.amazonaws.com/uploads/variant_image/image/5140","file_name":"Broken_heart_copy.jpeg","versions":["thumbnail"],"image_processing":null},{"id":59274,"variant_id":92694,"uploader_id":"Shopify","name":null,"position":1,"base_path":"https://tradegecko-development-images.s3.amazonaws.com/uploads/variant_image/image/59274","file_name":"dellMON.jpg","versions":["thumbnail"],"image_processing":null},{"id":206,"variant_id":1034,"uploader_id":26,"name":"p17e54urld1ffth831j3ct6a1gl1e.jpeg","position":1,"base_path":"https://tradegecko-development-images.s3.amazonaws.com/uploads/variant_image/image/206","file_name":"Dead_Cool.jpeg","versions":["thumbnail"],"image_processing":null},{"id":251,"variant_id":5252,"uploader_id":213,"name":"p17eh9kpij1u771kg1rdc103vn5i.jpg","position":1,"base_path":"https://tradegecko-development-images.s3.amazonaws.com/uploads/variant_image/image/251","file_name":"Chance_PerfectBoatneck_WhiteW.Navy.jpg","versions":["thumbnail"],"image_processing":null}]}'
+      string: '{"images":[{"base_path":"https://tradegecko-development-images.s3.amazonaws.com/uploads/variant_image/image/204","created_at":"2013-12-19T03:55:45.973Z","file_name":"Dead_Cool.jpeg","id":204,"image_processing":false,"name":"p17e54uam11hmn11g019qg16gj1lvh4.jpeg","position":1,"product_id":27,"updated_at":"2013-12-19T03:55:45.973Z","uploader_id":26,"variant_ids":[1035],"versions":["thumbnail"]},{"base_path":"https://tradegecko-development-images.s3.amazonaws.com/uploads/variant_image/image/5140","created_at":"2013-12-19T03:55:45.973Z","file_name":"Broken_heart_copy.jpeg","id":5140,"image_processing":false,"name":"p17hgbcgn413jf2pi9h415jjjc74.jpeg","position":1,"product_id":27,"updated_at":"2013-12-19T03:55:45.973Z","uploader_id":26,"variant_id":1995,"variant_ids":[1995],"versions":["thumbnail"]},{"base_path":"https://tradegecko-development-images.s3.amazonaws.com/uploads/variant_image/image/59274","created_at":"2013-12-19T03:55:45.973Z","file_name":"dellMON.jpg","id":59274,"image_processing":false,"name":null,"position":1,"product_id":28,"updated_at":"2013-12-19T03:55:45.973Z","uploader_id":"Shopify","variant_id":92694,"variant_ids":[92694],"versions":["thumbnail"]},{"base_path":"https://tradegecko-development-images.s3.amazonaws.com/uploads/variant_image/image/206","created_at":"2013-12-19T03:55:45.973Z","file_name":"Dead_Cool.jpeg","id":206,"image_processing":false,"name":"p17e54urld1ffth831j3ct6a1gl1e.jpeg","position":1,"product_id":1034,"updated_at":"2013-12-19T03:55:45.973Z","uploader_id":26,"variant_id":1034,"variant_ids":[1034],"versions":["thumbnail"]},{"base_path":"https://tradegecko-development-images.s3.amazonaws.com/uploads/variant_image/image/251","created_at":"2013-12-19T03:55:45.973Z","file_name":"Chance_PerfectBoatneck_WhiteW.Navy.jpg","id":251,"image_processing":false,"name":"p17eh9kpij1u771kg1rdc103vn5i.jpg","position":1,"product_id":5252,"updated_at":"2013-12-19T03:55:45.973Z","uploader_id":213,"variant_id":5252,"variant_ids":[5252],"versions":["thumbnail"]}]}'
     http_version: 
   recorded_at: Wed, 12 Mar 2014 11:39:39 GMT
 recorded_with: VCR 2.8.0

data/test/gecko_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class GeckoTest < Minitest::Test

data/test/helpers/association_helper_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gecko'
 
 class Gecko::Helpers::AssociationHelperTest < Minitest::Test
@@ -25,31 +27,31 @@ class Gecko::Helpers::AssociationHelperTest < Minitest::Test
   end
 
   def test_has_many
-    record = @klass.new(@client, {order_ids: [123]})
+    record = @klass.new(@client, { order_ids: [123] })
     @client.Order.expects(:find_many).with([123])
     record.orders
   end
 
   def test_has_many_without_ids
-    record = @klass.new(@client, {order_ids: []})
+    record = @klass.new(@client, { order_ids: [] })
     @client.Order.expects(:find_many).never
     assert_empty(record.orders)
   end
 
   def test_belongs_to
-    record = @klass.new(@client, {order_id: 4})
+    record = @klass.new(@client, { order_id: 4 })
     @client.Order.expects(:find).with(4)
     record.order
   end
 
   def test_belongs_to_without_id
-    record = @klass.new(@client, {order_id: nil})
+    record = @klass.new(@client, { order_id: nil })
     @client.Order.expects(:find).never
     assert_nil record.order
   end
 
   def test_belongs_to_with_class
-    record = @klass.new(@client, {small_order_id: 56})
+    record = @klass.new(@client, { small_order_id: 56 })
     @client.Order.expects(:find).with(56)
     record.small_order
   end

data/test/helpers/inspection_helper_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gecko'
 
 class Gecko::Helpers::InspectionHelperTest < Minitest::Test
@@ -12,9 +14,9 @@ class Gecko::Helpers::InspectionHelperTest < Minitest::Test
 
   def test_inspect_times
     record = @klass.new(@client, {
-      published_date: Date.new(2014),
-      published_time: Time.new(2014),
-      published_datetime: DateTime.new(2014),
+      published_date:     Date.new(2014),
+      published_time:     Time.new(2014),
+      published_datetime: DateTime.new(2014)
     })
     assert_equal("2014-01-01 00:00:00", get_timestamp(record.inspect, :published_time))
     assert_equal("2014-01-01 00:00:00", get_timestamp(record.inspect, :published_datetime))
@@ -22,6 +24,6 @@ class Gecko::Helpers::InspectionHelperTest < Minitest::Test
   end
 
   def get_timestamp(inspect_string, attribute)
-    inspect_string.match(%r|#{attribute}: \"(?<timestamp>[\d:\s-]+)\"|)[:timestamp]
+    inspect_string.match(/#{attribute}: \"(?<timestamp>[\d:\s-]+)\"/)[:timestamp]
   end
 end

data/test/helpers/serialization_helper_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gecko'
 require 'test_helper'
 
@@ -27,14 +29,14 @@ class Gecko::Helpers::SerializationHelperTest < Minitest::Test
 
   let(:record) do
     Widget.new(@client, {
-      name:       "Gecko",
-      secret:     "Iguana",
+      name:          "Gecko",
+      secret:        "Iguana",
       initial_stock: 10.0,
-      update_stock: 10.0,
-      score:      1.234,
-      started_at: DateTime.now,
-      started_on: Date.today,
-      wodgets:    [Wodget.new(@client, name: "Hi")]
+      update_stock:  10.0,
+      score:         1.234,
+      started_at:    DateTime.now,
+      started_on:    Date.today,
+      wodgets:       [Wodget.new(@client, name: "Hi")]
     })
   end
 
@@ -48,7 +50,7 @@ class Gecko::Helpers::SerializationHelperTest < Minitest::Test
   end
 
   def test_as_json
-    assert_equal({widget: record.serializable_hash}, record.as_json)
+    assert_equal({ widget: record.serializable_hash }, record.as_json)
   end
 
   def test_writeable_on_create
@@ -72,7 +74,7 @@ class Gecko::Helpers::SerializationHelperTest < Minitest::Test
   end
 
   def test_serializes_arrays
-    assert_equal([{name: "Hi"}], record.serializable_hash[:wodgets])
+    assert_equal([{ name: "Hi" }], record.serializable_hash[:wodgets])
   end
 
   def test_root_key
@@ -100,12 +102,12 @@ private
 
   def serialized_record
     {
-      name:       "Gecko",
+      name:          "Gecko",
       initial_stock: "10.0",
-      score:      "1.234",
-      started_on: Date.today,
-      started_at: DateTime.now,
-      wodgets:    [{name: "Hi"}]
+      score:         "1.234",
+      started_on:    Date.today,
+      started_at:    DateTime.now,
+      wodgets:       [{ name: "Hi" }]
     }
   end
 end

data/test/helpers/validation_helper_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gecko'
 
 class Gecko::Helpers::ValidationHelperTest < Minitest::Test
@@ -17,7 +19,7 @@ class Gecko::Helpers::ValidationHelperTest < Minitest::Test
 
   def test_from_response
     record = @klass.new(@client, name: "Gecko")
-    record.errors.from_response({name: ["is not shiny"]})
+    record.errors.from_response({ name: ["is not shiny"] })
     assert(!record.valid?)
     assert_equal(record.errors[:name], ["is not shiny"])
   end

data/test/record/account_adapter_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 class Gecko::Record::AccountAdapterTest < Minitest::Test
   include TestingAdapter

data/test/record/address_adapter_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class Gecko::Record::AddressAdapterTest < Minitest::Test

data/test/record/address_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class Gecko::AddressTest < Minitest::Test

data/test/record/company_adapter_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class Gecko::Record::CompanyAdapterTest < Minitest::Test

data/test/record/company_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class Gecko::CompanyTest < Minitest::Test

data/test/record/contact_adapter_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class Gecko::Record::ContactAdapterTest < Minitest::Test

data/test/record/contact_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class Gecko::ContactTest < Minitest::Test
@@ -15,4 +17,4 @@ class Gecko::ContactTest < Minitest::Test
   def test_initializes_record
     assert_instance_of(Gecko::Record::Contact, @record)
   end
-end
+end

data/test/record/currency_adapter_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class Gecko::Record::CurrencyAdapterTest < Minitest::Test

data/test/record/currency_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class Gecko::CurrencyTest < Minitest::Test

data/test/record/fulfillment_adapter_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class Gecko::Record::FulfillmentAdapterTest < Minitest::Test

data/test/record/fulfillment_line_item_adapter_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class Gecko::Record::FulfillmentLineItemAdapterTest < Minitest::Test

data/test/record/fulfillment_line_item_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class Gecko::FulfillmentLineItemTest < Minitest::Test

data/test/record/fulfillment_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class Gecko::FulfillmentTest < Minitest::Test
@@ -17,11 +19,11 @@ class Gecko::FulfillmentTest < Minitest::Test
   end
 
   def test_serialization
-    json_keys = %w(
+    json_keys = %w[
       order_id shipping_address_id billing_address_id status stock_location_id exchange_rate
       delivery_type tracking_number notes tracking_url tracking_company packed_at
       service shipped_at received_at receipt
-    ).map(&:to_sym)
+    ].map(&:to_sym)
     assert_equal json_keys.sort, @record.as_json[:fulfillment].keys.sort
   end
 end

data/test/record/image_adapter_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class Gecko::Record::ImageAdapterTest < Minitest::Test

data/test/record/image_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class Gecko::ImageTest < Minitest::Test
@@ -22,4 +24,20 @@ class Gecko::ImageTest < Minitest::Test
     assert_equal("https://example.com/Gecko.jpg", @record.url(:full))
     assert_equal("https://example.com/thumbnail_Gecko.jpg", @record.url(:thumbnail))
   end
+
+  def test_building_record # rubocop:disable Metrics/MethodLength
+    record = @client.adapter_for(record_class.demodulized_name).build({
+      variant_ids: 1,
+      product_id:  1,
+      url:         "https://example.com/Gecko.jpg"
+    })
+    assert_equal(record.product_id, 1)
+    assert_equal(record.variant_ids, [1])
+    assert_equal(record.serializable_hash, {
+      product_id:  1,
+      variant_ids: [1],
+      name:        nil,
+      url:         "https://example.com/Gecko.jpg"
+    })
+  end
 end

data/test/record/invoice_adapter_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class Gecko::Record::InvoiceAdapterTest < Minitest::Test

data/test/record/invoice_line_item_adapter_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class Gecko::Record::InvoiceLineItemAdapterTest < Minitest::Test

data/test/record/invoice_line_item_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class Gecko::InvoiceLineItemTest < Minitest::Test

data/test/record/invoice_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class Gecko::InvoiceTest < Minitest::Test

data/test/record/location_adapter_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class Gecko::Record::LocationAdapterTest < Minitest::Test

data/test/record/location_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class Gecko::LocationTest < Minitest::Test

data/test/record/note_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class Gecko::NoteTest < Minitest::Test

data/test/record/order_adapter_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class Gecko::Record::OrderAdapterTest < Minitest::Test

data/test/record/order_line_item_adapter_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class Gecko::Record::OrderLineItemAdapterTest < Minitest::Test

data/test/record/order_line_item_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class Gecko::OrderLineItemTest < Minitest::Test