gecko-ruby 0.9.1 → 0.10.0

data/lib/gecko/helpers/validation_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gecko
   module Helpers
     # Provides record validation
@@ -71,7 +73,7 @@ module Gecko
     #
     # @api public
     def empty?
-      messages.all? { |k, v| v && v.empty? && !v.is_a?(String) }
+      messages.all? { |_k, v| v&.empty? && !v.is_a?(String) }
     end
 
     # Parse JSON errors response into the error object

data/lib/gecko/record/account.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gecko/record/base'
 
 module Gecko
@@ -52,7 +54,7 @@ module Gecko
       #
       # @api public
       def current
-        if self.has_record_for_id?(:current)
+        if has_record_for_id?(:current)
           record_for_id(:current)
         else
           @identity_map[:current] = find(:current)

data/lib/gecko/record/address.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gecko/record/base'
 
 module Gecko

data/lib/gecko/record/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gecko/helpers/association_helper'
 require 'gecko/helpers/inspection_helper'
 require 'gecko/helpers/serialization_helper'
@@ -24,9 +26,9 @@ module Gecko
       # @return [undefined]
       #
       # @api private
-      def initialize(client, attributes={})
+      def initialize(client, attributes = {})
         super(attributes)
-        @client   = client
+        @client = client
       end
 
       # Whether the record has been persisted
@@ -62,7 +64,7 @@ module Gecko
       #
       # @api private
       def self.demodulized_name
-        self.name.split('::').last
+        name.split('::').last
       end
     end
   end

data/lib/gecko/record/base_adapter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gecko
   module Record
     class BaseAdapter
@@ -108,7 +110,7 @@ module Gecko
       # @return [Array<Gecko::Record::Base>] Records via the API
       #
       # @api public
-      def where(params={})
+      def where(params = {})
         response = @last_response = request(:get, plural_path, params: params)
         parsed_response = response.parsed
         set_pagination(response.headers)
@@ -149,14 +151,14 @@ module Gecko
       # @return <Gecko::Record::Base> A record instance
       #
       # @api public
-      def first(params={})
+      def first(params = {})
         where(params.merge(limit: 1)).first
       end
 
       # Fetch the forty-second record for the given parameters
       #
       # @api public
-      def forty_two(params={})
+      def forty_two(params = {})
         where(params.merge(limit: 1, page: 42)).first
       end
 
@@ -171,7 +173,7 @@ module Gecko
       #
       # @api public
       def count(params = {})
-        self.where(params.merge(limit: 0))
+        where(params.merge(limit: 0))
         @pagination['total_records']
       end
 
@@ -199,13 +201,13 @@ module Gecko
       # @return [nil] if no record was found
       #
       # @api private
-      def fetch(id)
+      def fetch(id) # rubocop:disable Metrics/MethodLength
         verify_id_presence!(id)
         response = @last_response = request(:get, plural_path + '/' + id.to_s)
         record_json = extract_record(response.parsed)
         instantiate_and_register_record(record_json)
-      rescue OAuth2::Error => ex
-        case ex.response.status
+      rescue OAuth2::Error => e
+        case e.response.status
         when 404
           record_not_found!(id)
         else
@@ -257,7 +259,7 @@ module Gecko
       # @return [Gecko::Record::Base]
       #
       # @api public
-      def build(attributes={})
+      def build(attributes = {})
         model_class.new(@client, attributes)
       end
 
@@ -342,7 +344,7 @@ module Gecko
       # @api private
       def create_record(record, opts = {})
         response = request(:post, plural_path, {
-          body: record.as_json,
+          body:         record.as_json,
           raise_errors: false
         }.merge(headers: headers_from_opts(opts)))
         handle_response(record, response)
@@ -355,7 +357,7 @@ module Gecko
       # @api private
       def update_record(record, opts = {})
         response = request(:put, plural_path + "/" + record.id.to_s, {
-          body: record.as_json,
+          body:         record.as_json,
           raise_errors: false
         }.merge(headers: headers_from_opts(opts)))
         handle_response(record, response)
@@ -368,10 +370,10 @@ module Gecko
       # @return [OAuth2::Response]
       #
       # @api private
-      def handle_response(record, response)
+      def handle_response(record, response) # rubocop:disable Metrics/MethodLength
         case response.status
         when 200..299
-          if response_json = extract_record(response.parsed)
+          if (response_json = extract_record(response.parsed))
             record.attributes = response_json
             register_record(record)
           end
@@ -380,7 +382,7 @@ module Gecko
           record.errors.from_response(response.parsed['errors'])
           false
         else
-          fail OAuth2::Error.new(response)
+          fail OAuth2::Error, response
         end
       end
 
@@ -410,6 +412,7 @@ module Gecko
 
           record_class = record_type.singularize.classify
           next unless Gecko::Record.const_defined?(record_class)
+
           adapter = @client.adapter_for(record_class)
 
           records.each do |record_json|
@@ -428,14 +431,16 @@ module Gecko
       # @return [OAuth2::Response]
       #
       # @api private
-      def request(verb, path, options={})
+      def request(verb, path, options = {}) # rubocop:disable Metrics/MethodLength
         ActiveSupport::Notifications.instrument('request.gecko') do |payload|
           payload[:verb]         = verb
           payload[:params]       = options[:params]
           payload[:body]         = options[:body]
           payload[:model_class]  = model_class
           payload[:request_path] = path
-          options[:headers]      = options.fetch(:headers, {}).tap { |headers| headers['Content-Type'] = 'application/json' }
+          options[:headers]      = options.fetch(:headers, {}).tap do |headers|
+            headers['Content-Type'] = 'application/json'
+          end
           options[:body]         = options[:body].to_json if options[:body]
           payload[:response]     = @client.access_token.request(verb, path, options)
         end
@@ -450,9 +455,9 @@ module Gecko
       end
 
       def verify_id_presence!(id)
-        if id.respond_to?(:empty?) ? id.empty? : !id
-          fail RecordNotFound, "Couldn't find #{model_class.name} without an ID"
-        end
+        return unless id.respond_to?(:empty?) ? id.empty? : !id
+
+        fail RecordNotFound, "Couldn't find #{model_class.name} without an ID"
       end
     end
   end

data/lib/gecko/record/company.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gecko/record/base'
 
 module Gecko

data/lib/gecko/record/contact.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gecko/record/base'
 
 module Gecko

data/lib/gecko/record/currency.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gecko/record/base'
 
 module Gecko

data/lib/gecko/record/exceptions.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gecko
   module Record
     # Generic Gecko::Record exception class.

data/lib/gecko/record/fulfillment.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gecko/record/base'
 require 'gecko/record/fulfillment_line_item'
 

data/lib/gecko/record/fulfillment_line_item.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gecko/record/base'
 
 module Gecko
@@ -13,7 +15,6 @@ module Gecko
     end
 
     class FulfillmentLineItemAdapter < BaseAdapter
-
     end
   end
 end

data/lib/gecko/record/image.rb

@@ -1,12 +1,17 @@
+# frozen_string_literal: true
+
 require 'gecko/record/base'
 
 module Gecko
   module Record
     class Image < Base
-      AVAILABLE_SIZES = [:full, :thumbnail]
+      AVAILABLE_SIZES = %i[full thumbnail].freeze
+
+      belongs_to :uploader, class_name: "User", readonly: true
+
+      belongs_to :product, writeable_on: :create
+      has_many :variants,  writeable_on: :create, readonly: false
 
-      belongs_to :variant
-      belongs_to :uploader, class_name: "User",   readonly: true
       attribute :name,             String
       attribute :url,              String
       attribute :position,         Integer,       readonly: true
@@ -31,11 +36,11 @@ module Gecko
     private
 
       def build_url(size)
-        if size == :full
-          file_path = file_name
-        else
-          file_path = "#{size}_#{file_name}"
-        end
+        file_path = if size == :full
+                      file_name
+                    else
+                      "#{size}_#{file_name}"
+                    end
         [base_path, file_path].join("/")
       end
     end

data/lib/gecko/record/invoice.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gecko/record/base'
 
 module Gecko
@@ -7,10 +9,13 @@ module Gecko
       belongs_to :shipping_address
       belongs_to :billing_address
       belongs_to :payment_term
+      belongs_to :company,                    readonly: true
+      belongs_to :currency,                   readonly: true
 
       has_many :invoice_line_items, embedded: true
 
       attribute :invoice_number,  String
+      attribute :order_number,    String,     readonly: true
       attribute :invoiced_at,     Date
       attribute :due_at,          Date
       attribute :notes,           String
@@ -23,7 +28,6 @@ module Gecko
     end
 
     class InvoiceAdapter < BaseAdapter
-
     end
   end
 end

data/lib/gecko/record/invoice_line_item.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gecko/record/base'
 
 module Gecko
@@ -13,7 +15,6 @@ module Gecko
     end
 
     class InvoiceLineItemAdapter < BaseAdapter
-
     end
   end
 end

data/lib/gecko/record/location.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gecko/record/base'
 
 module Gecko

data/lib/gecko/record/note.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gecko/record/base'
 
 module Gecko

data/lib/gecko/record/order.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gecko/record/base'
 
 module Gecko

data/lib/gecko/record/order_line_item.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gecko/record/base'
 
 module Gecko
@@ -39,6 +41,7 @@ module Gecko
 
       def discount_multiplier
         return 1 unless discount
+
         1 - discount / 100
       end
     end

data/lib/gecko/record/payment_term.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gecko/record/base'
 
 module Gecko
@@ -10,7 +12,6 @@ module Gecko
     end
 
     class PaymentTermAdapter < BaseAdapter
-
     end
   end
 end

data/lib/gecko/record/product.rb

@@ -1,9 +1,13 @@
+# frozen_string_literal: true
+
 require 'gecko/record/base'
 
 module Gecko
   module Record
     class Product < Base
       has_many :variants
+      has_many :images
+
       attribute :name,         String
       attribute :description,  String
       attribute :product_type, String

data/lib/gecko/record/purchase_order.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gecko/record/base'
 
 module Gecko
@@ -38,7 +40,6 @@ module Gecko
     end
 
     class PurchaseOrderAdapter < BaseAdapter
-
     end
   end
 end

data/lib/gecko/record/purchase_order_line_item.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gecko/record/base'
 
 module Gecko
@@ -23,7 +25,6 @@ module Gecko
     end
 
     class PurchaseOrderLineItemAdapter < BaseAdapter
-
     end
   end
 end

data/lib/gecko/record/tax_type.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gecko/record/base'
 
 module Gecko
@@ -13,7 +15,6 @@ module Gecko
     end
 
     class TaxTypeAdapter < BaseAdapter
-
     end
   end
 end

data/lib/gecko/record/user.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'gecko/record/base'
 
 module Gecko
@@ -32,7 +34,7 @@ module Gecko
       #
       # @api public
       def current
-        if self.has_record_for_id?(:current)
+        if has_record_for_id?(:current)
           record_for_id(:current)
         else
           @identity_map[:current] = find(:current)