games_dice 0.3.12 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: d19dba764a16a41817baaa3ccfd957f79433c9b0
-  data.tar.gz: 29037036e7fe3d1f5456e66bec3d8675a2434eaa
+SHA256:
+  metadata.gz: 7c1046747fdad80e794bb7883aaaade1a14e737a39641b6e85e7c179e96a3375
+  data.tar.gz: 54b1c1aa41b58b53e8a72ad59f835de932fde926a038626a0df165605677300c
 SHA512:
-  metadata.gz: 8420089013a0439dd92199fc276bdb718ab4abb9e5cef872542b1d87d545ab53a9c382bb8ebb3d2fe7226816e3a1cd9b4a071e6659cc0ad7d0fbd959ef5135e8
-  data.tar.gz: 69c75770fc39c5d4ada410cf16397105e6020380a320a6023380786591b80a3a7f1ace3a00c3e0a21b665f1b6260303db5bfce223bc23d9712142ac3042190d1
+  metadata.gz: 60e56aa2b32a4550ae6334c372ad1a9b0a07820c8a58ae4ce07c0ae3d5721ff91b8422d3d2d52b690e387738d3ee5bb6a7c05bed2d40145b776ef9a9d6295c0c
+  data.tar.gz: 7a0e7c3759def3b6f482e4242ae23b770c50876fc26f5464bca4e77b91cbf64596c901c4eb9cc69e9eee351d63fa8978426ceae7125eb34aa7c3e0856a0a8e1e

data/.rubocop.yml

@@ -0,0 +1,15 @@
+AllCops:
+  TargetRubyVersion: 2.6.0
+  NewCops: enable
+
+Layout/LineLength:
+  Max: 120
+  
+Metrics/BlockLength:
+  IgnoredMethods:
+    - context
+    - describe
+    - shared_examples
+    - define
+  
+

data/.travis.yml

@@ -1,14 +1,11 @@
 language: ruby
+
 before_install:
  - gem install bundler
-rvm:
-  - "2.0.0"
-  - "2.1.0"
-  - "2.1.1"
-  - "2.1.4"
-  - "2.2.0"
-  - "2.3.1"
-  - "2.4.1"
-  - "2.4.2"
-  - jruby-9.0.5.0
 
+os:
+  - linux
+
+rvm:
+  - "2.7.1"
+  - "3.0.0"

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # GamesDice Changelog
 
+## 0.4.0 ( 19 September 2021 )
+
+ * Dropping support for older Ruby versions (< 2.6)
+ * Native extensions are no longer optional, to reduce maintenance overhead. Effectively dropping support for JRuby.
+ * Tidy up code for maintainability (Rubocop and RSpec)
+
 ## 0.3.11 ( 26 May 2014 )
 
  * Bugfix. Actually use custom PRNG passed to GamesDice.create or GamesDice::Bunch.new

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Dependencies are in games_dice.gemspec

data/Rakefile

@@ -1,16 +1,19 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+# frozen_string_literal: true
+
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 require 'rake/extensiontask'
-require "yard"
+require 'yard'
 
 def can_compile_extensions
   return false if RUBY_DESCRIPTION =~ /jruby/
-  return true
+
+  true
 end
 
-desc "GamesDice unit tests"
+desc 'GamesDice unit tests'
 RSpec::Core::RakeTask.new(:test) do |t|
-  t.pattern = "spec/*_spec.rb"
+  t.pattern = 'spec/*_spec.rb'
   t.verbose = false
 end
 
@@ -21,20 +24,20 @@ end
 gemspec = Gem::Specification.load('games_dice.gemspec')
 Rake::ExtensionTask.new do |ext|
   ext.name = 'games_dice'
-  ext.source_pattern = "*.{c,h}"
+  ext.source_pattern = '*.{c,h}'
   ext.ext_dir = 'ext/games_dice'
   ext.lib_dir = 'lib/games_dice'
   ext.gem_spec = gemspec
 end
 
-task :delete_compiled_ext do |t|
+task :delete_compiled_ext do |_t|
   `rm lib/games_dice/games_dice.*`
 end
 
-task :pure_test => [:delete_compiled_ext, :test]
+task pure_test: %i[delete_compiled_ext test]
 
 if can_compile_extensions
-  task :default => [:compile, :test]
+  task default: %i[compile test]
 else
-  task :default => [:test]
+  task default: [:test]
 end

data/ext/games_dice/extconf.rb

@@ -1,25 +1,7 @@
-# ext/games_dice/extconf.rb
-can_compile_extensions = false
-want_extensions = true
-
-begin
-  require 'mkmf'
-  can_compile_extensions = true
-rescue Exception
-  # This will appear only in verbose mode.
-  $stderr.puts "Could not require 'mkmf'. Not fatal: The extensions are optional."
-end
+# frozen_string_literal: true
 
+# ext/games_dice/extconf.rb
 
-if can_compile_extensions && want_extensions
-  create_makefile( 'games_dice/games_dice' )
-
-else
-  # Create a dummy Makefile, to satisfy Gem::Installer#install
-  mfile = open("Makefile", "wb")
-  mfile.puts '.PHONY: install'
-  mfile.puts 'install:'
-  mfile.puts "\t" + '@echo "Extensions not installed, falling back to pure Ruby version."'
-  mfile.close
+require 'mkmf'
 
-end
+create_makefile('games_dice/games_dice')

data/ext/games_dice/probabilities.c

@@ -472,7 +472,7 @@ ProbabilityList *pl_repeat_n_sum_k( ProbabilityList *pl, int n, int k, int kbest
   pl_result->offset = pl->offset * k;
 
   for ( i = 0; i < pl->slots; i++ ) {
-    if ( ! pl->probs[i] > 0.0 ) continue;
+    if ( pl->probs[i] <= 0.0 ) continue;
 
     q = i + pl->offset;
     calc_keep_distributions( pl, k, q, kbest, keep_distributions );

data/games_dice.gemspec

@@ -1,46 +1,40 @@
-# -*- encoding: utf-8 -*-
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+require 'English'
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'games_dice/version'
 
 Gem::Specification.new do |gem|
-  gem.name          = "games_dice"
+  gem.name          = 'games_dice'
   gem.version       = GamesDice::VERSION
-  gem.authors       = ["Neil Slater"]
-  gem.email         = ["slobo777@gmail.com"]
-  gem.description   = %q{A library for simulating dice. Use it to construct dice-rolling systems used in role-playing and board games.}
-  gem.summary       = %q{Simulates and explains dice rolls from simple "1d6" to complex "roll 7 ten-sided dice, take best 3,
-                        results of 10 roll again and add on".}
-  gem.homepage      = "https://github.com/neilslater/games_dice"
-  gem.license       = "MIT"
-
-  gem.add_development_dependency "rspec", ">= 2.13.0"
-  gem.add_development_dependency "rake", ">= 1.9.1"
-  gem.add_development_dependency "yard", ">= 0.8.6"
-  gem.add_development_dependency "coveralls", ">= 0.6.7"
-  gem.add_development_dependency "json", ">= 1.7.7"
-  gem.add_development_dependency "rake-compiler", ">= 0.8.3"
-  if RUBY_VERSION <= "1.9.2"
-    gem.add_development_dependency "mime-types", "< 2.0.0"
-  end
+  gem.authors       = ['Neil Slater']
+  gem.email         = ['slobo777@gmail.com']
+  gem.description   = 'A library for simulating dice. Use it to construct dice-rolling systems used in role-playing and board games.'
+  gem.summary       = 'Simulates and explains dice rolls from simple "1d6" to complex "roll 7 ten-sided dice, take best 3,
+                        results of 10 roll again and add on".'
+  gem.homepage      = 'https://github.com/neilslater/games_dice'
+  gem.license       = 'MIT'
 
+  gem.required_ruby_version = '>= 2.6.0'
+  gem.add_development_dependency 'coveralls', '>= 0.6.7'
+  gem.add_development_dependency 'json', '>= 1.7.7'
+  gem.add_development_dependency 'rake', '>= 1.9.1'
+  gem.add_development_dependency 'rake-compiler', '>= 0.8.3'
+  gem.add_development_dependency 'rspec', '>= 2.13.0'
+  gem.add_development_dependency 'rubocop', '>= 1.2.1'
+  gem.add_development_dependency 'yard', '>= 0.8.6'
 
   # Red Carpet renders README.md, and is optional even when developing the gem.
-  # However, it has a C extension, and v3.0.0 is does not compile for 1.8.7. This only affects the gem build process, so
+  # However, it has a C extension, which will not work in JRuby. This only affects the gem build process, so
   # is only really used in environments like Travis, and is safe to wrap like this in the gemspec.
-  if RUBY_DESCRIPTION !~ /jruby/
-    if RUBY_VERSION >= "1.9.0"
-      gem.add_development_dependency "redcarpet", ">=2.3.0"
-    else
-      gem.add_development_dependency "redcarpet", ">=2.3.0", "<3.0.0"
-    end
-  end
+  gem.add_development_dependency 'redcarpet', '>=3.5.1' if RUBY_DESCRIPTION !~ /jruby/
 
-  gem.add_dependency "parslet", ">= 1.5.0"
+  gem.add_dependency 'parslet', '>= 1.5.0'
 
-  gem.files         = `git ls-files`.split($/)
-  gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
+  gem.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
+  gem.executables   = gem.files.grep(%r{^bin/}).map { |f| File.basename(f) }
   gem.extensions    = gem.files.grep(%r{/extconf\.rb$})
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
-  gem.require_paths = ["lib"]
+  gem.require_paths = ['lib']
 end