gamerom 0.3.0 → 0.4.0

data/lib/gamerom/repo_adapters/vimm.rb

@@ -3,12 +3,13 @@
 require 'mechanize'
 require 'mechanize/progressbar'
 require 'mechanizeprogress'
-require 'nokogiri'
-require 'rest-client'
 
 module Gamerom
   module RepoAdapters
+    # Vimm - An adapter for the Vimm's Lair repository website
     class Vimm
+      extend Gamerom::RepoAdapter
+
       PLATFORM = {
         'Dreamcast' => 'Dreamcast',
         'DS' => 'Nintendo DS',
@@ -27,29 +28,30 @@ module Gamerom
         'SNES' => 'Super Nintendo',
         'Wii' => 'Wii',
         'WiiWare' => 'WiiWare',
-      }
+      }.freeze
 
       def self.platforms
         PLATFORM
       end
 
-      def self.games(platform)
-        games = []
-        sections = ('a'..'z').to_a.unshift("number")
-        progress_bar = ProgressBar.new(platform, sections.count)
+      def self.sections
+        ('a'..'z').to_a.unshift('number')
+      end
+
+      def self.extract_games(platform)
         sections.each_with_index do |section, index|
-          page = Nokogiri::HTML(RestClient.get("https://vimm.net/vault/?p=list&system=#{platform}&section=#{section}"))
-          games.append *page.css('table.hovertable td:first-child a:first-child').map { |game|
-            {
-              id: game['href'].split('/').last.to_i,
-              name: game.text,
-              region: 'USA',
-            }
-          }
-          progress_bar.set(index+1)
+          page = nokogiri_get("https://vimm.net/vault/?p=list&system=#{platform}&section=#{section}")
+          game_links = page.css('table.hovertable td:first-child a:first-child')
+          yield game_links.map { |game_link| game(game_link) }, index
         end
-        progress_bar.finish
-        games
+      end
+
+      def self.game(game_link)
+        {
+          id: game_link['href'].split('/').last.to_i,
+          name: game_link.text,
+          region: 'USA',
+        }
       end
 
       def self.install(game)
@@ -58,7 +60,7 @@ module Gamerom
         agent.pluggable_parser.default = Mechanize::Download
         agent.user_agent = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.93 Safari/537.36'
         page = agent.get("https://vimm.net/vault/#{game.id}")
-        form = page.form_with(:id => 'download_form')
+        form = page.form_with(id: 'download_form')
 
         filenames = []
         game_files = []
@@ -67,24 +69,25 @@ module Gamerom
         if multiple_disks.empty?
           game_files << { id: form['mediaId'], name: 'single file rom' }
         else
-          puts "multiple discs detected"
-          game_files.concat multiple_disks.children[1..-2].map { |disk| { name: disk.text, id: disk['value']} }
+          puts 'multiple discs detected'
+          game_files.concat(multiple_disks.children[1..-2].map { |disk| { name: disk.text, id: disk['value'] } })
         end
 
         game_files.each do |game_file|
           puts "downloading #{game_file[:name]}"
           form.method = 'GET'
-          button = form.button_with(:type => "submit")
+          button = form.button_with(type: 'submit')
           response = nil
           form['mediaId'] = game_file[:id]
-          agent.progressbar{
+          agent.progressbar do
             response = form.click_button(button)
-          }
-          if response.code.to_i == 200
-            filename = response.filename
-            response.save!("#{game.filepath}/#{filename}")
-            filenames << filename
           end
+
+          break unless response.code.to_i == 200
+
+          filename = response.filename
+          response.save!("#{game.filepath}/#{filename}")
+          filenames << filename
         end
         yield filenames
       end

data/lib/gamerom/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Gamerom
-  VERSION = "0.3.0"
+  VERSION = '0.4.0'
 end

data/lib/mechanizeprogress.rb

@@ -1,21 +1,25 @@
+# frozen_string_literal: true
+
+# Mechanize - A Monkeypatch for the mechanize progressbar
 class Mechanize
   include MechanizeProgressBarAPI # (1of7)a
   class HTTP
+    # Agent - A Monkeypatch for the mechanize progressbar
     class Agent
-      def response_read response, request, uri = nil
+      def response_read(response, request, _uri = nil)
         body_io = StringIO.new
         body_io.set_encoding Encoding::BINARY if body_io.respond_to? :set_encoding
         total = 0
-        mpbar = MechanizeProgressBar.new(self.context, request, response) # (2of7)a
+        mpbar = MechanizeProgressBar.new(context, request, response) # (2of7)a
 
         begin
-          response.read_body { |part|
+          response.read_body do |part|
             total += part.length
             body_io.write(part)
-#           log.debug("Read #{part.length} bytes (#{total} total)") if log
+            # log.debug("Read #{part.length} bytes (#{total} total)") if log
             log.debug("Read #{part.length} bytes (#{total} total)") if log && !mpbar.suppress_logger? # (3of7)m
             mpbar.inc(part.length) # (4of7)a
-          }
+          end
         rescue Net::HTTP::Persistent::Error => e
           body_io.rewind
           raise Mechanize::ResponseReadError.new(e, response, body_io)
@@ -27,14 +31,14 @@ class Mechanize
         log.debug("Read #{total} bytes total") if log && !mpbar.suppress_logger? # (7of7)a
 
         raise Mechanize::ResponseCodeError, response if
-          Net::HTTPUnknownResponse === response
+          Net::HTTPUnknownResponse == response
 
         content_length = response.content_length
 
-        unless Net::HTTP::Head === request or Net::HTTPRedirection === response then
-          raise EOFError, "Content-Length (#{content_length}) does not match " \
-          "response body length (#{body_io.length})" if
-            content_length and content_length != body_io.length
+        unless Net::HTTP::Head == request || Net::HTTPRedirection == response
+          if content_length && content_length != body_io.length
+            raise EOFError, "Content-Length (#{content_length}) does not match response body length (#{body_io.length})"
+          end
         end
 
         body_io

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gamerom
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Lucas Mundim
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-05-14 00:00:00.000000000 Z
+date: 2021-05-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mechanize
@@ -118,6 +118,7 @@ files:
 - Rakefile
 - bin/console
 - bin/setup
+- entrypoint.sh
 - exe/gamerom
 - gamerom.gemspec
 - lib/gamerom.rb
@@ -126,6 +127,7 @@ files:
 - lib/gamerom/game.rb
 - lib/gamerom/game_info.rb
 - lib/gamerom/repo.rb
+- lib/gamerom/repo_adapter.rb
 - lib/gamerom/repo_adapters/coolrom.rb
 - lib/gamerom/repo_adapters/romnation.rb
 - lib/gamerom/repo_adapters/vimm.rb
@@ -147,14 +149,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 3.0.0
+      version: 3.0.1
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
+rubygems_version: 3.2.15
 signing_key:
 specification_version: 4
 summary: The Video Game ROM downloader