gamerom 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4f51e93d7f99ee967817de3ac803470be484e9223574971e39e594c23e457fed
-  data.tar.gz: 0cfbfa5e0712c540e2e7e175b274e1d0f4501214f88c68b00833277561e2ae19
+  metadata.gz: eca8f221edcd2f3f8e311f084c3c4afbf93f642a7e0d4c4731d0af2f758271b7
+  data.tar.gz: 8fb301ca2d507dd9a1000496a7b41a65c5a853a1f29c047525d082eca2ddf548
 SHA512:
-  metadata.gz: 835103d42c4c74a0593bfc7b8d2362dd8b95dc04ccfc1fc8d01bad508193ea6aeaac940479e5acc003db52310e5f7e5b9f70239ad5a452ae0a6ccef9dc85d060
-  data.tar.gz: f1697e783df89bedb5437bcc54473d0fea2074f2b7a5794460ad8a8c5e08d78e449193a77eed645ea48a3f323608f3d81ea843863b0a34ea4a045462805e1471
+  metadata.gz: b438895a5ca17cb390bc7f7cc49de3f3b730d2eb2ba5ba0cecf0cc5f075b08f1fa5a2f4332c5407c74878d65bcb8e47d8e7a2bd8d2fd454d1f018c6890c53769
+  data.tar.gz: f838766967003016f1830c1ebc80d12540347c3f1e0ed4f7a74df0973afaf0df4a5a1a7c8079f6310949783a0755e5c38ec59568e7cfa1ffad4fe1ebaffe5e35

data/.github/workflows/main.yml

@@ -10,7 +10,7 @@ jobs:
     - name: Set up Ruby
       uses: ruby/setup-ruby@v1
       with:
-        ruby-version: 3.0.0
+        ruby-version: 3.0.1
     - name: Run the default task
       run: |
         gem install bundler -v 2.2.3

data/.rubocop.yml

@@ -1,10 +1,43 @@
+AllCops:
+  NewCops: enable
+
 Style/StringLiterals:
   Enabled: true
-  EnforcedStyle: double_quotes
+  EnforcedStyle: single_quotes
 
 Style/StringLiteralsInInterpolation:
   Enabled: true
   EnforcedStyle: double_quotes
 
+Style/TrailingCommaInHashLiteral:
+  Enabled: false
+
 Layout/LineLength:
-  Max: 120
+  Max: 150
+
+Metrics/MethodLength:
+  Max: 500
+
+Metrics/ClassLength:
+  Max: 500
+
+Metrics/BlockLength:
+  Max: 100
+
+Metrics/AbcSize:
+  Enabled: false
+
+Metrics/CyclomaticComplexity:
+  Enabled: true
+  Exclude:
+    - 'lib/mechanizeprogress.rb'
+
+Metrics/PerceivedComplexity:
+  Enabled: true
+  Exclude:
+    - 'lib/mechanizeprogress.rb'
+
+Style/SoleNestedConditional:
+  Enabled: true
+  Exclude:
+    - 'lib/mechanizeprogress.rb'

data/.ruby-version

@@ -1 +1 @@
-ruby-3.0.0
+ruby-3.0.1

data/CHANGELOG.md

@@ -6,6 +6,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.4.0] - 2021-05-18
+- Refactor code #2
+- Fix all rubocop errors/warnings
+- Run executable inside container as the same userID/groupID than host user
+- Fix info when game not found
+- Update to ruby version 3.0.1
+- Add `--install` option to search command for installing all games from the search results #3
+
 ## [0.3.0] - 2021-05-14
 - Use progress bar on the update database commands
 - Add romnation repo
@@ -23,7 +31,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [0.1.0] - 2021-05-07
 - Initial release
 
-[Unreleased]: https://github.com/lucasmundim/gamerom/compare/v0.3.0...HEAD
+[Unreleased]: https://github.com/lucasmundim/gamerom/compare/v0.4.0...HEAD
+[0.4.0]: https://github.com/lucasmundim/gamerom/compare/v0.3.0...v0.4.0
 [0.3.0]: https://github.com/lucasmundim/gamerom/compare/v0.2.2...v0.3.0
 [0.2.2]: https://github.com/lucasmundim/gamerom/compare/v0.2.1...v0.2.2
 [0.2.1]: https://github.com/lucasmundim/gamerom/compare/v0.2.0...v0.2.1

data/Dockerfile

@@ -1,4 +1,4 @@
-FROM ruby:3.0.0-alpine as build
+FROM ruby:3.0.1-alpine as build
 
 RUN apk add --no-cache --virtual .build-deps \
   build-base \
@@ -7,10 +7,15 @@ RUN apk add --no-cache --virtual .build-deps \
 # throw errors if Gemfile has been modified since Gemfile.lock
 RUN bundle config --global frozen 1
 
+RUN mkdir -p /bundle && chmod 777 /bundle
+
+ENV GEM_HOME="/bundle"
+ENV PATH $GEM_HOME/bin:$GEM_HOME/gems/bin:$PATH
+
 RUN mkdir -p /app
 WORKDIR /app
 
 COPY . .
 RUN bundle install
 
-ENTRYPOINT ["bundle", "exec", "./exe/gamerom"]
+ENTRYPOINT ["/app/entrypoint.sh"]

data/Gemfile

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
 # Specify your gem's dependencies in gamerom.gemspec
 gemspec
 
-gem "rake", "~> 13.0"
+gem 'rake', '~> 13.0'
 
-gem "rspec", "~> 3.0"
+gem 'rspec', '~> 3.0'
 
-gem "rubocop", "~> 0.80"
+gem 'rubocop', '~> 0.80'

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    gamerom (0.3.0)
+    gamerom (0.4.0)
       mechanize (~> 2.8.0)
       mechanize-progressbar (~> 0.2.0)
       nokogiri (~> 1.11.3)
@@ -43,9 +43,9 @@ GEM
     net-http-persistent (4.0.1)
       connection_pool (~> 2.2)
     netrc (0.11.0)
-    nokogiri (1.11.3-x86_64-darwin)
+    nokogiri (1.11.4-x86_64-darwin)
       racc (~> 1.4)
-    nokogiri (1.11.3-x86_64-linux)
+    nokogiri (1.11.4-x86_64-linux)
       racc (~> 1.4)
     parallel (1.20.1)
     parser (3.0.1.0)
@@ -107,4 +107,4 @@ DEPENDENCIES
   rubocop (~> 0.80)
 
 BUNDLED WITH
-   2.2.3
+   2.2.15

data/Makefile

@@ -1,4 +1,4 @@
-VERSION:=$(shell cat lib/gamerom/version.rb |grep VERSION|cut -d\" -f2)
+VERSION:=$(shell cat lib/gamerom/version.rb |grep VERSION|cut -d\' -f2)
 IMAGE=lucasmundim/gamerom:${VERSION}
 DOCKER_OPTS=--rm -it -v ${HOME}/.gamerom:/root/.gamerom ${IMAGE}
 LOCAL_VOLUME_OPTS=-v ${CURDIR}:/app

data/README.md

@@ -15,7 +15,7 @@ It currently supports the following repositories:
 Add this to your .bashrc, .bash_aliases, etc:
 
 ```
-alias gamerom='docker run --rm -it -v ~/.gamerom:/root/.gamerom docker.io/lucasmundim/gamerom:0.3.0'
+alias gamerom="docker run -e UID=$(id -u) -e GROUP_ID=$(id -g) --rm -it -v ~/.gamerom:/home/runuser/.gamerom docker.io/lucasmundim/gamerom:0.4.0"
 ```
 
 Use it as:
@@ -585,7 +585,7 @@ Print program version
 
 ```
 $ gamerom version
-0.3.0
+0.4.0
 ```
 
 ## Development

data/Rakefile

@@ -1,11 +1,11 @@
 # frozen_string_literal: true
 
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-require "rubocop/rake_task"
+require 'rubocop/rake_task'
 
 RuboCop::RakeTask.new
 

data/bin/console

@@ -1,8 +1,8 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
 
-require "bundler/setup"
-require "gamerom"
+require 'bundler/setup'
+require 'gamerom'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -11,5 +11,5 @@ require "gamerom"
 # require "pry"
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start(__FILE__)

data/entrypoint.sh

@@ -0,0 +1,6 @@
+#!/bin/sh
+delgroup dialout
+addgroup -g "$GROUP_ID" rungroup
+adduser -u $UID -D -s /bin/sh -G rungroup runuser
+command="cd /app && GEM_HOME="/bundle" PATH=$GEM_HOME/bin:$GEM_HOME/gems/bin:$PATH bundle exec ./exe/gamerom ${@}"
+su - runuser -c "$command"

data/exe/gamerom

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
-require "gamerom"
+require 'gamerom'
 
 Gamerom::Cli.start(ARGV)

data/gamerom.gemspec

@@ -1,40 +1,40 @@
 # frozen_string_literal: true
 
-require_relative "lib/gamerom/version"
+require_relative 'lib/gamerom/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "gamerom"
+  spec.name          = 'gamerom'
   spec.version       = Gamerom::VERSION
-  spec.authors       = ["Lucas Mundim"]
-  spec.email         = ["lucas.mundim@gmail.com"]
+  spec.authors       = ['Lucas Mundim']
+  spec.email         = ['lucas.mundim@gmail.com']
 
-  spec.summary       = "The Video Game ROM downloader"
-  spec.description   = "A command-line installer for game ROMs from many repositories."
-  spec.homepage      = "https://github.com/lucasmundim/gamerom"
-  spec.license       = "MIT"
-  spec.required_ruby_version = Gem::Requirement.new(">= 3.0.0")
+  spec.summary       = 'The Video Game ROM downloader'
+  spec.description   = 'A command-line installer for game ROMs from many repositories.'
+  spec.homepage      = 'https://github.com/lucasmundim/gamerom'
+  spec.license       = 'MIT'
+  spec.required_ruby_version = Gem::Requirement.new('>= 3.0.1')
 
-  spec.metadata["allowed_push_host"] = "https://rubygems.org"
+  spec.metadata['allowed_push_host'] = 'https://rubygems.org'
 
-  spec.metadata["homepage_uri"] = spec.homepage
-  spec.metadata["source_code_uri"] = spec.homepage
-  spec.metadata["changelog_uri"] = "#{spec.homepage}/blob/master/CHANGELOG.md"
+  spec.metadata['homepage_uri'] = spec.homepage
+  spec.metadata['source_code_uri'] = spec.homepage
+  spec.metadata['changelog_uri'] = "#{spec.homepage}/blob/master/CHANGELOG.md"
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
   spec.files = Dir.chdir(File.expand_path(__dir__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{\A(?:test|spec|features)/}) }
   end
-  spec.bindir        = "exe"
+  spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
-
-  spec.add_runtime_dependency "mechanize", "~> 2.8.0"
-  spec.add_runtime_dependency "mechanize-progressbar", "~> 0.2.0"
-  spec.add_runtime_dependency "nokogiri", "~> 1.11.3"
-  spec.add_runtime_dependency "progressbar", "~> 0.9.0"
-  spec.add_runtime_dependency "rest-client", "~> 2.1.0"
-  spec.add_runtime_dependency "thor", "~> 1.1.0"
+  spec.require_paths = ['lib']
+
+  spec.add_runtime_dependency 'mechanize', '~> 2.8.0'
+  spec.add_runtime_dependency 'mechanize-progressbar', '~> 0.2.0'
+  spec.add_runtime_dependency 'nokogiri', '~> 1.11.3'
+  spec.add_runtime_dependency 'progressbar', '~> 0.9.0'
+  spec.add_runtime_dependency 'rest-client', '~> 2.1.0'
+  spec.add_runtime_dependency 'thor', '~> 1.1.0'
 
   # For more information and examples about making a new gem, checkout our
   # guide at: https://bundler.io/guides/creating_gem.html

data/lib/gamerom.rb

@@ -1,11 +1,11 @@
 # frozen_string_literal: true
 
-require_relative "gamerom/config"
-require_relative "gamerom/game"
-require_relative "gamerom/game_info"
-require_relative "gamerom/repo"
-require_relative "gamerom/cli"
-require_relative "gamerom/version"
+require_relative 'gamerom/config'
+require_relative 'gamerom/game'
+require_relative 'gamerom/game_info'
+require_relative 'gamerom/repo'
+require_relative 'gamerom/cli'
+require_relative 'gamerom/version'
 
 module Gamerom
   class Error < StandardError; end

data/lib/gamerom/cli.rb

@@ -3,8 +3,9 @@
 require 'thor'
 
 module Gamerom
+  # Cli - Main cli commands
   class Cli < Thor
-    class_option :verbose, :aliases => ['-v'], :type => :boolean, default: false, desc: "Show verbose backtrace"
+    class_option :verbose, aliases: ['-v'], type: :boolean, default: false, desc: 'Show verbose backtrace'
 
     def self.exit_on_failure?
       true
@@ -22,26 +23,27 @@ module Gamerom
     end
 
     desc 'info GAME_IDENTIFIER', 'Info for game GAME_IDENTIFIER (id/name)'
-    option :repo, :aliases => ['-r'], type: :string, required: true, desc: "Which repo to use", enum: Gamerom::Repo.list.map(&:to_s)
-    option :platform, :aliases => ['-p'], type: :string, required: true, desc: "Which platform to use"
+    option :repo, aliases: ['-r'], type: :string, required: true, desc: 'Which repo to use', enum: Gamerom::Repo.list.map(&:to_s)
+    option :platform, aliases: ['-p'], type: :string, required: true, desc: 'Which platform to use'
     def info(game_identifier)
       repo = Repo.new(options[:repo])
       validate_platform repo, options[:platform]
       puts "showing info for game #{game_identifier} on #{options[:platform]} platform on #{options[:repo]} repo..."
       game = repo.find(options[:platform], game_identifier)
-      if game.nil?
+      if !game.nil?
+        puts game
+        puts game.filenames if game.installed?
+      else
         shell.say "Game #{game_identifier} not found", :red
       end
-      puts game
-      puts game.filenames if game.installed?
-    rescue => e
+    rescue StandardError => e
       render_error e, options
       exit 1
     end
 
     desc 'install GAME_IDENTIFIER', 'Install game GAME_IDENTIFIER (id/name)'
-    option :repo, :aliases => ['-r'], type: :string, required: true, desc: "Which repo to use", enum: Gamerom::Repo.list.map(&:to_s)
-    option :platform, :aliases => ['-p'], type: :string, required: true, desc: "Which platform to use"
+    option :repo, aliases: ['-r'], type: :string, required: true, desc: 'Which repo to use', enum: Gamerom::Repo.list.map(&:to_s)
+    option :platform, aliases: ['-p'], type: :string, required: true, desc: 'Which platform to use'
     def install(game_identifier)
       repo = Repo.new(options[:repo])
       validate_platform repo, options[:platform]
@@ -52,20 +54,20 @@ module Gamerom
       end
       puts "installing game #{game.id} - #{game.name} - #{game.region} on #{options[:platform]} platform on #{options[:repo]} repo..."
       if game.installed?
-        shell.say "Game already installed", :yellow
+        shell.say 'Game already installed', :yellow
         return
       end
       game.install
-      shell.say "Game installed", :green
-    rescue => e
+      shell.say 'Game installed', :green
+    rescue StandardError => e
       render_error e, options
       exit 1
     end
 
     desc 'install_all', 'Install all games'
-    option :repo, :aliases => ['-r'], type: :string, required: true, desc: "Which repo to use", enum: Gamerom::Repo.list.map(&:to_s)
-    option :platform, :aliases => ['-p'], type: :string, required: true, desc: "Which platform to use"
-    option :region, :aliases => ['-g'], type: :string, required: false, desc: "Only from specified region"
+    option :repo, aliases: ['-r'], type: :string, required: true, desc: 'Which repo to use', enum: Gamerom::Repo.list.map(&:to_s)
+    option :platform, aliases: ['-p'], type: :string, required: true, desc: 'Which platform to use'
+    option :region, aliases: ['-g'], type: :string, required: false, desc: 'Only from specified region'
     def install_all
       repo = Repo.new(options[:repo])
       validate_platform repo, options[:platform]
@@ -73,40 +75,40 @@ module Gamerom
       games.each do |game|
         install(game.id) unless game.installed?
       end
-    rescue => e
+    rescue StandardError => e
       render_error e, options
       exit 1
     end
 
     desc 'list', 'List available games'
-    option :repo, :aliases => ['-r'], type: :string, required: true, desc: "Which repo to use", enum: Gamerom::Repo.list.map(&:to_s)
-    option :platform, :aliases => ['-p'], type: :string, required: true, desc: "Which platform to use"
-    option :region, :aliases => ['-g'], type: :string, required: false, desc: "Only from specified region"
+    option :repo, aliases: ['-r'], type: :string, required: true, desc: 'Which repo to use', enum: Gamerom::Repo.list.map(&:to_s)
+    option :platform, aliases: ['-p'], type: :string, required: true, desc: 'Which platform to use'
+    option :region, aliases: ['-g'], type: :string, required: false, desc: 'Only from specified region'
     def list
       repo = Repo.new(options[:repo])
       validate_platform repo, options[:platform]
       puts "listing available games for #{options[:platform]} platform on #{options[:repo]} repo..."
       games = repo.games options[:platform], region: options[:region]
       print_game_table(games)
-    rescue => e
+    rescue StandardError => e
       render_error e, options
       exit 1
     end
 
     desc 'platforms', 'List available platforms'
-    option :repo, :aliases => ['-r'], type: :string, required: true, desc: "Which repo to use", enum: Gamerom::Repo.list.map(&:to_s)
+    option :repo, aliases: ['-r'], type: :string, required: true, desc: 'Which repo to use', enum: Gamerom::Repo.list.map(&:to_s)
     def platforms
       puts "listing available platforms for #{options[:repo]} repo..."
       platforms = { platforms: Repo.new(options[:repo]).platforms }
       puts platforms.to_yaml
-    rescue => e
+    rescue StandardError => e
       render_error e, options
       exit 1
     end
 
     desc 'recover', 'Try to recover state from already downloaded roms'
-    option :repo, :aliases => ['-r'], type: :string, required: true, desc: "Which repo to use", enum: Gamerom::Repo.list.map(&:to_s)
-    option :platform, :aliases => ['-p'], type: :string, required: true, desc: "Which platform to use"
+    option :repo, aliases: ['-r'], type: :string, required: true, desc: 'Which repo to use', enum: Gamerom::Repo.list.map(&:to_s)
+    option :platform, aliases: ['-p'], type: :string, required: true, desc: 'Which platform to use'
     def recover
       repo = Repo.new(options[:repo])
       validate_platform repo, options[:platform]
@@ -116,10 +118,9 @@ module Gamerom
       games.each do |game|
         filename = nil
         basename = "#{Gamerom::GAME_DIR}/#{repo.name}/#{options[:platform]}/#{game[:region]}/#{game[:name]}"
-        ['zip', '7z', 'rar'].each do |ext|
-          if File.exists? "#{basename}.#{ext}"
-            filename = "#{basename}.#{ext}"
-          end
+        %w[zip 7z rar].each do |ext|
+          fullname = "#{basename}.#{ext}"
+          filename = fullname if File.exist? fullname
         end
 
         if filename
@@ -129,100 +130,107 @@ module Gamerom
           games_not_found << game[:name]
         end
       end
-      if games_not_found.count > 0
-        puts "Games not found:"
+      if games_not_found.count.positive?
+        puts 'Games not found:'
         puts games_not_found
       end
-    rescue => e
+    rescue StandardError => e
       puts e.message
       exit 1
     end
 
     desc 'regions', 'List available regions'
-    option :repo, :aliases => ['-r'], type: :string, required: true, desc: "Which repo to use", enum: Gamerom::Repo.list.map(&:to_s)
-    option :platform, :aliases => ['-p'], type: :string, required: true, desc: "Which platform to use"
+    option :repo, aliases: ['-r'], type: :string, required: true, desc: 'Which repo to use', enum: Gamerom::Repo.list.map(&:to_s)
+    option :platform, aliases: ['-p'], type: :string, required: true, desc: 'Which platform to use'
     def regions
       repo = Repo.new(options[:repo])
       validate_platform repo, options[:platform]
       puts "listing available regions for #{options[:platform]} platform on #{options[:repo]} repo..."
       puts repo.regions options[:platform]
-    rescue => e
+    rescue StandardError => e
       render_error e, options
       exit 1
     end
 
     desc 'repo', 'List available repo'
     def repo
-      puts "listing available repo..."
+      puts 'listing available repo...'
       puts Repo.list
-    rescue => e
+    rescue StandardError => e
       render_error e, options
       exit 1
     end
 
     desc 'search KEYWORD', 'Search games by KEYWORD'
-    option :repo, :aliases => ['-r'], type: :string, required: true, desc: "Which repo to use", enum: Gamerom::Repo.list.map(&:to_s)
-    option :platform, :aliases => ['-p'], type: :string, required: true, desc: "Which platform to use"
-    option :region, :aliases => ['-g'], type: :string, required: false, desc: "Only from specified region"
+    option :repo, aliases: ['-r'], type: :string, required: true, desc: 'Which repo to use', enum: Gamerom::Repo.list.map(&:to_s)
+    option :platform, aliases: ['-p'], type: :string, required: true, desc: 'Which platform to use'
+    option :region, aliases: ['-g'], type: :string, required: false, desc: 'Only from specified region'
+    option :install, aliases: ['-I'], type: :boolean, required: false, desc: 'Install search results'
     def search(keyword)
       repo = Repo.new(options[:repo])
       validate_platform repo, options[:platform]
       puts "searching available games for #{options[:platform]} platform on #{options[:repo]} repo..."
       games = repo.games options[:platform], region: options[:region], keyword: keyword
-      print_game_table(games)
-    rescue => e
+      if options[:install]
+        games.each do |game|
+          install(game.id) unless game.installed?
+        end
+      else
+        print_game_table(games)
+      end
+    rescue StandardError => e
       render_error e, options
       exit 1
     end
 
     desc 'stats', 'Show platform stats'
-    option :repo, :aliases => ['-r'], type: :string, required: true, desc: "Which repo to use", enum: Gamerom::Repo.list.map(&:to_s)
-    option :platform, :aliases => ['-p'], type: :string, required: true, desc: "Which platform to use"
+    option :repo, aliases: ['-r'], type: :string, required: true, desc: 'Which repo to use', enum: Gamerom::Repo.list.map(&:to_s)
+    option :platform, aliases: ['-p'], type: :string, required: true, desc: 'Which platform to use'
     def stats
       repo = Repo.new(options[:repo])
       validate_platform repo, options[:platform]
       puts "stats for #{options[:platform]} platform on #{options[:repo]} repo..."
       games = repo.games options[:platform]
       total = games.count
-      installed = games.select { |game| game.installed? }.count
+      installed = games.select(&:installed?).count
       size = 0
-      if File.exists? "#{Gamerom::GAME_DIR}/#{repo.name}/#{options[:platform]}"
+      if File.exist? "#{Gamerom::GAME_DIR}/#{repo.name}/#{options[:platform]}"
         size = `du -hs "#{Gamerom::GAME_DIR}/#{repo.name}/#{options[:platform]}/"|awk '{ print $1 }'`
       end
       puts "  All: #{installed}/#{total} - size: #{size}"
       repo.regions(options[:platform]).each do |region|
         games = repo.games(options[:platform], region: region)
         total = games.count
-        installed = games.select { |game| game.installed? }.count
+        installed = games.select(&:installed?).count
         size = 0
-        if File.exists? "#{Gamerom::GAME_DIR}/#{repo.name}/#{options[:platform]}/#{region}"
+        if File.exist? "#{Gamerom::GAME_DIR}/#{repo.name}/#{options[:platform]}/#{region}"
           size = `du -hs "#{Gamerom::GAME_DIR}/#{repo.name}/#{options[:platform]}/#{region}/"|awk '{ print $1 }'`
         end
         puts "  #{region}: #{installed}/#{total} - size: #{size}"
       end
       puts
-    rescue => e
+    rescue StandardError => e
       render_error e, options
       exit 1
     end
 
     desc 'stats_all', 'Show stats for all platforms'
-    option :repo, :aliases => ['-r'], type: :string, required: true, desc: "Which repo to use", enum: Gamerom::Repo.list.map(&:to_s)
+    option :repo, aliases: ['-r'], type: :string, required: true, desc: 'Which repo to use', enum: Gamerom::Repo.list.map(&:to_s)
     def stats_all
       repo = Repo.new(options[:repo])
-      repo.platforms.keys.each do |platform|
+      repo.platforms.each_key do |platform|
         a = Gamerom::Cli.new
         a.options = { platform: platform, repo: options[:repo] }
         a.stats
       end
-    rescue => e
+    rescue StandardError => e
       render_error e, options
       exit 1
     end
 
     desc 'uninstall GAME_IDENTIFIER', 'Uninstall game GAME_IDENTIFIER (id/name)'
-    option :repo, :aliases => ['-r'], type: :string, required: true, desc: "Which repo to use", enum: Gamerom::Repo.list.map(&:to_s)
-    option :platform, :aliases => ['-p'], type: :string, required: true, desc: "Which platform to use"
+    option :repo, aliases: ['-r'], type: :string, required: true, desc: 'Which repo to use', enum: Gamerom::Repo.list.map(&:to_s)
+    option :platform, aliases: ['-p'], type: :string, required: true, desc: 'Which platform to use'
     def uninstall(game_identifier)
       repo = Repo.new(options[:repo])
       validate_platform repo, options[:platform]
@@ -232,21 +240,21 @@ module Gamerom
         return
       end
       puts "uninstalling game #{game.id} - #{game.name} - #{game.region} on #{options[:platform]} platform..."
-      if !game.installed?
-        shell.say "Game is not installed", :yellow
+      unless game.installed?
+        shell.say 'Game is not installed', :yellow
         return
       end
       game.uninstall
-      shell.say "Game uninstalled", :green
-    rescue => e
+      shell.say 'Game uninstalled', :green
+    rescue StandardError => e
       render_error e, options
       exit 1
     end
 
     desc 'uninstall_all', 'Uninstall all games'
-    option :repo, :aliases => ['-r'], type: :string, required: true, desc: "Which repo to use", enum: Gamerom::Repo.list.map(&:to_s)
-    option :platform, :aliases => ['-p'], type: :string, required: true, desc: "Which platform to use"
-    option :region, :aliases => ['-g'], type: :string, required: false, desc: "Only from specified region"
+    option :repo, aliases: ['-r'], type: :string, required: true, desc: 'Which repo to use', enum: Gamerom::Repo.list.map(&:to_s)
+    option :platform, aliases: ['-p'], type: :string, required: true, desc: 'Which platform to use'
+    option :region, aliases: ['-g'], type: :string, required: false, desc: 'Only from specified region'
     def uninstall_all
       repo = Repo.new(options[:repo])
       validate_platform repo, options[:platform]
@@ -254,36 +262,36 @@ module Gamerom
       games.each do |game|
         uninstall(game.id) if game.installed?
       end
-    rescue => e
+    rescue StandardError => e
       render_error e, options
       exit 1
     end
 
     desc 'update_all_databases', 'Update all local databases'
-    option :repo, :aliases => ['-r'], type: :string, required: true, desc: "Which repo to use", enum: Gamerom::Repo.list.map(&:to_s)
+    option :repo, aliases: ['-r'], type: :string, required: true, desc: 'Which repo to use', enum: Gamerom::Repo.list.map(&:to_s)
     def update_all_databases
       puts "updating all databases on #{options[:repo]} repo..."
       repo = Repo.new(options[:repo])
-      repo.platforms.keys.each do |platform|
+      repo.platforms.each_key do |platform|
         repo = Repo.new(options[:repo])
         repo.update_database platform
       end
       shell.say 'All game databases updated', :green
-    rescue => e
+    rescue StandardError => e
       render_error e, options
       exit 1
     end
 
     desc 'update_database', 'Update local database'
-    option :repo, :aliases => ['-r'], type: :string, required: true, desc: "Which repo to use", enum: Gamerom::Repo.list.map(&:to_s)
-    option :platform, :aliases => ['-p'], type: :string, required: true, desc: "Which platform to use"
+    option :repo, aliases: ['-r'], type: :string, required: true, desc: 'Which repo to use', enum: Gamerom::Repo.list.map(&:to_s)
+    option :platform, aliases: ['-p'], type: :string, required: true, desc: 'Which platform to use'
     def update_database
       repo = Repo.new(options[:repo])
       validate_platform repo, options[:platform]
       puts "updating #{options[:platform]} platform on #{options[:repo]} repo..."
       repo.update_database options[:platform]
       shell.say "Game database updated for platform #{options[:platform]} on #{options[:repo]} repo", :green
-    rescue => e
+    rescue StandardError => e
       render_error e, options
       exit 1
     end
@@ -294,6 +302,7 @@ module Gamerom
     end
 
     private
+
     def print_game_table(games)
       results = []
 
@@ -303,21 +312,23 @@ module Gamerom
           game.name,
           game.region,
           game.installed? ? shell.set_color('installed', :green) : '-',
-          game.respond_to?(:tags) ? game.tags.join(", ") : '-'
+          game.respond_to?(:tags) ? game.tags.join(', ') : '-'
         ]
       end
       results.sort_by! { |columns| columns[1] }
-      results.unshift ['ID', 'NAME', 'REGION', 'INSTALLED', 'TAGS']
+      results.unshift %w[ID NAME REGION INSTALLED TAGS]
       shell.print_table(results)
     end
 
-    def render_error exception, options
+    def render_error(exception, options)
       shell.say exception.message, :red
       shell.say exception.full_message.force_encoding('utf-8'), :red if options[:verbose]
     end
 
     def validate_platform(repo, platform)
-      raise "Expected '--platform' to be one of #{repo.platforms.keys.join(', ')}; got #{platform}" if !repo.platforms.keys.include? options[:platform]
+      return if repo.platforms.keys.include? options[:platform]
+
+      raise "Expected '--platform' to be one of #{repo.platforms.keys.join(", ")}; got #{platform}"
     end
   end
 end