g5_authenticatable 0.9.1.pre.2 → 1.0.0.pre.1

data/spec/requests/grape_api_spec.rb

@@ -1,19 +1,21 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
-describe 'a secure Grape API' do
-  subject(:api_call) { get '/api/secure_resource' }
+require 'rails_helper'
+
+RSpec.describe 'a secure Grape API' do
+  subject(:api_call) { safe_get '/api/secure_resource' }
 
   context 'with an authenticated user', :auth_request do
     it 'should be successful' do
       api_call
-      expect(response).to be_http_ok
+      expect(response.status).to eq(200)
     end
   end
 
   context 'without an authenticated user' do
     it 'should be unauthorized' do
       api_call
-      expect(response).to be_http_unauthorized
+      expect(response.status).to eq(401)
     end
   end
 end

data/spec/requests/rails_api_spec.rb

@@ -1,44 +1,46 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
-describe 'a secure Rails API' do
+require 'rails_helper'
+
+RSpec.describe 'a secure Rails API' do
   describe 'POST request to an API-only action' do
-    subject(:api_call) { post '/rails_api/secure_resource' }
+    subject(:api_call) { safe_post '/rails_api/secure_resource' }
 
     context 'with an authenticated user', :auth_request do
       it 'should be successful' do
         api_call
-        expect(response).to be_http_ok
+        expect(response.status).to eq(200)
       end
     end
 
     context 'without an authenticated user' do
       it 'should be unauthorized' do
         api_call
-        expect(response).to be_http_unauthorized
+        expect(response.status).to eq(401)
       end
     end
   end
 
   describe 'GET json request to mixed API/website action' do
-    subject(:api_call) { get '/rails_api/secure_resource.json' }
+    subject(:api_call) { safe_get '/rails_api/secure_resource.json' }
 
     context 'with an authenticated user', :auth_request do
       it 'should be successful' do
         api_call
-        expect(response).to be_http_ok
+        expect(response.status).to eq(200)
       end
     end
 
     context 'without an authenticated user' do
       it 'should be unauthorized' do
         api_call
-        expect(response).to be_http_unauthorized
+        expect(response.status).to eq(401)
       end
     end
   end
 
   describe 'GET html request to mixed API/website action' do
-    subject(:website_call) { get '/rails_api/secure_resource.html' }
+    subject(:website_call) { safe_get '/rails_api/secure_resource.html' }
 
     it 'should be a redirect' do
       website_call

data/spec/requests/sign_out_spec.rb

@@ -1,16 +1,19 @@
-require 'spec_helper'
+# frozen_string_literal: true
+
+require 'rails_helper'
 
 # Normally, we'd do this as a feature spec, but there's
 # currently no easy way to get capybara to play along nicely
 # with mocks for external redirects (the capybara-mechanize driver
 # comes closest, but not quite)
-describe 'Signing out' do
+RSpec.describe 'Signing out' do
   let(:auth_sign_out_url) do
-    "#{ENV['G5_AUTH_ENDPOINT']}/users/sign_out?redirect_url=http%3A%2F%2Fwww.example.com%2F"
+    "#{ENV['G5_AUTH_ENDPOINT']}/users/sign_out" \
+      '?redirect_url=http%3A%2F%2Fwww.example.com%2F'
   end
 
   describe 'GET /g5_auth/users/sign_out' do
-    subject(:sign_out) { get '/g5_auth/users/sign_out' }
+    subject(:sign_out) { safe_get '/g5_auth/users/sign_out' }
 
     context 'when user is logged in', :auth_request do
       it 'should redirect to the auth server' do
@@ -19,7 +22,8 @@ describe 'Signing out' do
 
       it 'should not allow the user to access protected pages' do
         sign_out
-        expect(get '/protected_page').to redirect_to('/g5_auth/users/sign_in')
+        expect(safe_get('/protected_page'))
+          .to redirect_to('/g5_auth/users/sign_in')
       end
     end
 
@@ -31,7 +35,7 @@ describe 'Signing out' do
   end
 
   describe 'DELETE /g5_auth/users/sign_out', :auth_request do
-    subject(:sign_out) { delete '/g5_auth/users/sign_out' }
+    subject(:sign_out) { safe_delete '/g5_auth/users/sign_out' }
 
     it 'should redirect to GET' do
       expect(sign_out).to redirect_to('/g5_auth/users/sign_out')

data/spec/requests/token_validation_spec.rb

@@ -1,9 +1,13 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
-describe 'API Token validation' do
-  let(:token_info_url) { URI.join(ENV['G5_AUTH_ENDPOINT'], '/oauth/token/info') }
+require 'rails_helper'
 
-  subject(:api_call) { get '/rails_api/secure_resource.json' }
+RSpec.describe 'API Token validation' do
+  let(:token_info_url) do
+    URI.join(ENV['G5_AUTH_ENDPOINT'], '/oauth/token/info')
+  end
+
+  subject(:api_call) { safe_get '/rails_api/secure_resource.json' }
 
   context 'when token validation is enabled' do
     before { G5Authenticatable.strict_token_validation = true }
@@ -36,7 +40,7 @@ describe 'API Token validation' do
 
       it 'should return a 401' do
         api_call
-        expect(response).to be_http_unauthorized
+        expect(response.status).to eq(401)
       end
     end
 

data/spec/routing/auth_error_routing_spec.rb

@@ -1,15 +1,16 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
-describe G5Authenticatable::ErrorController do
-  routes {G5Authenticatable::Engine.routes}
+require 'rails_helper'
+
+RSpec.describe G5Authenticatable::ErrorController do
+  routes { G5Authenticatable::Engine.routes }
 
   it 'should route GET /g5_auth/auth_error path' do
-    expect(get: '/auth_error').
-      to route_to(controller: 'g5_authenticatable/error', action: 'auth_error')
+    expect(get: '/auth_error')
+      .to route_to(controller: 'g5_authenticatable/error', action: 'auth_error')
   end
 
   it 'should generate a helper' do
     expect(auth_error_path).to eq('/g5_auth/auth_error')
   end
-
 end

data/spec/routing/sign_out_routing_spec.rb

@@ -1,10 +1,12 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
-describe 'Sign out routes' do
-  routes {G5Authenticatable::Engine.routes}
+require 'rails_helper'
+
+RSpec.describe 'Sign out routes' do
+  routes { G5Authenticatable::Engine.routes }
 
   it 'should route GET /g5_auth/users/sign_out' do
-    expect(get('/users/sign_out')).to route_to(controller: 'g5_authenticatable/sessions',
-                                               action: 'destroy')
+    expect(get('/users/sign_out'))
+      .to route_to(controller: 'g5_authenticatable/sessions', action: 'destroy')
   end
 end

data/spec/services/g5_authenticatable/impersonate_sessionable_spec.rb

@@ -1,6 +1,8 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
-describe G5Authenticatable::ImpersonateSessionable do
+require 'rails_helper'
+
+RSpec.describe G5Authenticatable::ImpersonateSessionable do
   let!(:user) { FactoryGirl.create(:g5_authenticatable_user) }
 
   class MyImpersponateSessionableTest
@@ -16,31 +18,37 @@ describe G5Authenticatable::ImpersonateSessionable do
       expect(service_instance).to receive(:impersonation_user).and_return(user)
     end
 
-    it { expect(impersonation_user).to be_truthy }
+    it { is_expected.to be_truthy }
   end
 
   describe '#impersonation_user' do
     subject(:impersonation_user) { service_instance.send(:impersonation_user) }
 
     before do
-      expect(service_instance).to receive(:impersonate_admin_uid).and_return(user.uid)
+      expect(service_instance).to receive(:impersonate_admin_uid)
+        .and_return(user.uid)
     end
 
-    it { expect(impersonation_user).to eq(user) }
+    it { is_expected.to eq(user) }
   end
 
   describe '#user_to_impersonate' do
-    subject(:user_to_impersonate) { service_instance.send(:user_to_impersonate) }
+    subject(:user_to_impersonate) do
+      service_instance.send(:user_to_impersonate)
+    end
 
     before do
-      expect(service_instance).to receive(:impersonating_user_uid).and_return(user.uid)
+      expect(service_instance).to receive(:impersonating_user_uid)
+        .and_return(user.uid)
     end
 
-    it { expect(user_to_impersonate).to eq(user) }
+    it { is_expected.to eq(user) }
   end
 
   describe '#able_to_impersonate?' do
-    subject(:able_to_impersonate) { service_instance.send(:able_to_impersonate?, user, user2) }
+    subject(:able_to_impersonate) do
+      service_instance.send(:able_to_impersonate?, user, user2)
+    end
 
     context 'having a super admin and any other user' do
       let!(:user) do
@@ -50,7 +58,7 @@ describe G5Authenticatable::ImpersonateSessionable do
       end
       let!(:user2) { FactoryGirl.create(:g5_authenticatable_user) }
 
-      it { expect(able_to_impersonate).to eq(true) }
+      it { is_expected.to eq(true) }
     end
 
     context 'having an admin' do
@@ -67,7 +75,7 @@ describe G5Authenticatable::ImpersonateSessionable do
           user
         end
 
-        it { expect(able_to_impersonate).to eq(false) }
+        it { is_expected.to eq(false) }
       end
 
       context 'assuming another admin' do
@@ -77,22 +85,37 @@ describe G5Authenticatable::ImpersonateSessionable do
           user
         end
 
-        it { expect(able_to_impersonate).to eq(true) }
+        it { is_expected.to eq(true) }
       end
 
       context 'assuming a regular user' do
         let!(:user2) { FactoryGirl.create(:g5_authenticatable_user) }
 
-        it { expect(able_to_impersonate).to eq(true) }
+        it { is_expected.to eq(true) }
       end
     end
 
     context 'providing no user' do
-      it { expect(service_instance.send(:able_to_impersonate?, user, nil)).to eq(false) }
+      context 'when user to impersonate is nil' do
+        let(:user) { FactoryGirl.create(:g5_authenticatable_super_admin) }
+        let(:user2) {}
+
+        it { is_expected.to eq(false) }
+      end
 
-      it { expect(service_instance.send(:able_to_impersonate?, nil, user)).to eq(false) }
+      context 'when signed-in user is nil' do
+        let(:user) {}
+        let(:user2) { FactoryGirl.create(:g5_authenticatable_user) }
 
-      it { expect(service_instance.send(:able_to_impersonate?, nil, nil)).to eq(false) }
+        it { is_expected.to eq(false) }
+      end
+
+      context 'when both users are nil' do
+        let(:user) {}
+        let(:user2) {}
+
+        it { is_expected.to eq(false) }
+      end
     end
   end
 
@@ -101,12 +124,12 @@ describe G5Authenticatable::ImpersonateSessionable do
 
     context 'having an existing uid' do
       let(:uid) { user.uid }
-      it { expect(user_by_uid).to eq(user) }
+      it { is_expected.to eq(user) }
     end
 
     context 'having a no existing uid' do
       let(:uid) { 'some-random-text' }
-      it { expect(user_by_uid).to be_nil }
+      it { is_expected.to be_nil }
     end
   end
 end

data/spec/spec_helper.rb

@@ -1,60 +1,93 @@
+# frozen_string_literal: true
+
 # MUST happen before any other code is loaded
 require 'simplecov'
-SimpleCov.start 'test_frameworks'
+SimpleCov.start 'rails'
+
+# Given that it is always loaded, you are encouraged to keep this file as
+# light-weight as possible. Requiring heavyweight dependencies from this file
+# will add to the boot time of your test suite on EVERY test run, even for an
+# individual file that may not need all of that loaded. Instead, consider making
+# a separate helper file that requires the additional dependencies and performs
+# the additional setup, and require it from the spec files that actually need
+# it.
+#
+# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 
-require 'codeclimate-test-reporter'
-CodeClimate::TestReporter.start
+RSpec.configure do |config|
+  # rspec-expectations config goes here. You can use an alternate
+  # assertion/expectation library such as wrong or the stdlib/minitest
+  # assertions if you prefer.
+  config.expect_with :rspec do |expectations|
+    # This option will default to `true` in RSpec 4. It makes the `description`
+    # and `failure_message` of custom matchers include text for helper methods
+    # defined using `chain`, e.g.:
+    #     be_bigger_than(2).and_smaller_than(4).description
+    #     # => "be bigger than 2 and smaller than 4"
+    # ...rather than:
+    #     # => "be bigger than 2"
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
 
-ENV["RAILS_ENV"] ||= 'test'
-require File.expand_path("../dummy/config/environment", __FILE__)
+  # rspec-mocks config goes here. You can use an alternate test double
+  # library (such as bogus or mocha) by changing the `mock_with` option here.
+  config.mock_with :rspec do |mocks|
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended, and will default to
+    # `true` in RSpec 4.
+    mocks.verify_partial_doubles = true
+  end
 
-require 'rspec/rails'
-require 'capybara/rspec'
-require 'webmock/rspec'
-require 'g5_authenticatable/rspec'
-require 'g5_updatable/rspec'
-require 'g5_updatable/factories'
+  # This option will default to `:apply_to_host_groups` in RSpec 4 (and will
+  # have no way to turn it off -- the option exists only for backwards
+  # compatibility in RSpec 3). It causes shared context metadata to be
+  # inherited by the metadata hash of host groups and examples, rather than
+  # triggering implicit auto-inclusion in groups with matching metadata.
+  config.shared_context_metadata_behavior = :apply_to_host_groups
 
-Rails.backtrace_cleaner.remove_silencers!
+  # This allows you to limit a spec run to individual examples or groups
+  # you care about by tagging them with `:focus` metadata. When nothing
+  # is tagged with `:focus`, all examples get run. RSpec also provides
+  # aliases for `it`, `describe`, and `context` that include `:focus`
+  # metadata: `fit`, `fdescribe` and `fcontext`, respectively.
+  config.filter_run_when_matching :focus
 
-# Requires supporting ruby files with custom matchers and macros, etc,
-# in spec/support/ and its subdirectories.
-Dir[File.expand_path('../support/**/*.rb', __FILE__)].each { |f| require f }
+  # Allows RSpec to persist some state between runs in order to support
+  # the `--only-failures` and `--next-failure` CLI options. We recommend
+  # you configure your source control system to ignore this file.
+  # config.example_status_persistence_file_path = "spec/examples.txt"
 
-RSpec.configure do |config|
-  # ## Mock Framework
-  #
-  # If you prefer to use mocha, flexmock or RR, uncomment the appropriate line:
-  #
-  # config.mock_with :mocha
-  # config.mock_with :flexmock
-  # config.mock_with :rr
-  config.mock_with :rspec
-
-  # If you're not using ActiveRecord, or you'd prefer not to run each of your
-  # examples within a transaction, remove the following line or assign false
-  # instead of true.
-  config.use_transactional_fixtures = true
-
-  # If true, the base class of anonymous controllers will be inferred
-  # automatically. This will be the default behavior in future versions of
-  # rspec-rails.
-  config.infer_base_class_for_anonymous_controllers = false
+  # Limits the available syntax to the non-monkey patched syntax that is
+  # recommended. For more details, see:
+  #   - http://rspec.info/blog/2012/06/rspecs-new-expectation-syntax/
+  #   - http://www.teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+  #   - http://rspec.info/blog/2014/05/notable-changes-in-rspec-3/#zero-monkey-patching-mode
+  config.disable_monkey_patching!
+
+  # Many RSpec users commonly either run the entire suite or an individual
+  # file, and it's useful to allow more verbose output when running an
+  # individual spec file.
+  if config.files_to_run.one?
+    # Use the documentation formatter for detailed output,
+    # unless a formatter has already been configured
+    # (e.g. via a command-line flag).
+    config.default_formatter = 'doc'
+  end
+
+  # Print the 10 slowest examples and example groups at the
+  # end of the spec run, to help surface which specs are running
+  # particularly slow.
+  # config.profile_examples = 10
 
   # Run specs in random order to surface order dependencies. If you find an
   # order dependency and want to debug it, you can fix the order by providing
   # the seed, which is printed after each run.
   #     --seed 1234
-  config.order = 'random'
-
-  # These two settings work together to allow you to limit a spec run
-  # to individual examples or groups you care about by tagging them with
-  # `:focus` metadata. When nothing is tagged with `:focus`, all examples
-  # get run.
-  config.filter_run :focus
-  config.run_all_when_everything_filtered = true
-
-  config.infer_spec_type_from_file_location!
+  config.order = :random
 
-  config.after(:suite) { WebMock.disable! }
+  # Seed global randomization in this process using the `--seed` CLI option.
+  # Setting this allows you to use `--seed` to deterministically reproduce
+  # test failures related to randomization by passing the same `--seed` value
+  # as the one that triggered the failure.
+  Kernel.srand config.seed
 end