g5_authenticatable 0.9.1.pre.2 → 1.0.0.pre.1

data/spec/models/post_spec.rb

@@ -1,6 +1,8 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
-describe Post do
+require 'rails_helper'
+
+RSpec.describe Post do
   subject { post }
   let(:post) { FactoryGirl.create(:post) }
 

data/spec/policies/application_policy_spec.rb

@@ -1,6 +1,8 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
-describe ApplicationPolicy do
+require 'rails_helper'
+
+RSpec.describe ApplicationPolicy do
   subject(:policy) { described_class }
 
   let(:user) { FactoryGirl.create(:g5_authenticatable_user) }
@@ -15,24 +17,18 @@ describe ApplicationPolicy do
       let(:user) { FactoryGirl.create(:g5_authenticatable_super_admin) }
 
       context 'when record exists in scope' do
-        it 'permits access' do
-          expect(policy).to permit(user, record)
-        end
+        it { is_expected.to permit(user, record) }
       end
 
       context 'when record does not exist in scope' do
         let(:record) { FactoryGirl.build(:post) }
 
-        it 'denies access' do
-          expect(policy).to_not permit(user, record)
-        end
+        it { is_expected.to_not permit(user, record) }
       end
     end
 
     context 'when user is not a super_admin' do
-      it 'denies access' do
-        expect(policy).to_not permit(user, record)
-      end
+      it { is_expected.to_not permit(user, record) }
     end
   end
 
@@ -71,23 +67,17 @@ describe ApplicationPolicy do
     context 'when there is no user' do
       let(:user) {}
 
-      it 'is false' do
-        expect(super_admin?).to eq(false)
-      end
+      it { is_expected.to eq(false) }
     end
 
     context 'when user does not have super_admin role' do
-      it 'is false' do
-        expect(super_admin?).to eq(false)
-      end
+      it { is_expected.to eq(false) }
     end
 
     context 'when user has the super_admin role' do
       let(:user) { FactoryGirl.create(:g5_authenticatable_super_admin) }
 
-      it 'is true' do
-        expect(super_admin?).to eq(true)
-      end
+      it { is_expected.to eq(true) }
     end
   end
 
@@ -97,23 +87,17 @@ describe ApplicationPolicy do
     context 'when there is no user' do
       let(:user) {}
 
-      it 'is false' do
-        expect(admin?).to eq(false)
-      end
+      it { is_expected.to eq(false) }
     end
 
     context 'when user does not have admin role' do
-      it 'is false' do
-        expect(admin?).to eq(false)
-      end
+      it { is_expected.to eq(false) }
     end
 
     context 'when user has the admin role' do
       let(:user) { FactoryGirl.create(:g5_authenticatable_admin) }
 
-      it 'is true' do
-        expect(admin?).to eq(true)
-      end
+      it { is_expected.to eq(true) }
     end
   end
 
@@ -123,23 +107,17 @@ describe ApplicationPolicy do
     context 'when there is no user' do
       let(:user) {}
 
-      it 'is false' do
-        expect(editor?).to eq(false)
-      end
+      it { is_expected.to eq(false) }
     end
 
     context 'when user does not have editor role' do
-      it 'is false' do
-        expect(editor?).to eq(false)
-      end
+      it { is_expected.to eq(false) }
     end
 
     context 'when user has the editor role' do
       let(:user) { FactoryGirl.create(:g5_authenticatable_editor) }
 
-      it 'is true' do
-        expect(editor?).to eq(true)
-      end
+      it { is_expected.to eq(true) }
     end
   end
 
@@ -149,23 +127,78 @@ describe ApplicationPolicy do
     context 'when there is no user' do
       let(:user) {}
 
-      it 'is false' do
-        expect(viewer?).to eq(false)
-      end
+      it { is_expected.to eq(false) }
     end
 
     context 'when user does not have viewer role' do
       let(:user) { FactoryGirl.create(:g5_authenticatable_editor) }
 
-      it 'is false' do
-        expect(viewer?).to eq(false)
-      end
+      it { is_expected.to eq(false) }
     end
 
     context 'when user has the viewer role' do
-      it 'is true' do
-        expect(viewer?).to eq(true)
-      end
+      let(:user) { FactoryGirl.create(:g5_authenticatable_viewer) }
+
+      it { is_expected.to eq(true) }
+    end
+  end
+
+  describe '#global_role?' do
+    subject(:global_role?) { policy.new(user, record).global_role? }
+
+    let(:scoped_role) do
+      FactoryGirl.create(:g5_authenticatable_role, name: role_name,
+                                                   resource: resource)
+    end
+    let(:resource) { FactoryGirl.create(:g5_updatable_client) }
+
+    context 'when there is no user' do
+      it { is_expected.to eq(false) }
+    end
+
+    context 'when the user is a global super admin' do
+      let(:user) { FactoryGirl.create(:g5_authenticatable_super_admin) }
+
+      it { is_expected.to eq(true) }
+    end
+
+    context 'when the user is a global admin' do
+      let(:user) { FactoryGirl.create(:g5_authenticatable_admin) }
+
+      it { is_expected.to eq(true) }
+    end
+
+    context 'when the user is a global editor' do
+      let(:user) { FactoryGirl.create(:g5_authenticatable_editor) }
+
+      it { is_expected.to eq(true) }
+    end
+
+    context 'when the user is a global viewer' do
+      let(:user) { FactoryGirl.create(:g5_authenticatable_viewer) }
+
+      it { is_expected.to eq(true) }
+    end
+
+    context 'when user is a scoped admin' do
+      let(:role_name) { :admin }
+      before { user.roles << scoped_role }
+
+      it { is_expected.to eq(false) }
+    end
+
+    context 'when user is a scoped editor' do
+      let(:role_name) { :editor }
+      before { user.roles << scoped_role }
+
+      it { is_expected.to eq(false) }
+    end
+
+    context 'when user is a scoped viewer' do
+      let(:role_name) { :viewer }
+      before { user.roles << scoped_role }
+
+      it { is_expected.to eq(false) }
     end
   end
 end

data/spec/policies/client_policy_spec.rb

@@ -1,6 +1,8 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
-describe G5Updatable::ClientPolicy do
+require 'rails_helper'
+
+RSpec.describe G5Updatable::ClientPolicy do
   subject(:policy) { described_class }
 
   let(:user) { FactoryGirl.create(:g5_authenticatable_user) }
@@ -17,8 +19,9 @@ describe G5Updatable::ClientPolicy do
   let!(:client_3) { FactoryGirl.create(:g5_updatable_client) }
 
   describe '.resolve' do
-
-    subject { G5Updatable::ClientPolicy::Scope.new(user, G5Updatable::Client).resolve }
+    subject do
+      G5Updatable::ClientPolicy::Scope.new(user, G5Updatable::Client).resolve
+    end
 
     context 'with global role' do
       before { user.add_role :admin }
@@ -38,7 +41,7 @@ describe G5Updatable::ClientPolicy do
       end
     end
 
-    context 'with many client roles'  do
+    context 'with many client roles' do
       before do
         user.add_role(:admin, client_1)
         user.add_role(:admin, client_2)

data/spec/policies/location_policy_spec.rb

@@ -1,6 +1,8 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
-describe G5Updatable::LocationPolicy do
+require 'rails_helper'
+
+RSpec.describe G5Updatable::LocationPolicy do
   subject(:policy) { described_class }
 
   let(:user) { FactoryGirl.create(:g5_authenticatable_user) }
@@ -9,11 +11,19 @@ describe G5Updatable::LocationPolicy do
   let!(:client_1) { FactoryGirl.create(:g5_updatable_client) }
   let!(:client_2) { FactoryGirl.create(:g5_updatable_client) }
 
-  let!(:location_1) { FactoryGirl.create(:g5_updatable_location, client: client_1) }
-  let!(:location_2) { FactoryGirl.create(:g5_updatable_location, client: client_1) }
+  let!(:location_1) do
+    FactoryGirl.create(:g5_updatable_location, client: client_1)
+  end
+  let!(:location_2) do
+    FactoryGirl.create(:g5_updatable_location, client: client_1)
+  end
 
-  let!(:location_3) { FactoryGirl.create(:g5_updatable_location, client: client_2) }
-  let!(:location_4) { FactoryGirl.create(:g5_updatable_location, client: client_2) }
+  let!(:location_3) do
+    FactoryGirl.create(:g5_updatable_location, client: client_2)
+  end
+  let!(:location_4) do
+    FactoryGirl.create(:g5_updatable_location, client: client_2)
+  end
 
   before do
     user.roles = []
@@ -22,7 +32,10 @@ describe G5Updatable::LocationPolicy do
   end
 
   describe '.resolve' do
-    subject { G5Updatable::LocationPolicy::Scope.new(user, G5Updatable::Location).resolve }
+    subject do
+      G5Updatable::LocationPolicy::Scope.new(user, G5Updatable::Location)
+                                        .resolve
+    end
 
     context 'with global role' do
       before { user.add_role :admin }
@@ -42,7 +55,7 @@ describe G5Updatable::LocationPolicy do
       end
     end
 
-    context 'with many client roles'  do
+    context 'with many client roles' do
       before do
         user.add_role(:admin, location_1)
         user.add_role(:admin, location_2)

data/spec/policies/selectable_client_policy_spec.rb

@@ -1,6 +1,8 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
-describe G5Updatable::SelectableClientPolicy do
+require 'rails_helper'
+
+RSpec.describe G5Updatable::SelectableClientPolicy do
   subject(:policy) { described_class }
 
   let(:user) { FactoryGirl.create(:g5_authenticatable_user) }
@@ -17,13 +19,24 @@ describe G5Updatable::SelectableClientPolicy do
   let!(:client_3) { FactoryGirl.create(:g5_updatable_client) }
 
   describe '.resolve' do
-    subject { G5Updatable::SelectableClientPolicy::Scope.new(user, G5Updatable::Client).resolve }
+    subject do
+      G5Updatable::SelectableClientPolicy::Scope.new(user, G5Updatable::Client)
+                                                .resolve
+    end
 
-    let!(:location_1) { FactoryGirl.create(:g5_updatable_location, client: client_1) }
-    let!(:location_2) { FactoryGirl.create(:g5_updatable_location, client: client_1) }
+    let!(:location_1) do
+      FactoryGirl.create(:g5_updatable_location, client: client_1)
+    end
+    let!(:location_2) do
+      FactoryGirl.create(:g5_updatable_location, client: client_1)
+    end
 
-    let!(:location_3) { FactoryGirl.create(:g5_updatable_location, client: client_2) }
-    let!(:location_4) { FactoryGirl.create(:g5_updatable_location, client: client_2) }
+    let!(:location_3) do
+      FactoryGirl.create(:g5_updatable_location, client: client_2)
+    end
+    let!(:location_4) do
+      FactoryGirl.create(:g5_updatable_location, client: client_2)
+    end
 
     context 'with global role' do
       before { user.add_role :admin }
@@ -46,11 +59,12 @@ describe G5Updatable::SelectableClientPolicy do
       end
     end
 
-    context 'with role for location and client that location does not belong to' do
+    context 'with role for location and unrelated client' do
       before do
         user.add_role :admin, location_1
         user.add_role :admin, client_2
       end
+
       it 'returns 1 client' do
         expect(subject.length).to eq(2)
         expect(subject).to include(client_1)
@@ -59,9 +73,8 @@ describe G5Updatable::SelectableClientPolicy do
     end
 
     context 'with a client role' do
-      before do
-        user.add_role :admin, client_2
-      end
+      before { user.add_role :admin, client_2 }
+
       it 'returns 1 client' do
         expect(subject.length).to eq(1)
         expect(subject).to include(client_2)
@@ -69,14 +82,12 @@ describe G5Updatable::SelectableClientPolicy do
     end
 
     context 'with a location role' do
-      before do
-        user.add_role :admin, location_1
-      end
+      before { user.add_role :admin, location_1 }
+
       it 'returns 1 client' do
         expect(subject.length).to eq(1)
         expect(subject).to include(client_1)
       end
     end
   end
-
 end

data/spec/rails_helper.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+ENV['RAILS_ENV'] ||= 'test'
+require File.expand_path('../dummy/config/environment', __FILE__)
+
+require 'rspec/rails'
+require 'capybara/rspec'
+require 'webmock/rspec'
+require 'g5_authenticatable/rspec'
+require 'g5_updatable/rspec'
+require 'g5_updatable/factories'
+
+Rails.backtrace_cleaner.remove_silencers!
+
+# Requires supporting ruby files with custom matchers and macros, etc,
+# in spec/support/ and its subdirectories.
+Dir[File.expand_path('../support/**/*.rb', __FILE__)].each { |f| require f }
+
+RSpec.configure do |config|
+  # If you're not using ActiveRecord, or you'd prefer not to run each of your
+  # examples within a transaction, remove the following line or assign false
+  # instead of true.
+  config.use_transactional_fixtures = true
+
+  # If true, the base class of anonymous controllers will be inferred
+  # automatically. This will be the default behavior in future versions of
+  # rspec-rails.
+  config.infer_base_class_for_anonymous_controllers = false
+
+  # Controller tests live under spec/controllers, etc.
+  config.infer_spec_type_from_file_location!
+end
+
+Shoulda::Matchers.configure do |config|
+  config.integrate do |with|
+    with.test_framework :rspec
+    with.library :rails
+  end
+end

data/spec/requests/default_role_authorization_spec.rb

@@ -1,10 +1,12 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
-describe 'Default role-based authorization API' do
+require 'rails_helper'
+
+RSpec.describe 'Default role-based authorization API' do
   let(:json) { JSON.parse(response.body) }
 
   describe 'GET /posts', :auth_request do
-    subject(:get_posts) { get posts_path, format: :json }
+    subject(:get_posts) { safe_get posts_path, format: :json }
 
     let!(:post) { FactoryGirl.create(:post, author: user) }
     let!(:other_post) { FactoryGirl.create(:post) }
@@ -19,7 +21,7 @@ describe 'Default role-based authorization API' do
       end
 
       it 'includes all posts' do
-        expect(json['posts']).to include(
+        expect(json).to include(
           hash_including('id' => post.id,
                          'author_id' => post.author.id,
                          'content' => post.content),
@@ -38,7 +40,7 @@ describe 'Default role-based authorization API' do
   end
 
   describe 'GET /posts/:id', :auth_request do
-    subject(:show_post) { get post_path(post.id), format: :json }
+    subject(:show_post) { safe_get post_path(post.id), format: :json }
 
     let(:post) { FactoryGirl.create(:post, author: user) }
 
@@ -59,7 +61,7 @@ describe 'Default role-based authorization API' do
     end
 
     context 'when user is not a super_admin' do
-      let(:user) { FactoryGirl.create(:g5_authenticatable_user) }
+      let(:user) { FactoryGirl.create(:g5_authenticatable_viewer) }
 
       it 'returns forbidden' do
         expect(response).to be_forbidden
@@ -68,10 +70,12 @@ describe 'Default role-based authorization API' do
   end
 
   describe 'POST /posts', :auth_request do
-    subject(:create_post) { post posts_path, post: post_params, format: :json }
+    subject(:create_post) do
+      safe_post posts_path, post: post_params, format: :json
+    end
 
     let(:post_params) do
-      {content: post_obj.content, author_id: post_obj.author.id}
+      { content: post_obj.content, author_id: post_obj.author.id }
     end
     let(:post_obj) { FactoryGirl.build(:post, author: user) }
 
@@ -80,7 +84,7 @@ describe 'Default role-based authorization API' do
 
       it 'returns ok' do
         create_post
-        expect(response).to be_created
+        expect(response.status).to eq(201)
       end
 
       it 'creates a post' do
@@ -102,11 +106,11 @@ describe 'Default role-based authorization API' do
 
   describe 'PUT /posts/:id', :auth_request do
     subject(:update_post) do
-      put post_path(post.id), post: post_params, format: :json
+      safe_put post_path(post.id), post: post_params, format: :json
     end
 
     let(:post_params) do
-      {content: 'some brand new content', author_id: post.author.id}
+      { content: 'some brand new content', author_id: post.author.id }
     end
     let(:post) { FactoryGirl.create(:post, author: user) }
 
@@ -115,7 +119,7 @@ describe 'Default role-based authorization API' do
 
       it 'returns ok' do
         update_post
-        expect(response).to be_http_no_content
+        expect(response.status).to eq(204)
       end
 
       it 'updates the post' do
@@ -137,7 +141,7 @@ describe 'Default role-based authorization API' do
 
   describe 'DELETE /posts/:id', :auth_request do
     subject(:delete_post) do
-      delete post_path(post.id), format: :json
+      safe_delete post_path(post.id), format: :json
     end
 
     let!(:post) { FactoryGirl.create(:post, author: user) }
@@ -147,7 +151,7 @@ describe 'Default role-based authorization API' do
 
       it 'returns ok' do
         delete_post
-        expect(response).to be_http_no_content
+        expect(response.status).to eq(204)
       end
 
       it 'deletes the post' do