fudge 0.6.1 → 0.6.3

data/spec/lib/fudge/tasks/flay_spec.rb

@@ -5,7 +5,6 @@ describe Fudge::Tasks::Flay do
 
   it_should_behave_like 'bundle aware'
 
-
   let(:output_good) do
     <<-EOF
 Total score (lower is better) = 0
@@ -19,15 +18,15 @@ EOF
   end
 
   describe '#run' do
-    it "runs flay on the codebase" do
+    it 'runs flay on the codebase' do
       expect(subject).to run_command "flay --diff `find . | grep --color=never -e '\\.rb$'`"
     end
 
     context 'with :exclude => pattern' do
-      subject {described_class.new :exclude => 'spec/'}
+      subject { described_class.new exclude: 'spec/' }
 
       # Test doesn't check result :(
-      it "filters out the pattern" do
+      it 'filters out the pattern' do
         cmd = "flay --diff `find . | grep --color=never -e '\\.rb$' | grep --color=never -v -E 'spec/'`"
         expect(subject).to run_command cmd
       end
@@ -38,10 +37,10 @@ EOF
 
     context 'when :max score is supplied' do
       it 'fails when score is higher than max' do
-        task = described_class.new :max => 99
+        task = described_class.new max: 99
         expect(task).not_to succeed_with_output output_bad
 
-        task = described_class.new :max => 100
+        task = described_class.new max: 100
         expect(task).to succeed_with_output output_bad
       end
     end

data/spec/lib/fudge/tasks/flog_spec.rb

@@ -46,24 +46,24 @@ EOF
   end
 
   describe '#run' do
-    it "runs flog on the codebase" do
+    it 'runs flog on the codebase' do
       expect(subject).to run_command "flog `find . | grep --color=never -e '\\.rb$'`"
     end
 
     context 'with :exclude => pattern' do
-      subject {described_class.new :exclude => 'spec/'}
+      subject { described_class.new exclude: 'spec/' }
 
       # Test doesn't check result :(
-      it "filters out the pattern" do
+      it 'filters out the pattern' do
         with_pattern = "flog `find . | grep --color=never -e '\\.rb$' | grep --color=never -v -E 'spec/'`"
         expect(subject).to run_command with_pattern
       end
     end
 
     context 'with :methods => true' do
-      subject {described_class.new :methods => true}
+      subject { described_class.new methods: true }
 
-      it "runs with methods only flag" do
+      it 'runs with methods only flag' do
         with_pattern = "flog -m `find . | grep --color=never -e '\\.rb$'`"
         expect(subject).to run_command with_pattern
       end
@@ -76,20 +76,20 @@ EOF
 
     context 'when :max score is supplied' do
       it 'fails when score is higher than max' do
-        task = described_class.new :max => 9.9
+        task = described_class.new max: 9.9
         expect(task).not_to succeed_with_output output_good
 
-        task = described_class.new :max => 10.0
+        task = described_class.new max: 10.0
         expect(task).to succeed_with_output output_good
       end
     end
 
     context 'when :average score is supplied' do
       it 'fails when average is higher than :average' do
-        task = described_class.new :average => 4.9
+        task = described_class.new average: 4.9
         expect(task).not_to succeed_with_output output_good
 
-        task = described_class.new :average => 5.0
+        task = described_class.new average: 5.0
         expect(task).to succeed_with_output output_good
       end
     end

data/spec/lib/fudge/tasks/in_directory_spec.rb

@@ -6,7 +6,7 @@ class TestInDirectoryTask
     :test_in_directory
   end
 
-  def run(options={})
+  def run(_options = {})
     self.pwd = FileUtils.pwd
   end
 end
@@ -17,7 +17,7 @@ describe Fudge::Tasks::InDirectory do
   it { is_expected.to be_registered_as :in_directory }
 
   describe '#initialize' do
-    it "should take a directory as first argument" do
+    it 'should take a directory as first argument' do
       expect { described_class.new }.to raise_error ArgumentError
     end
   end
@@ -30,7 +30,7 @@ describe Fudge::Tasks::InDirectory do
       subject.tasks << task
     end
 
-    it "should change to the given directory and run child tasks" do
+    it 'should change to the given directory and run child tasks' do
       subject.run
 
       expect(task.pwd).to eq(path)

data/spec/lib/fudge/tasks/rake_spec.rb

@@ -5,13 +5,13 @@ describe Fudge::Tasks::Rake do
   it { is_expected.to be_a Fudge::Tasks::Shell }
 
   describe '#run' do
-    it "should be rake by default" do
+    it 'should be rake by default' do
       expect(subject).to run_command 'rake '
     end
 
     it_should_behave_like 'bundle aware'
 
-    it "should add any arguments given" do
+    it 'should add any arguments given' do
       expect(described_class.new('db:migrate')).to run_command 'rake db:migrate'
     end
   end

data/spec/lib/fudge/tasks/rspec_spec.rb

@@ -4,38 +4,37 @@ describe Fudge::Tasks::Rspec do
   it { is_expected.to be_registered_as :rspec }
 
   describe '#run' do
-    it "should turn on color if not specified" do
+    it 'should turn on color if not specified' do
       expect(subject).to run_command /--tty/
     end
 
-    it "should turn off color if specified" do
-      expect(described_class.new(:color => false)).not_to run_command /--tty/
+    it 'should turn off color if specified' do
+      expect(described_class.new(color: false)).not_to run_command /--tty/
     end
 
-    it "should append any arguments passed in" do
-      task = described_class.new('foobar', :color => false)
+    it 'should append any arguments passed in' do
+      task = described_class.new('foobar', color: false)
       expect(task).to run_command 'rspec foobar'
     end
 
-    it "should default the arguments to spec/" do
-      expect(described_class.new(:color => false)).to run_command 'rspec spec/'
+    it 'should default the arguments to spec/' do
+      expect(described_class.new(color: false)).to run_command 'rspec spec/'
     end
-
   end
 
   it_should_behave_like 'bundle aware'
 
   describe '#coverage' do
-    subject { described_class.new :coverage => 99 }
+    subject { described_class.new coverage: 99 }
 
     it { is_expected.not_to succeed_with_output 'some dummy output with no coverage' }
     it { is_expected.not_to succeed_with_output '98.99999%) covered' }
     it { is_expected.not_to succeed_with_output '0.00%) covered' }
     it { is_expected.to succeed_with_output '99.99999%) covered' }
     it { is_expected.to succeed_with_output '100.0%) covered' }
-    it { is_expected.to succeed_with_output "\n0 examples, 0 failures"}
-    it { is_expected.to succeed_with_output "No examples found.\n\n\nFinished in 0.00006 seconds\n\e[32m0 examples, 0 failures\e[0m\n"}
-    it { is_expected.to succeed_with_output "Finished in 0.1 seconds\n70 examples, 0 failures\n700 / 700 LOC (100.0%) covered."}
-    it { is_expected.not_to succeed_with_output "Finished in 0.6 seconds\n70 examples, 0 failures\n384 / 700 LOC (54.86%) covered."}
+    it { is_expected.to succeed_with_output "\n0 examples, 0 failures" }
+    it { is_expected.to succeed_with_output "No examples found.\n\n\nFinished in 0.00006 seconds\n\e[32m0 examples, 0 failures\e[0m\n" }
+    it { is_expected.to succeed_with_output "Finished in 0.1 seconds\n70 examples, 0 failures\n700 / 700 LOC (100.0%) covered." }
+    it { is_expected.not_to succeed_with_output "Finished in 0.6 seconds\n70 examples, 0 failures\n384 / 700 LOC (54.86%) covered." }
   end
 end

data/spec/lib/fudge/tasks/shell_spec.rb

@@ -2,63 +2,60 @@ require 'spec_helper'
 
 describe Fudge::Tasks::Shell do
   describe '#run' do
-    it "should take a command and run it" do
+    it 'should take a command and run it' do
       expect(described_class.new(:ls)).to run_command 'ls'
     end
 
-    it "should add any arguments given" do
+    it 'should add any arguments given' do
       expect(described_class.new(:ls, '-l', '-a')).to run_command 'ls -l -a'
     end
 
-    it "should return false for an unsuccessful command" do
+    it 'should return false for an unsuccessful command' do
       expect(described_class.new(:ls, '--newnre').run).to be_falsey
     end
 
-    it "should return true for a successful command" do
+    it 'should return true for a successful command' do
       expect(described_class.new(:ls).run).to be_truthy
     end
 
-    context "when there is an formatter passed to run" do
-
+    context 'when there is an formatter passed to run' do
       let(:output) { StringIO.new }
       let(:formatter) { Fudge::Formatters::Simple.new(output) }
       subject { described_class.new('echo foo') }
 
-      it "prints messages to the formatter instead of default" do
-
-        subject.run :formatter => formatter
+      it 'prints messages to the formatter instead of default' do
+        subject.run formatter: formatter
 
         expect(output.string).not_to be_empty
-        expect(output.string).to include "foo"
+        expect(output.string).to include 'foo'
       end
 
       it 'uses the formatter when reporting checks on build result' do
         checker = double.as_null_object
         expect(Fudge::OutputChecker).to receive(:new).with(anything, formatter) { checker }
-        subject.run :formatter => formatter
+        subject.run formatter: formatter
       end
-
     end
   end
 
   describe '#check_for' do
-    context "with no callable to check the matches" do
-      subject { described_class.new(:ls, :check_for => /4 files found/) }
+    context 'with no callable to check the matches' do
+      subject { described_class.new(:ls, check_for: /4 files found/) }
 
-      it { is_expected.to succeed_with_output "Hello there were 4 files found." }
-      it { is_expected.not_to succeed_with_output "Hellow there were 5 files found." }
+      it { is_expected.to succeed_with_output 'Hello there were 4 files found.' }
+      it { is_expected.not_to succeed_with_output 'Hellow there were 5 files found.' }
     end
 
-    context "with a callable to check the matches" do
-      let(:file_count_matcher) { lambda { |matches| matches[1].to_i >= 4 }}
+    context 'with a callable to check the matches' do
+      let(:file_count_matcher) { ->(matches) { matches[1].to_i >= 4 } }
       subject do
         described_class.new :ls,
-          :check_for => [/(\d+) files found/, file_count_matcher]
+                            check_for: [/(\d+) files found/, file_count_matcher]
       end
 
-      it { is_expected.not_to succeed_with_output "Hello there were 3 files found." }
-      it { is_expected.to succeed_with_output "Hello there were 4 files found." }
-      it { is_expected.to succeed_with_output "Hellow there were 5 files found." }
+      it { is_expected.not_to succeed_with_output 'Hello there were 3 files found.' }
+      it { is_expected.to succeed_with_output 'Hello there were 4 files found.' }
+      it { is_expected.to succeed_with_output 'Hellow there were 5 files found.' }
     end
   end
 end

data/spec/lib/fudge/tasks/sub_process_spec.rb

@@ -6,25 +6,25 @@ describe Fudge::Tasks::SubProcess do
   let(:formatter) { Fudge::Formatters::Simple.new(output) }
 
   describe '#run' do
-    it "takes a command and runs it" do
+    it 'takes a command and runs it' do
       expect(described_class.new(:ls)).to run_command [{}, 'ls', {}]
     end
 
-    it "adds any arguments given" do
+    it 'adds any arguments given' do
       expect(described_class.new(:ls, '-l', '-a')).to run_command [{}, 'ls', '-l', '-a', {}]
     end
 
-    it "returns false for an unsuccessful command" do
+    it 'returns false for an unsuccessful command' do
       expect(described_class.new(:ls, '--newnre').run).to be_falsey
     end
 
-    it "returns true for a successful command" do
+    it 'returns true for a successful command' do
       expect(described_class.new(:ls).run).to be_truthy
     end
 
-    context "when given environment variables" do
-      context "when the task is created" do
-        it "passes the variables to the sub-process" do
+    context 'when given environment variables' do
+      context 'when the task is created' do
+        it 'passes the variables to the sub-process' do
           process = described_class.new(%(ruby -e "puts ENV['PATH'];puts ENV['FOO']"), environment: { 'FOO' => 'bar' })
 
           process.run(formatter: formatter)
@@ -33,8 +33,8 @@ describe Fudge::Tasks::SubProcess do
         end
       end
 
-      context "when the task is run" do
-        it "passes the variables to the sub-process" do
+      context 'when the task is run' do
+        it 'passes the variables to the sub-process' do
           process = described_class.new(%(ruby -e "puts ENV['PATH'];puts ENV['FOO']"))
 
           process.run(formatter: formatter, environment: { 'FOO' => 'bar' })
@@ -43,8 +43,8 @@ describe Fudge::Tasks::SubProcess do
         end
       end
 
-      context "when the task is created and when it is run" do
-        it "gives priority to the variables passed in on run" do
+      context 'when the task is created and when it is run' do
+        it 'gives priority to the variables passed in on run' do
           process = described_class.new(%(ruby -e "puts ENV['FOO'];puts ENV['BAZ']"),
                                         environment: { 'FOO' => 'bar', 'BAZ' => 'quux' })
 
@@ -55,8 +55,8 @@ describe Fudge::Tasks::SubProcess do
       end
     end
 
-    context "when not given an environment variable" do
-      it "does not make that variable available to the sub-process" do
+    context 'when not given an environment variable' do
+      it 'does not make that variable available to the sub-process' do
         process = described_class.new(%(ruby -e "puts ENV['FOO']"))
 
         process.run(formatter: formatter)
@@ -65,9 +65,9 @@ describe Fudge::Tasks::SubProcess do
       end
     end
 
-    context "when given spawn options" do
-      context "when the task is created" do
-        it "applies those options to the sub-process" do
+    context 'when given spawn options' do
+      context 'when the task is created' do
+        it 'applies those options to the sub-process' do
           process = described_class.new(%(ruby -e "puts ENV['PATH'];puts ENV['FOO']"),
                                         environment: { 'FOO' => 'bar' },
                                         spawn_options: { unsetenv_others: true }) # Should clear environment variables
@@ -78,8 +78,8 @@ describe Fudge::Tasks::SubProcess do
         end
       end
 
-      context "when the task is run" do
-        it "applies those options to the sub-process" do
+      context 'when the task is run' do
+        it 'applies those options to the sub-process' do
           process = described_class.new(%(ruby -e "puts ENV['PATH'];puts ENV['FOO']"),
                                         environment: { 'FOO' => 'bar' })
 
@@ -89,8 +89,8 @@ describe Fudge::Tasks::SubProcess do
         end
       end
 
-      context "when the task is created and when it is run" do
-        it "gives priority to the options passed in on run" do
+      context 'when the task is created and when it is run' do
+        it 'gives priority to the options passed in on run' do
           process = described_class.new(%(ruby -e "puts ENV['PATH'];puts ENV['FOO']"),
                                         environment: { 'FOO' => 'bar' },
                                         spawn_options: { unsetenv_others: true }) # Clear environment variables

data/spec/lib/fudge/tasks/task_spec.rb

@@ -4,7 +4,7 @@ class MyTask < Fudge::Tasks::Task
   attr_accessor :cod
 
   attr_accessor :_methods_missing
-  def method_missing(method, *args)
+  def method_missing(method, *_args)
     (@_methods_missing ||= []).push(method)
   end
 end
@@ -16,56 +16,56 @@ end
 
 describe Fudge::Tasks::Task do
   describe :initialize do
-    context "given arguments" do
-      it "accepts and stores the arguments" do
+    context 'given arguments' do
+      it 'accepts and stores the arguments' do
         task = MyTask.new :foo, :bar, :baz
         expect(task.args).to match_array [:foo, :bar, :baz]
       end
     end
 
-    context "given options" do
-      let (:task) { MyTask.new :cod => 'fanglers' }
+    context 'given options' do
+      let(:task) { MyTask.new cod: 'fanglers' }
 
-      it "accepts and sets the options" do
+      it 'accepts and sets the options' do
         expect(task.cod).to eq 'fanglers'
       end
 
-      it "accepts and stores the options" do
-        expect(task.options).to eq({ cod: 'fanglers' })
+      it 'accepts and stores the options' do
+        expect(task.options).to eq(cod: 'fanglers')
       end
 
-      context "including an option that is not supported" do
-        let (:task) { MyTask.new :cod => 'fanglers', :foo => 'bar' }
+      context 'including an option that is not supported' do
+        let(:task) { MyTask.new cod: 'fanglers', foo: 'bar' }
 
-        it "ignores the unsupported options" do
+        it 'ignores the unsupported options' do
           expect(task._methods_missing).to be_nil
         end
 
-        it "stores all provided options" do
-          expect(task.options).to eq({ cod: 'fanglers', foo: 'bar' })
+        it 'stores all provided options' do
+          expect(task.options).to eq(cod: 'fanglers', foo: 'bar')
         end
       end
     end
 
-    context "given arguments and options" do
-      let (:task) { MyTask.new :foo, :bar, :cod => 'fanglers' }
+    context 'given arguments and options' do
+      let(:task) { MyTask.new :foo, :bar, cod: 'fanglers' }
 
-      it "stores the arguments separately from the options" do
+      it 'stores the arguments separately from the options' do
         expect(task.args).to match_array [:foo, :bar]
       end
 
-      it "applies the options" do
+      it 'applies the options' do
         expect(task.cod).to eq 'fanglers'
       end
 
-      it "stores the options separately from the arguments" do
-        expect(task.options).to eq({ cod: 'fanglers' })
+      it 'stores the options separately from the arguments' do
+        expect(task.options).to eq(cod: 'fanglers')
       end
     end
   end
 
   describe :name do
-    it "should default to implied name from class name" do
+    it 'should default to implied name from class name' do
       expect(TestNamespace::SomeTask.name).to eq(:some_task)
     end
   end