fudge 0.6.1 → 0.6.3

data/spec/lib/fudge/exceptions_spec.rb

@@ -24,7 +24,7 @@ module Fudge::Exceptions
       it { is_expected.to be_a String }
     end
 
-    it "should take a task name as a parameter" do
+    it 'should take a task name as a parameter' do
       expect { described_class.new }.to raise_error ArgumentError
     end
   end
@@ -39,7 +39,7 @@ module Fudge::Exceptions
       it { is_expected.to be_a String }
     end
 
-    it "should take a task group name as a parameter" do
+    it 'should take a task group name as a parameter' do
       expect { described_class.new }.to raise_error ArgumentError
     end
   end

data/spec/lib/fudge/formatters/simple_spec.rb

@@ -5,64 +5,63 @@ describe Fudge::Formatters::Simple do
 
   subject { described_class.new(stdout) }
 
-  describe "#error" do
-    it "returns message in RED" do
-      string = subject.error "a message"
+  describe '#error' do
+    it 'returns message in RED' do
+      string = subject.error 'a message'
       expect(string).to eq("\e[31ma message\e[0m")
     end
   end
 
-  describe "#success" do
-    it "returns message in BRIGHT GREEN" do
-      string = subject.success "a message"
+  describe '#success' do
+    it 'returns message in BRIGHT GREEN' do
+      string = subject.success 'a message'
       expect(string).to eq("\e[1m\e[32ma message\e[0m")
     end
   end
 
-  describe "#info" do
-    it "returns message in CYAN" do
-      string = subject.info "a message"
+  describe '#info' do
+    it 'returns message in CYAN' do
+      string = subject.info 'a message'
       expect(string).to eq("\e[36ma message\e[0m")
     end
   end
 
-  describe "#notice" do
-    it "returns message in YELLOW" do
-      string = subject.notice "a message"
+  describe '#notice' do
+    it 'returns message in YELLOW' do
+      string = subject.notice 'a message'
       expect(string).to eq("\e[33ma message\e[0m")
     end
   end
 
-  describe "#normal" do
-    it "returns unchanged message" do
-      string = subject.normal "a message"
-      expect(string).to eq("a message")
+  describe '#normal' do
+    it 'returns unchanged message' do
+      string = subject.normal 'a message'
+      expect(string).to eq('a message')
     end
   end
 
-  describe "#puts" do
-    it "outputs message on stdout" do
-      subject.puts "a message"
-      expect(stdout.string).to eq("a message" + "\n")
+  describe '#puts' do
+    it 'outputs message on stdout' do
+      subject.puts 'a message'
+      expect(stdout.string).to eq('a message' + "\n")
     end
   end
 
-  describe "#write" do
-    it "supports chaining types to stdout" do
+  describe '#write' do
+    it 'supports chaining types to stdout' do
       subject.write do |w|
-        w.normal('normal').
-          notice('notice').
-          info('info').
-          success('success').
-          error('error')
+        w.normal('normal')
+         .notice('notice')
+         .info('info')
+         .success('success')
+         .error('error')
       end
 
-      expect(stdout.string).to eq('normal' + ' ' +
-                              "\e[33mnotice\e[0m" + ' ' +
-                              "\e[36minfo\e[0m" + ' ' +
-                              "\e[1m\e[32msuccess\e[0m" + ' ' +
+      expect(stdout.string).to eq('normal' + ' ' \
+                              "\e[33mnotice\e[0m" + ' ' \
+                              "\e[36minfo\e[0m" + ' ' \
+                              "\e[1m\e[32msuccess\e[0m" + ' ' \
                               "\e[31merror\e[0m" + "\n")
-
     end
   end
 end

data/spec/lib/fudge/output_checker_spec.rb

@@ -4,19 +4,19 @@ describe Fudge::OutputChecker do
   let(:output_io) { StringIO.new }
   let(:formatter) { Fudge::Formatters::Simple.new(output_io) }
 
-  describe "#check" do
+  describe '#check' do
     subject { described_class.new(/foo/, formatter) }
 
-    context "when the output does not match the check" do
-       it 'send a mismatch message to the output io' do
-          subject.check('bar')
-          expect(output_io.string).to include "Output didn't match (?-mix:foo)."
-       end
+    context 'when the output does not match the check' do
+      it 'send a mismatch message to the output io' do
+        subject.check('bar')
+        expect(output_io.string).to include "Output didn't match (?-mix:foo)."
+      end
     end
 
-    context "with a block for checking" do
+    context 'with a block for checking' do
       let(:callable) do
-        Proc.new do
+        proc do
           false
         end
       end
@@ -25,7 +25,7 @@ describe Fudge::OutputChecker do
       it 'sends error mesage to the output io' do
         subject.check('foo')
 
-        expect(output_io.string).to include "Output matched (?-mix:foo) but condition failed."
+        expect(output_io.string).to include 'Output matched (?-mix:foo) but condition failed.'
       end
     end
   end

data/spec/lib/fudge/parser_spec.rb

@@ -12,11 +12,11 @@ describe Fudge::Parser do
       end
     end
 
-    it "should read a file and evaluate it" do
+    it 'should read a file and evaluate it' do
       expect(subject.parse(@path)).to be_a Fudge::Description
     end
 
-    it "should pass the contents to the new description" do
+    it 'should pass the contents to the new description' do
       expect(subject.parse(@path).instance_variable_get(:@foo)).to eq(:bar)
     end
   end

data/spec/lib/fudge/runner_spec.rb

@@ -10,35 +10,35 @@ describe Fudge::Runner do
   subject { described_class.new(description) }
 
   describe '#run_build' do
-    it "should run the default task in the description" do
+    it 'should run the default task in the description' do
       subject.run_build
 
       expect(DummyTask.ran).to be_truthy
     end
 
-    it "should raise an exception if the build fails" do
+    it 'should raise an exception if the build fails' do
       allow_any_instance_of(Fudge::Build).to receive(:run).and_return(false)
 
       expect { subject.run_build }.to raise_error Fudge::Exceptions::BuildFailed
     end
 
-    context "when an formatter is provided" do
+    context 'when an formatter is provided' do
       let(:stdout) { StringIO.new }
       let(:formatter) { Fudge::Formatters::Simple.new(stdout) }
 
       before :each do
-        subject.run_build 'default', :formatter => formatter
+        subject.run_build 'default', formatter: formatter
       end
 
-      it "puts all output to given formatter instead stdout" do
+      it 'puts all output to given formatter instead stdout' do
         expect(stdout.string).not_to be_empty
-        expect(stdout.string).to include "Running build"
-        expect(stdout.string).to include "default"
-        expect(stdout.string).to include "Build SUCCEEDED!"
+        expect(stdout.string).to include 'Running build'
+        expect(stdout.string).to include 'default'
+        expect(stdout.string).to include 'Build SUCCEEDED!'
       end
 
-      it "runs the task passing the formatter down" do
-        expect(DummyTask.run_options).to eq({:formatter => formatter})
+      it 'runs the task passing the formatter down' do
+        expect(DummyTask.run_options).to eq(formatter: formatter)
       end
     end
   end

data/spec/lib/fudge/tasks/brakeman_spec.rb

@@ -5,7 +5,6 @@ describe Fudge::Tasks::Brakeman do
 
   it_should_behave_like 'bundle aware'
 
-
   let(:output_good) do
     <<-EOF
 | Errors            | 0     |
@@ -50,10 +49,10 @@ EOF
 
     context 'when :max score is supplied' do
       it 'fails when score is higher than max' do
-        task = described_class.new :max => 0
+        task = described_class.new max: 0
         expect(task).not_to succeed_with_output output_bad
 
-        task = described_class.new :max => 1
+        task = described_class.new max: 1
         expect(task).to succeed_with_output output_bad
       end
     end

data/spec/lib/fudge/tasks/bundler_spec.rb

@@ -11,12 +11,11 @@ class TestBundlerAwareTask
 end
 
 class TestNonBundlerAwareTask
-
   def self.name
     :test_non_bundle_aware
   end
 
-  def run(options={})
+  def run(_options = {})
     true
   end
 end
@@ -28,15 +27,15 @@ describe Fudge::Tasks::CleanBundlerEnv do
     let(:bundle_aware_task) { TestBundlerAwareTask.new }
     let(:non_bundle_aware_task) { TestNonBundlerAwareTask.new }
 
-    context "with a bundle aware task" do
-      it "should run the bundle dependent tasks successfully" do
+    context 'with a bundle aware task' do
+      it 'should run the bundle dependent tasks successfully' do
         subject.tasks << bundle_aware_task
         subject.tasks << non_bundle_aware_task
 
         expect(subject.run).to be_truthy
       end
 
-      it "runs each task with a clean bundle env" do
+      it 'runs each task with a clean bundle env' do
         expect(Bundler).to receive(:with_clean_env).and_call_original
 
         subject.tasks << bundle_aware_task

data/spec/lib/fudge/tasks/cane_spec.rb

@@ -6,31 +6,31 @@ describe Fudge::Tasks::Cane do
   it_should_behave_like 'bundle aware'
 
   describe '#run' do
-    it "runs cane on the codebase" do
-      expect(subject).to run_command "cane"
+    it 'runs cane on the codebase' do
+      expect(subject).to run_command 'cane'
     end
 
     context 'with :doc => false' do
-      subject {described_class.new :doc => false }
+      subject { described_class.new doc: false }
 
-      it "runs with --no-doc" do
-        expect(subject).to run_command "cane --no-doc"
+      it 'runs with --no-doc' do
+        expect(subject).to run_command 'cane --no-doc'
       end
     end
 
     context 'with :style => false' do
-      subject {described_class.new :style => false }
+      subject { described_class.new style: false }
 
-      it "runs with --no-style" do
-        expect(subject).to run_command "cane --no-style"
+      it 'runs with --no-style' do
+        expect(subject).to run_command 'cane --no-style'
       end
     end
 
     context 'with :max_width => 100' do
-      subject {described_class.new :max_width => 100 }
+      subject { described_class.new max_width: 100 }
 
-      it "runs with --style-measure 100" do
-        expect(subject).to run_command "cane --style-measure 100"
+      it 'runs with --style-measure 100' do
+        expect(subject).to run_command 'cane --style-measure 100'
       end
     end
 

data/spec/lib/fudge/tasks/composite_task_spec.rb

@@ -8,7 +8,7 @@ end
 Fudge::Tasks.register(DummyTask2)
 
 describe Fudge::Tasks::CompositeTask do
-  subject { described_class.new do; end }
+  subject { described_class.new { ; } }
 
   describe '#run' do
     before :each do
@@ -19,20 +19,20 @@ describe Fudge::Tasks::CompositeTask do
       allow_any_instance_of(DummyTask2).to receive(:run) { |*_| @task_two_run = true }
     end
 
-    it "should run all tasks defined and return true if they all succeed" do
+    it 'should run all tasks defined and return true if they all succeed' do
       expect_any_instance_of(DummyTask).to receive(:run).and_return(true)
       expect(subject.run).to be_truthy
       expect(@task_two_run).to be_truthy
     end
 
-    it "should return false if any of the tasks fail" do
+    it 'should return false if any of the tasks fail' do
       expect_any_instance_of(DummyTask).to receive(:run).and_return(false)
       expect(subject.run).to be_falsey
       expect(@task_two_run).to be_falsey
     end
   end
 
-  describe "Using TaskDSL" do
+  describe 'Using TaskDSL' do
     describe '#task' do
       class AnotherCompositeTask < Fudge::Tasks::CompositeTask
         include Fudge::TaskDSL
@@ -49,15 +49,15 @@ describe Fudge::Tasks::CompositeTask do
 
       subject { AnotherCompositeTask.new }
 
-      it "should define a task for each new instance of the composite task" do
+      it 'should define a task for each new instance of the composite task' do
         expect(subject).to run_command 'foo bar'
       end
 
-      it "should support defining composite tasks" do
+      it 'should support defining composite tasks' do
         expect(subject.tasks[1].tasks.first).to be_a DummyTask
       end
 
-      context "when provided an output" do
+      context 'when provided an output' do
         let(:output) { StringIO.new }
         let(:formatter) { Fudge::Formatters::Simple.new(output) }
 
@@ -65,8 +65,8 @@ describe Fudge::Tasks::CompositeTask do
           allow_any_instance_of(Fudge::Tasks::Shell).to receive(:run)
         end
 
-        it "prints messages to the output instead of stdout" do
-          subject.run :formatter => formatter
+        it 'prints messages to the output instead of stdout' do
+          subject.run formatter: formatter
 
           expect(output.string).not_to be_empty
           expect(output.string).to match /Running task.*shell.*foo, bar/

data/spec/lib/fudge/tasks/cucumber_spec.rb

@@ -0,0 +1,38 @@
+require 'spec_helper'
+
+describe Fudge::Tasks::Cucumber do
+  it { is_expected.to be_registered_as :cucumber }
+
+  describe '#run' do
+    it 'turns on color if not specified' do
+      expect(subject).to run_command /--color/
+    end
+
+    it 'turns off color if specified' do
+      expect(described_class.new(color: false)).not_to run_command /--color/
+    end
+
+    it 'appends any arguments passed in' do
+      task = described_class.new('foobar', color: false)
+      expect(task).to run_command 'cucumber foobar'
+    end
+
+    it 'should default the arguments to spec/' do
+      expect(described_class.new(color: false)).to run_command 'cucumber features/'
+    end
+  end
+
+  it_should_behave_like 'bundle aware'
+
+  describe '#coverage' do
+    subject { described_class.new coverage: 99 }
+
+    it { is_expected.not_to succeed_with_output 'some dummy output with no coverage' }
+    it { is_expected.not_to succeed_with_output '98.99999%) covered' }
+    it { is_expected.not_to succeed_with_output '0.00%) covered' }
+    it { is_expected.to succeed_with_output '99.99999%) covered' }
+    it { is_expected.to succeed_with_output '100.0%) covered' }
+    it { is_expected.to succeed_with_output "Finished in 0.1 seconds\n70 examples, 0 failures\n700 / 700 LOC (100.0%) covered." }
+    it { is_expected.not_to succeed_with_output "Finished in 0.6 seconds\n70 examples, 0 failures\n384 / 700 LOC (54.86%) covered." }
+  end
+end

data/spec/lib/fudge/tasks/each_directory_spec.rb

@@ -6,7 +6,7 @@ class TestEachDirectoryTask
     :test_each_directory
   end
 
-  def run(options={})
+  def run(_options = {})
     (self.pwds ||= []) << FileUtils.pwd
   end
 end
@@ -17,7 +17,7 @@ describe Fudge::Tasks::EachDirectory do
   it { is_expected.to be_registered_as :each_directory }
 
   describe '#initialize' do
-    it "should take a directory pattern as first argument" do
+    it 'should take a directory pattern as first argument' do
       expect { described_class.new }.to raise_error ArgumentError
     end
   end
@@ -33,35 +33,35 @@ describe Fudge::Tasks::EachDirectory do
       subject.tasks << task
     end
 
-    it "should change to the given directories and run child tasks" do
+    it 'should change to the given directories and run child tasks' do
       subject.run
 
       expect(task.pwds).to eq(dirs)
     end
 
-    it "should allow explicit specification of directories through an array" do
-      ed2 = described_class.new ["spec/lib","spec/support"]
+    it 'should allow explicit specification of directories through an array' do
+      ed2 = described_class.new ['spec/lib', 'spec/support']
       ed2.tasks << task
       ed2.run
       expect(task.pwds).to eq(dirs.sort)
     end
 
-    it "should respect the order of the directories as specified" do
-      ed2 = described_class.new ["spec/support","spec/lib"]
+    it 'should respect the order of the directories as specified' do
+      ed2 = described_class.new ['spec/support', 'spec/lib']
       ed2.tasks << task
       ed2.run
       expect(task.pwds).not_to eq(dirs.sort)
       expect(task.pwds.sort).to eq(dirs.sort)
     end
 
-    it "should load fudge_settings.yml in the right directory" do
+    it 'should load fudge_settings.yml in the right directory' do
       ed2 = described_class.new ['spec/lib']
       ed2.tasks << Fudge::Tasks::Shell.new('pwd')
       ed2.run
       expect(ed2.tasks.first.options[:test]).to eq('coverage')
     end
 
-    it "should not load fudge_settings.yml in the wrong directory" do
+    it 'should not load fudge_settings.yml in the wrong directory' do
       ed2 = described_class.new ['spec/support']
       ed2.tasks << Fudge::Tasks::Shell.new('pwd')
       ed2.run