RubyGems - freeform - Versions diffs - 1.0.11 → 2.0.0 - Mend

freeform 1.0.11 → 2.0.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (34) hide show

checksums.yaml +8 -8
data/Gemfile.lock +3 -3
data/README.md +16 -17
data/lib/freeform/form/date_params_filter.rb +34 -0
data/lib/freeform/form/model.rb +56 -0
data/lib/freeform/form/nested.rb +64 -39
data/lib/freeform/form/property.rb +31 -75
data/lib/freeform/form/validation.rb +48 -34
data/lib/freeform/form.rb +31 -42
data/lib/freeform/version.rb +1 -1
data/spec/acceptance_spec.rb +140 -260
data/spec/builder/builder_spec.rb +23 -41
data/spec/builder/view_helper_spec.rb +7 -16
data/spec/dummy/app/forms/project_form.rb +16 -2
data/spec/dummy/app/models/company.rb +2 -2
data/spec/dummy/app/models/milestone.rb +3 -3
data/spec/dummy/app/models/project.rb +3 -3
data/spec/dummy/app/models/task.rb +2 -2
data/spec/dummy/db/migrate/20110710143903_initial_tables.rb +5 -5
data/spec/dummy/db/schema.rb +6 -4
data/spec/dummy/db/test.sqlite3 +0 -0
data/spec/form/date_params_filter_spec.rb +51 -0
data/spec/form/form_input_key_spec.rb +9 -11
data/spec/form/model_spec.rb +244 -0
data/spec/form/nested_spec.rb +108 -138
data/spec/form/persistence_spec.rb +304 -0
data/spec/form/property_spec.rb +104 -256
data/spec/form/validation_spec.rb +114 -127
data/spec/spec_helper.rb +6 -0
metadata +10 -10
data/spec/dummy/app/forms/milestone_form.rb +0 -4
data/spec/dummy/app/forms/task_form.rb +0 -11
data/spec/dummy/log/test.log +0 -111133
data/spec/persistence_spec.rb +0 -645

data/spec/persistence_spec.rb DELETED Viewed

@@ -1,645 +0,0 @@
-require 'spec_helper'
-describe FreeForm::Form do
-  let!(:task_class) do
-    klass = Class.new(FreeForm::Form) do
-      form_input_key :task
-      form_model :task
-      validate_models
-      allow_destroy_on_save
-      property :name,          :on => :task
-      property :start_date,    :on => :task
-      property :end_date,      :on => :task
-    end
-    # This wrapper just avoids CONST warnings
-    v, $VERBOSE = $VERBOSE, nil
-      Module.const_set("TaskForm", klass)
-    $VERBOSE = v
-    klass
-  end
-  let(:form_class) do
-    klass = Class.new(FreeForm::Form) do
-      form_input_key :company
-      form_models :company
-      child_model :project do
-        company.project.present? ? company.project : company.build_project
-      end
-      validate_models
-      allow_destroy_on_save
-      property :name,     :on => :company, :as => :company_name
-      property :name,     :on => :project, :as => :project_name
-      property :due_date, :on => :project
-      has_many :tasks, :class => Module::TaskForm, :default_initializer => :default_task_initializer
-      def default_task_initializer
-        { :task => project.tasks.build }
-      end
-    end
-    # This wrapper just avoids CONST warnings
-    v, $VERBOSE = $VERBOSE, nil
-      Module.const_set("AcceptanceForm", klass)
-    $VERBOSE = v
-    klass
-  end
-  let(:company) { Company.create!(:name => "Demo Corporation") }
-  let(:project) { Project.create!(:company => company, :name => "Widget", :due_date => Date.new(2014, 1, 1)) }
-  let(:task_1)  { Task.create!(:project => project, :name => "Task 1", :start_date => Date.new(2014, 2, 2), :end_date => Date.new(2014, 3, 3)) }
-  let(:task_2)  { Task.create!(:project => project, :name => "Task 2", :start_date => Date.new(2014, 9, 1), :end_date => Date.new(2014, 10, 1)) }
-  let(:form) do
-    f = form_class.new( :company => company )
-    company.project.tasks.each do |task|
-      f.build_task(:task => task)
-    end
-    f
-  end
-  before(:each) do
-    company.reload
-    project.reload
-    task_1.reload
-    task_2.reload
-  end
-  describe "form initialization", :initialization => true do
-    it "initializes with Company model" do
-      form.company.should eq(company)
-    end
-    it "initializes with Project model" do
-      form.project.should eq(project)
-    end
-    it "initializes with Task model" do
-      form.tasks.first.task.should eq(task_1)
-    end
-    it "initializes with Task with project parent" do
-      task = form.tasks.first.task
-      task.project.should eq(form.project)
-    end
-  end
-  describe "building nested models", :nested_models => true do
-    it "can build multiple tasks" do
-      form.tasks.count.should eq(2)
-      form.build_task
-      form.tasks.count.should eq(3)
-    end
-    it "build new models for each task" do
-      form.build_task
-      task_1 = form.tasks.first.task
-      task_2 = form.tasks.last.task
-      task_1.should_not eq(task_2)
-    end
-    it "builds new tasks with project parent" do
-      form.build_task
-      task_1 = form.tasks.first.task
-      task_2 = form.tasks.last.task
-      task_1.project.should eq(task_2.project)
-    end
-  end
-  describe "assigning parameters", :assign_params => true do
-    let(:attributes) do {
-      :company_name => "dummycorp",
-      :project_name => "railsapp",
-      "due_date(1i)" => "2014",
-      "due_date(2i)" => "10",
-      "due_date(3i)" => "30",
-      :tasks_attributes => {
-        "0" => {
-          :name => "task_1",
-          "start_date(1i)" => "2012",
-          "start_date(2i)" => "1",
-          "start_date(3i)" => "2",
-        },
-        "1" => {
-          :name => "task_2",
-          "end_date(1i)" => "2011",
-          "end_date(2i)" => "12",
-          "end_date(3i)" => "15",
-        }
-      } }
-    end
-    before(:each) do
-      form.fill(attributes)
-    end
-    it "assigns company name" do
-      form.company_name.should eq("dummycorp")
-      form.company.name.should eq("dummycorp")
-    end
-    it "assigns project name" do
-      form.project_name.should eq("railsapp")
-      form.project.name.should eq("railsapp")
-    end
-    it "assigns project due date" do
-      form.due_date.should eq(Date.new(2014, 10, 30))
-      form.project.due_date.should eq(Date.new(2014, 10, 30))
-    end
-    it "builds new task automatically" do
-      form.tasks.count.should eq(2)
-    end
-    it "assigns first task name" do
-      form.tasks.first.task.name.should eq("task_1")
-    end
-    it "assigns first task start_date" do
-      form.tasks.first.task.start_date.should eq(Date.new(2012, 1, 2))
-    end
-    it "assigns second task name" do
-      form.tasks.last.task.name.should eq("task_2")
-    end
-    it "assigns second task end_date" do
-      form.tasks.last.task.end_date.should eq(Date.new(2011, 12, 15))
-    end
-  end
-  describe "validations", :validations => true do
-    context "with invalid attributes" do
-      let(:attributes) do {
-        :company_name => "dummycorp",
-        :project_name => nil,
-        "due_date(1i)" => "2014",
-        "due_date(2i)" => "10",
-        "due_date(3i)" => "30",
-        :tasks_attributes => {
-          "0" => {
-            :name => "task_1",
-            "start_date(1i)" => "2012",
-            "start_date(2i)" => "1",
-            "start_date(3i)" => "2",
-          },
-          "1" => {
-            :name => "task_2",
-            "end_date(1i)" => "2011",
-            "end_date(2i)" => "12",
-            "end_date(3i)" => "15",
-          }
-        } }
-      end
-      before(:each) do
-        form.fill(attributes)
-        form.valid?
-      end
-      it "should be invalid" do
-        form.should_not be_valid
-      end
-      it "should have errors on project name" do
-        form.errors[:project_name].should eq(["can't be blank"])
-      end
-      it "should not have errors on last tasks's start_date" do
-        form.tasks.last.errors[:start_date].should be_empty
-      end
-    end
-    context "with invalid nested model only" do
-      let(:attributes) do {
-        :company_name => "dummycorp",
-        :project_name => "rails app",
-        "due_date(1i)" => "2014",
-        "due_date(2i)" => "10",
-        "due_date(3i)" => "30",
-        :tasks_attributes => {
-          "0" => {
-            :name => "task_1",
-            "start_date(1i)" => nil,
-            "start_date(2i)" => nil,
-            "start_date(3i)" => nil,
-          },
-          "1" => {
-            :name => "task_2",
-            "end_date(1i)" => "2011",
-            "end_date(2i)" => "12",
-            "end_date(3i)" => "15",
-          }
-        } }
-      end
-      before(:each) do
-        form.fill(attributes)
-        form.valid?
-      end
-      it "should be invalid" do
-        form.should_not be_valid
-      end
-      it "should have errors on first tasks's start_date" do
-        form.tasks.first.errors[:start_date].should eq(["can't be blank"])
-      end
-    end
-    context "with valid attributes" do
-      let(:attributes) do {
-        :company_name => "dummycorp",
-        :project_name => "railsapp",
-        "due_date(1i)" => "2014",
-        "due_date(2i)" => "10",
-        "due_date(3i)" => "30",
-        :tasks_attributes => {
-          "0" => {
-            :name => "task_1",
-            "start_date(1i)" => "2012",
-            "start_date(2i)" => "1",
-            "start_date(3i)" => "2",
-          },
-          "1" => {
-            :name => "task_2",
-            "start_date(1i)" => "2011",
-            "start_date(2i)" => "8",
-            "start_date(3i)" => "15",
-            "end_date(1i)" => "2011",
-            "end_date(2i)" => "12",
-            "end_date(3i)" => "15",
-          }
-        } }
-      end
-      before(:each) do
-        form.fill(attributes)
-      end
-      it "should be valid" do
-        form.should be_valid
-      end
-    end
-  end
-  describe "saving and destroying", :saving => true do
-    context "with invalid attributes" do
-      let(:attributes) do {
-        :company_name => "dummycorp",
-        :project_name => nil,
-        "due_date(1i)" => "2014",
-        "due_date(2i)" => "10",
-        "due_date(3i)" => "30",
-        :tasks_attributes => {
-          "0" => {
-            :name => "task_1",
-            "start_date(1i)" => "2012",
-            "start_date(2i)" => "1",
-            "start_date(3i)" => "2",
-          },
-          "1" => {
-            :name => "task_2",
-            "end_date(1i)" => "2011",
-            "end_date(2i)" => "12",
-            "end_date(3i)" => "15",
-          }
-        } }
-      end
-      before(:each) do
-        form.fill(attributes)
-      end
-      it "should return false on 'save'" do
-        form.save.should be_false
-      end
-      it "should raise error on 'save!'" do
-        expect{ form.save! }.to raise_error(FreeForm::FormInvalid)
-      end
-    end
-    context "with invalid, marked for destruction attributes", :failing => true do
-      let(:attributes) do {
-        :company_name => "dummycorp",
-        :project_name => "my_project",
-        "due_date(1i)" => "2014",
-        "due_date(2i)" => "10",
-        "due_date(3i)" => "30",
-        :tasks_attributes => {
-          "0" => {
-            :name => "task_1",
-            "start_date(1i)" => "2012",
-            "start_date(2i)" => "1",
-            "start_date(3i)" => "2",
-          },
-          "1" => {
-            :name => "task_2",
-            "end_date(1i)" => "2011",
-            "end_date(2i)" => "12",
-            "end_date(3i)" => "15",
-            :_destroy => "1"
-          }
-        } }
-      end
-      before(:each) do
-        form.fill(attributes)
-      end
-      it "should return true on 'save'" do
-        form.save.should be_true
-      end
-      it "should not raise error on 'save!'" do
-        expect{ form.save! }.to_not raise_error
-      end
-    end
-    context "with valid attributes" do
-      let(:attributes) do {
-        :company_name => "dummycorp",
-        :project_name => "railsapp",
-        "due_date(1i)" => "2014",
-        "due_date(2i)" => "10",
-        "due_date(3i)" => "30",
-        :tasks_attributes => {
-          "0" => {
-            :name => "new_task_1",
-            "start_date(1i)" => "2012",
-            "start_date(2i)" => "1",
-            "start_date(3i)" => "2",
-          },
-          "1" => {
-            :name => "new_task_2",
-            "start_date(1i)" => "2011",
-            "start_date(2i)" => "8",
-            "start_date(3i)" => "15",
-            "end_date(1i)" => "2011",
-            "end_date(2i)" => "12",
-            "end_date(3i)" => "15",
-          }
-        } }
-      end
-      before(:each) do
-        form.fill(attributes)
-      end
-      describe "save", :save => true do
-        describe "without destroy" do
-          it "should return true on 'save', and call save on other models" do
-            form.company.should_receive(:save).and_return(true)
-            form.project.should_receive(:save).and_return(true)
-            form.tasks.first.task.should_receive(:save).and_return(true)
-            form.tasks.last.task.should_receive(:save).and_return(true)
-            form.save
-          end
-          describe "value assignment and persistence" do
-            before(:each) { form.save }
-            it "assign company values" do
-              company.reload
-              company.name.should eq("dummycorp")
-            end
-            it "assigns project values" do
-              project.reload
-              project.name.should eq("railsapp")
-              project.due_date.should eq(Date.new(2014, 10, 30))
-            end
-            it "assigns task_1 values" do
-              task_1.reload
-              task_1.name.should eq("new_task_1")
-              task_1.start_date.should eq(Date.new(2012, 1, 2))
-              task_1.end_date.should eq(Date.new(2014, 3, 3))
-            end
-            it "assigns task_1 values" do
-              task_2.reload
-              task_2.name.should eq("new_task_2")
-              task_2.start_date.should eq(Date.new(2011, 8, 15))
-              task_2.end_date.should eq(Date.new(2011, 12, 15))
-            end
-          end
-        end
-        describe "with destroy" do
-          it "destroys models on save if set" do
-            form._destroy = true
-            form.company.should_receive(:destroy).and_return(true)
-            form.project.should_receive(:destroy).and_return(true)
-            form.tasks.first.task.should_receive(:save).and_return(true)
-            form.tasks.last.task.should_receive(:save).and_return(true)
-            form.save
-          end
-          it "destroys models on save if set through attribute" do
-            form.fill({:_destroy => "1"})
-            form.company.should_receive(:destroy).and_return(true)
-            form.project.should_receive(:destroy).and_return(true)
-            form.tasks.first.task.should_receive(:save).and_return(true)
-            form.tasks.last.task.should_receive(:save).and_return(true)
-            form.save
-          end
-          describe "value assignment and persistence" do
-            before(:each) { form._destroy = true }
-            before(:each) { form.save }
-            it "destroys company" do
-              expect { company.reload }.to raise_error
-            end
-            it "destroys project" do
-              expect { project.reload }.to raise_error
-            end
-            it "assigns task_1 values" do
-              task_1.reload
-              task_1.name.should eq("new_task_1")
-              task_1.start_date.should eq(Date.new(2012, 1, 2))
-              task_1.end_date.should eq(Date.new(2014, 3, 3))
-            end
-            it "assigns task_1 values" do
-              task_2.reload
-              task_2.name.should eq("new_task_2")
-              task_2.start_date.should eq(Date.new(2011, 8, 15))
-              task_2.end_date.should eq(Date.new(2011, 12, 15))
-            end
-          end
-        end
-        describe "with nested destroy" do
-          before(:each) { form.tasks.first._destroy = true }
-          it "destroys nested models on save if set" do
-            form.company.should_receive(:save).and_return(true)
-            form.project.should_receive(:save).and_return(true)
-            form.tasks.first.task.should_receive(:destroy).and_return(true)
-            form.tasks.last.task.should_receive(:save).and_return(true)
-            form.save
-          end
-          describe "value assignment and persistence" do
-            before(:each) { form.save }
-            it "assign company values" do
-              company.reload
-              company.name.should eq("dummycorp")
-            end
-            it "assigns project values" do
-              project.reload
-              project.name.should eq("railsapp")
-              project.due_date.should eq(Date.new(2014, 10, 30))
-            end
-            it "destroys task_1" do
-              expect { task_1.reload }.to raise_error
-            end
-            it "assigns task_1 values" do
-              task_2.reload
-              task_2.name.should eq("new_task_2")
-              task_2.start_date.should eq(Date.new(2011, 8, 15))
-              task_2.end_date.should eq(Date.new(2011, 12, 15))
-            end
-          end
-        end
-      end
-      describe "save!", :save! => true do
-        describe "without destroy" do
-          it "should return true on 'save!', and call save! on other models" do
-            form.company.should_receive(:save!).and_return(true)
-            form.project.should_receive(:save!).and_return(true)
-            form.tasks.first.task.should_receive(:save!).and_return(true)
-            form.tasks.last.task.should_receive(:save!).and_return(true)
-            form.save!
-          end
-          describe "value assignment and persistence" do
-            before(:each) { form.save! }
-            it "assign company values" do
-              company.reload
-              company.name.should eq("dummycorp")
-            end
-            it "assigns project values" do
-              project.reload
-              project.name.should eq("railsapp")
-              project.due_date.should eq(Date.new(2014, 10, 30))
-            end
-            it "assigns task_1 values" do
-              task_1.reload
-              task_1.name.should eq("new_task_1")
-              task_1.start_date.should eq(Date.new(2012, 1, 2))
-              task_1.end_date.should eq(Date.new(2014, 3, 3))
-            end
-            it "assigns task_1 values" do
-              task_2.reload
-              task_2.name.should eq("new_task_2")
-              task_2.start_date.should eq(Date.new(2011, 8, 15))
-              task_2.end_date.should eq(Date.new(2011, 12, 15))
-            end
-          end
-        end
-        describe "with destroy" do
-          it "destroys models on save! if set" do
-            form._destroy = true
-            form.company.should_receive(:destroy).and_return(true)
-            form.project.should_receive(:destroy).and_return(true)
-            form.tasks.first.task.should_receive(:save!).and_return(true)
-            form.tasks.last.task.should_receive(:save!).and_return(true)
-            form.save!
-          end
-          it "destroys models on save! if set" do
-            form.fill({:_destroy => "1"})
-            form.company.should_receive(:destroy).and_return(true)
-            form.project.should_receive(:destroy).and_return(true)
-            form.tasks.first.task.should_receive(:save!).and_return(true)
-            form.tasks.last.task.should_receive(:save!).and_return(true)
-            form.save!
-          end
-          describe "value assignment and persistence" do
-            before(:each) { form._destroy = true }
-            before(:each) { form.save! }
-            it "destroys company" do
-              expect { company.reload }.to raise_error
-            end
-            it "destroys project" do
-              expect { project.reload }.to raise_error
-            end
-            it "assigns task_1 values" do
-              task_1.reload
-              task_1.name.should eq("new_task_1")
-              task_1.start_date.should eq(Date.new(2012, 1, 2))
-              task_1.end_date.should eq(Date.new(2014, 3, 3))
-            end
-            it "assigns task_1 values" do
-              task_2.reload
-              task_2.name.should eq("new_task_2")
-              task_2.start_date.should eq(Date.new(2011, 8, 15))
-              task_2.end_date.should eq(Date.new(2011, 12, 15))
-            end
-          end
-        end
-        describe "with nested destroy" do
-          it "destroys nested models on save! if set" do
-            form.tasks.last._destroy = true
-            form.company.should_receive(:save!).and_return(true)
-            form.project.should_receive(:save!).and_return(true)
-            form.tasks.first.task.should_receive(:save!).and_return(true)
-            form.tasks.last.task.should_receive(:destroy).and_return(true)
-            form.save!
-          end
-          describe "value assignment and persistence" do
-            before(:each) { form.tasks.first._destroy = true }
-            before(:each) { form.save! }
-            it "assign company values" do
-              company.reload
-              company.name.should eq("dummycorp")
-            end
-            it "assigns project values" do
-              project.reload
-              project.name.should eq("railsapp")
-              project.due_date.should eq(Date.new(2014, 10, 30))
-            end
-            it "destroys task_1" do
-              expect { task_1.reload }.to raise_error
-            end
-            it "assigns task_1 values" do
-              task_2.reload
-              task_2.name.should eq("new_task_2")
-              task_2.start_date.should eq(Date.new(2011, 8, 15))
-              task_2.end_date.should eq(Date.new(2011, 12, 15))
-            end
-          end
-        end
-      end
-    end
-  end
-end