freeform 1.0.11 → 2.0.0

data/spec/form/nested_spec.rb

@@ -3,161 +3,131 @@ require 'freeform/form/property'
 require 'freeform/form/nested'
 
 describe FreeForm::Nested do
-  describe "has_many", :has_many => true do
-    let!(:nested_class) do
-      klass = Class.new(Module) do
-        include FreeForm::Property
-        include FreeForm::Nested
+  let(:form_class) do
+    klass = Class.new(Module) do
+      include FreeForm::Model
+      include FreeForm::Property
+      include FreeForm::Nested
+      
+      def initialize(h={})
+        h.each {|k,v| send("#{k}=",v)}
+      end  
+      
+      has_many :mailing_addresses, :default_initializer => :mailing_address_initializer do
         declared_model :address
-        
         property :street, :on => :address            
-        
-        def initialize(h={})
-          h.each {|k,v| send("#{k}=",v)}
-        end  
       end
-      # This wrapper just avoids CONST warnings
-      v, $VERBOSE = $VERBOSE, nil
-        Module.const_set("MailingAddressForm", klass)
-      $VERBOSE = v
-      klass
-    end
 
-    let!(:second_nested_class) do
-      klass = Class.new(Module) do
-        include FreeForm::Property
-        include FreeForm::Nested
+      def mailing_address_initializer
+        { :address => OpenStruct.new(:id => Random.new.rand(1000000)) }
+      end
+
+      has_many :phone_numbers, :default_initializer => :phone_number_initializer do
         declared_model :phone
-        
-        property :number, :on => :phone
-        
-        def initialize(h={})
-          h.each {|k,v| send("#{k}=",v)}
-        end  
+        property :number, :on => :phone        
       end
-      # This wrapper just avoids CONST warnings
-      v, $VERBOSE = $VERBOSE, nil
-        Module.const_set("PhoneNumberForm", klass)
-      $VERBOSE = v
-      klass
-    end
 
-    let(:form_class) do
-      klass = Class.new(Module) do
-        include FreeForm::Property
-        include FreeForm::Nested
-        
-        def initialize(h={})
-          h.each {|k,v| send("#{k}=",v)}
-        end  
-        
-        has_many :mailing_addresses, :class => Module::MailingAddressForm, :default_initializer => :mailing_address_initializer
-        def mailing_address_initializer
-          { :address => OpenStruct.new(:id => Random.new.rand(1000000)) }
-        end
-
-        has_many :phone_numbers, :class => Module::PhoneNumberForm, :default_initializer => :phone_number_initializer
-        def phone_number_initializer
-          { :phone => OpenStruct.new(:id => Random.new.rand(1000000)) }
-        end
+      def phone_number_initializer
+        { :phone => OpenStruct.new(:id => Random.new.rand(1000000)) }
       end
-      # This wrapper just avoids CONST warnings
-      v, $VERBOSE = $VERBOSE, nil
-        Module.const_set("DummyForm", klass)
-      $VERBOSE = v
-      klass
     end
+    # This wrapper just avoids CONST warnings
+    v, $VERBOSE = $VERBOSE, nil
+      Module.const_set("ParentForm", klass)
+    $VERBOSE = v
+    klass
+  end
 
-    let(:form) do
-      form_model = form_class.new
+  let(:form) do
+    form_model = form_class.new
+  end
+
+  describe "form class" do
+    it "has correct class" do
+      form.should be_a(Module::ParentForm)
     end
 
-    describe "form class" do
-      it "sets nested_form in models" do
-        form_class.models.should eq([:mailing_addresses, :phone_numbers])
-      end
+    it "has nested forms" do
+      form_class.nested_forms.should eq([Module::ParentForm::MailingAddress, Module::ParentForm::PhoneNumber])
     end
-    
-    describe "building nested models" do
-      it "initializes with no nested models prebuilt" do
-        form.mailing_addresses.should eq([])
-        form.phone_numbers.should eq([])
+
+    describe "mailing address nested form class" do
+      let(:nested_form) { form_class.nested_forms.first.new }
+
+      it "should be a MailingAddress object" do
+        nested_form.should be_a(Module::ParentForm::MailingAddress)
       end
-      
-      context "with default initializer" do
-        context "for mailing addresses" do
-          it "allows nested_forms to be built" do
-            form.build_mailing_addresses
-            form.mailing_addresses.should be_an(Array)
-            form.mailing_addresses.should_not be_empty
-            form.mailing_addresses.first.should be_a(Module::MailingAddressForm)
-          end
-    
-          it "does not add to other has_many array" do
-            form.build_mailing_addresses
-            form.phone_numbers.should eq([])
-          end
-
-          it "builds unique models" do
-            form = form_class.new
-            form.build_mailing_address
-            form.build_mailing_address
-            address_1 = form.mailing_addresses.first.address
-            address_2 = form.mailing_addresses.last.address
-            address_1.should_not eq(address_2)
-          end
-        end
-
-        context "for phone numbers" do
-          it "allows nested_forms to be built" do
-            form.build_phone_number
-            form.phone_numbers.should be_an(Array)
-            form.phone_numbers.should_not be_empty
-            form.phone_numbers.first.should be_a(Module::PhoneNumberForm)
-          end
-    
-          it "does not add to other has_many array" do
-            form.build_phone_numbers
-            form.mailing_addresses.should eq([])
-          end
-
-          it "builds unique models" do
-            form = form_class.new
-            form.build_phone_number
-            form.build_phone_number
-            phone_1 = form.phone_numbers.first.phone
-            phone_2 = form.phone_numbers.last.phone
-            phone_1.should_not eq(phone_2)
-          end
-        end
+
+      it "should respond to property methods" do
+        nested_form.should respond_to(:street)
       end
-      
-      context "with custom initializer" do
-        it "allows nested_forms to be built" do
-          form.build_mailing_addresses(:address => OpenStruct.new)
-          form.mailing_addresses.should be_an(Array)
-          form.mailing_addresses.should_not be_empty
-          form.mailing_addresses.first.should be_a(Module::MailingAddressForm)
-        end
-        
-        it "allows nested_forms to be built with custom initializers" do
-          form.build_mailing_address(:address => OpenStruct.new(:street => "1600 Pennsylvania Ave."))
-          form.mailing_addresses.first.street.should eq("1600 Pennsylvania Ave.")
-        end
+    end
+
+    describe "phone number nested form class" do
+      let(:nested_form) { form_class.nested_forms.last.new }
+
+      it "should be a PhoneNumber object" do
+        nested_form.should be_a(Module::ParentForm::PhoneNumber)
       end
+
+      it "should respond to property methods" do
+        nested_form.should respond_to(:number)
+      end
+    end
+  end
+  
+  describe "building nested models" do
+    it "responds to mailing_addresses" do
+      form.should respond_to(:mailing_addresses)
+    end
+
+    it "responds to phone_numbers" do
+      form.should respond_to(:phone_numbers)
     end
-    
-    describe "setting attributes" do
-      describe "nested attribute assignment" do
-        let(:attributes) do
-          { :mailing_addresses_attributes => { "0" => { :street => "123 Main St." } } }
-        end
-
-        it "assigns nested attributes" do
-          form.fill(attributes)
-          form.mailing_addresses.first.street.should eq("123 Main St.")
-        end
+
+    it "initializes with no nested models prebuilt" do
+      form.mailing_addresses.should eq([])
+      form.phone_numbers.should eq([])
+    end
+
+    describe "building new nested models" do
+      it "can build new nested model" do
+        form.build_mailing_address
+        form.mailing_addresses.should_not be_empty
+        form.mailing_addresses.first.should be_a(Module::ParentForm::MailingAddress)
+      end
+
+      it "builds unique models" do
+        form.build_mailing_address
+        form.build_mailing_address
+        address_model_1 = form.mailing_addresses.first
+        address_model_2 = form.mailing_addresses.last
+        address_model_1.should_not eq(address_model_2)
+        address_model_1.address.should_not eq(address_model_2.address)
+      end
+
+      it "builds with correct default initializer" do
+        address_model = form.build_mailing_address
+        address_model.address.should be_a(OpenStruct)
+      end
+
+      it "builds with custom initializer" do
+        address_model = form.build_mailing_address({:address => Date.new})
+        address_model.address.should be_a(Date)
       end
-    end      
+    end    
   end
+  
+  describe "setting attributes" do
+    describe "nested attribute assignment" do
+      let(:attributes) do
+        { :mailing_addresses_attributes => { "0" => { :street => "123 Main St." } } }
+      end
+
+      it "assigns nested attributes" do
+        form.fill(attributes)
+        form.mailing_addresses.first.street.should eq("123 Main St.")
+      end
+    end
+  end      
 end

data/spec/form/persistence_spec.rb

@@ -0,0 +1,304 @@
+require 'spec_helper'
+
+describe FreeForm::Form do
+  let(:form_class) do
+    klass = Class.new(FreeForm::Form) do
+      form_input_key :task
+      form_models :task
+      validate_models
+      allow_destroy_on_save
+
+      property :name,        :on => :task
+      property :start_date,  :on => :task
+      property :end_date,    :on => :task
+      validates :name, :presence => true
+
+      has_many :milestones do
+        form_input_key :milestone
+        form_model :milestone
+        validate_models
+        allow_destroy_on_save
+
+        property :name,          :on => :milestone
+      end
+
+      def milestone_initializer
+        { :milestone => task.milestones.build }
+      end
+    end
+    # This wrapper just avoids CONST warnings
+    v, $VERBOSE = $VERBOSE, nil
+      Module.const_set("AcceptanceForm", klass)
+    $VERBOSE = v
+    klass
+  end
+
+  let(:company) { Company.create!(:name => "Demo Corporation") }
+  let(:project) { Project.create!(:owner => company, :name => "Widget", :due_date => Date.new(2014, 1, 1)) }
+  let(:task)  { Task.new(:project => project) }
+
+  let(:form) do
+    form_class.new( :task => task ).tap do |f|
+      f.build_milestone
+    end
+  end
+
+  before(:each) { Milestone.destroy_all }
+
+  describe "form initialization", :initialization => true do
+    it "initializes with task model" do
+      form.task.should eq(task)
+    end
+
+    it "initializes with a milestone model" do
+      form.milestones.should_not be_empty
+    end
+  end
+
+  describe "saving", :saving => true do
+    context "with invalid attributes on primary form" do
+      let(:attributes) do {
+        :name => nil,
+        "start_date(1i)" => "2012",
+        "start_date(2i)" => "1",
+        "start_date(3i)" => "2",
+        "end_date(1i)" => "2011",
+        "end_date(2i)" => "12",
+        "end_date(3i)" => "15",
+        :milestones_attributes => {
+          "0" => {
+            :name => "milestone_1",
+          },
+          "1310201" => {
+            :name => "milestone_2",
+          }
+        } }
+      end
+
+      before(:each) do
+        form.fill(attributes)
+      end
+
+      it "should not be valid" do
+        form.should_not be_valid
+      end
+
+      describe "#save" do
+        it "should return false on 'save'" do
+          form.save.should be_false
+        end
+
+        it "should not persist task" do
+          form.save
+          task.should_not exist_in_database
+        end
+
+        it "should not save any Milestone objects" do
+          form.save
+          Milestone.all.size.should eq(0)
+        end
+      end
+
+      describe "#save!" do
+        it "should raise error on 'save!'" do
+          expect{ form.save! }.to raise_error(FreeForm::FormInvalid)
+        end
+      end
+    end
+
+    context "with invalid attributes on nested form" do
+      let(:attributes) do {
+        :name => "newtask",
+        "start_date(1i)" => "2012",
+        "start_date(2i)" => "1",
+        "start_date(3i)" => "2",
+        "end_date(1i)" => "2011",
+        "end_date(2i)" => "12",
+        "end_date(3i)" => "15",
+        :milestones_attributes => {
+          "0" => {
+            :name => "milestone_1",
+          },
+          "1310201" => {
+            :name => nil,
+          }
+        } }
+      end
+
+      before(:each) do
+        form.fill(attributes)
+      end
+
+      it "should not be valid" do
+        form.should_not be_valid
+      end
+
+      describe "#save" do
+        it "should return false on 'save'" do
+          form.save.should be_false
+        end
+
+        it "should not persist task" do
+          form.save
+          task.should_not exist_in_database
+        end
+
+        it "should not save any Milestone objects" do
+          form.save
+          Milestone.all.size.should eq(0)
+        end
+      end
+
+      describe "#save!" do
+        it "should raise error on 'save!'" do
+          expect{ form.save! }.to raise_error(FreeForm::FormInvalid)
+        end
+      end
+    end
+
+    context "with invalid attributes on destroyed nested form" do
+      let(:attributes) do {
+        :name => "newtask",
+        "start_date(1i)" => "2012",
+        "start_date(2i)" => "1",
+        "start_date(3i)" => "2",
+        "end_date(1i)" => "2011",
+        "end_date(2i)" => "12",
+        "end_date(3i)" => "15",
+        :milestones_attributes => {
+          "0" => {
+            :name => "milestone_1",
+          },
+          "1310201" => {
+            :name => nil,
+            :_destroy => "1",
+          }
+        } }
+      end
+
+      before(:each) do
+        form.fill(attributes)
+      end
+
+      it "should not be valid" do
+        form.should be_valid
+      end
+
+      describe "#save" do
+        it "should return true on 'save'" do
+          form.save.should be_true
+        end
+
+        it "should persist task" do
+          form.save
+          task.should exist_in_database
+        end
+
+        it "should save one Milestone object" do
+          form.save
+          Milestone.all.size.should eq(1)
+        end
+      end
+
+      describe "#save!" do
+        it "should not raise error on 'save!'" do
+          expect{ form.save! }.to_not raise_error
+        end
+      end
+    end
+
+    context "with valid attributes and multiple nested forms" do
+      let(:attributes) do {
+        :name => "newtask",
+        "start_date(1i)" => "2012",
+        "start_date(2i)" => "1",
+        "start_date(3i)" => "2",
+        "end_date(1i)" => "2011",
+        "end_date(2i)" => "12",
+        "end_date(3i)" => "15",
+        :milestones_attributes => {
+          "0" => {
+            :name => "milestone_1",
+          },
+          "1310201" => {
+            :name => "milestone_2",
+          },
+          "9837373" => {
+            :name => "milestone_3",
+          }
+        } }
+      end
+
+      before(:each) do
+        form.fill(attributes)
+      end
+
+      it "should not be valid" do
+        form.should be_valid
+      end
+
+      describe "#save" do
+        it "should return true on 'save'" do
+          form.save.should be_true
+        end
+
+        it "should persist task" do
+          form.save
+          task.should exist_in_database
+        end
+
+        it "should save three Milestone objects" do
+          form.save
+          Milestone.all.size.should eq(3)
+        end
+      end
+
+      describe "#save!" do
+        it "should not raise error on 'save!'" do
+          expect{ form.save! }.to_not raise_error
+        end
+      end
+    end
+  end
+
+  describe "destroying", :destroying => true do
+    context "without nested forms" do
+      let(:task) { Task.create!(:project => project, :name => "mytask", :start_date => Date.new(2011, 1, 1), :end_date => Date.new(2012, 1, 1)) }
+
+      let(:form) do
+        form_class.new( :task => task )
+      end
+
+      it "destroys all models in form" do
+        form.destroy
+        task.should_not exist_in_database
+      end
+    end
+
+    context "with nested forms" do
+      let(:task) { Task.create!(:project => project, :name => "mytask", :start_date => Date.new(2011, 1, 1), :end_date => Date.new(2012, 1, 1)) }
+      let(:milestone) do
+        task.milestones.build do |m|
+          m.name = "dummy_milestone"
+          m.save!
+        end
+      end 
+
+      let(:form) do
+        form_class.new( :task => task ).tap do |f|
+          f.build_milestone(:milestone => milestone)
+        end
+      end
+
+      it "destroys all models in form" do
+        form.destroy
+        task.should_not exist_in_database
+      end
+
+      it "destroys all nested models" do
+        form.destroy
+        milestone.should_not exist_in_database
+      end
+    end
+  end
+end