fpm-cookery 0.19.0 → 0.20.0

data/spec/source_integrity_check_spec.rb

@@ -2,175 +2,162 @@ require 'spec_helper'
 require 'fpm/cookery/source_integrity_check'
 require 'fpm/cookery/recipe'
 
-class TestRecipe < FPM::Cookery::Recipe
-  source 'http://example.com/foo.tar.gz'
-end
-
 describe "SourceIntegrityCheck" do
-  let(:recipe) { TestRecipe.new(__FILE__) }
+  let(:recipe_class) do
+    Class.new(FPM::Cookery::Recipe) {
+      source 'http://example.com/foo.tar.gz'
+    }
+  end
+
+  let(:config) { double('Config').as_null_object }
+  let(:recipe) { recipe_class.new(__FILE__, config) }
   let(:check) { FPM::Cookery::SourceIntegrityCheck.new(recipe) }
 
   before do
-    recipe.source_handler.instance_eval do
-      def local_path
-        fixture_path('test-source-1.0.tar.gz')
-      end
-    end
+    allow(recipe).to receive(:local_path).and_return(fixture_path('test-source-1.0.tar.gz'))
   end
 
   describe "without any checksum defined" do
     describe "#error?" do
       it "returns true" do
-        check.error?.must_equal true
+        expect(check.error?).to eq(true)
       end
     end
 
     describe "#checksum_missing?" do
       it "returns true" do
-        check.checksum_missing?.must_equal true
+        expect(check.checksum_missing?).to eq(true)
       end
     end
 
     it "has checksum_expected set to nil" do
-      check.checksum_expected.must_equal nil
+      expect(check.checksum_expected).to eq(nil)
     end
 
     it "has checksum_actual set to the sha256 checksum" do
-      check.checksum_actual.must_equal '285a6b8098ecc9040ece8f621e37c20edba39545c5d195c4894f410ed9d44b22'
+      expect(check.checksum_actual).to eq('285a6b8098ecc9040ece8f621e37c20edba39545c5d195c4894f410ed9d44b22')
     end
 
     it "has filename set" do
-      check.filename.must_equal fixture_path('test-source-1.0.tar.gz')
+      expect(check.filename).to eq(fixture_path('test-source-1.0.tar.gz'))
     end
 
     it "has digest set to nil" do
-      check.digest.must_equal :sha256
+      expect(check.digest).to eq(:sha256)
     end
   end
 
   describe "with a correct sha256 checksum defined" do
     describe "#error?" do
       it "returns false" do
-        def recipe.sha256
-          '285a6b8098ecc9040ece8f621e37c20edba39545c5d195c4894f410ed9d44b22'
-        end
+        allow(recipe).to receive(:sha256).and_return('285a6b8098ecc9040ece8f621e37c20edba39545c5d195c4894f410ed9d44b22')
 
-        check.error?.must_equal false
+        expect(check.error?).to eq(false)
       end
     end
   end
 
   describe "with a wrong sha256 checksum defined" do
     before do
-      def recipe.sha256
-        'xxxx6b8098ecc9040ece8f621e37c20edba39545c5d195c4894f410ed9d44b22'
-      end
+      allow(recipe).to receive(:sha256).and_return('xxxx6b8098ecc9040ece8f621e37c20edba39545c5d195c4894f410ed9d44b22')
     end
 
     describe "#error?" do
       it "returns true" do
-        check.error?.must_equal true
+        expect(check.error?).to eq(true)
       end
     end
 
     it "has checksum_expected set to the expected checksum" do
-      check.checksum_expected.must_equal 'xxxx6b8098ecc9040ece8f621e37c20edba39545c5d195c4894f410ed9d44b22'
+      expect(check.checksum_expected).to eq('xxxx6b8098ecc9040ece8f621e37c20edba39545c5d195c4894f410ed9d44b22')
     end
 
     it "has checksum_actual set to the actual checksum" do
-      check.checksum_actual.must_equal '285a6b8098ecc9040ece8f621e37c20edba39545c5d195c4894f410ed9d44b22'
+      expect(check.checksum_actual).to eq('285a6b8098ecc9040ece8f621e37c20edba39545c5d195c4894f410ed9d44b22')
     end
 
     it "has filename set" do
-      check.filename.must_equal fixture_path('test-source-1.0.tar.gz')
+      expect(check.filename).to eq(fixture_path('test-source-1.0.tar.gz'))
     end
 
     it "has digest set to :sha256" do
-      check.digest.must_equal :sha256
+      expect(check.digest).to eq(:sha256)
     end
   end
 
   describe "with a correct sha1 checksum defined" do
     describe "#error?" do
       it "returns false" do
-        def recipe.sha1
-          'dd4a8575c60f8122c30d21dfeed9f23f64948bf7'
-        end
+        allow(recipe).to receive(:sha1).and_return('dd4a8575c60f8122c30d21dfeed9f23f64948bf7')
 
-        check.error?.must_equal false
+        expect(check.error?).to eq(false)
       end
     end
   end
 
   describe "with a wrong sha1 checksum defined" do
     before do
-      def recipe.sha1
-        'xxxx8575c60f8122c30d21dfeed9f23f64948bf7'
-      end
+      allow(recipe).to receive(:sha1).and_return('xxxx8575c60f8122c30d21dfeed9f23f64948bf7')
     end
 
     describe "#error?" do
       it "returns true" do
-        check.error?.must_equal true
+        expect(check.error?).to eq(true)
       end
     end
 
     it "has checksum_expected set to the expected checksum" do
-      check.checksum_expected.must_equal 'xxxx8575c60f8122c30d21dfeed9f23f64948bf7'
+      expect(check.checksum_expected).to eq('xxxx8575c60f8122c30d21dfeed9f23f64948bf7')
     end
 
     it "has checksum_actual set to the actual checksum" do
-      check.checksum_actual.must_equal 'dd4a8575c60f8122c30d21dfeed9f23f64948bf7'
+      expect(check.checksum_actual).to eq('dd4a8575c60f8122c30d21dfeed9f23f64948bf7')
     end
 
     it "has filename set" do
-      check.filename.must_equal fixture_path('test-source-1.0.tar.gz')
+      expect(check.filename).to eq(fixture_path('test-source-1.0.tar.gz'))
     end
 
     it "has digest set to :sha1" do
-      check.digest.must_equal :sha1
+      expect(check.digest).to eq(:sha1)
     end
   end
 
   describe "with a correct md5 checksum defined" do
     describe "#error?" do
       it "returns false" do
-        def recipe.md5
-          'd8f1330c3d1cec72287b88b2a6c1bc91'
-        end
+        allow(recipe).to receive(:md5).and_return('d8f1330c3d1cec72287b88b2a6c1bc91')
 
-        check.error?.must_equal false
+        expect(check.error?).to eq(false)
       end
     end
   end
 
   describe "with a wrong md5 checksum defined" do
     before do
-      def recipe.md5
-        'xxxx330c3d1cec72287b88b2a6c1bc91'
-      end
+      allow(recipe).to receive(:md5).and_return('xxxx330c3d1cec72287b88b2a6c1bc91')
     end
 
     describe "#error?" do
       it "returns true" do
-        check.error?.must_equal true
+        expect(check.error?).to eq(true)
       end
     end
 
     it "has checksum_expected set to the expected checksum" do
-      check.checksum_expected.must_equal 'xxxx330c3d1cec72287b88b2a6c1bc91'
+      expect(check.checksum_expected).to eq('xxxx330c3d1cec72287b88b2a6c1bc91')
     end
 
     it "has checksum_actual set to the actual checksum" do
-      check.checksum_actual.must_equal 'd8f1330c3d1cec72287b88b2a6c1bc91'
+      expect(check.checksum_actual).to eq('d8f1330c3d1cec72287b88b2a6c1bc91')
     end
 
     it "has filename set" do
-      check.filename.must_equal fixture_path('test-source-1.0.tar.gz')
+      expect(check.filename).to eq(fixture_path('test-source-1.0.tar.gz'))
     end
 
     it "has digest set to :md5" do
-      check.digest.must_equal :md5
+      expect(check.digest).to eq(:md5)
     end
   end
 end

data/spec/source_spec.rb

@@ -7,7 +7,7 @@ describe "Source" do
       it "returns true" do
         source = FPM::Cookery::Source.new('http://example.com/', :with => :git)
 
-        source.provider?.must_equal true
+        expect(source.provider?).to eq(true)
       end
     end
 
@@ -15,7 +15,7 @@ describe "Source" do
       it "returns false" do
         source = FPM::Cookery::Source.new('http://example.com/')
 
-        source.provider?.must_equal false
+        expect(source.provider?).to eq(false)
       end
     end
   end
@@ -25,7 +25,7 @@ describe "Source" do
       it "returns true" do
         source = FPM::Cookery::Source.new('file:///tmp')
 
-        source.local?.must_equal true
+        expect(source.local?).to eq(true)
       end
     end
 
@@ -33,7 +33,7 @@ describe "Source" do
       it "returns false" do
         source = FPM::Cookery::Source.new('https://www.example.com/')
 
-        source.local?.must_equal false
+        expect(source.local?).to eq(false)
       end
     end
   end
@@ -42,7 +42,7 @@ describe "Source" do
     it "returns the url path" do
       source = FPM::Cookery::Source.new('file:///opt/src/foo')
 
-      source.path.must_equal '/opt/src/foo'
+      expect(source.path).to eq('/opt/src/foo')
     end
   end
 
@@ -50,8 +50,8 @@ describe "Source" do
     it "can handle it" do
       source = FPM::Cookery::Source.new('git@github.com:foo/bar.git')
 
-      source.url.must_equal 'git@github.com:foo/bar.git'
-      source.path.must_equal 'foo/bar.git'
+      expect(source.url).to eq('git@github.com:foo/bar.git')
+      expect(source.path).to eq('foo/bar.git')
     end
   end
 end

data/spec/spec_helper.rb

@@ -1,12 +1,15 @@
-require 'minitest'
-require 'minitest/autorun'
-require 'minitest/pride'
+RSpec.configure do |config|
+  config.treat_symbols_as_metadata_keys_with_true_values = true
+  config.run_all_when_everything_filtered = true
+  config.filter_run :focus
 
-def fixture_path(file)
-  File.expand_path("../fixtures/#{file}", __FILE__)
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = 'random'
 end
 
-# For my rspec poisoned brain. ;)
-module Kernel
-  alias_method :context, :describe
+def fixture_path(file)
+  File.expand_path("../fixtures/#{file}", __FILE__)
 end

metadata

@@ -1,111 +1,111 @@
 --- !ruby/object:Gem::Specification
 name: fpm-cookery
 version: !ruby/object:Gem::Version
-  version: 0.19.0
+  version: 0.20.0
 platform: ruby
 authors:
 - Bernd Ahlers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-03 00:00:00.000000000 Z
+date: 2014-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: minitest
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '2.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '2.14'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: fpm
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.0.0
 - !ruby/object:Gem::Dependency
   name: facter
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: puppet
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: addressable
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: systemu
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: A tool for building software packages with fpm.
@@ -116,9 +116,8 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- .autotest
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE
@@ -219,12 +218,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []