fpm-cookery 0.19.0 → 0.20.0

data/spec/path_spec.rb

@@ -6,13 +6,13 @@ describe "Path" do
   describe ".pwd" do
     it "returns the current dir" do
       Dir.chdir('/tmp') do
-        FPM::Cookery::Path.pwd.to_s.must_match %r{/tmp|/private/tmp}
+        expect(FPM::Cookery::Path.pwd.to_s).to match(%r{/tmp|/private/tmp})
       end
     end
 
     it "adds the given path to the current dir" do
       Dir.chdir('/tmp') do
-        FPM::Cookery::Path.pwd('foo').to_s.must_match %r{/tmp|/private/tmp}
+        expect(FPM::Cookery::Path.pwd('foo').to_s).to match(%r{/tmp|/private/tmp})
       end
     end
   end
@@ -22,19 +22,19 @@ describe "Path" do
 
     describe "with a path fragmet" do
       it "returns a new concatenated path object" do
-        (path + 'bar').to_s.must_equal '/foo/bar'
+        expect((path + 'bar').to_s).to eq('/foo/bar')
       end
     end
 
     describe "with an absolute path" do
       it "overwrites the old path" do
-        (path + '/bar').to_s.must_equal '/bar'
+        expect((path + '/bar').to_s).to eq('/bar')
       end
     end
 
     describe "with an empty fragment" do
       it "does't modify the path" do
-        (path + '').to_s.must_equal '/foo'
+        expect((path + '').to_s).to eq('/foo')
       end
     end
   end
@@ -44,19 +44,19 @@ describe "Path" do
 
     describe "with a path fragment" do
       it "returns a new concatenated path object" do
-        (path/'bar').to_s.must_equal '/foo/bar'
+        expect((path/'bar').to_s).to eq('/foo/bar')
       end
     end
 
     describe "with an absolute path" do
       it "returns a new concatenated path object" do
-        (path/'/baz').to_s.must_equal '/foo/baz'
+        expect((path/'/baz').to_s).to eq('/foo/baz')
       end
     end
 
     describe "with a nil argument" do
       it "does not modify the path" do
-        (path/nil).to_s.must_equal '/foo'
+        expect((path/nil).to_s).to eq('/foo')
       end
     end
   end
@@ -65,10 +65,10 @@ describe "Path" do
     it "creates the directory" do
       dir = Dir.mktmpdir
       FileUtils.rm_rf(dir)
-      File.exists?(dir).must_equal false
+      expect(File.exists?(dir)).to eq(false)
 
       FPM::Cookery::Path.new(dir).mkdir
-      File.exists?(dir).must_equal true
+      expect(File.exists?(dir)).to eq(true)
 
       FileUtils.rm_rf(dir)
     end
@@ -76,9 +76,9 @@ describe "Path" do
     describe "directory exists" do
       it "does not throw an error" do
         dir = Dir.mktmpdir
-        File.exists?(dir).must_equal true
+        expect(File.exists?(dir)).to eq(true)
 
-        FPM::Cookery::Path.new(dir).mkdir.must_equal [dir]
+        expect(FPM::Cookery::Path.new(dir).mkdir).to eq([dir])
 
         FileUtils.rm_rf(dir)
       end
@@ -92,8 +92,8 @@ describe "Path" do
           path = FPM::Cookery::Path.new(dir)
           path.install([__FILE__, File.expand_path('../spec_helper.rb', __FILE__)])
 
-          File.exist?(path/File.basename(__FILE__)).must_equal true
-          File.exist?(path/'spec_helper.rb').must_equal true
+          expect(File.exist?(path/File.basename(__FILE__))).to eq(true)
+          expect(File.exist?(path/'spec_helper.rb')).to eq(true)
         end
       end
     end
@@ -104,7 +104,7 @@ describe "Path" do
           path = FPM::Cookery::Path.new(dir)
           path.install(File.expand_path('../spec_helper.rb', __FILE__) => 'foo.rb')
 
-          File.exist?(path/'foo.rb').must_equal true
+          expect(File.exist?(path/'foo.rb')).to eq(true)
         end
       end
     end
@@ -115,7 +115,7 @@ describe "Path" do
           path = FPM::Cookery::Path.new(dir)
           path.install(File.expand_path('../spec_helper.rb', __FILE__))
 
-          File.exist?(path/'spec_helper.rb').must_equal true
+          expect(File.exist?(path/'spec_helper.rb')).to eq(true)
         end
       end
     end
@@ -126,7 +126,7 @@ describe "Path" do
           path = FPM::Cookery::Path.new(dir)
           path.install(File.expand_path('../spec_helper.rb', __FILE__), 'foo.rb')
 
-          File.exist?(path/'foo.rb').must_equal true
+          expect(File.exist?(path/'foo.rb')).to eq(true)
         end
       end
     end

data/spec/recipe_spec.rb

@@ -1,39 +1,38 @@
 require 'spec_helper'
 require 'fpm/cookery/recipe'
 
-class TestRecipe < FPM::Cookery::Recipe
-  NAME = :test_recipe
-  CHECKSUM = true
-end
-
 describe "Recipe" do
-  let(:klass) { TestRecipe }
+  def stub_dir(dir, path)
+    value = path.nil? ? nil : FPM::Cookery::Path.new(path)
+    allow(config).to receive(dir).and_return(value)
+  end
 
-  before do
-    # Reset the class level instance variables.
-    klass.instance_variables.each do |v|
-      klass.instance_variable_set(v, nil)
-    end
+  let(:klass) do
+    Class.new(FPM::Cookery::Recipe)
+  end
+
+  let(:config) do
+    double('Config', :tmp_root => nil, :pkg_dir => nil, :cache_dir => nil).as_null_object
   end
 
   let(:recipe) do
-    klass.new(__FILE__)
+    klass.new(__FILE__, config)
   end
 
   it "sets the filename" do
-    recipe.filename.to_s.must_equal __FILE__
+    expect(recipe.filename.to_s).to eq(__FILE__)
   end
 
   describe "#workdir" do
     it "sets the workdir" do
-      recipe.workdir.to_s.must_equal File.dirname(__FILE__)
+      expect(recipe.workdir.to_s).to eq(File.dirname(__FILE__))
     end
 
     describe "with a relative filename path" do
       it "expands the workdir path" do
         filename = "spec/#{File.basename(__FILE__)}"
-        r = klass.new(filename)
-        r.workdir.to_s.must_equal File.dirname(__FILE__)
+        r = klass.new(filename, config)
+        expect(r.workdir.to_s).to eq(File.dirname(__FILE__))
       end
     end
   end
@@ -44,7 +43,7 @@ describe "Recipe" do
         source 'http://example.com/foo-1.0.tar.gz', :foo => 'bar'
       end
 
-      recipe.source_handler.must_be_instance_of FPM::Cookery::SourceHandler
+      expect(recipe.source_handler).to be_a(FPM::Cookery::SourceHandler)
     end
   end
 
@@ -56,8 +55,8 @@ describe "Recipe" do
 
     klass.send(attr, value)
 
-    klass.send(attr).must_equal expect
-    recipe.send(attr).must_equal expect
+    expect(klass.send(attr)).to eq(expect)
+    expect(recipe.send(attr)).to eq(expect)
   end
 
   describe "#arch" do
@@ -120,7 +119,7 @@ describe "Recipe" do
     end
 
     it "sets a default revision of 1" do
-      recipe.revision.must_equal 1
+      expect(recipe.revision).to eq(1)
     end
   end
 
@@ -142,7 +141,7 @@ describe "Recipe" do
     end
 
     it "does not set a default vendor" do
-      recipe.vendor.must_equal nil
+      expect(recipe.vendor).to eq(nil)
     end
   end
 
@@ -202,12 +201,12 @@ describe "Recipe" do
             #{name} "#{list[0]}"
             #{name} "#{list[1]}"
           end
-          klass.#{name}.size.must_equal #{list.size}
-          recipe.#{name}.size.must_equal #{list.size}
-          klass.#{name}[0].must_equal "#{list[0]}"
-          klass.#{name}[1].must_equal "#{list[1]}"
-          recipe.#{name}[0].must_equal "#{list[0]}"
-          recipe.#{name}[1].must_equal "#{list[1]}"
+          expect(klass.#{name}.size).to eq(#{list.size})
+          expect(recipe.#{name}.size).to eq(#{list.size})
+          expect(klass.#{name}[0]).to eq("#{list[0]}")
+          expect(klass.#{name}[1]).to eq("#{list[1]}")
+          expect(recipe.#{name}[0]).to eq("#{list[0]}")
+          expect(recipe.#{name}[1]).to eq("#{list[1]}")
         end
       end
     }
@@ -231,8 +230,8 @@ describe "Recipe" do
         source 'http://example.com/foo-1.0.tar.gz'
       end
 
-      klass.source.must_equal 'http://example.com/foo-1.0.tar.gz'
-      klass.new(__FILE__).source.must_equal 'http://example.com/foo-1.0.tar.gz'
+      expect(klass.source).to eq('http://example.com/foo-1.0.tar.gz')
+      expect(klass.new(__FILE__, config).source).to eq('http://example.com/foo-1.0.tar.gz')
     end
 
     describe "with specs" do
@@ -241,8 +240,8 @@ describe "Recipe" do
           source 'http://example.com/foo-1.0.tar.gz', :foo => 'bar'
         end
 
-        klass.spec.must_equal({:foo => 'bar'})
-        klass.new(__FILE__).spec.must_equal({:foo => 'bar'})
+        expect(klass.spec).to eq({:foo => 'bar'})
+        expect(klass.new(__FILE__, config).spec).to eq({:foo => 'bar'})
       end
     end
   end
@@ -253,8 +252,8 @@ describe "Recipe" do
         url 'http://example.com/foo-1.0.tar.gz'
       end
 
-      klass.source.must_equal 'http://example.com/foo-1.0.tar.gz'
-      klass.new(__FILE__).source.must_equal 'http://example.com/foo-1.0.tar.gz'
+      expect(klass.source).to eq('http://example.com/foo-1.0.tar.gz')
+      expect(klass.new(__FILE__, config).source).to eq('http://example.com/foo-1.0.tar.gz')
     end
 
     describe "with specs" do
@@ -263,8 +262,8 @@ describe "Recipe" do
           url 'http://example.com/foo-1.0.tar.gz', :foo => 'bar'
         end
 
-        klass.spec.must_equal({:foo => 'bar'})
-        klass.new(__FILE__).spec.must_equal({:foo => 'bar'})
+        expect(klass.spec).to eq({:foo => 'bar'})
+        expect(klass.new(__FILE__, config).spec).to eq({:foo => 'bar'})
       end
     end
   end
@@ -275,7 +274,7 @@ describe "Recipe" do
         source 'http://example.com/foo-1.0.tar.gz'
       end
 
-      File.basename(klass.new(__FILE__).local_path.to_s).must_equal 'foo-1.0.tar.gz'
+      expect(File.basename(klass.new(__FILE__, config).local_path.to_s)).to eq('foo-1.0.tar.gz')
     end
   end
 
@@ -292,7 +291,7 @@ describe "Recipe" do
           end
         end
 
-        klass.new(__FILE__).vendor.must_equal 'b'
+        expect(klass.new(__FILE__, config).vendor).to eq('b')
       end
     end
 
@@ -308,7 +307,7 @@ describe "Recipe" do
           end
         end
 
-        klass.new(__FILE__).vendor.must_equal 'b'
+        expect(klass.new(__FILE__, config).vendor).to eq('b')
       end
     end
 
@@ -324,7 +323,7 @@ describe "Recipe" do
           end
         end
 
-        klass.new(__FILE__).vendor.must_equal 'a'
+        expect(klass.new(__FILE__, config).vendor).to eq('a')
       end
     end
   end
@@ -346,7 +345,7 @@ describe "Recipe" do
           end
         end
 
-        klass.new(__FILE__).vendor.must_equal 'b'
+        expect(klass.new(__FILE__, config).vendor).to eq('b')
       end
     end
 
@@ -360,7 +359,7 @@ describe "Recipe" do
           end
         end
 
-        klass.new(__FILE__).vendor.must_equal 'b'
+        expect(klass.new(__FILE__, config).vendor).to eq('b')
       end
     end
 
@@ -374,7 +373,7 @@ describe "Recipe" do
           end
         end
 
-        klass.new(__FILE__).vendor.must_equal 'a'
+        expect(klass.new(__FILE__, config).vendor).to eq('a')
       end
     end
   end
@@ -383,86 +382,126 @@ describe "Recipe" do
   #############################################################################
   # Directories
   #############################################################################
+
+  describe "#tmp_root" do
+    describe "default" do
+      it "defaults to the workdir" do
+        expect(recipe.tmp_root).to eq(recipe.workdir)
+      end
+    end
+
+    describe "set manually" do
+      it "sets the tmp_root" do
+        stub_dir(:tmp_root, '/tmp')
+        expect(recipe.tmp_root.to_s).to eq('/tmp')
+      end
+    end
+
+    describe "with an argument" do
+      it "returns a concatenated path" do
+        expect(recipe.tmp_root('test')).to eq(recipe.workdir('test'))
+      end
+    end
+  end
+
   describe "#destdir" do
+    before do
+      stub_dir(:tmp_root, '/tmp')
+    end
+
     describe "default" do
       it "sets the destdir" do
-        recipe.destdir.must_equal recipe.workdir('tmp-dest')
+        expect(recipe.destdir).to eq(recipe.tmp_root('tmp-dest'))
       end
     end
 
     describe "set manually" do
       it "sets the destdir" do
         recipe.destdir = '/tmp'
-        recipe.destdir.to_s.must_equal '/tmp'
+        expect(recipe.destdir.to_s).to eq('/tmp')
       end
     end
 
     describe "with an argument" do
       it "returns a concatenated path" do
-        recipe.destdir('test').must_equal recipe.workdir('tmp-dest/test')
+        expect(recipe.destdir('test')).to eq(recipe.tmp_root('tmp-dest/test'))
       end
     end
   end
 
   describe "#builddir" do
+    before do
+      stub_dir(:tmp_root, '/tmp')
+    end
+
     describe "default" do
       it "sets the builddir" do
-        recipe.builddir.must_equal recipe.workdir('tmp-build')
+        expect(recipe.builddir).to eq(recipe.tmp_root('tmp-build'))
       end
     end
 
     describe "set manually" do
       it "sets the builddir" do
         recipe.builddir = '/tmp/jojo'
-        recipe.builddir.to_s.must_equal '/tmp/jojo'
+        expect(recipe.builddir.to_s).to eq('/tmp/jojo')
       end
     end
 
     describe "with an argument" do
       it "returns a concatenated path" do
-        recipe.builddir('test').must_equal recipe.workdir('tmp-build/test')
+        expect(recipe.builddir('test')).to eq(recipe.tmp_root('tmp-build/test'))
       end
     end
   end
 
   describe "#pkgdir" do
+    before do
+      stub_dir(:pkg_dir, '/tmp/pkg')
+    end
+
     describe "default" do
       it "sets the pkgdir" do
-        recipe.pkgdir.must_equal recipe.workdir('pkg')
+        stub_dir(:pkg_dir, nil)
+        expect(recipe.pkgdir).to eq(recipe.workdir('pkg'))
       end
     end
 
     describe "set manually" do
       it "sets the pkgdir" do
         recipe.pkgdir = '/tmp/jojo'
-        recipe.pkgdir.to_s.must_equal '/tmp/jojo'
+        expect(recipe.pkgdir.to_s).to eq('/tmp/jojo')
       end
     end
 
     describe "with an argument" do
       it "returns a concatenated path" do
-        recipe.pkgdir('test').must_equal recipe.workdir('pkg/test')
+        expect(recipe.pkgdir('test').to_s).to eq('/tmp/pkg/test')
       end
     end
   end
 
   describe "#cachedir" do
+    before do
+      stub_dir(:cache_dir, '/tmp/cache')
+    end
+
     describe "default" do
       it "sets the cachedir" do
-        recipe.cachedir.must_equal recipe.workdir('cache')
+        stub_dir(:cache_dir, nil)
+        expect(recipe.cachedir).to eq(recipe.workdir('cache'))
       end
     end
 
     describe "set manually" do
       it "sets the cachedir" do
         recipe.cachedir = '/tmp/jojo'
-        recipe.cachedir.to_s.must_equal '/tmp/jojo'
+        expect(recipe.cachedir.to_s).to eq('/tmp/jojo')
       end
     end
 
     describe "with an argument" do
       it "returns a concatenated path" do
-        recipe.cachedir('test').must_equal recipe.workdir('cache/test')
+        expect(recipe.cachedir('test').to_s).to eq('/tmp/cache/test')
       end
     end
   end
@@ -472,9 +511,9 @@ describe "Recipe" do
       klass.depends [:pkg1, :pkg2]
       klass.build_depends [:pkg3, :pkg4]
 
-      [:pkg1, :pkg2, :pkg3, :pkg4].all? { |i|
+      expect([:pkg1, :pkg2, :pkg3, :pkg4].all? { |i|
         klass.depends_all.member?(i) && recipe.depends_all.member?(i)
-      }.must_equal true
+      }).to eq(true)
     end
   end
 end