formtastic 4.0.0 → 5.0.0

data/spec/helpers/reflection_helper_spec.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 require 'spec_helper'
 
 RSpec.describe 'Formtastic::Helpers::Reflection' do
@@ -6,7 +7,7 @@ RSpec.describe 'Formtastic::Helpers::Reflection' do
   include FormtasticSpecHelper
 
   before do
-    @output_buffer = ''
+    @output_buffer = ActionView::OutputBuffer.new ''
     mock_everything
   end
 
@@ -27,6 +28,6 @@ RSpec.describe 'Formtastic::Helpers::Reflection' do
       expect(@reflection_tester.reflection_for(:sub_posts)).not_to be_nil
     end
   end
-  
-  
+
+
 end

data/spec/helpers/semantic_errors_helper_spec.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 require 'spec_helper'
 
 RSpec.describe 'Formtastic::FormBuilder#semantic_errors' do
@@ -6,7 +7,7 @@ RSpec.describe 'Formtastic::FormBuilder#semantic_errors' do
   include FormtasticSpecHelper
 
   before do
-    @output_buffer = ''
+    @output_buffer = ActionView::OutputBuffer.new ''
     mock_everything
     @title_errors = ['must not be blank', 'must be awesome']
     @base_errors = ['base error message', 'nasty error']
@@ -95,7 +96,7 @@ RSpec.describe 'Formtastic::FormBuilder#semantic_errors' do
       end
     end
   end
-  
+
   describe 'when :base is passed in as an argument' do
     before do
       allow(@errors).to receive(:[]).with(errors_matcher(:base)).and_return(@base_error)
@@ -108,5 +109,5 @@ RSpec.describe 'Formtastic::FormBuilder#semantic_errors' do
       end
     end
   end
-  
+
 end

data/spec/i18n_spec.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 require 'spec_helper'
 
 RSpec.describe 'Formtastic::I18n' do
@@ -82,7 +83,7 @@ RSpec.describe 'Formtastic::I18n' do
     include FormtasticSpecHelper
 
     before do
-      @output_buffer = ''
+      @output_buffer = ActionView::OutputBuffer.new ''
       mock_everything
 
       ::I18n.backend.store_translations :en, {:formtastic => {
@@ -117,7 +118,7 @@ RSpec.describe 'Formtastic::I18n' do
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:title))
         end)
-        expect(output_buffer).to have_tag("form label", :text => /Hello post!/)
+        expect(output_buffer.to_str).to have_tag("form label", :text => /Hello post!/)
       end
     end
 
@@ -126,7 +127,7 @@ RSpec.describe 'Formtastic::I18n' do
         concat(semantic_form_for(:project, :url => 'http://test.host') do |builder|
           concat(builder.input(:title))
         end)
-        expect(output_buffer).to have_tag("form label", :text => /Hello project!/)
+        expect(output_buffer.to_str).to have_tag("form label", :text => /Hello project!/)
       end
     end
 
@@ -135,7 +136,7 @@ RSpec.describe 'Formtastic::I18n' do
         concat(semantic_form_for(:project, :url => 'http://test.host') do |builder|
           concat(builder.input(:author))
         end)
-        expect(output_buffer).to have_tag("form label", :text => /Author/)
+        expect(output_buffer.to_str).to have_tag("form label", :text => /Author/)
       end
     end
 
@@ -146,7 +147,7 @@ RSpec.describe 'Formtastic::I18n' do
             concat(f.input(:name))
           end)
         end)
-        expect(output_buffer).to have_tag("form label", :text => /Hello author name!/)
+        expect(output_buffer.to_str).to have_tag("form label", :text => /Hello author name!/)
       end
     end
 
@@ -157,7 +158,7 @@ RSpec.describe 'Formtastic::I18n' do
             concat(f.input(:name))
           end
         end)
-        expect(output_buffer).to have_tag("form label", :text => /Hello author name!/)
+        expect(output_buffer.to_str).to have_tag("form label", :text => /Hello author name!/)
       end
     end
 
@@ -168,10 +169,10 @@ RSpec.describe 'Formtastic::I18n' do
             concat(f.input(:title))
           end
         end)
-        expect(output_buffer).to have_tag("form label", :text => /Hello project!/)
+        expect(output_buffer.to_str).to have_tag("form label", :text => /Hello project!/)
       end
     end
-    
+
     it 'should be able to translate nested forms with top level translations' do
       with_config :i18n_lookups_by_default, true do
         concat(semantic_form_for(:post) do |builder|
@@ -179,7 +180,7 @@ RSpec.describe 'Formtastic::I18n' do
             concat(f.input(:name))
           end
         end)
-        expect(output_buffer).to have_tag("form label", :text => /Hello author name!/)
+        expect(output_buffer.to_str).to have_tag("form label", :text => /Hello author name!/)
       end
     end
 
@@ -188,10 +189,10 @@ RSpec.describe 'Formtastic::I18n' do
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:body))
         end)
-        expect(output_buffer).to have_tag("form label", :text => /Elaborate/)
+        expect(output_buffer.to_str).to have_tag("form label", :text => /Elaborate/)
       end
     end
-    
+
     it 'should be able to translate nested helper label as Rails does' do
       with_config :i18n_lookups_by_default, true do
         concat(semantic_form_for(@new_post) do |builder|
@@ -199,7 +200,7 @@ RSpec.describe 'Formtastic::I18n' do
             concat(f.input(:login))
           end)
         end)
-        expect(output_buffer).to have_tag("form label", :text => /Hello login/)
+        expect(output_buffer.to_str).to have_tag("form label", :text => /Hello login/)
       end
     end
 

data/spec/input_class_finder_spec.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 require 'spec_helper'
 require 'formtastic/input_class_finder'
 

data/spec/inputs/base/collections_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'fast_spec_helper'
 require 'inputs/base/collections'
 
@@ -34,6 +35,7 @@ RSpec.describe MyInput do
         statuses = ActiveSupport::HashWithIndifferentAccess.new("active"=>0, "inactive"=>1)
         allow(model_class).to receive(:statuses) { statuses }
         allow(model).to receive(:defined_enums) { {"status" => statuses } }
+        allow(model).to receive(:model_name).and_return(double(i18n_key: model_name))
       end
 
       context 'no translations available' do

data/spec/inputs/base/validations_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'fast_spec_helper'
 require 'active_model'
 require 'inputs/base/validations'

data/spec/inputs/boolean_input_spec.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 require 'spec_helper'
 
 RSpec.describe 'boolean input' do
@@ -6,7 +7,7 @@ RSpec.describe 'boolean input' do
   include FormtasticSpecHelper
 
   before do
-    @output_buffer = ''
+    @output_buffer = ActionView::OutputBuffer.new ''
     mock_everything
   end
 
@@ -16,38 +17,38 @@ RSpec.describe 'boolean input' do
         concat(builder.input(:allow_comments, :as => :boolean))
       end)
     end
-    
+
     it_should_have_input_wrapper_with_class("boolean")
     it_should_have_input_wrapper_with_class(:input)
     it_should_have_input_wrapper_with_id("post_allow_comments_input")
     it_should_apply_error_logic_for_input_type(:boolean)
-  
+
     it 'should generate a label containing the input' do
-    expect(output_buffer).not_to have_tag('label.label')
-    expect(output_buffer).to have_tag('form li label', :count => 1)
-    expect(output_buffer).to have_tag('form li label[@for="post_allow_comments"]')
-    expect(output_buffer).to have_tag('form li label', :text => /Allow comments/)
-    expect(output_buffer).to have_tag('form li label input[@type="checkbox"]', :count => 1)
-    expect(output_buffer).to have_tag('form li input[@type="hidden"]', :count => 1)
-    expect(output_buffer).not_to have_tag('form li label input[@type="hidden"]', :count => 1) # invalid HTML5
+    expect(output_buffer.to_str).not_to have_tag('label.label')
+    expect(output_buffer.to_str).to have_tag('form li label', :count => 1)
+    expect(output_buffer.to_str).to have_tag('form li label[@for="post_allow_comments"]')
+    expect(output_buffer.to_str).to have_tag('form li label', :text => /Allow comments/)
+    expect(output_buffer.to_str).to have_tag('form li label input[@type="checkbox"]', :count => 1)
+    expect(output_buffer.to_str).to have_tag('form li input[@type="hidden"]', :count => 1)
+    expect(output_buffer.to_str).not_to have_tag('form li label input[@type="hidden"]', :count => 1) # invalid HTML5
     end
-  
+
     it 'should not add a "name" attribute to the label' do
-      expect(output_buffer).not_to have_tag('form li label[@name]')
+      expect(output_buffer.to_str).not_to have_tag('form li label[@name]')
     end
-  
+
     it 'should generate a checkbox input' do
-      expect(output_buffer).to have_tag('form li label input')
-      expect(output_buffer).to have_tag('form li label input#post_allow_comments')
-      expect(output_buffer).to have_tag('form li label input[@type="checkbox"]')
-      expect(output_buffer).to have_tag('form li label input[@name="post[allow_comments]"]')
-      expect(output_buffer).to have_tag('form li label input[@type="checkbox"][@value="1"]')
+      expect(output_buffer.to_str).to have_tag('form li label input')
+      expect(output_buffer.to_str).to have_tag('form li label input#post_allow_comments')
+      expect(output_buffer.to_str).to have_tag('form li label input[@type="checkbox"]')
+      expect(output_buffer.to_str).to have_tag('form li label input[@name="post[allow_comments]"]')
+      expect(output_buffer.to_str).to have_tag('form li label input[@type="checkbox"][@value="1"]')
     end
-  
+
     it 'should generate a checked input if object.method returns true' do
-      expect(output_buffer).to have_tag('form li label input[@checked="checked"]')
-      expect(output_buffer).to have_tag('form li input[@name="post[allow_comments]"]', :count => 2)
-      expect(output_buffer).to have_tag('form li input#post_allow_comments', :count => 1)
+      expect(output_buffer.to_str).to have_tag('form li label input[@checked="checked"]')
+      expect(output_buffer.to_str).to have_tag('form li input[@name="post[allow_comments]"]', :count => 2)
+      expect(output_buffer.to_str).to have_tag('form li input#post_allow_comments', :count => 1)
     end
   end
 
@@ -55,7 +56,7 @@ RSpec.describe 'boolean input' do
     concat(semantic_form_for(@new_post) do |builder|
       concat(builder.input(:answer_comments, :as => :boolean, :input_html => {:checked => 'checked'}))
     end)
-    expect(output_buffer).to have_tag('form li label input[@checked="checked"]')
+    expect(output_buffer.to_str).to have_tag('form li label input[@checked="checked"]')
   end
 
   it 'should name the hidden input with the :name html_option' do
@@ -63,8 +64,8 @@ RSpec.describe 'boolean input' do
       concat(builder.input(:answer_comments, :as => :boolean, :input_html => { :name => "foo" }))
     end)
 
-    expect(output_buffer).to have_tag('form li input[@type="checkbox"][@name="foo"]', :count => 1)
-    expect(output_buffer).to have_tag('form li input[@type="hidden"][@name="foo"]', :count => 1)
+    expect(output_buffer.to_str).to have_tag('form li input[@type="checkbox"][@name="foo"]', :count => 1)
+    expect(output_buffer.to_str).to have_tag('form li input[@type="hidden"][@name="foo"]', :count => 1)
   end
 
   it 'should name the hidden input with the :name html_option' do
@@ -72,33 +73,33 @@ RSpec.describe 'boolean input' do
       concat(builder.input(:answer_comments, :as => :boolean, :input_html => { :name => "foo" }))
     end)
 
-    expect(output_buffer).to have_tag('form li input[@type="checkbox"][@name="foo"]', :count => 1)
-    expect(output_buffer).to have_tag('form li input[@type="hidden"][@name="foo"]', :count => 1)
+    expect(output_buffer.to_str).to have_tag('form li input[@type="checkbox"][@name="foo"]', :count => 1)
+    expect(output_buffer.to_str).to have_tag('form li input[@type="hidden"][@name="foo"]', :count => 1)
   end
 
   it "should generate a disabled input and hidden input if :input_html is passed :disabled => 'disabled' " do
     concat(semantic_form_for(@new_post) do |builder|
       concat(builder.input(:allow_comments, :as => :boolean, :input_html => {:disabled => 'disabled'}))
     end)
-    expect(output_buffer).to have_tag('form li label input[@disabled="disabled"]', :count => 1)
-    expect(output_buffer).to have_tag('form li input[@type="hidden"][@disabled="disabled"]', :count => 1)
+    expect(output_buffer.to_str).to have_tag('form li label input[@disabled="disabled"]', :count => 1)
+    expect(output_buffer.to_str).to have_tag('form li input[@type="hidden"][@disabled="disabled"]', :count => 1)
   end
 
   it 'should generate an input[id] with matching label[for] when id passed in :input_html' do
     concat(semantic_form_for(@new_post) do |builder|
       concat(builder.input(:allow_comments, :as => :boolean, :input_html => {:id => 'custom_id'}))
     end)
-    expect(output_buffer).to have_tag('form li label input[@id="custom_id"]')
-    expect(output_buffer).to have_tag('form li label[@for="custom_id"]')
+    expect(output_buffer.to_str).to have_tag('form li label input[@id="custom_id"]')
+    expect(output_buffer.to_str).to have_tag('form li label[@for="custom_id"]')
   end
 
   it 'should allow checked and unchecked values to be sent' do
     concat(semantic_form_for(@new_post) do |builder|
       concat(builder.input(:allow_comments, :as => :boolean, :checked_value => 'checked', :unchecked_value => 'unchecked'))
     end)
-    expect(output_buffer).to have_tag('form li label input[@type="checkbox"][@value="checked"]:not([@unchecked_value][@checked_value])')
-    expect(output_buffer).to have_tag('form li input[@type="hidden"][@value="unchecked"]')
-    expect(output_buffer).not_to have_tag('form li label input[@type="hidden"]') # invalid HTML5
+    expect(output_buffer.to_str).to have_tag('form li label input[@type="checkbox"][@value="checked"]:not([@unchecked_value][@checked_value])')
+    expect(output_buffer.to_str).to have_tag('form li input[@type="hidden"][@value="unchecked"]')
+    expect(output_buffer.to_str).not_to have_tag('form li label input[@type="hidden"]') # invalid HTML5
   end
 
   it 'should generate a checked input if object.method returns checked value' do
@@ -108,7 +109,7 @@ RSpec.describe 'boolean input' do
       concat(builder.input(:allow_comments, :as => :boolean, :checked_value => 'yes', :unchecked_value => 'no'))
     end)
 
-    expect(output_buffer).to have_tag('form li label input[@type="checkbox"][@value="yes"][@checked="checked"]')
+    expect(output_buffer.to_str).to have_tag('form li label input[@type="checkbox"][@value="yes"][@checked="checked"]')
   end
 
   it 'should not generate a checked input if object.method returns unchecked value' do
@@ -118,7 +119,7 @@ RSpec.describe 'boolean input' do
       concat(builder.input(:allow_comments, :as => :boolean, :checked_value => 'yes', :unchecked_value => 'no'))
     end)
 
-    expect(output_buffer).to have_tag('form li label input[@type="checkbox"][@value="yes"]:not([@checked])')
+    expect(output_buffer.to_str).to have_tag('form li label input[@type="checkbox"][@value="yes"]:not([@checked])')
   end
 
   it 'should generate a checked input if object.method returns checked value' do
@@ -128,7 +129,7 @@ RSpec.describe 'boolean input' do
       concat(builder.input(:allow_comments, :as => :boolean, :checked_value => 'yes', :unchecked_value => 'no'))
     end)
 
-    expect(output_buffer).to have_tag('form li label input[@type="checkbox"][@value="yes"][@checked="checked"]')
+    expect(output_buffer.to_str).to have_tag('form li label input[@type="checkbox"][@value="yes"][@checked="checked"]')
   end
 
   it 'should generate a checked input for boolean database values compared to string checked values' do
@@ -138,7 +139,7 @@ RSpec.describe 'boolean input' do
       concat(builder.input(:foo, :as => :boolean))
     end)
 
-    expect(output_buffer).to have_tag('form li label input[@type="checkbox"][@value="1"][@checked="checked"]')
+    expect(output_buffer.to_str).to have_tag('form li label input[@type="checkbox"][@value="1"][@checked="checked"]')
   end
 
   it 'should generate a checked input if object.method returns checked value when inverted' do
@@ -148,7 +149,7 @@ RSpec.describe 'boolean input' do
       concat(builder.input(:allow_comments, :as => :boolean, :checked_value => 0, :unchecked_value => 1))
     end)
 
-    expect(output_buffer).to have_tag('form li label input[@type="checkbox"][@value="0"][@checked="checked"]')
+    expect(output_buffer.to_str).to have_tag('form li label input[@type="checkbox"][@value="0"][@checked="checked"]')
   end
 
   it 'should not generate a checked input if object.method returns unchecked value' do
@@ -158,7 +159,7 @@ RSpec.describe 'boolean input' do
       concat(builder.input(:allow_comments, :as => :boolean, :checked_value => 'yes', :unchecked_value => 'no'))
     end)
 
-    expect(output_buffer).to have_tag('form li label input[@type="checkbox"][@value="yes"]:not([@checked])')
+    expect(output_buffer.to_str).to have_tag('form li label input[@type="checkbox"][@value="yes"]:not([@checked])')
   end
 
   it 'should generate a label and a checkbox even if no object is given' do
@@ -166,49 +167,49 @@ RSpec.describe 'boolean input' do
       concat(builder.input(:allow_comments, :as => :boolean))
     end)
 
-    expect(output_buffer).to have_tag('form li label[@for="project_allow_comments"]')
-    expect(output_buffer).to have_tag('form li label', :text => /Allow comments/)
-    expect(output_buffer).to have_tag('form li label input[@type="checkbox"]')
+    expect(output_buffer.to_str).to have_tag('form li label[@for="project_allow_comments"]')
+    expect(output_buffer.to_str).to have_tag('form li label', :text => /Allow comments/)
+    expect(output_buffer.to_str).to have_tag('form li label input[@type="checkbox"]')
 
-    expect(output_buffer).to have_tag('form li label input#project_allow_comments')
-    expect(output_buffer).to have_tag('form li label input[@type="checkbox"]')
-    expect(output_buffer).to have_tag('form li label input[@name="project[allow_comments]"]')
+    expect(output_buffer.to_str).to have_tag('form li label input#project_allow_comments')
+    expect(output_buffer.to_str).to have_tag('form li label input[@type="checkbox"]')
+    expect(output_buffer.to_str).to have_tag('form li label input[@name="project[allow_comments]"]')
   end
-  
+
   it 'should not pass input_html options down to the label html' do
     concat(semantic_form_for(@new_post) do |builder|
       builder.input(:title, :as => :boolean, :input_html => { :tabindex => 2, :x => "X" })
     end)
-    expect(output_buffer).not_to have_tag('label[tabindex]')
-    expect(output_buffer).not_to have_tag('label[x]')
+    expect(output_buffer.to_str).not_to have_tag('label[tabindex]')
+    expect(output_buffer.to_str).not_to have_tag('label[x]')
   end
 
   context "when required" do
-    
+
     it "should add the required attribute to the input's html options" do
       with_config :use_required_attribute, true do
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:title, :as => :boolean, :required => true))
         end)
-        expect(output_buffer).to have_tag("input[@required]")
+        expect(output_buffer.to_str).to have_tag("input[@required]")
       end
     end
-      
+
     it "should not add the required attribute to the boolean fields input's html options" do
       with_config :use_required_attribute, true do
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:title, :as => :boolean))
         end)
-        expect(output_buffer).not_to have_tag("input[@required]")
+        expect(output_buffer.to_str).not_to have_tag("input[@required]")
       end
     end
-    
+
   end
 
   describe "when namespace is provided" do
 
     before do
-      @output_buffer = ''
+      @output_buffer = ActionView::OutputBuffer.new ''
       mock_everything
 
       concat(semantic_form_for(@new_post, :namespace => "context2") do |builder|
@@ -220,11 +221,11 @@ RSpec.describe 'boolean input' do
     it_should_have_an_inline_label_for("context2_post_allow_comments")
 
   end
-  
+
   describe "when index is provided" do
 
     before do
-      @output_buffer = ''
+      @output_buffer = ActionView::OutputBuffer.new ''
       mock_everything
 
       concat(semantic_form_for(@new_post) do |builder|
@@ -233,22 +234,22 @@ RSpec.describe 'boolean input' do
         end)
       end)
     end
-    
+
     it 'should index the id of the wrapper' do
-      expect(output_buffer).to have_tag("li#post_author_attributes_3_name_input")
+      expect(output_buffer.to_str).to have_tag("li#post_author_attributes_3_name_input")
     end
-    
+
     it 'should index the id of the input tag' do
-      expect(output_buffer).to have_tag("input#post_author_attributes_3_name")
+      expect(output_buffer.to_str).to have_tag("input#post_author_attributes_3_name")
     end
-    
+
     it 'should index the name of the hidden input' do
-      expect(output_buffer).to have_tag("input[@type='hidden'][@name='post[author_attributes][3][name]']")
+      expect(output_buffer.to_str).to have_tag("input[@type='hidden'][@name='post[author_attributes][3][name]']")
     end
 
     it 'should index the name of the checkbox input' do
-      expect(output_buffer).to have_tag("input[@type='checkbox'][@name='post[author_attributes][3][name]']")
+      expect(output_buffer.to_str).to have_tag("input[@type='checkbox'][@name='post[author_attributes][3][name]']")
     end
-    
+
   end
 end