formtastic 4.0.0 → 5.0.0

data/spec/actions/link_action_spec.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 require 'spec_helper'
 
 RSpec.describe 'LinkAction', 'when cancelling' do
@@ -6,49 +7,49 @@ RSpec.describe 'LinkAction', 'when cancelling' do
   include FormtasticSpecHelper
 
   before do
-    @output_buffer = ''
+    @output_buffer = ActionView::OutputBuffer.new ''
     mock_everything
   end
-  
+
   context 'without a :url' do
     before do
       concat(semantic_form_for(@new_post) do |builder|
         concat(builder.action(:cancel, :as => :link))
       end)
     end
-    
+
     it 'should render a submit type of input' do
-      expect(output_buffer).to have_tag('li.action.link_action a[@href="javascript:history.back()"]')
+      expect(output_buffer.to_str).to have_tag('li.action.link_action a[@href="javascript:history.back()"]')
     end
-    
+
   end
-  
+
   context 'with a :url as String' do
-    
+
     before do
       concat(semantic_form_for(@new_post) do |builder|
         concat(builder.action(:cancel, :as => :link, :url => "http://foo.bah/baz"))
       end)
     end
-    
+
     it 'should render a submit type of input' do
-      expect(output_buffer).to have_tag('li.action.link_action a[@href="http://foo.bah/baz"]')
+      expect(output_buffer.to_str).to have_tag('li.action.link_action a[@href="http://foo.bah/baz"]')
     end
-    
+
   end
 
   context 'with a :url as Hash' do
-    
+
     before do
       concat(semantic_form_for(@new_post) do |builder|
         concat(builder.action(:cancel, :as => :link, :url => { :action => "foo" }))
       end)
     end
-    
+
     it 'should render a submit type of input' do
-      expect(output_buffer).to have_tag('li.action.link_action a[@href="/mock/path"]')
+      expect(output_buffer.to_str).to have_tag('li.action.link_action a[@href="/mock/path"]')
     end
-    
+
   end
 
 end
@@ -56,37 +57,37 @@ end
 RSpec.describe 'LinkAction', 'when submitting' do
 
   include FormtasticSpecHelper
-  
+
   before do
-    @output_buffer = ''
+    @output_buffer = ActionView::OutputBuffer.new ''
     mock_everything
   end
-  
+
   it 'should raise an error' do
-    expect { 
+    expect {
       concat(semantic_form_for(@new_post) do |builder|
         concat(builder.action(:submit, :as => :link))
       end)
     }.to raise_error(Formtastic::UnsupportedMethodForAction)
   end
-  
+
 end
 
 RSpec.describe 'LinkAction', 'when submitting' do
 
   include FormtasticSpecHelper
-  
+
   before do
-    @output_buffer = ''
+    @output_buffer = ActionView::OutputBuffer.new ''
     mock_everything
   end
-  
+
   it 'should raise an error' do
-    expect { 
+    expect {
       concat(semantic_form_for(@new_post) do |builder|
         concat(builder.action(:reset, :as => :link))
       end)
     }.to raise_error(Formtastic::UnsupportedMethodForAction)
   end
-  
+
 end

data/spec/builder/custom_builder_spec.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 require 'spec_helper'
 
 RSpec.describe 'Formtastic::Helpers::FormHelper.builder' do
@@ -17,7 +18,7 @@ RSpec.describe 'Formtastic::Helpers::FormHelper.builder' do
   end
 
   before do
-    @output_buffer = ''
+    @output_buffer = ActionView::OutputBuffer.new ''
     mock_everything
   end
 
@@ -87,9 +88,9 @@ RSpec.describe 'Formtastic::Helpers::FormHelper.builder' do
           concat(builder.inputs)
         end)
 
-        expect(output_buffer).to_not have_tag('input#post_title')
-        expect(output_buffer).to_not have_tag('li#post_created_at_input')
-        expect(output_buffer).to have_tag('textarea#post_body')
+        expect(output_buffer.to_str).to_not have_tag('input#post_title')
+        expect(output_buffer.to_str).to_not have_tag('li#post_created_at_input')
+        expect(output_buffer.to_str).to have_tag('textarea#post_body')
       end
     end
 

data/spec/builder/error_proc_spec.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 require 'spec_helper'
 
 RSpec.describe 'Rails field_error_proc' do
@@ -6,7 +7,7 @@ RSpec.describe 'Rails field_error_proc' do
   include FormtasticSpecHelper
 
   before do
-    @output_buffer = ''
+    @output_buffer = ActionView::OutputBuffer.new ''
     mock_everything
   end
 

data/spec/builder/semantic_fields_for_spec.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 require 'spec_helper'
 
 RSpec.describe 'Formtastic::FormBuilder#fields_for' do
@@ -6,7 +7,7 @@ RSpec.describe 'Formtastic::FormBuilder#fields_for' do
   include FormtasticSpecHelper
 
   before do
-    @output_buffer = ''
+    @output_buffer = ActionView::OutputBuffer.new ''
     mock_everything
     allow(@new_post).to receive(:author).and_return(::Author.new)
   end
@@ -26,7 +27,7 @@ RSpec.describe 'Formtastic::FormBuilder#fields_for' do
         expect(nested_builder.class).to eq(Formtastic::Helpers::FormHelper.builder)
       end
     end
-    
+
     it 'should respond to input' do
       semantic_fields_for(@new_post) do |nested_builder|
         expect(nested_builder.respond_to?(:input)).to be_truthy
@@ -42,7 +43,7 @@ RSpec.describe 'Formtastic::FormBuilder#fields_for' do
       end
     end
   end
-  
+
   context 'within a form_for block' do
     it 'yields an instance of FormHelper.builder' do
       semantic_form_for(@new_post) do |builder|
@@ -51,7 +52,7 @@ RSpec.describe 'Formtastic::FormBuilder#fields_for' do
         end
       end
     end
-    
+
     it 'yields an instance of FormHelper.builder with hash-like model' do
       semantic_form_for(:user) do |builder|
         builder.semantic_fields_for(:author, @hash_backed_author) do |nested_builder|
@@ -59,7 +60,7 @@ RSpec.describe 'Formtastic::FormBuilder#fields_for' do
         end
       end
     end
-    
+
     it 'nests the object name' do
       semantic_form_for(@new_post) do |builder|
         builder.semantic_fields_for(@bob) do |nested_builder|
@@ -67,7 +68,7 @@ RSpec.describe 'Formtastic::FormBuilder#fields_for' do
         end
       end
     end
-    
+
     it 'supports passing collection as second parameter' do
       semantic_form_for(@new_post) do |builder|
         builder.semantic_fields_for(:author, [@fred,@bob]) do |nested_builder|
@@ -75,7 +76,7 @@ RSpec.describe 'Formtastic::FormBuilder#fields_for' do
         end
       end
     end
-    
+
     it 'should sanitize html id for li tag' do
       allow(@bob).to receive(:column_for_attribute).and_return(double('column', :type => :string, :limit => 255))
       concat(semantic_form_for(@new_post) do |builder|
@@ -83,12 +84,12 @@ RSpec.describe 'Formtastic::FormBuilder#fields_for' do
           concat(nested_builder.inputs(:login))
         end)
       end)
-      expect(output_buffer).to have_tag('form fieldset.inputs #post_author_1_login_input')
+      expect(output_buffer.to_str).to have_tag('form fieldset.inputs #post_author_1_login_input')
       # Not valid selector, so using good ol' regex
-      expect(output_buffer).not_to match(/id="post\[author\]_1_login_input"/)
+      expect(output_buffer.to_str).not_to match(/id="post\[author\]_1_login_input"/)
       # <=> output_buffer.should_not have_tag('form fieldset.inputs #post[author]_1_login_input')
     end
-    
+
     it 'should use namespace provided in nested fields' do
       allow(@bob).to receive(:column_for_attribute).and_return(double('column', :type => :string, :limit => 255))
       concat(semantic_form_for(@new_post, :namespace => 'context2') do |builder|
@@ -96,29 +97,29 @@ RSpec.describe 'Formtastic::FormBuilder#fields_for' do
           concat(nested_builder.inputs(:login))
         end)
       end)
-      expect(output_buffer).to have_tag('form fieldset.inputs #context2_post_author_1_login_input')
+      expect(output_buffer.to_str).to have_tag('form fieldset.inputs #context2_post_author_1_login_input')
     end
-    
+
     it 'should render errors on the nested inputs' do
       @errors = double('errors')
-      allow(@errors).to receive(:[]).with(errors_matcher(:login)).and_return(['oh noes'])      
+      allow(@errors).to receive(:[]).with(errors_matcher(:login)).and_return(['oh noes'])
       allow(@bob).to receive(:errors).and_return(@errors)
-      
+
       concat(semantic_form_for(@new_post, :namespace => 'context2') do |builder|
         concat(builder.semantic_fields_for(@bob) do |nested_builder|
           concat(nested_builder.inputs(:login))
         end)
       end)
-      expect(output_buffer).to match(/oh noes/)
+      expect(output_buffer.to_str).to match(/oh noes/)
     end
-    
+
   end
-  
-  context "when I rendered my own hidden id input" do 
-    
+
+  context "when I rendered my own hidden id input" do
+
     before do
-      output_buffer.replace ''
-      
+      @output_buffer = ActionView::OutputBuffer.new ''
+
       expect(@fred.posts.size).to eq(1)
       allow(@fred.posts.first).to receive(:persisted?).and_return(true)
       allow(@fred).to receive(:posts_attributes=)
@@ -129,13 +130,13 @@ RSpec.describe 'Formtastic::FormBuilder#fields_for' do
         end)
       end)
     end
-  
+
     it "should only render one hidden input (my one)" do
-      expect(output_buffer).to have_tag 'input#author_posts_attributes_0_id', :count => 1
+      expect(output_buffer.to_str).to have_tag 'input#author_posts_attributes_0_id', :count => 1
     end
-    
+
     it "should render the hidden input inside an li.hidden" do
-      expect(output_buffer).to have_tag 'li.hidden input#author_posts_attributes_0_id'
+      expect(output_buffer.to_str).to have_tag 'li.hidden input#author_posts_attributes_0_id'
     end
   end
 

data/spec/fast_spec_helper.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 $LOAD_PATH << 'lib/formtastic'
 require 'active_support/all'
 require 'localized_string'

data/spec/generators/formtastic/form/form_generator_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 # Generators are not automatically loaded by Rails
@@ -11,7 +12,7 @@ RSpec.describe Formtastic::FormGenerator do
   destination File.expand_path("../../../../../tmp", __FILE__)
 
   before do
-    @output_buffer = ''
+    @output_buffer = ActionView::OutputBuffer.new ''
     prepare_destination
     mock_everything
     allow(::Post).to receive(:reflect_on_all_associations).with(:belongs_to).and_return([
@@ -21,7 +22,7 @@ RSpec.describe Formtastic::FormGenerator do
       double('reflection', :name => :attachment, :options => {:polymorphic => true}, :macro => :belongs_to),
     ])
   end
-  
+
   after do
     FileUtils.rm_rf(File.expand_path("../../../../../tmp", __FILE__))
   end
@@ -82,14 +83,14 @@ RSpec.describe Formtastic::FormGenerator do
     end
 
     describe 'haml' do
-      
+
       describe 'app/views/posts/_form.html.haml' do
         before { run_generator %w(Post --template-engine haml) }
         subject { file('app/views/posts/_form.html.haml') }
         it { is_expected.to exist }
         it { is_expected.to contain "= semantic_form_for @post do |f|" }
       end
-      
+
       context 'with copy option' do
         describe 'app/views/posts/_form.html.haml' do
           before { run_generator %w(Post --copy --template-engine haml) }
@@ -97,7 +98,7 @@ RSpec.describe Formtastic::FormGenerator do
           it { is_expected.not_to exist }
         end
       end
-      
+
     end
 
     describe 'slim' do
@@ -110,10 +111,10 @@ RSpec.describe Formtastic::FormGenerator do
       end
     end
   end
-  
+
   describe 'with copy option' do
     before { run_generator %w(Post --copy) }
-  
+
     describe 'app/views/posts/_form.html.erb' do
       subject { file('app/views/posts/_form.html.erb') }
       it { is_expected.not_to exist }

data/spec/generators/formtastic/input/input_generator_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 require 'generators/formtastic/input/input_generator'

data/spec/generators/formtastic/install/install_generator_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 # Generators are not automatically loaded by Rails

data/spec/helpers/action_helper_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 RSpec.describe 'with action class finder' do
@@ -21,21 +22,21 @@ RSpec.describe 'with action class finder' do
           concat(semantic_form_for(:project, :url => 'http://test.host') do |builder|
             concat(builder.action(:submit))
           end)
-          expect(output_buffer).to have_tag('form li.action.input_action', :count => 1)
+          expect(output_buffer.to_str).to have_tag('form li.action.input_action', :count => 1)
         end
 
         it 'should default to a button for reset' do
           concat(semantic_form_for(:project, :url => 'http://test.host') do |builder|
             concat(builder.action(:reset))
           end)
-          expect(output_buffer).to have_tag('form li.action.input_action', :count => 1)
+          expect(output_buffer.to_str).to have_tag('form li.action.input_action', :count => 1)
         end
 
         it 'should default to a link for cancel' do
           concat(semantic_form_for(:project, :url => 'http://test.host') do |builder|
             concat(builder.action(:cancel))
           end)
-          expect(output_buffer).to have_tag('form li.action.link_action', :count => 1)
+          expect(output_buffer.to_str).to have_tag('form li.action.link_action', :count => 1)
         end
       end
 
@@ -202,26 +203,26 @@ RSpec.describe 'with action class finder' do
           concat(semantic_form_for(@new_post) do |builder|
             concat(builder.action(:submit, :wrapper_html => {:id => :another_id}))
           end)
-          expect(output_buffer).to have_tag("form li#another_id")
+          expect(output_buffer.to_str).to have_tag("form li#another_id")
         end
 
         it 'should append given classes to li default classes' do
           concat(semantic_form_for(@new_post) do |builder|
             concat(builder.action(:submit, :wrapper_html => {:class => :another_class}))
           end)
-          expect(output_buffer).to have_tag("form li.action")
-          expect(output_buffer).to have_tag("form li.input_action")
-          expect(output_buffer).to have_tag("form li.another_class")
+          expect(output_buffer.to_str).to have_tag("form li.action")
+          expect(output_buffer.to_str).to have_tag("form li.input_action")
+          expect(output_buffer.to_str).to have_tag("form li.another_class")
         end
 
         it 'should allow classes to be an array' do
           concat(semantic_form_for(@new_post) do |builder|
             concat(builder.action(:submit, :wrapper_html => {:class => [ :my_class, :another_class ]}))
           end)
-          expect(output_buffer).to have_tag("form li.action")
-          expect(output_buffer).to have_tag("form li.input_action")
-          expect(output_buffer).to have_tag("form li.my_class")
-          expect(output_buffer).to have_tag("form li.another_class")
+          expect(output_buffer.to_str).to have_tag("form li.action")
+          expect(output_buffer.to_str).to have_tag("form li.input_action")
+          expect(output_buffer.to_str).to have_tag("form li.my_class")
+          expect(output_buffer.to_str).to have_tag("form li.another_class")
         end
       end
 
@@ -230,9 +231,9 @@ RSpec.describe 'with action class finder' do
           concat(semantic_form_for(@new_post) do |builder|
             concat(builder.action(:submit))
           end)
-          expect(output_buffer).to have_tag("form li#post_submit_action")
-          expect(output_buffer).to have_tag("form li.action")
-          expect(output_buffer).to have_tag("form li.input_action")
+          expect(output_buffer.to_str).to have_tag("form li#post_submit_action")
+          expect(output_buffer.to_str).to have_tag("form li.action")
+          expect(output_buffer.to_str).to have_tag("form li.input_action")
         end
       end
 

data/spec/helpers/actions_helper_spec.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 require 'spec_helper'
 
 RSpec.describe 'Formtastic::FormBuilder#actions' do
@@ -6,7 +7,7 @@ RSpec.describe 'Formtastic::FormBuilder#actions' do
   include FormtasticSpecHelper
 
   before do
-    @output_buffer = ''
+    @output_buffer = ActionView::OutputBuffer.new ''
     mock_everything
   end
 
@@ -21,123 +22,123 @@ RSpec.describe 'Formtastic::FormBuilder#actions' do
       end
 
       it 'should render a fieldset inside the form, with a class of "actions"' do
-        expect(output_buffer).to have_tag("form fieldset.actions")
+        expect(output_buffer.to_str).to have_tag("form fieldset.actions")
       end
 
       it 'should render an ol inside the fieldset' do
-        expect(output_buffer).to have_tag("form fieldset.actions ol")
+        expect(output_buffer.to_str).to have_tag("form fieldset.actions ol")
       end
 
       it 'should render the contents of the block inside the ol' do
-        expect(output_buffer).to have_tag("form fieldset.actions ol", :text => /hello/)
+        expect(output_buffer.to_str).to have_tag("form fieldset.actions ol", :text => /hello/)
       end
 
       it 'should not render a legend inside the fieldset' do
-        expect(output_buffer).not_to have_tag("form fieldset.actions legend")
+        expect(output_buffer.to_str).not_to have_tag("form fieldset.actions legend")
       end
     end
 
     describe 'when a :name option is provided' do
       before do
         @legend_text = "Advanced options"
-    
+
         concat(semantic_form_for(@new_post) do |builder|
           builder.actions :name => @legend_text do
           end
         end)
       end
       it 'should render a fieldset inside the form' do
-        expect(output_buffer).to have_tag("form fieldset.actions legend", :text => /#{@legend_text}/)
+        expect(output_buffer.to_str).to have_tag("form fieldset.actions legend", :text => /#{@legend_text}/)
       end
     end
-    
+
     describe 'when other options are provided' do
       before do
         @id_option = 'advanced'
         @class_option = 'wide'
-    
+
         concat(semantic_form_for(@new_post) do |builder|
           builder.actions :id => @id_option, :class => @class_option do
           end
         end)
       end
       it 'should pass the options into the fieldset tag as attributes' do
-        expect(output_buffer).to have_tag("form fieldset##{@id_option}")
-        expect(output_buffer).to have_tag("form fieldset.#{@class_option}")
+        expect(output_buffer.to_str).to have_tag("form fieldset##{@id_option}")
+        expect(output_buffer.to_str).to have_tag("form fieldset.#{@class_option}")
       end
     end
-    
+
   end
 
   describe 'without a block' do
-  
+
     describe 'with no args (default buttons)' do
-  
+
       before do
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.actions)
         end)
       end
-  
+
       it 'should render a form' do
-        expect(output_buffer).to have_tag('form')
+        expect(output_buffer.to_str).to have_tag('form')
       end
-  
+
       it 'should render an actions fieldset inside the form' do
-        expect(output_buffer).to have_tag('form fieldset.actions')
+        expect(output_buffer.to_str).to have_tag('form fieldset.actions')
       end
-  
+
       it 'should not render a legend in the fieldset' do
-        expect(output_buffer).not_to have_tag('form fieldset.actions legend')
+        expect(output_buffer.to_str).not_to have_tag('form fieldset.actions legend')
       end
-  
+
       it 'should render an ol in the fieldset' do
-        expect(output_buffer).to have_tag('form fieldset.actions ol')
+        expect(output_buffer.to_str).to have_tag('form fieldset.actions ol')
       end
-  
+
       it 'should render a list item in the ol for each default action' do
-        expect(output_buffer).to have_tag('form fieldset.actions ol li.action.input_action', :count => 1)
+        expect(output_buffer.to_str).to have_tag('form fieldset.actions ol li.action.input_action', :count => 1)
       end
-  
+
     end
-  
+
     describe 'with button names as args' do
-    
+
       before do
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.actions(:submit, :cancel, :reset))
         end)
       end
-    
+
       it 'should render a form with a fieldset containing a list item for each button arg' do
-        expect(output_buffer).to have_tag('form > fieldset.actions > ol > li.action', :count => 3)
+        expect(output_buffer.to_str).to have_tag('form > fieldset.actions > ol > li.action', :count => 3)
       end
-    
+
     end
-  
+
     describe 'with button names as args and an options hash' do
-    
+
      before do
        concat(semantic_form_for(@new_post) do |builder|
          concat(builder.actions(:submit, :cancel, :reset, :name => "Now click a button", :id => "my-id"))
        end)
      end
-    
+
      it 'should render a form with a fieldset containing a list item for each button arg' do
-       expect(output_buffer).to have_tag('form > fieldset.actions > ol > li.action', :count => 3)
+       expect(output_buffer.to_str).to have_tag('form > fieldset.actions > ol > li.action', :count => 3)
      end
-    
+
      it 'should pass the options down to the fieldset' do
-       expect(output_buffer).to have_tag('form > fieldset#my-id.actions')
+       expect(output_buffer.to_str).to have_tag('form > fieldset#my-id.actions')
      end
-    
+
      it 'should use the special :name option as a text for the legend tag' do
-       expect(output_buffer).to have_tag('form > fieldset#my-id.actions > legend', :text => /Now click a button/)
+       expect(output_buffer.to_str).to have_tag('form > fieldset#my-id.actions > legend', :text => /Now click a button/)
      end
-    
+
     end
-  
+
   end
-  
+
 end