formtastic 3.1.3 → 5.0.0
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +7 -0
- data/.gitattributes +1 -0
- data/.github/workflows/test.yml +61 -0
- data/.gitignore +3 -2
- data/CHANGELOG.md +61 -0
- data/Gemfile.lock +140 -0
- data/MIT-LICENSE +1 -1
- data/{README.textile → README.md} +183 -167
- data/RELEASE_PROCESS +3 -1
- data/Rakefile +20 -1
- data/app/assets/stylesheets/formtastic.css +1 -1
- data/bin/appraisal +8 -0
- data/formtastic.gemspec +12 -16
- data/gemfiles/rails_6.0/Gemfile +5 -0
- data/gemfiles/rails_6.1/Gemfile +5 -0
- data/gemfiles/rails_7.0/Gemfile +5 -0
- data/gemfiles/rails_7.1/Gemfile +5 -0
- data/gemfiles/rails_edge/Gemfile +13 -0
- data/lib/formtastic/action_class_finder.rb +1 -0
- data/lib/formtastic/actions/base.rb +1 -0
- data/lib/formtastic/actions/button_action.rb +1 -0
- data/lib/formtastic/actions/buttonish.rb +1 -0
- data/lib/formtastic/actions/input_action.rb +1 -0
- data/lib/formtastic/actions/link_action.rb +1 -0
- data/lib/formtastic/actions.rb +7 -3
- data/lib/formtastic/deprecation.rb +2 -38
- data/lib/formtastic/engine.rb +4 -1
- data/lib/formtastic/form_builder.rb +12 -24
- data/lib/formtastic/helpers/action_helper.rb +2 -48
- data/lib/formtastic/helpers/actions_helper.rb +1 -0
- data/lib/formtastic/helpers/enum.rb +14 -0
- data/lib/formtastic/helpers/errors_helper.rb +3 -2
- data/lib/formtastic/helpers/fieldset_wrapper.rb +14 -9
- data/lib/formtastic/helpers/file_column_detection.rb +1 -0
- data/lib/formtastic/helpers/form_helper.rb +2 -1
- data/lib/formtastic/helpers/input_helper.rb +20 -76
- data/lib/formtastic/helpers/inputs_helper.rb +29 -23
- data/lib/formtastic/helpers/reflection.rb +1 -0
- data/lib/formtastic/helpers.rb +2 -2
- data/lib/formtastic/html_attributes.rb +1 -0
- data/lib/formtastic/i18n.rb +2 -1
- data/lib/formtastic/input_class_finder.rb +1 -0
- data/lib/formtastic/inputs/base/associations.rb +1 -0
- data/lib/formtastic/inputs/base/choices.rb +3 -2
- data/lib/formtastic/inputs/base/collections.rb +46 -10
- data/lib/formtastic/inputs/base/database.rb +5 -7
- data/lib/formtastic/inputs/base/datetime_pickerish.rb +1 -0
- data/lib/formtastic/inputs/base/errors.rb +7 -6
- data/lib/formtastic/inputs/base/fileish.rb +1 -0
- data/lib/formtastic/inputs/base/hints.rb +2 -1
- data/lib/formtastic/inputs/base/html.rb +9 -7
- data/lib/formtastic/inputs/base/labelling.rb +3 -2
- data/lib/formtastic/inputs/base/naming.rb +5 -4
- data/lib/formtastic/inputs/base/numeric.rb +1 -0
- data/lib/formtastic/inputs/base/options.rb +3 -3
- data/lib/formtastic/inputs/base/placeholder.rb +1 -0
- data/lib/formtastic/inputs/base/stringish.rb +1 -0
- data/lib/formtastic/inputs/base/timeish.rb +9 -4
- data/lib/formtastic/inputs/base/validations.rb +39 -12
- data/lib/formtastic/inputs/base/wrapping.rb +1 -0
- data/lib/formtastic/inputs/base.rb +3 -2
- data/lib/formtastic/inputs/boolean_input.rb +2 -1
- data/lib/formtastic/inputs/check_boxes_input.rb +15 -6
- data/lib/formtastic/inputs/color_input.rb +1 -1
- data/lib/formtastic/inputs/country_input.rb +4 -1
- data/lib/formtastic/inputs/datalist_input.rb +1 -0
- data/lib/formtastic/inputs/date_picker_input.rb +1 -0
- data/lib/formtastic/inputs/date_select_input.rb +1 -0
- data/lib/formtastic/inputs/datetime_picker_input.rb +1 -0
- data/lib/formtastic/inputs/datetime_select_input.rb +1 -0
- data/lib/formtastic/inputs/email_input.rb +1 -0
- data/lib/formtastic/inputs/file_input.rb +1 -0
- data/lib/formtastic/inputs/hidden_input.rb +3 -2
- data/lib/formtastic/inputs/number_input.rb +1 -0
- data/lib/formtastic/inputs/password_input.rb +1 -0
- data/lib/formtastic/inputs/phone_input.rb +1 -0
- data/lib/formtastic/inputs/radio_input.rb +21 -0
- data/lib/formtastic/inputs/range_input.rb +1 -0
- data/lib/formtastic/inputs/search_input.rb +1 -0
- data/lib/formtastic/inputs/select_input.rb +30 -1
- data/lib/formtastic/inputs/string_input.rb +1 -0
- data/lib/formtastic/inputs/text_input.rb +1 -0
- data/lib/formtastic/inputs/time_picker_input.rb +1 -0
- data/lib/formtastic/inputs/time_select_input.rb +1 -0
- data/lib/formtastic/inputs/time_zone_input.rb +17 -6
- data/lib/formtastic/inputs/url_input.rb +1 -0
- data/lib/formtastic/inputs.rb +33 -29
- data/lib/formtastic/localized_string.rb +1 -0
- data/lib/formtastic/localizer.rb +21 -22
- data/lib/formtastic/namespaced_class_finder.rb +8 -9
- data/lib/formtastic/version.rb +2 -1
- data/lib/formtastic.rb +10 -11
- data/lib/generators/formtastic/form/form_generator.rb +2 -1
- data/lib/generators/formtastic/input/input_generator.rb +47 -0
- data/lib/generators/formtastic/install/install_generator.rb +1 -0
- data/lib/generators/templates/formtastic.rb +15 -13
- data/lib/generators/templates/input.rb +19 -0
- data/sample/basic_inputs.html +1 -1
- data/script/integration-template.rb +73 -0
- data/script/integration.sh +19 -0
- data/spec/action_class_finder_spec.rb +2 -1
- data/spec/actions/button_action_spec.rb +21 -20
- data/spec/actions/generic_action_spec.rb +134 -133
- data/spec/actions/input_action_spec.rb +20 -19
- data/spec/actions/link_action_spec.rb +30 -29
- data/spec/builder/custom_builder_spec.rb +39 -22
- data/spec/builder/error_proc_spec.rb +6 -5
- data/spec/builder/semantic_fields_for_spec.rb +46 -45
- data/spec/fast_spec_helper.rb +13 -0
- data/spec/generators/formtastic/form/form_generator_spec.rb +33 -32
- data/spec/generators/formtastic/input/input_generator_spec.rb +125 -0
- data/spec/generators/formtastic/install/install_generator_spec.rb +10 -9
- data/spec/helpers/action_helper_spec.rb +329 -10
- data/spec/helpers/actions_helper_spec.rb +43 -42
- data/spec/helpers/form_helper_spec.rb +45 -38
- data/spec/helpers/input_helper_spec.rb +976 -2
- data/spec/helpers/inputs_helper_spec.rb +217 -202
- data/spec/helpers/reflection_helper_spec.rb +7 -6
- data/spec/helpers/semantic_errors_helper_spec.rb +26 -25
- data/spec/i18n_spec.rb +30 -29
- data/spec/input_class_finder_spec.rb +2 -1
- data/spec/inputs/base/collections_spec.rb +78 -0
- data/spec/inputs/base/validations_spec.rb +481 -0
- data/spec/inputs/boolean_input_spec.rb +73 -72
- data/spec/inputs/check_boxes_input_spec.rb +169 -121
- data/spec/inputs/color_input_spec.rb +53 -64
- data/spec/inputs/country_input_spec.rb +23 -22
- data/spec/inputs/custom_input_spec.rb +3 -6
- data/spec/inputs/datalist_input_spec.rb +3 -2
- data/spec/inputs/date_picker_input_spec.rb +114 -113
- data/spec/inputs/date_select_input_spec.rb +76 -61
- data/spec/inputs/datetime_picker_input_spec.rb +123 -122
- data/spec/inputs/datetime_select_input_spec.rb +85 -68
- data/spec/inputs/email_input_spec.rb +17 -16
- data/spec/inputs/file_input_spec.rb +18 -17
- data/spec/inputs/hidden_input_spec.rb +32 -31
- data/spec/inputs/include_blank_spec.rb +10 -9
- data/spec/inputs/label_spec.rb +26 -25
- data/spec/inputs/number_input_spec.rb +212 -211
- data/spec/inputs/password_input_spec.rb +17 -16
- data/spec/inputs/phone_input_spec.rb +17 -16
- data/spec/inputs/placeholder_spec.rb +18 -17
- data/spec/inputs/radio_input_spec.rb +92 -65
- data/spec/inputs/range_input_spec.rb +136 -135
- data/spec/inputs/readonly_spec.rb +51 -0
- data/spec/inputs/search_input_spec.rb +16 -15
- data/spec/inputs/select_input_spec.rb +209 -102
- data/spec/inputs/string_input_spec.rb +51 -50
- data/spec/inputs/text_input_spec.rb +34 -33
- data/spec/inputs/time_picker_input_spec.rb +115 -114
- data/spec/inputs/time_select_input_spec.rb +84 -70
- data/spec/inputs/time_zone_input_spec.rb +58 -31
- data/spec/inputs/url_input_spec.rb +17 -16
- data/spec/inputs/with_options_spec.rb +9 -8
- data/spec/localizer_spec.rb +18 -17
- data/spec/namespaced_class_finder_spec.rb +18 -6
- data/spec/schema.rb +22 -0
- data/spec/spec_helper.rb +172 -260
- data/spec/support/custom_macros.rb +74 -76
- data/spec/support/deprecation.rb +2 -1
- data/spec/support/shared_examples.rb +2 -1233
- data/spec/support/specialized_class_finder_shared_example.rb +1 -0
- data/spec/support/test_environment.rb +24 -9
- metadata +78 -170
- data/.travis.yml +0 -29
- data/Appraisals +0 -29
- data/CHANGELOG +0 -39
- data/DEPRECATIONS +0 -49
- data/gemfiles/rails_3.2.gemfile +0 -7
- data/gemfiles/rails_4.0.4.gemfile +0 -7
- data/gemfiles/rails_4.1.gemfile +0 -7
- data/gemfiles/rails_4.2.gemfile +0 -7
- data/gemfiles/rails_4.gemfile +0 -7
- data/gemfiles/rails_edge.gemfile +0 -10
- data/lib/formtastic/util.rb +0 -57
- data/spec/helpers/namespaced_action_helper_spec.rb +0 -43
- data/spec/helpers/namespaced_input_helper_spec.rb +0 -36
- data/spec/support/deferred_garbage_collection.rb +0 -21
- data/spec/util_spec.rb +0 -66
data/gemfiles/rails_4.1.gemfile
DELETED
data/gemfiles/rails_4.2.gemfile
DELETED
data/gemfiles/rails_4.gemfile
DELETED
data/gemfiles/rails_edge.gemfile
DELETED
@@ -1,10 +0,0 @@
|
|
1
|
-
# This file was generated by Appraisal
|
2
|
-
|
3
|
-
source "https://rubygems.org"
|
4
|
-
|
5
|
-
gem "rails", :git => "git://github.com/rails/rails.git"
|
6
|
-
gem "rack", :github => "rack/rack"
|
7
|
-
gem "i18n", :github => "svenfuchs/i18n"
|
8
|
-
gem "arel", :github => "rails/arel"
|
9
|
-
|
10
|
-
gemspec :path => "../"
|
data/lib/formtastic/util.rb
DELETED
@@ -1,57 +0,0 @@
|
|
1
|
-
# encoding: utf-8
|
2
|
-
|
3
|
-
# Adapted from the rails3 compatibility shim in Haml 2.2
|
4
|
-
module Formtastic
|
5
|
-
# @private
|
6
|
-
module Util
|
7
|
-
extend self
|
8
|
-
## Rails XSS Safety
|
9
|
-
|
10
|
-
# Returns the given text, marked as being HTML-safe.
|
11
|
-
# With older versions of the Rails XSS-safety mechanism,
|
12
|
-
# this destructively modifies the HTML-safety of `text`.
|
13
|
-
#
|
14
|
-
# @param text [String]
|
15
|
-
# @return [String] `text`, marked as HTML-safe
|
16
|
-
def html_safe(text)
|
17
|
-
if text.respond_to?(:html_safe)
|
18
|
-
text.html_safe
|
19
|
-
else
|
20
|
-
text
|
21
|
-
end
|
22
|
-
end
|
23
|
-
|
24
|
-
def rails3?
|
25
|
-
match?(rails_version, "~> 3.0")
|
26
|
-
end
|
27
|
-
|
28
|
-
def rails4?
|
29
|
-
match?(rails_version, "~> 4.0")
|
30
|
-
end
|
31
|
-
|
32
|
-
def rails4_0?
|
33
|
-
match?(rails_version, "~> 4.0.0")
|
34
|
-
end
|
35
|
-
|
36
|
-
def rails4_1?
|
37
|
-
match?(rails_version, "~> 4.1.0")
|
38
|
-
end
|
39
|
-
|
40
|
-
def deprecated_version_of_rails?
|
41
|
-
match?(rails_version, "< #{minimum_version_of_rails}")
|
42
|
-
end
|
43
|
-
|
44
|
-
def minimum_version_of_rails
|
45
|
-
"4.1.0"
|
46
|
-
end
|
47
|
-
|
48
|
-
def rails_version
|
49
|
-
::Rails::VERSION::STRING
|
50
|
-
end
|
51
|
-
|
52
|
-
def match?(version, dependency)
|
53
|
-
Gem::Dependency.new("formtastic", dependency).match?("formtastic", version)
|
54
|
-
end
|
55
|
-
|
56
|
-
end
|
57
|
-
end
|
@@ -1,43 +0,0 @@
|
|
1
|
-
require 'spec_helper'
|
2
|
-
|
3
|
-
describe 'with action class finder' do
|
4
|
-
include_context 'form builder'
|
5
|
-
|
6
|
-
before {
|
7
|
-
allow(Formtastic::FormBuilder)
|
8
|
-
.to receive(:action_class_finder).and_return(Formtastic::ActionClassFinder)
|
9
|
-
}
|
10
|
-
|
11
|
-
it_behaves_like 'Action Helper'
|
12
|
-
|
13
|
-
describe 'instantiating an action class' do
|
14
|
-
it "should delegate to ActionClassFinder" do
|
15
|
-
concat(semantic_form_for(@new_post) do |builder|
|
16
|
-
Formtastic::ActionClassFinder.any_instance.should_receive(:find).
|
17
|
-
with(:button).and_call_original
|
18
|
-
|
19
|
-
builder.action(:submit, :as => :button)
|
20
|
-
end)
|
21
|
-
end
|
22
|
-
|
23
|
-
describe 'when instantiated multiple times with the same action type' do
|
24
|
-
it "should be cached" do
|
25
|
-
concat(semantic_form_for(@new_post) do |builder|
|
26
|
-
Formtastic::ActionClassFinder.should_receive(:new).once.and_call_original
|
27
|
-
builder.action(:submit, :as => :button)
|
28
|
-
builder.action(:submit, :as => :button)
|
29
|
-
end)
|
30
|
-
end
|
31
|
-
end
|
32
|
-
|
33
|
-
context 'of unknown action' do
|
34
|
-
it "should try to load class named as the action" do
|
35
|
-
expect {
|
36
|
-
semantic_form_for(@new_post) do |builder|
|
37
|
-
builder.action(:destroy)
|
38
|
-
end
|
39
|
-
}.to raise_error(Formtastic::UnknownActionError, 'Unable to find action class DestroyAction')
|
40
|
-
end
|
41
|
-
end
|
42
|
-
end
|
43
|
-
end
|
@@ -1,36 +0,0 @@
|
|
1
|
-
# encoding: utf-8
|
2
|
-
require 'spec_helper'
|
3
|
-
|
4
|
-
describe 'with input class finder' do
|
5
|
-
include_context 'form builder'
|
6
|
-
|
7
|
-
before {
|
8
|
-
allow(Formtastic::FormBuilder)
|
9
|
-
.to receive(:input_class_finder).and_return(Formtastic::InputClassFinder)
|
10
|
-
}
|
11
|
-
it_behaves_like 'Input Helper' # from spec/support/shared_examples.rb
|
12
|
-
|
13
|
-
|
14
|
-
describe 'instantiating an input class' do
|
15
|
-
describe 'when instantiated multiple times with the same input type' do
|
16
|
-
|
17
|
-
it "should be cached (not calling the internal methods)" do
|
18
|
-
# TODO this is really tied to the underlying implementation
|
19
|
-
concat(semantic_form_for(@new_post) do |builder|
|
20
|
-
Formtastic::InputClassFinder.should_receive(:new).once.and_call_original
|
21
|
-
builder.input(:title, :as => :string)
|
22
|
-
builder.input(:title, :as => :string)
|
23
|
-
end)
|
24
|
-
end
|
25
|
-
end
|
26
|
-
|
27
|
-
it "should delegate to InputClassFinder" do
|
28
|
-
concat(semantic_form_for(@new_post) do |builder|
|
29
|
-
Formtastic::InputClassFinder.any_instance.should_receive(:find).
|
30
|
-
with(:string).and_call_original
|
31
|
-
|
32
|
-
builder.input(:title, :as => :string)
|
33
|
-
end)
|
34
|
-
end
|
35
|
-
end
|
36
|
-
end
|
@@ -1,21 +0,0 @@
|
|
1
|
-
# Taken from http://makandra.com/notes/950-speed-up-rspec-by-deferring-garbage-collection
|
2
|
-
class DeferredGarbageCollection
|
3
|
-
|
4
|
-
DEFERRED_GC_THRESHOLD = (ENV['DEFER_GC'] || 10.0).to_f
|
5
|
-
|
6
|
-
@@last_gc_run = Time.now
|
7
|
-
|
8
|
-
def self.start
|
9
|
-
GC.disable if DEFERRED_GC_THRESHOLD > 0
|
10
|
-
end
|
11
|
-
|
12
|
-
def self.reconsider
|
13
|
-
if DEFERRED_GC_THRESHOLD > 0 && Time.now - @@last_gc_run >= DEFERRED_GC_THRESHOLD
|
14
|
-
GC.enable
|
15
|
-
GC.start
|
16
|
-
GC.disable
|
17
|
-
@@last_gc_run = Time.now
|
18
|
-
end
|
19
|
-
end
|
20
|
-
|
21
|
-
end
|
data/spec/util_spec.rb
DELETED
@@ -1,66 +0,0 @@
|
|
1
|
-
# encoding: utf-8
|
2
|
-
require 'spec_helper'
|
3
|
-
|
4
|
-
describe 'Formtastic::Util' do
|
5
|
-
|
6
|
-
describe '.deprecated_version_of_rails?' do
|
7
|
-
|
8
|
-
subject { Formtastic::Util.deprecated_version_of_rails? }
|
9
|
-
|
10
|
-
context '4.0.0' do
|
11
|
-
before { allow(Formtastic::Util).to receive(:rails_version) { "4.0.0" } }
|
12
|
-
it 'should be true' do
|
13
|
-
expect(subject).to be_truthy
|
14
|
-
end
|
15
|
-
end
|
16
|
-
|
17
|
-
context '4.0.3' do
|
18
|
-
before { allow(Formtastic::Util).to receive(:rails_version) { "4.0.3" } }
|
19
|
-
it 'should be true' do
|
20
|
-
expect(subject).to be_truthy
|
21
|
-
end
|
22
|
-
end
|
23
|
-
|
24
|
-
context '4.0.4' do
|
25
|
-
before { allow(Formtastic::Util).to receive(:rails_version) { "4.0.4" } }
|
26
|
-
it 'should be false' do
|
27
|
-
expect(subject).to be_truthy
|
28
|
-
end
|
29
|
-
end
|
30
|
-
|
31
|
-
context '4.0.5' do
|
32
|
-
before { allow(Formtastic::Util).to receive(:rails_version) { "4.0.5" } }
|
33
|
-
it 'should be false' do
|
34
|
-
expect(subject).to be_truthy
|
35
|
-
end
|
36
|
-
end
|
37
|
-
|
38
|
-
context '4.1.0' do
|
39
|
-
before { allow(Formtastic::Util).to receive(:rails_version) { "4.1.0" } }
|
40
|
-
it 'should be false' do
|
41
|
-
expect(subject).to be_falsey
|
42
|
-
end
|
43
|
-
end
|
44
|
-
|
45
|
-
context '4.1.1' do
|
46
|
-
before { allow(Formtastic::Util).to receive(:rails_version) { "4.1.1" } }
|
47
|
-
it 'should be false' do
|
48
|
-
expect(subject).to be_falsey
|
49
|
-
end
|
50
|
-
end
|
51
|
-
|
52
|
-
context '4.2.0' do
|
53
|
-
before { allow(Formtastic::Util).to receive(:rails_version) { "4.2.0" } }
|
54
|
-
it 'should be false' do
|
55
|
-
expect(subject).to be_falsey
|
56
|
-
end
|
57
|
-
end
|
58
|
-
|
59
|
-
context '5.0.0' do
|
60
|
-
before { allow(Formtastic::Util).to receive(:rails_version) { "5.0.0" } }
|
61
|
-
it 'should be true' do
|
62
|
-
expect(subject).to be_falsey
|
63
|
-
end
|
64
|
-
end
|
65
|
-
end
|
66
|
-
end
|