formtastic 3.1.3 → 5.0.0

data/spec/support/custom_macros.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 
 module CustomMacros
 
@@ -10,67 +11,67 @@ module CustomMacros
 
     def it_should_have_input_wrapper_with_class(class_name)
       it "should have input wrapper with class '#{class_name}'" do
-        output_buffer.should have_tag("form li.#{class_name}")
+        expect(output_buffer.to_str).to have_tag("form li.#{class_name}")
       end
     end
 
     def it_should_have_input_wrapper_with_id(id_string)
       it "should have input wrapper with id '#{id_string}'" do
-        output_buffer.should have_tag("form li##{id_string}")
+        expect(output_buffer.to_str).to have_tag("form li##{id_string}")
       end
     end
 
     def it_should_not_have_a_label
       it "should not have a label" do
-        output_buffer.should_not have_tag("form li label")
+        expect(output_buffer.to_str).not_to have_tag("form li label")
       end
     end
 
     def it_should_have_a_nested_fieldset
       it "should have a nested_fieldset" do
-        output_buffer.should have_tag("form li fieldset")
+        expect(output_buffer.to_str).to have_tag("form li fieldset")
       end
     end
 
     def it_should_have_a_nested_fieldset_with_class(klass)
       it "should have a nested_fieldset with class #{klass}" do
-        output_buffer.should have_tag("form li fieldset.#{klass}")
+        expect(output_buffer.to_str).to have_tag("form li fieldset.#{klass}")
       end
     end
 
     def it_should_have_a_nested_ordered_list_with_class(klass)
       it "should have a nested fieldset with class #{klass}" do
-        output_buffer.should have_tag("form li ol.#{klass}")
+        expect(output_buffer.to_str).to have_tag("form li ol.#{klass}")
       end
     end
 
     def it_should_have_label_with_text(string_or_regex)
       it "should have a label with text '#{string_or_regex}'" do
-        output_buffer.should have_tag("form li label", string_or_regex)
+        expect(output_buffer.to_str).to have_tag("form li label", :text => string_or_regex)
       end
     end
 
     def it_should_have_label_for(element_id)
       it "should have a label for ##{element_id}" do
-        output_buffer.should have_tag("form li label.label[@for='#{element_id}']")
+        expect(output_buffer.to_str).to have_tag("form li label.label[@for='#{element_id}']")
       end
     end
 
     def it_should_have_an_inline_label_for(element_id)
       it "should have a label for ##{element_id}" do
-        output_buffer.should have_tag("form li label[@for='#{element_id}']")
+        expect(output_buffer.to_str).to have_tag("form li label[@for='#{element_id}']")
       end
     end
 
     def it_should_have_input_with_id(element_id)
       it "should have an input with id '#{element_id}'" do
-        output_buffer.should have_tag("form li input##{element_id}")
+        expect(output_buffer.to_str).to have_tag("form li input##{element_id}")
       end
     end
 
     def it_should_have_select_with_id(element_id)
       it "should have a select box with id '#{element_id}'" do
-        output_buffer.should have_tag("form li select##{element_id}")
+        expect(output_buffer.to_str).to have_tag("form li select##{element_id}")
       end
     end
 
@@ -78,7 +79,7 @@ module CustomMacros
     def it_should_have_tag_with(type, attribute_value_hash)
       attribute_value_hash.each do |attribute, value|
         it "should have a #{type} box with #{attribute} '#{value}'" do
-          output_buffer.should have_tag("form li #{type}[@#{attribute}=\"#{value}\"]")
+          expect(output_buffer.to_str).to have_tag("form li #{type}[@#{attribute}=\"#{value}\"]")
         end
       end
     end
@@ -88,44 +89,44 @@ module CustomMacros
 
     def it_should_have_many_tags(type, count)
       it "should have #{count} #{type} tags" do
-        output_buffer.should have_tag("form li #{type}", count: count)
+        expect(output_buffer.to_str).to have_tag("form li #{type}", count: count)
       end
     end
 
     def it_should_have_input_with_type(input_type)
       it "should have a #{input_type} input" do
-        output_buffer.should have_tag("form li input[@type=\"#{input_type}\"]")
+        expect(output_buffer.to_str).to have_tag("form li input[@type=\"#{input_type}\"]")
       end
     end
 
     def it_should_have_input_with_name(name)
       it "should have an input named #{name}" do
-        output_buffer.should have_tag("form li input[@name=\"#{name}\"]")
+        expect(output_buffer.to_str).to have_tag("form li input[@name=\"#{name}\"]")
       end
     end
 
     def it_should_have_select_with_name(name)
       it "should have an input named #{name}" do
-        output_buffer.should have_tag("form li select[@name=\"#{name}\"]")
+        expect(output_buffer.to_str).to have_tag("form li select[@name=\"#{name}\"]")
       end
     end
 
     def it_should_have_textarea_with_name(name)
       it "should have an input named #{name}" do
-        output_buffer.should have_tag("form li textarea[@name=\"#{name}\"]")
+        expect(output_buffer.to_str).to have_tag("form li textarea[@name=\"#{name}\"]")
       end
     end
 
     def it_should_have_textarea_with_id(element_id)
       it "should have an input with id '#{element_id}'" do
-        output_buffer.should have_tag("form li textarea##{element_id}")
+        expect(output_buffer.to_str).to have_tag("form li textarea##{element_id}")
       end
     end
 
     def it_should_have_label_and_input_with_id(element_id)
       it "should have an input with id '#{element_id}'" do
-        output_buffer.should have_tag("form li input##{element_id}")
-        output_buffer.should have_tag("form li label[@for='#{element_id}']")
+        expect(output_buffer.to_str).to have_tag("form li input##{element_id}")
+        expect(output_buffer.to_str).to have_tag("form li label[@for='#{element_id}']")
       end
     end
 
@@ -135,7 +136,7 @@ module CustomMacros
           concat(semantic_form_for(@new_post) do |builder|
             concat(builder.input(:title, :as => as))
           end)
-          output_buffer.should have_tag("form li input[@size='#{Formtastic::FormBuilder.default_text_field_size}']")
+          expect(output_buffer.to_str).to have_tag("form li input[@size='#{Formtastic::FormBuilder.default_text_field_size}']")
         end
       end
     end
@@ -146,8 +147,8 @@ module CustomMacros
           concat(semantic_form_for(@new_post) do |builder|
             concat(builder.input(:title, :as => as))
           end)
-          output_buffer.should have_tag("form li input")
-          output_buffer.should_not have_tag("form li input[@size]")
+          expect(output_buffer.to_str).to have_tag("form li input")
+          expect(output_buffer.to_str).not_to have_tag("form li input[@size]")
         end
       end
     end
@@ -157,7 +158,7 @@ module CustomMacros
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:title, :as => as, :input_html => { :class => 'myclass' }))
         end)
-        output_buffer.should have_tag("form li input.myclass")
+        expect(output_buffer.to_str).to have_tag("form li input.myclass")
       end
     end
 
@@ -166,27 +167,28 @@ module CustomMacros
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:title, :as => as, :input_html => { :id => 'myid' }))
         end)
-        output_buffer.should have_tag('form li label[@for="myid"]')
+        expect(output_buffer.to_str).to have_tag('form li label[@for="myid"]')
       end
     end
 
     def it_should_have_maxlength_matching_column_limit
       it 'should have a maxlength matching column limit' do
-        @new_post.column_for_attribute(:title).limit.should == 50
-        output_buffer.should have_tag("form li input[@maxlength='50']")
+        expect(@new_post.column_for_attribute(:title).limit).to eq(50)
+        expect(output_buffer.to_str).to have_tag("form li input[@maxlength='50']")
       end
     end
 
     def it_should_use_column_size_for_columns_shorter_than_default_text_field_size(as)
       it 'should use the column size for columns shorter than default_text_field_size' do
         column_limit_shorted_than_default = 1
-        @new_post.stub(:column_for_attribute).and_return(double('column', :type => as, :limit => column_limit_shorted_than_default))
+        allow(@new_post).to receive(:column_for_attribute)
+                                .and_return(double('column', :type => as, :limit => column_limit_shorted_than_default))
 
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:title, :as => as))
         end)
 
-        output_buffer.should have_tag("form li input[@size='#{column_limit_shorted_than_default}']")
+        expect(output_buffer.to_str).to have_tag("form li input[@size='#{column_limit_shorted_than_default}']")
       end
     end
 
@@ -195,25 +197,25 @@ module CustomMacros
         before do
           @title_errors = ['must not be blank', 'must be longer than 10 characters', 'must be awesome']
           @errors = double('errors')
-          @errors.stub(:[]).with(errors_matcher(:title)).and_return(@title_errors)
+          allow(@errors).to receive(:[]).with(errors_matcher(:title)).and_return(@title_errors)
           Formtastic::FormBuilder.file_metadata_suffixes.each do |suffix|
-            @errors.stub(:[]).with(errors_matcher("title_#{suffix}".to_sym)).and_return(nil)
+            allow(@errors).to receive(:[]).with(errors_matcher("title_#{suffix}".to_sym)).and_return(nil)
           end
-          @new_post.stub(:errors).and_return(@errors)
+          allow(@new_post).to receive(:errors).and_return(@errors)
         end
 
         it 'should apply an errors class to the list item' do
           concat(semantic_form_for(@new_post) do |builder|
             concat(builder.input(:title, :as => type))
           end)
-          output_buffer.should have_tag('form li.error')
+          expect(output_buffer.to_str).to have_tag('form li.error')
         end
 
         it 'should not wrap the input with the Rails default error wrapping' do
           concat(semantic_form_for(@new_post) do |builder|
             concat(builder.input(:title, :as => type))
           end)
-          output_buffer.should_not have_tag('div.fieldWithErrors')
+          expect(output_buffer.to_str).not_to have_tag('div.fieldWithErrors')
         end
 
         it 'should render a paragraph for the errors' do
@@ -221,7 +223,7 @@ module CustomMacros
           concat(semantic_form_for(@new_post) do |builder|
             concat(builder.input(:title, :as => type))
           end)
-          output_buffer.should have_tag('form li.error p.inline-errors')
+          expect(output_buffer.to_str).to have_tag('form li.error p.inline-errors')
         end
 
         it 'should not display an error list' do
@@ -229,7 +231,7 @@ module CustomMacros
           concat(semantic_form_for(@new_post) do |builder|
             concat(builder.input(:title, :as => type))
           end)
-          output_buffer.should have_tag('form li.error ul.errors')
+          expect(output_buffer.to_str).to have_tag('form li.error ul.errors')
         end
       end
 
@@ -241,15 +243,15 @@ module CustomMacros
         end
 
         it 'should not apply an errors class to the list item' do
-          output_buffer.should_not have_tag('form li.error')
+          expect(output_buffer.to_str).not_to have_tag('form li.error')
         end
 
         it 'should not render a paragraph for the errors' do
-          output_buffer.should_not have_tag('form li.error p.inline-errors')
+          expect(output_buffer.to_str).not_to have_tag('form li.error p.inline-errors')
         end
 
         it 'should not display an error list' do
-          output_buffer.should_not have_tag('form li.error ul.errors')
+          expect(output_buffer.to_str).not_to have_tag('form li.error ul.errors')
         end
       end
 
@@ -261,26 +263,22 @@ module CustomMacros
         end
 
         it 'should not apply an errors class to the list item' do
-          output_buffer.should_not have_tag('form li.error')
+          expect(output_buffer.to_str).not_to have_tag('form li.error')
         end
 
         it 'should not render a paragraph for the errors' do
-          output_buffer.should_not have_tag('form li.error p.inline-errors')
+          expect(output_buffer.to_str).not_to have_tag('form li.error p.inline-errors')
         end
 
         it 'should not display an error list' do
-          output_buffer.should_not have_tag('form li.error ul.errors')
+          expect(output_buffer.to_str).not_to have_tag('form li.error ul.errors')
         end
       end
     end
 
     def it_should_call_find_on_association_class_when_no_collection_is_provided(as)
       it "should call find on the association class when no collection is provided" do
-        if Formtastic::Util.rails3?
-          ::Author.should_receive(:scoped)
-        else
-          ::Author.should_receive(:where)
-        end
+        expect(::Author).to receive(:where)
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:author, :as => as))
         end)
@@ -292,14 +290,14 @@ module CustomMacros
 
         before do
           @authors = ([::Author.all] * 2).flatten
-          output_buffer.replace ''
+          @output_buffer = ActionView::OutputBuffer.new ''
         end
 
         it 'should use the provided collection' do
           concat(semantic_form_for(@new_post) do |builder|
             concat(builder.input(:author, :as => as, :collection => @authors))
           end)
-          output_buffer.should have_tag("form li.#{as} #{countable}", :count => @authors.size + (as == :select ? 1 : 0))
+          expect(output_buffer.to_str).to have_tag("form li.#{as} #{countable}", :count => @authors.size + (as == :select ? 1 : 0))
         end
 
         describe 'and the :collection is an array of strings' do
@@ -313,24 +311,24 @@ module CustomMacros
             end)
 
             @categories.each do |value|
-              output_buffer.should have_tag("form li.#{as}", /#{value}/)
-              output_buffer.should have_tag("form li.#{as} #{countable}[@value='#{value}']")
+              expect(output_buffer.to_str).to have_tag("form li.#{as}", :text => /#{value}/)
+              expect(output_buffer.to_str).to have_tag("form li.#{as} #{countable}[@value='#{value}']")
             end
           end
 
           if as == :radio
             it 'should generate a sanitized label for attribute' do
-              @bob.stub(:category_name).and_return(@categories)
+              allow(@bob).to receive(:category_name).and_return(@categories)
               concat(semantic_form_for(@new_post) do |builder|
                 fields = builder.semantic_fields_for(@bob) do |bob_builder|
                   concat(bob_builder.input(:category_name, :as => as, :collection => @categories))
                 end
                 concat(fields)
               end)
-              output_buffer.should have_tag("form li fieldset ol li label[@for='post_author_category_name_general']")
-              output_buffer.should have_tag("form li fieldset ol li label[@for='post_author_category_name_design']")
-              output_buffer.should have_tag("form li fieldset ol li label[@for='post_author_category_name_development']")
-              output_buffer.should have_tag("form li fieldset ol li label[@for='post_author_category_name_quasi-serious_inventions']")
+              expect(output_buffer.to_str).to have_tag("form li fieldset ol li label[@for='post_author_category_name_general']")
+              expect(output_buffer.to_str).to have_tag("form li fieldset ol li label[@for='post_author_category_name_design']")
+              expect(output_buffer.to_str).to have_tag("form li fieldset ol li label[@for='post_author_category_name_development']")
+              expect(output_buffer.to_str).to have_tag("form li fieldset ol li label[@for='post_author_category_name_quasi-serious_inventions']")
             end
           end
         end
@@ -346,8 +344,8 @@ module CustomMacros
             end)
 
             @categories.each do |label, value|
-              output_buffer.should have_tag("form li.#{as}", /#{label}/)
-              output_buffer.should have_tag("form li.#{as} #{countable}[@value='#{value}']")
+              expect(output_buffer.to_str).to have_tag("form li.#{as}", :text => /#{label}/)
+              expect(output_buffer.to_str).to have_tag("form li.#{as} #{countable}[@value='#{value}']")
             end
           end
         end
@@ -364,9 +362,9 @@ module CustomMacros
 
             @categories.each do |text, value|
               label = as == :select ? :option : :label
-              output_buffer.should have_tag("form li.#{as} #{label}", /#{text}/i)
-              output_buffer.should have_tag("form li.#{as} #{countable}[@value='#{value.to_s}']")
-              output_buffer.should have_tag("form li.#{as} #{countable}#post_category_name_#{value.to_s}") if as == :radio
+              expect(output_buffer.to_str).to have_tag("form li.#{as} #{label}", :text => /#{text}/i)
+              expect(output_buffer.to_str).to have_tag("form li.#{as} #{countable}[@value='#{value.to_s}']")
+              expect(output_buffer.to_str).to have_tag("form li.#{as} #{countable}#post_category_name_#{value.to_s}") if as == :radio
             end
           end
         end
@@ -382,8 +380,8 @@ module CustomMacros
                 concat(builder.input(:category_name, :as => as, :collection => @choices))
               end)
 
-              output_buffer.should have_tag("form li.#{as} #{countable}#post_category_name_true")
-              output_buffer.should have_tag("form li.#{as} #{countable}#post_category_name_false")
+              expect(output_buffer.to_str).to have_tag("form li.#{as} #{countable}#post_category_name_true")
+              expect(output_buffer.to_str).to have_tag("form li.#{as} #{countable}#post_category_name_false")
             end
           end
         end
@@ -400,8 +398,8 @@ module CustomMacros
 
             @categories.each do |value|
               label = as == :select ? :option : :label
-              output_buffer.should have_tag("form li.#{as} #{label}", /#{value}/i)
-              output_buffer.should have_tag("form li.#{as} #{countable}[@value='#{value.to_s}']")
+              expect(output_buffer.to_str).to have_tag("form li.#{as} #{label}", :text => /#{value}/i)
+              expect(output_buffer.to_str).to have_tag("form li.#{as} #{countable}[@value='#{value.to_s}']")
             end
           end
         end
@@ -417,8 +415,8 @@ module CustomMacros
             end)
 
             @categories.each do |label, value|
-              output_buffer.should have_tag("form li.#{as}", /#{label}/)
-              output_buffer.should have_tag("form li.#{as} #{countable}[@value='#{value}']")
+              expect(output_buffer.to_str).to have_tag("form li.#{as}", :text => /#{label}/)
+              expect(output_buffer.to_str).to have_tag("form li.#{as} #{countable}[@value='#{value}']")
             end
           end
 
@@ -437,7 +435,7 @@ module CustomMacros
 
             it 'should have options with text content from the specified method' do
               ::Author.all.each do |author|
-                output_buffer.should have_tag("form li.#{as}", /#{author.login}/)
+                expect(output_buffer.to_str).to have_tag("form li.#{as}", :text => /#{author.login}/)
               end
             end
           end
@@ -453,7 +451,7 @@ module CustomMacros
 
             it 'should have options with the proc applied to each' do
               ::Author.all.each do |author|
-                output_buffer.should have_tag("form li.#{as}", /#{author.login.reverse}/)
+                expect(output_buffer.to_str).to have_tag("form li.#{as}", :text => /#{author.login.reverse}/)
               end
             end
           end
@@ -472,7 +470,7 @@ module CustomMacros
 
             it 'should have options with the proc applied to each' do
               ::Author.all.each do |author|
-                output_buffer.should have_tag("form li.#{as}", /#{author.login.reverse}/)
+                expect(output_buffer.to_str).to have_tag("form li.#{as}", :text => /#{author.login.reverse}/)
               end
             end
           end
@@ -483,8 +481,8 @@ module CustomMacros
 
             describe "when the collection objects respond to #{label_method}" do
               before do
-                @fred.stub(:respond_to?) { |m| m.to_s == label_method || m.to_s == 'id' }
-                [@fred, @bob].each { |a| a.stub(label_method).and_return('The Label Text') }
+                allow(@fred).to receive(:respond_to?) { |m| m.to_s == label_method || m.to_s == 'id' }
+                [@fred, @bob].each { |a| allow(a).to receive(label_method).and_return('The Label Text') }
 
                 with_deprecation_silenced do
                   concat(semantic_form_for(@new_post) do |builder|
@@ -495,7 +493,7 @@ module CustomMacros
 
               it "should render the options with #{label_method} as the label" do
                 ::Author.all.each do |author|
-                  output_buffer.should have_tag("form li.#{as}", /The Label Text/)
+                  expect(output_buffer.to_str).to have_tag("form li.#{as}", :text => /The Label Text/)
                 end
               end
             end
@@ -516,7 +514,7 @@ module CustomMacros
 
             it 'should have options with values from specified method' do
               ::Author.all.each do |author|
-                output_buffer.should have_tag("form li.#{as} #{countable}[@value='#{author.login}']")
+                expect(output_buffer.to_str).to have_tag("form li.#{as} #{countable}[@value='#{author.login}']")
               end
             end
           end
@@ -532,7 +530,7 @@ module CustomMacros
 
             it 'should have options with the proc applied to each value' do
               ::Author.all.each do |author|
-                output_buffer.should have_tag("form li.#{as} #{countable}[@value='#{author.login.reverse}']")
+                expect(output_buffer.to_str).to have_tag("form li.#{as} #{countable}[@value='#{author.login.reverse}']")
               end
             end
           end
@@ -551,7 +549,7 @@ module CustomMacros
 
             it 'should have options with the proc applied to each value' do
               ::Author.all.each do |author|
-                output_buffer.should have_tag("form li.#{as} #{countable}[@value='#{author.login.reverse}']")
+                expect(output_buffer.to_str).to have_tag("form li.#{as} #{countable}[@value='#{author.login.reverse}']")
               end
             end
           end

data/spec/support/deprecation.rb

@@ -1,5 +1,6 @@
+# frozen_string_literal: true
 def with_deprecation_silenced(&block)
-  ::ActiveSupport::Deprecation.silence do
+  ::Formtastic::Deprecation.silence do
     yield
   end
 end