foreman_wreckingball 0.1.0 → 1.0.0

data/test/models/foreman_wreckingball/cpu_hot_add_status_test.rb

@@ -0,0 +1,86 @@
+require 'test_plugin_helper'
+
+module ForemanWreckingball
+  class CpuHotAddStatusTest < ActiveSupport::TestCase
+    setup do
+      User.current = users(:admin)
+    end
+
+    should belong_to(:host)
+
+    let(:host) do
+      FactoryGirl.create(:host, :managed, :with_vmware_facet)
+    end
+    let(:status) { ForemanWreckingball::CpuHotAddStatus.new(host: host) }
+
+    test 'has a host association' do
+      status.save!
+      assert_equal status, host.public_send(status.class.host_association)
+    end
+
+    describe 'status labels' do
+      test 'with possible performance degration' do
+        status.status = CpuHotAddStatus::PERFORMANCE_DEGRATION
+        assert_equal 'Possible performance degration', status.to_label
+      end
+
+      test 'without performance degration' do
+        status.status = CpuHotAddStatus::OK
+        assert_equal 'No Impact', status.to_label
+      end
+    end
+
+    describe 'global status' do
+      test 'with possible performance degration' do
+        status.status = CpuHotAddStatus::PERFORMANCE_DEGRATION
+        assert_equal HostStatus::Global::ERROR, status.to_global
+      end
+
+      test 'without performance degration' do
+        status.status = CpuHotAddStatus::OK
+        assert_equal HostStatus::Global::OK, status.to_global
+      end
+    end
+
+    describe '#performance_degration?' do
+      context 'with cpu hot add disabled' do
+        setup do
+          host.vmware_facet.cpu_hot_add = false
+        end
+
+        test 'status is not relevant' do
+          refute status.relevant?
+        end
+
+        test 'no performance degration is indicated' do
+          refute status.performance_degration?
+        end
+      end
+
+      context 'with cpu hot add enabled' do
+        setup do
+          host.vmware_facet.cpu_hot_add = true
+        end
+
+        test 'status is relevant' do
+          assert status.relevant?
+        end
+
+        test 'no performance degration is indicated' do
+          FactoryGirl.create(:vmware_hypervisor_facet, cpu_cores: 4, vmware_cluster: host.vmware_facet.vmware_cluster)
+          host.vmware_facet.cpus = 100
+          assert status.performance_degration?
+        end
+      end
+    end
+
+    describe '#hypervisor_min_cores' do
+      test 'returns the minimum core count from all hypervisors in the same cluster' do
+        FactoryGirl.create(:vmware_hypervisor_facet, cpu_cores: 4, vmware_cluster: host.vmware_facet.vmware_cluster)
+        FactoryGirl.create(:vmware_hypervisor_facet, cpu_cores: 8, vmware_cluster: host.vmware_facet.vmware_cluster)
+        status.host.reload
+        assert_equal 4, status.hypervisor_min_cores
+      end
+    end
+  end
+end

data/test/models/foreman_wreckingball/operatingsystem_status_test.rb

@@ -0,0 +1,95 @@
+require 'test_plugin_helper'
+
+module ForemanWreckingball
+  class OperatingsystemStatusTest < ActiveSupport::TestCase
+    setup do
+      User.current = users(:admin)
+    end
+
+    should belong_to(:host)
+
+    let(:operatingsystem) do
+      FactoryGirl.create(
+        :operatingsystem,
+        architectures: [architectures(:x86_64)],
+        major: 6,
+        minor: 1,
+        type: 'Redhat',
+        name: 'RedHat'
+      )
+    end
+    let(:host) do
+      FactoryGirl.create(
+        :host,
+        :managed,
+        :with_vmware_facet,
+        architecture: architectures(:x86_64),
+        operatingsystem: operatingsystem
+      )
+    end
+    let(:status) { ForemanWreckingball::OperatingsystemStatus.new(host: host) }
+
+    test 'has a host association' do
+      status.save!
+      assert_equal status, host.public_send(status.class.host_association)
+    end
+
+    test '#relevant is only for hosts with a vmware facet' do
+      h = FactoryGirl.build(:host, :managed)
+      refute ForemanWreckingball::ToolsStatus.new(host: h).relevant?
+      assert status.relevant?
+    end
+
+    describe 'status calculation' do
+      test 'when os does not match' do
+        status.stubs(:os_matches_identifier?).returns(false)
+        assert_equal OperatingsystemStatus::MISMATCH, status.to_status
+      end
+
+      test 'when os matches' do
+        status.stubs(:os_matches_identifier?).returns(true)
+        assert_equal OperatingsystemStatus::OK, status.to_status
+      end
+    end
+
+    describe 'status labels' do
+      test 'when os does not match' do
+        status.status = OperatingsystemStatus::MISMATCH
+        assert_equal 'VM OS is incorrect', status.to_label
+      end
+
+      test 'when os matches' do
+        status.status = OperatingsystemStatus::OK
+        assert_equal 'OK', status.to_label
+      end
+    end
+
+    describe 'global status' do
+      test 'when os does not match' do
+        status.status = OperatingsystemStatus::MISMATCH
+        assert_equal HostStatus::Global::WARN, status.to_global
+      end
+
+      test 'when os matches' do
+        status.status = OperatingsystemStatus::OK
+        assert_equal HostStatus::Global::OK, status.to_global
+      end
+    end
+
+    describe '#os_matches_identifier?' do
+      test 'when architecture does not match' do
+        host.architecture = architectures(:sparc)
+        refute status.os_matches_identifier?
+      end
+
+      test 'when operatingsystem does not match' do
+        host.operatingsystem = operatingsystems(:ubuntu1210)
+        refute status.os_matches_identifier?
+      end
+
+      test 'when architecture, osfamily, name and major match' do
+        assert status.os_matches_identifier?
+      end
+    end
+  end
+end

data/test/models/foreman_wreckingball/tools_status_test.rb

@@ -0,0 +1,55 @@
+require 'test_plugin_helper'
+
+module ForemanWreckingball
+  class ToolsStatusTest < ActiveSupport::TestCase
+    setup do
+      User.current = users(:admin)
+    end
+
+    should belong_to(:host)
+
+    let(:host) { FactoryGirl.create(:host, :with_vmware_facet) }
+    let(:status) { ForemanWreckingball::ToolsStatus.new(host: host) }
+
+    test 'has a host association' do
+      status.save!
+      assert_equal status, host.public_send(status.class.host_association)
+    end
+
+    test '#relevant? is only for hosts not in build mode' do
+      host.build = false
+      assert status.relevant?
+
+      host.build = true
+      refute status.relevant?
+    end
+
+    test '#relevant is only for hosts with a vmware facet' do
+      h = FactoryGirl.build(:host, :managed)
+      refute ForemanWreckingball::ToolsStatus.new(host: h).relevant?
+    end
+
+    describe 'status calculation' do
+      test 'when host is powered down' do
+        Host::Managed.any_instance.stubs(:supports_power_and_running?).returns(false)
+        assert_equal ForemanWreckingball::ToolsStatus::POWERDOWN, status.to_status
+      end
+
+      test 'when host is powered on' do
+        Host::Managed.any_instance.stubs(:supports_power_and_running?).returns(true)
+        assert_equal 2, status.to_status
+      end
+    end
+
+    describe 'status labels' do
+      test 'shows a powered down host' do
+        status.status = ForemanWreckingball::ToolsStatus::POWERDOWN
+        assert_equal 'Powered down', status.to_label
+      end
+
+      test 'shows ok message' do
+        assert_equal 'OK', status.to_label
+      end
+    end
+  end
+end

data/test/models/foreman_wreckingball/vmware_cluster_test.rb

@@ -0,0 +1,12 @@
+require 'test_plugin_helper'
+
+module ForemanWreckingball
+  class VmwareClusterTest < ActiveSupport::TestCase
+    should validate_presence_of(:compute_resource)
+    should validate_presence_of(:name)
+    should belong_to(:compute_resource)
+    should have_many(:vmware_hypervisor_facets)
+    should have_many(:hosts)
+    should have_many(:vmware_facets)
+  end
+end

data/test/models/foreman_wreckingball/vmware_facet_test.rb

@@ -0,0 +1,9 @@
+require 'test_plugin_helper'
+
+module ForemanWreckingball
+  class VmwareFacetTest < ActiveSupport::TestCase
+    should validate_presence_of(:host)
+    should belong_to(:vmware_cluster)
+    should have_many(:vmware_hypervisor_facets)
+  end
+end

data/test/models/foreman_wreckingball/vmware_hypervisor_facet_test.rb

@@ -0,0 +1,13 @@
+require 'test_plugin_helper'
+
+module ForemanWreckingball
+  class VmwareHypervisorFacetTest < ActiveSupport::TestCase
+    should validate_presence_of(:host)
+    should belong_to(:vmware_cluster)
+    should have_many(:vmware_facets)
+
+    test 'should sanitize name' do
+      assert_equal 'abc-server.example.com', ForemanWreckingball::VmwareHypervisorFacet.sanitize_name('abc_server.example.com.')
+    end
+  end
+end

data/test/models/host_test.rb

@@ -0,0 +1,10 @@
+require 'test_plugin_helper'
+
+class Host::ManagedTest < ActiveSupport::TestCase
+  should have_one(:vmware_facet)
+  should have_one(:vmware_cluster)
+  should have_one(:vmware_hypervisor_facet)
+  should have_one(:vmware_tools_status_object)
+  should have_one(:vmware_operatingsystem_status_object)
+  should have_one(:vmware_cpu_hot_add_status_object)
+end

data/test/test_plugin_helper.rb

@@ -1,6 +1,7 @@
 # This calls the main test_helper in Foreman-core
 require 'test_helper'
+require 'dynflow/testing'
 
 # Add plugin to FactoryBot's paths
-FactoryBot.definition_file_paths << File.join(File.dirname(__FILE__), 'factories')
-FactoryBot.reload
+FactoryGirl.definition_file_paths << File.join(File.dirname(__FILE__), 'factories')
+FactoryGirl.reload

data/test/unit/foreman_wreckingball/vmware_cluster_importer_test.rb

@@ -0,0 +1,42 @@
+require 'test_plugin_helper'
+
+module ForemanWreckingball
+  class VmwareClusterImporterTest < ActiveSupport::TestCase
+    setup do
+      User.current = users(:admin)
+      Fog.mock!
+    end
+    teardown { Fog.unmock! }
+
+    let(:compute_resource) { FactoryGirl.create(:vmware_cr, :uuid => 'Solutions') }
+    let(:importer) do
+      VmwareClusterImporter.new(
+        compute_resource: compute_resource
+      )
+    end
+
+    describe '#import!' do
+      test 'imports clusters' do
+        importer.import!
+        clusters = ForemanWreckingball::VmwareCluster.pluck(:name)
+        assert_includes clusters, 'Solutionscluster'
+        assert_includes clusters, 'Problemscluster'
+        assert_includes clusters, 'Nested/Lastcluster'
+      end
+
+      test 'removes old clusters' do
+        old_cluster = FactoryGirl.create(:vmware_cluster, compute_resource: compute_resource)
+        importer.import!
+        refute ForemanWreckingball::VmwareCluster.find_by(id: old_cluster.id)
+      end
+
+      test 'can be run twice without a change' do
+        importer.import!
+        before = ForemanWreckingball::VmwareCluster.pluck(:updated_at)
+        importer.import!
+        after = ForemanWreckingball::VmwareCluster.pluck(:updated_at)
+        assert_equal before, after
+      end
+    end
+  end
+end

data/test/unit/foreman_wreckingball/vmware_hypervisor_importer_test.rb

@@ -0,0 +1,72 @@
+require 'test_plugin_helper'
+
+module ForemanWreckingball
+  class VmwareHypervisorImporterTest < ActiveSupport::TestCase
+    setup do
+      User.current = users(:admin)
+      Fog.mock!
+    end
+    teardown { Fog.unmock! }
+
+    let(:organization) do
+      Organization.find_by(name: 'Organization 1')
+    end
+    let(:tax_location) do
+      Location.find_by(name: 'Location 1')
+    end
+    let(:compute_resource) do
+      FactoryGirl.create(
+        :vmware_cr,
+        uuid: 'Solutions',
+        organizations: [organization],
+        locations: [tax_location]
+      )
+    end
+    let(:cluster) do
+      FactoryGirl.create(
+        :vmware_cluster,
+        name: 'Solutionscluster',
+        compute_resource: compute_resource
+      )
+    end
+    let(:importer) do
+      VmwareHypervisorImporter.new(
+        compute_resource: compute_resource
+      )
+    end
+
+    describe '#import!' do
+      setup do
+        cluster
+      end
+
+      test 'imports hypervisors' do
+        importer.import!
+        host = Host::Managed.joins(:vmware_hypervisor_facet).find_by(:name => 'host1.example.com')
+
+        # Test host attributes are set correctly
+        assert_equal 'example.com', host.domain.name
+        assert_equal 'PowerEdge R730', host.model.name
+        assert_equal '1.2.3.4', host.ip
+        assert_nil host.ip6
+        assert_equal organization, host.organization
+        assert_equal tax_location, host.location
+
+        # Test facet attributes are set correctly
+        assert_equal cluster, host.vmware_hypervisor_facet.vmware_cluster
+        assert_equal 20, host.vmware_hypervisor_facet.cpu_cores
+        assert_equal 40, host.vmware_hypervisor_facet.cpu_threads
+        assert_equal 2, host.vmware_hypervisor_facet.cpu_sockets
+        assert_equal 824_597_241_856, host.vmware_hypervisor_facet.memory
+        assert_equal '4c4c4544-0051-3610-8046-c4c44f584a32', host.vmware_hypervisor_facet.uuid
+      end
+
+      test 'updates host by katello name' do
+        host = FactoryGirl.create(:host,  organization: organization)
+        host.update_attributes!(:name => "virt-who-host1.example.com-#{organization.id}")
+        importer.import!
+        assert_equal 'host1.example.com', host.reload.name
+      end
+    end
+  end
+end

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: foreman_wreckingball
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Timo Goebel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-06 00:00:00.000000000 Z
+date: 2018-05-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: foreman-tasks
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.0
+        version: 0.10.9
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.0
+        version: 0.10.9
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
@@ -42,16 +42,16 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.52.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.52.1
 description: Adds status checks of the VMWare VMs to Foreman.
 email:
 - timo.goebel@dm.de
@@ -102,8 +102,26 @@ files:
 - locale/en/foreman_wreckingball.po
 - locale/foreman_wreckingball.pot
 - locale/gemspec.rb
+- test/actions/foreman_wreckingball/host/refresh_vmware_facet_test.rb
+- test/actions/foreman_wreckingball/host/remediate_vmware_operatingsystem_test.rb
+- test/actions/foreman_wreckingball/vmware/schedule_vmware_sync_test.rb
+- test/actions/foreman_wreckingball/vmware/sync_compute_resource_test.rb
+- test/controllers/foreman_wreckingball/hosts_controller_test.rb
+- test/factories/compute_resource.rb
+- test/factories/foreman_wreckingball_factories.rb
+- test/factories/host.rb
+- test/models/compute_resource_test.rb
+- test/models/compute_resources/vmware_test.rb
+- test/models/foreman_wreckingball/cpu_hot_add_status_test.rb
+- test/models/foreman_wreckingball/operatingsystem_status_test.rb
+- test/models/foreman_wreckingball/tools_status_test.rb
+- test/models/foreman_wreckingball/vmware_cluster_test.rb
+- test/models/foreman_wreckingball/vmware_facet_test.rb
+- test/models/foreman_wreckingball/vmware_hypervisor_facet_test.rb
+- test/models/host_test.rb
 - test/test_plugin_helper.rb
-- test/unit/foreman_wreckingball_test.rb
+- test/unit/foreman_wreckingball/vmware_cluster_importer_test.rb
+- test/unit/foreman_wreckingball/vmware_hypervisor_importer_test.rb
 homepage: https://github.com/dm-drogeriemarkt/foreman_wreckingball
 licenses:
 - GPL-3.0
@@ -129,5 +147,23 @@ signing_key:
 specification_version: 4
 summary: Adds status checks of the VMWare VMs to Foreman.
 test_files:
-- test/unit/foreman_wreckingball_test.rb
+- test/unit/foreman_wreckingball/vmware_cluster_importer_test.rb
+- test/unit/foreman_wreckingball/vmware_hypervisor_importer_test.rb
+- test/models/compute_resource_test.rb
+- test/models/host_test.rb
+- test/models/foreman_wreckingball/operatingsystem_status_test.rb
+- test/models/foreman_wreckingball/vmware_hypervisor_facet_test.rb
+- test/models/foreman_wreckingball/cpu_hot_add_status_test.rb
+- test/models/foreman_wreckingball/vmware_cluster_test.rb
+- test/models/foreman_wreckingball/vmware_facet_test.rb
+- test/models/foreman_wreckingball/tools_status_test.rb
+- test/models/compute_resources/vmware_test.rb
+- test/factories/compute_resource.rb
+- test/factories/host.rb
+- test/factories/foreman_wreckingball_factories.rb
+- test/actions/foreman_wreckingball/host/remediate_vmware_operatingsystem_test.rb
+- test/actions/foreman_wreckingball/host/refresh_vmware_facet_test.rb
+- test/actions/foreman_wreckingball/vmware/sync_compute_resource_test.rb
+- test/actions/foreman_wreckingball/vmware/schedule_vmware_sync_test.rb
 - test/test_plugin_helper.rb
+- test/controllers/foreman_wreckingball/hosts_controller_test.rb

data/test/unit/foreman_wreckingball_test.rb

@@ -1,11 +0,0 @@
-require 'test_plugin_helper'
-
-class ForemanWreckingballTest < ActiveSupport::TestCase
-  setup do
-    User.current = User.find_by_login 'admin'
-  end
-
-  test 'the truth' do
-    assert true
-  end
-end