foreman_wreckingball 0.1.0 → 1.0.0

data/app/models/foreman_wreckingball/operatingsystem_status.rb

@@ -46,19 +46,19 @@ module ForemanWreckingball
     end
 
     def relevant?(_options = {})
-      host && !!host.vmware_facet
+      host && host.vmware_facet
     end
 
     def os_matches_identifier?
       guest_id = host.vmware_facet.guest_id
       vsphere_os = VsphereOsIdentifiers.lookup(guest_id)
       return true unless vsphere_os
-      os = host.operatingsystem
       return true unless host.operatingsystem && host.architecture
       return false if vsphere_os.architecture && vsphere_os.architecture != host.architecture.name
       return false if vsphere_os.osfamily && vsphere_os.osfamily != host.operatingsystem.family
       return false if vsphere_os.name && vsphere_os.name != host.operatingsystem.name
-      return false if vsphere_os.major && vsphere_os.major != host.operatingsystem.major.to_i
+      return false if vsphere_os.major && ![vsphere_os.major].flatten.include?(host.operatingsystem.major.to_i)
+      return false if vsphere_os.release && ![vsphere_os.release].flatten.include?(host.facts['os::release::full'])
       true
     end
   end

data/app/models/foreman_wreckingball/tools_status.rb

@@ -40,7 +40,7 @@ module ForemanWreckingball
     end
 
     def relevant?(_options = {})
-      host && !host.build? && !!host.vmware_facet
+      host && !host.build? && host.vmware_facet
     end
   end
 end

data/app/models/foreman_wreckingball/vmware_cluster.rb

@@ -1,14 +1,23 @@
 module ForemanWreckingball
   class VmwareCluster < ActiveRecord::Base
-    has_many :vmware_hypervisor_facets, :class_name => '::ForemanWreckingball::VmwareHypervisorFacet'
-    has_many :hosts, :class_name => '::Host::Managed', :through => :vmware_hypervisor_facets,
-      :inverse_of => :vmware_cluster
-    belongs_to :compute_resource, :inverse_of => :vmware_clusters
-    has_many :vmware_facets, :class_name => '::ForemanWreckingball::VmwareFacet', :inverse_of => :vmware_clusters
+    has_many :vmware_hypervisor_facets,
+             :class_name => '::ForemanWreckingball::VmwareHypervisorFacet',
+             :inverse_of => :vmware_cluster,
+             :dependent => :nullify
+    has_many :hosts, :class_name => '::Host::Managed',
+                     :through => :vmware_hypervisor_facets,
+                     :inverse_of => :vmware_cluster,
+                     :dependent => :nullify
+    belongs_to :compute_resource,
+               :inverse_of => :vmware_clusters
+    has_many :vmware_facets,
+             :class_name => '::ForemanWreckingball::VmwareFacet',
+             :inverse_of => :vmware_cluster,
+             :dependent => :nullify
 
     validates_lengths_from_database
 
     validates :compute_resource, :presence => true, :allow_blank => false
-    validates :name, :presence => true, :allow_blank => false, uniqueness: { scope: :compute_resource}
+    validates :name, :presence => true, :allow_blank => false, :uniqueness => { scope: :compute_resource }
   end
 end

data/app/models/foreman_wreckingball/vmware_facet.rb

@@ -7,10 +7,11 @@ module ForemanWreckingball
     enum :tools_state => VALID_GUEST_STATUSES
 
     belongs_to :vmware_cluster, :class_name => '::ForemanWreckingball::VmwareCluster',
-      :inverse_of => :vmware_facets
+                                :inverse_of => :vmware_facets
 
-    has_many :vmware_hypervisor_facets, :class_name => '::ForemanWreckingball::VmwareHypervisorFacet', :through => :vmware_cluster,
-      :inverse_of => :vmware_facets
+    has_many :vmware_hypervisor_facets, :class_name => '::ForemanWreckingball::VmwareHypervisorFacet',
+                                        :through => :vmware_cluster,
+                                        :inverse_of => :vmware_facets
 
     validates_lengths_from_database
 
@@ -32,7 +33,7 @@ module ForemanWreckingball
     def refresh!
       vm = host.compute_object
       return unless vm
-      self.update(
+      update(
         :vmware_cluster => ::ForemanWreckingball::VmwareCluster.find_by(:name => vm.cluster, :compute_resource => host.compute_resource),
         :cpus => vm.cpus,
         :corespersocket => vm.corespersocket,

data/app/models/foreman_wreckingball/vmware_hypervisor_facet.rb

@@ -9,10 +9,10 @@ module ForemanWreckingball
     belongs_to :vmware_cluster, :inverse_of => :vmware_hypervisor_facets, :class_name => 'ForemanWreckingball::VmwareCluster'
 
     has_many :vmware_facets, :class_name => '::ForemanWreckingball::VmwareFacet', :through => :vmware_clusters,
-      :inverse_of => :vmware_hypervisor_facets
+                             :inverse_of => :vmware_hypervisor_facets
 
     def self.sanitize_name(name)
-      name.gsub('_', '-').chomp('.').downcase
+      name.tr('_', '-').chomp('.').downcase
     end
   end
 end

data/app/services/foreman_wreckingball/vmware_cluster_importer.rb

@@ -13,16 +13,16 @@ module ForemanWreckingball
         delete_removed_clusters
         create_new_clusters
       end
-    logger.info("Import clusters for '#{compute_resource}' completed. Added: #{counters[:added] || 0}, Updated: #{counters[:updated] || 0}, Deleted: #{counters[:deleted] || 0} clusters")
+      logger.info("Import clusters for '#{compute_resource}' completed. Added: #{counters[:added] || 0}, Updated: #{counters[:updated] || 0}, Deleted: #{counters[:deleted] || 0} clusters")
     end
 
     def delete_removed_clusters
       delete_query = ::ForemanWreckingball::VmwareCluster.where(:compute_resource => compute_resource).where.not(:name => cluster_names)
-      if ActiveRecord::Base.connection.adapter_name.downcase.starts_with? 'mysql'
-        counters[:deleted] = ::ForemanWreckingball::VmwareCluster.where(:id => delete_query.pluck(:id)).delete_all
-      else
-        counters[:deleted] = delete_query.delete_all
-      end
+      counters[:deleted] = if ActiveRecord::Base.connection.adapter_name.downcase.starts_with? 'mysql'
+                             ::ForemanWreckingball::VmwareCluster.where(:id => delete_query.pluck(:id)).delete_all
+                           else
+                             delete_query.delete_all
+                           end
     end
 
     def create_new_clusters

data/app/services/foreman_wreckingball/vmware_hypervisor_importer.rb

@@ -15,7 +15,7 @@ module ForemanWreckingball
       compute_resource.vmware_clusters.each do |cluster|
         import_hypervisors(cluster)
       end
-      logger.info("Import hypervisors for '#{compute_resource}' completed. Added: #{counters[:added] || 0}, Updated: #{counters[:updated] || 0}, Deleted: #{counters[:deleted] || 0} hypervisors")
+      logger.info("Import hypervisors for '#{compute_resource}' completed. Added: #{counters[:added] || 0}, Updated: #{counters[:updated] || 0}, Deleted: #{counters[:deleted] || 0} hypervisors") # rubocop:disable Metrics/LineLength
     end
 
     def import_hypervisors(cluster)
@@ -30,7 +30,11 @@ module ForemanWreckingball
       counter = host.vmware_hypervisor_facet ? :updated : :added
 
       ipaddress6 = hypervisor.ipaddress6
-      ipaddress6 = nil if (IPAddr.new('fe80::/10').include?(ipaddress6) rescue false)
+      ipaddress6 = nil if begin
+                             IPAddr.new('fe80::/10').include?(ipaddress6)
+                           rescue StandardError
+                             false
+                           end
 
       hostname = hypervisor.hostname
       domainname = hypervisor.domainname
@@ -74,7 +78,7 @@ module ForemanWreckingball
     def find_host_for_hypervisor(hypervisor)
       name = ::ForemanWreckingball::VmwareHypervisorFacet.sanitize_name(hypervisor.name)
       hostname = ::ForemanWreckingball::VmwareHypervisorFacet.sanitize_name([hypervisor.hostname, hypervisor.domainname].join('.'))
-      hostname = nil unless hostname.present?
+      hostname = nil if hostname.blank?
       katello_name = katello_hypervisor_hostname(hostname || name)
       katello_uuid = katello_hypervisor_hostname(hypervisor.uuid)
 

data/config/routes.rb

@@ -1,7 +1,7 @@
 Rails.application.routes.draw do
   scope '/wreckingball' do
     constraints(:id => /[^\/]+/) do
-      resources :hosts, controller: 'foreman_wreckingball/hosts', :only => [] do
+      resources :hosts, controller: 'foreman_wreckingball/hosts', only: [] do
         member do
           put :remediate
         end

data/lib/foreman_wreckingball/engine.rb

@@ -1,3 +1,6 @@
+require 'dynflow'
+require 'foreman-tasks'
+
 module ForemanWreckingball
   class Engine < ::Rails::Engine
     engine_name 'foreman_wreckingball'
@@ -7,7 +10,7 @@ module ForemanWreckingball
     config.autoload_paths += Dir["#{config.root}/app/models/concerns"]
     config.autoload_paths += Dir["#{config.root}/app/helpers/concerns"]
 
-    initializer "foreman_wreckingball.register_paths" do |app|
+    initializer 'foreman_wreckingball.register_paths' do |_app|
       ::ForemanTasks.dynflow.config.eager_load_paths.concat(%W[#{ForemanWreckingball::Engine.root}/app/lib/actions])
     end
 
@@ -20,7 +23,7 @@ module ForemanWreckingball
 
     initializer 'foreman_wreckingball.register_plugin', :before => :finisher_hook do |_app|
       Foreman::Plugin.register :foreman_wreckingball do
-        requires_foreman '>= 1.15'
+        requires_foreman '>= 1.16'
 
         security_block :foreman_wreckingball do
           permission :refresh_vmware_status_hosts, {
@@ -37,9 +40,9 @@ module ForemanWreckingball
         ]
 
         menu :top_menu, :wreckingball_status_dashboard, :url_hash => { :controller => :'foreman_wreckingball/hosts', :action => :status_dashboard },
-          :caption => N_('VMware Status'),
-          :parent => :hosts_menu,
-          :after => :hosts
+                                                        :caption => N_('VMware Status'),
+                                                        :parent => :hosts_menu,
+                                                        :after => :hosts
 
         register_custom_status(ForemanWreckingball::ToolsStatus)
         register_custom_status(ForemanWreckingball::OperatingsystemStatus)
@@ -53,7 +56,7 @@ module ForemanWreckingball
       end
     end
 
-    initializer 'foreman_wreckingball.dynflow_world', :before => 'foreman_tasks.initialize_dynflow' do |app|
+    initializer 'foreman_wreckingball.dynflow_world', :before => 'foreman_tasks.initialize_dynflow' do |_app|
       ::ForemanTasks.dynflow.require!
     end
 
@@ -71,11 +74,11 @@ module ForemanWreckingball
           Fog::Compute::Vsphere::Host.send(:include, FogExtensions::ForemanWreckingball::Vsphere::Host)
           Fog::Compute::Vsphere::Real.send(:include, FogExtensions::ForemanWreckingball::Vsphere::Real)
         end
-      rescue => e
+      rescue StandardError => e
         Rails.logger.warn "ForemanWreckingball: skipping engine hook (#{e})\n#{e.backtrace.join("\n")}"
       end
 
-      #load 'foreman_wreckingball/scheduled_jobs.rb'
+      # load 'foreman_wreckingball/scheduled_jobs.rb'
     end
 
     initializer 'foreman_wreckingball.register_gettext', after: :load_config_initializers do |_app|

data/lib/foreman_wreckingball/scheduled_jobs.rb

@@ -3,7 +3,7 @@ pending_jobs = ::Foreman::Application.dynflow.world.persistence.find_execution_p
 scheduled_job = pending_jobs.select do |job|
   delayed_plan = ::Foreman::Application.dynflow.world.persistence.load_delayed_plan(job.id)
   next if delayed_plan.blank?
-  delayed_plan.to_hash[:serialized_args].first["job_class"] == 'UpdateHostsVmwareFacets'
+  delayed_plan.to_hash[:serialized_args].first['job_class'] == 'UpdateHostsVmwareFacets'
 end
 
 # Only schedule the job if there isn't a scheduled job

data/lib/foreman_wreckingball/version.rb

@@ -1,3 +1,3 @@
 module ForemanWreckingball
-  VERSION = '0.1.0'.freeze
+  VERSION = '1.0.0'.freeze
 end

data/lib/tasks/foreman_vmware_checks_tasks.rake

@@ -33,7 +33,7 @@ namespace :foreman_wreckingball do
                          "#{ForemanWreckingball::Engine.root}/lib/**/*.rb",
                          "#{ForemanWreckingball::Engine.root}/test/**/*.rb"]
       end
-    rescue
+    rescue StandardError
       puts 'Rubocop not loaded.'
     end
 
@@ -44,6 +44,4 @@ end
 Rake::Task[:test].enhance ['test:foreman_wreckingball']
 
 load 'tasks/jenkins.rake'
-if Rake::Task.task_defined?(:'jenkins:unit')
-  Rake::Task['jenkins:unit'].enhance ['test:foreman_wreckingball', 'foreman_wreckingball:rubocop']
-end
+Rake::Task['jenkins:unit'].enhance ['test:foreman_wreckingball', 'foreman_wreckingball:rubocop'] if Rake::Task.task_defined?(:'jenkins:unit')

data/test/actions/foreman_wreckingball/host/refresh_vmware_facet_test.rb

@@ -0,0 +1,57 @@
+require 'test_plugin_helper'
+
+module Actions
+  module ForemanWreckingball
+    module Vmware
+      class RefreshVmwareFacetTest < ActiveSupport::TestCase
+        include ::Dynflow::Testing
+        setup do
+          ::Fog.mock!
+          # this is not stubbed correctly in fog-vsphere
+          Fog::Compute::Vsphere::Server.any_instance.stubs(:cpuHotAddEnabled).returns(false)
+        end
+        teardown { ::Fog.unmock! }
+
+        let(:compute_resource) do
+          cr = FactoryGirl.create(:compute_resource, :vmware, :uuid => 'Solutions')
+          ComputeResource.find(cr.id)
+        end
+        let(:uuid) { '5032c8a5-9c5e-ba7a-3804-832a03e16381' }
+        let(:vm) { compute_resource.find_vm_by_uuid(uuid) }
+
+        let(:host) do
+          FactoryGirl.create(
+            :host,
+            :managed,
+            :with_vmware_facet,
+            compute_resource: compute_resource,
+            uuid: uuid
+          ).tap do |host|
+            host.vmware_facet.update_attribute(:guest_id, 'asianux4_64Guest')
+          end
+        end
+
+        let(:action_class) { ::Actions::ForemanWreckingball::Host::RefreshVmwareFacet }
+        let(:action) do
+          create_action(action_class).tap do |action|
+            action.stubs(:action_subject).returns(host)
+            action.input.update(
+              host: {
+                id: host.id
+              }
+            )
+          end
+        end
+        let(:planned_action) do
+          plan_action(action, host)
+        end
+        let(:runned_action) { run_action(planned_action) }
+
+        test "it refreshes a host's vmware facet" do
+          assert_equal :success, runned_action.state
+          assert_equal 'rhel6_64Guest', host.reload.vmware_facet.guest_id
+        end
+      end
+    end
+  end
+end

data/test/actions/foreman_wreckingball/host/remediate_vmware_operatingsystem_test.rb

@@ -0,0 +1,74 @@
+require 'test_plugin_helper'
+
+module Actions
+  module ForemanWreckingball
+    module Vmware
+      class RemediateVmwareOperatingsystemTest < ActiveSupport::TestCase
+        include ::Dynflow::Testing
+        setup do
+          ::Fog.mock!
+          # this is not stubbed correctly in fog-vsphere
+          Fog::Compute::Vsphere::Server.any_instance.stubs(:cpuHotAddEnabled).returns(false)
+        end
+        teardown { ::Fog.unmock! }
+
+        let(:compute_resource) do
+          cr = FactoryGirl.create(:compute_resource, :vmware, :uuid => 'Solutions')
+          ComputeResource.find(cr.id)
+        end
+        let(:uuid) { '5032c8a5-9c5e-ba7a-3804-832a03e16381' }
+        let(:vm) { compute_resource.find_vm_by_uuid(uuid) }
+
+        let(:operatingsystem) do
+          FactoryGirl.create(
+            :operatingsystem,
+            architectures: [architectures(:x86_64)],
+            major: 6,
+            minor: 1,
+            type: 'Redhat',
+            name: 'RedHat'
+          )
+        end
+
+        let(:host) do
+          FactoryGirl.create(
+            :host,
+            :managed,
+            :with_vmware_facet,
+            architecture: architectures(:x86_64),
+            operatingsystem: operatingsystem,
+            compute_resource: compute_resource,
+            uuid: uuid
+          ).tap do |host|
+            host.vmware_facet.update_attribute(:guest_id, 'asianux4_64Guest')
+          end
+        end
+
+        let(:action_class) { ::Actions::ForemanWreckingball::Host::RemediateVmwareOperatingsystem }
+        let(:action) do
+          create_action(action_class).tap do |action|
+            action.stubs(:action_subject).returns(host)
+            action.input.update(
+              host: {
+                id: host.id
+              }
+            )
+          end
+        end
+        let(:planned_action) do
+          plan_action(action, host)
+        end
+        let(:runned_action) { run_action(planned_action) }
+
+        test "it remediates the host's vm operatingsystem" do
+          assert_equal :success, runned_action.state
+          assert_equal 'asianux4_64Guest', runned_action.output.fetch('old_operatingsystem_id')
+          assert_equal 'rhel6_64Guest', runned_action.output.fetch('new_operatingsytem_id')
+          assert_equal true, runned_action.output.fetch('state')
+          assert_equal true, runned_action.output.fetch('initially_powered_on')
+          assert_equal 'rhel6_64Guest', host.reload.vmware_facet.guest_id
+        end
+      end
+    end
+  end
+end

data/test/actions/foreman_wreckingball/vmware/schedule_vmware_sync_test.rb

@@ -0,0 +1,27 @@
+require 'test_plugin_helper'
+
+module Actions
+  module ForemanWreckingball
+    module Vmware
+      class ScheduleVmwareSyncTest < ActiveSupport::TestCase
+        include ::Dynflow::Testing
+
+        let(:action_class) { ::Actions::ForemanWreckingball::Vmware::ScheduleVmwareSync }
+        let(:sync_action_class) { ::Actions::ForemanWreckingball::Vmware::SyncComputeResource }
+
+        let(:action) do
+          create_action(action_class)
+        end
+        let(:planned_action) do
+          plan_action(action)
+        end
+
+        context 'with a vmware compute resource' do
+          test 'syncs a compute resource' do
+            assert_action_planed_with(planned_action, sync_action_class, compute_resources(:vmware))
+          end
+        end
+      end
+    end
+  end
+end

data/test/actions/foreman_wreckingball/vmware/sync_compute_resource_test.rb

@@ -0,0 +1,48 @@
+require 'test_plugin_helper'
+
+module Actions
+  module ForemanWreckingball
+    module Vmware
+      class SyncComputeResourceTest < ActiveSupport::TestCase
+        include ::Dynflow::Testing
+        setup do
+          ::Fog.mock!
+          # Only Solutionscluster has valid mock data, let's ignore the rest
+          ::Foreman::Model::Vmware.any_instance.stubs(:clusters).returns(['Solutionscluster'])
+        end
+        teardown { ::Fog.unmock! }
+
+        let(:action_class) { ::Actions::ForemanWreckingball::Vmware::SyncComputeResource }
+        let(:compute_resource) do
+          FactoryGirl.create(
+            :vmware_cr,
+            uuid: 'Solutions'
+          )
+        end
+
+        let(:action) do
+          create_action(action_class).tap do |action|
+            action.stubs(:action_subject).returns(compute_resource)
+            action.input.update(
+              compute_resource: {
+                id: compute_resource.id
+              }
+            )
+          end
+        end
+        let(:planned_action) do
+          plan_action(action, compute_resource)
+        end
+        let(:runned_action) { run_action(planned_action) }
+
+        describe 'ComputeResource Sync' do
+          test 'syncs a compute resource' do
+            assert ::ForemanWreckingball::VmwareCluster.count.zero?
+            assert_equal :success, runned_action.state
+            refute ::ForemanWreckingball::VmwareCluster.count.zero?
+          end
+        end
+      end
+    end
+  end
+end

data/test/controllers/foreman_wreckingball/hosts_controller_test.rb

@@ -0,0 +1,67 @@
+require 'test_plugin_helper'
+
+module ForemanWreckingball
+  class HostsControllerTest < ActionController::TestCase
+    let(:task_id) { 123 }
+    let(:fake_task) do
+      OpenStruct.new(
+        id: task_id
+      )
+    end
+
+    describe '#status_dashboard' do
+      test 'shows an empty status page' do
+        get :status_dashboard, {}, set_session_user
+        assert_response :success
+      end
+
+      test 'shows a status page' do
+        FactoryGirl.create_list(:host, 5, :with_wreckingball_statuses)
+        get :status_dashboard, {}, set_session_user
+        assert_response :success
+      end
+    end
+
+    describe '#refresh_status_dashboard' do
+      test 'redirects to scheduled task' do
+        ForemanTasks.expects(:async_task).returns(fake_task)
+        put :refresh_status_dashboard, {}, set_session_user
+        assert_response :redirect
+        assert_includes flash[:success], 'successfully scheduled'
+        assert_redirected_to foreman_tasks_task_path(123)
+      end
+    end
+
+    describe '#remediate' do
+      let(:host) do
+        FactoryGirl.create(:host, :with_wreckingball_statuses)
+      end
+
+      test 'redirects to scheduled task' do
+        ForemanTasks.expects(:async_task).returns(fake_task)
+        put :remediate, { status_id: host.vmware_operatingsystem_status_object.id, id: host.id }, set_session_user
+        assert_response :redirect
+        assert_includes flash[:success], 'successfully scheduled'
+        assert_redirected_to foreman_tasks_task_path(123)
+      end
+
+      test 'raises error when status can not be remediated' do
+        FactoryGirl.create(:host, :with_wreckingball_statuses)
+        assert_raises Foreman::Exception do
+          put :remediate, { status_id: host.vmware_tools_status_object.id, id: host.id }, set_session_user
+        end
+      end
+
+      test 'returns not found when host id is invalid' do
+        put :remediate, { status_id: nil, id: 'invalid' }, set_session_user
+        assert_response :not_found
+      end
+
+      test 'returns not found when status id is invalid' do
+        FactoryGirl.create(:host, :with_wreckingball_statuses)
+        put :remediate, { status_id: 'invalid', id: host.id }, set_session_user
+        assert_response :not_found
+      end
+    end
+  end
+end

data/test/factories/compute_resource.rb

@@ -0,0 +1,13 @@
+FactoryGirl.modify do
+  factory :compute_resource do
+    trait :with_vmware_clusters do
+      transient do
+        vmware_clusters_count 1
+      end
+
+      after(:create) do |compute_resource, evaluator|
+        create_list(:vmware_cluster, evaluator.vmware_clusters_count, compute_resource: compute_resource)
+      end
+    end
+  end
+end

data/test/factories/foreman_wreckingball_factories.rb

@@ -0,0 +1,45 @@
+FactoryGirl.define do
+  factory :vmware_facet, class: 'ForemanWreckingball::VmwareFacet' do
+    vmware_cluster
+    tools_state 2 #:toolsOk
+    cpus 2
+    corespersocket 1
+    memory_mb 8192
+    guest_id 'rhel6_64Guest'
+    cpu_hot_add false
+    host
+  end
+
+  factory :vmware_hypervisor_facet, class: 'ForemanWreckingball::VmwareHypervisorFacet' do
+    host
+    vmware_cluster
+    cpu_cores 18
+    cpu_sockets 1
+    cpu_threads 36
+    memory 412_046_372_864
+    uuid { SecureRandom.uuid }
+  end
+
+  factory :vmware_cluster, class: 'ForemanWreckingball::VmwareCluster' do
+    sequence(:name) { |n| "Cluster #{n}" }
+    association :compute_resource, factory: [:compute_resource, :vmware]
+  end
+
+  factory :vmware_tools_status, class: 'ForemanWreckingball::ToolsStatus' do
+    association :host, factory: [:host, :with_vmware_facet]
+    reported_at { Time.now.utc }
+    after(:build) { |status| status.status = status.to_status }
+  end
+
+  factory :vmware_operatingsystem_status, class: 'ForemanWreckingball::OperatingsystemStatus' do
+    association :host, factory: [:host, :with_vmware_facet]
+    reported_at { Time.now.utc }
+    after(:build) { |status| status.status = status.to_status }
+  end
+
+  factory :vmware_cpu_hot_add_status, class: 'ForemanWreckingball::CpuHotAddStatus' do
+    association :host, factory: [:host, :with_vmware_facet]
+    reported_at { Time.now.utc }
+    after(:build) { |status| status.status = status.to_status }
+  end
+end

data/test/factories/host.rb

@@ -0,0 +1,38 @@
+FactoryGirl.modify do
+  factory :host do
+    trait :with_vmware_facet do
+      vmware_facet
+    end
+
+    trait :with_vmware_hypervisor_facet do
+      vmware_hypervisor_facet
+    end
+
+    trait :with_vmware_tools_status do
+      with_vmware_facet
+      after(:create) do |host, _evaluator|
+        create :vmware_tools_status, host: host
+      end
+    end
+
+    trait :with_vmware_operatingsystem_status do
+      with_vmware_facet
+      after(:create) do |host, _evaluator|
+        create :vmware_operatingsystem_status, host: host
+      end
+    end
+
+    trait :with_vmware_cpu_hot_add_status do
+      with_vmware_facet
+      after(:create) do |host, _evaluator|
+        create :vmware_cpu_hot_add_status, host: host
+      end
+    end
+
+    trait :with_wreckingball_statuses do
+      with_vmware_tools_status
+      with_vmware_operatingsystem_status
+      with_vmware_cpu_hot_add_status
+    end
+  end
+end

data/test/models/compute_resource_test.rb

@@ -0,0 +1,5 @@
+require 'test_plugin_helper'
+
+class ComputeResourceTest < ActiveSupport::TestCase
+  should have_many(:vmware_clusters)
+end

data/test/models/compute_resources/vmware_test.rb

@@ -0,0 +1,12 @@
+require 'test_plugin_helper'
+
+class VmwareTest < ActiveSupport::TestCase
+  setup { Fog.mock! }
+  teardown { Fog.unmock! }
+  let(:compute_resource) { FactoryGirl.build(:vmware_cr, :uuid => 'Solutions') }
+
+  test '#hypervisors returns hosts by cluster' do
+    hosts = compute_resource.hypervisors(cluster_id: 'Solutionscluster').map(&:name)
+    assert_includes hosts, 'host1.example.com'
+  end
+end