foreman_snapshot_management 2.0.1 → 2.0.3

data/webpack/components/SnapshotManagement/components/SnapshotForm/SnapshotForm.js

@@ -1,13 +1,11 @@
-import React from 'react';
+import React, { useState } from 'react';
 import PropTypes from 'prop-types';
 import * as Yup from 'yup';
 
 import { translate as __ } from 'foremanReact/common/I18n';
-// import CheckBox from 'foremanReact/components/common/forms/Checkbox';
-// import TextInput from 'foremanReact/components/common/forms/TextInput';
 import ForemanForm from 'foremanReact/components/common/forms/ForemanForm';
 import TextField from 'foremanReact/components/common/forms/TextField';
-
+import { FieldLevelHelp } from 'patternfly-react';
 import { SNAPSHOT_CREATE_URL } from './SnapshotFormConstants';
 import './snapshotForm.scss';
 
@@ -18,6 +16,7 @@ const SnapshotForm = ({
   capabilities,
   ...props
 }) => {
+  const { setModalClosed } = props;
   let nameValidation = Yup.string().max(80, 'Too Long!');
   if (capabilities.limitSnapshotNameFormat)
     nameValidation = nameValidation
@@ -34,33 +33,53 @@ const SnapshotForm = ({
     name: nameValidation.required('is required'),
     description: Yup.string(),
     includeRam: Yup.bool(),
+    useQuiesce: Yup.bool(),
+    snapshotMode: Yup.string(),
   });
 
-  const handleSubmit = async (values, actions) => {
+  const [snapshotMode, setSnapshotMode] = useState();
+
+  const options = [
+    { name: '', value: '' },
+    { name: 'Memory', value: __('Memory') },
+  ];
+  if (capabilities.quiesceOption) {
+    options.push({ name: 'Quiesce', value: __('Quiesce') });
+  }
+
+  const handleSubmit = (values, actions) => {
+    if (snapshotMode === 'Quiesce') {
+      values.useQuiesce = true;
+      values.includeRam = false;
+    } else if (snapshotMode === 'Memory') {
+      values.includeRam = true;
+      values.useQuiesce = false;
+    }
+
     const submitValues = {
       include_ram: values.includeRam || false,
+      quiesce: values.useQuiesce || false,
       snapshot: {
         name: values.name,
         description: values.description || '',
       },
     };
-
-    await submitForm({
+    submitForm({
       item: 'Snapshot',
       url: SNAPSHOT_CREATE_URL.replace(':hostId', hostId),
       values: submitValues,
       message: __('Snapshot successfully created!'),
+      successCallback: setModalClosed,
+      actions,
     });
-    actions.setSubmitting(false);
-    props.setModalClosed();
   };
 
   return (
     <ForemanForm
-      onSubmit={(values, actions) => handleSubmit(values, actions)}
+      onSubmit={handleSubmit}
       initialValues={initialValues}
       validationSchema={validationSchema}
-      onCancel={() => props.setModalClosed()}
+      onCancel={setModalClosed}
     >
       <TextField
         name="name"
@@ -75,12 +94,31 @@ const SnapshotForm = ({
         label={__('Description')}
         inputClassName="col-md-8"
       />
-      <TextField
-        type="checkbox"
-        name="includeRam"
-        label={__('Include RAM')}
-        inputClassName="col-md-8"
-      />
+      <div className="form-group">
+        <label className="col-md-2 control-label">
+          {__('Snapshot Mode')}
+          <FieldLevelHelp
+            buttonClass="field-help"
+            placement="top"
+            content={__(
+              "Select Snapshot Mode between mutually exclusive options, 'Memory' (includes RAM) and 'Quiesce'."
+            )}
+          />
+        </label>
+        <div className="col-md-8">
+          <select
+            className="common-select form-control"
+            value={snapshotMode}
+            onChange={e => setSnapshotMode(e.target.value)}
+          >
+            {options.map(item => (
+              <option key={item.value} value={item.value}>
+                {item.name}
+              </option>
+            ))}
+          </select>
+        </div>
+      </div>
     </ForemanForm>
   );
 };
@@ -93,11 +131,13 @@ SnapshotForm.propTypes = {
     name: PropTypes.string.isRequired,
     description: PropTypes.string.isRequired,
     includeRam: PropTypes.bool.isRequired,
+    useQuiesce: PropTypes.bool,
   }),
   submitForm: PropTypes.func.isRequired,
   setModalClosed: PropTypes.func,
   capabilities: PropTypes.shape({
     limitSnapshotNameFormat: PropTypes.bool,
+    quiesceOption: PropTypes.bool,
   }),
 };
 
@@ -108,10 +148,13 @@ SnapshotForm.defaultProps = {
     name: '',
     description: '',
     includeRam: false,
+    useQuiesce: false,
+    snapshotMode: '',
   },
   setModalClosed: () => {},
   capabilities: {
     limitSnapshotNameFormat: false,
+    quiesceOption: false,
   },
 };
 

data/webpack/components/SnapshotManagement/components/SnapshotForm/__tests__/__snapshots__/SnapshotForm.test.js.snap

@@ -8,6 +8,8 @@ exports[`SnapshotForm rendering render 1`] = `
       "description": "",
       "includeRam": false,
       "name": "",
+      "snapshotMode": "",
+      "useQuiesce": false,
     }
   }
   onCancel={[Function]}
@@ -25,6 +27,8 @@ exports[`SnapshotForm rendering render 1`] = `
       "_exclusive": Object {},
       "_mutate": undefined,
       "_nodes": Array [
+        "snapshotMode",
+        "useQuiesce",
         "includeRam",
         "description",
         "name",
@@ -121,6 +125,56 @@ exports[`SnapshotForm rendering render 1`] = `
           ],
           "type": "string",
         },
+        "snapshotMode": StringSchema {
+          "_blacklist": RefSet {
+            "list": Array [],
+            "refs": Array [],
+          },
+          "_conditions": Array [],
+          "_deps": Array [],
+          "_exclusive": Object {},
+          "_mutate": undefined,
+          "_options": Object {
+            "abortEarly": true,
+            "recursive": true,
+          },
+          "_type": "string",
+          "_typeError": [Function],
+          "_whitelist": RefSet {
+            "list": Array [],
+            "refs": Array [],
+          },
+          "tests": Array [],
+          "transforms": Array [
+            [Function],
+          ],
+          "type": "string",
+        },
+        "useQuiesce": BooleanSchema {
+          "_blacklist": RefSet {
+            "list": Array [],
+            "refs": Array [],
+          },
+          "_conditions": Array [],
+          "_deps": Array [],
+          "_exclusive": Object {},
+          "_mutate": undefined,
+          "_options": Object {
+            "abortEarly": true,
+            "recursive": true,
+          },
+          "_type": "boolean",
+          "_typeError": [Function],
+          "_whitelist": RefSet {
+            "list": Array [],
+            "refs": Array [],
+          },
+          "tests": Array [],
+          "transforms": Array [
+            [Function],
+          ],
+          "type": "boolean",
+        },
       },
       "tests": Array [],
       "transforms": Array [
@@ -146,14 +200,40 @@ exports[`SnapshotForm rendering render 1`] = `
     required={false}
     type="textarea"
   />
-  <TextField
-    className=""
-    inputClassName="col-md-8"
-    label="Include RAM"
-    name="includeRam"
-    required={false}
-    type="checkbox"
-  />
+  <div
+    className="form-group"
+  >
+    <label
+      className="col-md-2 control-label"
+    >
+      Snapshot Mode
+      <FieldLevelHelp
+        buttonClass="field-help"
+        content="Select Snapshot Mode between mutually exclusive options, 'Memory' (includes RAM) and 'Quiesce'."
+        placement="top"
+        rootClose={true}
+      />
+    </label>
+    <div
+      className="col-md-8"
+    >
+      <select
+        className="common-select form-control"
+        onChange={[Function]}
+      >
+        <option
+          key=""
+          value=""
+        />
+        <option
+          key="Memory"
+          value="Memory"
+        >
+          Memory
+        </option>
+      </select>
+    </div>
+  </div>
 </ForemanForm>
 `;
 
@@ -165,6 +245,8 @@ exports[`SnapshotForm rendering render with limitSnapshotNameFormat capability 1
       "description": "",
       "includeRam": false,
       "name": "",
+      "snapshotMode": "",
+      "useQuiesce": false,
     }
   }
   onCancel={[Function]}
@@ -182,6 +264,8 @@ exports[`SnapshotForm rendering render with limitSnapshotNameFormat capability 1
       "_exclusive": Object {},
       "_mutate": undefined,
       "_nodes": Array [
+        "snapshotMode",
+        "useQuiesce",
         "includeRam",
         "description",
         "name",
@@ -282,6 +366,56 @@ exports[`SnapshotForm rendering render with limitSnapshotNameFormat capability 1
           ],
           "type": "string",
         },
+        "snapshotMode": StringSchema {
+          "_blacklist": RefSet {
+            "list": Array [],
+            "refs": Array [],
+          },
+          "_conditions": Array [],
+          "_deps": Array [],
+          "_exclusive": Object {},
+          "_mutate": undefined,
+          "_options": Object {
+            "abortEarly": true,
+            "recursive": true,
+          },
+          "_type": "string",
+          "_typeError": [Function],
+          "_whitelist": RefSet {
+            "list": Array [],
+            "refs": Array [],
+          },
+          "tests": Array [],
+          "transforms": Array [
+            [Function],
+          ],
+          "type": "string",
+        },
+        "useQuiesce": BooleanSchema {
+          "_blacklist": RefSet {
+            "list": Array [],
+            "refs": Array [],
+          },
+          "_conditions": Array [],
+          "_deps": Array [],
+          "_exclusive": Object {},
+          "_mutate": undefined,
+          "_options": Object {
+            "abortEarly": true,
+            "recursive": true,
+          },
+          "_type": "boolean",
+          "_typeError": [Function],
+          "_whitelist": RefSet {
+            "list": Array [],
+            "refs": Array [],
+          },
+          "tests": Array [],
+          "transforms": Array [
+            [Function],
+          ],
+          "type": "boolean",
+        },
       },
       "tests": Array [],
       "transforms": Array [
@@ -307,14 +441,40 @@ exports[`SnapshotForm rendering render with limitSnapshotNameFormat capability 1
     required={false}
     type="textarea"
   />
-  <TextField
-    className=""
-    inputClassName="col-md-8"
-    label="Include RAM"
-    name="includeRam"
-    required={false}
-    type="checkbox"
-  />
+  <div
+    className="form-group"
+  >
+    <label
+      className="col-md-2 control-label"
+    >
+      Snapshot Mode
+      <FieldLevelHelp
+        buttonClass="field-help"
+        content="Select Snapshot Mode between mutually exclusive options, 'Memory' (includes RAM) and 'Quiesce'."
+        placement="top"
+        rootClose={true}
+      />
+    </label>
+    <div
+      className="col-md-8"
+    >
+      <select
+        className="common-select form-control"
+        onChange={[Function]}
+      >
+        <option
+          key=""
+          value=""
+        />
+        <option
+          key="Memory"
+          value="Memory"
+        >
+          Memory
+        </option>
+      </select>
+    </div>
+  </div>
 </ForemanForm>
 `;
 
@@ -343,6 +503,8 @@ exports[`SnapshotForm rendering render with optional Props 1`] = `
       "_exclusive": Object {},
       "_mutate": undefined,
       "_nodes": Array [
+        "snapshotMode",
+        "useQuiesce",
         "includeRam",
         "description",
         "name",
@@ -439,6 +601,56 @@ exports[`SnapshotForm rendering render with optional Props 1`] = `
           ],
           "type": "string",
         },
+        "snapshotMode": StringSchema {
+          "_blacklist": RefSet {
+            "list": Array [],
+            "refs": Array [],
+          },
+          "_conditions": Array [],
+          "_deps": Array [],
+          "_exclusive": Object {},
+          "_mutate": undefined,
+          "_options": Object {
+            "abortEarly": true,
+            "recursive": true,
+          },
+          "_type": "string",
+          "_typeError": [Function],
+          "_whitelist": RefSet {
+            "list": Array [],
+            "refs": Array [],
+          },
+          "tests": Array [],
+          "transforms": Array [
+            [Function],
+          ],
+          "type": "string",
+        },
+        "useQuiesce": BooleanSchema {
+          "_blacklist": RefSet {
+            "list": Array [],
+            "refs": Array [],
+          },
+          "_conditions": Array [],
+          "_deps": Array [],
+          "_exclusive": Object {},
+          "_mutate": undefined,
+          "_options": Object {
+            "abortEarly": true,
+            "recursive": true,
+          },
+          "_type": "boolean",
+          "_typeError": [Function],
+          "_whitelist": RefSet {
+            "list": Array [],
+            "refs": Array [],
+          },
+          "tests": Array [],
+          "transforms": Array [
+            [Function],
+          ],
+          "type": "boolean",
+        },
       },
       "tests": Array [],
       "transforms": Array [
@@ -464,13 +676,39 @@ exports[`SnapshotForm rendering render with optional Props 1`] = `
     required={false}
     type="textarea"
   />
-  <TextField
-    className=""
-    inputClassName="col-md-8"
-    label="Include RAM"
-    name="includeRam"
-    required={false}
-    type="checkbox"
-  />
+  <div
+    className="form-group"
+  >
+    <label
+      className="col-md-2 control-label"
+    >
+      Snapshot Mode
+      <FieldLevelHelp
+        buttonClass="field-help"
+        content="Select Snapshot Mode between mutually exclusive options, 'Memory' (includes RAM) and 'Quiesce'."
+        placement="top"
+        rootClose={true}
+      />
+    </label>
+    <div
+      className="col-md-8"
+    >
+      <select
+        className="common-select form-control"
+        onChange={[Function]}
+      >
+        <option
+          key=""
+          value=""
+        />
+        <option
+          key="Memory"
+          value="Memory"
+        >
+          Memory
+        </option>
+      </select>
+    </div>
+  </div>
 </ForemanForm>
 `;

data/webpack/components/SnapshotManagementCard/SnapshotManagementCard.js

@@ -0,0 +1,61 @@
+import PropTypes from 'prop-types';
+import React from 'react';
+
+import CardTemplate from 'foremanReact/components/HostDetails/Templates/CardItem/CardTemplate';
+import { translate as __ } from 'foremanReact/common/I18n';
+
+import SnapshotManagement from '../SnapshotManagement';
+
+const SnapshotManagementCard = ({ hostDetails, ...props }) => {
+  const children = [];
+  const capabilities = {
+    editableSnapshotName:
+      hostDetails?.capabilities?.includes('editable_snapshot_name') || false,
+    limitSnapshotNameFormat:
+      hostDetails?.capabilities?.includes('limit_snapshot_name_format') ||
+      false,
+    quiesceOption:
+      hostDetails?.capabilities?.includes('snapshot_include_quiesce') || false,
+  };
+
+  if (hostDetails?.id && hostDetails?.permissions)
+    children.push(
+      <SnapshotManagement
+        key="SnapshotManagement"
+        host={{ id: hostDetails.id, name: hostDetails.name }}
+        canCreate={hostDetails.permissions.create_snapshots}
+        canUpdate={hostDetails.permissions.edit_snapshots}
+        canRevert={hostDetails.permissions.revert_snapshots}
+        canDelete={hostDetails.permissions.destroy_snapshots}
+        capabilities={capabilities}
+      />
+    );
+  return (
+    <CardTemplate
+      overrideGridProps={{ xl2: 6, xl: 8, lg: 8, md: 12 }}
+      header={__('Snapshots')}
+    >
+      {children}
+    </CardTemplate>
+  );
+};
+
+export default SnapshotManagementCard;
+
+SnapshotManagementCard.propTypes = {
+  hostDetails: PropTypes.shape({
+    name: PropTypes.string,
+    id: PropTypes.number,
+    capabilities: PropTypes.array,
+    permissions: PropTypes.shape({
+      create_snapshots: PropTypes.bool,
+      edit_snapshots: PropTypes.bool,
+      revert_snapshots: PropTypes.bool,
+      destroy_snapshots: PropTypes.bool,
+    }),
+  }),
+};
+
+SnapshotManagementCard.defaultProps = {
+  hostDetails: {},
+};

data/webpack/components/SnapshotManagementCard/__tests__/SnapshotManagementCard.test.js

@@ -0,0 +1,53 @@
+import { testComponentSnapshotsWithFixtures } from 'react-redux-test-utils';
+
+import SnapshotManagementCard from '../SnapshotManagementCard';
+
+const hostDetails = {
+  id: 42,
+  name: 'deep.thought',
+  permissions: {
+    create_snapshots: true,
+    edit_snapshots: false,
+    revert_snapshots: true,
+    destroy_snapshots: false,
+  },
+};
+
+const hostDetailsVmware = {
+  ...hostDetails,
+  capabilities: [
+    'build',
+    'image',
+    'snapshots',
+    'snapshot_include_quiesce',
+    'snapshot_include_ram',
+    'editable_snapshot_name',
+  ],
+};
+const hostDetailsProxmox = {
+  ...hostDetails,
+  capabilities: [
+    'build',
+    'new_volume',
+    'new_interface',
+    'image',
+    'snapshots',
+    'limit_snapshot_name_format',
+  ],
+};
+
+const fixtures = {
+  'without optional Props': {},
+  'with Props': { hostDetails },
+  'with VMWare capabilities': {
+    hostDetails: hostDetailsVmware,
+  },
+  'with Proxmox capabilities': {
+    hostDetails: hostDetailsProxmox,
+  },
+};
+
+describe('SnapshotManagementCard', () => {
+  describe('renders', () =>
+    testComponentSnapshotsWithFixtures(SnapshotManagementCard, fixtures));
+});