foreman_rh_cloud 3.0.26 → 4.0.21.1

data/test/unit/slice_generator_test.rb

@@ -53,7 +53,6 @@ class SliceGeneratorTest < ActiveSupport::TestCase
       'insights_client::hostname',
       'insights_client::obfuscate_ip_enabled',
       'insights_client::ips',
-      'insights_id',
     ]
   end
 
@@ -72,7 +71,7 @@ class SliceGeneratorTest < ActiveSupport::TestCase
     json_str = generator.render
     actual = JSON.parse(json_str.join("\n"))
 
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
+    assert_equal 'slice_123', actual['report_slice_id']
     assert_not_nil(actual_host = actual['hosts'].first)
     assert_nil actual_host['ip_addresses']
     assert_nil actual_host['mac_addresses']
@@ -103,7 +102,7 @@ class SliceGeneratorTest < ActiveSupport::TestCase
     json_str = generator.render
     actual = JSON.parse(json_str.join("\n"))
 
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
+    assert_equal 'slice_123', actual['report_slice_id']
     assert_not_nil(actual_host = actual['hosts'].first)
     assert_not_nil(actual_system_profile = actual_host['system_profile'])
     assert_equal 4, actual_system_profile['number_of_cpus']
@@ -121,7 +120,7 @@ class SliceGeneratorTest < ActiveSupport::TestCase
     json_str = generator.render
     actual = JSON.parse(json_str.join("\n"))
 
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
+    assert_equal 'slice_123', actual['report_slice_id']
     assert_not_nil(actual_host = actual['hosts'].first)
     assert_equal @host.interfaces.where.not(ip: nil).first.ip, actual_host['ip_addresses'].first
     assert_equal @host.interfaces.where.not(mac: nil).first.mac, actual_host['mac_addresses'].first
@@ -143,7 +142,7 @@ class SliceGeneratorTest < ActiveSupport::TestCase
     json_str = generator.render
     actual = JSON.parse(json_str.join("\n"))
 
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
+    assert_equal 'slice_123', actual['report_slice_id']
     assert_not_nil(actual_host = actual['hosts'].first)
     assert_equal @host.interfaces.where.not(ip: nil).first.ip, actual_host['ip_addresses'].first
     assert_equal @host.interfaces.where.not(mac: nil).first.mac, actual_host['mac_addresses'].first
@@ -173,7 +172,7 @@ class SliceGeneratorTest < ActiveSupport::TestCase
     json_str = generator.render
     actual = JSON.parse(json_str.join("\n"))
 
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
+    assert_equal 'slice_123', actual['report_slice_id']
     assert_not_nil(actual_host = actual['hosts'].first)
     assert_equal @host.interfaces.where.not(ip: nil).first.ip, actual_host['ip_addresses'].first
     assert_equal @host.interfaces.where.not(mac: nil).first.mac, actual_host['mac_addresses'].first
@@ -192,7 +191,7 @@ class SliceGeneratorTest < ActiveSupport::TestCase
     json_str = generator.render
     actual = JSON.parse(json_str.join("\n"))
 
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
+    assert_equal 'slice_123', actual['report_slice_id']
     assert_not_nil(actual_host = actual['hosts'].first)
     assert_equal '10.230.230.1', actual_host['ip_addresses'].first
     assert_not_nil(actual_system_profile = actual_host['system_profile'])
@@ -222,7 +221,7 @@ class SliceGeneratorTest < ActiveSupport::TestCase
     json_str = generator.render
     actual = JSON.parse(json_str.join("\n"))
 
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
+    assert_equal 'slice_123', actual['report_slice_id']
     assert_not_nil(actual_host = actual['hosts'].first)
     assert_equal '10.230.230.100', actual_host['ip_addresses'].first
     assert_not_nil(actual_system_profile = actual_host['system_profile'])
@@ -244,7 +243,7 @@ class SliceGeneratorTest < ActiveSupport::TestCase
     json_str = generator.render
     actual = JSON.parse(json_str.join("\n"))
 
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
+    assert_equal 'slice_123', actual['report_slice_id']
     assert_not_nil(actual_host = actual['hosts'].first)
     assert_equal 'obfuscated_name', actual_host['fqdn']
     assert_equal '1234', actual_host['account']
@@ -264,7 +263,7 @@ class SliceGeneratorTest < ActiveSupport::TestCase
 
     obfuscated_fqdn = Digest::SHA1.hexdigest(@host.fqdn) + '.example.com'
 
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
+    assert_equal 'slice_123', actual['report_slice_id']
     assert_not_nil(actual_host = actual['hosts'].first)
     assert_equal obfuscated_fqdn, actual_host['fqdn']
     assert_equal '1234', actual_host['account']
@@ -283,7 +282,7 @@ class SliceGeneratorTest < ActiveSupport::TestCase
     json_str = generator.render
     actual = JSON.parse(json_str.join("\n"))
 
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
+    assert_equal 'slice_123', actual['report_slice_id']
     assert_not_nil(actual_host = actual['hosts'].first)
     assert_equal @host.fqdn, actual_host['fqdn']
     assert_equal '1234', actual_host['account']
@@ -356,7 +355,7 @@ class SliceGeneratorTest < ActiveSupport::TestCase
     json_str = generator.render
     actual = JSON.parse(json_str.join("\n"))
 
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
+    assert_equal 'slice_123', actual['report_slice_id']
     assert_not_nil(actual_host = actual['hosts'].first)
     assert_equal @host.fqdn, actual_host['fqdn']
     assert_not_nil(host_facts = actual_host['facts']&.first)
@@ -378,7 +377,7 @@ class SliceGeneratorTest < ActiveSupport::TestCase
     json_str = generator.render
     actual = JSON.parse(json_str.join("\n"))
 
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
+    assert_equal 'slice_123', actual['report_slice_id']
     assert_not_nil(actual_host = actual['hosts'].first)
     assert_equal @host.fqdn, actual_host['fqdn']
     assert_not_nil(host_facts = actual_host['facts']&.first)
@@ -398,7 +397,7 @@ class SliceGeneratorTest < ActiveSupport::TestCase
     json_str = generator.render
     actual = JSON.parse(json_str.join("\n"))
 
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
+    assert_equal 'slice_123', actual['report_slice_id']
     assert_not_nil(actual_host = actual['hosts'].first)
     assert_equal @host.fqdn, actual_host['fqdn']
     assert_equal '1234', actual_host['account']
@@ -418,7 +417,7 @@ class SliceGeneratorTest < ActiveSupport::TestCase
     json_str = generator.render
     actual = JSON.parse(json_str.join("\n"))
 
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
+    assert_equal 'slice_123', actual['report_slice_id']
     assert_not_nil(actual_host = actual['hosts'].first)
     assert_equal @host.fqdn, actual_host['fqdn']
     assert_equal '1234', actual_host['account']
@@ -437,7 +436,7 @@ class SliceGeneratorTest < ActiveSupport::TestCase
     json_str = generator.render
     actual = JSON.parse(json_str.join("\n"))
 
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
+    assert_equal 'slice_123', actual['report_slice_id']
     assert_equal 1, generator.hosts_count
   end
 
@@ -450,7 +449,7 @@ class SliceGeneratorTest < ActiveSupport::TestCase
     json_str = generator.render
     actual = JSON.parse(json_str.join("\n"))
 
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
+    assert_equal 'slice_123', actual['report_slice_id']
     assert_not_nil(actual_host = actual['hosts'].first)
     assert_not_nil(actual_profile = actual_host['system_profile'])
     assert_equal 1024, actual_profile['system_memory_bytes']
@@ -476,7 +475,7 @@ class SliceGeneratorTest < ActiveSupport::TestCase
     json_str = generator.render
     actual = JSON.parse(json_str.join("\n"))
 
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
+    assert_equal 'slice_123', actual['report_slice_id']
     assert_not_nil(actual_host = actual['hosts'].first)
     assert_not_nil(actual_host['account'])
     assert_not_empty(actual_host['account'])
@@ -493,7 +492,7 @@ class SliceGeneratorTest < ActiveSupport::TestCase
     json_str = generator.render
     actual = JSON.parse(json_str.join("\n"))
 
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
+    assert_equal 'slice_123', actual['report_slice_id']
     assert_not_nil(actual_host = actual['hosts'].first)
     assert_not_nil(actual_profile = actual_host['system_profile'])
     assert_equal 'Red Hat Test Linux 7.1 (TestId)', actual_profile['os_release']
@@ -508,7 +507,7 @@ class SliceGeneratorTest < ActiveSupport::TestCase
     json_str = generator.render
     actual = JSON.parse(json_str.join("\n"))
 
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
+    assert_equal 'slice_123', actual['report_slice_id']
     assert_not_nil(actual_host = actual['hosts'].first)
     assert_not_nil(actual_profile = actual_host['system_profile'])
     assert_equal 'virtual', actual_profile['infrastructure_type']
@@ -523,7 +522,7 @@ class SliceGeneratorTest < ActiveSupport::TestCase
     json_str = generator.render
     actual = JSON.parse(json_str.join("\n"))
 
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
+    assert_equal 'slice_123', actual['report_slice_id']
     assert_not_nil(actual_host = actual['hosts'].first)
     assert_not_nil(actual_profile = actual_host['system_profile'])
     assert_equal 'physical', actual_profile['infrastructure_type']
@@ -538,7 +537,7 @@ class SliceGeneratorTest < ActiveSupport::TestCase
     json_str = generator.render
     actual = JSON.parse(json_str.join("\n"))
 
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
+    assert_equal 'slice_123', actual['report_slice_id']
     assert_not_nil(actual_host = actual['hosts'].first)
     assert_not_nil(actual_profile = actual_host['system_profile'])
     assert_equal 'aws', actual_profile['cloud_provider']
@@ -553,7 +552,7 @@ class SliceGeneratorTest < ActiveSupport::TestCase
     json_str = generator.render
     actual = JSON.parse(json_str.join("\n"))
 
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
+    assert_equal 'slice_123', actual['report_slice_id']
     assert_not_nil(actual_host = actual['hosts'].first)
     assert_not_nil(actual_profile = actual_host['system_profile'])
     assert_equal 'google', actual_profile['cloud_provider']
@@ -568,7 +567,7 @@ class SliceGeneratorTest < ActiveSupport::TestCase
     json_str = generator.render
     actual = JSON.parse(json_str.join("\n"))
 
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
+    assert_equal 'slice_123', actual['report_slice_id']
     assert_not_nil(actual_host = actual['hosts'].first)
     assert_not_nil(actual_profile = actual_host['system_profile'])
     assert_equal 'azure', actual_profile['cloud_provider']
@@ -583,7 +582,7 @@ class SliceGeneratorTest < ActiveSupport::TestCase
     json_str = generator.render
     actual = JSON.parse(json_str.join("\n"))
 
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
+    assert_equal 'slice_123', actual['report_slice_id']
     assert_not_nil(actual_host = actual['hosts'].first)
     assert_not_nil(actual_profile = actual_host['system_profile'])
     assert_equal 'alibaba', actual_profile['cloud_provider']
@@ -598,7 +597,7 @@ class SliceGeneratorTest < ActiveSupport::TestCase
     json_str = generator.render
     actual = JSON.parse(json_str.join("\n"))
 
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
+    assert_equal 'slice_123', actual['report_slice_id']
     assert_not_nil(actual_host = actual['hosts'].first)
     assert_not_nil(actual_profile = actual_host['system_profile'])
     assert_equal 'alibaba', actual_profile['cloud_provider']
@@ -624,57 +623,15 @@ class SliceGeneratorTest < ActiveSupport::TestCase
     json_str = generator.render
     actual = JSON.parse(json_str.join("\n"))
 
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
+    assert_equal 'slice_123', actual['report_slice_id']
     assert_not_nil(actual_host = actual['hosts'].first)
     assert_not_nil(actual_profile = actual_host['system_profile'])
     assert_not_nil(actual_profile['installed_packages'])
   end
 
-  test 'omits malformed bios_uuid field' do
-    FactoryBot.create(:fact_value, fact_name: fact_names['dmi::system::uuid'], value: 'test value', host: @host)
-
-    batch = Host.where(id: @host.id).in_batches.first
-    generator = create_generator(batch)
-
-    json_str = generator.render
-    actual = JSON.parse(json_str.join("\n"))
-
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
-    assert_not_nil(actual_host = actual['hosts'].first)
-    assert_nil actual_host['bios_uuid']
-  end
-
-  test 'passes valid bios_uuid field' do
-    FactoryBot.create(:fact_value, fact_name: fact_names['dmi::system::uuid'], value: 'D30B0B42-7824-2635-C62D-491394DE43F7', host: @host)
-
-    batch = Host.where(id: @host.id).in_batches.first
-    generator = create_generator(batch)
-
-    json_str = generator.render
-    actual = JSON.parse(json_str.join("\n"))
-
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
-    assert_not_nil(actual_host = actual['hosts'].first)
-    assert_not_nil actual_host['bios_uuid']
-  end
-
-  test 'passes valid insights_id field' do
-    FactoryBot.create(:fact_value, fact_name: fact_names['insights_id'], value: 'D30B0B42-7824-2635-C62D-491394DE43F7', host: @host)
-
-    batch = Host.where(id: @host.id).in_batches.first
-    generator = create_generator(batch)
-
-    json_str = generator.render
-    actual = JSON.parse(json_str.join("\n"))
-
-    assert_equal '00000000-0000-0000-0000-000000000000', actual['report_slice_id']
-    assert_not_nil(actual_host = actual['hosts'].first)
-    assert_not_nil actual_host['insights_id']
-  end
-
   private
 
-  def create_generator(batch, name = '00000000-0000-0000-0000-000000000000')
+  def create_generator(batch, name = 'slice_123')
     generator = ForemanInventoryUpload::Generators::Slice.new(batch, [], name)
     if block_given?
       yield(generator)

data/test/unit/tags_generator_test.rb

@@ -62,47 +62,6 @@ class TagsGeneratorTest < ActiveSupport::TestCase
     assert_equal false, actual.key?('content_view')
   end
 
-  test 'generates parameter tags' do
-    FactoryBot.create(:setting, :name => 'include_parameter_tags', :settings_type => "boolean", :category => "Setting::RhCloud", :default => false, :value => true)
-
-    @host.stubs(:host_inherited_params_objects).returns(
-      [
-        OpenStruct.new(name: 'bool_param', value: true),
-        OpenStruct.new(name: 'false_param', value: false),
-        OpenStruct.new(name: 'int_param', value: 1),
-        OpenStruct.new(name: 'empty_param', value: nil),
-        OpenStruct.new(name: 'empty_str_param', value: ''),
-      ]
-    )
-
-    generator = create_generator
-    actual = Hash[generator.generate_parameters]
-
-    assert_equal 3, actual.count
-    assert_equal true, actual['bool_param']
-    assert_equal false, actual['false_param']
-    assert_equal 1, actual['int_param']
-  end
-
-  test 'skips parameter tags if include_parameter_tags setting is off' do
-    FactoryBot.create(:setting, :name => 'include_parameter_tags', :settings_type => "boolean", :category => "Setting::RhCloud", :default => false, :value => false)
-
-    @host.stubs(:host_inherited_params_objects).returns(
-      [
-        OpenStruct.new(name: 'bool_param', value: true),
-        OpenStruct.new(name: 'false_param', value: false),
-        OpenStruct.new(name: 'int_param', value: 1),
-        OpenStruct.new(name: 'empty_param', value: nil),
-        OpenStruct.new(name: 'empty_str_param', value: ''),
-      ]
-    )
-
-    generator = create_generator
-    actual = generator.generate_parameters.group_by { |key, value| key }
-
-    assert_equal 0, actual.count
-  end
-
   private
 
   def create_generator

data/webpack/ForemanInventoryUpload/Components/PageHeader/components/PageDescription/PageDescription.js

@@ -31,17 +31,6 @@ export const PageDescription = () => (
         About subscription watch
       </a>
     </p>
-    <p>
-      {__('For more information about Insights and Cloud Connector read')}
-      &nbsp;
-      <a
-        href="https://console.redhat.com/security/insights/"
-        target="_blank"
-        rel="noopener noreferrer"
-      >
-        Red Hat Insights Data and Application Security
-      </a>
-    </p>
   </div>
 );
 

data/webpack/ForemanInventoryUpload/Components/PageHeader/components/PageDescription/__tests__/__snapshots__/PageDescription.test.js.snap

@@ -24,16 +24,5 @@ exports[`PageDescription rendering render without Props 1`] = `
       About subscription watch
     </a>
   </p>
-  <p>
-    For more information about Insights and Cloud Connector read
-     
-    <a
-      href="https://console.redhat.com/security/insights/"
-      rel="noopener noreferrer"
-      target="_blank"
-    >
-      Red Hat Insights Data and Application Security
-    </a>
-  </p>
 </div>
 `;

data/webpack/ForemanInventoryUpload/Components/PageHeader/components/SyncButton/SyncButtonActions.js

@@ -1,5 +1,6 @@
 import React from 'react';
-import { post } from 'foremanReact/redux/API';
+import { get, post } from 'foremanReact/redux/API';
+import { withInterval } from 'foremanReact/redux/middlewares/IntervalMiddleware';
 import { addToast } from 'foremanReact/redux/actions/toasts';
 import { translate as __ } from 'foremanReact/common/I18n';
 import { inventoryUrl } from '../../../../ForemanInventoryHelpers';
@@ -8,10 +9,7 @@ import {
   INVENTORY_SYNC,
   INVENTORY_SYNC_TASK_UPDATE,
 } from './SyncButtonConstants';
-import {
-  setupTaskPolling,
-  taskRelatedToast,
-} from '../../../../../common/ForemanTasks';
+import { foremanUrl } from '../../../../../ForemanRhCloudHelpers';
 
 export const handleSync = () => dispatch => {
   dispatch(
@@ -23,9 +21,9 @@ export const handleSync = () => dispatch => {
           task: { id },
         },
       }) => {
-        dispatch(setupInventorySyncTaskPolling(id, dispatch));
+        dispatch(getSyncTaskInterval(id));
         return dispatch(
-          taskRelatedToast(id, 'info', __('Inventory sync has started:'))
+          taskPageRefererToast(id, 'info', __('Inventory sync has started:'))
         );
       },
       errorToast: inventorySyncErrorToast,
@@ -33,25 +31,62 @@ export const handleSync = () => dispatch => {
   );
 };
 
-export const setupInventorySyncTaskPolling = (id, dispatch) =>
-  setupTaskPolling({
-    taskId: id,
-    key: INVENTORY_SYNC_TASK_UPDATE,
-    onTaskSuccess: ({
-      output: {
-        host_statuses: { sync, disconnect },
-      },
-    }) =>
-      dispatch(
-        addToast({
-          sticky: true,
-          type: 'success',
-          message: <Toast syncHosts={sync} disconnectHosts={disconnect} />,
-        })
-      ),
-    dispatch,
-  });
+export const getSyncTaskInterval = id => dispatch => {
+  dispatch(
+    withInterval(
+      get({
+        key: INVENTORY_SYNC_TASK_UPDATE,
+        url: inventoryUrl(`tasks/${id}`),
+        handleSuccess: ({ data: { result, output } }, stopTaskInterval) => {
+          if (result === 'success') {
+            const {
+              host_statuses: { sync, disconnect },
+            } = output;
+            dispatch(
+              addToast({
+                sticky: true,
+                type: 'success',
+                message: (
+                  <Toast syncHosts={sync} disconnectHosts={disconnect} />
+                ),
+              })
+            );
+          }
+          if (result === 'error') {
+            dispatch(
+              taskPageRefererToast(
+                id,
+                'error',
+                __('Inventory sync has failed:'),
+                true
+              )
+            );
+          }
+          stopTaskInterval();
+        },
+        errorToast: inventorySyncErrorToast,
+      })
+    )
+  );
+};
 
-const inventorySyncErrorToast = message =>
-  `${__('Inventory sync has failed: ')} ${message.response?.data?.message ||
-    message}`;
+const inventorySyncErrorToast = ({ message, response }) =>
+  `${__('Inventory sync has failed: ')} ${response.data?.message || message}`;
+
+const taskPageRefererToast = (taskID, toastType, prefix, sticky = false) =>
+  addToast({
+    sticky,
+    type: toastType,
+    message: (
+      <span>
+        {prefix}{' '}
+        <a
+          target="_blank"
+          rel="noopener noreferrer"
+          href={foremanUrl(`/foreman_tasks/tasks/${taskID}`)}
+        >
+          {__('view the task page for more details')}
+        </a>
+      </span>
+    ),
+  });

data/webpack/ForemanInventoryUpload/Components/PageHeader/components/SyncButton/__tests__/__snapshots__/integrations.test.js.snap

@@ -22,7 +22,7 @@ Array [
       "errorToast": [Function],
       "interval": 3000,
       "type": "API_GET",
-      "url": "/foreman_tasks/api/tasks/1/details?include_permissions",
+      "url": "/foreman_inventory_upload/tasks/1",
     },
   ],
   Array [
@@ -31,7 +31,7 @@ Array [
         "message": Object {
           "message": <span>
             Inventory sync has started:
-            <br />
+             
             <a
               href="/foreman_tasks/tasks/1"
               rel="noopener noreferrer"
@@ -40,6 +40,7 @@ Array [
               view the task page for more details
             </a>
           </span>,
+          "sticky": false,
           "type": "info",
         },
       },

data/webpack/InsightsCloudSync/Components/InsightsTable/InsightsTableActions.js

@@ -19,6 +19,25 @@ export const fetchInsights = (queryParams = {}) => (dispatch, getState) => {
     ...queryParams,
   };
 
+  dispatch(
+    get({
+      key: INSIGHTS_HITS_API_KEY,
+      url: INSIGHTS_HITS_PATH,
+      params: {
+        page,
+        per_page: perPage,
+        search: query,
+        order: `${sortBy} ${sortOrder}`,
+      },
+      handleSuccess: response => {
+        if (isSelectAll) {
+          selectAllIds(dispatch, response.data.hits || []);
+          dispatch(selectAll());
+        }
+      },
+    })
+  );
+
   const uri = new URI();
   uri.search({
     page,
@@ -39,25 +58,6 @@ export const fetchInsights = (queryParams = {}) => (dispatch, getState) => {
   if (!isSelectAll) {
     dispatch(setSelectAllAlert(false));
   }
-
-  return dispatch(
-    get({
-      key: INSIGHTS_HITS_API_KEY,
-      url: INSIGHTS_HITS_PATH,
-      params: {
-        page,
-        per_page: perPage,
-        search: query,
-        order: `${sortBy} ${sortOrder}`,
-      },
-      handleSuccess: response => {
-        if (isSelectAll) {
-          selectAllIds(dispatch, response.data.hits || []);
-          dispatch(selectAll());
-        }
-      },
-    })
-  );
 };
 
 const selectAllIds = (dispatch, results, prevSelectedIds = {}) => {

data/webpack/InsightsCloudSync/Components/InsightsTable/__tests__/__snapshots__/InsightsTableActions.test.js.snap

@@ -26,20 +26,6 @@ Array [
 
 exports[`insights table actions should fetchInsights 1`] = `
 Array [
-  Array [
-    Object {
-      "payload": Object {
-        "args": Array [
-          Object {
-            "pathname": "/foreman_rh_cloud/insights_cloud",
-            "search": "?page=2&per_page=7&search=&sort_by=&sort_order=&select_all=true",
-          },
-        ],
-        "method": "push",
-      },
-      "type": "@@router/CALL_HISTORY_METHOD",
-    },
-  ],
   Array [
     Object {
       "payload": Object {
@@ -75,6 +61,20 @@ Array [
       "url": "/insights_cloud/hits",
     },
   ],
+  Array [
+    Object {
+      "payload": Object {
+        "args": Array [
+          Object {
+            "pathname": "/foreman_rh_cloud/insights_cloud",
+            "search": "?page=2&per_page=7&search=&sort_by=&sort_order=&select_all=true",
+          },
+        ],
+        "method": "push",
+      },
+      "type": "@@router/CALL_HISTORY_METHOD",
+    },
+  ],
 ]
 `;
 

data/webpack/InsightsCloudSync/Components/RemediationModal/RemediateButton.js

@@ -34,7 +34,6 @@ const RemediateButton = ({ isExperimentalMode, selectedIds, toggleModal }) => {
     button = (
       <Popover
         isVisible={isVisible}
-        aria-label={__('Please enable lab features to use this button')}
         bodyContent={
           <div dangerouslySetInnerHTML={{ __html: popoverContent }} />
         }

data/webpack/InsightsCloudSync/Components/RemediationModal/RemediationModal.scss

@@ -6,18 +6,4 @@
       margin-top: 5px;
     }
   }
-
-  // applies to the backdrop parent of the modal
-  @at-root .pf-c-backdrop {
-    width: calc(100% - 200px) !important;
-    left: 200px !important;
-  }
-
-  // where the vertical nav breaks: https://github.com/theforeman/foreman/blob/3347fa49d500964f0209122d8d36c920d1feafcc/webpack/assets/javascripts/react_app/components/Layout/components/Toolbar/HeaderToolbar.scss#L26
-  @media (max-width: 768px) {
-    @at-root .pf-c-backdrop {
-      width: 100% !important;
-      left: 0 !important;
-    }
-  }
 }