foreman_rh_cloud 3.0.26 → 4.0.21.1

data/lib/insights_cloud/async/insights_rules_sync.rb

@@ -6,17 +6,8 @@ module InsightsCloud
       include ::ForemanRhCloud::CloudAuth
 
       def plan
-        unless cloud_auth_available?
-          logger.debug('Cloud authentication is not available, skipping rules sync')
-          return
-        end
-
-        # since the tasks are not connected, we need to force sequence execution here
-        # to make sure we don't run resolutions until we synced all our rules
-        sequence do
-          plan_self
-          plan_resolutions
-        end
+        plan_self
+        plan_resolutions
       end
 
       def plan_resolutions
@@ -46,9 +37,14 @@ module InsightsCloud
       private
 
       def query_insights_rules(offset)
-        rules_response = execute_cloud_request(
+        rules_response = RestClient::Request.execute(
           method: :get,
-          url: InsightsCloud.rules_url(offset: offset)
+          url: InsightsCloud.rules_url(offset: offset),
+          verify_ssl: ForemanRhCloud.verify_ssl_method,
+          proxy: ForemanRhCloud.transformed_http_proxy_string(logger: logger),
+          headers: {
+            Authorization: "Bearer #{rh_credentials}",
+          }
         )
 
         JSON.parse(rules_response)

data/lib/inventory_sync/async/host_result.rb

@@ -1,8 +1,6 @@
 module InventorySync
   module Async
     class HostResult
-      attr_reader :uuid_by_fqdn
-
       def initialize(result)
         @total = result['total']
         @count = result['count']
@@ -10,7 +8,6 @@ module InventorySync
         @per_page = result['per_page']
         @sub_ids = result["results"].map { |host| host['subscription_manager_id'] }
         @uuid_by_sub_id = Hash[result["results"].map { |host| [host['subscription_manager_id'], host['id']] }]
-        @uuid_by_fqdn = Hash[result["results"].map { |host| [host['fqdn'].downcase, host['id']] }]
       end
 
       def status_hashes
@@ -22,7 +19,6 @@ module InventorySync
               host_id: host_id,
               status: InventorySync::InventoryStatus::SYNC,
               reported_at: DateTime.current,
-              type: InventorySync::InventoryStatus.name,
             }
           end
         end.compact

data/lib/inventory_sync/async/inventory_full_sync.rb

@@ -5,11 +5,6 @@ module InventorySync
       set_callback :step, :around, :update_statuses_batch
 
       def plan(organization)
-        unless cloud_auth_available?
-          logger.debug('Cloud authentication is not available, skipping inventory hosts sync')
-          return
-        end
-
         plan_self(organization_id: organization.id)
       end
 
@@ -29,7 +24,6 @@ module InventorySync
 
         logger.debug("Synced hosts amount: #{host_statuses[:sync]}")
         logger.debug("Disconnected hosts amount: #{host_statuses[:disconnect]}")
-        output[:host_statuses] = host_statuses
       end
 
       def update_statuses_batch
@@ -59,7 +53,7 @@ module InventorySync
       end
 
       def host_statuses
-        @host_statuses ||= {
+        output[:host_statuses] ||= {
           sync: 0,
           disconnect: 0,
         }

data/lib/inventory_sync/async/inventory_hosts_sync.rb

@@ -4,17 +4,6 @@ module InventorySync
       set_callback :iteration, :around, :setup_facet_transaction
       set_callback :step, :around, :create_facets
 
-      def plan
-        unless cloud_auth_available?
-          logger.debug('Cloud authentication is not available, skipping inventory hosts sync')
-          return
-        end
-
-        # by default the tasks will be executed concurrently
-        plan_self
-        plan_self_host_sync
-      end
-
       def setup_facet_transaction
         InsightsFacet.transaction do
           yield
@@ -31,22 +20,14 @@ module InventorySync
       private
 
       def add_missing_insights_facets(uuids_hash)
-        existing_facets = InsightsFacet.where(host_id: uuids_hash.keys).pluck(:host_id, :uuid)
-        missing_facets = uuids_hash.except(*existing_facets.map(&:first)).map do |host_id, uuid|
+        existing_facets = InsightsFacet.where(host_id: uuids_hash.keys).pluck(:host_id)
+        missing_facets = uuids_hash.except(*existing_facets).map do |host_id, uuid|
           {
             host_id: host_id,
             uuid: uuid,
           }
         end
         InsightsFacet.create(missing_facets)
-
-        existing_facets.select { |host_id, uuid| uuid.empty? }.each do |host_id, _uuid|
-          InsightsFacet.where(host_id: host_id).update_all(uuid: uuids_hash[host_id])
-        end
-      end
-
-      def plan_self_host_sync
-        plan_action InventorySync::Async::InventorySelfHostSync
       end
     end
   end

data/lib/inventory_sync/async/inventory_scheduled_sync.rb

@@ -4,14 +4,6 @@ module InventorySync
       include ::Actions::RecurringAction
 
       def plan
-        unless Setting[:allow_auto_inventory_upload]
-          logger.debug(
-            'The scheduled process is disabled due to the "allow_auto_inventory_upload"
-            setting being set to false.'
-          )
-          return
-        end
-
         Organization.unscoped.each do |org|
           plan_org_sync(org)
         end
@@ -20,10 +12,6 @@ module InventorySync
       def plan_org_sync(org)
         plan_action InventoryFullSync, org
       end
-
-      def logger
-        action_logger
-      end
     end
   end
 end

data/lib/inventory_sync/async/query_inventory_job.rb

@@ -29,10 +29,13 @@ module InventorySync
       private
 
       def query_inventory(page = 1)
-        hosts_inventory_response = execute_cloud_request(
+        hosts_inventory_response = RestClient::Request.execute(
           method: :get,
-          url: request_url,
+          url: ForemanInventoryUpload.inventory_export_url,
+          verify_ssl: ForemanRhCloud.verify_ssl_method,
+          proxy: ForemanRhCloud.transformed_http_proxy_string(logger: logger),
           headers: {
+            Authorization: "Bearer #{rh_credentials}",
             params: {
               per_page: 100,
               page: page,
@@ -46,10 +49,6 @@ module InventorySync
       def logger
         action_logger
       end
-
-      def request_url
-        ForemanInventoryUpload.inventory_export_url
-      end
     end
   end
 end

data/lib/tasks/insights.rake

@@ -4,19 +4,4 @@ namespace :rh_cloud_insights do
     ForemanTasks.sync_task(InsightsCloud::Async::InsightsFullSync)
     puts "Synchronized Insights hosts hits data"
   end
-
-  desc "Remove insights client report statuses by searching on host criteria"
-  task clean_statuses: [:environment] do
-    hosts_search = ENV['SEARCH']
-
-    if hosts_search.empty?
-      puts 'Must specify SEARCH= criteria for hosts search'
-      next
-    end
-
-    cleaner = ForemanRhCloud::InsightsStatusCleaner.new
-    deleted_count = cleaner.clean(hosts_search)
-
-    puts "Deleted #{deleted_count} insights statuses"
-  end
 end

data/lib/tasks/rh_cloud_inventory.rake

@@ -23,15 +23,8 @@ namespace :rh_cloud_inventory do
       organizations = [ENV['organization_id']]
       base_folder = ENV['target'] || Dir.pwd
 
-      unless File.writable?(base_folder)
-        puts "#{base_folder} is not writable by the current process"
-        base_folder = Dir.mktmpdir
-        puts "Using #{base_folder} for the output"
-      end
-
-      if portal_user.empty? && organizations.empty?
+      unless portal_user || organizations.empty?
         puts "Must specify either portal_user or organization_id"
-        return
       end
 
       User.as_anonymous_admin do

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "foreman_rh_cloud",
-  "version": "3.0.26",
+  "version": "4.0.21.1",
   "description": "Inventory Upload =============",
   "main": "index.js",
   "scripts": {

data/test/controllers/insights_cloud/api/machine_telemetries_controller_test.rb

@@ -11,39 +11,6 @@ module InsightsCloud::Api
         host = FactoryBot.create(:host, :with_subscription, :organization => org)
         User.current = ::Katello::CpConsumerUser.new(:uuid => host.subscription_facet.uuid, :login => host.subscription_facet.uuid)
         InsightsCloud::Api::MachineTelemetriesController.any_instance.stubs(:upstream_owner).returns({ 'uuid' => 'abcdefg' })
-
-        @cert1 = "-----BEGIN CERTIFICATE-----\r\n" +
-        "MIIFdDCCA1ygAwIBAgIJAM5Uqykb3EAtMA0GCSqGSIb3DQEBCwUAME8xCzAJBgNV\r\n" +
-        "BAYTAklMMREwDwYDVQQIDAhUZWwgQXZpdjEUMBIGA1UECgwLVGhlIEZvcmVtYW4x\r\n" +
-        "FzAVBgNVBAMMDnRoZWZvcmVtYW4ub3JnMB4XDTE4MDMyNDEyMzYyOFoXDTI4MDMy\r\n" +
-        "MTEyMzYyOFowTzELMAkGA1UEBhMCSUwxETAPBgNVBAgMCFRlbCBBdml2MRQwEgYD\r\n" +
-        "VQQKDAtUaGUgRm9yZW1hbjEXMBUGA1UEAwwOdGhlZm9yZW1hbi5vcmcwggIiMA0G\r\n" +
-        "CSqGSIb3DQEBAQUAA4ICDwAwggIKAoICAQDF04/s4h+BgHPG1HDZ/sDlYq925pkc\r\n" +
-        "RTVAfnE2EXDAmZ6W4Q9ueDY65MHe3ZWO5Dg72kNSP2sK9kRI7Dk5CAFOgyw1rH8t\r\n" +
-        "Hd1+0xp/lv6e4SvSYghxIL68vFe0ftKkm1usqejBM5ZTgKr7JCI+XSIN36F65Kde\r\n" +
-        "c+vxwBnayuhP04r9/aaE/709SXML4eRVYW8I3qFy9FPtUOm+bY8U2PIv5fHayqbG\r\n" +
-        "cL/4t3+MCtMhHJsLzdBXya+1P5t+HcKjUNlmwoUF961YAktVuEFloGd0RMRlqF3/\r\n" +
-        "itU3QNlXgA5QBIciE5VPr/PiqgMC3zgd5avjF4OribZ+N9AATLiQMW78il5wSfcc\r\n" +
-        "kQjU9ChOLrzku455vQ8KE4bc0qvpCWGfUah6MvL9JB+TQkRl/8kxl0b9ZinIvJDH\r\n" +
-        "ynVMb4cB/TDEjrjOfzn9mWLH0ZJqjmc2bER/G12WQxOaYLxdVwRStD3Yh6PtiFWu\r\n" +
-        "sXOk19UOTVkeuvGFVtvzLfEwQ1lDEo7+VBQz8FG/HBu2Hpq3IwCFrHuicikwjQJk\r\n" +
-        "nfturgD0rBOKEc1qWNZRCvovYOLL6ihvv5Orujsx5ZCHOAtnVNxkvIlFt2RS45LF\r\n" +
-        "MtPJyhAc6SjitllfUEirxprsbmeSZqrIfzcGaEhgOSnyik1WMv6bYiqPfBg8Fzjh\r\n" +
-        "vOCbtiDNPmvgOwIDAQABo1MwUTAdBgNVHQ4EFgQUtkAgQopsTtG9zSG3MgW2IxHD\r\n" +
-        "MDwwHwYDVR0jBBgwFoAUtkAgQopsTtG9zSG3MgW2IxHDMDwwDwYDVR0TAQH/BAUw\r\n" +
-        "AwEB/zANBgkqhkiG9w0BAQsFAAOCAgEAJq7iN+ZroRBweNhvUobxs75bLIV6tNn1\r\n" +
-        "MdNHDRA+hezwf+gxHZhFyaAHfTpst2/9leK5Qe5Zd6gZLr3E5/8ppQuRod72H39B\r\n" +
-        "vxMlG5zxDss0WMo3vZeKZbTY6QhXi/lY2IZ6OGV4feSvCsYxn27GTjjrRUSLFeHH\r\n" +
-        "JVemCwCDMavaE3+OIY4v2P4FcG+MjUvfOB9ahI24TWL7YgrsNVmJjCILq+EeUj0t\r\n" +
-        "Gde1SXVyLkqt7PoxHRJAE0BCEMJSnjxaVB329acJgeehBUxjj4CCPqtDxtbz9HEH\r\n" +
-        "mOKfNdaKpFor+DUeEKUWVGnr9U9xOaC+Ws+oX7MIEUCDM7p2ob4JwcjnFs1jZgHh\r\n" +
-        "Hwig+i7doTlc701PvKWO96fuNHK3B3/jTb1fVvSZ49O/RvY1VWODdUdxWmXGHNh3\r\n" +
-        "LoR8tSPEb46lC2DXGaIQumqQt8PnBG+vL1qkQa1SGTV7dJ8TTbxbv0S+sS+igkk9\r\n" +
-        "zsIEK8Ea3Ep935cXximz0faAAKHSA+It+xHLAyDtqy2KaAEBgGsBuuWlUfK6TaP3\r\n" +
-        "Gwdjct3y4yYUO45lUsUfHqX8vk/4ttW5zYeDiW+HArJz+9VUXNbEdury4kGuHgBj\r\n" +
-        "xHD4Bsul65+hHZ9QywKU26F1A6TLkYpQ2rk/Dx9LGICM4m4IlHjWJPFsQdtkyOor\r\n" +
-        "osxMtcaZZ1E=\r\n" +
-        "-----END CERTIFICATE-----"
       end
 
       test "should respond with response from cloud" do
@@ -63,14 +30,6 @@ module InsightsCloud::Api
         ::ForemanRhCloud::CloudRequestForwarder.any_instance.expects(:execute_cloud_request).with do |opts|
           opts[:headers][:content_type] == 'application/json'
         end.returns(res)
-        InsightsCloud::Api::MachineTelemetriesController.any_instance.expects(:candlepin_id_cert)
-          .returns(
-            {
-              cert: @cert1,
-              key: OpenSSL::PKey::RSA.new(1024).to_pem,
-            }
-          )
-        InsightsCloud::Api::MachineTelemetriesController.any_instance.expects(:cp_owner_id).returns('123')
 
         post :forward_request, as: :json, params: { "path" => "static/v1/test", "machine_telemetry" => {"foo" => "bar"} }
         assert_equal @body, @response.body

data/test/factories/inventory_upload_factories.rb

@@ -49,7 +49,7 @@ end
 
 FactoryBot.define do
   factory :katello_subscription_facets, :aliases => [:subscription_facet], :class => ::Katello::Host::SubscriptionFacet do
-    sequence(:uuid) { |n| "00000000-%<n>04d-%<r>04d-0000-000000000000" % {n: n, r: rand(500)} }
+    sequence(:uuid) { |n| "uuid-#{n}-#{rand(500)}" }
     facts { { 'memory.memtotal' => "12 GB" } }
   end
 end

data/test/jobs/insights_full_sync_test.rb

@@ -7,7 +7,6 @@ class InsightsFullSyncTest < ActiveSupport::TestCase
   setup do
     InsightsCloud::Async::InsightsFullSync.any_instance.stubs(:plan_rules_sync)
     InsightsCloud::Async::InsightsFullSync.any_instance.stubs(:plan_notifications)
-    FactoryBot.create(:setting, name: 'rh_cloud_token', value: 'MOCK_TOKEN')
 
     uuid1 = 'accdf444-5628-451d-bf3e-cf909ad72756'
     @host1 = FactoryBot.create(:host, :managed, name: 'host1')

data/test/jobs/insights_resolutions_sync_test.rb

@@ -1,4 +1,4 @@
-require 'test_plugin_helper'
+require 'test_helper'
 require 'foreman_tasks/test_helpers'
 
 class InsightsResolutionsSyncTest < ActiveSupport::TestCase
@@ -63,7 +63,6 @@ class InsightsResolutionsSyncTest < ActiveSupport::TestCase
     }
 
     @rule = FactoryBot.create(:insights_rule, rule_id: 'network_tcp_connection_hang|NETWORK_TCP_CONNECTION_HANG_WARN')
-    FactoryBot.create(:setting, name: 'rh_cloud_token', value: 'MOCK_TOKEN')
   end
 
   test 'Resolutions data is replaced with data from cloud' do
@@ -75,13 +74,4 @@ class InsightsResolutionsSyncTest < ActiveSupport::TestCase
     assert_equal 5, InsightsResolution.all.count
     assert_equal 2, @rule.resolutions.count
   end
-
-  test 'Skips pinging the cloud if no rule ids were found' do
-    InsightsCloud::Async::InsightsResolutionsSync.any_instance.expects(:query_insights_resolutions).never
-    InsightsRule.all.delete_all
-
-    ForemanTasks.sync_task(InsightsCloud::Async::InsightsResolutionsSync)
-
-    assert_equal 0, InsightsResolution.all.count
-  end
 end

data/test/jobs/insights_rules_sync_test.rb

@@ -112,7 +112,6 @@ class InsightsRulesSyncTest < ActiveSupport::TestCase
     @hit = FactoryBot.create(:insights_hit, host_id: @host.id)
 
     InsightsCloud::Async::InsightsRulesSync.any_instance.stubs(:plan_resolutions)
-    FactoryBot.create(:setting, name: 'rh_cloud_token', value: 'MOCK_TOKEN')
   end
 
   test 'Hits data is replaced with data from cloud' do

data/test/jobs/inventory_full_sync_test.rb

@@ -242,7 +242,6 @@ class InventoryFullSyncTest < ActiveSupport::TestCase
   end
 
   test 'Host status should be SYNC for inventory hosts' do
-    FactoryBot.create(:setting, name: 'rh_cloud_token', value: 'TEST TOKEN')
     InventorySync::Async::InventoryFullSync.any_instance.expects(:query_inventory).returns(@inventory)
 
     ForemanTasks.sync_task(InventorySync::Async::InventoryFullSync, @host2.organization)
@@ -254,7 +253,6 @@ class InventoryFullSyncTest < ActiveSupport::TestCase
   end
 
   test 'Host status should be DISCONNECT for hosts that are not returned from cloud' do
-    FactoryBot.create(:setting, name: 'rh_cloud_token', value: 'TEST TOKEN')
     InventorySync::Async::InventoryFullSync.any_instance.expects(:query_inventory).returns(@inventory)
     FactoryBot.create(:fact_value, fact_name: fact_names['virt::uuid'], value: '1234', host: @host2)
 
@@ -263,12 +261,4 @@ class InventoryFullSyncTest < ActiveSupport::TestCase
 
     assert_equal InventorySync::InventoryStatus::DISCONNECT, InventorySync::InventoryStatus.where(host_id: @host1.id).first.status
   end
-
-  test 'Task should be aborted if token is not present' do
-    FactoryBot.create(:setting, name: 'rh_cloud_token', value: '')
-
-    InventorySync::Async::InventoryFullSync.any_instance.expects(:plan_self).never
-
-    ForemanTasks.sync_task(InventorySync::Async::InventoryFullSync, @host1.organization)
-  end
 end

data/test/models/insights_client_report_status_test.rb

@@ -1,75 +1,77 @@
 require 'test_plugin_helper'
 
 class InsightsClientReportStatusTest < ActiveSupport::TestCase
-  setup do
-    @host = FactoryBot.create(:host, :managed)
-  end
-
-  test 'fresh host does not have insights status' do
-    @host.reload
-
-    refute @host.host_statuses.where(type: 'InsightsClientReportStatus').exists?
-    insights_status = @host.get_status(InsightsClientReportStatus)
-    refute insights_status.relevant?
-  end
-
-  test 'host can refresh all its statuses' do
-    @host.refresh_statuses
-    @host.reload
-
-    refute @host.host_statuses.where(type: 'InsightsClientReportStatus').exists?
-  end
-
-  test 'host with correct report status sets global status to OK' do
-    global_status = @host.get_status(HostStatus.find_status_by_humanized_name('Global'))
-    # Status has to be OK before action
-    assert_equal HostStatus::Global::OK, global_status.status
-
-    # force create record
-    @host.get_status(InsightsClientReportStatus).refresh!
-    # now refresh should work
-    @host.refresh_statuses([InsightsClientReportStatus])
-
-    @host.reload
-    global_status = @host.get_status(HostStatus.find_status_by_humanized_name('Global'))
-    # Status has to be OK after the action too
-    assert_equal HostStatus::Global::OK, global_status.status
-
-    insights_status = @host.get_status(InsightsClientReportStatus)
-    # assert the status would be displayed
-    assert insights_status.relevant?
-  end
-
-  test 'host will return to OK once the status is refreshed' do
-    global_status = @host.get_status(HostStatus.find_status_by_humanized_name('Global'))
-    # Status has to be OK before action
-    assert_equal HostStatus::Global::OK, global_status.status
-
-    insights_status = @host.get_status(InsightsClientReportStatus)
-    insights_status.status = InsightsClientReportStatus::NO_REPORT
-    insights_status.save!
-    @host.refresh_global_status!
-    global_status = @host.global_status
-    assert_equal HostStatus::Global::ERROR, global_status
-
-    @host.refresh_statuses([InsightsClientReportStatus])
-
-    @host.reload
-    # Status has to be OK after the action too
-    assert_equal HostStatus::Global::OK, @host.global_status
-  end
-
-  test 'host with stale status would set global to ERROR' do
-    global_status = @host.get_status(HostStatus.find_status_by_humanized_name('Global'))
-    # Status has to be OK before action
-    assert_equal HostStatus::Global::OK, global_status.status
-
-    insights_status = @host.get_status(InsightsClientReportStatus)
-    insights_status.status = InsightsClientReportStatus::NO_REPORT
-    insights_status.save!
-    @host.refresh_global_status!
-    @host.reload
-
-    assert_equal HostStatus::Global::ERROR, @host.global_status
+  describe 'to_status' do
+    let(:host) { FactoryBot.create(:host, :managed) }
+
+    setup do
+      CommonParameter.where(name: 'host_registration_insights').destroy_all
+    end
+
+    test 'host_registration_insights = true & is getting data' do
+      FactoryBot.create(:common_parameter, name: 'host_registration_insights', key_type: 'boolean', value: true)
+      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
+
+      assert_equal 0, host_status.to_status(data: true)
+    end
+
+    test 'host_registration_insights = true & no data in less than 48 hours' do
+      FactoryBot.create(:common_parameter, name: 'host_registration_insights', key_type: 'boolean', value: true)
+      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
+      host_status.update(reported_at: 1.day.ago)
+      assert_equal 0, host_status.to_status
+    end
+
+    test 'host_registration_insights = true & no data in more than 48 hours' do
+      FactoryBot.create(:common_parameter, name: 'host_registration_insights', key_type: 'boolean', value: true)
+      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
+      host_status.update(reported_at: 3.days.ago)
+      assert_equal 1, host_status.to_status
+    end
+
+    test 'host_registration_insights = false & no data' do
+      FactoryBot.create(:common_parameter, name: 'host_registration_insights', key_type: 'boolean', value: false)
+      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
+      assert_equal 2, host_status.to_status
+    end
+
+    test 'host_registration_insights = false & getting data' do
+      FactoryBot.create(:common_parameter, name: 'host_registration_insights', key_type: 'boolean', value: false)
+      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
+      assert_equal 3, host_status.to_status(data: true)
+    end
+
+    test 'host_registration_insights = nil & is getting data' do
+      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
+      assert_equal 3, host_status.to_status(data: true)
+    end
+
+    test 'host_registration_insights = nil & no data in less than 48 hours' do
+      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
+      host_status.update(reported_at: 1.day.ago)
+      assert_equal 2, host_status.to_status
+    end
+
+    test 'host_registration_insights = nil & no data in more than 48 hours' do
+      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
+      host_status.update(reported_at: 3.days.ago)
+      assert_equal 2, host_status.to_status
+    end
+
+    test 'override param on host level from `false` to `true`' do
+      FactoryBot.create(:common_parameter, name: 'host_registration_insights', key_type: 'boolean', value: false)
+      FactoryBot.create(:host_parameter, name: 'host_registration_insights', key_type: 'boolean', value: true, host: host)
+
+      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
+      assert_equal 0, host_status.to_status(data: true)
+    end
+
+    test 'override param on host level from `true` to `false`' do
+      FactoryBot.create(:common_parameter, name: 'host_registration_insights', key_type: 'boolean', value: true)
+      FactoryBot.create(:host_parameter, name: 'host_registration_insights', key_type: 'boolean', value: false, host: host)
+
+      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
+      assert_equal 2, host_status.to_status
+    end
   end
 end

data/test/test_plugin_helper.rb

@@ -2,8 +2,6 @@
 require 'test_helper'
 
 # Add plugin to FactoryBot's paths
-FactoryBot.definition_file_paths << "#{ForemanTasks::Engine.root}/test/factories"
-FactoryBot.definition_file_paths << "#{ForemanRemoteExecution::Engine.root}/test/factories"
 FactoryBot.definition_file_paths << File.join(File.dirname(__FILE__), 'factories')
 # FactoryBot.definition_file_paths << "#{Katello::Engine.root}/test/factories"
 FactoryBot.reload

data/test/unit/services/foreman_rh_cloud/cloud_request_forwarder_test.rb

@@ -42,13 +42,12 @@ class CloudRequestForwarderTest < ActiveSupport::TestCase
   test 'should prepare correct cloud url' do
     paths = {
       "/redhat_access/r/insights/platform/module-update-router/v1/channel?module=insights-core" => "https://cert.cloud.redhat.com/api/module-update-router/v1/channel?module=insights-core",
-      "/redhat_access/r/insights/v1/static/release/insights-core.egg" => "https://cert-api.access.redhat.com/r/insights/v1/static/release/insights-core.egg",
-      "/redhat_access/r/insights/v1/static/uploader.v2.json" => "https://cert-api.access.redhat.com/r/insights/v1/static/uploader.v2.json",
-      "/redhat_access/r/insights/v1/static/uploader.v2.json.asc" => "https://cert-api.access.redhat.com/r/insights/v1/static/uploader.v2.json.asc",
+      "/redhat_access/r/insights/v1/static/release/insights-core.egg" => "https://cloud.redhat.com/api/v1/static/release/insights-core.egg",
+      "/redhat_access/r/insights/v1/static/uploader.v2.json" => "https://cloud.redhat.com/api/v1/static/uploader.v2.json",
+      "/redhat_access/r/insights/v1/static/uploader.v2.json.asc" => "https://cloud.redhat.com/api/v1/static/uploader.v2.json.asc",
       "/redhat_access/r/insights/platform/inventory/v1/hosts" => "https://cert.cloud.redhat.com/api/inventory/v1/hosts",
       "/redhat_access/r/insights/platform/ingress/v1/upload" => "https://cert.cloud.redhat.com/api/ingress/v1/upload",
       "/redhat_access/r/insights/uploads/67200803-132b-474b-a6f9-37be74185df4" => "https://cert-api.access.redhat.com/r/insights/uploads/67200803-132b-474b-a6f9-37be74185df4",
-      "/redhat_access/r/insights/" => "https://cert.cloud.redhat.com/api/apicast-tests/ping",
     }
 
     paths.each do |key, value|

data/test/unit/services/foreman_rh_cloud/template_renderer_helper_test.rb

@@ -8,7 +8,6 @@ class TemplateRendererHelperTest < ActiveSupport::TestCase
     response.stubs(:body).returns('TEST PLAYBOOK')
     ForemanRhCloud::RemediationsRetriever.any_instance.stubs(:query_playbook).returns(response)
     @host1 = FactoryBot.create(:host)
-    FactoryBot.create(:setting, name: 'rh_cloud_token', value: 'MOCK_TOKEN')
   end
 
   test 'Generates a playbook for hit and remediation' do