foreman_remote_execution 9.0.1 → 9.1.0

data/webpack/JobWizard/JobWizard.js

@@ -36,6 +36,7 @@ import { useValidation } from './validation';
 import { useAutoFill } from './autofill';
 import { submit } from './submit';
 import { generateDefaultDescription } from './JobWizardHelpers';
+import { StartsBeforeErrorAlert } from './StartsBeforeErrorAlert';
 import './JobWizard.scss';
 
 export const JobWizard = ({ rerunData }) => {
@@ -185,6 +186,24 @@ export const JobWizard = ({ rerunData }) => {
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [rerunData, jobTemplateID, dispatch]);
 
+  const [isStartsBeforeError, setIsStartsBeforeError] = useState(false);
+  useEffect(() => {
+    const updateStartsBeforeError = () => {
+      setIsStartsBeforeError(
+        scheduleValue.scheduleType === SCHEDULE_TYPES.FUTURE &&
+          new Date().getTime() >= new Date(scheduleValue.startsBefore).getTime()
+      );
+    };
+    let interval;
+    if (scheduleValue.scheduleType === SCHEDULE_TYPES.FUTURE) {
+      updateStartsBeforeError();
+      interval = setInterval(updateStartsBeforeError, 5000);
+    }
+    return () => {
+      interval && clearInterval(interval);
+    };
+  }, [scheduleValue.scheduleType, scheduleValue.startsBefore]);
+
   const [valid, setValid] = useValidation({
     advancedValues,
     templateValues,
@@ -209,6 +228,11 @@ export const JobWizard = ({ rerunData }) => {
     !templateError &&
     !!jobTemplateID &&
     templateResponse.job_template;
+  const areHostsSelected =
+    selectedTargets.hosts.length > 0 ||
+    selectedTargets.hostCollections.length > 0 ||
+    selectedTargets.hostGroups.length > 0 ||
+    hostsSearchQuery.length > 0;
   const steps = [
     {
       name: WIZARD_TITLES.categoryAndTemplate,
@@ -238,7 +262,7 @@ export const JobWizard = ({ rerunData }) => {
         />
       ),
       canJumpTo: isTemplate,
-      enableNext: isTemplate && valid.hostsAndInputs,
+      enableNext: isTemplate && valid.hostsAndInputs && areHostsSelected,
     },
     {
       name: WIZARD_TITLES.advanced,
@@ -254,14 +278,26 @@ export const JobWizard = ({ rerunData }) => {
           templateValues={templateValues}
         />
       ),
-      canJumpTo: isTemplate && valid.hostsAndInputs,
-      enableNext: isTemplate && valid.hostsAndInputs && valid.advanced,
+      canJumpTo: isTemplate && valid.hostsAndInputs && areHostsSelected,
+      enableNext:
+        isTemplate &&
+        valid.hostsAndInputs &&
+        areHostsSelected &&
+        valid.advanced,
     },
     {
       name: WIZARD_TITLES.schedule,
-      canJumpTo: isTemplate && valid.hostsAndInputs && valid.advanced,
+      canJumpTo:
+        isTemplate &&
+        valid.hostsAndInputs &&
+        areHostsSelected &&
+        valid.advanced,
       enableNext:
-        isTemplate && valid.hostsAndInputs && valid.advanced && valid.schedule,
+        isTemplate &&
+        valid.hostsAndInputs &&
+        areHostsSelected &&
+        valid.advanced &&
+        valid.schedule,
       steps: [
         {
           name: WIZARD_TITLES.typeOfExecution,
@@ -278,9 +314,17 @@ export const JobWizard = ({ rerunData }) => {
               }}
             />
           ),
-          canJumpTo: isTemplate && valid.hostsAndInputs && valid.advanced,
+          canJumpTo:
+            isTemplate &&
+            valid.hostsAndInputs &&
+            areHostsSelected &&
+            valid.advanced,
 
-          enableNext: isTemplate && valid.hostsAndInputs && valid.advanced,
+          enableNext:
+            isTemplate &&
+            valid.hostsAndInputs &&
+            areHostsSelected &&
+            valid.advanced,
         },
         ...(scheduleValue.scheduleType === SCHEDULE_TYPES.FUTURE
           ? [
@@ -298,10 +342,15 @@ export const JobWizard = ({ rerunData }) => {
                     }}
                   />
                 ),
-                canJumpTo: isTemplate && valid.hostsAndInputs && valid.advanced,
+                canJumpTo:
+                  isTemplate &&
+                  valid.hostsAndInputs &&
+                  areHostsSelected &&
+                  valid.advanced,
                 enableNext:
                   isTemplate &&
                   valid.hostsAndInputs &&
+                  areHostsSelected &&
                   valid.advanced &&
                   valid.schedule,
               },
@@ -323,10 +372,15 @@ export const JobWizard = ({ rerunData }) => {
                     }}
                   />
                 ),
-                canJumpTo: isTemplate && valid.hostsAndInputs && valid.advanced,
+                canJumpTo:
+                  isTemplate &&
+                  valid.hostsAndInputs &&
+                  areHostsSelected &&
+                  valid.advanced,
                 enableNext:
                   isTemplate &&
                   valid.hostsAndInputs &&
+                  areHostsSelected &&
                   valid.advanced &&
                   valid.schedule,
               },
@@ -349,39 +403,50 @@ export const JobWizard = ({ rerunData }) => {
       ),
       nextButtonText: 'Run',
       canJumpTo:
-        isTemplate && valid.hostsAndInputs && valid.advanced && valid.schedule,
+        isTemplate &&
+        valid.advanced &&
+        valid.hostsAndInputs &&
+        areHostsSelected &&
+        valid.schedule,
       enableNext:
         isTemplate &&
         valid.hostsAndInputs &&
+        areHostsSelected &&
         valid.advanced &&
         valid.schedule &&
-        !isSubmitting,
+        !isSubmitting &&
+        !isStartsBeforeError,
     },
   ];
   const location = useForemanLocation();
   const organization = useForemanOrganization();
   return (
-    <Wizard
-      onClose={() => history.goBack()}
-      navAriaLabel="Run Job steps"
-      steps={steps}
-      height="100%"
-      className="job-wizard"
-      onSave={() => {
-        submit({
-          jobTemplateID,
-          templateValues,
-          advancedValues,
-          scheduleValue,
-          dispatch,
-          selectedTargets,
-          hostsSearchQuery,
-          location,
-          organization,
-          feature: routerSearch?.feature,
-        });
-      }}
-    />
+    <>
+      {isStartsBeforeError && <StartsBeforeErrorAlert />}
+      <Wizard
+        onClose={() => history.goBack()}
+        navAriaLabel="Run Job steps"
+        steps={steps}
+        height="100%"
+        className="job-wizard"
+        onSave={() => {
+          submit({
+            jobTemplateID,
+            templateValues,
+            advancedValues,
+            scheduleValue,
+            dispatch,
+            selectedTargets,
+            hostsSearchQuery,
+            location,
+            organization,
+            feature: routerSearch?.feature,
+            provider: templateResponse.provider_name,
+            advancedInputs: templateResponse.advanced_template_inputs,
+          });
+        }}
+      />
+    </>
   );
 };
 

data/webpack/JobWizard/StartsBeforeErrorAlert.js

@@ -0,0 +1,17 @@
+import React from 'react';
+import { Divider, Alert } from '@patternfly/react-core';
+import { translate as __ } from 'foremanReact/common/I18n';
+
+export const StartsBeforeErrorAlert = () => (
+  <>
+    <Alert
+      variant="danger"
+      title={__("'Starts before' date must in the future")}
+    >
+      {__(
+        'Please go back to "Schedule" - "Future execution" step to fix the error'
+      )}
+    </Alert>
+    <Divider component="div" />
+  </>
+);

data/webpack/JobWizard/__tests__/__snapshots__/integration.test.js.snap

@@ -7,6 +7,14 @@ Array [
     "type": "get",
     "url": "/ui_job_wizard/categories",
   },
+  Object {
+    "key": "HOST_IDS",
+    "params": Object {
+      "search": "id = 105 or id = 37",
+    },
+    "type": "get",
+    "url": "/api/hosts",
+  },
   Object {
     "key": "JOB_TEMPLATES",
     "type": "get",

data/webpack/JobWizard/__tests__/fixtures.js

@@ -161,6 +161,11 @@ export const testSetup = (selectors, api) => {
         ],
       },
     },
+    HOSTS_API: {
+      response: {
+        subtotal: 3,
+      },
+    },
   });
   return store;
 };

data/webpack/JobWizard/__tests__/integration.test.js

@@ -18,6 +18,15 @@ import {
 const store = testSetup(selectors, api);
 
 describe('Job wizard fill', () => {
+  beforeEach(() => {
+    jest.spyOn(selectors, 'selectRouterSearch');
+    selectors.selectRouterSearch.mockImplementation(() => ({
+      'host_ids[]': ['105', '37'],
+    }));
+  });
+  afterEach(() => {
+    selectors.selectRouterSearch.mockRestore();
+  });
   it('should select template', async () => {
     api.get.mockImplementation(({ handleSuccess, ...action }) => {
       if (action.key === 'JOB_CATEGORIES') {
@@ -33,7 +42,13 @@ describe('Job wizard fill', () => {
           handleSuccess({
             data: jobTemplate,
           });
+      } else if (action.key === 'HOST_IDS') {
+        handleSuccess &&
+          handleSuccess({
+            data: { results: [{ name: 'host1' }, { name: 'host3' }] },
+          });
       }
+
       return { type: 'get', ...action };
     });
     selectors.selectJobTemplate.mockRestore();

data/webpack/JobWizard/__tests__/validation.test.js

@@ -41,11 +41,26 @@ describe('Job wizard validation', () => {
     expect(screen.getByText(WIZARD_TITLES.review)).toBeDisabled();
     await act(async () => {
       fireEvent.click(screen.getByText(WIZARD_TITLES.hostsAndInputs));
+      await new Promise(resolve => setTimeout(resolve, 0)); // to resolve gql
     });
+    const select = name =>
+      screen.getByRole('button', { name: `${name} toggle` });
+    fireEvent.click(select('hosts'));
+    await act(async () => {
+      fireEvent.click(screen.getByText('host1'));
+    });
+
+    expect(screen.getByText(WIZARD_TITLES.advanced)).toBeDisabled();
+    expect(screen.getByText(WIZARD_TITLES.schedule)).toBeDisabled();
+    expect(screen.getByText(WIZARD_TITLES.review)).toBeDisabled();
     const textField = screen.getByLabelText('plain hidden', {
       selector: 'textarea',
     });
     await act(async () => {
+      fireEvent.click(
+        // Close the select
+        select('hosts')
+      );
       await fireEvent.change(textField, {
         target: { value: 'text' },
       });
@@ -85,8 +100,20 @@ describe('Job wizard validation', () => {
     // setup
     await act(async () => {
       fireEvent.click(screen.getByText(WIZARD_TITLES.hostsAndInputs));
+      await new Promise(resolve => setTimeout(resolve, 0)); // to resolve gql
     });
+
+    const select = name =>
+      screen.getByRole('button', { name: `${name} toggle` });
+    fireEvent.click(select('hosts'));
     await act(async () => {
+      fireEvent.click(screen.getByText('host1'));
+    });
+    await act(async () => {
+      fireEvent.click(
+        // Close the host select
+        select('hosts')
+      );
       await fireEvent.change(
         screen.getByLabelText('plain hidden', {
           selector: 'textarea',

data/webpack/JobWizard/autofill.js

@@ -72,6 +72,7 @@ export const useAutoFill = ({
           if (input) {
             if (typeof rest[key] === 'string') {
               setTemplateValues(prev => ({ ...prev, [input]: rest[key] }));
+              setAdvancedValues(prev => ({ ...prev, [input]: rest[key] }));
             } else {
               const { value, advanced } = rest[key];
               if (advanced) {

data/webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js

@@ -26,6 +26,15 @@ mockApi(api);
 jest.useFakeTimers();
 
 describe('AdvancedFields', () => {
+  beforeEach(() => {
+    jest.spyOn(selectors, 'selectRouterSearch');
+    selectors.selectRouterSearch.mockImplementation(() => ({
+      'host_ids[]': ['105', '37'],
+    }));
+  });
+  afterEach(() => {
+    selectors.selectRouterSearch.mockRestore();
+  });
   it('should save data between steps for advanced fields', async () => {
     const wrapper = mount(
       <MockedProvider mocks={gqlMock} addTypename={false}>
@@ -51,7 +60,7 @@ describe('AdvancedFields', () => {
       .simulate('click'); // Advanced step
 
     await act(async () => {
-      jest.runAllTimers(); // to handle pf4 date picker popover
+      jest.advanceTimersByTime(1000); // to handle pf4 date picker popover
     });
     const effectiveUserInput = () => wrapper.find('input#effective-user');
     const advancedTemplateInput = () =>
@@ -83,7 +92,7 @@ describe('AdvancedFields', () => {
       .simulate('click'); // Advanced step
 
     await act(async () => {
-      jest.runOnlyPendingTimers(); // to handle pf4 date picker popover
+      jest.advanceTimersByTime(1000); // to handle pf4 date picker popover
     });
     expect(effectiveUserInput().prop('value')).toEqual(effectiveUesrValue);
     expect(advancedTemplateInput().prop('value')).toEqual(
@@ -100,7 +109,7 @@ describe('AdvancedFields', () => {
     );
     await act(async () => {
       fireEvent.click(screen.getByText(WIZARD_TITLES.advanced));
-      jest.runOnlyPendingTimers(); // to handle pf4 date picker popover
+      jest.advanceTimersByTime(1000); // to handle pf4 date picker popover
     });
 
     const searchValue = 'search test';
@@ -137,7 +146,7 @@ describe('AdvancedFields', () => {
       fireEvent.change(timeField, {
         target: { value: timeValue },
       });
-      jest.runAllTimers(); // to handle pf4 date picker popover
+      jest.advanceTimersByTime(1000); // to handle pf4 date picker popover
     });
     expect(
       screen.getByLabelText('adv plain hidden', {
@@ -156,7 +165,7 @@ describe('AdvancedFields', () => {
 
     await act(async () => {
       await fireEvent.click(screen.getByText(WIZARD_TITLES.advanced));
-      jest.runOnlyPendingTimers();
+      jest.advanceTimersByTime(1000);
     });
     expect(textField.value).toBe(textValue);
     expect(searchField.value).toBe(searchValue);
@@ -177,7 +186,7 @@ describe('AdvancedFields', () => {
     );
     await act(async () => {
       fireEvent.click(screen.getByText(WIZARD_TITLES.advanced));
-      jest.runAllTimers(); // to handle pf4 date picker popover
+      jest.advanceTimersByTime(1000); // to handle pf4 date picker popover
     });
 
     expect(
@@ -212,7 +221,7 @@ describe('AdvancedFields', () => {
     );
     await act(async () => {
       fireEvent.click(screen.getByText(WIZARD_TITLES.advanced));
-      jest.runAllTimers(); // to handle pf4 date picker popover
+      jest.advanceTimersByTime(1000); // to handle pf4 date picker popover
     });
 
     const textField = screen.getByLabelText('adv plain hidden', {
@@ -270,6 +279,11 @@ describe('AdvancedFields', () => {
           handleSuccess({
             data: { results: [jobTemplate] },
           });
+      } else if (action.key === 'HOST_IDS') {
+        handleSuccess &&
+          handleSuccess({
+            data: { results: [{ name: 'host1' }, { name: 'host3' }] },
+          });
       }
       return { type: 'get', ...action };
     });
@@ -280,7 +294,7 @@ describe('AdvancedFields', () => {
     );
     await act(async () => {
       fireEvent.click(screen.getByText(WIZARD_TITLES.advanced));
-      jest.runAllTimers(); // to handle pf4 date picker popover
+      jest.advanceTimersByTime(1000); // to handle pf4 date picker popover
     });
     expect(
       screen.getByLabelText('description preview', {
@@ -339,6 +353,11 @@ describe('AdvancedFields', () => {
           handleSuccess({
             data: { results: [jobTemplate] },
           });
+      } else if (action.key === 'HOST_IDS') {
+        handleSuccess &&
+          handleSuccess({
+            data: { results: [{ name: 'host1' }, { name: 'host3' }] },
+          });
       }
       return { type: 'get', ...action };
     });
@@ -349,7 +368,7 @@ describe('AdvancedFields', () => {
     );
     await act(async () => {
       fireEvent.click(screen.getByText(WIZARD_TITLES.advanced));
-      jest.runAllTimers(); // to handle pf4 date picker popover
+      jest.advanceTimersByTime(1000); // to handle pf4 date picker popover
     });
     expect(
       screen.getByLabelText('description preview', {
@@ -369,7 +388,7 @@ describe('AdvancedFields', () => {
     );
     await act(async () => {
       fireEvent.click(screen.getByText(WIZARD_TITLES.advanced));
-      jest.runAllTimers(); // to handle pf4 date picker popover
+      jest.advanceTimersByTime(1000); // to handle pf4 date picker popover
     });
     const resourceSelectField = screen.getByLabelText(
       'adv resource select typeahead input'

data/webpack/JobWizard/steps/AdvancedFields/__tests__/__snapshots__/AdvancedFields.test.js.snap

@@ -7,6 +7,14 @@ Array [
     "type": "get",
     "url": "/ui_job_wizard/categories",
   },
+  Object {
+    "key": "HOST_IDS",
+    "params": Object {
+      "search": "id = 105 or id = 37",
+    },
+    "type": "get",
+    "url": "/api/hosts",
+  },
   Object {
     "key": "JOB_TEMPLATES",
     "type": "get",

data/webpack/JobWizard/steps/HostsAndInputs/HostPreviewModal.js

@@ -60,3 +60,6 @@ HostPreviewModal.propTypes = {
   setIsOpen: PropTypes.func.isRequired,
   searchQuery: PropTypes.string.isRequired,
 };
+HostPreviewModal.defaultPropTypes = {
+  searchQuery: '',
+};

data/webpack/JobWizard/steps/HostsAndInputs/__tests__/HostsAndInputs.test.js

@@ -30,6 +30,27 @@ describe('Hosts', () => {
     const select = name =>
       screen.getByRole('button', { name: `${name} toggle` });
     fireEvent.click(select('hosts'));
+    await act(async () => {
+      fireEvent.click(screen.getByText('host1'));
+      fireEvent.click(select('hosts'));
+    });
+    expect(
+      screen.queryAllByText('Please select at least one host')
+    ).toHaveLength(0);
+    await act(async () => {
+      fireEvent.click(select('hosts'));
+    });
+    await act(async () => {
+      fireEvent.click(
+        screen.getByText('host1', {
+          selector: '.pf-c-select__menu-item',
+        })
+      );
+      fireEvent.blur(select('hosts'));
+    });
+    expect(
+      screen.queryAllByText('Please select at least one host')
+    ).toHaveLength(1);
     await act(async () => {
       fireEvent.click(screen.getByText('host1'));
       fireEvent.click(screen.getByText('host2'));
@@ -107,6 +128,13 @@ describe('Hosts', () => {
     expect(screen.queryAllByText('Host groups')).toHaveLength(1);
     expect(screen.queryAllByText('Search query')).toHaveLength(1);
     expect(screen.queryAllByText('Host collections')).toHaveLength(0);
+
+    await act(async () => {
+      fireEvent.click(
+        // Close the select
+        screen.getByText('Hosts', { selector: '.pf-c-select__toggle-text' })
+      );
+    });
   });
   it('Host fill list from url', async () => {
     routerSelectors.selectRouterLocation.mockImplementation(() => ({
@@ -151,8 +179,9 @@ describe('Hosts', () => {
 
   it('input fill from url', async () => {
     const inputText = 'test text';
+    const advancedInputText = 'test adv text';
     routerSelectors.selectRouterLocation.mockImplementation(() => ({
-      search: `feature=test_feature&inputs[plain hidden]=${inputText}`,
+      search: `host_ids%5B%5D=host1&host_ids%5B%5D=host3&feature=test_feature&inputs[plain hidden]=${inputText}&inputs[adv plain hidden]=${advancedInputText}`,
     }));
     render(
       <MockedProvider mocks={gqlMock} addTypename={false}>
@@ -175,5 +204,13 @@ describe('Hosts', () => {
       selector: 'textarea',
     });
     expect(textField.value).toBe(inputText);
+
+    await act(async () => {
+      fireEvent.click(screen.getByText('Advanced fields'));
+    });
+    const advancedTextField = screen.getByLabelText('adv plain hidden', {
+      selector: 'textarea',
+    });
+    expect(advancedTextField.value).toBe(advancedInputText);
   });
 });

data/webpack/JobWizard/steps/HostsAndInputs/buildHostQuery.js

@@ -1,18 +1,24 @@
 export const buildHostQuery = (selected, search) => {
   const { hosts, hostCollections, hostGroups } = selected;
-  const hostsSearch = `(id ^ (${hosts.map(({ id }) => id).join(',')}))`;
-  const hostCollectionsSearch = `(host_collection_id ^ (${hostCollections
+  const hostsSearch = `id ^ (${hosts.map(({ id }) => id).join(',')})`;
+  const hostCollectionsSearch = `host_collection_id ^ (${hostCollections
     .map(({ id }) => id)
-    .join(',')}))`;
-  const hostGroupsSearch = `(hostgroup_id ^ (${hostGroups
+    .join(',')})`;
+  const hostGroupsSearch = `hostgroup_id ^ (${hostGroups
     .map(({ id }) => id)
-    .join(',')}))`;
-  return [
+    .join(',')})`;
+  const queryParts = [
     hosts.length ? hostsSearch : false,
     hostCollections.length ? hostCollectionsSearch : false,
     hostGroups.length ? hostGroupsSearch : false,
-    search.length ? `(${search})` : false,
-  ]
-    .filter(Boolean)
-    .join(' or ');
+    search.length ? search : false,
+  ].filter(Boolean);
+
+  if (queryParts.length === 0) {
+    return 'name=a AND name=b';
+  }
+  if (queryParts.length === 1) {
+    return queryParts[0] || 'name=a AND name=b';
+  }
+  return queryParts.map(p => `(${p})`).join(' or ') || 'name=a AND name=b';
 };

data/webpack/JobWizard/steps/HostsAndInputs/index.js

@@ -51,6 +51,30 @@ const HostsAndInputs = ({
   const isLoading = useSelector(selectIsLoadingHosts);
   const templateInputs = useSelector(selectTemplateInputs);
   const [hostPreviewOpen, setHostPreviewOpen] = useState(false);
+  const [wasFocus, setWasFocus] = useState(false);
+  const [isError, setIsError] = useState(false);
+  useEffect(() => {
+    if (wasFocus) {
+      if (
+        selected.hosts.length === 0 &&
+        selected.hostCollections.length === 0 &&
+        selected.hostGroups.length === 0 &&
+        hostsSearchQuery.length === 0
+      ) {
+        setIsError(true);
+      } else {
+        setIsError(false);
+      }
+    }
+  }, [
+    hostMethod,
+    hostsSearchQuery.length,
+    selected,
+    selected.hostCollections.length,
+    selected.hostGroups.length,
+    selected.hosts.length,
+    wasFocus,
+  ]);
   useEffect(() => {
     debounce(() => {
       dispatch(
@@ -99,6 +123,9 @@ const HostsAndInputs = ({
   const clearSearch = () => {
     setHostsSearchQuery('');
   };
+  const [errorText, setErrorText] = useState(
+    __('Please select at least one host')
+  );
   return (
     <div className="target-hosts-and-inputs">
       <WizardTitle title={WIZARD_TITLES.hostsAndInputs} />
@@ -110,8 +137,13 @@ const HostsAndInputs = ({
         />
       )}
       <Form>
-        <FormGroup fieldId="host_selection" id="host-selection">
-          <InputGroup>
+        <FormGroup
+          fieldId="host_selection"
+          id="host-selection"
+          helperTextInvalid={errorText}
+          validated={isError ? 'error' : 'default'}
+        >
+          <InputGroup onBlur={() => setWasFocus(true)}>
             <SelectField
               isRequired
               className="target-method-select"
@@ -123,7 +155,23 @@ const HostsAndInputs = ({
                 }
                 return true;
               })}
-              setValue={setHostMethod}
+              setValue={val => {
+                setHostMethod(val);
+                if (val === hostMethods.searchQuery) {
+                  setErrorText(__('Please enter a search query'));
+                }
+                if (val === hostMethods.hosts) {
+                  setErrorText(__('Please select at least one host'));
+                }
+                if (val === hostMethods.hostCollections) {
+                  setErrorText(
+                    __('Please select at least one host collection')
+                  );
+                }
+                if (val === hostMethods.hostGroups) {
+                  setErrorText(__('Please select at least one host group'));
+                }
+              }}
               value={hostMethod}
             />
             {hostMethod === hostMethods.searchQuery && (