foreman_remote_execution 17.0.0 → 17.2.0

data/webpack/JobInvocationDetail/TemplateInvocationComponents/index.scss

@@ -1,5 +1,4 @@
 .jobs-table-action-item a {
-
     color: inherit;
     text-decoration: none;
 

data/webpack/JobInvocationDetail/__tests__/JobInvocationHostTablePolling.test.js

@@ -311,6 +311,39 @@ describe('JobInvocationHostTable polling', () => {
     expect(hostsCalls.length).toBeGreaterThan(callsAfterFilterChange);
   });
 
+  it('sends include_permissions only on the first request', () => {
+    renderTable();
+
+    expect(hostsCalls).toHaveLength(1);
+    expect(hostsCalls[0].params.include_permissions).toBe(true);
+
+    act(() => {
+      flushPendingCallbacks();
+    });
+
+    act(() => {
+      jest.advanceTimersByTime(5000);
+    });
+
+    act(() => {
+      flushPendingCallbacks();
+    });
+
+    expect(hostsCalls).toHaveLength(2);
+    expect(hostsCalls[1].params.include_permissions).toBeUndefined();
+
+    act(() => {
+      jest.advanceTimersByTime(5000);
+    });
+
+    act(() => {
+      flushPendingCallbacks();
+    });
+
+    expect(hostsCalls).toHaveLength(3);
+    expect(hostsCalls[2].params.include_permissions).toBeUndefined();
+  });
+
   it('stops polling on API error', () => {
     apiGetSpy.mockRestore();
     setupErrorMock();

data/webpack/JobInvocationDetail/__tests__/JobInvocationPolling.test.js

@@ -5,7 +5,10 @@ import {
   getJobInvocation,
   stopJobInvocationPolling,
 } from '../JobInvocationActions';
-import { JOB_INVOCATION_KEY } from '../JobInvocationConstants';
+import {
+  JOB_INVOCATION_KEY,
+  AUTO_REFRESH_INTERVAL_MS,
+} from '../JobInvocationConstants';
 
 jest.useFakeTimers();
 
@@ -66,22 +69,24 @@ describe('job invocation polling', () => {
     store.dispatch(getJobInvocation(url, ref));
     expect(apiGetSpy).toHaveBeenCalledTimes(1);
 
-    jest.advanceTimersByTime(5000);
+    jest.advanceTimersByTime(AUTO_REFRESH_INTERVAL_MS);
     expect(apiGetSpy).toHaveBeenCalledTimes(2);
   });
 
-  it('includes include_permissions=true in every poll call', () => {
+  it('does not include include_permissions on subsequent poll calls', () => {
     setupGetMock(runningData);
     const store = makeStore();
 
     store.dispatch(getJobInvocation(url, ref));
-    jest.advanceTimersByTime(5000);
+    jest.advanceTimersByTime(AUTO_REFRESH_INTERVAL_MS);
 
     expect(apiGetSpy).toHaveBeenCalledTimes(2);
     expect(apiGetSpy.mock.calls[1][0].params).toMatchObject({
       include_hosts: false,
-      include_permissions: true,
     });
+    expect(apiGetSpy.mock.calls[1][0].params).not.toHaveProperty(
+      'include_permissions'
+    );
   });
 
   it('stops polling when job succeeds', () => {
@@ -91,7 +96,7 @@ describe('job invocation polling', () => {
     store.dispatch(getJobInvocation(url, ref));
     expect(apiGetSpy).toHaveBeenCalledTimes(1);
 
-    jest.advanceTimersByTime(5000);
+    jest.advanceTimersByTime(AUTO_REFRESH_INTERVAL_MS);
     expect(apiGetSpy).toHaveBeenCalledTimes(1);
   });
 
@@ -100,7 +105,7 @@ describe('job invocation polling', () => {
     const store = makeStore();
 
     store.dispatch(getJobInvocation(url, ref));
-    jest.advanceTimersByTime(5000);
+    jest.advanceTimersByTime(AUTO_REFRESH_INTERVAL_MS);
 
     expect(apiGetSpy).toHaveBeenCalledTimes(1);
   });
@@ -110,7 +115,7 @@ describe('job invocation polling', () => {
     const store = makeStore();
 
     store.dispatch(getJobInvocation(url, ref));
-    jest.advanceTimersByTime(5000);
+    jest.advanceTimersByTime(AUTO_REFRESH_INTERVAL_MS);
 
     expect(apiGetSpy).toHaveBeenCalledTimes(1);
   });
@@ -125,7 +130,7 @@ describe('job invocation polling', () => {
     const store = makeStore();
 
     store.dispatch(getJobInvocation(url, ref));
-    jest.advanceTimersByTime(5000);
+    jest.advanceTimersByTime(AUTO_REFRESH_INTERVAL_MS);
 
     expect(apiGetSpy).toHaveBeenCalledTimes(1);
   });
@@ -138,7 +143,7 @@ describe('job invocation polling', () => {
     expect(apiGetSpy).toHaveBeenCalledTimes(1);
 
     stopJobInvocationPolling(ref);
-    jest.advanceTimersByTime(5000);
+    jest.advanceTimersByTime(AUTO_REFRESH_INTERVAL_MS);
 
     expect(apiGetSpy).toHaveBeenCalledTimes(1);
   });
@@ -154,7 +159,7 @@ describe('job invocation polling', () => {
     store.dispatch(getJobInvocation(url, ref));
     expect(apiGetSpy).toHaveBeenCalledTimes(2);
 
-    jest.advanceTimersByTime(5000);
+    jest.advanceTimersByTime(AUTO_REFRESH_INTERVAL_MS);
 
     // Only the second poll chain fires (first was cancelled)
     expect(apiGetSpy).toHaveBeenCalledTimes(3);
@@ -165,7 +170,7 @@ describe('job invocation polling', () => {
     const store = makeStore();
 
     store.dispatch(getJobInvocation(url, ref));
-    jest.advanceTimersByTime(15000);
+    jest.advanceTimersByTime(AUTO_REFRESH_INTERVAL_MS * 3);
 
     expect(apiGetSpy).toHaveBeenCalledTimes(4);
   });

data/webpack/JobInvocationDetail/index.js

@@ -54,6 +54,11 @@ const JobInvocationDetailPage = ({
   } = items;
   const finished = isJobFinished(statusLabel);
   const pollTimeoutRef = useRef({ timeoutId: null, cancel: () => {} });
+  const permissionsRef = useRef(null);
+  if (items.permissions && !permissionsRef.current) {
+    permissionsRef.current = items.permissions;
+  }
+  const permissions = items.permissions || permissionsRef.current;
   const jobInvocationApiStatus = useSelector(state =>
     selectAPIStatus(state, JOB_INVOCATION_KEY)
   );
@@ -87,6 +92,11 @@ const JobInvocationDetailPage = ({
     };
   }, [dispatch, id]);
 
+  const dataWithPermissions = useMemo(() => ({ ...items, permissions }), [
+    items,
+    permissions,
+  ]);
+
   const apiFailed = jobInvocationApiStatus === API_STATUS.ERROR;
 
   const backendErrorMessage = useMemo(() => {
@@ -143,7 +153,10 @@ const JobInvocationDetailPage = ({
         breadcrumbOptions={breadcrumbOptions}
         toolbarButtons={
           items.id !== undefined && (
-            <JobInvocationToolbarButtons jobId={id} data={items} />
+            <JobInvocationToolbarButtons
+              jobId={id}
+              data={dataWithPermissions}
+            />
           )
         }
         searchable={false}

data/webpack/JobWizard/JobWizard.js

@@ -18,6 +18,7 @@ import {
   WIZARD_TITLES,
   SCHEDULE_TYPES,
   initialScheduleState,
+  STARTS_ERROR_CHECK_INTERVAL_MS,
 } from './JobWizardConstants';
 import {
   selectTemplateError,
@@ -237,7 +238,10 @@ export const JobWizard = ({ rerunData }) => {
       }
     };
     updateStartsError();
-    const interval = setInterval(updateStartsError, 5000);
+    const interval = setInterval(
+      updateStartsError,
+      STARTS_ERROR_CHECK_INTERVAL_MS
+    );
 
     return () => {
       interval && clearInterval(interval);

data/webpack/JobWizard/JobWizard.scss

@@ -1,5 +1,6 @@
 .job-wizard {
   font-size: var(--pf-v5-global--FontSize--md);
+
   .wizard-title {
     margin-bottom: 25px;
   }
@@ -15,6 +16,7 @@
       var(--pf-v5-cwizard__toggle--ZIndex) + 1
     ); // So the select box can be shown above the wizard footer and navigation toggle
   }
+
   .pf-v5-c-wizard__main-body {
     @media (max-width: 600px) {
       max-width: 100%;
@@ -41,6 +43,7 @@
     .pf-v5-c-chip-group.pf-m-category {
       margin-bottom: 10px;
     }
+
     .pf-v5-c-select__toggle-typeahead {
       border: 0px;
     }
@@ -50,62 +53,76 @@
         flex-wrap: nowrap;
       }
     }
+
     .foreman-search-field {
       width: 100%;
     }
   }
+
   input[type='radio'],
   input[type='checkbox'] {
     margin: 0;
   }
+
   .schedule-tab {
     #repeat-on-weekly {
       display: grid;
       grid-template-columns: repeat(7, 1fr);
     }
+
     .pf-v5-l-grid {
       gap: var(--pf-v5-cform--GridGap);
     }
+
     #repeat-on-hourly {
       max-height: 300px;
       overflow: scroll;
     }
+
     .schedule-radio label {
       width: 100%;
     }
+
     .schedule-radio input {
       align-self: center;
     }
+
     .schedule-radio-repeat-text {
       width: 100px;
       display: inline-block;
       margin-right: 5px;
       align-self: center;
     }
+
     .schedule-radio-title {
       width: 80px;
       display: inline-block;
       align-self: center;
     }
+
     .schedule-radio-occurences {
       display: inline-block;
       align-self: center;
     }
+
     .schedule-radio-wrapper {
       display: flex;
     }
   }
+
   .future-schedule-tab {
     .clear-datetime-button {
       margin-left: 10px;
       align-self: center;
       font-size: var(--pf-v5-global--FontSize--md);
     }
+
     .pf-v5-c-form__group-control {
       display: flex;
       flex-wrap: wrap;
     }
   }
+
   .pf-v5-c-date-picker {
     vertical-align: top;
   }
@@ -119,10 +136,12 @@
     // overwriting bootstrap/_forms.scss margin: 4px 0 0;
     margin: 0;
   }
+
   textarea {
     min-height: 40px;
     min-width: 100px;
   }
+
   .pf-v5-c-modal-box {
     width: auto;
   }
@@ -132,9 +151,11 @@
       margin-left: 10px;
     }
   }
+
   .pf-v5-c-radio__body {
     font-size: var(--pf-v5-cradio__label--FontSize);
   }
+
   .reset-default {
     padding-bottom: 0;
   }

data/webpack/JobWizard/JobWizardConstants.js

@@ -1,6 +1,9 @@
 import { translate as __ } from 'foremanReact/common/I18n';
 import { foremanUrl } from 'foremanReact/common/helpers';
-import { getControllerSearchProps } from 'foremanReact/constants';
+import {
+  getControllerSearchProps,
+  MS_PER_SECOND,
+} from 'foremanReact/constants';
 
 export const JOB_TEMPLATES = 'JOB_TEMPLATES';
 export const JOB_CATEGORIES = 'JOB_CATEGORIES';
@@ -78,3 +81,9 @@ export const HOST_IDS = 'HOST_IDS';
 export const REX_FEATURE = 'REX_FEATURE';
 
 export const JOB_API_KEY = 'JOB_API_KEY';
+
+export const SUNDAY_BASE_YEAR = 2017;
+export const DEFAULT_MINUTE_OPTIONS = [0, 15, 30, 45];
+export const STARTS_ERROR_CHECK_INTERVAL_MS = 5000;
+export const DATE_PADDING_SLICE = -2;
+export const DEBOUNCE_INPUT_MS = MS_PER_SECOND;

data/webpack/JobWizard/steps/Schedule/RepeatHour.js

@@ -12,13 +12,15 @@ import {
   SelectVariant,
 } from '@patternfly/react-core/deprecated';
 import { translate as __ } from 'foremanReact/common/I18n';
+import { MINUTES_PER_HOUR } from 'foremanReact/constants';
 import { helpLabel } from '../form/FormHelpers';
+import { DEFAULT_MINUTE_OPTIONS } from '../../JobWizardConstants';
 
 export const RepeatHour = ({ repeatData, setRepeatData }) => {
   const isValidMinute = newMinute =>
     Number.isInteger(parseInt(newMinute, 10)) &&
     newMinute >= 0 &&
-    newMinute < 60;
+    newMinute < MINUTES_PER_HOUR;
 
   const { minute } = repeatData;
   useEffect(() => {
@@ -27,7 +29,7 @@ export const RepeatHour = ({ repeatData, setRepeatData }) => {
     }
   }, [minute, setRepeatData]);
   const [minuteOpen, setMinuteOpen] = useState(false);
-  const [options, setOptions] = useState([0, 15, 30, 45]);
+  const [options, setOptions] = useState(DEFAULT_MINUTE_OPTIONS);
   const [isAlertOpen, setIsAlertOpen] = useState(false);
   return (
     <FormGroup

data/webpack/JobWizard/steps/Schedule/RepeatWeek.js

@@ -2,15 +2,17 @@ import React, { useEffect } from 'react';
 import PropTypes from 'prop-types';
 import { FormGroup, Checkbox } from '@patternfly/react-core';
 import { translate as __, documentLocale } from 'foremanReact/common/I18n';
+import { DAYS_PER_WEEK } from 'foremanReact/constants';
 import { RepeatDaily } from './RepeatDaily';
 import { noop } from '../../../helpers';
+import { SUNDAY_BASE_YEAR } from '../../JobWizardConstants';
 
 export const getWeekDays = () => {
   const locale = documentLocale().replace(/-/g, '_');
-  const baseDate = new Date(Date.UTC(2017, 0, 1)); // just a Sunday
+  const baseDate = new Date(Date.UTC(SUNDAY_BASE_YEAR, 0, 1)); // just a Sunday
   const weekDays = [];
   const formatOptions = { weekday: 'short', timeZone: 'UTC' };
-  for (let i = 0; i < 7; i++) {
+  for (let i = 0; i < DAYS_PER_WEEK; i++) {
     try {
       weekDays.push(baseDate.toLocaleDateString(locale, formatOptions));
     } catch {

data/webpack/JobWizard/steps/Schedule/ScheduleRecurring.js

@@ -12,6 +12,7 @@ import {
 } from '@patternfly/react-core';
 import { ExclamationCircleIcon } from '@patternfly/react-icons';
 import { translate as __ } from 'foremanReact/common/I18n';
+import { MS_PER_MINUTE } from 'foremanReact/constants';
 import { RepeatOn } from './RepeatOn';
 import { SCHEDULE_TYPES } from '../../JobWizardConstants';
 import { PurposeField } from './PurposeField';
@@ -114,7 +115,7 @@ export const ScheduleRecurring = ({
                   setScheduleValue(current => ({
                     ...current,
                     startsAt: new Date(
-                      new Date().getTime() + 60000
+                      new Date().getTime() + MS_PER_MINUTE
                     ).toISOString(), // 1 minute in the future
                     isFuture: true,
                   }))

data/webpack/JobWizard/steps/Schedule/ScheduleType.js

@@ -2,6 +2,7 @@ import React from 'react';
 import PropTypes from 'prop-types';
 import { Form, FormGroup, Radio, Divider } from '@patternfly/react-core';
 import { translate as __ } from 'foremanReact/common/I18n';
+import { MS_PER_MINUTE } from 'foremanReact/constants';
 import {
   WIZARD_TITLES,
   SCHEDULE_TYPES,
@@ -49,7 +50,9 @@ export const ScheduleType = ({
           onChange={() => {
             setScheduleValue(current => ({
               ...current,
-              startsAt: new Date(new Date().getTime() + 60000).toISOString(), // 1 minute in the future
+              startsAt: new Date(
+                new Date().getTime() + MS_PER_MINUTE
+              ).toISOString(), // 1 minute in the future
               scheduleType: SCHEDULE_TYPES.FUTURE,
               repeatType: repeatTypes.noRepeat,
             }));

data/webpack/JobWizard/steps/form/DateTimePicker.js

@@ -7,13 +7,19 @@ import {
 } from '@patternfly/react-core';
 import { debounce } from 'lodash';
 import { translate as __, documentLocale } from 'foremanReact/common/I18n';
+import {
+  DATE_PADDING_SLICE,
+  DEBOUNCE_INPUT_MS,
+} from '../../JobWizardConstants';
 
 const formatDateTime = d =>
   `${d.getFullYear()}-${`0${d.getMonth() + 1}`.slice(
-    -2
-  )}-${`0${d.getDate()}`.slice(-2)} ${`0${d.getHours()}`.slice(
-    -2
-  )}:${`0${d.getMinutes()}`.slice(-2)}:${`0${d.getSeconds()}`.slice(-2)}`;
+    DATE_PADDING_SLICE
+  )}-${`0${d.getDate()}`.slice(DATE_PADDING_SLICE)} ${`0${d.getHours()}`.slice(
+    DATE_PADDING_SLICE
+  )}:${`0${d.getMinutes()}`.slice(
+    DATE_PADDING_SLICE
+  )}:${`0${d.getSeconds()}`.slice(DATE_PADDING_SLICE)}`;
 
 export const DateTimePicker = ({
   dateTime,
@@ -103,7 +109,7 @@ export const DateTimePicker = ({
         aria-label={`${ariaLabel} datepicker`}
         value={formattedDate}
         placeholder="yyyy/mm/dd"
-        onChange={debounce(onDateChange, 1000, {
+        onChange={debounce(onDateChange, DEBOUNCE_INPUT_MS, {
           leading: false,
           trailing: true,
         })}
@@ -123,7 +129,7 @@ export const DateTimePicker = ({
         time={dateTime ? dateObject.toString() : ''}
         inputProps={dateTime ? {} : { value: '' }}
         placeholder={includeSeconds ? 'hh:mm:ss' : 'hh:mm'}
-        onChange={debounce(onTimeChange, 1000, {
+        onChange={debounce(onTimeChange, DEBOUNCE_INPUT_MS, {
           leading: false,
           trailing: true,
         })}

data/webpack/JobWizard/steps/form/FormHelpers.js

@@ -8,16 +8,17 @@ export const helpLabel = (text, id) => {
   if (!text) return null;
   return (
     <Popover id={`${id}-help`} bodyContent={text} aria-label="help-text">
-      <button
-        type="button"
+      <Button
+        ouiaId={`${id}-help-button`}
+        variant="plain"
         aria-label={__('open-help-tooltip-button')}
         onClick={e => e.preventDefault()}
-        className="pf-v5-c-form__group-label-help"
+        isInline
       >
         <Icon isInline>
           <HelpIcon />
         </Icon>
-      </button>
+      </Button>
     </Popover>
   );
 };

data/webpack/react_app/components/FeaturesDropdown/index.scss

@@ -1,7 +1,9 @@
 #schedule-a-job-dropdown ul.pf-v5-c-dropdown__menu {
   padding-left: 0;
+
   li {
     display: unset;
+
     a {
       font-size: 16px;
       color: var(--pf-v5-cdropdown__menu-item--Color);

data/webpack/react_app/components/TargetingHosts/TargetingHostsLabelsRow.scss

@@ -3,24 +3,28 @@
 .tasks-labels-row {
   margin: 0;
   padding: 10px;
+
   .title {
     font-weight: 600;
     font-size: 13px;
   }
+
   .label {
     font-size: 100%;
-
     margin-left: 5px;
     margin-right: 5px;
+
     a {
       padding-left: 10px;
     }
   }
+
   .pficon-close {
     color: $color-pf-white;
   }
+
   .compound-label-pf {
-    margin-left: 0;
     margin: 10px;
+    margin-left: 0;
   }
 }

data/webpack/react_app/components/TargetingHosts/__tests__/__snapshots__/TargetingHostsPage.test.js.snap

@@ -25,7 +25,7 @@ exports[`TargetingHostsPage renders 1`] = `
             },
             "bookmarks": Object {
               "canCreate": true,
-              "documentationUrl": "4.1.5Searching",
+              "documentationUrl": "/links/manual/4.1.5Searching",
               "id": "targeting_hosts_search",
               "url": "/api/bookmarks",
             },

data/webpack/react_app/components/TargetingHosts/index.js

@@ -7,6 +7,7 @@ import {
   withInterval,
   stopInterval,
 } from 'foremanReact/redux/middlewares/IntervalMiddleware';
+import { MS_PER_SECOND } from 'foremanReact/constants';
 
 import {
   selectItems,
@@ -100,7 +101,7 @@ const WrappedTargetingHosts = () => {
             dispatch(stopInterval(TARGETING_HOSTS));
           },
         }),
-        1000
+        MS_PER_SECOND
       ),
     [dispatch]
   );

data/webpack/react_app/redux/actions/jobInvocations/index.js

@@ -1,5 +1,6 @@
 // eslint-disable-next-line import/no-extraneous-dependencies
 import API from 'foremanReact/API';
+import { HTTP_STATUS_CODES, MS_PER_SECOND } from 'foremanReact/constants';
 
 import {
   JOB_INVOCATIONS_GET_JOB_INVOCATIONS,
@@ -7,7 +8,7 @@ import {
   JOB_INVOCATIONS_JOB_FINISHED,
 } from '../../consts';
 
-const defaultJobInvocationsPollingInterval = 1000;
+const defaultJobInvocationsPollingInterval = MS_PER_SECOND;
 const jobInvocationsInterval =
   process.env.JOB_INVOCATIONS_POLLING || defaultJobInvocationsPollingInterval;
 
@@ -32,7 +33,7 @@ const getJobInvocations = url => async (dispatch, getState) => {
   }
 
   function onGetJobInvocationsFailed(error) {
-    if (error.response.status === 401) {
+    if (error.response.status === HTTP_STATUS_CODES.UNAUTHORIZED) {
       window.location.replace('/users/login');
     }
   }

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: foreman_remote_execution
 version: !ruby/object:Gem::Version
-  version: 17.0.0
+  version: 17.2.0
 platform: ruby
 authors:
 - Foreman Remote Execution team
 bindir: bin
 cert_chain: []
-date: 2026-08-03 00:00:00.000000000 Z
+date: 2026-08-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: deface
@@ -485,7 +485,6 @@ files:
 - webpack/__mocks__/foremanReact/components/Pagination.js
 - webpack/__mocks__/foremanReact/components/ToastsList/index.js
 - webpack/__mocks__/foremanReact/components/common/ActionButtons/ActionButtons.js
-- webpack/__mocks__/foremanReact/constants.js
 - webpack/__mocks__/foremanReact/history.js
 - webpack/__mocks__/foremanReact/redux/API/APIActions.js
 - webpack/__mocks__/foremanReact/redux/API/APIConstants.js

data/webpack/__mocks__/foremanReact/constants.js

@@ -1,25 +0,0 @@
-export const STATUS = {
-  PENDING: 'PENDING',
-  RESOLVED: 'RESOLVED',
-  ERROR: 'ERROR',
-};
-
-export const getControllerSearchProps = (
-  controller,
-  id = 'searchBar',
-  canCreate = true
-) => ({
-  controller,
-  autocomplete: {
-    id,
-    searchQuery: '',
-    url: `${controller}/auto_complete_search`,
-    useKeyShortcuts: true,
-  },
-  bookmarks: {
-    id,
-    url: '/api/bookmarks',
-    canCreate,
-    documentationUrl: `4.1.5Searching`,
-  },
-});