foreman_remote_execution 17.0.0 → 17.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d0c5f9e975897ee24ccf2c91fafe81e998742ec7453ca0e7cf3aea4846962b23
-  data.tar.gz: 20f9ca73d78bd41ce758b3ac39e1e880be6630230eb64d735850a88ae7b9cbec
+  metadata.gz: e240991349f9cb6bc60f979202f8de2bde03d3d8100c13e701469aa2f8e29a97
+  data.tar.gz: f9936d90d62ce33221969367e5625cdf750c36922855142f460f46b18a8bc925
 SHA512:
-  metadata.gz: 57609a9b217ab4e7e5e60536a6a4de788b26d46d09f68330ca385fbd4df59d65cabc33581026ba15795aacbfc96b1fe6a97b735e006dfcf0a51188032ea525b9
-  data.tar.gz: 23d742ef78d0f9dc5cc205d541c74a8c3a3472618c4e67a6cb1c5c94c552a2ea6aa601ce38b498f9fae2403227f0efdf44055fefe8cc90df1de86e3c7b6fc96f
+  metadata.gz: eaf96768e4b112d387e660cca80d6b9dd360dd1145cf40b5540ea428bdf4bf3482e47591a05d2e2f0bcc05e36808e8163346258f323cc7f7f60917db3b930686
+  data.tar.gz: 56dbf3ac2a8cb8f90c8ae719fc5213c2fbf40588812bf98552fa8bdd967b6d1150632543dfb6992df09050d74813dd3eeb367cc857c3709a921a404b3772c823

data/app/controllers/api/v2/job_invocations_controller.rb

@@ -117,12 +117,14 @@ module Api
       param_group :search_and_pagination, ::Api::V2::BaseController
       add_scoped_search_description_for(JobInvocation)
       param :id, :identifier, :required => true
+      param :include_permissions, :bool, :required => false, :desc => N_('Include per-host task and permission data in the response')
       def hosts
         set_hosts_and_template_invocations
         @total = @hosts.size
         @hosts = @hosts.search_for(params[:search], :order => params[:order]).paginate(:page => params[:page], :per_page => params[:per_page])
         @subtotal = @hosts.total_entries
         set_statuses_and_smart_proxies
+        set_tasks_and_permissions if Foreman::Cast.to_bool(params[:include_permissions])
         if params[:awaiting]
           @hosts = @hosts.select { |host| @host_statuses[host.id] == 'N/A' }
         end
@@ -321,15 +323,35 @@ module Api
         template_invocations = @template_invocations.where(host_id: @hosts.select(:id))
                                                     .includes(:run_host_job_task).to_a
         hosts = @hosts.to_a
-        template_invocations_by_host_id = template_invocations.index_by(&:host_id)
+        @template_invocations_by_host_id = template_invocations.index_by(&:host_id)
         @host_statuses = hosts.to_h do |host|
-          template_invocation = template_invocations_by_host_id[host.id]
+          template_invocation = @template_invocations_by_host_id[host.id]
           task = template_invocation.try(:run_host_job_task)
           [host.id, template_invocation_status(task, @job_invocation.task)]
         end
         @smart_proxy_id = template_invocations.to_h { |ti| [ti.host_id, ti.smart_proxy_id] }
         @smart_proxy_name = template_invocations.to_h { |ti| [ti.host_id, ti.smart_proxy_name] }
       end
+
+      def set_tasks_and_permissions
+        can_cancel = authorized_for(:permission => :cancel_job_invocations, :auth_object => @job_invocation)
+        can_create = authorized_for(controller: :job_invocations, action: :create)
+        can_execute_on_infra = User.current.can?(:execute_jobs_on_infrastructure_hosts)
+
+        hosts = @hosts.to_a
+        @task_by_host = hosts.to_h do |host|
+          task = @template_invocations_by_host_id[host.id].try(:run_host_job_task)
+          [host.id, task ? { :id => task.id, :cancellable => task.try(:cancellable?) || false } : nil]
+        end
+        @permissions_by_host = hosts.to_h do |host|
+          task = @template_invocations_by_host_id[host.id].try(:run_host_job_task)
+          [host.id, {
+            :view_foreman_tasks => authorized_for(:permission => :view_foreman_tasks, :auth_object => task),
+            :cancel_job_invocations => can_cancel,
+            :execute_jobs => can_create && (!host.infrastructure_host? || can_execute_on_infra),
+          }]
+        end
+      end
     end
   end
 end

data/app/controllers/job_invocations_controller.rb

@@ -149,33 +149,6 @@ class JobInvocationsController < ApplicationController
     render :json => {:job_invocations => job_invocations}
   end
 
-  def list_jobs_hosts
-    @job_invocation = resource_base.find(params[:id])
-    hosts = @job_invocation.targeting.hosts.authorized(:view_hosts, Host)
-    hosts = hosts.search_for(params[:search])
-    template_invocations_task_by_hosts = {}
-    hosts.each do |host|
-      template_invocation = @job_invocation.template_invocations.find { |template_inv| template_inv.host_id == host.id }
-      next unless template_invocation
-      template_invocation_task = template_invocation.run_host_job_task
-      template_invocations_task_by_hosts[host.id] =
-        {
-          :host_name => host.name,
-          :id => host.id,
-          :task => template_invocation_task.attributes.merge({cancellable: template_invocation_task.cancellable? }),
-          :permissions => {
-            :view_foreman_tasks => authorized_for(:permission => :view_foreman_tasks, :auth_object => template_invocation_task),
-            :cancel_job_invocations => authorized_for(:permission => :cancel_job_invocations, :auth_object => @job_invocation),
-            :execute_jobs => authorized_for(controller: :job_invocations, action: :create) && (!host.infrastructure_host? || User.current.can?(:execute_jobs_on_infrastructure_hosts)),
-          },
-        }
-    end
-
-    render json: {
-      :template_invocations_task_by_hosts => template_invocations_task_by_hosts,
-    }
-  end
-
   private
 
   def action_permission
@@ -186,7 +159,7 @@ class JobInvocationsController < ApplicationController
         'create'
       when 'cancel'
         'cancel'
-      when 'chart', 'preview_job_invocations_per_host', 'list_jobs_hosts'
+      when 'chart', 'preview_job_invocations_per_host'
         'view'
       else
         super

data/app/models/remote_execution_provider.rb

@@ -76,6 +76,17 @@ class RemoteExecutionProvider
       [true, 'true', 'True', 'TRUE', '1'].include?(setting)
     end
 
+    def remote_working_dir(host)
+      dir = host_setting(host, :remote_execution_remote_working_dir).to_s.strip
+      unless Pathname.new(dir).absolute?
+        raise ::Foreman::Exception.new(
+          N_('Remote working directory "%{current_value}" is not an absolute path'),
+          current_value: dir
+        )
+      end
+      dir
+    end
+
     def effective_user_password(host)
       host_setting(host, :remote_execution_effective_user_password)
     end

data/app/models/script_execution_provider.rb

@@ -1,11 +1,14 @@
 class ScriptExecutionProvider < RemoteExecutionProvider
   class << self
     def proxy_command_options(template_invocation, host)
-      super.merge(:ssh_user => ssh_user(host, template_invocation.job_invocation),
-        :effective_user => effective_user(template_invocation),
-        :effective_user_method => effective_user_method(host),
-        :cleanup_working_dirs => cleanup_working_dirs?(host),
-        :ssh_port => ssh_port(host))
+      super.merge(
+        ssh_user: ssh_user(host, template_invocation.job_invocation),
+        effective_user: effective_user(template_invocation),
+        effective_user_method: effective_user_method(host),
+        cleanup_working_dirs: cleanup_working_dirs?(host),
+        remote_working_dir: remote_working_dir(host),
+        ssh_port: ssh_port(host)
+      )
     end
 
     def humanized_name

data/app/views/api/v2/job_invocations/hosts.json.rabl

@@ -13,3 +13,11 @@ end
 node :smart_proxy_name do |host|
   @smart_proxy_name[host.id]
 end
+
+node(:task, :if => ->(_host) { @task_by_host }) do |host|
+  @task_by_host[host.id]
+end
+
+node(:permissions, :if => ->(_host) { @permissions_by_host }) do |host|
+  @permissions_by_host[host.id]
+end

data/config/routes.rb

@@ -35,7 +35,6 @@ Rails.application.routes.draw do
       get 'auto_complete_search'
     end
     member do
-      get 'hosts', to: 'job_invocations#list_jobs_hosts'
       post 'cancel'
     end
   end

data/lib/foreman_remote_execution/plugin.rb

@@ -86,6 +86,15 @@ Foreman::Plugin.register :foreman_remote_execution do
         description: N_('When enabled, working directories will be removed after task completion. You may override this per host by setting a parameter called remote_execution_cleanup_working_dirs.'),
         default: true,
         full_name: N_('Cleanup working directories')
+      setting 'remote_execution_remote_working_dir',
+        type: :string,
+        description: N_('Directory on the host where remote execution jobs in push mode place and run their scripts. '\
+                        'You can override this setting per host with the `remote_execution_remote_working_dir` host parameter.'),
+        default: '/var/tmp',
+        full_name: N_('Remote working directory')
+      validates 'remote_execution_remote_working_dir',
+        ->(value) { Pathname.new(value.to_s.strip).absolute? },
+        message: N_('must be an absolute path')
       setting 'remote_execution_cockpit_url',
         type: :string,
         description: N_('Where to find the Cockpit instance for the Web Console button.  By default, no button is shown.'),
@@ -134,9 +143,9 @@ Foreman::Plugin.register :foreman_remote_execution do
     permission :lock_job_templates, { :job_templates => [:lock, :unlock] }, :resource_type => 'JobTemplate'
     permission :create_job_invocations, { :job_invocations => [:new, :create, :legacy_create, :refresh, :rerun, :preview_hosts],
                                           'api/v2/job_invocations' => [:create, :rerun] }, :resource_type => 'JobInvocation'
-    permission :view_job_invocations, { :job_invocations => [:index, :chart, :show, :auto_complete_search, :preview_job_invocations_per_host, :list_jobs_hosts], :template_invocations => [:show, :show_template_invocation_by_host],
+    permission :view_job_invocations, { :job_invocations => [:index, :chart, :show, :auto_complete_search, :preview_job_invocations_per_host], :template_invocations => [:show, :show_template_invocation_by_host],
                                         'api/v2/job_invocations' => [:index, :show, :output, :raw_output, :outputs, :hosts] }, :resource_type => 'JobInvocation'
-    permission :view_template_invocations, { :template_invocations => [:show, :template_invocation_preview, :show_template_invocation_by_host], :job_invocations => [:list_jobs_hosts],
+    permission :view_template_invocations, { :template_invocations => [:show, :template_invocation_preview, :show_template_invocation_by_host],
                                             'api/v2/template_invocations' => [:template_invocations], :ui_job_wizard => [:job_invocation] }, :resource_type => 'TemplateInvocation'
     permission :create_template_invocations, {}, :resource_type => 'TemplateInvocation'
     permission :execute_jobs_on_infrastructure_hosts, {}, :resource_type => 'JobInvocation'

data/lib/foreman_remote_execution/version.rb

@@ -1,3 +1,3 @@
 module ForemanRemoteExecution
-  VERSION = '17.0.0'.freeze
+  VERSION = '17.2.0'.freeze
 end

data/test/functional/api/v2/job_invocations_controller_test.rb

@@ -284,20 +284,59 @@ module Api
       end
 
       describe '#hosts' do
-        test 'should compute job_status for the paginated subset' do
-          invocation = FactoryBot.create(:job_invocation, :with_template, :with_task)
-          2.times { invocation.template_invocations << FactoryBot.create(:template_invocation, :with_task, :with_host, :job_invocation => invocation) }
-          invocation.job_category = invocation.pattern_template_invocations.first.template.job_category
-          invocation.targeting.hosts = invocation.template_invocations.map(&:host)
-          invocation.save!
+        setup do
+          @hosts_invocation = FactoryBot.create(:job_invocation, :with_template, :with_task)
+          2.times { @hosts_invocation.template_invocations << FactoryBot.create(:template_invocation, :with_task, :with_host, :job_invocation => @hosts_invocation) }
+          @hosts_invocation.job_category = @hosts_invocation.pattern_template_invocations.first.template.job_category
+          @hosts_invocation.targeting.hosts = @hosts_invocation.template_invocations.map(&:host)
+          @hosts_invocation.save!
+        end
 
-          get :hosts, params: { :id => invocation.id, :page => 2, :per_page => 1 }
+        test 'should compute job_status for the paginated subset' do
+          get :hosts, params: { :id => @hosts_invocation.id, :page => 2, :per_page => 1 }
           assert_response :success
           result = ActiveSupport::JSON.decode(@response.body)
           assert_equal 3, result['total']
           assert_equal 1, result['results'].size
           assert_equal(['success'], result['results'].map { |r| r['job_status'] })
         end
+
+        test 'should not include task and permissions without include_permissions' do
+          get :hosts, params: { :id => @hosts_invocation.id }
+          assert_response :success
+          result = ActiveSupport::JSON.decode(@response.body)
+          result['results'].each do |host|
+            assert_not host.key?('task'), 'Expected task to be absent'
+            assert_not host.key?('permissions'), 'Expected permissions to be absent'
+          end
+        end
+
+        test 'should include task and permissions with include_permissions=true' do
+          get :hosts, params: { :id => @hosts_invocation.id, :include_permissions => true }
+          assert_response :success
+          result = ActiveSupport::JSON.decode(@response.body)
+          result['results'].each do |host|
+            assert host.key?('task'), 'Expected task to be present'
+            assert host.key?('permissions'), 'Expected permissions to be present'
+            permissions = host['permissions']
+            assert permissions.key?('view_foreman_tasks')
+            assert permissions.key?('cancel_job_invocations')
+            assert permissions.key?('execute_jobs')
+          end
+        end
+
+        test 'should handle hosts with nil task gracefully when include_permissions=true' do
+          invocation = FactoryBot.create(:job_invocation, :with_template, :with_task, :with_unplanned_host)
+          invocation.job_category = invocation.pattern_template_invocations.first.template.job_category
+          invocation.save!
+
+          get :hosts, params: { :id => invocation.id, :include_permissions => true }
+          assert_response :success
+          result = ActiveSupport::JSON.decode(@response.body)
+          result['results'].each do |host|
+            assert host.key?('permissions'), 'Expected permissions to be present'
+          end
+        end
       end
 
       describe 'raw output' do

data/test/unit/remote_execution_provider_test.rb

@@ -202,6 +202,62 @@ class RemoteExecutionProviderTest < ActiveSupport::TestCase
       end
     end
 
+    describe 'remote working directory' do
+      it 'defaults to the value of the global setting' do
+        assert_equal '/var/tmp', proxy_options[:remote_working_dir]
+      end
+
+      it 'updates the value via settings' do
+        Setting[:remote_execution_remote_working_dir] = '/opt/rex'
+        assert_equal '/opt/rex', proxy_options[:remote_working_dir]
+      end
+
+      it 'takes the value from host parameters over the global setting' do
+        Setting[:remote_execution_remote_working_dir] = '/opt/rex'
+        host.host_parameters << FactoryBot.build(:host_parameter, name: 'remote_execution_remote_working_dir', value: '/opt/host')
+        host.clear_host_parameters_cache!
+        assert_equal '/opt/host', proxy_options[:remote_working_dir]
+      end
+
+      it 'takes the value inherited from the host group over the global setting' do
+        Setting[:remote_execution_remote_working_dir] = '/opt/rex'
+        hostgroup = FactoryBot.create(:hostgroup)
+        hostgroup.group_parameters << FactoryBot.build(:hostgroup_parameter, name: 'remote_execution_remote_working_dir', value: '/opt/hostgroup')
+        host.update!(hostgroup: hostgroup)
+        host.clear_host_parameters_cache!
+        assert_equal '/opt/hostgroup', proxy_options[:remote_working_dir]
+      end
+
+      it 'strips surrounding whitespace' do
+        Setting[:remote_execution_remote_working_dir] = ' /opt/rex '
+        assert_equal '/opt/rex', proxy_options[:remote_working_dir]
+      end
+
+      it 'rejects a setting value that is not an absolute path' do
+        assert_raises(ActiveRecord::RecordInvalid) do
+          Setting[:remote_execution_remote_working_dir] = 'opt/rex'
+        end
+      end
+
+      it 'rejects an empty setting value' do
+        assert_raises(ActiveRecord::RecordInvalid) do
+          Setting[:remote_execution_remote_working_dir] = ''
+        end
+      end
+
+      it 'raises when the host parameter is not an absolute path' do
+        host.host_parameters << FactoryBot.build(:host_parameter, name: 'remote_execution_remote_working_dir', value: 'opt/host')
+        host.clear_host_parameters_cache!
+        assert_raises(::Foreman::Exception) { proxy_options }
+      end
+
+      it 'raises when the host parameter is empty' do
+        host.host_parameters << FactoryBot.build(:host_parameter, name: 'remote_execution_remote_working_dir', value: '')
+        host.clear_host_parameters_cache!
+        assert_raises(::Foreman::Exception) { proxy_options }
+      end
+    end
+
     describe '#find_ip_or_hostname' do
       let(:host) do
         FactoryBot.create(:host) do |host|

data/webpack/JobInvocationDetail/CheckboxesActions.js

@@ -86,6 +86,7 @@ const ActionsKebab = ({
           id="toggle-kebab"
           isExpanded={isDropdownOpen}
           onClick={() => setIsDropdownOpen(prev => !prev)}
+          ouiaId="actions-kebab-toggle"
           ref={toggleRef}
           variant="plain"
         >

data/webpack/JobInvocationDetail/DropdownFilter.js

@@ -22,6 +22,7 @@ const DropdownFilter = ({ dropdownFilter, setDropdownFilter }) => {
       ref={toggleRef}
       onClick={() => setIsOpen(!isOpen)}
       isExpanded={isOpen}
+      ouiaId="host-status-select-toggle"
       style={{
         width: '200px',
       }}

data/webpack/JobInvocationDetail/JobInvocationActions.js

@@ -7,10 +7,9 @@ import {
   CHANGE_ENABLED_RECURRING_LOGIC,
   JOB_INVOCATION_KEY,
   STATUS,
+  AUTO_REFRESH_INTERVAL_MS,
 } from './JobInvocationConstants';
 
-const POLL_INTERVAL = 5000;
-
 export const isJobFinished = statusLabel =>
   statusLabel === STATUS.FAILED ||
   statusLabel === STATUS.SUCCEEDED ||
@@ -26,20 +25,27 @@ const createPollState = cancel => ({ timeoutId: null, cancel });
 
 export const getJobInvocation = (url, pollTimeoutRef) => dispatch => {
   let cancelled = false;
+  let isFirstCall = true;
 
   const poll = () => {
     if (cancelled) return;
+    const params = { include_hosts: false };
+    if (isFirstCall) {
+      params.include_permissions = true;
+      isFirstCall = false;
+    }
+
     dispatch(
       APIActions.get({
         key: JOB_INVOCATION_KEY,
-        params: { include_permissions: true, include_hosts: false },
+        params,
         url,
         handleSuccess: ({ data }) => {
           if (cancelled) return;
           // eslint-disable-next-line camelcase
           pollTimeoutRef.current.timeoutId = isJobFinished(data?.status_label)
             ? null
-            : setTimeout(poll, POLL_INTERVAL);
+            : setTimeout(poll, AUTO_REFRESH_INTERVAL_MS);
         },
         handleError: () => {
           if (cancelled) return;

data/webpack/JobInvocationDetail/JobInvocationConstants.js

@@ -15,14 +15,15 @@ export const GET_REPORT_TEMPLATE_INPUTS = 'GET_REPORT_TEMPLATE_INPUTS';
 export const JOB_INVOCATION_HOSTS = 'JOB_INVOCATION_HOSTS';
 export const GET_TEMPLATE_INVOCATION = 'GET_TEMPLATE_INVOCATION';
 export const DIRECT_OPEN_HOST_LIMIT = 3;
-export const ALL_JOB_HOSTS = 'ALL_JOB_HOSTS';
 export const AWAITING_STATUS_FILTER = '(job_invocation.result = N/A)';
 
 export const AUTO_REFRESH_INTERVAL_MS = 5000;
+export const DEFAULT_CHART_LEGEND_WIDTH = 270;
+export const CLIPBOARD_COPIED_EXIT_DELAY_MS = 1500;
+export const CLIPBOARD_DEFAULT_EXIT_DELAY_MS = 600;
 
 export const showTemplateInvocationUrl = (hostID, jobID) =>
   `/show_template_invocation_by_host/${hostID}/job_invocation/${jobID}`;
-export const LIST_TEMPLATE_INVOCATIONS = 'LIST_TEMPLATE_INVOCATIONS';
 
 export const templateInvocationPageUrl = (hostID, jobID) =>
   `/job_invocations_detail/${jobID}/host_invocation/${hostID}`;

data/webpack/JobInvocationDetail/JobInvocationDetail.scss

@@ -1,5 +1,6 @@
 .job-invocation-detail-flex {
   $chart_size: 105px;
+
   padding-top: 0px;
   padding-left: 10px;
   display: flex;
@@ -92,16 +93,17 @@ section.job-additional-info {
       max-height: 25em;
     }
   }
+
   div.invocation-output {
     display: block;
     padding: 9.5px;
     margin: 0 0 10px;
     font-size: 12px;
     word-break: break-all;
-    word-wrap: break-word;
+    overflow-wrap: break-word;
     color: rgba(255, 255, 255, 1);
     background-color: rgba(47, 47, 47, 1);
-    border: 1px solid #000000;
+    border: 1px solid #000;
     border-radius: 0px;
     font-family: Menlo, Monaco, Consolas, monospace;
 
@@ -127,7 +129,7 @@ section.job-additional-info {
     }
 
     a {
-      color: #ffffff;
+      color: #fff;
     }
 
     a.scroll-link{

data/webpack/JobInvocationDetail/JobInvocationHostTable.js

@@ -39,7 +39,6 @@ import { CheckboxesActions } from './CheckboxesActions';
 import DropdownFilter from './DropdownFilter';
 import Columns, {
   JOB_INVOCATION_HOSTS,
-  LIST_TEMPLATE_INVOCATIONS,
   STATUS_UPPERCASE,
   AWAITING_STATUS_FILTER,
   AUTO_REFRESH_INTERVAL_MS,
@@ -163,11 +162,24 @@ const JobInvocationHostTable = ({
     [initialFilter, urlSearchQuery]
   );
 
+  const [hostPermissions, setHostPermissions] = useState({});
+
   const updateHostsState = useCallback(data => {
     const ids = data.data.results.map(i => i.id);
     setApiResponse(data.data);
     setAllHostsIds(ids);
     setStatus(STATUS_UPPERCASE.RESOLVED);
+
+    const resultsWithPermissions = data.data.results.filter(r => r.permissions);
+    if (resultsWithPermissions.length > 0) {
+      setHostPermissions(prev => {
+        const updated = { ...prev };
+        resultsWithPermissions.forEach(r => {
+          updated[r.id] = { task: r.task, permissions: r.permissions };
+        });
+        return updated;
+      });
+    }
   }, []);
 
   // Call hosts data with params
@@ -229,7 +241,10 @@ const JobInvocationHostTable = ({
         finalParams.search = filterSearch;
       }
 
-      currentPollParams.current = finalParams;
+      finalParams.include_permissions = true;
+
+      currentPollParams.current = { ...finalParams };
+      delete currentPollParams.current.include_permissions;
       clearTimeout(pollTimeoutId.current);
       pollTimeoutId.current = null;
 
@@ -258,20 +273,12 @@ const JobInvocationHostTable = ({
   const initializedRef = useRef(false);
   useEffect(() => {
     if (!initializedRef.current) {
-      dispatch(
-        APIActions.get({
-          key: LIST_TEMPLATE_INVOCATIONS,
-          url: `/job_invocations/${id}/hosts`,
-          params: {},
-        })
-      );
-
       if (initialFilter === '') {
         onFilterUpdate('all_statuses');
       }
       initializedRef.current = true;
     }
-  }, [dispatch, id, initialFilter, onFilterUpdate]);
+  }, [initialFilter, onFilterUpdate]);
 
   useEffect(() => {
     const filterChanged = initialFilter !== prevFilter.current;
@@ -506,7 +513,12 @@ const JobInvocationHostTable = ({
                     <Td key={k}>{columns[k].wrapper(result)}</Td>
                   ))}
                   <Td isActionCell>
-                    <RowActions hostID={result.id} jobID={id} />
+                    <RowActions
+                      hostID={result.id}
+                      jobID={id}
+                      task={hostPermissions[result.id]?.task}
+                      permissions={hostPermissions[result.id]?.permissions}
+                    />
                   </Td>
                 </Tr>
                 <Tr

data/webpack/JobInvocationDetail/JobInvocationSelectors.js

@@ -6,7 +6,6 @@ import {
 import {
   JOB_INVOCATION_KEY,
   GET_TEMPLATE_INVOCATION,
-  LIST_TEMPLATE_INVOCATIONS,
 } from './JobInvocationConstants';
 
 export const selectItems = state =>
@@ -20,7 +19,3 @@ export const selectTemplateInvocation = hostID => state =>
 
 export const selectTemplateInvocationStatus = hostID => state =>
   selectAPIStatus(state, `${GET_TEMPLATE_INVOCATION}_${hostID}`);
-
-export const selectTemplateInvocationList = state =>
-  selectAPIResponse(state, LIST_TEMPLATE_INVOCATIONS)
-    ?.template_invocations_task_by_hosts;

data/webpack/JobInvocationDetail/JobInvocationSystemStatusChart.js

@@ -23,7 +23,10 @@ import {
   global_palette_blue_300 as inProgressColor,
   global_palette_green_500 as successedColor,
 } from '@patternfly/react-tokens';
-import { STATUS_TITLES } from './JobInvocationConstants';
+import {
+  STATUS_TITLES,
+  DEFAULT_CHART_LEGEND_WIDTH,
+} from './JobInvocationConstants';
 import './JobInvocationDetail.scss';
 
 const JobInvocationSystemStatusChart = ({
@@ -52,7 +55,7 @@ const JobInvocationSystemStatusChart = ({
     return '0';
   };
   const chartSize = 105;
-  const [legendWidth, setLegendWidth] = useState(270);
+  const [legendWidth, setLegendWidth] = useState(DEFAULT_CHART_LEGEND_WIDTH);
 
   // Calculates chart legend width based on its content
   useEffect(() => {

data/webpack/JobInvocationDetail/TemplateInvocation.js

@@ -12,6 +12,8 @@ import {
   templateInvocationPageUrl,
   GET_TEMPLATE_INVOCATION,
   AUTO_REFRESH_INTERVAL_MS,
+  CLIPBOARD_COPIED_EXIT_DELAY_MS,
+  CLIPBOARD_DEFAULT_EXIT_DELAY_MS,
 } from './JobInvocationConstants';
 import {
   selectTemplateInvocationStatus,
@@ -42,7 +44,11 @@ const CopyToClipboard = ({ fullOutput }) => {
       textId="code-content"
       aria-label="Copy to clipboard"
       onClick={e => onClick(e, fullOutput)}
-      exitDelay={copied ? 1500 : 600}
+      exitDelay={
+        copied
+          ? CLIPBOARD_COPIED_EXIT_DELAY_MS
+          : CLIPBOARD_DEFAULT_EXIT_DELAY_MS
+      }
       maxWidth="110px"
       variant="plain"
       onTooltipHidden={() => setCopied(false)}

data/webpack/JobInvocationDetail/TemplateInvocationComponents/OutputCodeBlock.js

@@ -7,6 +7,7 @@ import React, {
 import PropTypes from 'prop-types';
 import { Button } from '@patternfly/react-core';
 import { translate as __ } from 'foremanReact/common/I18n';
+import { MS_PER_SECOND } from 'foremanReact/constants';
 
 export const OutputCodeBlock = ({ code, showOutputType, scrollElement }) => {
   let lineCounter = 0;
@@ -122,7 +123,7 @@ export const OutputCodeBlock = ({ code, showOutputType, scrollElement }) => {
         <div key={index} className={`line ${line.output_type}`}>
           <span
             className="counter"
-            title={new Date(line.timestamp * 1000).toISOString()}
+            title={new Date(line.timestamp * MS_PER_SECOND).toISOString()}
           >
             {lineCounter.toString().padStart(4, '\u00A0')}:{' '}
           </span>

data/webpack/JobInvocationDetail/TemplateInvocationComponents/TemplateActionButtons.js

@@ -1,12 +1,11 @@
 import React from 'react';
 import PropTypes from 'prop-types';
-import { useDispatch, useSelector } from 'react-redux';
+import { useDispatch } from 'react-redux';
 import { Flex, FlexItem, Button } from '@patternfly/react-core';
 import { ActionsColumn } from '@patternfly/react-table';
 import { APIActions } from 'foremanReact/redux/API';
 import { addToast } from 'foremanReact/components/ToastsList';
 import { translate as __ } from 'foremanReact/common/I18n';
-import { selectTemplateInvocationList } from '../JobInvocationSelectors';
 import './index.scss';
 
 const actions = ({
@@ -81,11 +80,9 @@ const actions = ({
   },
 });
 
-export const RowActions = ({ hostID, jobID }) => {
+export const RowActions = ({ hostID, jobID, task, permissions }) => {
   const dispatch = useDispatch();
-  const response = useSelector(selectTemplateInvocationList)?.[hostID];
-  if (!response?.permissions) return null;
-  const { task, permissions } = response;
+  if (!permissions) return null;
   const { id: taskID, cancellable: taskCancellable } = task || {};
   const getActions = actions({
     taskID,
@@ -216,4 +213,18 @@ TemplateActionButtons.defaultProps = {
 RowActions.propTypes = {
   hostID: PropTypes.oneOfType([PropTypes.string, PropTypes.number]).isRequired,
   jobID: PropTypes.oneOfType([PropTypes.string, PropTypes.number]).isRequired,
+  task: PropTypes.shape({
+    id: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
+    cancellable: PropTypes.bool,
+  }),
+  permissions: PropTypes.shape({
+    view_foreman_tasks: PropTypes.bool,
+    cancel_job_invocations: PropTypes.bool,
+    execute_jobs: PropTypes.bool,
+  }),
+};
+
+RowActions.defaultProps = {
+  task: null,
+  permissions: null,
 };