foreman_puppet 11.0.0 → 11.1.0

data/webpack/src/Extends/Hosts/BulkActions/BulkRemovePuppetProxy/__tests__/index.test.js

@@ -1,23 +1,35 @@
 import React from 'react';
-import { mount } from '@theforeman/test';
+import { screen, act } from '@testing-library/react';
+import userEvent from '@testing-library/user-event';
+import '@testing-library/jest-dom';
 
 import { openBulkModal } from 'foremanReact/common/BulkModalStateHelper';
 import { ForemanActionsBarContext } from 'foremanReact/components/HostDetails/ActionsBar';
+import { rtlHelpers } from 'foremanReact/common/rtlTestHelpers';
+import { APIActions } from 'foremanReact/redux/API';
+import { foremanUrl } from 'foremanReact/common/helpers';
 
 import BulkRemovePuppetProxyScene from '../index';
-import BulkRemoveProxyCommon from '../../BulkRemoveProxyCommon';
+import { BULK_REMOVE_PUPPET_PROXY_KEY } from '../../BulkRemoveProxyCommon/actions';
 
-jest.mock('foremanReact/components/HostDetails/ActionsBar', () => ({
-  ForemanActionsBarContext: jest.requireActual('react').createContext(),
-}));
+jest.mock(
+  'foremanReact/components/HostDetails/ActionsBar',
+  () => ({
+    ForemanActionsBarContext: jest.requireActual('react').createContext(),
+  }),
+  { virtual: true }
+);
 
-jest.mock('../../BulkRemoveProxyCommon', () => ({
-  __esModule: true,
-  default: jest.fn(() => null),
+jest.mock('foremanReact/redux/API', () => ({
+  APIActions: {
+    put: jest.fn(payload => ({ type: 'MOCK_API_PUT', payload })),
+  },
 }));
 
+const { renderWithStoreAndI18n } = rtlHelpers;
+
 describe('BulkRemovePuppetProxyScene', () => {
-  const fetchBulkParams = jest.fn();
+  const fetchBulkParams = jest.fn(() => 'name = host1');
   const refreshTableData = jest.fn();
   const contextValue = {
     selectAllHostsMode: false,
@@ -27,38 +39,115 @@ describe('BulkRemovePuppetProxyScene', () => {
     refreshTableData,
   };
 
+  const renderScene = (context = contextValue) =>
+    renderWithStoreAndI18n(
+      <ForemanActionsBarContext.Provider value={context}>
+        <BulkRemovePuppetProxyScene />
+      </ForemanActionsBarContext.Provider>
+    );
+
+  const openSceneModal = async () => {
+    openBulkModal('bulk-remove-puppet-proxy', true);
+
+    return screen.findByRole('dialog', { name: 'Remove Puppet Proxy' });
+  };
+
   beforeEach(() => {
-    jest.clearAllMocks();
     openBulkModal('bulk-remove-puppet-proxy', false);
   });
 
-  it('opens with bulk modal state and passes expected props', () => {
-    openBulkModal('bulk-remove-puppet-proxy', true);
-    const wrapper = mount(
-      <ForemanActionsBarContext.Provider value={contextValue}>
-        <BulkRemovePuppetProxyScene />
-      </ForemanActionsBarContext.Provider>
+  afterEach(() => {
+    jest.clearAllMocks();
+  });
+
+  it('does not show the modal when bulk modal state is closed', () => {
+    renderScene();
+
+    expect(
+      screen.queryByRole('dialog', { name: 'Remove Puppet Proxy' })
+    ).not.toBeInTheDocument();
+  });
+
+  it('shows the modal with a warning for the selected hosts when opened', async () => {
+    renderScene();
+    await openSceneModal();
+
+    expect(
+      screen.getByText(/Removing the Puppet proxy will affect/)
+    ).toBeInTheDocument();
+    expect(screen.getByText('2', { selector: 'strong' })).toBeInTheDocument();
+    expect(screen.getByText(/selected hosts/)).toBeInTheDocument();
+    expect(
+      screen.getByRole('button', { name: 'Remove Puppet Proxy' })
+    ).toBeInTheDocument();
+    expect(screen.getByRole('button', { name: 'Cancel' })).toBeInTheDocument();
+  });
+
+  it('shows the all hosts warning when select all hosts mode is enabled', async () => {
+    renderScene({
+      ...contextValue,
+      selectAllHostsMode: true,
+    });
+    await openSceneModal();
+
+    expect(
+      screen.getByText(/Removing the Puppet proxy will affect/)
+    ).toBeInTheDocument();
+    expect(screen.getByText('All', { selector: 'strong' })).toBeInTheDocument();
+    expect(screen.getByText(/selected hosts/)).toBeInTheDocument();
+  });
+
+  it('closes the modal when Cancel is clicked', async () => {
+    renderScene();
+    await openSceneModal();
+
+    await userEvent.click(screen.getByRole('button', { name: 'Cancel' }));
+
+    expect(
+      screen.queryByRole('dialog', { name: 'Remove Puppet Proxy' })
+    ).not.toBeInTheDocument();
+  });
+
+  it('dispatches the bulk remove puppet proxy action when confirmed', async () => {
+    renderScene();
+    await openSceneModal();
+
+    await userEvent.click(
+      screen.getByRole('button', { name: 'Remove Puppet Proxy' })
     );
 
-    const componentType =
-      BulkRemoveProxyCommon.default || BulkRemoveProxyCommon;
-    const props = wrapper.find(componentType).props();
-
-    expect(props).toEqual(
-      expect.objectContaining({
-        isCAProxy: false,
-        selectAllHostsMode: false,
-        selectedCount: 2,
-        selectedResults: [1, 2],
-        fetchBulkParams,
-        isOpen: true,
-        closeModal: expect.any(Function),
-        onSuccess: refreshTableData,
-        handleErrorMessage: 'Failed to remove Puppet Proxy',
-        removeMessage: 'Remove Puppet Proxy',
-      })
+    expect(fetchBulkParams).toHaveBeenCalledTimes(1);
+    expect(APIActions.put).toHaveBeenCalledWith({
+      key: BULK_REMOVE_PUPPET_PROXY_KEY,
+      url: foremanUrl('/api/v2/hosts/bulk/remove_puppet_proxy'),
+      handleSuccess: expect.any(Function),
+      handleError: expect.any(Function),
+      params: {
+        included: {
+          search: 'name = host1',
+        },
+        ca_proxy: false,
+      },
+    });
+  });
+
+  it('refreshes table data after a successful bulk remove', async () => {
+    renderScene();
+    await openSceneModal();
+
+    await userEvent.click(
+      screen.getByRole('button', { name: 'Remove Puppet Proxy' })
     );
 
-    wrapper.unmount();
+    const { handleSuccess } = APIActions.put.mock.calls[0][0];
+
+    act(() => {
+      handleSuccess({ data: { message: 'Puppet proxy removed' } });
+    });
+
+    expect(refreshTableData).toHaveBeenCalledTimes(1);
+    expect(
+      screen.queryByRole('dialog', { name: 'Remove Puppet Proxy' })
+    ).not.toBeInTheDocument();
   });
 });

data/webpack/src/Router/routes.fixtures.js

@@ -0,0 +1,13 @@
+import React from 'react';
+
+export const ExampleRoutePage = () => (
+  <h1>Foreman Puppet example route</h1>
+);
+
+export const exampleRoutes = {
+  example: {
+    path: '/foreman_puppet_example',
+    exact: true,
+    component: ExampleRoutePage,
+  },
+};

data/webpack/src/Router/routes.test.js

@@ -1,16 +1,76 @@
 import React from 'react';
-import { shallow } from '@theforeman/test';
+import { createMemoryHistory } from 'history';
+import { Router, Route, Switch } from 'react-router-dom';
+import { screen } from '@testing-library/react';
+import '@testing-library/jest-dom';
 
-import Routes from './routes';
+import routes from './routes';
+import ForemanPuppetRouter from './index';
+import { exampleRoutes } from './routes.fixtures';
+import { rtlHelpers } from 'foremanReact/common/rtlTestHelpers';
+
+const { renderWithStore } = rtlHelpers;
+
+const renderForemanPuppetRouterAtPath = path => {
+  const history = createMemoryHistory({ initialEntries: [path] });
+
+  return renderWithStore(
+    <Router history={history}>
+      <ForemanPuppetRouter />
+    </Router>
+  );
+};
+
+const renderRoutesAtPath = (routeMap, path) => {
+  const history = createMemoryHistory({ initialEntries: [path] });
+
+  return renderWithStore(
+    <Router history={history}>
+      <Switch>
+        {Object.entries(routeMap).map(([key, props]) => (
+          <Route key={key} {...props} />
+        ))}
+      </Switch>
+    </Router>
+  );
+};
 
 describe('ForemanPuppetRoutes', () => {
-  it('should create routes', () => {
-    Object.entries(Routes).forEach(([key, Route]) => {
-      const Component = Route.component;
-      const component = shallow(<Component history={{}} some="props" />);
-      Route.renderResult = component;
+  it('exports an empty routes configuration object', () => {
+    expect(routes).toEqual({});
+    expect(routes).not.toBeNull();
+    expect(Array.isArray(routes)).toBe(false);
+  });
+
+  describe('fixture routes', () => {
+    it('defines valid route entries', () => {
+      Object.entries(exampleRoutes).forEach(([routeKey, route]) => {
+        expect(routeKey).toBeTruthy();
+        expect(route).toEqual(
+          expect.objectContaining({
+            path: expect.any(String),
+            component: expect.any(Function),
+          })
+        );
+      });
     });
 
-    expect(Routes).toMatchSnapshot();
+    it('renders a fixture route at its path', () => {
+      const { path } = exampleRoutes.example;
+
+      renderRoutesAtPath(exampleRoutes, path);
+
+      expect(
+        screen.getByRole('heading', { name: 'Foreman Puppet example route' })
+      ).toBeInTheDocument();
+    });
+  });
+
+  describe('ForemanPuppetRouter', () => {
+    it('renders without content when no routes are configured', () => {
+      const { container } = renderForemanPuppetRouterAtPath('/');
+
+      expect(container).toBeEmptyDOMElement();
+    });
   });
 });

data/webpack/src/foreman_puppet_host_form.test.js

@@ -4,6 +4,8 @@ import $ from 'jquery';
 
 import { checkForUnavailablePuppetclasses } from './foreman_puppet_host_form';
 
+const WARNING_RENDER_TIMEOUT = 100;
+
 jest.unmock('jquery');
 jest.unmock('./foreman_puppet_host_form');
 
@@ -59,6 +61,6 @@ describe('checkForUnavailablePuppetclasses', () => {
     checkForUnavailablePuppetclasses();
     setTimeout(() => {
       expect($('a .pficon')).toHaveLength(1);
-    }, 100);
+    }, WARNING_RENDER_TIMEOUT);
   });
 });

data/webpack/test_setup.js

@@ -0,0 +1 @@
+import 'foremanJSTestSetup';

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foreman_puppet
 version: !ruby/object:Gem::Version
-  version: 11.0.0
+  version: 11.1.0
 platform: ruby
 authors:
 - Ondřej Ezr
@@ -384,6 +384,12 @@ files:
 - webpack/src/Extends/Hosts/BulkActions/BulkChangeProxyCommon/index.js
 - webpack/src/Extends/Hosts/BulkActions/BulkChangePuppetCAProxy/__tests__/index.test.js
 - webpack/src/Extends/Hosts/BulkActions/BulkChangePuppetCAProxy/index.js
+- webpack/src/Extends/Hosts/BulkActions/BulkChangePuppetEnvironment/BulkChangePuppetEnvironmentModal.js
+- webpack/src/Extends/Hosts/BulkActions/BulkChangePuppetEnvironment/__tests__/BulkChangePuppetEnvironmentModal.test.js
+- webpack/src/Extends/Hosts/BulkActions/BulkChangePuppetEnvironment/__tests__/actions.test.js
+- webpack/src/Extends/Hosts/BulkActions/BulkChangePuppetEnvironment/__tests__/index.test.js
+- webpack/src/Extends/Hosts/BulkActions/BulkChangePuppetEnvironment/actions.js
+- webpack/src/Extends/Hosts/BulkActions/BulkChangePuppetEnvironment/index.js
 - webpack/src/Extends/Hosts/BulkActions/BulkChangePuppetProxy/__tests__/index.test.js
 - webpack/src/Extends/Hosts/BulkActions/BulkChangePuppetProxy/index.js
 - webpack/src/Extends/Hosts/BulkActions/BulkRemoveProxyCommon/__tests__/actions.test.js
@@ -391,13 +397,17 @@ files:
 - webpack/src/Extends/Hosts/BulkActions/BulkRemoveProxyCommon/index.js
 - webpack/src/Extends/Hosts/BulkActions/BulkRemovePuppetCAProxy/__tests__/index.test.js
 - webpack/src/Extends/Hosts/BulkActions/BulkRemovePuppetCAProxy/index.js
+- webpack/src/Extends/Hosts/BulkActions/BulkRemovePuppetEnvironment/BulkRemovePuppetEnvironmentModal.js
+- webpack/src/Extends/Hosts/BulkActions/BulkRemovePuppetEnvironment/__tests__/BulkRemovePuppetEnvironmentModal.test.js
+- webpack/src/Extends/Hosts/BulkActions/BulkRemovePuppetEnvironment/__tests__/index.test.js
+- webpack/src/Extends/Hosts/BulkActions/BulkRemovePuppetEnvironment/index.js
 - webpack/src/Extends/Hosts/BulkActions/BulkRemovePuppetProxy/__tests__/index.test.js
 - webpack/src/Extends/Hosts/BulkActions/BulkRemovePuppetProxy/index.js
 - webpack/src/Extends/Hosts/BulkActions/__tests__/toastHelpers.test.js
 - webpack/src/Extends/Hosts/BulkActions/toastHelpers.js
 - webpack/src/ForemanPuppet.js
-- webpack/src/Router/__snapshots__/routes.test.js.snap
 - webpack/src/Router/index.js
+- webpack/src/Router/routes.fixtures.js
 - webpack/src/Router/routes.js
 - webpack/src/Router/routes.test.js
 - webpack/src/foreman_class_edit.js
@@ -405,6 +415,7 @@ files:
 - webpack/src/foreman_puppet_host_form.test.js
 - webpack/src/index.js
 - webpack/src/reducers.js
+- webpack/test_setup.js
 homepage: https://github.com/theforeman/foreman_puppet
 licenses:
 - GPL-3.0
@@ -426,7 +437,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.16
+rubygems_version: 4.0.20
 specification_version: 4
 summary: Add Puppet features to Foreman
 test_files:

data/webpack/src/Router/__snapshots__/routes.test.js.snap

@@ -1,3 +0,0 @@
-// Jest Snapshot v1, https://goo.gl/fbAQLP
-
-exports[`ForemanPuppetRoutes should create routes 1`] = `Object {}`;