foreman_puppet 11.0.0 → 11.1.0

data/webpack/src/Extends/Hosts/BulkActions/BulkChangePuppetEnvironment/__tests__/BulkChangePuppetEnvironmentModal.test.js

@@ -0,0 +1,155 @@
+import React from 'react';
+import { render, screen, fireEvent } from '@testing-library/react';
+import '@testing-library/jest-dom';
+import { IntlProvider } from 'react-intl';
+import { useDispatch, useSelector } from 'react-redux';
+
+import BulkChangePuppetEnvironmentModal from '../BulkChangePuppetEnvironmentModal';
+import { fetchEnvironments, bulkChangePuppetEnvironment } from '../actions';
+import {
+  selectAPIResponse,
+  selectAPIStatus,
+} from 'foremanReact/redux/API/APISelectors';
+
+jest.mock('@patternfly/react-core', () => {
+  const React = require('react');
+  const actual = jest.requireActual('@patternfly/react-core');
+
+  const MenuToggle = React.forwardRef(({ children, onClick }, ref) => (
+    <button type="button" ref={ref} onClick={onClick}>
+      {children}
+    </button>
+  ));
+
+  const SelectOption = ({ children, value, onSelect }) => (
+    <button type="button" onClick={event => onSelect(event, value)}>
+      {children}
+    </button>
+  );
+
+  const SelectList = ({ children, onSelect }) => (
+    <div>
+      {React.Children.map(children, child =>
+        React.isValidElement(child)
+          ? React.cloneElement(child, { onSelect })
+          : child
+      )}
+    </div>
+  );
+
+  const Select = ({ children, isOpen, toggle, onSelect }) => (
+    <div>
+      {toggle()}
+      {isOpen &&
+        React.Children.map(children, child =>
+          React.isValidElement(child)
+            ? React.cloneElement(child, { onSelect })
+            : child
+        )}
+    </div>
+  );
+
+  return {
+    ...actual,
+    MenuToggle,
+    Select,
+    SelectList,
+    SelectOption,
+  };
+});
+
+jest.mock('react-redux', () => ({
+  ...jest.requireActual('react-redux'),
+  useDispatch: jest.fn(),
+  useSelector: jest.fn(),
+}));
+
+jest.mock('foremanReact/Root/Context/ForemanContext', () => ({
+  useForemanOrganization: jest.fn(() => ({ id: 23 })),
+}));
+
+jest.mock('foremanReact/redux/API/APISelectors', () => ({
+  selectAPIResponse: jest.fn(),
+  selectAPIStatus: jest.fn(),
+}));
+
+jest.mock('../actions', () => ({
+  fetchEnvironments: jest.fn(() => ({ type: 'FETCH_ENVIRONMENTS' })),
+  bulkChangePuppetEnvironment: jest.fn(() => ({
+    type: 'BULK_CHANGE_PUPPET_ENVIRONMENT',
+  })),
+  PUPPET_ENVIRONMENTS_KEY: 'PUPPET_ENVIRONMENTS_KEY',
+  BULK_CHANGE_PUPPET_ENVIRONMENT_KEY: 'BULK_CHANGE_PUPPET_ENVIRONMENT',
+  INHERIT_ENVIRONMENT: 'inherit',
+}));
+
+describe('BulkChangePuppetEnvironmentModal', () => {
+  const dispatch = jest.fn();
+  const fetchBulkParams = jest.fn(
+    () => 'organization = "Default Organization"'
+  );
+  const environmentsResponse = {
+    results: [{ id: 1, name: 'production' }],
+  };
+
+  const renderComponent = () =>
+    render(
+      <IntlProvider locale="en">
+        <BulkChangePuppetEnvironmentModal
+          isOpen
+          closeModal={jest.fn()}
+          fetchBulkParams={fetchBulkParams}
+          selectedCount={2}
+          selectAllHostsMode={false}
+        />
+      </IntlProvider>
+    );
+
+  beforeEach(() => {
+    jest.clearAllMocks();
+    useDispatch.mockReturnValue(dispatch);
+    selectAPIResponse.mockReturnValue(environmentsResponse);
+    selectAPIStatus.mockReturnValue('RESOLVED');
+    useSelector.mockImplementation(selector => selector({}));
+  });
+
+  it('renders the environment options', () => {
+    renderComponent();
+
+    expect(fetchEnvironments).toHaveBeenCalledWith(23);
+    expect(
+      screen.getAllByText('Change Puppet Environment')[0]
+    ).toBeInTheDocument();
+    expect(
+      screen.getByRole('button', { name: 'Select an Environment' })
+    ).toBeInTheDocument();
+    expect(
+      screen.getByText(/Changing the Puppet environment will affect/)
+    ).toBeInTheDocument();
+  });
+
+  it('submits organization scope with the bulk change request', () => {
+    renderComponent();
+
+    fireEvent.click(
+      screen.getByRole('button', { name: 'Select an Environment' })
+    );
+    expect(screen.getByText('*Inherit from host group*')).toBeInTheDocument();
+    fireEvent.click(screen.getByText('production'));
+    fireEvent.click(
+      screen.getByRole('button', { name: 'Change Puppet Environment' })
+    );
+
+    expect(bulkChangePuppetEnvironment).toHaveBeenCalledWith(
+      {
+        included: {
+          search: 'organization = "Default Organization"',
+        },
+        environment_id: '1',
+        organization_id: 23,
+      },
+      expect.any(Function),
+      expect.any(Function)
+    );
+  });
+});

data/webpack/src/Extends/Hosts/BulkActions/BulkChangePuppetEnvironment/__tests__/actions.test.js

@@ -0,0 +1,49 @@
+import { APIActions } from 'foremanReact/redux/API';
+import {
+  fetchEnvironments,
+  PUPPET_ENVIRONMENTS_KEY,
+  bulkChangePuppetEnvironment,
+  BULK_CHANGE_PUPPET_ENVIRONMENT_KEY,
+} from '../actions';
+
+jest.mock('foremanReact/redux/API', () => ({
+  APIActions: {
+    get: jest.fn(),
+    put: jest.fn(),
+  },
+}));
+
+describe('BulkChangePuppetEnvironment actions', () => {
+  const environmentsUrl = '/foreman_puppet/api/v2/environments';
+  const bulkChangeUrl = '/api/v2/hosts/bulk/change_puppet_environment';
+
+  beforeEach(() => {
+    jest.clearAllMocks();
+  });
+
+  it('fetches environments', () => {
+    fetchEnvironments(23);
+
+    expect(APIActions.get).toHaveBeenCalledWith({
+      key: PUPPET_ENVIRONMENTS_KEY,
+      url: environmentsUrl,
+      params: { per_page: 'all', organization_id: 23 },
+    });
+  });
+
+  it('calls bulk change puppet environment endpoint', () => {
+    const params = { included: { ids: [1] }, environment_id: '1' };
+    const handleSuccess = jest.fn();
+    const handleError = jest.fn();
+
+    bulkChangePuppetEnvironment(params, handleSuccess, handleError);
+
+    expect(APIActions.put).toHaveBeenCalledWith({
+      key: BULK_CHANGE_PUPPET_ENVIRONMENT_KEY,
+      url: bulkChangeUrl,
+      handleSuccess,
+      handleError,
+      params,
+    });
+  });
+});

data/webpack/src/Extends/Hosts/BulkActions/BulkChangePuppetEnvironment/__tests__/index.test.js

@@ -0,0 +1,66 @@
+import React from 'react';
+import renderer, { act } from 'react-test-renderer';
+
+import { useBulkModalOpen } from 'foremanReact/common/BulkModalStateHelper';
+import { ForemanActionsBarContext } from 'foremanReact/components/HostDetails/ActionsBar';
+
+import BulkChangePuppetEnvironmentScene from '../index';
+import BulkChangePuppetEnvironmentModal from '../BulkChangePuppetEnvironmentModal';
+
+jest.mock('foremanReact/common/BulkModalStateHelper', () => ({
+  useBulkModalOpen: jest.fn(),
+}));
+
+jest.mock('../BulkChangePuppetEnvironmentModal', () => ({
+  __esModule: true,
+  default: jest.fn(() => null),
+}));
+
+describe('BulkChangePuppetEnvironmentScene', () => {
+  const fetchBulkParams = jest.fn();
+  const refreshTableData = jest.fn();
+  const contextValue = {
+    selectAllHostsMode: false,
+    selectedCount: 2,
+    selectedResults: [1, 2],
+    fetchBulkParams,
+    refreshTableData,
+  };
+
+  beforeEach(() => {
+    jest.clearAllMocks();
+    useBulkModalOpen.mockReturnValue({
+      isOpen: true,
+      close: jest.fn(),
+    });
+  });
+
+  it('opens with bulk modal state and passes expected props', () => {
+    let component;
+    act(() => {
+      component = renderer.create(
+        <ForemanActionsBarContext.Provider value={contextValue}>
+          <BulkChangePuppetEnvironmentScene />
+        </ForemanActionsBarContext.Provider>
+      );
+    });
+
+    const componentType =
+      BulkChangePuppetEnvironmentModal.default ||
+      BulkChangePuppetEnvironmentModal;
+    const { props } = component.root.findByType(componentType);
+
+    expect(props).toEqual(
+      expect.objectContaining({
+        fetchBulkParams,
+        selectedCount: 2,
+        selectAllHostsMode: false,
+        isOpen: true,
+        closeModal: expect.any(Function),
+        onSuccess: refreshTableData,
+      })
+    );
+
+    component.unmount();
+  });
+});

data/webpack/src/Extends/Hosts/BulkActions/BulkChangePuppetEnvironment/actions.js

@@ -0,0 +1,37 @@
+import { APIActions } from 'foremanReact/redux/API';
+import { foremanUrl } from 'foremanReact/common/helpers';
+
+export const PUPPET_ENVIRONMENTS_KEY = 'PUPPET_ENVIRONMENTS_KEY';
+export const BULK_CHANGE_PUPPET_ENVIRONMENT_KEY =
+  'BULK_CHANGE_PUPPET_ENVIRONMENT';
+
+export const INHERIT_ENVIRONMENT = 'inherit';
+
+export const fetchEnvironments = organizationId => {
+  const url = foremanUrl('/foreman_puppet/api/v2/environments');
+  return APIActions.get({
+    key: PUPPET_ENVIRONMENTS_KEY,
+    url,
+    params: {
+      per_page: 'all',
+      ...(organizationId ? { organization_id: organizationId } : {}),
+    },
+  });
+};
+
+export const bulkChangePuppetEnvironment = (
+  params,
+  handleSuccess,
+  handleError
+) => {
+  const url = foremanUrl('/api/v2/hosts/bulk/change_puppet_environment');
+  return APIActions.put({
+    key: BULK_CHANGE_PUPPET_ENVIRONMENT_KEY,
+    url,
+    handleSuccess,
+    handleError,
+    params,
+  });
+};
+
+export default fetchEnvironments;

data/webpack/src/Extends/Hosts/BulkActions/BulkChangePuppetEnvironment/index.js

@@ -0,0 +1,30 @@
+import React, { useContext } from 'react';
+import { ForemanActionsBarContext } from 'foremanReact/components/HostDetails/ActionsBar';
+import { useBulkModalOpen } from 'foremanReact/common/BulkModalStateHelper';
+import BulkChangePuppetEnvironmentModal from './BulkChangePuppetEnvironmentModal';
+
+const BulkChangePuppetEnvironmentScene = () => {
+  const {
+    selectAllHostsMode,
+    selectedCount,
+    fetchBulkParams,
+    refreshTableData,
+  } = useContext(ForemanActionsBarContext);
+  const { isOpen, close: closeModal } = useBulkModalOpen(
+    'bulk-change-puppet-environment'
+  );
+
+  return (
+    <BulkChangePuppetEnvironmentModal
+      fetchBulkParams={fetchBulkParams}
+      selectedCount={selectedCount}
+      selectAllHostsMode={selectAllHostsMode}
+      isOpen={isOpen}
+      closeModal={closeModal}
+      onSuccess={refreshTableData}
+    />
+  );
+};
+
+export { BulkChangePuppetEnvironmentModal };
+export default BulkChangePuppetEnvironmentScene;

data/webpack/src/Extends/Hosts/BulkActions/BulkChangePuppetProxy/__tests__/index.test.js

@@ -1,69 +1,182 @@
 import React from 'react';
-import { mount } from '@theforeman/test';
+import { act, screen, waitFor } from '@testing-library/react';
+import userEvent from '@testing-library/user-event';
+import '@testing-library/jest-dom';
 
 import { openBulkModal } from 'foremanReact/common/BulkModalStateHelper';
 import { ForemanActionsBarContext } from 'foremanReact/components/HostDetails/ActionsBar';
+import { rtlHelpers } from 'foremanReact/common/rtlTestHelpers';
+import { APIActions } from 'foremanReact/redux/API';
+import API from 'foremanReact/redux/API/API';
 
 import BulkChangePuppetProxyScene from '../index';
-import BulkChangeProxyCommon from '../../BulkChangeProxyCommon';
+import { BULK_CHANGE_PUPPET_PROXY_KEY } from '../../BulkChangeProxyCommon/actions';
 
-jest.mock('foremanReact/components/HostDetails/ActionsBar', () => ({
-  ForemanActionsBarContext: jest.requireActual('react').createContext(),
-}));
+jest.mock('foremanReact/redux/API', () => {
+  const actual = jest.requireActual('foremanReact/redux/API');
 
-jest.mock('../../BulkChangeProxyCommon', () => ({
-  __esModule: true,
-  default: jest.fn(() => null),
-}));
-
-describe('BulkChangePuppetProxyScene', () => {
-  const fetchBulkParams = jest.fn();
-  const refreshTableData = jest.fn();
-  const contextValue = {
-    selectAllHostsMode: false,
-    selectedCount: 2,
-    selectedResults: [1, 2],
-    fetchBulkParams,
-    refreshTableData,
+  return {
+    ...actual,
+    APIActions: {
+      ...actual.APIActions,
+      put: jest.fn(params => ({ type: 'MOCK_API_PUT', payload: params })),
+    },
   };
+});
+
+jest.mock('foremanReact/redux/API/APISelectors', () =>
+  jest.requireActual('foremanReact/redux/API/APISelectors')
+);
+
+const { renderWithStoreAndI18n } = rtlHelpers;
+
+const MODAL_ID = 'bulk-change-puppet-proxy';
+
+const fetchBulkParams = jest.fn(() => 'id ^ (1,2)');
+const refreshTableData = jest.fn();
+
+const defaultContextValue = {
+  selectAllHostsMode: false,
+  selectedCount: 2,
+  selectedResults: [1, 2],
+  fetchBulkParams,
+  refreshTableData,
+};
+
+const smartProxiesResponse = {
+  data: {
+    results: [{ id: 1, name: 'proxy1.example.com' }],
+  },
+};
 
+const renderScene = ({ contextValue = defaultContextValue } = {}) =>
+  renderWithStoreAndI18n(
+    <ForemanActionsBarContext.Provider value={contextValue}>
+      <BulkChangePuppetProxyScene />
+    </ForemanActionsBarContext.Provider>
+  );
+
+const selectPuppetProxy = async () => {
+  await act(async () => {
+    await userEvent.click(await screen.findByText('Select a Puppet Proxy'));
+  });
+  await act(async () => {
+    await userEvent.click(screen.getByText('proxy1.example.com'));
+  });
+};
+
+describe('BulkChangePuppetProxyScene', () => {
   beforeEach(() => {
+    openBulkModal(MODAL_ID, false);
+    API.get.mockImplementation(() => Promise.resolve(smartProxiesResponse));
+  });
+
+  afterEach(() => {
     jest.clearAllMocks();
-    openBulkModal('bulk-change-puppet-proxy', false);
   });
 
-  it('opens with bulk modal state and passes expected props', () => {
-    openBulkModal('bulk-change-puppet-proxy', true);
-    const wrapper = mount(
-      <ForemanActionsBarContext.Provider value={contextValue}>
-        <BulkChangePuppetProxyScene />
-      </ForemanActionsBarContext.Provider>
-    );
+  it('does not show the modal when bulk modal state is closed', () => {
+    renderScene();
 
-    const componentType =
-      BulkChangeProxyCommon.default || BulkChangeProxyCommon;
-    const props = wrapper.find(componentType).props();
+    expect(
+      screen.queryByRole('dialog', { name: 'Change Puppet Proxy' })
+    ).not.toBeInTheDocument();
+  });
 
-    expect(props).toEqual(
+  it('opens the modal with Puppet Proxy content when bulk modal is open', async () => {
+    openBulkModal(MODAL_ID, true);
+    renderScene();
+
+    expect(
+      await screen.findByRole('dialog', { name: 'Change Puppet Proxy' })
+    ).toBeInTheDocument();
+    expect(
+      screen.getByText(/Changing the Puppet proxy will affect/)
+    ).toBeInTheDocument();
+    expect(screen.getByText('2')).toBeInTheDocument();
+    expect(
+      await screen.findByText('Select a Puppet Proxy')
+    ).toBeInTheDocument();
+    expect(screen.queryByText('Select a Puppet CA Proxy')).not.toBeInTheDocument();
+    expect(screen.queryByText('Change Puppet CA Proxy')).not.toBeInTheDocument();
+    expect(
+      await screen.findByRole('button', { name: 'Change Puppet Proxy' })
+    ).toBeDisabled();
+    expect(screen.getByRole('button', { name: 'Cancel' })).toBeInTheDocument();
+  });
+
+  it('shows the all-hosts warning when select all hosts mode is enabled', async () => {
+    openBulkModal(MODAL_ID, true);
+    renderScene({
+      contextValue: { ...defaultContextValue, selectAllHostsMode: true },
+    });
+
+    await screen.findByRole('dialog', { name: 'Change Puppet Proxy' });
+    expect(screen.getByText('All')).toBeInTheDocument();
+  });
+
+  it('closes the modal when Cancel is clicked', async () => {
+    openBulkModal(MODAL_ID, true);
+    renderScene();
+
+    await screen.findByRole('dialog', { name: 'Change Puppet Proxy' });
+    await userEvent.click(screen.getByRole('button', { name: 'Cancel' }));
+
+    await waitFor(() => {
+      expect(
+        screen.queryByRole('dialog', { name: 'Change Puppet Proxy' })
+      ).not.toBeInTheDocument();
+    });
+  });
+
+  it('submits puppet proxy change request when confirm is clicked', async () => {
+    openBulkModal(MODAL_ID, true);
+    renderScene();
+
+    await screen.findByRole('dialog', { name: 'Change Puppet Proxy' });
+    await selectPuppetProxy();
+    await act(async () => {
+      await userEvent.click(
+        screen.getByRole('button', { name: 'Change Puppet Proxy' })
+      );
+    });
+
+    expect(fetchBulkParams).toHaveBeenCalledTimes(1);
+    expect(APIActions.put).toHaveBeenCalledWith(
       expect.objectContaining({
-        isCAProxy: false,
-        fetchBulkParams,
-        selectedCount: 2,
-        selectedResults: [1, 2],
-        selectAllHostsMode: false,
-        isOpen: true,
-        closeModal: expect.any(Function),
-        onSuccess: refreshTableData,
-        selectMessage: 'Select a Puppet Proxy',
-        handleErrorMessage: 'Failed to change Puppet Proxy',
-        changeMessage: 'Change Puppet Proxy',
-        allHostsMessage:
-          'Changing the Puppet proxy will affect {boldCount} selected hosts. Some hosts may already have been associated with the selected Puppet proxy.',
-        someHostsMessage:
-          'Changing the Puppet proxy will affect {boldCount} selected {count, plural, one {host} other {hosts}}. Some hosts may already have been associated with the selected Puppet proxy.',
+        key: BULK_CHANGE_PUPPET_PROXY_KEY,
+        params: {
+          included: {
+            search: 'id ^ (1,2)',
+          },
+          proxy_id: '1',
+          ca_proxy: false,
+        },
       })
     );
+  });
+
+  it('refreshes table data after successful change', async () => {
+    openBulkModal(MODAL_ID, true);
+    renderScene();
+
+    await screen.findByRole('dialog', { name: 'Change Puppet Proxy' });
+    await selectPuppetProxy();
+    await act(async () => {
+      await userEvent.click(
+        screen.getByRole('button', { name: 'Change Puppet Proxy' })
+      );
+    });
+
+    const { handleSuccess } = APIActions.put.mock.calls[0][0];
+
+    act(() => {
+      handleSuccess({ data: { message: 'Change started' } });
+    });
 
-    wrapper.unmount();
+    expect(refreshTableData).toHaveBeenCalledTimes(1);
+    expect(
+      screen.queryByRole('dialog', { name: 'Change Puppet Proxy' })
+    ).not.toBeInTheDocument();
   });
 });

data/webpack/src/Extends/Hosts/BulkActions/BulkRemoveProxyCommon/__tests__/actions.test.js

@@ -7,12 +7,6 @@ import {
   BULK_REMOVE_PUPPET_CA_PROXY_KEY,
 } from '../actions';
 
-jest.mock('foremanReact/redux/API', () => ({
-  APIActions: {
-    put: jest.fn(),
-  },
-}));
-
 describe('BulkRemoveProxyCommon actions', () => {
   const url = foremanUrl('/api/v2/hosts/bulk/remove_puppet_proxy');