foreman_pipeline 0.0.11 → 0.1.0

data/test/fixtures/jobs.yml

@@ -0,0 +1,47 @@
+valid:
+  name: "valid job"
+  organization_id: <%= ActiveRecord::FixtureSet.identify(:empty_organization) %>
+  hostgroup_id: <%= ActiveRecord::FixtureSet.identify(:basic) %>
+  compute_resource_id: <%= ActiveRecord::FixtureSet.identify(:ec2) %>
+  content_view_id: <%= ActiveRecord::FixtureSet.identify(:library_view) %>
+  jenkins_instance_id: <%= ActiveRecord::FixtureSet.identify(:one) %>
+  environment_id: <%= ActiveRecord::FixtureSet.identify(:library) %>
+  manual_trigger: true
+  sync_trigger: false
+  levelup_trigger: false
+
+runs_on_sync:
+  name:  "runs on sync"
+  organization_id: <%= ActiveRecord::FixtureSet.identify(:empty_organization) %>
+  hostgroup_id: <%= ActiveRecord::FixtureSet.identify(:basic) %>
+  compute_resource_id: <%= ActiveRecord::FixtureSet.identify(:ec2) %>
+  content_view_id: <%= ActiveRecord::FixtureSet.identify(:library_view) %>
+  jenkins_instance_id: <%= ActiveRecord::FixtureSet.identify(:one) %>
+  environment_id: <%= ActiveRecord::FixtureSet.identify(:library) %>
+  manual_trigger: false
+  sync_trigger: true
+  levelup_trigger: false
+
+runs_on_levelup:
+  name: "runs on publish/promote"
+  organization_id: <%= ActiveRecord::FixtureSet.identify(:empty_organization) %>
+  hostgroup_id: <%= ActiveRecord::FixtureSet.identify(:basic) %>
+  compute_resource_id: <%= ActiveRecord::FixtureSet.identify(:ec2) %>
+  content_view_id: <%= ActiveRecord::FixtureSet.identify(:library_view) %>
+  jenkins_instance_id: <%= ActiveRecord::FixtureSet.identify(:one) %>
+  environment_id: <%= ActiveRecord::FixtureSet.identify(:library) %>
+  manual_trigger: false
+  sync_trigger: false
+  levelup_trigger: true
+
+runs_on_first_publish:
+  name: "runs on publish/promote"
+  organization_id: <%= ActiveRecord::FixtureSet.identify(:empty_organization) %>
+  hostgroup_id: <%= ActiveRecord::FixtureSet.identify(:basic) %>
+  compute_resource_id: <%= ActiveRecord::FixtureSet.identify(:ec2) %>
+  content_view_id: <%= ActiveRecord::FixtureSet.identify(:no_environment_view) %>
+  jenkins_instance_id: <%= ActiveRecord::FixtureSet.identify(:one) %>
+  environment_id: <%= ActiveRecord::FixtureSet.identify(:library) %>
+  manual_trigger: false
+  sync_trigger: false
+  levelup_trigger: true

data/test/fixtures/pipeline_compute_attributes.yml

@@ -0,0 +1,20 @@
+simple:
+  compute_profile_id: <%= ActiveRecord::FixtureSet.identify(:small) %>
+  compute_resource_id: <%= ActiveRecord::FixtureSet.identify(:ec2) %>
+  vm_attrs:
+    flavor_id: m1.small
+    availability_zone: eu-west-1a
+
+intermediate:
+  compute_profile_id: <%= ActiveRecord::FixtureSet.identify(:big) %>
+  compute_resource_id: <%= ActiveRecord::FixtureSet.identify(:ec2) %>
+  vm_attrs:
+    cpus: 2
+    memory: 536870912
+
+advanced:
+  compute_profile_id: <%= ActiveRecord::FixtureSet.identify(:big) %>
+  compute_resource_id: <%= ActiveRecord::FixtureSet.identify(:one) %>
+  vm_attrs:
+    cpus: 2
+    memory: 536870912

data/test/fixtures/pipeline_compute_profiles.yml

@@ -0,0 +1,5 @@
+small:
+  name: small
+
+big:
+  name: big

data/test/fixtures/pipeline_hostgroups.yml

@@ -0,0 +1,25 @@
+basic:
+  name: Basic
+  architecture: x86_64
+  environment: production
+  operatingsystem: centos5_3
+  medium: one
+  puppet_proxy: puppetmaster
+  domain: mydomain
+  title: Basic
+  root_pass: $1$foreman$NW1XVtbk4/XkJqmKNrFWV0
+  compute_profile_id: <%= ActiveRecord::FixtureSet.identify(:small) %>
+  lookup_value_matcher: hostgroup=Basic
+
+advanced:
+  name: Advanced
+  architecture: x86_64
+  environment: production
+  operatingsystem: centos5_3
+  medium: one
+  puppet_proxy: puppetmaster
+  domain: mydomain
+  title: advanced
+  root_pass: $1$foreman$NW1XVtbk4/XkJqmKNrFWV0
+  compute_profile_id: <%= ActiveRecord::FixtureSet.identify(:big) %>
+  lookup_value_matcher: hostgroup=Advanced

data/test/fixtures_support.rb

@@ -0,0 +1,17 @@
+module ForemanPipeline
+  module FixturesSupport
+    FIXTURE_CLASSES = {
+      :jobs => ForemanPipeline::Job,
+      :jenkins_instances => ForemanPipeline::JenkinsInstance,
+      :jenkins_users => ForemanPipeline::JenkinsUser,
+      :jenkins_projects => ForemanPipeline::JenkinsProject,
+      :pipeline_hostgroups => Hostgroup,
+      :pipeline_compute_profiles => ComputeProfile,
+      :pipeline_compute_attributes => ComputeAttribute,
+    }
+
+    def self.set_fixture_classes(test_class)
+      FIXTURE_CLASSES.each { |k, v| test_class.set_fixture_class(k => v) }
+    end
+  end
+end

data/test/{foreman_pipeline_plugin_test_helper.rb → foreman_pipeline_test_helper.rb}

@@ -5,6 +5,11 @@ FactoryGirl.definition_file_paths << File.join(File.dirname(__FILE__), 'factorie
 FactoryGirl.reload
 
 require "#{Katello::Engine.root}/test/support/fixtures_support"
+require "fixtures_support"
+
+require 'dynflow/testing'
+Mocha::Mock.send :include, Dynflow::Testing::Mimic
+require "#{Katello::Engine.root}/test/support/foreman_tasks/task"
 
 module FixtureTestCase
   extend ActiveSupport::Concern
@@ -17,16 +22,14 @@ module FixtureTestCase
     self.pre_loaded_fixtures = true
 
     Katello::FixturesSupport.set_fixture_classes(self)
+    ForemanPipeline::FixturesSupport.set_fixture_classes(self)
 
-    self.fixture_path = Dir.mktmpdir("katello_fixtures")
+    self.fixture_path = Dir.mktmpdir("pipeline_and_katello_fixtures")
     FileUtils.cp(Dir.glob("#{Katello::Engine.root}/test/fixtures/models/*"), self.fixture_path)
+    FileUtils.cp(Dir.glob("#{ForemanPipeline::Engine.root}/test/fixtures/*"), self.fixture_path)
     FileUtils.cp(Dir.glob("#{Rails.root}/test/fixtures/*"), self.fixture_path)
     fixtures(:all)
-    FIXTURES = load_fixtures
-
-    # load_permissions
-
-    Setting::Katello.load_defaults
+    FIXTURES = load_fixtures(ActiveRecord::Base)
   end
 
   module ClassMethods
@@ -42,9 +45,9 @@ class ActiveSupport::TestCase
 
   def get_organization(org = nil)
     saved_user = User.current
-    User.current = User.find(users(:admin))
+    User.current = User.find(users(:admin).id)
     org = org.nil? ? :empty_organization : org
-    organization = Organization.find(taxonomies(org.to_sym))
+    organization = Organization.find(taxonomies(org.to_sym).id)
     organization.stubs(:label_not_changed).returns(true)
     organization.setup_label_from_name
     organization.save!
@@ -52,3 +55,9 @@ class ActiveSupport::TestCase
     organization
   end
 end
+
+class ActionController::TestCase
+  def setup_engine_routes
+    @routes = ForemanPipeline::Engine.routes
+  end
+end

data/test/functional/foreman_pipeline/api/jenkins_users_controller_test.rb

@@ -0,0 +1,47 @@
+require "foreman_pipeline_test_helper"
+
+class ForemanPipeline::Api::JenkinsUsersControllerTest < ActionController::TestCase
+  setup do
+    setup_engine_routes
+    @org = get_organization
+    @user = ForemanPipeline::JenkinsUser.find(jenkins_users(:jenkins_user_one).id)
+  end
+
+  test "should get index" do
+    get :index, :organization_id => @org.id
+    assert_response :success
+    response = JSON.parse(@response.body)
+    assert_equal 1, response['total']
+    assert_equal @user.name, response['results'].first['name']
+  end
+
+  test "should get show" do
+    get :show, :organization_id => @org.id,
+               :id => @user.id
+    assert_response :success
+    resp = JSON.parse(@response.body)
+    assert_equal @user.name, resp['name']
+  end
+
+  test "should update jenkins user" do
+    put :update, :organization_id => @org.id,
+                 :id => @user.id,
+                 :jenkins_user => { :id => @user.id,
+                                    :name => "New username" }
+    assert_response :success
+  end
+
+  test "should create jenkins user" do
+    post :create, :organization_id => @org.id,
+                  :jenkins_user => { :name => "Brand new user",
+                                     :organization_id => @org.id,
+                                     :token => "AndTheSilenceGaveNoToken" }
+    assert_response :success
+  end
+
+  test "should destroy jenkins user" do
+    delete :destroy, :organization_id => @org.id,
+                     :id => @user.id
+    assert_response :success
+  end
+end

data/test/functional/foreman_pipeline/api/jobs_controller_test.rb

@@ -0,0 +1,186 @@
+require 'foreman_pipeline_test_helper'
+
+class ForemanPipeline::Api::JobsControllerTest < ActionController::TestCase
+   include ::Support::ForemanTasks::Task
+
+  setup do
+    stub_tasks!
+    setup_engine_routes
+    @job = jobs(:valid)
+    @org = get_organization
+  end
+
+  test "should get index" do
+    get :index, { :organization_id => @org.id}
+    assert_response :success
+    response = ActiveSupport::JSON.decode(@response.body)
+    assert_equal 4, response['total']
+    assert response['results'].map { |item| item['name'] }.include?("valid job")
+  end
+
+  test 'should get show' do
+    job = ForemanPipeline::Job.find(jobs(:valid).id)
+    get :show, { :organization_id => @org.id, :id => job.id }
+    assert_response :success
+    response = ActiveSupport::JSON.decode(@response.body)
+    assert_equal job.name, response['name']
+  end
+
+  test 'should create new job' do
+    post :create, :organization_id => @org.id,
+                  :job => { :name => "new job",
+                            :manual_trigger => false,
+                            :levelup_trigger => false,
+                            :sync_trigger => false }
+    assert_response :success
+  end
+
+  test 'should not create new job without name' do
+    post :create, :organization_id => @org.id,
+                  :job => { :manual_trigger => false,
+                            :levelup_trigger => false,
+                            :sync_trigger => false }
+    assert_response :unprocessable_entity
+    response = ActiveSupport::JSON.decode(@response.body)
+    assert_equal ["can't be blank"], response['errors']['name']
+  end
+
+  test 'should update job' do
+    put :update, :organization_id => @org.id,
+                  :job => { :id => @job.id,
+                            :name => "updated job",
+                            :manual_trigger => true,
+                            :levelup_trigger => false,
+                            :sync_trigger => false },
+                  :id => @job.id
+    assert_response :success
+  end
+
+  test 'should not update job with nil as a name' do
+    put :update, :organization_id => @org.id,
+                  :job => { :id => @job.id,
+                            :name => nil,
+                            :manual_trigger => true,
+                            :levelup_trigger => false,
+                            :sync_trigger => false },
+                  :id => @job.id
+    assert_response :unprocessable_entity
+  end
+
+  test 'should delete job' do
+    delete :destroy, :organization_id => @org.id,
+                     :id => @job.id
+    assert_response :success
+  end
+
+  test 'should set content view' do
+    cv_id = katello_content_views(:acme_default).id
+    put :set_content_view, :organization_id => @org.id,
+                           :id => @job.id,
+                           :content_view_id => cv_id
+    assert_response :success
+  end
+
+  test 'should set hostgroup' do
+    hg_id = pipeline_hostgroups(:basic).id
+    put :set_hostgroup, :organization_id => @org.id,
+                        :id => @job.id,
+                        :hostgroup_id => hg_id
+    assert_response :success
+  end
+
+  test 'should set jenkins' do
+    jenkins_id = jenkins_instances(:one).id
+    put :set_jenkins, :organization_id => @org.id,
+                      :id => @job.id,
+                      :jenkins_instance_id => jenkins_id
+    assert_response :success
+  end
+
+  test 'should set environment' do
+    env_id = katello_environments(:library).id
+    put :set_environment, :organization_id => @org.id,
+                          :id => @job.id,
+                          :environment_id => env_id
+    assert_response :success
+  end
+
+  test "should set compute resource" do
+    compute_id = compute_resources(:ec2).id
+    put :set_resource, :organization_id => @org.id,
+                        :id => @job.id,
+                        :resource_id => compute_id
+    assert_response :success
+  end
+
+  test "should not set compute resource" do
+    compute_id = compute_resources(:mycompute).id
+    put :set_resource, :organization_id => @org.id,
+                       :id => @job.id,
+                       :resource_id => compute_id
+    assert_response :unprocessable_entity
+    message = "Cannot add a Compute resource that is not associated with assigned Hostgroup through a Compute profile"
+    assert_equal message, JSON.parse(@response.body)['errors']['base'].first
+  end
+
+  test "should set to_environments" do
+    ids = [katello_environments(:dev).id, katello_environments(:staging).id]
+    put :set_to_environments, :organization_id => @org.id,
+                              :id => @job.id,
+                              :to_environment_ids => ids
+    assert_response :success
+  end
+
+  test "should not set to_environments and detect env succession violation" do
+    ids = [katello_environments(:beta).id]
+    put :set_to_environments, :organization_id => @org.id,
+                              :id => @job.id,
+                              :to_environment_ids => ids
+    assert_response :unprocessable_entity
+  end
+
+  test "should set empty to_environments" do
+    put :set_to_environments, :organization_id => @org.id,
+                              :id => @job.id,
+                              :to_environment_ids => []
+    assert_response :success
+  end
+
+  test "should list available paths" do
+    get :available_paths, :organization_id => @org.id,
+                          :id => @job.id
+    resp = JSON.parse(@response.body)
+    assert_equal "Dev", resp['results'].first['environments'][1]['name']
+    assert_equal 4, resp['results'].count
+  end
+
+  test "should list available resources" do
+    get :available_resources, :organization_id => @org.id,
+                              :id => @job.id
+    resp = JSON.parse(@response.body)
+    assert_equal 1, resp.count
+  end
+
+  test "should run job" do
+    get :run_job, :organization_id => @org.id,
+                  :id => @job.id
+    assert_equal "", @response.body
+    assert_response :success
+  end
+
+  test "should add jenkins projects" do
+    assert_sync_task(::Actions::ForemanPipeline::Jenkins::GetBuildParams, :job_id => @job.id, :name => "foo")
+    put :add_projects, :organization_id => @org.id,
+                       :id => @job.id,
+                       :projects => ["foo"]
+    assert_response :success
+  end
+
+  test "remove jenkins projects" do
+    ids = [jenkins_projects(:first).id, jenkins_projects(:second).id]
+    put :remove_projects, :organization_id => @org.id,
+                          :id => @job.id,
+                          :projects => ids
+    assert_response :success
+  end
+end

data/test/{unit → models}/jenkins_instance_test.rb

@@ -1,4 +1,4 @@
-require 'foreman_pipeline_plugin_test_helper'
+require 'foreman_pipeline_test_helper'
 
 class JenkinsInstanceTest < ActiveSupport::TestCase
 

data/test/{unit → models}/job_test.rb

@@ -1,32 +1,21 @@
-require 'foreman_pipeline_plugin_test_helper'
+require 'foreman_pipeline_test_helper'
 
 class JobTest < ActiveSupport::TestCase
 
   def setup
     @organization = get_organization
     @compute_resource = FactoryGirl.create(:compute_resource, :libvirt)
-    @hostgroup = FactoryGirl.create(:pipeline_hostgroup)
+    @hostgroup = FactoryGirl.create(:hostgroup)
     @content_view = FactoryGirl.create(:katello_content_view)
     @jenkins_user = FactoryGirl.create(:jenkins_user, :organization => get_organization)
     @jenkins_instance = FactoryGirl.create(:jenkins_instance, :jenkins_user => @jenkins_user, :organization => get_organization)
     @environment = FactoryGirl.create(:katello_environment, :library)
   end
 
-  test "should validate host" do
-    job = ForemanPipeline::Job.create(:name => "test job",
-                                      :organization => @organization,
-                                      :hostgroup => @hostgroup,
-                                      :compute_resource => @compute_resource,
-                                      :content_view => @content_view,
-                                      :jenkins_instance => @jenkins_instance,
-                                      :environment => @environment)
-    assert job.is_valid?
-  end
-
   test "should find target cv" do
-    cv = Katello::ContentView.find(katello_content_views(:acme_default))
-    env = Katello::KTEnvironment.find(katello_environments(:library))
-    to_env = Katello::KTEnvironment.find(katello_environments(:dev))
+    cv = Katello::ContentView.find(katello_content_views(:acme_default).id)
+    env = Katello::KTEnvironment.find(katello_environments(:library).id)
+    to_env = Katello::KTEnvironment.find(katello_environments(:dev).id)
 
     job = ForemanPipeline::Job.create(:name => "test job",
                                       :organization => @organization,
@@ -41,8 +30,8 @@ class JobTest < ActiveSupport::TestCase
   end
 
   test "should not find target cv" do
-    cv = Katello::ContentView.find(katello_content_views(:acme_default))
-    env = Katello::KTEnvironment.find(katello_environments(:test))
+    cv = Katello::ContentView.find(katello_content_views(:acme_default).id)
+    env = Katello::KTEnvironment.find(katello_environments(:test).id)
 
     job = ForemanPipeline::Job.create(:name => "test job",
                                       :organization => @organization,
@@ -56,10 +45,10 @@ class JobTest < ActiveSupport::TestCase
   end
 
   test "should find envs for promotion" do
-    cv = Katello::ContentView.find(katello_content_views(:acme_default))
-    env = Katello::KTEnvironment.find(katello_environments(:library))
-    to_env = Katello::KTEnvironment.find(katello_environments(:dev))
-    to_env2 = Katello::KTEnvironment.find(katello_environments(:staging))
+    cv = Katello::ContentView.find(katello_content_views(:acme_default).id)
+    env = Katello::KTEnvironment.find(katello_environments(:library).id)
+    to_env = Katello::KTEnvironment.find(katello_environments(:dev).id)
+    to_env2 = Katello::KTEnvironment.find(katello_environments(:staging).id)
 
     job = ForemanPipeline::Job.create(:name => "test job",
                                       :organization => @organization,
@@ -73,10 +62,10 @@ class JobTest < ActiveSupport::TestCase
   end
 
   test "envs_for_promotion should exclude one env from promotions" do
-    cv = Katello::ContentView.find(katello_content_views(:library_dev_view))
-    env = Katello::KTEnvironment.find(katello_environments(:library))
-    to_env = Katello::KTEnvironment.find(katello_environments(:dev))
-    to_env2 = Katello::KTEnvironment.find(katello_environments(:staging))
+    cv = Katello::ContentView.find(katello_content_views(:library_dev_view).id)
+    env = Katello::KTEnvironment.find(katello_environments(:library).id)
+    to_env = Katello::KTEnvironment.find(katello_environments(:dev).id)
+    to_env2 = Katello::KTEnvironment.find(katello_environments(:staging).id)
 
     job = ForemanPipeline::Job.create(:name => "test job",
                                       :organization => @organization,
@@ -90,10 +79,10 @@ class JobTest < ActiveSupport::TestCase
   end
 
   test "job can be promoted" do
-    cv = Katello::ContentView.find(katello_content_views(:library_dev_view))
-    env = Katello::KTEnvironment.find(katello_environments(:library))
-    to_env = Katello::KTEnvironment.find(katello_environments(:dev))
-    to_env2 = Katello::KTEnvironment.find(katello_environments(:staging))
+    cv = Katello::ContentView.find(katello_content_views(:library_dev_view).id)
+    env = Katello::KTEnvironment.find(katello_environments(:library).id)
+    to_env = Katello::KTEnvironment.find(katello_environments(:dev).id)
+    to_env2 = Katello::KTEnvironment.find(katello_environments(:staging).id)
 
     job = ForemanPipeline::Job.create(:name => "test job",
                                       :organization => @organization,
@@ -107,9 +96,9 @@ class JobTest < ActiveSupport::TestCase
   end
 
   test "job cannot be promoted" do
-    cv = Katello::ContentView.find(katello_content_views(:library_dev_view))
-    env = Katello::KTEnvironment.find(katello_environments(:library))
-    to_env = Katello::KTEnvironment.find(katello_environments(:dev))
+    cv = Katello::ContentView.find(katello_content_views(:library_dev_view).id)
+    env = Katello::KTEnvironment.find(katello_environments(:library).id)
+    to_env = Katello::KTEnvironment.find(katello_environments(:dev).id)
 
     job = ForemanPipeline::Job.create(:name => "test job",
                                       :organization => @organization,
@@ -123,10 +112,10 @@ class JobTest < ActiveSupport::TestCase
   end
 
   test "is promotion safe" do
-    cv = Katello::ContentView.find(katello_content_views(:library_dev_view))
-    env = Katello::KTEnvironment.find(katello_environments(:library))
-    to_env = Katello::KTEnvironment.find(katello_environments(:dev))
-    to_env2 = Katello::KTEnvironment.find(katello_environments(:staging))
+    cv = Katello::ContentView.find(katello_content_views(:library_dev_view).id)
+    env = Katello::KTEnvironment.find(katello_environments(:library).id)
+    to_env = Katello::KTEnvironment.find(katello_environments(:dev).id)
+    to_env2 = Katello::KTEnvironment.find(katello_environments(:staging).id)
 
     job = ForemanPipeline::Job.create(:name => "test job",
                                       :organization => @organization,
@@ -140,8 +129,8 @@ class JobTest < ActiveSupport::TestCase
   end
 
   test "is not promotion safe" do
-    cv = Katello::ContentView.find(katello_content_views(:library_dev_view))
-    env = Katello::KTEnvironment.find(katello_environments(:library))
+    cv = Katello::ContentView.find(katello_content_views(:library_dev_view).id)
+    env = Katello::KTEnvironment.find(katello_environments(:library).id)
 
     job = ForemanPipeline::Job.create(:name => "test job",
                                       :organization => @organization,
@@ -154,9 +143,9 @@ class JobTest < ActiveSupport::TestCase
   end
 
   test "is not promotion safe again" do
-    cv = Katello::ContentView.find(katello_content_views(:library_dev_view))
-    env = Katello::KTEnvironment.find(katello_environments(:library))
-    to_env = Katello::KTEnvironment.find(katello_environments(:dev))
+    cv = Katello::ContentView.find(katello_content_views(:library_dev_view).id)
+    env = Katello::KTEnvironment.find(katello_environments(:library).id)
+    to_env = Katello::KTEnvironment.find(katello_environments(:dev).id)
 
     job = ForemanPipeline::Job.create(:name => "test job",
                                       :organization => @organization,
@@ -170,9 +159,9 @@ class JobTest < ActiveSupport::TestCase
   end
 
   test "should detect env succession violation" do
-    cv = Katello::ContentView.find(katello_content_views(:library_dev_view))
-    env = Katello::KTEnvironment.find(katello_environments(:library))
-    to_env = Katello::KTEnvironment.find(katello_environments(:test))
+    cv = Katello::ContentView.find(katello_content_views(:library_dev_view).id)
+    env = Katello::KTEnvironment.find(katello_environments(:library).id)
+    to_env = Katello::KTEnvironment.find(katello_environments(:test).id)
 
     job = ForemanPipeline::Job.new(:name => "test job",
                                       :organization => @organization,
@@ -186,9 +175,9 @@ class JobTest < ActiveSupport::TestCase
     assert_equal "Environment succession violation: #{to_env.name}", job.errors[:base].first
   end
 
-  test "was not yet promoted" do
-    cv = Katello::ContentView.find(katello_content_views(:library_dev_view))
-    env = Katello::KTEnvironment.find(katello_environments(:library))
+  test "was not yet promoted to given envs" do
+    cv = Katello::ContentView.find(katello_content_views(:library_dev_view).id)
+    env = Katello::KTEnvironment.find(katello_environments(:library).id)
     job = ForemanPipeline::Job.create(:name => "test job",
                                       :organization => @organization,
                                       :hostgroup => @hostgroup,
@@ -200,10 +189,26 @@ class JobTest < ActiveSupport::TestCase
     assert job.not_yet_promoted?
   end
 
+  test "was already promoted to all to_environments" do
+    cv = Katello::ContentView.find(katello_content_views(:library_dev_view).id)
+    to_env = Katello::KTEnvironment.find(katello_environments(:dev).id)
+    lib = Katello::KTEnvironment.find(katello_environments(:library).id)
+
+    job = ForemanPipeline::Job.create(:name => "test job",
+                                      :organization => @organization,
+                                      :hostgroup => @hostgroup,
+                                      :compute_resource => @compute_resource,
+                                      :content_view => cv,
+                                      :jenkins_instance => @jenkins_instance,
+                                      :environment => lib,
+                                      :to_environments => [to_env])
+    refute job.not_yet_promoted?
+  end
+
   test "there should be env for promotion" do
-    cv = Katello::ContentView.find(katello_content_views(:library_dev_view))
-    env = Katello::KTEnvironment.find(katello_environments(:dev))
-    to_env = Katello::KTEnvironment.find(katello_environments(:test))
+    cv = Katello::ContentView.find(katello_content_views(:library_dev_view).id)
+    env = Katello::KTEnvironment.find(katello_environments(:dev).id)
+    to_env = Katello::KTEnvironment.find(katello_environments(:test).id)
 
     job = ForemanPipeline::Job.create(:name => "test job",
                                       :organization => @organization,
@@ -217,10 +222,10 @@ class JobTest < ActiveSupport::TestCase
     assert_equal to_env, job.envs_for_promotion.first
   end
 
-  test "there shloud not be env for promotion" do
-    cv = Katello::ContentView.find(katello_content_views(:library_dev_view))
-    env = Katello::KTEnvironment.find(katello_environments(:library))
-    to_env = Katello::KTEnvironment.find(katello_environments(:dev))
+  test "there should not be env for promotion" do
+    cv = Katello::ContentView.find(katello_content_views(:library_dev_view).id)
+    env = Katello::KTEnvironment.find(katello_environments(:library).id)
+    to_env = Katello::KTEnvironment.find(katello_environments(:dev).id)
 
     job = ForemanPipeline::Job.create(:name => "test job",
                                       :organization => @organization,
@@ -232,4 +237,55 @@ class JobTest < ActiveSupport::TestCase
                                       :to_environments => [to_env])
     assert job.envs_for_promotion.empty?
   end
+
+  test "should not save job with composite view" do
+    composite = Katello::ContentView.find(katello_content_views(:composite_view).id)
+    job = ForemanPipeline::Job.new(:name => "test job",
+                                   :content_view => composite)
+    refute job.save
+    assert job.errors['base'].include? "Cannot add content view, only non-composites allowed."
+  end
+
+  test "should not save job where compute profile on hg is missing" do
+    job = ForemanPipeline::Job.create(:name => "test job",
+                                      :organization => @organization,
+                                      :hostgroup => @hostgroup,
+                                      :content_view => @content_view,
+                                      :jenkins_instance => @jenkins_instance,
+                                      :environment => @environment)
+    refute job.is_valid?
+  end
+
+  test "should not save job when compute resource is not available through hostgroup" do
+    job = ForemanPipeline::Job.create(:name => "test job",
+                                      :organization => @organization,
+                                      :hostgroup => Hostgroup.find(pipeline_hostgroups(:basic).id),
+                                      :compute_resource => @compute_resource,
+                                      :content_view => @content_view,
+                                      :jenkins_instance => @jenkins_instance,
+                                      :environment => @environment)
+    refute job.is_valid?
+  end
+
+  test "should find one compute resource available" do
+    job = ForemanPipeline::Job.create(:name => "test_job",
+                                      :organization => @organization,
+                                      :hostgroup => Hostgroup.find(pipeline_hostgroups(:basic).id))
+    assert_equal 1, job.available_compute_resources.count
+  end
+
+  test "should find two compute resources available" do
+    job = ForemanPipeline::Job.create(:name => "test_job",
+                                      :organization => @organization,
+                                      :hostgroup => Hostgroup.find(pipeline_hostgroups(:advanced).id))
+    assert_equal 2, job.available_compute_resources.count
+  end
+
+  test "should not save when hostgroup has no puppet env" do
+    job = ForemanPipeline::Job.new(:name => "test job",
+                                   :organization => @organization,
+                                   :hostgroup => @hostgroup)
+    refute job.save
+    assert job.errors.messages[:base].include? "Cannot add Hostgroup without Puppet environment"
+  end
 end