foreman_pipeline 0.0.11 → 0.1.0

data/app/models/foreman_pipeline/jenkins_project_param.rb

@@ -8,7 +8,6 @@ module ForemanPipeline
     self.inheritance_column = :_inheritance_type_disabled
     belongs_to :organization
     belongs_to :jenkins_project, :class_name => "ForemanPipeline::JenkinsProject"
-    attr_accessible :name, :type, :description, :value, :organization_id, :jenkins_project_id
 
     TYPES = ["string", "boolean", "text"]
     validates :type, :inclusion => { :in => TYPES }

data/app/models/foreman_pipeline/jenkins_user.rb

@@ -11,8 +11,6 @@ module ForemanPipeline
     validates :name, :presence => true
     validates :token, :presence => true
 
-    attr_accessible :name, :token, :organization_id
-
     scoped_search :on => :name, :complete_value => true
   end
 end

data/app/models/foreman_pipeline/job.rb

@@ -13,8 +13,8 @@ module ForemanPipeline
     belongs_to :jenkins_instance, :class_name => "ForemanPipeline::JenkinsInstance"
     belongs_to :environment, :class_name => 'Katello::KTEnvironment'
 
-    has_many :job_jenkins_projects, :dependent => :destroy
-    has_many :jenkins_projects, :through => :job_jenkins_projects, :class_name => 'ForemanPipeline::JenkinsProject'
+    has_many :jenkins_projects, :class_name => 'ForemanPipeline::JenkinsProject'
+
     has_many :content_view_repositories, :class_name=> 'Katello::ContentViewRepository',
      :primary_key => :content_view_id, :foreign_key => :content_view_id
     has_many :repositories, :through => :content_view_repositories
@@ -24,10 +24,8 @@ module ForemanPipeline
 
     validates :name, :presence => true
     validates :organization, :presence => true
-    validate :no_composite_view, :check_env_succession
 
-    attr_accessible :name, :content_view_id, :hostgroup_id, :organization_id, :compute_resource_id, :jenkins_instance_id,
-      :environment_id, :manual_trigger, :levelup_trigger, :sync_trigger
+    validate :no_composite_view, :env_succession, :compute_resource_on_hg, :compute_profile_on_hg, :hg_with_puppet_env
 
     scoped_search :on => :name, :complete_value => true
     scoped_search :on => :organization_id, :complete_value => true
@@ -84,7 +82,9 @@ module ForemanPipeline
     end
 
     def available_compute_resources
-      hostgroup.compute_profile.compute_attributes.map(&:compute_resource) rescue []
+      return [] unless hostgroup
+      ids = ComputeAttribute.where(:compute_profile_id => hostgroup.compute_profile_id).pluck(:compute_resource_id).uniq
+      ComputeResource.where(:id => ids)
     end
 
     private
@@ -94,7 +94,7 @@ module ForemanPipeline
        "Cannot add content view, only non-composites allowed.") if !content_view.nil? && content_view.composite?
     end
 
-    def check_env_succession
+    def env_succession
       if environment && should_be_promoted?
         to_environments.each do |to_env|
           unless to_env.prior == environment
@@ -103,5 +103,21 @@ module ForemanPipeline
         end
       end
     end
+
+    def compute_profile_on_hg
+      errors.add(:base,
+        "Cannot add Hostgroup without Compute Profile") if hostgroup && hostgroup.compute_profile.nil?
+    end
+
+    def compute_resource_on_hg
+      if (hostgroup && compute_resource && !available_compute_resources.include?(compute_resource)) || (!hostgroup && compute_resource)
+        errors.add(:base,
+          "Cannot add a Compute resource that is not associated with assigned Hostgroup through a Compute profile")
+      end
+    end
+
+    def hg_with_puppet_env
+      errors.add(:base, "Cannot add Hostgroup without Puppet environment") if hostgroup && !hostgroup.environment
+    end
   end
-end
+end

data/app/models/foreman_pipeline/job_to_environment.rb

@@ -7,8 +7,6 @@ module ForemanPipeline
     belongs_to :organization
     validate :org_membership
 
-    attr_accessible :job_id, :environment_id, :organization_id
-
     private
 
     def org_membership

data/app/services/foreman_pipeline/job_filter.rb

@@ -0,0 +1,34 @@
+module ForemanPipeline
+  class JobFilter
+
+    def allow_run_for?(job)
+     allowed?(job) && job.target_cv_version_avail?
+    end
+
+    def allowed?(job)
+      job.is_valid? && job.not_yet_promoted?
+    end
+
+    def allowed_jobs_for_repo(repo)
+      jobs = ForemanPipeline::Job.where(:content_view_id => repo.content_view_ids)
+      jobs.select { |job| allow_run_for?(job) && job.sync_trigger }
+    end
+
+    def allowed_jobs_for_cvv(version)
+      jobs = ForemanPipeline::Job.where(:content_view_id => version.content_view_id)
+      jobs.select do |job|
+        allowed?(job) &&
+        job.levelup_trigger &&
+        version == job.target_cv_version
+      end
+    end
+
+    def allowed_jobs_for_cv(content_view)
+      content_view.jobs.select do |job|
+        allowed?(job) &&
+        job.environment.library? &&
+        job.levelup_trigger
+      end
+    end
+  end
+end

data/app/views/foreman/unattended/snippets/_jenkins_instance_pubkey.erb

@@ -1,10 +1,10 @@
-echo "running jenkins_pubkey snippet"
+echo "running pipeline_jenkins_pubkey snippet"
 mkdir -p /root/.ssh
 touch /root/.ssh/authorized_keys || exit
-echo "<%= @host.params['foreman_pipeline_jenkins_pubkey']%>" >> /root/.ssh/authorized_keys
+echo "<%= @host.params['pipeline_jenkins_pubkey']%>" >> /root/.ssh/authorized_keys
 
 <% if @host.operatingsystem.name.match(/centos/i) -%>
 restorecon -R -v /root/.ssh
 <% end -%>
 
-echo "jenkins_pubkey snippet done"
+echo "pipeline_jenkins_pubkey snippet done"

data/app/views/foreman_pipeline/api/jenkins_instances/show.json.rabl

@@ -1,6 +1,6 @@
 object @resource
 
-attributes :id, :name, :url, :organization_id, :server_version, :jenkins_home, :cert_path
+attributes :id, :name, :url, :organization_id, :server_version, :jenkins_home, :cert_path, :timeout
 
 child :jenkins_user => :jenkins_user do
   extends "foreman_pipeline/api/jenkins_users/show"

data/config/routes.rb

@@ -5,12 +5,8 @@ class ActionDispatch::Routing::Mapper
 end
 
 ForemanPipeline::Engine.routes.draw do
-
-
   scope :foreman_pipeline, :path => '/foreman_pipeline' do
-
     namespace :api do
-
       api_resources :organizations, :only => [] do
         api_resources :jobs do
           member do
@@ -37,16 +33,15 @@ ForemanPipeline::Engine.routes.draw do
 
         api_resources :jenkins_projects, :only => [:show, :update]
 
+        api_resources :jenkins_project_params, :only => [:update]
+
         api_resources :jenkins_requests, :only => [] do
           collection do
             get :list
           end
         end
 
-        api_resources :jenkins_project_params, :only => [:update]
-
         api_resources :jenkins_users, :only => [:index, :create, :destroy, :show, :update]
-
       end
     end
   end

data/db/migrate/20150209160604_add_jenkins_home_to_jenkins_instance_table.rb

@@ -1,6 +1,6 @@
 class AddJenkinsHomeToJenkinsInstanceTable < ActiveRecord::Migration
   def up
-    add_column :integration_jenkins_instances, :jenkins_home, :string, :null => false, :default => ""
+    add_column :integration_jenkins_instances, :jenkins_home, :string, :null => false, :default => "", :limit => 255
   end
 
   def down

data/db/migrate/20150213095447_add_cert_path_to_jenkins_instances.rb

@@ -1,6 +1,6 @@
 class AddCertPathToJenkinsInstances < ActiveRecord::Migration
   def up
-    add_column :integration_jenkins_instances, :cert_path, :string, :null => false, :default => "~/.ssh/id_rsa"
+    add_column :integration_jenkins_instances, :cert_path, :string, :null => false, :default => "~/.ssh/id_rsa", :limit => 255
   end
 
   def down

data/db/migrate/20150223142315_change_jenkins_instance_cert_path_column.rb

@@ -1,6 +1,6 @@
 class ChangeJenkinsInstanceCertPathColumn < ActiveRecord::Migration
   def up
-    change_column :integration_jenkins_instances, :cert_path, :string, :default => ""
+    change_column :integration_jenkins_instances, :cert_path, :string, :default => "", :limit => 255
   end
 
   def down

data/db/migrate/20150224090100_create_jenkins_projects_table.rb

@@ -3,13 +3,13 @@ class CreateJenkinsProjectsTable < ActiveRecord::Migration
     create_table "integration_jenkins_projects" do |t|
       t.string "name",                  :null => false
     end
-    
+
     create_table "integration_job_jenkins_projects" do |t|
-      t.integer "job_id"              
-      t.integer "jenkins_project_id" 
+      t.integer "job_id"
+      t.integer "jenkins_project_id"
       t.datetime "created_at",          :null => false
       t.datetime "updated_at",          :null => false
-    end    
+    end
   end
 
   def down

data/db/migrate/20160404102405_update_projects_table.rb

@@ -0,0 +1,9 @@
+class UpdateProjectsTable < ActiveRecord::Migration
+  def up
+    add_column :foreman_pipeline_jenkins_projects, :job_jenkins_project_id, :integer
+  end
+
+  def down
+    remove_column :foreman_pipeline_jenkins_projects, :job_jenkins_project_id
+  end
+end

data/db/migrate/20160404133012_drop_job_jenkins_project.rb

@@ -0,0 +1,30 @@
+class DropJobJenkinsProject < ActiveRecord::Migration
+  def up
+    jjps = execute("SELECT * FROM foreman_pipeline_job_jenkins_projects;")
+    add_column :foreman_pipeline_jenkins_projects, :job_id, :integer
+    jjps.each do |jjp|
+      project = ForemanPipeline::JenkinsProject.find(jjp['jenkins_project_id'])
+      project.job_id = jjp['job_id']
+      project.save!
+    end
+    remove_column :foreman_pipeline_jenkins_projects, :job_jenkins_project_id
+    drop_table :foreman_pipeline_job_jenkins_projects
+  end
+
+  def down
+    create_table :foreman_pipeline_job_jenkins_projects do |t|
+      t.integer :job_id
+      t.integer :jenkins_project_id
+      t.datetime :created_at,          :null => false
+      t.datetime :updated_at,          :null => false
+    end
+
+    add_column :foreman_pipeline_jenkins_projects, :job_jenkins_project_id, :integer
+    projects = execute("SELECT * FROM foreman_pipeline_jenkins_projects;")
+    projects.each do |project|
+      execute("INSERT INTO foreman_pipeline_job_jenkins_projects (job_id, jenkins_project_id, created_at, updated_at) VALUES (#{project['job_id']},#{project['id']},'#{Time.now}','#{Time.now}')")
+    end
+
+    remove_column :foreman_pipeline_jenkins_projects, :job_id
+  end
+end

data/db/migrate/20160629085119_add_timeout_to_jenkins_instance.rb

@@ -0,0 +1,9 @@
+class AddTimeoutToJenkinsInstance < ActiveRecord::Migration
+  def up
+    add_column :foreman_pipeline_jenkins_instances, :timeout, :integer, :default => 60
+  end
+
+  def down
+    remove_column :foreman_pipeline_jenkins_instances, :timeout
+  end
+end

data/db/seeds.d/location.rb

@@ -0,0 +1,9 @@
+loc = Location.find_or_create_by(:name => "foreman_pipeline")
+loc.organizations = Organization.all
+loc.environments = Environment.all
+loc.domains = Domain.all
+loc.media = Medium.all
+loc.subnets = Subnet.all
+loc.compute_resources = ComputeResource.all
+loc.smart_proxies = SmartProxy.all
+loc.save!

data/db/seeds.d/snippets.rb

@@ -0,0 +1,11 @@
+defaults = { :default => true, :locked => false }
+
+ProvisioningTemplate.without_auditing do
+  [
+    { :name => "pipeline_jenkins_pubkey", :source => "snippets/_jenkins_instance_pubkey.erb", :snippet => true }
+  ].each do |template|
+      next if ProvisioningTemplate.find_by_name(template[:name]).present?
+      template[:template] = File.read(File.join(ForemanPipeline::Engine.root, "app/views/foreman/unattended", template.delete(:source)))
+      ProvisioningTemplate.create(defaults.merge(template))
+    end
+end

data/lib/foreman_pipeline/engine.rb

@@ -81,8 +81,7 @@ module ForemanPipeline
 
 
     rake_tasks do
-      load "#{ForemanPipeline::Engine.root}/lib/foreman_pipeline/tasks/foreman_pipeline_seed.rake"
-      load "#{ForemanPipeline::Engine.root}/lib/foreman_pipeline/tasks/foreman_pipeline_test.rake"
+      load "#{ForemanPipeline::Engine.root}/lib/foreman_pipeline/tasks/test.rake"
     end
 
   end

data/lib/foreman_pipeline/plugin.rb

@@ -1,5 +1,5 @@
 Foreman::Plugin.register :foreman_pipeline do
-  requires_foreman '>= 1.11'
+  requires_foreman '>= 1.13'
 
   sub_menu :top_menu, :foreman_pipeline_menu, :caption => N_('Pipeline') do
     menu :top_menu,

data/lib/foreman_pipeline/roles.rb

@@ -2,12 +2,12 @@ require 'foreman_pipeline/plugin'
 
 viewer_permissions = [:view_jobs, :view_jenkins_instances, :view_jenkins_users,
                      :view_jenkins_projects, :view_jenkins_requests]
-manager_permissions = [:view_jobs, :edit_jobs, :destroy_jobs, :create_jobs, 
+manager_permissions = [:view_jobs, :edit_jobs, :destroy_jobs, :create_jobs,
                        :view_jenkins_instances, :edit_jenkins_instances, :destroy_jenkins_instances, :create_jenkins_instances,
                         :view_jenkins_users, :edit_jenkins_users, :destroy_jenkins_users, :create_jenkins_users,
                         :view_jenkins_projects,
-                        :edit_jenkins_project_params, 
+                        :edit_jenkins_project_params,
                         :view_jenkins_requests]
 
 Foreman::Plugin.find(:foreman_pipeline).send :role, "Pipeline viewer", viewer_permissions
-Foreman::Plugin.find(:foreman_pipeline).send :role, "Pipeline manager", manager_permissions
+Foreman::Plugin.find(:foreman_pipeline).send :role, "Pipeline manager", manager_permissions

data/lib/foreman_pipeline/skip_tests.rb

@@ -1,11 +1,13 @@
 require 'foreman_pipeline/plugin'
 
-#skipping Bastion routes as they have no permissions
+# skipping Bastion routes as they have no permissions
 tests_to_skip = {
   "AccessPermissionsTest" => ["route bastion/bastion/index should have a permission that grants access",
                               "route bastion/bastion/index_ie should have a permission that grants access",
-                              "route katello/api/v2/host_packages/auto_complete_search should have a permission that grants access"],
-#skipping seeds tests because katello adds its settings and we get 'unexpected invocation' for mock object
+                              "route katello/api/v2/host_packages/auto_complete_search should have a permission that grants access",
+                              "route katello/api/v2/host_subscriptions/create should have a permission that grants access",
+                              "route katello/api/v2/host_subscriptions/destroy should have a permission that grants access"],
+# skipping seeds tests because katello adds its settings and we get 'unexpected invocation' for mock object
   "SeedsTest" => ["all access permissions are created by permissions seed",
                   "doesn't add a template back that was deleted",
                   "doesn't add a template back that was renamed",
@@ -29,9 +31,9 @@ tests_to_skip = {
                      "used_and_selected_or_inherited_ids for inherited location"],
   "OrganizationTest" => ["name can be the same if parent is different",
                          ".my_organizations returns user's associated orgs and children"],
-#parent_id for organization is disabled by default
+# parent_id for organization is disabled by default
   "TaxonomixTest" => [".used_organization_ids can work with array of organizations"],
-#bunch of broken tests, various causes
+# bunch of broken tests, various causes
   "UserTest" => ["when a user logs in, last login time should be updated",
                  "return organization and child ids for non-admin user",
                  "#ensure_last_admin_is_not_deleted with non-admins",
@@ -73,7 +75,21 @@ tests_to_skip = {
                                     "should delete null organization",
                                     "should clear the session if the user deleted their current organization",
                                     "should clone organization with assocations"],
-  "UnattendedControllerTest" => ["template with hostgroup should be identified as hostgroup provisioning"]
+  "UnattendedControllerTest" => ["template with hostgroup should be identified as hostgroup provisioning"],
+
+# core compute resoure fixtures do not care about plugins
+  "ComputeResourceTest" => ["ensure compute resource with associated profile can get destroyed"],
+
+# katello uses keyword args, not compatible with 1.9.3
+  "AboutControllerTest" => ["test_index", "test_registered_providers_list"],
+# docker related
+  "ContainerStepsTest" => ["shows a link to a new compute resource if none is available",
+                           "shows taxonomies tabs"],
+
+  "OrganizationsControllerTest::wizard" => ["redirects to step 3 if no unassigned hosts exist",
+                                            "redirects to step 2 if unassigned hosts exist",
+                                            "redirects to step 3 if no permissins for hosts"],
+  "Api::V2::ContainersControllerTest::container operations" => ["creates a container with correct params"]
 }
 
 Foreman::Plugin.find(:foreman_pipeline).send :tests_to_skip, tests_to_skip

data/lib/foreman_pipeline/tasks/{foreman_pipeline_test.rake → test.rake}

@@ -1,11 +1,12 @@
 require File.expand_path("../engine", File.dirname(__FILE__))
 
 namespace :test do
-
+  desc "Run plugin test suite"
   task :foreman_pipeline => ['db:test:prepare'] do
     test_task = Rake::TestTask.new('foreman_pipeline_test_task') do |t|
       t.libs << ["test", "#{ForemanPipeline::Engine.root}/test"]
       t.test_files = ["#{ForemanPipeline::Engine.root}/test/**/*_test.rb"]
+      t.warning = false
       t.verbose = true
     end
     Rake::Task[test_task.name].invoke
@@ -21,4 +22,4 @@ if Rake::Task.task_defined?(:'jenkins:unit')
   Rake::Task["jenkins:unit"].enhance do
     Rake::Task['test:foreman_pipeline'].invoke
   end
-end
+end

data/lib/foreman_pipeline/version.rb

@@ -1,3 +1,3 @@
 module ForemanPipeline
-  VERSION = "0.0.11"
+  VERSION = "0.1.0"
 end

data/test/fixtures/jenkins_instances.yml

@@ -0,0 +1,8 @@
+one:
+  name: "jenkins.example.com"
+  url: "http://jenkins.example.com:3000"
+  organization_id: <%= ActiveRecord::FixtureSet.identify(:empty_organization) %>
+  pubkey: "sha-rsa 3gsdf5gsdf4g== jenkins@jenkins.example.com"
+  jenkins_home: "/var/lib/jenkins"
+  cert_path: "/tmp/my_certs"
+  jenkins_user_id: <%= ActiveRecord::FixtureSet.identify(:jenkins_user_one) %>

data/test/fixtures/jenkins_projects.yml

@@ -0,0 +1,9 @@
+first:
+  name: "first jenkins project"
+  organization_id: <%= ActiveRecord::FixtureSet.identify(:empty_organization) %>
+  job_id: <%= ActiveRecord::FixtureSet.identify(:valid)%>
+
+second:
+  name: "second jenkins project"
+  organization_id: <%= ActiveRecord::FixtureSet.identify(:empty_organization) %>
+  job_id: <%= ActiveRecord::FixtureSet.identify(:valid)%>

data/test/fixtures/jenkins_users.yml

@@ -0,0 +1,4 @@
+jenkins_user_one:
+  name: "Jenkins user"
+  token: "53asd74f6g6sd36gdsfg37d7fg3"
+  organization_id: <%= ActiveRecord::FixtureSet.identify(:empty_organization) %>