foreman_openscap 8.0.2 → 9.0.1

data/webpack/routes/OvalPolicies/OvalPoliciesShow/OvalPoliciesShowHelper.js

@@ -1,117 +0,0 @@
-import { translate as __, sprintf } from 'foremanReact/common/I18n';
-import { decodeModelId } from '../../../helpers/globalIdHelper';
-import { addSearch } from '../../../helpers/pageParamsHelper';
-import { newJobPath } from '../../../helpers/pathsHelper';
-
-export const policySchedule = policy => {
-  switch (policy.period) {
-    case 'weekly':
-      return sprintf(__('Weekly, on %s'), policy.weekday);
-    case 'monthly':
-      return sprintf(__('Monthly, day of month: %s'), policy.dayOfMonth);
-    case 'custom':
-      return sprintf(__('Custom cron: %s'), policy.cronLine);
-    default:
-      return __('Unknown schedule');
-  }
-};
-
-const targetingScopedSearchQuery = policy => {
-  const hgIds = policy.hostgroups.nodes.reduce((memo, hg) => {
-    const ids = [decodeModelId(hg)].concat(
-      hg.descendants.nodes.map(decodeModelId)
-    );
-    return ids.reduce(
-      (acc, id) => (acc.includes(id) ? acc : [...acc, id]),
-      memo
-    );
-  }, []);
-
-  if (hgIds.length === 0) {
-    return '';
-  }
-
-  return `hostgroup_id ^ (${hgIds.join(' ')})`;
-};
-
-export const newJobFormPath = (policy, policyId) =>
-  addSearch(newJobPath, {
-    feature: 'foreman_openscap_run_oval_scans',
-    host_ids: targetingScopedSearchQuery(policy),
-    'inputs[oval_policies]': policyId,
-  });
-
-const policyToAttrs = (policy, attrs) =>
-  Object.entries(policy).reduce((memo, [key, value]) => {
-    if (attrs.includes(key)) {
-      memo[key] = value;
-    }
-    return memo;
-  }, {});
-
-const onUpdateSuccess = (
-  closeEditable,
-  stopSubmitting,
-  showToast,
-  attr,
-  onValidationError
-) => result => {
-  const { errors } = result.data.updateOvalPolicy;
-  if (Array.isArray(errors) && errors.length > 0) {
-    stopSubmitting();
-    if (
-      errors.length === 1 &&
-      errors[0].path.join(' ') === `attributes ${attr}`
-    ) {
-      onValidationError(errors[0].message);
-    } else {
-      showToast({
-        type: 'error',
-        message: formatError(joinErrors(errors)),
-      });
-    }
-  } else {
-    closeEditable();
-    showToast({
-      type: 'success',
-      message: __('OVAL policy was successfully updated.'),
-    });
-  }
-};
-
-const formatError = error =>
-  sprintf(
-    __('There was a following error when updating OVAL policy: %s'),
-    error
-  );
-
-const joinErrors = errors => errors.map(err => err.message).join(', ');
-
-const onUpdateError = (showToast, stopSubmitting) => error => {
-  stopSubmitting();
-  showToast({ type: 'error', message: formatError(error.message) });
-};
-
-export const onAttrUpdate = (attr, policy, callMutation, showToast) => (
-  newValue,
-  closeEditable,
-  stopSubmitting,
-  onValidationError
-) => {
-  const vars = policyToAttrs(policy, ['id', 'name', 'description', 'cronLine']);
-  vars[attr] = newValue;
-  return (
-    callMutation({ variables: vars })
-      // eslint-disable-next-line promise/prefer-await-to-then
-      .then(
-        onUpdateSuccess(
-          closeEditable,
-          stopSubmitting,
-          showToast,
-          attr,
-          onValidationError
-        )
-      )
-      .catch(onUpdateError(showToast, stopSubmitting))
-  );
-};

data/webpack/routes/OvalPolicies/OvalPoliciesShow/__tests__/OvalPoliciesEdit.fixtures.js

@@ -1,48 +0,0 @@
-import { mockFactory } from '../../../../testHelper';
-import updateOvalPolicyMutation from '../../../../graphql/mutations/updateOvalPolicy.gql';
-import { ovalPolicy } from './OvalPoliciesShow.fixtures';
-
-const updateOvalPolicyMockFactory = mockFactory(
-  'updateOvalPolicy',
-  updateOvalPolicyMutation
-);
-
-export const updatedName = 'updated policy name';
-
-const variables = {
-  id: ovalPolicy.id,
-  name: updatedName,
-  cronLine: ovalPolicy.cronLine,
-  description: ovalPolicy.description,
-};
-const responsePolicy = {
-  ovalPolicy: {
-    __typename: 'ForemanOpenscap::OvalPolicy',
-    id: ovalPolicy.id,
-    name: updatedName,
-    description: ovalPolicy.description,
-    cronLine: ovalPolicy.cronLine,
-  },
-  errors: [],
-};
-
-export const policyUpdateMock = updateOvalPolicyMockFactory(
-  variables,
-  responsePolicy
-);
-
-export const policyUpdateErrorMock = updateOvalPolicyMockFactory(
-  variables,
-  responsePolicy,
-  { errors: [{ message: 'This is an unexpected failure.' }] }
-);
-
-export const policyUpdateValidationMock = updateOvalPolicyMockFactory(
-  variables,
-  {
-    ovalPolicy,
-    errors: [
-      { path: ['attributes', 'name'], message: 'has already been taken' },
-    ],
-  }
-);

data/webpack/routes/OvalPolicies/OvalPoliciesShow/__tests__/OvalPoliciesEdit.test.js

@@ -1,202 +0,0 @@
-import React from 'react';
-
-import { render, screen, waitFor } from '@testing-library/react';
-import '@testing-library/jest-dom';
-import userEvent from '@testing-library/user-event';
-
-import OvalPoliciesShow from '../';
-import {
-  historyMock,
-  ovalPolicyId,
-  policyDetailMock,
-  policyEditPermissionsMock,
-  ovalPolicy,
-} from './OvalPoliciesShow.fixtures';
-import {
-  policyUpdateMock,
-  policyUpdateErrorMock,
-  policyUpdateValidationMock,
-  updatedName,
-} from './OvalPoliciesEdit.fixtures';
-import { ovalPoliciesShowPath } from '../../../../helpers/pathsHelper';
-
-import {
-  withMockedProvider,
-  tick,
-  withRouter,
-  withRedux,
-} from '../../../../testHelper';
-
-import * as toasts from '../../../../helpers/toastHelper';
-
-const TestComponent = withRouter(
-  withRedux(withMockedProvider(OvalPoliciesShow))
-);
-
-describe('OvalPoliciesShow', () => {
-  it('should open and close inline edit for name', async () => {
-    render(
-      <TestComponent
-        history={historyMock}
-        match={{
-          params: { id: ovalPolicyId, tab: 'details' },
-          path: ovalPoliciesShowPath,
-        }}
-        mocks={policyDetailMock}
-      />
-    );
-    await waitFor(tick);
-    userEvent.click(screen.getByRole('button', { name: 'edit name' }));
-    userEvent.clear(screen.getByLabelText(/name text input/));
-    userEvent.type(screen.getByLabelText(/name text input/), 'foo');
-    expect(screen.getByLabelText(/name text input/)).toHaveAttribute(
-      'value',
-      'foo'
-    );
-    userEvent.click(
-      screen.getByRole('button', { name: 'cancel editing name' })
-    );
-    expect(screen.queryByText('foo')).not.toBeInTheDocument();
-  });
-  it('should update policy name', async () => {
-    const showToast = jest.fn();
-    jest.spyOn(toasts, 'showToast').mockImplementation(() => showToast);
-
-    const { container } = render(
-      <TestComponent
-        history={historyMock}
-        match={{
-          params: { id: ovalPolicyId, tab: 'details' },
-          path: ovalPoliciesShowPath,
-        }}
-        mocks={policyDetailMock.concat(policyUpdateMock)}
-      />
-    );
-    await waitFor(tick);
-    const editBtn = screen.getByRole('button', { name: 'edit name' });
-    expect(editBtn).toBeInTheDocument();
-    expect(
-      screen.queryByRole('button', { name: 'submit name' })
-    ).not.toBeInTheDocument();
-
-    userEvent.click(editBtn);
-    expect(
-      screen.queryByRole('button', { name: 'edit name' })
-    ).not.toBeInTheDocument();
-    const inputField = screen.getByLabelText(/name text input/);
-    const submitBtn = screen.getByRole('button', { name: 'submit name' });
-    const cancelBtn = screen.getByRole('button', {
-      name: 'cancel editing name',
-    });
-
-    userEvent.clear(inputField);
-    userEvent.type(inputField, updatedName);
-    userEvent.click(submitBtn);
-    expect(inputField).toBeDisabled();
-    expect(submitBtn).toBeDisabled();
-    expect(cancelBtn).toBeDisabled();
-    const spinner = container.querySelector('#edit-name-spinner');
-    expect(spinner).toBeInTheDocument();
-    await waitFor(tick);
-    expect(showToast).toHaveBeenCalledWith({
-      type: 'success',
-      message: 'OVAL policy was successfully updated.',
-    });
-
-    expect(inputField).not.toBeInTheDocument();
-    expect(editBtn).toBeInTheDocument();
-    expect(cancelBtn).not.toBeInTheDocument();
-    expect(
-      screen.queryByRole('button', { name: 'submit name' })
-    ).not.toBeInTheDocument();
-    await waitFor(tick);
-    expect(screen.getAllByText(updatedName).pop()).toBeInTheDocument();
-  });
-  it('should show unexpected errors', async () => {
-    const showToast = jest.fn();
-    jest.spyOn(toasts, 'showToast').mockImplementation(() => showToast);
-
-    render(
-      <TestComponent
-        history={historyMock}
-        match={{
-          params: { id: ovalPolicyId, tab: 'details' },
-          path: ovalPoliciesShowPath,
-        }}
-        mocks={policyDetailMock.concat(policyUpdateErrorMock)}
-      />
-    );
-    await waitFor(tick);
-    const editBtn = screen.getByRole('button', { name: 'edit name' });
-    userEvent.click(editBtn);
-    const inputField = screen.getByLabelText(/name text input/);
-    userEvent.clear(inputField);
-    userEvent.type(inputField, updatedName);
-    userEvent.click(screen.getByRole('button', { name: 'submit name' }));
-    await waitFor(tick);
-    expect(showToast).toHaveBeenCalledWith({
-      type: 'error',
-      message:
-        'There was a following error when updating OVAL policy: This is an unexpected failure.',
-    });
-    expect(inputField).toBeInTheDocument();
-    expect(inputField).not.toBeDisabled();
-    expect(screen.getByText(ovalPolicy.name)).toBeInTheDocument();
-  });
-  it('should show validation errors', async () => {
-    const showToast = jest.fn();
-    jest.spyOn(toasts, 'showToast').mockImplementation(() => showToast);
-
-    const { container } = render(
-      <TestComponent
-        history={historyMock}
-        match={{
-          params: { id: ovalPolicyId, tab: 'details' },
-          path: ovalPoliciesShowPath,
-        }}
-        mocks={policyDetailMock.concat(policyUpdateValidationMock)}
-      />
-    );
-    await waitFor(tick);
-    const editBtn = screen.getByRole('button', { name: 'edit name' });
-    userEvent.click(editBtn);
-    const inputField = screen.getByLabelText(/name text input/);
-    userEvent.clear(inputField);
-    userEvent.type(inputField, updatedName);
-    userEvent.click(screen.getByRole('button', { name: 'submit name' }));
-    await waitFor(tick);
-    expect(inputField).toBeInTheDocument();
-    expect(inputField).not.toBeDisabled();
-    expect(
-      container.querySelector('#edit-name-spinner')
-    ).not.toBeInTheDocument();
-    expect(screen.getByText(ovalPolicy.name)).toBeInTheDocument();
-    expect(screen.getByText('has already been taken')).toBeInTheDocument();
-    userEvent.click(
-      screen.getByRole('button', { name: 'cancel editing name' })
-    );
-    userEvent.click(editBtn);
-    expect(
-      screen.queryByText('has already been taken')
-    ).not.toBeInTheDocument();
-  });
-  it('should not show edit btns when user is not allowed to edit', async () => {
-    render(
-      <TestComponent
-        history={historyMock}
-        match={{
-          params: { id: ovalPolicyId, tab: 'details' },
-          path: ovalPoliciesShowPath,
-        }}
-        mocks={policyEditPermissionsMock}
-      />
-    );
-    await waitFor(tick);
-    expect(
-      screen.queryByRole('button', { name: 'edit name' })
-    ).not.toBeInTheDocument();
-    expect(
-      screen.queryByRole('button', { name: 'edit description' })
-    ).not.toBeInTheDocument();
-  });
-});

data/webpack/routes/OvalPolicies/OvalPoliciesShow/__tests__/OvalPoliciesShow.fixtures.js

@@ -1,124 +0,0 @@
-import { mockFactory, admin, intruder, viewer } from '../../../../testHelper';
-import ovalPolicyQuery from '../../../../graphql/queries/ovalPolicy.gql';
-import cvesQuery from '../../../../graphql/queries/cves.gql';
-import hostgroupsQuery from '../../../../graphql/queries/hostgroups.gql';
-
-const policyDetailMockFactory = mockFactory('ovalPolicy', ovalPolicyQuery);
-const cvesMockFactory = mockFactory('cves', cvesQuery);
-const hostgroupsMockFactory = mockFactory('hostgroups', hostgroupsQuery);
-
-export const ovalPolicy = {
-  __typename: 'ForemanOpenscap::OvalPolicy',
-  id: 'MDE6Rm9yZW1hbk9wZW5zY2FwOjpPdmFsUG9saWN5LTM=',
-  name: 'Third policy',
-  period: 'weekly',
-  cronLine: null,
-  weekday: 'tuesday',
-  dayOfMonth: null,
-  description: 'A very strict policy',
-  meta: {
-    canEdit: true,
-  },
-  hostgroups: {
-    nodes: [
-      {
-        id: 'MDE6SG9zdGdyb3VwLTQ=',
-        name: 'oval hg',
-        descendants: {
-          nodes: [
-            { id: 'MDE6SG9zdGdyb3VwLTEw' },
-            { id: 'MDE6SG9zdGdyb3VwLTEy' },
-            { id: 'MDE6SG9zdGdyb3VwLTEx' },
-          ],
-        },
-      },
-    ],
-  },
-};
-
-const noEditPolicy = { ...ovalPolicy, meta: { canEdit: false } };
-
-const cvesResult = {
-  totalCount: 1,
-  nodes: [
-    {
-      id: 'MDE6Rm9yZW1hbk9wZW5zY2FwOjpDdmUtMjY3',
-      refId: 'CVE-2020-14365',
-      refUrl: 'https://access.redhat.com/security/cve/CVE-2020-14365',
-      definitionId: 'oval:com.redhat.rhsa:def:20203601',
-      hasErrata: true,
-      hosts: {
-        nodes: [
-          {
-            id: 'MDE6SG9zdC0z',
-            name: 'centos-random.example.com',
-          },
-        ],
-      },
-    },
-  ],
-};
-
-const hostgroupsResult = {
-  totalCount: 2,
-  nodes: [
-    {
-      id: 'MDE6SG9zdGdyb3VwLTQ=',
-      name: 'first hostgroup',
-    },
-    {
-      id: 'MDE6SG9zdGdyb3VwLTEy',
-      name: 'second hostgroup',
-    },
-  ],
-};
-
-export const ovalPolicyId = 3;
-
-export const pushMock = jest.fn();
-
-export const historyMock = {
-  location: {
-    search: '',
-  },
-  push: pushMock,
-};
-
-export const historyWithSearch = {
-  location: {
-    search: '?page=1&perPage=5',
-  },
-};
-
-export const policyDetailMock = policyDetailMockFactory(
-  { id: ovalPolicy.id },
-  ovalPolicy,
-  { currentUser: admin }
-);
-
-export const policyUnauthorizedMock = policyDetailMockFactory(
-  { id: ovalPolicy.id },
-  ovalPolicy,
-  { currentUser: intruder }
-);
-
-export const policyCvesMock = cvesMockFactory(
-  { search: `oval_policy_id = ${ovalPolicyId}`, first: 5, last: 5 },
-  cvesResult,
-  { currentUser: admin }
-);
-export const policyHostgroupsMock = hostgroupsMockFactory(
-  { search: `oval_policy_id = ${ovalPolicyId}`, first: 5, last: 5 },
-  hostgroupsResult,
-  { currentUser: admin }
-);
-export const policyHostgroupsDeniedMock = hostgroupsMockFactory(
-  { search: `oval_policy_id = ${ovalPolicyId}`, first: 5, last: 5 },
-  { totalCount: 0, nodes: [] },
-  { currentUser: intruder }
-);
-export const policyEditPermissionsMock = policyDetailMockFactory(
-  { id: ovalPolicy.id },
-  noEditPolicy,
-  { currentUser: viewer }
-);

data/webpack/routes/OvalPolicies/OvalPoliciesShow/__tests__/OvalPoliciesShow.test.js

@@ -1,172 +0,0 @@
-import React from 'react';
-import { Router } from 'react-router-dom';
-import { render, screen, waitFor } from '@testing-library/react';
-import { within } from '@testing-library/dom';
-import '@testing-library/jest-dom';
-import userEvent from '@testing-library/user-event';
-import { createMemoryHistory } from 'history';
-
-import OvalPoliciesShow from '../index';
-import {
-  ovalPoliciesShowPath,
-  resolvePath,
-} from '../../../../helpers/pathsHelper';
-
-import {
-  withRedux,
-  withMockedProvider,
-  tick,
-  withRouter,
-} from '../../../../testHelper';
-import {
-  policyDetailMock,
-  historyMock,
-  historyWithSearch,
-  pushMock,
-  policyCvesMock,
-  policyHostgroupsMock,
-  policyHostgroupsDeniedMock,
-  ovalPolicyId,
-  policyUnauthorizedMock,
-} from './OvalPoliciesShow.fixtures';
-
-const TestComponent = withRedux(
-  withRouter(withMockedProvider(OvalPoliciesShow))
-);
-
-describe('OvalPoliciesShow', () => {
-  it('should load details by default and handle tab change', async () => {
-    const { container } = render(
-      <TestComponent
-        history={historyMock}
-        match={{ params: { id: ovalPolicyId }, path: ovalPoliciesShowPath }}
-        mocks={policyDetailMock}
-      />
-    );
-    expect(screen.getByText('Loading')).toBeInTheDocument();
-    await waitFor(tick);
-    expect(screen.queryByText('Loading')).not.toBeInTheDocument();
-    expect(screen.getAllByText('Third policy').pop()).toBeInTheDocument();
-    expect(screen.getByText('Weekly, on tuesday')).toBeInTheDocument();
-    expect(screen.getByText('A very strict policy')).toBeInTheDocument();
-    const activeTabHeader = container.querySelector(
-      '.pf-c-tabs__item.pf-m-current'
-    );
-    expect(within(activeTabHeader).getByText('Details')).toBeInTheDocument();
-    userEvent.click(screen.getByRole('tab', { name: 'CVEs' }));
-    expect(pushMock).toHaveBeenCalledWith(
-      resolvePath(ovalPoliciesShowPath, {
-        ':id': ovalPolicyId,
-        ':tab?': 'cves',
-      })
-    );
-  });
-  it('should load details tab when specified in URL', async () => {
-    render(
-      <TestComponent
-        history={historyMock}
-        match={{
-          params: { id: ovalPolicyId, tab: 'details' },
-          path: ovalPoliciesShowPath,
-        }}
-        mocks={policyDetailMock}
-      />
-    );
-    expect(screen.getByText('Loading')).toBeInTheDocument();
-    await waitFor(tick);
-    expect(screen.queryByText('Loading')).not.toBeInTheDocument();
-    expect(screen.getByText('Weekly, on tuesday')).toBeInTheDocument();
-  });
-  it('should not load the page when user does not have permissions', async () => {
-    render(
-      <TestComponent
-        history={historyMock}
-        match={{ params: { id: ovalPolicyId }, path: ovalPoliciesShowPath }}
-        mocks={policyUnauthorizedMock}
-      />
-    );
-    await waitFor(tick);
-    expect(screen.queryByText('Loading')).not.toBeInTheDocument();
-    expect(
-      screen.getByText(
-        'You are not authorized to view the page. Request the following permissions from administrator: view_oval_policies.'
-      )
-    ).toBeInTheDocument();
-  });
-  it('should load CVEs tab when specified in URL', async () => {
-    const mocks = policyDetailMock.concat(policyCvesMock);
-    render(
-      <TestComponent
-        history={historyWithSearch}
-        match={{
-          params: { id: ovalPolicyId, tab: 'cves' },
-          path: ovalPoliciesShowPath,
-        }}
-        mocks={mocks}
-      />
-    );
-    expect(screen.getByText('Loading')).toBeInTheDocument();
-    await waitFor(tick);
-    await waitFor(tick);
-    expect(screen.queryByText('Loading')).not.toBeInTheDocument();
-    expect(screen.getByText('CVE-2020-14365')).toBeInTheDocument();
-  });
-  it('should have button for scanning all hostgroups', async () => {
-    const btnText = 'Scan All Hostgroups';
-
-    const WithProvider = withRedux(withMockedProvider(OvalPoliciesShow));
-    const history = createMemoryHistory();
-    history.push = jest.fn();
-
-    render(
-      <Router history={history}>
-        <WithProvider
-          history={history}
-          match={{ params: { id: ovalPolicyId }, path: ovalPoliciesShowPath }}
-          mocks={policyDetailMock}
-        />
-      </Router>
-    );
-    await waitFor(tick);
-    expect(screen.queryByText('Loading')).not.toBeInTheDocument();
-    expect(screen.getByText(btnText)).toBeInTheDocument();
-    userEvent.click(screen.getByRole('button', { name: btnText }));
-    expect(history.push).toHaveBeenCalledWith(
-      '/job_invocations/new?feature=foreman_openscap_run_oval_scans&host_ids=hostgroup_id+%5E+%284+10+12+11%29&inputs%5Boval_policies%5D=3'
-    );
-  });
-  it('should load hostgroups tab when specified in URL', async () => {
-    const mocks = policyDetailMock.concat(policyHostgroupsMock);
-    render(
-      <TestComponent
-        history={historyWithSearch}
-        match={{
-          params: { id: ovalPolicyId, tab: 'hostgroups' },
-          path: ovalPoliciesShowPath,
-        }}
-        mocks={mocks}
-      />
-    );
-    expect(screen.getByText('Loading')).toBeInTheDocument();
-    await waitFor(tick);
-    await waitFor(tick);
-    expect(screen.queryByText('Loading')).not.toBeInTheDocument();
-    expect(screen.getByText('first hostgroup')).toBeInTheDocument();
-  });
-  it('should not show hostgroups for a user without permissions', async () => {
-    const mocks = policyDetailMock.concat(policyHostgroupsDeniedMock);
-    render(
-      <TestComponent
-        history={historyWithSearch}
-        match={{
-          params: { id: ovalPolicyId, tab: 'hostgroups' },
-          path: ovalPoliciesShowPath,
-        }}
-        mocks={mocks}
-      />
-    );
-    await waitFor(tick);
-    await waitFor(tick);
-    expect(screen.getByText('Permission denied')).toBeInTheDocument();
-  });
-});

data/webpack/routes/OvalPolicies/OvalPoliciesShow/index.js

@@ -1,39 +0,0 @@
-import React from 'react';
-import PropTypes from 'prop-types';
-import { useQuery } from '@apollo/client';
-import { useDispatch } from 'react-redux';
-
-import { translate as __ } from 'foremanReact/common/I18n';
-import { showToast } from '../../../helpers/toastHelper';
-
-import OvalPoliciesShow from './OvalPoliciesShow';
-import { encodeId } from '../../../helpers/globalIdHelper';
-
-import ovalPolicy from '../../../graphql/queries/ovalPolicy.gql';
-
-const WrappedOvalPoliciesShow = props => {
-  const id = encodeId('ForemanOpenscap::OvalPolicy', props.match.params.id);
-
-  const useFetchFn = componentProps =>
-    useQuery(ovalPolicy, { variables: { id } });
-
-  const renameData = data => ({ policy: data.ovalPolicy });
-
-  return (
-    <OvalPoliciesShow
-      {...props}
-      fetchFn={useFetchFn}
-      renameData={renameData}
-      resultPath="ovalPolicy"
-      emptyStateTitle={__('No OVAL Policy found')}
-      permissions={['view_oval_policies']}
-      showToast={showToast(useDispatch())}
-    />
-  );
-};
-
-WrappedOvalPoliciesShow.propTypes = {
-  match: PropTypes.object.isRequired,
-};
-
-export default WrappedOvalPoliciesShow;